Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
> On Apr 11, 2019, at 11:07 PM, Jerin Jacob Kollanukkaran > wrote: > > > >> -Original Message- >> From: Yongseok Koh >> Sent: Friday, April 12, 2019 7:35 AM >> To: Pavan Nikhilesh Bhagavatula >> Cc: Thomas Monjalon ; dev ; Jerin >> Jacob Kollanukkaran ; jerinjac...@gmail.com >> Subj

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 7:35 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Thomas Monjalon ; dev ; Jerin > Jacob Kollanukkaran ; jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support > machine spec

Re: [dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode

2019-04-11 Thread Gagandeep Singh
> > > On 4/10/2019 12:12 PM, Gagandeep Singh wrote: > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Monday, April 8, 2019 6:47 PM > >> To: Gagandeep Singh ; dev@dpdk.org > >> Subject: [EXT] Re: [PATCH 01/13] net/enetc: support physical addressing > mode > >> > >> WARNING: Thi

Re: [dpdk-dev] [PATCH v3] vhost: fix null pointer checking

2019-04-11 Thread Tiwei Bie
On Thu, Apr 11, 2019 at 03:48:40PM +0100, Mohammad Abdul Awal wrote: > Null value for parameters will cause segfault. > > Fixes: d7280c9fff ("vhost: support selective datapath") > Fixes: 72e8543093 ("vhost: add API to get MTU value") > Fixes: a277c71598 ("vhost: refactor code structure") > Fixes:

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-11 Thread Tiwei Bie
On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: > Application should be able to obtain information like 'ifname' from > the 'vid' passed to 'destroy_connection' callback. Currently, all the > API calls with passed 'vid' fails with 'device not found'. > > Fixes: efba12a78ddf ("vhost:

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix return value check

2019-04-11 Thread Tiwei Bie
On Wed, Apr 10, 2019 at 02:44:05AM +, Chenbo Xia wrote: > Fix unchecked return value for fcntl. > > Coverity issue: 277210 > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo Xia > --- > drivers/net/virtio/virtio_user/vhost_user.c |

[dpdk-dev] [PATCH] doc: update ICE doc

2019-04-11 Thread Wenzhuo Lu
Update ICE document to describe a MDD event. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/ice.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 15c2766..666b1b2 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.

[dpdk-dev] [PATCH v3] net/ice: stop lldp by default

2019-04-11 Thread Qiming Yang
This patch stopped lldp by default to avoid the statistics error. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9d01018..b106ee9 100644 --- a/drivers/net/ice/i

Re: [dpdk-dev] [PATCH v2] net/i40e: fix scattered Rx enabling

2019-04-11 Thread Zhang, Qi Z
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, April 12, 2019 9:44 AM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/i40e: fix scattered Rx enabling > > Hi Qi, > > > -Original Message- > > From: Zhang, Qi Z > > Sent

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
> On Apr 11, 2019, at 1:12 PM, Yongseok Koh wrote: > >> >> On Apr 10, 2019, at 11:07 PM, Pavan Nikhilesh Bhagavatula >> wrote: >> >> Hi Yongseok, >> >>> -Original Message- >>> From: Yongseok Koh >>> Sent: Wednesday, April 10, 2019 11:08 PM >>> To: Pavan Nikhilesh Bhagavatula >>>

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
> On Apr 11, 2019, at 4:37 PM, Thomas Monjalon wrote: > > 10/04/2019 18:13, jerinjac...@gmail.com: >> From: Pavan Nikhilesh >> >> Currently, RTE_* flags are set based on the implementer ID but there might >> be some micro arch specific differences from the same vendor >> eg. CACHE_LINESIZE. A

[dpdk-dev] [PATCH 6/6] net/bnx2x: fix optic module verification

2019-04-11 Thread Rasesh Mody
Enable the optic module vendor and part number verification from driver by setting appropriate flags. Link handling module in conjunction with FW performs optic module verification. Without this fix the SFP is powered down and the link doesn't come up, if module verification is enforced in nvram s

[dpdk-dev] [PATCH 5/6] net/bnx2x: fix race for periodic flags

2019-04-11 Thread Rasesh Mody
The periodic callout function and the interrupt handler both modify the periodic flags. There is a possible race condition when an application is going through dev_stop()/dev_start() and an interrupt handler is invoked. We also need to ensure that periodic polling is not invoked in interrupt contex

[dpdk-dev] [PATCH 4/6] net/bnx2x: fix DMAE timeout

2019-04-11 Thread Rasesh Mody
From: Shahed Shaikh In some cases, DPKD application may send packets while PMD is going through load or unload flow. This causes firmware to access invalid/unallocated memory to process transmit buffer. Which results in error on PCI bus and chip further blocks access to host, causing a DMAE timeo

[dpdk-dev] [PATCH 2/6] net/bnx2x: fix memory leak

2019-04-11 Thread Rasesh Mody
From: Shahed Shaikh We allocate DMA memory but never free after using it. Add function to free DMA memory. Fixes: b5bf7719221d ("bnx2x: driver support routines") Cc: sta...@dpdk.org Signed-off-by: Shahed Shaikh --- drivers/net/bnx2x/bnx2x.c| 15 +++ drivers/net/bnx2x/bnx2x.h

[dpdk-dev] [PATCH 1/6] net/bnx2x: fix eth dev MTU

2019-04-11 Thread Rasesh Mody
Fix to update eth dev MTU for jumbo frames Fixes: 540a211084a7 ("bnx2x: driver core") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2

[dpdk-dev] [PATCH 3/6] net/bnx2x: fix ramrod timeout

2019-04-11 Thread Rasesh Mody
From: Shahed Shaikh There is a race condition while processing RAMROD completion in fast path queue through interrupt handler and polling method. Interrupt handler invoked from actual interrupt event and from RAMROD processing polling flow may create a situation where one flow will read and clea

Re: [dpdk-dev] [PATCH v2] net/i40e: fix scattered Rx enabling

2019-04-11 Thread Lu, Wenzhuo
Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, April 10, 2019 11:26 PM > To: Xing, Beilei ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix scattered Rx enabling > > No need to add additional vlan tag size for max pa

Re: [dpdk-dev] DPDK Release Status Meeting 11/4/2019

2019-04-11 Thread Rami Rosen
Hi, >* Coverity is up and there are already some fixes hit the mail list, >this is good progress, as a reminder, coverity dpdk project link: > https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview > (As of now link is not working for me but hopefully it will come back

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Thomas Monjalon
10/04/2019 18:13, jerinjac...@gmail.com: > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. Add support to set micro arch specific flags. I don't like how flag

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-11 Thread Thomas Monjalon
11/04/2019 14:37, Igor Russkikh: > On 10.04.2019 14:46, Thomas Monjalon wrote: > > 10/04/2019 13:18, Igor Russkikh: > >> MACSEC related device ops, API and parameters are taken from the > >> existing ixgbe PMD ops > > > > Please can you explain how it is related to rte_security? > > It is not. >

Re: [dpdk-dev] [PATCH] net/enic: fix VLAN inner type matching for older hardware

2019-04-11 Thread Ferruh Yigit
On 4/10/2019 6:35 AM, Hyong Youb Kim wrote: > The vlan pattern handler currently assumes the NIC always strips vlan > header from the L2 buffer, regardless of the vlan strip setting. But, > with older VIC models, the vlan header is actually present in the L2 > buffer if stripping is disabled. So in

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
> On Apr 10, 2019, at 11:07 PM, Pavan Nikhilesh Bhagavatula > wrote: > > Hi Yongseok, > >> -Original Message- >> From: Yongseok Koh >> Sent: Wednesday, April 10, 2019 11:08 PM >> To: Pavan Nikhilesh Bhagavatula >> Cc: Thomas Monjalon ; dev ; Jerin >> Jacob Kollanukkaran ; jerinjac..

[dpdk-dev] [PATCH 3/3] app/test/meson: auto detect number of cores

2019-04-11 Thread Aaron Conole
The arguments being passed will cause failures on laptops that have, for instance, 2 cores only. Most of the tests don't require more than a single core. Some require multiple cores (but those tests should be modified to 'SKIP' when the correct number of cores aren't available). The unit test re

[dpdk-dev] [PATCH 1/3] travis: enable ccache

2019-04-11 Thread Aaron Conole
We try to make the planet happy travis builds dpdk. Also, the 'sudo' flag was recently deprecated. Drop it. Suggested-by: Luca Boccassi Signed-off-by: Aaron Conole --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 3045eada5..

[dpdk-dev] [PATCH 2/3] travis: add a distinguisher to the 'extra' builds

2019-04-11 Thread Aaron Conole
This helps in two ways: 1. When looking at travis page for dpdk, it's a visual distinction 2. For ccache support, the build IDs include the 'env', so we get unique cache data. Signed-off-by: Aaron Conole --- .travis.yml | 16 1 file changed, 8 insertions(+), 8 deletion

[dpdk-dev] [PATCH 0/3] travis: enhancements for build (plus a meson fix)

2019-04-11 Thread Aaron Conole
This series improves the travis integration a bit, and adds the ability for the meson system to auto-detect the number of cores. Aaron Conole (3): travis: enable ccache travis: add a distinguisher to the 'extra' builds app/test/meson: auto detect number of cores .travis.yml | 19 +

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] app/testpmd: fix return value check

2019-04-11 Thread Ferruh Yigit
On 4/10/2019 5:34 AM, Rami Rosen wrote: > Fix unchecked return value issue for rte_eth_dev_configure. > > Coverity issue: 195021 > Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration") > Cc: sta...@dpdk.org > > Signed-off-by: Chenbo Xia > --- > > Acked-by: > Applied to dpdk-next-net/mas

Re: [dpdk-dev] [PATCH v4] app/testpmd: fix support of hex string parser for flow API

2019-04-11 Thread Ferruh Yigit
On 4/9/2019 9:41 AM, Wei Zhao wrote: > There is need for users to set configuration of HEX number for RSS > key. The key byte should be pass down as hex number not as char > string. This patch enable cmdline flow parse HEX number, > in order to not using string which pass ASIC number. > > Fixes: f

Re: [dpdk-dev] [PATCH] app/test/ipsec: fix logic around dequeue burst

2019-04-11 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Thursday, April 11, 2019 2:08 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com > Cc: Iremonger, Bernard ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/test/ipsec:

Re: [dpdk-dev] [PATCH] net/enic: fix raw item length check

2019-04-11 Thread Ferruh Yigit
On 4/9/2019 7:40 AM, Hyong Youb Kim wrote: > Currently, the raw item is always preceeded by a UDP header, and both > land in the L4 pattern buffer. So consider the UDP header size when > checking if the raw spec fits in the L4 buffer. > > Coverity issue: 336796 > Coverity issue: 336850 > Fixes: 47

[dpdk-dev] DPDK Release Status Meeting 11/4/2019

2019-04-11 Thread Ferruh Yigit
Minutes 11 April 2019 - Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Debian * Intel * Mellanox * RedHat Release Dates - * v19.05 dates: * RC1 is released on Friday, 5 April. * http://mails.dpdk.org/archives/announce/2019-April/000254.h

Re: [dpdk-dev] [dpdk-announce] release candidate 19.05-rc1

2019-04-11 Thread Ju-Hyoung Lee
Greeting, here is 19.05-rc1 test result. VERIFY-SRIOV-FAILSAFE-FOR-DPDK test failed at https://git.dpdk.org/dpdk/snapshot/dpdk-19.05-rc1.tar.xz (tagged for v19.05-rc1, 0507931311e4daf2468f2f7d1295e8a306662aad) There were a few patches for mlx5 and testpmd following, and VERIFY-SRIOV-FAILSAFE-F

Re: [dpdk-dev] [PATCH v4] meter: replace color definitions with rte_color values

2019-04-11 Thread Thomas Monjalon
11/04/2019 11:15, Jasvinder Singh: > This patch implements the changes proposed in the deprecation > note[1]. Replace multiple color definitions in various places such as > rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined > in rte_meter.h. > > This is simple search and replace exe

[dpdk-dev] [PATCH v3] vhost: fix null pointer checking

2019-04-11 Thread Mohammad Abdul Awal
Null value for parameters will cause segfault. Fixes: d7280c9fff ("vhost: support selective datapath") Fixes: 72e8543093 ("vhost: add API to get MTU value") Fixes: a277c71598 ("vhost: refactor code structure") Fixes: ca33faf9ef ("vhost: introduce API to fetch negotiated features") Fixes: eb3224745

Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure

2019-04-11 Thread Jens Freimann
On Thu, Apr 11, 2019 at 01:23:06PM +0300, Ilya Maximets wrote: Need to destroy allocated device if application fails to add new connection or we have fdset failure. Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") Fixes: efba12a78ddf ("vhost: add user callbacks for socket

[dpdk-dev] [PATCH v1 2/3] examples/fips_validation: fix cmac test failure

2019-04-11 Thread Marko Kovacevic
As a result of the cmac test running the test where PT len is 65536 it should give a result back to the user USER1: Error -1: Prepare op USER1: PT len 65536 as this MSG len is not supported. Issue was that the application was not freeing the op properly after a while causing the app to fail. CRYPT

[dpdk-dev] [PATCH v1 3/3] cryptodev: fix uninitialized session clear

2019-04-11 Thread Marko Kovacevic
added check to see if a session for a device has been initialised if it has return 0. Fixes: 5d6c73dd5938 ("cryptodev: add reference count to session private data") Cc: roy.fan.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Marko Kovacevic --- lib/librte_cryptodev/rte_cryptodev.c | 2 ++ 1

[dpdk-dev] [PATCH v1 1/3] examples/fips: fix hmac test failure

2019-04-11 Thread Marko Kovacevic
Application was failing as the HMAC and Plain SHA fips request files are similar in a way that they both have SHA- in the top section to determine the hash algo and hash sizes. And HMAC having the algo in the second line but the Plain SHA in the third meant that when the HMAC files was used once it

Re: [dpdk-dev] [PATCH v4 0/3] DMA map anonymous memory to eth devices

2019-04-11 Thread Ferruh Yigit
On 4/7/2019 6:02 AM, Shahaf Shuler wrote: > Small series to use the APIs introduced by commit c33a675b6276 ("bus: > introduce device level DMA memory mapping") > > On v4: > * simplify return logic from mbuf_pool_create. > * remove extern from mempools structure. > > On v3: > * remove redundan

Re: [dpdk-dev] [PATCH] vhost: fix device leak on connection add failure

2019-04-11 Thread David Marchand
On Thu, Apr 11, 2019 at 12:23 PM Ilya Maximets wrote: > Need to destroy allocated device if application fails to > add new connection or we have fdset failure. > > Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") > Fixes: efba12a78ddf ("vhost: add user callbacks for socket

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2019-04-11 Thread Pradeep Satyanarayana
> > The IBM Power team is not idle in this area. There's ongoing work to > > enable DTS on Power systems. > > Good to read there is some work in the pipe. > I can remember the first emails (in 2015) talking about some automated > tests for compilation and unit tests on IBM Power. Thomas, Unfort

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-11 Thread Paul E. McKenney
On Wed, Apr 10, 2019 at 06:20:04AM -0500, Honnappa Nagarahalli wrote: > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data >

[dpdk-dev] [PATCH] app/test/ipsec: fix logic around dequeue burst

2019-04-11 Thread Bernard Iremonger
Call rte_crypto_dequeue_burst() in a loop with a delay to ensure that all the packets are dequeued from the crtpto device. Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 42 +++

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-11 Thread Igor Russkikh
Hello Thomas, Thanks for the review! On 10.04.2019 14:46, Thomas Monjalon wrote: > 10/04/2019 13:18, Igor Russkikh: >> MACSEC related device ops, API and parameters are taken from the >> existing ixgbe PMD ops > > Please can you explain how it is related to rte_security? It is not. Do you mean

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value

2019-04-11 Thread Burakov, Anatoly
On 11-Apr-19 12:13 PM, Reshma Pattan wrote: Fix the data type of last_branches, last_branch_misses from unit32_t to uint64_t, and for hits_diff, miss_diff from int to int64_t respectively to fix possible overflow or truncation. Coverity issue: 337677 Fixes: 4b1a631b8a ("examples/vm_power: add oo

Re: [dpdk-dev] [PATCH v4 2/3] test/distributor: replace sync builtins with atomic builtins

2019-04-11 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Hunt, David > Sent: Wednesday, April 10, 2019 10:06 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > tho...@monjalon.net > Cc: reshma.pat...@intel.com; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH v4 2/3] tes

[dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value

2019-04-11 Thread Reshma Pattan
Fix the data type of last_branches, last_branch_misses from unit32_t to uint64_t, and for hits_diff, miss_diff from int to int64_t respectively to fix possible overflow or truncation. Coverity issue: 337677 Fixes: 4b1a631b8a ("examples/vm_power: add oob monitoring functions") CC: david.h...@intel.

[dpdk-dev] [PATCH 19.08] net/pcap: enable infinitely rxing a pcap file

2019-04-11 Thread Cian Ferriter
It can be useful to use pcap files for some rudimental performance testing. This patch enables this functionality in the pcap driver. At a high level, this works by creaing a ring of sufficient size to store the packets in the pcap file passed to the application. When the rx function for this mode

[dpdk-dev] [PATCH] vhost: fix device leak on connection add failure

2019-04-11 Thread Ilya Maximets
Need to destroy allocated device if application fails to add new connection or we have fdset failure. Fixes: acbff5c67ea7 ("vhost: fix crash when exceeding file descriptors") Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") Cc: sta...@dpdk.org Reported-by: David Marchand S

Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with rte_color values

2019-04-11 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 10, 2019 10:20 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v3] meter: replace color definitions with > rte_color values > > > > Th

[dpdk-dev] [PATCH v4] meter: replace color definitions with rte_color values

2019-04-11 Thread Jasvinder Singh
This patch implements the changes proposed in the deprecation note[1]. Replace multiple color definitions in various places such as rte_meter.h, rte_tm.h and rte_mtr.h with single rte_color defined in rte_meter.h. This is simple search and replace exercise without any implementation change. [1] h

Re: [dpdk-dev] [PATCH v6 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses

2019-04-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Wednesday, April 10, 2019 6:42 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v6 2/3] examples/l3fwd: use reserved IPv4/IPv6 > addresses > > The l3fwd exampl

[dpdk-dev] [PATCH] net/mlx5: fix RSS validation function

2019-04-11 Thread Ori Kam
The RSS validation function was missing the verifcation that if RSS is requested on inner packet, the flow must have tunnel data. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: sta...@dpdk.org Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5

Re: [dpdk-dev] [PATCH v6 1/3] app/testpmd: add ability to set Tx IP and UDP parameters

2019-04-11 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Wednesday, April 10, 2019 6:42 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v6 1/3] app/testpmd: add ability to set Tx IP and > UDP parameters > > This pat

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-11 Thread Ilya Maximets
On 10.04.2019 11:07, David Marchand wrote: > On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets > wrote: > > On 10.04.2019 10:24, David Marchand wrote: > > For vhost maintainers, looking at vhost_user_add_connection, aren't we > leaking a vid on errors ? either

Re: [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros

2019-04-11 Thread Luca Boccassi
On Wed, 2019-04-10 at 21:52 +0100, Bruce Richardson wrote: > In order to ensure good test coverage, we sometimes need to run > builds > on distros with older compilers, such as gcc 4.8 on RHEL/Centos 7. > This > patchset does a small amount of clean-up to test-meson-builds.sh > script > to allow it

Re: [dpdk-dev] ethdev flow director/filtering/steering API

2019-04-11 Thread Andrew Rybchenko
On 4/11/19 10:49 AM, Thomas Monjalon wrote: About the features called flow director, filtering or flow steering, we have some overlap in our API that we should clean. It is especially important when considering to freeze the API for stability. Please read this deprecation notice from December 20

Re: [dpdk-dev] [PATCH] reorder: add checks for invalid function inputs

2019-04-11 Thread Iremonger, Bernard
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, April 10, 2019 12:25 PM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Richardson, Bruce > > Subject: [PATCH] reorder: add checks for invalid function inputs > > For APIs which can return an error value, do sanity checking o

Re: [dpdk-dev] [PATCH v5 0/4] net/mlx: remove device register remap

2019-04-11 Thread Shahaf Shuler
Wednesday, April 10, 2019 9:41 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v5 0/4] net/mlx: remove device register remap > > This patchset lifts the requirement of reserving huge virtual address space > and remapping device UAR register on to it in order to use the same address > between primar

[dpdk-dev] ethdev flow director/filtering/steering API

2019-04-11 Thread Thomas Monjalon
About the features called flow director, filtering or flow steering, we have some overlap in our API that we should clean. It is especially important when considering to freeze the API for stability. Please read this deprecation notice from December 2016: * ethdev: the legacy filter API, includin

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2019-04-11 Thread David Marchand
Hello, On Tue, Apr 9, 2019 at 9:06 PM Vivian Kong wrote: > To build and run DPDK on Linux on IBM Z (s390x), big endian support > is added and s390x vector intrinics are used in the implementation > intrinsics* of DPDK libraries. > > I appreciate your feedback. > Quick check since this is not

Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-11 Thread Ye Xiaolong
On 04/11, David Marchand wrote: >Hello Xiaolong, > >On Thu, Apr 11, 2019 at 4:30 AM Ye Xiaolong wrote: > >> On 04/10, David Marchand wrote: >> >If we reserve N slots, but only submit n slots, we end up with an >> incorrect >> >opinion of the number of available slots later. >> >Either xsk_ring_pro

Re: [dpdk-dev] [PATCH] net/af_xdp: submit valid count to Tx queue

2019-04-11 Thread David Marchand
Hello Xiaolong, On Thu, Apr 11, 2019 at 4:30 AM Ye Xiaolong wrote: > On 04/10, David Marchand wrote: > >If we reserve N slots, but only submit n slots, we end up with an > incorrect > >opinion of the number of available slots later. > >Either xsk_ring_prod__submit should also update cached_prod

Re: [dpdk-dev] [PATCH v2] examples/multi_process: fix buffer underrun

2019-04-11 Thread Yongseok Koh
> On Apr 10, 2019, at 12:41 PM, Yongseok Koh wrote: > > For client_server_mp, the total number of buffers for the mbuf mempool > should be correctly calculated. Otherwise, having more clients will stop > traffic. > > Fixes: af75078fece3 ("first public release") > Cc: sta...@dpdk.org > > Signed-