[dpdk-dev] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr

2019-04-16 Thread Andy Pei
In rte_fpga_do_pr() function, if 'stat' returns error, rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been opened. After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns -EINVAL when 'stat' returns error Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus ra

Re: [dpdk-dev] [PATCH 3/9] net/mlx5: add Direct Rules configuration support

2019-04-16 Thread Ori Kam
Hi Koh, PSB > -Original Message- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 4:42 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 3/9] net/mlx5: add Direct Rules configuration support > > On Sun, A

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: update release notes for enetc PMD

2019-04-16 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 16, 2019 9:00 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: [EXT] Re: [PATCH] doc: update release notes for enetc PMD > > WARNING: This email was created outside of NXP. DO NOT CLICK links or > attachments unless you

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-16 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Shahaf Shuler > Sent: Wednesday, April 17, 2019 11:11 AM > To: Thomas Monjalon ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; Adrien Mazarguil > ; Hemant Agrawal > ; Shreyansh Jain ; John > Daley ; Hyong Youb Kim ; Gaetan > Rivet ; Beilei

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-16 Thread Andrew Rybchenko
On 4/17/19 8:41 AM, Shahaf Shuler wrote: Wednesday, April 17, 2019 3:36 AM, Thomas Monjalon: Subject: [PATCH] ethdev: deprecate legacy filter API As stated in the deprecation notice from December 2016, "the legacy filter API, including rte_eth_dev_filter_supported(), rte_eth_dev_filter_ctrl() a

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-16 Thread Shahaf Shuler
Wednesday, April 17, 2019 3:36 AM, Thomas Monjalon: > Subject: [PATCH] ethdev: deprecate legacy filter API > > As stated in the deprecation notice from December 2016, "the legacy filter > API, including rte_eth_dev_filter_supported(), > rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ET

Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

2019-04-16 Thread Ori Kam
PSB Thanks, Ori > -Original Message- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:01 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules > > On

Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

2019-04-16 Thread Ori Kam
> -Original Message- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 3:34 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with > Direct Rules > > > >

Re: [dpdk-dev] [PATCH] doc: update ICE doc

2019-04-16 Thread Lu, Wenzhuo
Hi Rami, From: Rami Rosen [mailto:ramir...@gmail.com] Sent: Tuesday, April 16, 2019 3:59 PM To: Lu, Wenzhuo Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc Hi, Wenzhuo, Regarding MDD for I40E, I am basing this on what I saw on the web regarding MDD on I40E: https://lists.o

[dpdk-dev] ABI and inline functions

2019-04-16 Thread Honnappa Nagarahalli
Hello, There was a conversation [1] in the context of RCU library. I thought it needs participation from broader audience. Summary for the context (please look at [1] for full details) 1) How do we provide ABI compatibility when the code base contains inline functions? Unless we freeze

Re: [dpdk-dev] [PATCH] net/mlx5: fix modify header action position

2019-04-16 Thread Ori Kam
PSB > -Original Message- > From: Yongseok Koh > Sent: Wednesday, April 17, 2019 2:42 AM > To: Ori Kam > Cc: Shahaf Shuler ; dev@dpdk.org; Dekel Peled > ; sta...@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix modify header action position > > On Sun, Apr 14, 2019 at 08:19:57PM +, Ori K

[dpdk-dev] [PATCH v6 2/3] test/rcu_qsbr: add API and functional tests

2019-04-16 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Konstantin Ananyev --- app/test/Makefile |2 +

[dpdk-dev] [PATCH v6 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

[dpdk-dev] [PATCH v6 3/3] doc/rcu: add lib_rcu documentation

2019-04-16 Thread Honnappa Nagarahalli
Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Marko Kovacevic --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 509 ++

[dpdk-dev] [PATCH v6 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

Re: [dpdk-dev] [PATCH v2 0/2] ice: fix wrong type and promisc mode

2019-04-16 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Wednesday, April 17, 2019 11:10 AM > To: Wang, Ying A ; Lu, Wenzhuo > ; Zhang, Qi Z > Cc: dev@dpdk.org; ramir...@gmail.com > Subject: RE: [PATCH v2 0/2] ice: fix wrong type and promisc mode > > > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH v2 0/2] ice: fix wrong type and promisc mode

2019-04-16 Thread Yang, Qiming
> -Original Message- > From: Wang, Ying A > Sent: Wednesday, April 17, 2019 9:48 AM > To: Lu, Wenzhuo ; Yang, Qiming > ; Zhang, Qi Z > Cc: dev@dpdk.org; ramir...@gmail.com; Wang, Ying A > > Subject: [PATCH v2 0/2] ice: fix wrong type and promisc mode > > Patch 1/2 modifies the variabl

[dpdk-dev] [PATCH v2 2/2] net/ice: fix promiscuous mode

2019-04-16 Thread Wang Ying A
When device promiscuous mode has already been enabled, should not return error if user re-enable it. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v2 1/2] net/ice: fix wrong type

2019-04-16 Thread Wang Ying A
Variable "status" should be defined as "enum ice_status" instead of "uint16_t". This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 8 1 file changed, 4 insertions(+), 4

[dpdk-dev] [PATCH v2 0/2] ice: fix wrong type and promisc mode

2019-04-16 Thread Wang Ying A
Patch 1/2 modifies the variable type of "status" from "uint16_t" to "enum ice_status ". Patch 2/2 adds a return value check to give user a correct prompt. V2: * For patch 1/2, change "int" to "enum ice_status"; fix some typo of the commit message and rename the patch title. For patch 2/2, make

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I think > > > > > > > > > > > you need to get rid of almost all use of inline and > > > > > > > > > > > visible structures. Yes it might be marginally > > > > > > > > > > > slower, but you thank me > > > > > the

Re: [dpdk-dev] [PATCH 3/9] net/mlx5: add Direct Rules configuration support

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 09:12:31PM +, Ori Kam wrote: > This commit provides the basic configuration needed in order to > support Direct Rules eswitch. What do you mean my "Direct Rules eswitch"? What is the official name of it? E-Switch is in HCA and DR is use by library? Then, shouldn't it be

Re: [dpdk-dev] [PATCH 1/2] net/ice: code clean

2019-04-16 Thread Wang, Ying A
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, April 15, 2019 8:44 PM > To: Wang, Ying A ; Lu, Wenzhuo > ; Yang, Qiming > Cc: dev@dpdk.org; Wang, Ying A ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/ice: code clean > > > > > -Original Message- > > From

[dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-16 Thread Thomas Monjalon
As stated in the deprecation notice from December 2016, "the legacy filter API, including rte_eth_dev_filter_supported(), rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow)".

Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

2019-04-16 Thread Yongseok Koh
> On Apr 16, 2019, at 5:01 PM, Yongseok Koh wrote: > > On Sun, Apr 14, 2019 at 09:12:30PM +, Ori Kam wrote: >> The meson build was missing the define for Direct Rules. And a typo in the title. menson -> meson Also would be better to use 'meson build' instead of 'meson compilation' "net/m

Re: [dpdk-dev] [PATCH 2/9] net/mlx5: fix menson compilation with Direct Rules

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 09:12:30PM +, Ori Kam wrote: > The meson build was missing the define for Direct Rules. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: or...@mellanox.com > > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/meson.build | 2 ++ > 1 file changed, 2 ins

Re: [dpdk-dev] [PATCH 1/9] net/mlx5: fix translate vport function name

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 09:12:29PM +, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. > > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") > Cc: viachesl...@mellanox.com > > Signed-off-by: Ori Kam > --- S

Re: [dpdk-dev] [PATCH] net/mlx5: fix modify header action position

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 08:19:57PM +, Ori Kam wrote: > According to RTE flow the action order should be the order that the > actions were given. > In the case of modify actions the position of the action was always > last. > > This commit solves this issue by saving the position of the first m

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 08:18:55PM +, Ori Kam wrote: > the flow group should be initialized. > For example selecting if the encapsulation is for root or private tables > is based on the flow->group value. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Signed-off-by: Ori Kam >

Re: [dpdk-dev] [PATCH] net/mlx5: fix release of jump to queue action

2019-04-16 Thread Yongseok Koh
On Sun, Apr 14, 2019 at 08:17:11PM +, Ori Kam wrote: > Currenlty the allocation of the jump to QP is done in flow apply, > this results in memory leak. > > This patch fixes this issue by moving the allocation and release of the > jump to QP action to the responsiblity of the hrxq. > > Fixes:

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error

2019-04-16 Thread David Christensen
In file included from drivers/pmd.cc:7:0: /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h: In function ‘int eth_dev_pci_specific_init(rte_eth_dev*, void*)’: /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:· error: invalid conversion from ‘void*’ to ‘rte_pci_device

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 16:56:32 + Honnappa Nagarahalli wrote: > > > > > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based > > > > > > > > > > > memory r

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 16:46:14 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > > Sent: Tuesday, April 16, 2019 5:40 PM > > To: Yigit, Ferruh ; David Christensen > > ; tho...@monjalon.net > > Cc: dev@dpdk.

[dpdk-dev] [Bug 255] Mbuf leak when rte_port_ethdev_writer_tx_bulk is called with more than 32 packets

2019-04-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=255 Bug ID: 255 Summary: Mbuf leak when rte_port_ethdev_writer_tx_bulk is called with more than 32 packets Product: DPDK Version: 18.05 Hardware: All OS: All

Re: [dpdk-dev] [PATCH] net: do not insert VLAN tag to shared mbufs

2019-04-16 Thread Chas Williams
On 4/16/19 12:28 PM, Bruce Richardson wrote: On Tue, Apr 16, 2019 at 04:51:26PM +0100, Ferruh Yigit wrote: The vlan_insert() is buggy when it tires to handle the shared mbufs, instead don't support inserting VLAN tag into shared mbufs and return an error for that case. Signed-off-by: Ferruh

Re: [dpdk-dev] [PATCH] net: do not insert VLAN tag to shared mbufs

2019-04-16 Thread Chas Williams
On 4/16/19 11:51 AM, Ferruh Yigit wrote: The vlan_insert() is buggy when it tires to handle the shared mbufs, s/tries/tries/ instead don't support inserting VLAN tag into shared mbufs and return an error for that case. Signed-off-by: Ferruh Yigit --- Cc: Stephen Hemminger Cc: Chas Willi

Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 5:48 PM, Thomas Monjalon wrote: > 12/04/2019 21:52, Yongseok Koh: >> >>> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko >>> wrote: >>> >>> At port detach routine after calling the rte_dev_remove() >>> testpmd performs some cleanup, checking the statuses of >>> remaining ports and

Re: [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for lcore_config

2019-04-16 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, April 10, 2019 10:46 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2 2/5] eal: add accessor functions for > lcore_config > > The fields of the internal EAL core configuration

Re: [dpdk-dev] [PATCH 0/3] net/ifc: SW relay improvement and fix

2019-04-16 Thread Ferruh Yigit
On 4/15/2019 8:56 AM, Xiao Wang wrote: > This patch set removes unnecessary relay on Tx queue and fixes 2 bugs to > improve stability. > > Xiao Wang (3): > net/ifc: do not relay for Tx queue > net/ifc: fix mediated vring initialization > net/ifc: fix used ring update Series applied to dpdk-

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Honnappa Nagarahalli
> > > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based > > > > > > > > > > memory reclamation > > > > > > > > > method. > > > > > > > > > > This library helps ident

Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup

2019-04-16 Thread Thomas Monjalon
12/04/2019 21:52, Yongseok Koh: > > > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko > > wrote: > > > > At port detach routine after calling the rte_dev_remove() > > testpmd performs some cleanup, checking the statuses of > > remaining ports and closes the appropriate ones. The port > > scan

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error

2019-04-16 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Tuesday, April 16, 2019 5:40 PM > To: Yigit, Ferruh ; David Christensen > ; tho...@monjalon.net > Cc: dev@dpdk.org; radhika.chi...@ibm.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error

2019-04-16 Thread Andrew Rybchenko
On 4/16/19 7:31 PM, Ferruh Yigit wrote: On 4/10/2019 10:36 PM, David Christensen wrote: The function eth_dev_pci_specific_init is missing a typecast to (struct rte_pci_device *) for the input argument bus_device. This causes build issues in the GNU C++ compiler. [CXX] g++ -o utils/pcap_ha

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] ethdev: missing typecast causes C++ build error

2019-04-16 Thread Ferruh Yigit
On 4/10/2019 10:36 PM, David Christensen wrote: > The function eth_dev_pci_specific_init is missing a typecast to > (struct rte_pci_device *) for the input argument bus_device. > This causes build issues in the GNU C++ compiler. > > [CXX] g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g

Re: [dpdk-dev] [PATCH] net: do not insert VLAN tag to shared mbufs

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 04:51:26PM +0100, Ferruh Yigit wrote: > The vlan_insert() is buggy when it tires to handle the shared mbufs, > instead don't support inserting VLAN tag into shared mbufs and return > an error for that case. > > Signed-off-by: Ferruh Yigit > --- > Cc: Stephen Hemminger > C

Re: [dpdk-dev] [PATCH v3] power: update for handling fifo path string

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 9:23 AM, Gosiewski, LukaszX wrote: > Hi, > Could there be also possibility, that patch is on hold because it's still > waiting for moderator approval? > I got this mail when posting: > " Your mail to 'dev' with the subject > > [PATCH v3] power: update for handling fifo path str

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

2019-04-16 Thread Ayuj Verma
Hi Fiona, Sorry for delay in response. Please see inline. Thanks and regards Ayuj Verma From: Trahe, Fiona Sent: 12 April 2019 20:47 To: Ayuj Verma; akhil.go...@nxp.com; Kusztal, ArkadiuszX Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desa

Re: [dpdk-dev] [PATCH] eal: fix large multiple calculation in reciprocal division

2019-04-16 Thread Stefan Kanthak
Pavan Nikhilesh wrote Sunday, April 14, 2019 7:22 AM: From: Pavan Nikhilesh Fix large multiple calculation in 64 bit reciprocal division. This "fix" has a SERIOUS bug, it needs yet another fix. I recommend to understand code first before you copy it! [...] + int64_t i; uint i = 64;

[dpdk-dev] [PATCH v3] power: update for handling fifo path string

2019-04-16 Thread Lukasz Gosiewski
From: Lukasz Krakowiak Removed doubled created fifo path string for channel info. --- v3: *improvement to coding style v2: * rebase to master changes Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- examples/vm_power_manager/channel_manager.c | 7 +++ 1 file changed,

[dpdk-dev] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-16 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Coverity issue: 279441 Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Li Qiang --- Change since v2: add prop

Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT

2019-04-16 Thread Przemysław Ołtarzewski
Hello, Last week I attempted to migrate our system from DPDK 18.11.1 to current master with David's patches applied. I haven't been able to make it work correctly - probably due to other changes in master since 18.11.1 - so unfortunately I cannot confirm that David's patchset solves the issue (alt

[dpdk-dev] [PATCH v3] power: update for handling fifo path string

2019-04-16 Thread Lukasz Gosiewski
From: Lukasz Krakowiak Removed doubled created fifo path string for channel info. --- v3: *improvement to coding style v2: * rebase to master changes Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- examples/vm_power_manager/channel_manager.c | 7 +++ 1 file changed,

Re: [dpdk-dev] [PATCH v3] power: update for handling fifo path string

2019-04-16 Thread Gosiewski, LukaszX
Hi, Could there be also possibility, that patch is on hold because it's still waiting for moderator approval? I got this mail when posting: " Your mail to 'dev' with the subject [PATCH v3] power: update for handling fifo path string Is being held until the list moderator can review it for

[dpdk-dev] [PATCH v2 1/3] power: update for handling fifo path string

2019-04-16 Thread Lukasz Gosiewski
From: Lukasz Krakowiak Removed doubled created fifo path string for channel info. --- v2: * rebase to master changes Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_manager.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/vm_power_man

[dpdk-dev] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-04-16 Thread Li Qiang
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Coverity issue: 279441 Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Li Qiang --- Change since v2: add prop

Re: [dpdk-dev] [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration

2019-04-16 Thread Ferruh Yigit
On 4/12/2019 7:13 PM, Yong Wang wrote: > -Original Message- > From: Eduard Serra Miralles > Date: Wednesday, April 10, 2019 at 9:44 PM > To: Yong Wang > Cc: "dev@dpdk.org" , Eduard Serra Miralles > Subject: [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration > > From: Eduar

Re: [dpdk-dev] [PATCH] net/bonding: fix potential out of bounds read

2019-04-16 Thread Ferruh Yigit
On 4/15/2019 10:27 AM, Radu Nicolau wrote: > Add validation to pointer constructed from the IPv4 header length > in order to prevent malformed packets from generating a potential > out of bounds memory read. Can you please add fixes lines? > > Signed-off-by: Radu Nicolau > --- > drivers/net/bo

Re: [dpdk-dev] [PATCH v3] eal: support strlcat function

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 3:37 PM, Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: >> On 17/01/2019 17:30, Bruce Richardson wrote: >>> Add the strlcat function to DPDK to exist alongside the strlcpy one. >>> While strncat is generally safe for use for concatenation, the

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-16 Thread Shreyansh Jain
Hi Ananyev, [...] > > As you have stated below, it's just the same thing with two different > views. > > > > > I think it would be plausible for both cases: > > > - one port per core (your case). > > > - multiple ports per core. > > > > Indeed. For this particular patch, I just chose the first on

Re: [dpdk-dev] [PATCH] doc: add ipn3ke release notes

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 1:21 PM, Rosen Xu wrote: > Add ipn3ke release notes for 19.05. Introduce new ipn3ke net driver, > and update new features of ifpga_rawdev. > > Signed-off-by: Rosen Xu Squashed into relevant commit in next-net, thanks.

[dpdk-dev] [PATCH] net: do not insert VLAN tag to shared mbufs

2019-04-16 Thread Ferruh Yigit
The vlan_insert() is buggy when it tires to handle the shared mbufs, instead don't support inserting VLAN tag into shared mbufs and return an error for that case. Signed-off-by: Ferruh Yigit --- Cc: Stephen Hemminger Cc: Chas Williams This is another approach to RFC to fix the vlan_insert: htt

Re: [dpdk-dev] [PATCH v2 2/2] build: fix crash by disabling AVX512 with binutils 2.31

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 04:39:32PM +0100, Ferruh Yigit wrote: > On Skylake platform, with native build, KNI kernel module crashes > because of the corrupted values passed to kernel module. > > The corruption occurs because the userspace kni library works > unexpectedly. Compiler [1] is using AVX51

Re: [dpdk-dev] [PATCH v2 1/2] build: fix meson binutils workaround

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 04:39:31PM +0100, Ferruh Yigit wrote: > The '-mno-avx512f' compiler flag is not passed to the compiler, > detection of the binutils and setting flags works fine, but the flag > itself not used by compiler. > > Removing the interim 'march_opt' variable and using directly > '

[dpdk-dev] [PATCH v2 2/2] build: fix crash by disabling AVX512 with binutils 2.31

2019-04-16 Thread Ferruh Yigit
On Skylake platform, with native build, KNI kernel module crashes because of the corrupted values passed to kernel module. The corruption occurs because the userspace kni library works unexpectedly. Compiler [1] is using AVX512 instructions and generated binary is wrong [2]. It turned around gcc

[dpdk-dev] [PATCH v2 1/2] build: fix meson binutils workaround

2019-04-16 Thread Ferruh Yigit
The '-mno-avx512f' compiler flag is not passed to the compiler, detection of the binutils and setting flags works fine, but the flag itself not used by compiler. Removing the interim 'march_opt' variable and using directly 'machine_args' and setting '-mno-avx512f' to 'machine_args' Fixes: 566b4d7

Re: [dpdk-dev] [PATCH] doc: update release notes for enetc PMD

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 11:13 AM, Gagandeep Singh wrote: > There are some basic features added. > > Signed-off-by: Gagandeep Singh Squashed into relevant commit in next-net, thanks. Please double check in the next-net.

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 08:03:36AM -0700, Stephen Hemminger wrote: > On Tue, 16 Apr 2019 10:42:13 +0100 > Bruce Richardson wrote: > > > On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: > > > On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > > > > On Fri, 12 Apr 2019 17:28:17 +0100

[dpdk-dev] [PATCH v2 1/2] net/af_xdp: enqueue buf ring when allocate Tx queue fails

2019-04-16 Thread Xiaolong Ye
When it fails to allocate enough slots in Tx queue for transmitting packets, we need to return the dequeued addrs to buf ring. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + 1 file changed, 1 insertion(+) diff

[dpdk-dev] [PATCH v2 0/2] some fixes

2019-04-16 Thread Xiaolong Ye
This patchset provides some fixes to af_xdp pmd, at first, I just added a simple error handling when Tx queue allocation fails, then David suggested a better way to do it and pointed out the inconsistent issue of reserve/submit ops (for Tx queue) and peek/release ops (for Rx queue), the second patc

[dpdk-dev] [PATCH v2 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-16 Thread Xiaolong Ye
As David pointed out, if we reserve N slots for Tx, but only submit n slots, we would end up with an incorrect opinion of the number of available slots later, we also would get wrong idx when we call xsk_ring_prod__reserve next time. It also applies to xsk_ring_cons__peek()/xsk_ring_cons__release()

Re: [dpdk-dev] [PATCH] doc: fix interactive commands in testpmd guide

2019-04-16 Thread Ferruh Yigit
On 4/16/2019 7:33 AM, Agalya Babu RadhaKrishnan wrote: > From: Agalya Babu RadhaKrishnan > > Added some missing documentation for interactive mode commands > > Fixes: 01b2092a5e ("testpmd: add dump commands for debug") > Fixes: caf05a1b86 ("app/testpmd: new command to dump log types") > > Signe

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 10:42:13 +0100 Bruce Richardson wrote: > On Tue, Apr 16, 2019 at 10:37:07AM +0100, Ferruh Yigit wrote: > > On 4/12/2019 11:08 PM, Stephen Hemminger wrote: > > > On Fri, 12 Apr 2019 17:28:17 +0100 > > > Ferruh Yigit wrote: > > > > > >> On 4/8/2019 5:41 PM, Stephen Hemming

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-16 Thread Akhil Goyal
Hi Shally/Ashish, Could you please review this patch. Thanks, Akhil > > Fixed some typos and clarified which errors should be returned > when and why on the enqueue and dequeue APIs. > > Fixes: a584d3bea902 ("doc: add compressdev library guide") > cc: sta...@dpdk.org > > Signed-off-by: Fiona Tr

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id

2019-04-16 Thread Akhil Goyal
> > The socket_id is used as an array index so should be within the range > > of zero to max numa nodes. Add a range check to ensure we don't get > > excessive values. > > > > Coverity issue: 336812 > > Coverity issue: 336829 > > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool intern

Re: [dpdk-dev] [PATCH] compress/qat: fixed data-plane return from QAT PMD

2019-04-16 Thread Akhil Goyal
> > > -Original Message- > > From: Trahe, Fiona > > Sent: Monday, April 8, 2019 6:16 PM > > To: dev@dpdk.org > > Cc: akhil.go...@nxp.com; Jozwiak, TomaszX ; > > Trahe, Fiona > > Subject: [PATCH] compress/qat: fixed data-plane return from QAT PMD > > > > Fixes: 62ada2182a46 ("compress/qat:

Re: [dpdk-dev] [PATCH v5 0/3] rwlock: reimplement rwlock with atomic and add relevant perf test case

2019-04-16 Thread Kevin Traynor
On 25/03/2019 09:14, Joyce Kong wrote: > Gavin Hu (1): > rwlock: reimplement with atomic builtins > Hi - for 18.11 branch, I applied above (queued for push) rebased to remove the trylock modifications. > Joyce Kong (2): > test/rwlock: add perf test case on all available cores > test/rwlock

Re: [dpdk-dev] [PATCH v3] app/test/ipsec: fix test initialisation

2019-04-16 Thread Akhil Goyal
> > > > Fix xform initialisation. > > Fix testsuite_setup. > > Remove unused variables. > > > > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") > > Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") > > > > Signed-off-by: Bernard Iremonger > > --- > > Changes in v3: > > drop

Re: [dpdk-dev] [PATCH] doc/crypto: fix missing asymmetric algo table

2019-04-16 Thread Akhil Goyal
> > On 4/3/2019 4:08 PM, Fiona Trahe wrote: > > > Fixes: 11e5ba72cf67 ("doc: add crypto asymmetric feature list") > > > cc: sta...@dpdk.org > > > > > > Signed-off-by: Fiona Trahe > > > --- > > > .gitignore | 1 + > > > doc/guides/conf.py

Re: [dpdk-dev] [PATCH] doc: add missing algorithms for AESNI MB PMD

2019-04-16 Thread Akhil Goyal
> > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > > Sent: Wednesday, April 10, 2019 2:36 AM > > To: Doherty, Declan > > Cc: akhil.go...@nxp.com; dev@dpdk.org; De Lara Guarch, Pablo > > > Subject: [dpdk-dev] [PATCH] doc: add missing algorith

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: use architecture independent API

2019-04-16 Thread Akhil Goyal
> > > IPSec Multi-buffer library has recently added API > that sets pointers depending on the architecture, at initiliazation, > in version 0.52. > > AESNI MB PMD was updated with these changes, but not > the AESNI GCM PMD, which also uses the same library. > > This makes the PMD to be only c

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-16 Thread Stephen Hemminger
On Tue, 16 Apr 2019 05:29:21 + Honnappa Nagarahalli wrote: > > > > > > > > On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Add RCU library supporting quiescent state based memory > > > > > > > > > reclamation > > > > > > >

Re: [dpdk-dev] [PATCH v2 0/1] add max mbuf size test case

2019-04-16 Thread Akhil Goyal
> -Original Message- > From: dev On Behalf Of Tomasz Cel > Sent: Tuesday, April 2, 2019 5:47 PM > To: dev@dpdk.org; fiona.tr...@intel.com; tomaszx.jozw...@intel.com; > tomaszx@intel.com > Subject: [dpdk-dev] [PATCH v2 0/1] add max mbuf size test case > > From: Tomasz Jozwiak > >

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix memory leak and illegal memory access

2019-04-16 Thread Akhil Goyal
> > > Opendir() returns allocated storage which must be freed at the > > end of function or in case any return on error. so freeing the > > allocation using closedir in an error case. > > > > Coverity issue: 323507 > > Coverity issue: 325880 > > Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specif

Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness

2019-04-16 Thread Akhil Goyal
> > -Original Message- > > From: Gagandeep Singh > > Sent: Monday, April 8, 2019 2:29 PM > > To: dev@dpdk.org; Akhil Goyal > > Cc: Gagandeep Singh > > Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness > > > > build a shared descriptor accordingly if core and > > CAAM end

Re: [dpdk-dev] [PATCH v2 1/3] examples/fips: fix hmac test failure

2019-04-16 Thread Akhil Goyal
> Application was failing as the HMAC and > Plain SHA fips request files are similar in a > way that they both have SHA- in the top section to > determine the hash algo and hash sizes. And HMAC having the > algo in the second line but the Plain SHA in the third > meant that when the HMAC files was

Re: [dpdk-dev] [PATCH] doc: fix heading levels in bbdev test guide

2019-04-16 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 15, 2019 12:59 PM > To: Mokhtar, Amr ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] doc: fix heading levels in bbdev test guide > > The section

Re: [dpdk-dev] [PATCH v3] eal: support strlcat function

2019-04-16 Thread Bruce Richardson
On Tue, Apr 16, 2019 at 03:29:52PM +0100, Kevin Traynor wrote: > On 17/01/2019 17:30, Bruce Richardson wrote: > > Add the strlcat function to DPDK to exist alongside the strlcpy one. > > While strncat is generally safe for use for concatenation, the API for the > > strlcat function is perhaps a lit

Re: [dpdk-dev] [PATCH v3] eal: support strlcat function

2019-04-16 Thread Kevin Traynor
On 17/01/2019 17:30, Bruce Richardson wrote: > Add the strlcat function to DPDK to exist alongside the strlcpy one. > While strncat is generally safe for use for concatenation, the API for the > strlcat function is perhaps a little nicer to use, and supports truncation > detection. > > See commit

[dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor

2019-04-16 Thread Viacheslav Ovsiienko
On BlueField platform we have the new entity - PF representor. This one represents the PCI PF attached to external host on the side of ARM. The traffic sent by the external host to the NIC via PF will be seem by ARM on this PF representor. This patch refactors port recognizing capability on the ba

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-16 Thread Ferruh Yigit
On 4/12/2019 3:40 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Andrew Rybchenko [mailto:arybche...@solarflare.com] >> Sent: Friday, April 12, 2019 2:13 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: [PATCH] a

Re: [dpdk-dev] [PATCH] doc/crypto: fix missing asymmetric algo table

2019-04-16 Thread Akhil Goyal
> Hi Fiona, > > On 4/3/2019 4:08 PM, Fiona Trahe wrote: > > Fixes: 11e5ba72cf67 ("doc: add crypto asymmetric feature list") > > cc: sta...@dpdk.org > > > > Signed-off-by: Fiona Trahe > > --- > > .gitignore | 1 + > > doc/guides/conf.py

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id

2019-04-16 Thread Akhil Goyal
> The socket_id is used as an array index so should be within the range > of zero to max numa nodes. Add a range check to ensure we don't get > excessive values. > > Coverity issue: 336812 > Coverity issue: 336829 > Fixes: 2c59bd32b70d ("cryptodev: do not create session mempool internally") > CC:

Re: [dpdk-dev] [PATCH] crypto/caam_jr: fix memory leak and illegal memory access

2019-04-16 Thread Akhil Goyal
> Opendir() returns allocated storage which must be freed at the > end of function or in case any return on error. so freeing the > allocation using closedir in an error case. > > Coverity issue: 323507 > Coverity issue: 325880 > Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations")

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-16 Thread Ananyev, Konstantin
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Tuesday, April 16, 2019 1:48 PM > To: Ananyev, Konstantin ; Ruifeng Wang (Arm > Technology China) ; > dev@dpdk.org > Cc: nd > Subject: RE: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool

Re: [dpdk-dev] [PATCH] examples/l3fwd: support separate buffer pool per port

2019-04-16 Thread Shreyansh Jain
Hello Ananyev, > Hi Shreyansh, > > > > > I tried this patch on MacchiatoBin + 82599 NIC. > > > > Compared with global-pool mode, per-port-pool mode showed slightly > > > lower performance in single core test. > > > > > > That was my thought too - for the case when queues from multiple > ports > >

[dpdk-dev] [PATCH] doc: add ipn3ke release notes

2019-04-16 Thread Rosen Xu
Add ipn3ke release notes for 19.05. Introduce new ipn3ke net driver, and update new features of ifpga_rawdev. Signed-off-by: Rosen Xu --- doc/guides/rel_notes/release_19_05.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_no

Re: [dpdk-dev] [PATCH v9 02/14] bus/ifpga: add function for AFU search by name

2019-04-16 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 16, 2019 16:48 > To: Xu, Rosen ; dev@dpdk.org > Cc: Zhang, Tianfei ; Wei, Dan > ; Pei, Andy ; Yang, Qiming > ; Wang, Haiyue ; Chen, > Santos ; Zhang, Zhang ; > Lomartire, David ; Hu, Jia > Subject: Re: [PATCH v9 02/14] bus

[dpdk-dev] [PATCH v4] power: update for handling fifo path string

2019-04-16 Thread Lukasz Gosiewski
From: Lukasz Krakowiak Removed doubled created fifo path string for channel info. Signed-off-by: Lukasz Krakowiak Signed-off-by: Lukasz Gosiewski --- v4: *improvement to coding style v3: *improvement to coding style v2: * rebase to master changes --- examples/vm_power_manager/channel_manag

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-16 Thread Igor Russkikh
> These are new ethdev APIs, not driver code, that have been sent after > rc1, so > these didn't go through a proper review cycle, we didn't get any comment > on any > other possible driver can use it, I am for postponing the series to next > release. > > Also th

Re: [dpdk-dev] [PATCH v4 00/13] ENETC PMD basic features and bug fixes

2019-04-16 Thread Gagandeep Singh
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 16, 2019 1:59 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH v4 00/13] ENETC PMD basic features and > bug fixes > > > On 4/16/2019 8:41 AM, Ferruh Yigit wrote: > > On 4/12/2019 1:28 PM, Gag

  1   2   >