[dpdk-dev] [PATCH v3] ethdev: support QinQ strip dynamic configuration

From: Vivek Sharma Enable missing support for runtime configuration (setting/getting) of QinQ strip rx offload for a given ethdev. Signed-off-by: Vivek Sharma --- v3: * Make patch as 'non-fix'. v2: * Use pointer to dereference dev->data->dev_conf.rxmode.offloads. lib/librte_ethdev/rte_ethde

Re: [dpdk-dev] [PATCH] net/ice: fix wrong Tx function selection

> -Original Message- > From: Rong, Leyi > Sent: Friday, April 19, 2019 11:04 AM > To: Lu, Wenzhuo ; Zhang, Qi Z > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH] net/ice: fix wrong Tx function selection > > Add ice_set_tx_function_flag() to configure tx_simple_allowed properly. > > F

[dpdk-dev] [PATCH] net/ice: fix wrong Tx function selection

Add ice_set_tx_function_flag() to configure tx_simple_allowed properly. Fixes: 6eac0b7fde95 ("net/ice: support advance Rx/Tx") Signed-off-by: Leyi Rong --- drivers/net/ice/ice_rxtx.c | 22 ++ drivers/net/ice/ice_rxtx.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a

[dpdk-dev] [PATCH v1] crypto/virtio: fix return value check

Fix unchecked return value issue for rte_pci_read_config. Coverity issue: 302861 Fixes: 25500d4b8076 ("crypto/virtio: support device init") Cc: sta...@dpdk.org Signed-off-by: Chenbo Xia --- drivers/crypto/virtio/virtio_pci.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH] net/cxgbe: fix colliding function names

This driver defines lots of functions (like init_rss) which are intended to only be used in this device. But when doing static linking these global functions cause link failures when similar function name is used in application. This patch prefixes all functions defined in cxgbe.h with cxgbe_ to a

Re: [dpdk-dev] [PATCH v3] net/bonding: fix potential out of bounds read

On 4/18/19 2:41 PM, Ferruh Yigit wrote: On 4/17/2019 3:36 PM, Radu Nicolau wrote: Add validation to pointer constructed from the IPv4 header length in order to prevent malformed packets from generating a potential out of bounds memory read. Fixes: 09150784a776 ("net/bonding: burst mode hash

Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

On 4/18/19 3:11 AM, David Marchand wrote: Hello Chas, On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3ch...@gmail.com > wrote: I should have some time this weekend to run these patches through our regression system. Did you manage to run this series throu

Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case

Hi, I'm seeing compile error. Isn't it due to this patch? $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) [1484/1523] Compiling C object 'app/test/app@test@@dpdk-test@exe/test_compressdev.c.o'. FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o cc -Iapp/test/app@test@@dp

Re: [dpdk-dev] [PATCH] eventdev: promote adapter functions as stable

> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Thursday, April 18, 2019 7:06 AM > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Mattias Rönnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil ; Carrillo, > Erik G > Cc: pbhagavat...

Re: [dpdk-dev] [pull-request] next-crypto 19.05 rc2

18/04/2019 16:03, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

18/04/2019 23:06, Pradeep Satyanarayana: > > Pradeep Satyanarayana/Beaverton/IBM wrote on 04/11/2019 08:57:05 AM: > > > From: Pradeep Satyanarayana/Beaverton/IBM > > To: Thomas Monjalon > > Cc: dev@dpdk.org, David Christensen , Vivian > > Kong , David Wilder > > Date: 04/11/2019 08:57 AM > > Su

[dpdk-dev] [PATCH] test/timer: exercise new APIs in secondary process

This commit adds an autotest which exercises new timer reset/stop APIs in a secondary process. Timers are created, and sometimes stopped, in the secondary process, and their expiration is checked for and handled in the primary process. Signed-off-by: Erik Gabriel Carrillo --- app/test/Makefile

[dpdk-dev] [PATCH v2] net/vmxnet3: v4 boot and guest UDP RSS configuration

From: Eduard Serra This patch introduces: - VMxnet3 v4 negotiation and, - entirely guest-driven UDP RSS support. VMxnet3 v3 already has UDP RSS support, however it depends on hypervisor provisioning on the VM through ESX specific flags, which are not transparent or known to the guest later on.

[dpdk-dev] DPDK techboard minutes (2019-04-10)

Hi, Here are the meeting notes of the DPDK technical board meeting held on 2019-04-10. Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Olivier Matz - Stephen Hemminger - Thomas Monjalon 1) DPDK development process and tools survey =

Re: [dpdk-dev] [PATCH] doc: fix interactive commands in testpmd guide

On 4/16/2019 4:05 PM, Ferruh Yigit wrote: > On 4/16/2019 7:33 AM, Agalya Babu RadhaKrishnan wrote: >> From: Agalya Babu RadhaKrishnan >> >> Added some missing documentation for interactive mode commands >> >> Fixes: 01b2092a5e ("testpmd: add dump commands for debug") >> Fixes: caf05a1b86 ("app/tes

Re: [dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch support

Thursday, April 18, 2019 4:16 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch > support > > Currently MLX5 PMD supports 3 flow engines: > Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while > the TCF is for E-Switch steering. > > Thi

Re: [dpdk-dev] [PATCH] net/mlx5: fix release of jump to queue action

Wednesday, April 17, 2019 1:46 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix release of jump to queue action > > On Sun, Apr 14, 2019 at 08:17:11PM +, Ori Kam wrote: > > Currenlty the allocation of the jump to QP is done in flow apply, this > > results in memory leak. > > > > This pat

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

Thursday, April 18, 2019 4:26 PM, Yongseok Koh: > Subject: Re: [PATCH v2] net/mlx5: fix modify header action position > > > > On Apr 17, 2019, at 1:01 PM, Ori Kam wrote: > > > > According to RTE flow the action order should be the order that the > > actions were given. > > In the case of modify

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup routine

Monday, April 15, 2019 11:46 AM, Slava Ovsiienko: > Subject: RE: [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup > routine > [...] > > I will take the v2. > There are some troubles with passing check-log script for mlx4/mlx5 merged > patch. > So, I prepared the separated patch for

Re: [dpdk-dev] [PATCH] net/mlx4: fix memory region cleanup routine

Monday, April 15, 2019 11:41 AM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx4: fix memory region cleanup routine > > mlx4 driver has a global list of Memory Regions created by device, and there > is a ml4_mr_release() routine which makes a memory cleanup at device > closing. The he

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor

Tuesday, April 16, 2019 5:10 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor > > On BlueField platform we have the new entity - PF representor. > This one represents the PCI PF attached to external host on the side of ARM. > The traffic sent by t

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix source port ID in Rx packets

On 4/18/2019 6:20 PM, Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses those caring about the

Re: [dpdk-dev] [PATCH v3] net/bonding: fix potential out of bounds read

On 4/17/2019 3:36 PM, Radu Nicolau wrote: > Add validation to pointer constructed from the IPv4 header length > in order to prevent malformed packets from generating a potential > out of bounds memory read. > > Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > Some port iterations are manually checking against RTE_ETH_DEV_UNUSED > instead of using the iterators based on rte_eth_find_next(). > > A new macro RTE_ETH_FOREACH_VALID_DEV() is introduced, but kept private > because there should be no need of iter

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

On 4/18/2019 6:58 PM, Ajit Khaparde wrote: > On Tue, Apr 16, 2019 at 5:37 PM Thomas Monjalon wrote: > >> As stated in the deprecation notice from December 2016, >> "the legacy filter API, including rte_eth_dev_filter_supported(), >> rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHER

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

Thursday, April 18, 2019 4:48 PM, Ori Kam: > Subject: RE: [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E- > Switch > > Hi Shahaf, > > Can you please fix it when you take it? Yes took care. > > Thanks, > Ori > > > -Original Message- > > From: Yongseok Koh > > Sent: Thursday

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: ipc add check for number of messages received

On 4/18/2019 6:19 PM, Herakliusz Lipiec wrote: > A sucessfull call to rte_mp_request_sync does not guarantee that there > are valid messages in the buffer, and this should be checked for before > accessing data in the message. > > Fixes: c9aa56edec8e ("net/tap: access primary process queues from s

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

On Tue, Apr 16, 2019 at 5:37 PM Thomas Monjalon wrote: > As stated in the deprecation notice from December 2016, > "the legacy filter API, including rte_eth_dev_filter_supported(), > rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHERTYPE, > FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, HASH

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

18/04/2019 19:09, Adrien Mazarguil: > On Thu, Apr 18, 2019 at 06:54:22PM +0200, Thomas Monjalon wrote: > > > > > > > > > "slave" is a wording from bonding. > > > > > In failsafe, it is sub-device, isn't it? > > > > > > I don't mind, although grep shows a couple of comments talking about > > > s

Re: [dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

18/04/2019 14:47, Thomas Monjalon: > 18/04/2019 13:50, Ferruh Yigit: > > On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > > > Some port iterations are manually checking against RTE_ETH_DEV_UNUSED > > > instead of using the iterators based on rte_eth_find_next(). > > > > > > A new macro RTE_ETH_FORE

[dpdk-dev] [PATCH v3] net/failsafe: fix source port ID in Rx packets

When passed to the application, Rx packets retain the port ID value originally set by slave devices. Unfortunately these IDs have no meaning to applications, which are typically unaware of their existence. This confuses those caring about the source port field in mbufs (m->port) which experience i

[dpdk-dev] [PATCH] net/tap: ipc add check for number of messages received

A sucessfull call to rte_mp_request_sync does not guarantee that there are valid messages in the buffer, and this should be checked for before accessing data in the message. Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: rasl...@mellanox.com Cc: sta...@dpdk.org S

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

On Thu, Apr 18, 2019 at 06:54:22PM +0200, Thomas Monjalon wrote: > > > > > > "slave" is a wording from bonding. > > > > In failsafe, it is sub-device, isn't it? > > > > I don't mind, although grep shows a couple of comments talking about slaves > > already. Either way I think it fits as those ar

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

18/04/2019 18:46, Adrien Mazarguil: > On Thu, Apr 18, 2019 at 05:51:18PM +0200, Thomas Monjalon wrote: > > 18/04/2019 17:39, Thomas Monjalon: > > > 18/04/2019 17:32, Adrien Mazarguil: > > > > When passed to the application, Rx packets retain the port ID value > > > > originally set by slave devices

Re: [dpdk-dev] [PATCH v3] doc/crypto: add release notes and more detailed doc to qat

> -Original Message- > From: Trahe, Fiona > Sent: Thursday, April 18, 2019 6:45 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Kusztal, ArkadiuszX > ; Trahe, Fiona > Subject: [PATCH v3] doc/crypto: add release notes and more detailed doc to > qat > > From: Arek Kusztal > > This pat

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

On Thu, Apr 18, 2019 at 05:51:18PM +0200, Thomas Monjalon wrote: > 18/04/2019 17:39, Thomas Monjalon: > > 18/04/2019 17:32, Adrien Mazarguil: > > > When passed to the application, Rx packets retain the port ID value > > > originally set by slave devices. Unfortunately these IDs have no meaning > >

[dpdk-dev] [PATCH v3] doc/crypto: add release notes and more detailed doc to qat

From: Arek Kusztal This patch adds release notes to 19.05 release document, and more detailed description to Intel QuickAssist Technology driver documentation files for asymmmetric crypto PMD. Signed-off-by: Arek Kusztal Signed-off-by: Fiona Trahe --- v3 changes: - fixed broken table and move

Re: [dpdk-dev] [PATCH v3 4/4] meson: add Mellanox BlueField cross-compile config

18/04/2019 13:49, Yongseok Koh: > Mellanox BlueField is armv8 CPU having cortex-a72. The implementor ID is > 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). > > Signed-off-by: Yongseok Koh > Acked-by: Jerin Jacob Series applied, thanks

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

On Thu, Apr 18, 2019 at 05:39:37PM +0200, Thomas Monjalon wrote: > 18/04/2019 17:32, Adrien Mazarguil: > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unawar

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

18/04/2019 17:39, Thomas Monjalon: > 18/04/2019 17:32, Adrien Mazarguil: > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically unaware of their existence. > > > >

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

18/04/2019 17:32, Adrien Mazarguil: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses those caring about the source po

[dpdk-dev] [PATCH v2] net/failsafe: fix source port ID in Rx packets

When passed to the application, Rx packets retain the port ID value originally set by slave devices. Unfortunately these IDs have no meaning to applications, which are typically unaware of their existence. This confuses those caring about the source port field in mbufs (m->port) which experience i

[dpdk-dev] [PATCH v1 2/2] net/af_xdp: name the umem memzone dynamically

Naming the umem memzone dynamically allows to create multiple af_xdp vdevs. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: Markus Theil Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --gi

[dpdk-dev] [PATCH v1 1/2] net/af_xdp: name the buf ring dynamically

Naming the buf_ring dynamically allows to create multiple af_xdp vdevs. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: Markus Theil Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --g

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

Hi Akhil, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard > Sent: Thursday, April 18, 2019 3:59 PM > To: Akhil Goyal ; dev@dpdk.org; Ananyev, > Konstantin > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fi

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Wednesday, April 10, 2019 1:49 PM > To: dev@dpdk.org > Cc: Hunt, David ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer > overrun > > The freqs array in

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

On Thu, Apr 18, 2019 at 03:42:24PM +0100, Ferruh Yigit wrote: > On 4/18/2019 2:11 PM, Adrien Mazarguil wrote: > > When passed to the application, Rx packets retain the port ID value > > originally set by slave devices. Unfortunately these IDs have no meaning to > > applications, which are typically

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

Hi Akhil, > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped > for inline crypto > > + if (sa->type == > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) { > > + ctx = (struct rte_security_ctx *) > > + rte_eth_dev_get_sec_c

Re: [dpdk-dev] [PATCH v1] examples/power: fix vm power manager resource leak

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Tuesday, April 9, 2019 10:43 AM > To: dev@dpdk.org > Cc: Hunt, David ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] examples/power: fix vm power manager > resource leak > > Fixes: 99a968fa

Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances

Hi, 24/04/2018 08:41, Arnon Warshavsky: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation of the event. > > T

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

On 4/18/2019 2:11 PM, Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses those caring about the

[dpdk-dev] Overlinking in PMDs

Hi, on a recent 18.11.1 build I saw again that we are overlinking a lot still [1]. Some might be important and I'd not want to touch any *inner* links inside DPDK at this time. But it seems about everything is unconditionally linked to generic libs as well. Here one example from a (meson) build: #

Re: [dpdk-dev] [PATCH 1/1] doc: announce change in power API

On 13/3/2019 7:21 PM, Hajkowski wrote: From: Marcin Hajkowski Function rte_power_set_env will no longer return success on attempt to set env in initialized state. Signed-off-by: Marcin Hajkowski --- Acked-by: David Hunt

Re: [dpdk-dev] [PATCH] net/atlantic: release note on macsec feature

On 4/18/2019 1:27 PM, Igor Russkikh wrote: > Signed-off-by: Igor Russkikh Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

On 4/18/2019 12:39 PM, Igor Russkikh wrote: > This patchset implements MACSEC hardware offload configuration in > Atlantic PMD via experimental PMD API. > > There is an agreement to work on 19.08 timeframe for the generic > MACSEC API inside of rte_security. > > v3 changes after Ferruh's comments

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor

PSB minor comments. > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, April 16, 2019 5:10 PM > To: dev@dpdk.org > Cc: Shahaf Shuler > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor > > On BlueField platform we have the new entit

Re: [dpdk-dev] [PATCH v3 2/4] meson: change default config for armv8

> > Current default cache line size for armv8 CPUs having Implementor ID of > 0x41 is 128 bytes, changing it to 64 bytes. Also, the max number of lcores is > changed to 16 from 256. > > Signed-off-by: Yongseok Koh > --- > > v3: > * decrease RTE_MAX_LCORE to 16 from 256 > * change title and comm

Re: [dpdk-dev] [PATCH v2] examples/vm_power: add conditional compilation for PMD specific code

On 2/4/2019 7:46 PM, David Christensen wrote: Running the devtools/test-build.sh script on IBM Power systems fails because the IXGBE_PMD is explicity disabled for Power as an untested driver, but the examples/vm_power_manager application has a hard dependency on a function call in the IXGBE_PMD

Re: [dpdk-dev] [pull-request] next-crypto 19.05 rc2

Ipsec-secgw patches are breaking the lookaside cases. So pushing them for RC3. > > The following changes since commit > 380154406dc8ce6f46a1c3e4e9fced5ba67644a1: > > build: use default flags for default Arm machine (2019-04-17 22:28:39 +0200) > > are available in the Git repository at: > >

Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list

Hi Lukasz, On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote: Removed dependency to mac_list from policies: * BRANCH_RATIO, * WORKLOAD, * TIME in function update_policy. Fixes: 1b897991473f ("power: update error handling") Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_mon

[dpdk-dev] [pull-request] next-crypto 19.05 rc2

The following changes since commit 380154406dc8ce6f46a1c3e4e9fced5ba67644a1: build: use default flags for default Arm machine (2019-04-17 22:28:39 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 44bf56300e3f3ed81b6ac2b

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

On Thu, Apr 18, 2019 at 03:11:26PM +0200, Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses th

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

Hey Adrien, On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuse

Re: [dpdk-dev] [PATCH v3] build: mention machine=default and its use in documentation

18/04/2019 11:30, luca.bocca...@gmail.com: > From: Luca Boccassi > > Document the new value, as it's useful for distributions and users > who need to use a stable baseline -march > > Signed-off-by: Luca Boccassi > Reviewed-by: Christian Ehrhardt > Reviewed-by: Jerin Jacob > --- > v2: fix typo

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

Hi Bernard, > - RTE_LOG_DP(DEBUG, IPSEC, "Create session for SA spi %u on cryptodev " > - "%u qp %u\n", sa->spi, > - ipsec_ctx->tbl[cdev_id_qp].id, > - ipsec_ctx->tbl[cdev_id_qp].qp); > + if ((sa == NULL) || (pool == NUL

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

Hi Shahaf, Can you please fix it when you take it? Thanks, Ori > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:23 PM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH v3 9/9] net/mlx5:

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

> On Apr 17, 2019, at 1:01 PM, Ori Kam wrote: > > According to RTE flow the action order should be the order that the > actions were given. > In the case of modify actions the position of the action was always > last. > > This commit solves this issue by saving the position of the first modify

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

> On Apr 18, 2019, at 6:16 AM, Ori Kam wrote: > > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/m

[dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

This commit adds support for drop action when creating E-Switch flow using DV. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 22 ++ drivers/net/mlx5/

[dpdk-dev] [PATCH v3 2/9] net/mlx5: fix meson build for Direct Rules

The meson build was missing the define for Direct Rules. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Cc: or...@mellanox.com Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/meson.bu

[dpdk-dev] [PATCH v3 8/9] net/mlx5: add Forward Database table type

Actions like encap/decap, modify header require setting the flow table type. Until now we supported only Nic RX and Nic TX, this commits adds the support for FDB table type for those actions. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 56

[dpdk-dev] [PATCH v3 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

This commits adds matching on source port, using DV API. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.h| 12 drivers/net/mlx5/mlx5_flow_dv.c | 149 drivers/net/mlx5/mlx5_g

[dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch support

Currently MLX5 PMD supports 3 flow engines: Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while the TCF is for E-Switch steering. This series add E-Switch steering support also for the DV engine. In order to support the new capability there should be support from both th

[dpdk-dev] [PATCH v3 5/9] net/mlx5: add port ID item to Direct Verbs

Adds the port ID item to the DV steering code. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 84 ++--- 1 file changed, 61 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/ml

[dpdk-dev] [PATCH v3 1/9] net/mlx5: fix translate vport function name

Modify the translate vport function to match other translate items naming convestions. Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") Cc: viachesl...@mellanox.com Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 12 ++--

[dpdk-dev] [PATCH v3 6/9] net/mlx5: add transfer attribute to matcher

In current implementation the DV steering supported only NIC steering. This commit adds the transfer attribute in order to create a matcher on the FDB tabels. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c| 1 + drivers/net/mlx5/mlx5_flow.h| 2 ++ drive

[dpdk-dev] [PATCH v3 3/9] net/mlx5: add Direct Rules E-Switch support

This commit checks the for DR E-Switch support. The support is based on both Device and Kernel. This commit also enables the user to manualy disable this this feature. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- v3: * Add comment to fdb_tbl --- drivers/net/mlx5/Makefile | 5 +

[dpdk-dev] [PATCH v3 4/9] net/mlx5: add validation for Direct Rule E-Switch

Add validation logic for E-Switch using Direct Rules. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_ethdev.c | 41 +++ drivers/net/mlx5/mlx5_flow.h| 5 + drivers/net/mlx5/mlx5_flow_dv.c | 243 +++

[dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

When passed to the application, Rx packets retain the port ID value originally set by slave devices. Unfortunately these IDs have no meaning to applications, which are typically unaware of their existence. This confuses those caring about the source port field in mbufs (m->port) which experience i

[dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface

Since this driver does not distinguish unicast/multicast addresses, applications could always rely on the standard MAC add/remove/set interface to configure both types. As a result, the multicast address list interface never got implemented (rte_eth_dev_set_mc_addr_list()) however PMD-agnostic app

Re: [dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

18/04/2019 13:50, Ferruh Yigit: > On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > > Some port iterations are manually checking against RTE_ETH_DEV_UNUSED > > instead of using the iterators based on rte_eth_find_next(). > > > > A new macro RTE_ETH_FOREACH_VALID_DEV() is introduced, but kept private

Re: [dpdk-dev] [PATCH v1] doc: fix spelling errors reported by aspell

On 03/04/2019 14:26, John McNamara wrote: > Signed-off-by: John McNamara > --- > > Some notes on this. > > It is probably best not to apply this patch until just before the release > since it could potentially create a lot of conflicts. I'll resubmit a v2 > prior to the 19.05 release. > > The

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

On Wed, Apr 17, 2019 at 02:36:27AM +0200, Thomas Monjalon wrote: > As stated in the deprecation notice from December 2016, > "the legacy filter API, including rte_eth_dev_filter_supported(), > rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHERTYPE, > FLEXIBLE, SYN, NTUPLE, TUNNEL, FDI

Re: [dpdk-dev] [PATCH 2/2] ethdev: promote function for port count as stable

On 4/18/19 2:51 PM, Ferruh Yigit wrote: On 4/17/2019 11:59 PM, Thomas Monjalon wrote: The function rte_eth_dev_count_total() was introduced one year ago in the release 18.05. It can be declared non experimental in 19.05. Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit Acked-by: Andre

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add actions to modify TCP header fields

On Wed, Apr 10, 2019 at 02:50:41PM +0300, Dekel Peled wrote: > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP >

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

Hello Ferruh, >> Pavel Belous (5): >> net/atlantic: macsec hardware structures declaration >> net/atlantic: enable macsec configuration >> net/atlantic: macsec firmware interface >> net/atlantic: interrupt handling and macsec configuration >> net/atlantic: implement macsec statistics >

Re: [dpdk-dev] [PATCH v2 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

On Thu, Apr 18, 2019 at 11:28:50AM +, Ori Kam wrote: > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h |

[dpdk-dev] [PATCH] net/atlantic: release note on macsec feature

Signed-off-by: Igor Russkikh --- doc/guides/rel_notes/release_19_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index dbdf07a0c05b..94d91bc5d311 100644 --- a/doc/guides/rel_notes/release_19_05.rst +++

Re: [dpdk-dev] [PATCH v2 8/9] net/mlx5: add Forward Database table type

On Thu, Apr 18, 2019 at 11:28:49AM +, Ori Kam wrote: > Actions like encap/decap, modify header require setting the flow table > type. Until now we supported only Nic RX and Nic TX, this commits adds > the support for FDB table type for those actions. > > Signed-off-by: Ori Kam > --- Acked-by

Re: [dpdk-dev] [PATCH v2 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

On Thu, Apr 18, 2019 at 11:28:48AM +, Ori Kam wrote: > This commits adds matching on source port, using DV API. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_flow.h| 12 +

Re: [dpdk-dev] [PATCH v2 6/9] net/mlx5: add transfer attribute to matcher

On Thu, Apr 18, 2019 at 11:28:47AM +, Ori Kam wrote: > In current implementation the DV steering supported only NIC steering. > This commit adds the transfer attribute in order to create a matcher > on the FDB tabels. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Addres

Re: [dpdk-dev] [PATCH v2 5/9] net/mlx5: add port ID item to Direct Verbs

On Thu, Apr 18, 2019 at 11:28:46AM +, Ori Kam wrote: > Adds the port ID item to the DV steering code. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 84 > ++--- > 1 file

Re: [dpdk-dev] [PATCH v2 4/9] net/mlx5: add validation for Direct Rule E-Switch

On Thu, Apr 18, 2019 at 11:28:45AM +, Ori Kam wrote: > Add validation logic for E-Switch using Direct Rules. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_ethdev.c | 41

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

Hi Fiona, > -Original Message- > From: Fiona Trahe > Sent: Tuesday, April 9, 2019 8:26 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; > lee.d...@intel.com; Sunila Sahu ; Shally Verma > ; Fiona Trahe ; > sta...@dpdk.org > Subject: [PATCH v2] doc/compress: clarify error ha

Re: [dpdk-dev] [PATCH v2 3/9] net/mlx5: add Direct Rules E-Switch support

On Thu, Apr 18, 2019 at 11:28:44AM +, Ori Kam wrote: > This commit checks the for DR E-Switch support. > The support is based on both Device and Kernel. > This commit also enables the user to manualy disable this this feature. > > Signed-off-by: Ori Kam > --- Only one minor nit below. With

Re: [dpdk-dev] [PATCH v2 2/9] net/mlx5: fix meson build for Direct Rules

On Thu, Apr 18, 2019 at 11:28:43AM +, Ori Kam wrote: > The meson build was missing the define for Direct Rules. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: or...@mellanox.com > > Signed-off-by: Ori Kam Acked-by: Yongseok Koh > --- > v2: > * Address ML comments. > ---

Re: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name

On Thu, Apr 18, 2019 at 11:28:42AM +, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. > > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") > Cc: viachesl...@mellanox.com > > Signed-off-by: Ori Kam You wer

[dpdk-dev] [PATCH] eventdev: promote adapter functions as stable

From: Jerin Jacob Promote the adapter functions and rte_event_port_unlinks_in_progress() as stable as it's been added for a while now and multiple drivers and test application like test-eventdev has been tested using the adapter APIs. Cc: nikhil@intel.com Cc: erik.g.carri...@intel.com Cc: ab

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build

On Thu, 2019-04-18 at 04:49 -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for > libraries and > dependency() can't find libraries by pkg-config. By adding fallback > of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("buil

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

On 4/18/2019 12:39 PM, Igor Russkikh wrote: > This patchset implements MACSEC hardware offload configuration in > Atlantic PMD via experimental PMD API. > > There is an agreement to work on 19.08 timeframe for the generic > MACSEC API inside of rte_security. > > v3 changes after Ferruh's comments

  1   2   >