Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers

2019-04-22 Thread Akhil Goyal
Hi Anoob, > > > > > > Hi Ayuj, Akhil, Fiona, Shally, > > > > > > I think there are couple of issues with this patch. The real issue > > > here is the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If > > > rte_crypto_asym.h doesn't include all the headers it uses, every file > > > which incl

[dpdk-dev] [PATCH] eventdev: add experimental tag back

2019-04-22 Thread Nikhil Rao
Add the experimental tag back to the Rx event adapter callback and the Rx event callback register functions. This patch also adds the experimental tag in the callback register function definition and adds the function to the EXPERIMENTAL section of the map file, these were missing previously. Fixe

Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers

2019-04-22 Thread Anoob Joseph
Hi Shally, Please see inline. Thanks, Anoob > -Original Message- > From: Shally Verma > Sent: Monday, April 22, 2019 6:23 PM > To: Anoob Joseph ; Ayuj Verma > ; akhil.go...@nxp.com; > arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com > Cc: Sunila Sahu ; Kanaka Durga Kotamarthy > ; Arvi

[dpdk-dev] [PATCH v7 3/3] doc/rcu: add lib_rcu documentation

2019-04-22 Thread Honnappa Nagarahalli
Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Marko Kovacevic --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 509 ++

[dpdk-dev] [PATCH v7 2/3] test/rcu_qsbr: add API and functional tests

2019-04-22 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Konstantin Ananyev --- app/test/Makefile |2 +

[dpdk-dev] [PATCH v7 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-22 Thread Honnappa Nagarahalli
Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

[dpdk-dev] [PATCH v7 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-22 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

Re: [dpdk-dev] [PATCH] net/i40e: fix crash when calling i40e_vsi_delete_mac

2019-04-22 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wangyunjian > Sent: Tuesday, April 16, 2019 10:05 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: xudingke ; sta...@dpdk.org; Lilijun (Jerry, > Cloud Networking) ; Zhang, Jerry > > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues

2019-04-22 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Qiming > Sent: Monday, April 22, 2019 2:58 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues > > > > -Original Mes

Re: [dpdk-dev] [PATCH] doc: update ICE doc

2019-04-22 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Tuesday, April 16, 2019 12:40 PM > To: Rami Rosen > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc > > Hi Rami, > > From: Rami Rosen [mailto:ramir...@gmail.com] > Sen

Re: [dpdk-dev] [PATCH] net/iavf: fix stats reset

2019-04-22 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Monday, April 22, 2019 10:19 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix stats reset > > stats_reset has been missed when support st

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection

2019-04-22 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Thomas Monjalon >Sent: Tuesday, April 23, 2019 2:51 AM >To: Pavan Nikhilesh Bhagavatula >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Marko >Kovacevic ; Ori Kam ; >Bruce Richardson ; Pablo de Lara >; Radu Nicolau ; >Akhil Goyal ; Tomasz Kantecki >; sta...@dp

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Xu, Rosen
Hi Thomas, Qian has some problem with his email. So some patch can't be found in patch work. For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > -Original Message- > From: Pei, Andy > Sent: Tuesday, April 23, 2019 9:19 > To: Thomas Monjalon ; Xu, Rose

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Pei, Andy
Hi Thomas, My patch is the same as LI Qiang's patch. I was told that Qiang's patch cannot get onto the patchwork, so I just help him do this. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, April 23, 2019 1:52 AM To: Xu, Rosen ; Pei, Andy Cc: sta...

Re: [dpdk-dev] [PATCH v6 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-22 Thread Honnappa Nagarahalli
> > On Tue, Apr 16, 2019 at 11:13:57PM -0500, Honnappa Nagarahalli wrote: > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock

[dpdk-dev] [dpdk-announce] release candidate 19.05-rc2

2019-04-22 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.05-rc2 More than 200 patches were integrated, including two new drivers (nfb and ipn3ke). The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_05.html The -rc3 should inc

Re: [dpdk-dev] [PATCH] doc: update release notes for windows support

2019-04-22 Thread Thomas Monjalon
10/04/2019 23:00, Pallavi Kadam: > Added documentation for Windows support on 19.05 release. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Anand Rawat > --- > +* **Added Windows Support.** > + > + * Added Windows support to compile and build Hello World Sample > Application. > + * Added Win

Re: [dpdk-dev] [PATCH v5] doc: add meson ut info in prog guide

2019-04-22 Thread Thomas Monjalon
02/02/2019 11:28, Hari Kumar Vemula: > --- /dev/null > +++ b/doc/guides/prog_guide/meson_ut.rst > @@ -0,0 +1,143 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + > +Copyright(c) 2018-2019 Intel Corporation. Why inserting a blank line between SPDX and Copyright. > + > +.. _Meson: > + > +Mes

Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface

2019-04-22 Thread Thomas Monjalon
29/03/2019 11:22, Lukasz Krakowiak: > Updated doc for JSON sample code related to vm_power_manager > fifo interface: "command": "destroy", "command": "power". > Corrected typo in doc vm_power_management.rst: 'json' instead > of 'jason'. > > --- > v2: > * coding style improved > > Signed-off-by: L

Re: [dpdk-dev] [PATCH] doc: fix heading levels in bbdev test guide

2019-04-22 Thread Thomas Monjalon
> > The section "Test Vector files" should not be at the same level as the > > main title "dpdk-test-bbdev Application". > > > > Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") > > Cc: sta...@dpdk.org > > Cc: amr.mokh...@intel.com > > Good catch. > > Acked-by: John McNamara

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value

2019-04-22 Thread Thomas Monjalon
> > Checking the return value of rte_metrics_update_values, if failed > > returning that value. > > Coverity had picked up that that the return value wasn't being checked. > > > > Coverity issue: 336863 > > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > > Cc: remy.hor...@intel.c

Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-22 Thread Thomas Monjalon
15/04/2019 11:21, Hunt, David: > On 12/4/2019 4:57 PM, Lee Daly wrote: > > This patch will ensure the correct max frequency of a core is set in > > the lcore_power_info struct when disabling turbo, while using the > > intel pstate driver. > > > > Fixes: e6c6dc0f96c8 ("power: add p-state driver comp

Re: [dpdk-dev] [PATCH v2] examples/vm_power: add conditional compilation for PMD specific code

2019-04-22 Thread Thomas Monjalon
18/04/2019 16:23, Hunt, David: > On 2/4/2019 7:46 PM, David Christensen wrote: > > Running the devtools/test-build.sh script on IBM Power systems fails > > because the IXGBE_PMD is explicity disabled for Power as an untested > > driver, but the examples/vm_power_manager application has a hard > > d

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix buffer overrun

2019-04-22 Thread Thomas Monjalon
10/04/2019 14:49, David Hunt: > The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, > yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS, > which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to > RTE_MAX_LCORE_FREQS. > > Fixes: d26c18c93260 ("e

Re: [dpdk-dev] [PATCH v3 0/5] some small fixes

2019-04-22 Thread Thomas Monjalon
> Bruce Richardson (5): > examples/vhost_scsi: fix header check for meson build > examples/vhost_scsi: fix missing NULL-check for parameter > net/i40e: fix dereference before NULL check in mbuf release > app/testpmd: fix variable use before NULL check > net/i40e: fix dereference before ch

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix overflowed value

2019-04-22 Thread Thomas Monjalon
11/04/2019 14:07, Burakov, Anatoly: > On 11-Apr-19 12:13 PM, Reshma Pattan wrote: > > Fix the data type of last_branches, last_branch_misses > > from unit32_t to uint64_t, and for hits_diff, miss_diff > > from int to int64_t respectively to fix possible > > overflow or truncation. > > > > Coverity

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow

2019-04-22 Thread Thomas Monjalon
15/04/2019 16:45, Hunt, David: > On 10/4/2019 3:54 PM, Reshma Pattan wrote: > > Use strlcpy instead of strcpy to fix string overflow. > > > > Coverity issue: 337671 > > Fixes: a63504a90f ("examples/power: add JSON string handling") > > CC: david.h...@intel.com > > CC: sta...@dpdk.org > > > > Signed

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection

2019-04-22 Thread Thomas Monjalon
10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, l3wfd em mode has two datapath modes em_sequential and > em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to > one or zero. > The code checks if NO_HASH_MULTI_LOOKUP is defined or not instea

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination

2019-04-22 Thread Thomas Monjalon
15/04/2019 16:50, Hunt, David: > On 9/4/2019 5:00 PM, Reshma Pattan wrote: > > After the read() the jason_data null termination is missing > > for the case "indent < 0", for "indent > 0" and "indent == 0" > > cases null termination is already handled. > > > > So add the missing case "indent < 0" to

Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code

2019-04-22 Thread Thomas Monjalon
> > A for loop to MAX_VFS had a break as the last line, so the w++ > > would never get called, breaking out of the loop after the > > first iteration. Remove the break so that the loop can execute > > properly. > > > > Fixes: ace158c4a821 ("examples/vm_power: add check for port count") > > Coverity

Re: [dpdk-dev] [PATCH v1] examples/power: fix vm power manager resource leak

2019-04-22 Thread Thomas Monjalon
09/04/2019 11:43, David Hunt: > Fixes: 99a968fac0cf ("examples/vm_power: add core list parameter") > Coverity issue: 337674 > > Signed-off-by: David Hunt Applied, thanks

Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues

2019-04-22 Thread Thomas Monjalon
09/04/2019 13:18, Burakov, Anatoly: > On 09-Apr-19 10:22 AM, David Hunt wrote: > > A previous change removed the limit of 64 cores by > > moving away from 64-bit masks to char arrays. However > > this left a buffer overrun issue, where the max channels > > was defined as 64, and max cores was defin

Re: [dpdk-dev] [PATCH v2 0/3] test: improve test coverage for power library

2019-04-22 Thread Thomas Monjalon
> Lukasz Krakowiak (3): > test: rename test_power_acpi_cpufreq.c -> > app/test/test_power_cpufreq.c > test: remove prefix _acpi from UT power function/test names > test: add UT for power turbo feature No review, no merge, sorry.

Re: [dpdk-dev] [PATCH v2 0/2] power: add fifo per core for JSON interface

2019-04-22 Thread Thomas Monjalon
12/04/2019 15:54, Lukasz Gosiewski: > This patch implement a separate FIFO for each cpu core. > Dependency to commit: 5c7c96571b7b7051ecc286f36be0b3d95b49995e > (power: update for handling fifo path string). > > Lukasz Krakowiak (2): > power: add fifo per core for JSON interface > doc: update

Re: [dpdk-dev] [PATCH v5 0/4] bidirect guest channel

2019-04-22 Thread Thomas Monjalon
05/04/2019 15:24, Hajkowski: > From: Marcin Hajkowski > > Extend guest channel API to allow bidirectional > communication. Modify power manager host and guest > side to communicate in both directions. This patchset is deferred to 19.08 because of a lack of review. Note: too many librte_power pa

Re: [dpdk-dev] [PATCH 0/3] rte_power enhancement

2019-04-22 Thread Thomas Monjalon
> Marcin Hajkowski (3): > power: return error in set env when power env already set > power: reset function pointers on unset env > power: add UTs for all power env types Applied, thanks

Re: [dpdk-dev] [PATCH] power: fix non thread-safe power env modification

2019-04-22 Thread Thomas Monjalon
05/04/2019 16:35, Hajkowski: > From: Marcin Hajkowski > > Due to lack of thread safety in exisiting solution > use spinlock mechanism for atomic > modification of power environment related data. > > Fixes: 445c6528b5 ("power: common interface for guest and host") > Cc: sta...@dpdk.org > > Signe

Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list

2019-04-22 Thread Thomas Monjalon
> > Removed dependency to mac_list from policies: > > * BRANCH_RATIO, > > * WORKLOAD, > > * TIME > > in function update_policy. > > > > Fixes: 1b897991473f ("power: update error handling") > > > > Signed-off-by: Lukasz Krakowiak > > Acked-by: David Hunt Applied, thanks

Re: [dpdk-dev] [PATCH v6 0/2] app/pdump: enhance to support unique cores

2019-04-22 Thread Thomas Monjalon
04/04/2019 10:55, Vipin Varghese: > The patch series enhances application to support pdump capture to run > on unique cores. > > Motivation > == > > DPDK pdump capture tool currently runs as secondary on the default core 0. > For all --pdump, core 0 iterates and capture packets. This lead

Re: [dpdk-dev] [PATCH v3] app/testbbdev: fix sprintf with snprintf or strlcpy

2019-04-22 Thread Thomas Monjalon
09/04/2019 15:05, Pallantla Poornima: > sprintf function is not secure as it doesn't check the length of string. > More secure function snprintf and strlcpy is used. > > Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") > Cc: sta...@dpdk.org > > Signed-off-by: Pallantla Poornima

Re: [dpdk-dev] [PATCH] test/timer: exercise new APIs in secondary process

2019-04-22 Thread Thomas Monjalon
18/04/2019 23:00, Erik Gabriel Carrillo: > This commit adds an autotest which exercises new timer reset/stop APIs > in a secondary process. Timers are created, and sometimes stopped, in > the secondary process, and their expiration is checked for and handled > in the primary process. > > Signed-of

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-22 Thread Shahaf Shuler
‫ב-22 באפר׳ 2019, בשעה 21:06, ‏‏Ori Kam ‏ כתב/ה:‬ > When creating the modify action using Direct Rules, we need to > add flags to mark, if the action will be done on root table or on > private table. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > > Signed-off-by: Ori Kam Acked-b

[dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-22 Thread Ori Kam
When creating the modify action using Direct Rules, we need to add flags to mark, if the action will be done on root table or on private table. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- v3: * Address ML comments. v2: * Change title. --- drivers/net/mlx

[dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-22 Thread Ori Kam
When creating the modify action using Direct Rules, we need to add flags to mark, if the action will be done on root table or on private table. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- v3: * Address ML comments. v2: * Change title. --- drivers/net/mlx

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Thomas Monjalon
> > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > > opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns > > -EINVAL > > when 'stat' returns error > > > > Coverity issue: 27944

Re: [dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak

2019-04-22 Thread Yongseok Koh
> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec > wrote: > > When sending multiple requests, rte_mp_request_sync > can succeed sending a few of those requests, but then > fail on a later one and in the end return with rc=-1. > The upper layers - e.g. device hotplug - currently > handles this

Re: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter if no DevX enabled

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 3:38 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix query host adapter if no DevX > enabled > > If there is the support of DevX is exposed by rdma-core but DevX is not > supported by or disabled for the specific interface the > mlx5_devx_cmd_query_hca_

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build

2019-04-22 Thread Shahaf Shuler
Saturday, April 20, 2019 3:03 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Direct Rules build > > All the library calls must be called via the glue layer. > > Fixes: b2177648b8de ("net/mlx5: add Direct Rules flow data alloc/free > routines") > Fixes: 79e35d0d5979 ("net/mlx5: shar

Re: [dpdk-dev] [PATCH] net/mlx5: fix typos replacing between Rx and Tx

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 6:24 PM, Dekel Peled: > Subject: [PATCH] net/mlx5: fix typos replacing between Rx and Tx > > In mlx5_rxq.c, in some comments, text includes "Tx" instead of "Rx". > In mlx5_txq.c, in some comments, text includes "Rx" instead of "Tx". > > This patch fixes these typos. > > Fi

Re: [dpdk-dev] [PATCH] net/mlx5: replace a port lookup with ethdev API

2019-04-22 Thread Shahaf Shuler
Thursday, April 18, 2019 3:15 AM, Thomas Monjalon: > Subject: [PATCH] net/mlx5: replace a port lookup with ethdev API > > Looking for an ethdev port is better (and more efficient) with an ethdev API > than an EAL one. > > Signed-off-by: Thomas Monjalon Applied to next-net-mlx, thanks.

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing init for flow group

2019-04-22 Thread Shahaf Shuler
Wednesday, April 17, 2019 2:08 AM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix missing init for flow group > > On Sun, Apr 14, 2019 at 08:18:55PM +, Ori Kam wrote: > > the flow group should be initialized. > > For example selecting if the encapsulation is for root or private > > tables

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-22 Thread Mattias Rönnblom
On 2019-04-22 17:52, Mattias Rönnblom wrote: On 2019-04-22 13:34, Neil Horman wrote: +uint64_t __rte_experimental +rte_rand(void) Do you really want to mark this as experimental?  I know it will trigger the symbol checker with a warning if you don't, but this function already existed previous

Re: [dpdk-dev] [PATCH] reorder: add checks for invalid function inputs

2019-04-22 Thread Thomas Monjalon
> > For APIs which can return an error value, do sanity checking of the input > > parameters for NULL and return a suitable error value for those cases. > > > > NOTE: The drain function is currently omitting NULL checks too, but this > > function has no way to flag an error value, so checking in t

Re: [dpdk-dev] [RFC v2 11/14] net: add rte prefix to ip defines

2019-04-22 Thread Stephen Hemminger
On Wed, 10 Apr 2019 10:32:15 +0200 Olivier Matz wrote: > diff --git a/app/test-acl/main.c b/app/test-acl/main.c > index b80179417..eb6294396 100644 > --- a/app/test-acl/main.c > +++ b/app/test-acl/main.c > @@ -625,7 +625,7 @@ parse_ipv4_net(const char *in, uint32_t *addr, uint32_t > *mask_len) >

Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures

2019-04-22 Thread Stephen Hemminger
On Wed, 10 Apr 2019 10:32:05 +0200 Olivier Matz wrote: > diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c > b/drivers/net/bonding/rte_eth_bond_pmd.c > index f30422a6d..9c5425ef5 100644 > --- a/drivers/net/bonding/rte_eth_bond_pmd.c > +++ b/drivers/net/bonding/rte_eth_bond_pmd.c > @@ -489,9 +4

Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures

2019-04-22 Thread Stephen Hemminger
On Wed, 10 Apr 2019 10:32:05 +0200 Olivier Matz wrote: > Add 'rte_' prefix to structures: > - rename struct arp_hdr as struct rte_arp_hdr. > - rename struct arp_ipv4 as struct rte_arp_ipv4. > > Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields > to avoid conflict with the #defines

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-22 Thread Mattias Rönnblom
On 2019-04-22 13:34, Neil Horman wrote: +uint64_t __rte_experimental +rte_rand(void) Do you really want to mark this as experimental? I know it will trigger the symbol checker with a warning if you don't, but this function already existed previously and was accepted as part of the ABI. Given

[dpdk-dev] [PATCH] net/mlx5: fix typos replacing between Rx and Tx

2019-04-22 Thread Dekel Peled
In mlx5_rxq.c, in some comments, text includes "Tx" instead of "Rx". In mlx5_txq.c, in some comments, text includes "Rx" instead of "Tx". This patch fixes these typos. Fixes: faf2667fe8d5 ("net/mlx5: separate DPDK from verbs Tx queue objects") Fixes: a1366b1a2be3 ("net/mlx5: add reference counter

[dpdk-dev] [PATCH v5 0/1] New software event timer adapter

2019-04-22 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD [1]. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To impr

[dpdk-dev] [PATCH v5 1/1] eventdev: add new software event timer adapter

2019-04-22 Thread Erik Gabriel Carrillo
This patch introduces a new version of the event timer adapter software PMD. In the original design, timer event producer lcores in the primary and secondary processes enqueued event timers into a ring, and a service core in the primary process dequeued them and processed them further. To improve

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix pool usage for security session

2019-04-22 Thread Akhil Goyal
Currently, two separate mempools are being used for creating crypto sessions and its private data. crypto sessions are created and initialized separately, so a separate mempool is passed to each API, but in case of security sessions, where only one API create and initialize the private data as well

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-22 Thread Stephen Hemminger
On Mon, 22 Apr 2019 07:34:20 -0400 Neil Horman wrote: > > + > > +uint64_t __rte_experimental > > +rte_rand(void) > Do you really want to mark this as experimental? I know it will trigger the > symbol checker with a warning if you don't, but this function already existed > previously and was ac

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags

2019-04-22 Thread Ori Kam
Hi Shahaf, PSB Thanks, Ori > -Original Message- > From: Shahaf Shuler > Sent: Monday, April 22, 2019 4:18 PM > To: Ori Kam ; Yongseok Koh > Cc: dev@dpdk.org; Ori Kam > Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags > > Monday, April 22, 2019 3:34 PM, Ori Ka

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix big endian build

2019-04-22 Thread Thomas Monjalon
> > Compilation was failing when using a big endian toolchain: > > > > rte_mbuf.h:504:2: error: expected ',' or '}' before 'RTE_MBUF_L3_LEN_OFS' > > > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > > Cc: konstantin.anan...@intel.com > > > > Signed-off-by: Thomas

Re: [dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound

2019-04-22 Thread Wiles, Keith
> On Apr 22, 2019, at 2:07 AM, Mattias Rönnblom > wrote: > > On 2019-04-22 06:33, Wiles, Keith wrote: > >>> From a performance point of view, the high-loop-count cases are rare enough >>> not to pose a serious threat. For example, being forced to redo rte_rand() >>> more than five times is

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags

2019-04-22 Thread Shahaf Shuler
Monday, April 22, 2019 3:34 PM, Ori Kam: > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags > > When creating the modify action using Direct Rules, we need to add flags to > mark, if the action will be done on root table or on private table. > > Fixes: 4f84a19779ca ("net/mlx

Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers

2019-04-22 Thread Shally Verma
Hi Anoob > -Original Message- > From: Anoob Joseph > Sent: Thursday, April 18, 2019 9:28 AM > To: Ayuj Verma ; akhil.go...@nxp.com; > arkadiuszx.kusz...@intel.com; fiona.tr...@intel.com > Cc: Shally Verma ; Sunila Sahu ; > Kanaka Durga Kotamarthy ; Arvind Desai > ; dev@dpdk.org; Ayuj Verma

Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable

2019-04-22 Thread Thomas Monjalon
> > Promote the adapter functions and rte_event_port_unlinks_in_progress() > > as stable as it's been added for a while now and multiple drivers and test > > application like test-eventdev has been tested using the adapter APIs. > > > > Cc: nikhil@intel.com > > Cc: erik.g.carri...@intel.com >

Re: [dpdk-dev] [PATCH] bus/vmbus: fix resource leak on error

2019-04-22 Thread Thomas Monjalon
17/04/2019 20:45, Stephen Hemminger: > If secondary process attempt to mmap the resource resulted in > the wrong address, then it would leave behind the bad mmap. > > Coverity issue: 337675, 337664 > Signed-off-by: Stephen Hemminger Fixes: 2a28a502c607 ("bus/vmbus: map ring in secondary process"

[dpdk-dev] [PATCH] net/mlx5: fix query host adapter if no DevX enabled

2019-04-22 Thread Viacheslav Ovsiienko
If there is the support of DevX is exposed by rdma-core but DevX is not supported by or disabled for the specific interface the mlx5_devx_cmd_query_hca_attr() routine returns an error preventing the device from successful probing. The routine should be invoked only in case of enabled DevX. Fixes:

[dpdk-dev] [PATCH v2] net/mlx5: fix modification action flags

2019-04-22 Thread Ori Kam
When creating the modify action using Direct Rules, we need to add flags to mark, if the action will be done on root table or on private table. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- v2: * Change title of commit. --- drivers/net/mlx5/mlx5_flow.h|

[dpdk-dev] [PATCH] net/mlx5: fix encapsulation action flags

2019-04-22 Thread Ori Kam
When creating the encapsulation action using Direct Rules, we need to add flags to mark, if the action will be done on root table or on private table. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.h| 1 + drivers/net/mlx5/mlx5_f

Re: [dpdk-dev] [PATCH 0/5] trivial blank line at end of file cleanup

2019-04-22 Thread Thomas Monjalon
10/04/2019 20:05, Stephen Hemminger: > Ran script that looks for extra whitespace (what git and checkpatch > complain about). Found several trival cases of extra line at > end of file. > > Stephen Hemminger (5): > vhost: eliminate blank line at EOF > net/atlantic: remove extra blank line at EO

Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR

2019-04-22 Thread Neil Horman
On Fri, Apr 19, 2019 at 11:21:37PM +0200, Mattias Rönnblom wrote: > This commit replaces rte_rand()'s use of lrand48() with a DPDK-native > combined Linear Feedback Shift Register (LFSR) (also known as > Tausworthe) pseudo-number generator, with five sequences. > > This generator is faster and pro

Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable

2019-04-22 Thread Rao, Nikhil
> -Original Message- > From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Friday, April 19, 2019 5:41 PM > To: dev@dpdk.org; Thomas Monjalon ; Jerin Jacob > ; Mattias Rönnblom > ; Van Haaren, Harry > ; Gujjar, Abhinandan S > ; Rao, Nikhil ; > Carrillo, Erik G > Cc: pbhagavat..

[dpdk-dev] [PATCH v5 1/3] ethdev: add actions to modify TCP header fields

2019-04-22 Thread Dekel Peled
Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

[dpdk-dev] [PATCH v5 3/3] net/mlx5: update modify header using Direct Verbs

2019-04-22 Thread Dekel Peled
This patch implements additional actions of packet header modifications. Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP

[dpdk-dev] [PATCH v5 0/3] add actions to modify header fields

2019-04-22 Thread Dekel Peled
Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2]. This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD. Original work by Xiaoyu Min. [1] http://patches.dpdk.org/patch/49

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add actions to modify TCP header fields

2019-04-22 Thread Dekel Peled
Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

Re: [dpdk-dev] [PATCH v2] eventdev: promote adapter functions as stable

2019-04-22 Thread Thomas Monjalon
> > Promote the adapter functions and rte_event_port_unlinks_in_progress() > > as stable as it's been added for a while now and multiple drivers and test > > application like test-eventdev has been tested using the adapter APIs. > > > > Cc: nikhil@intel.com > > Cc: erik.g.carri...@intel.com >

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add actions to modify TCP header fields

2019-04-22 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Adrien Mazarguil > Sent: Thursday, April 18, 2019 3:31 PM > To: Dekel Peled > Cc: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; arybche...@solarflare.com; > dev@dpdk.org; Ori Kam > S

Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues

2019-04-22 Thread Rami Rosen
Fix the issues reported by Coverity check, "Null-checking vsi suggests that it may be null, but it has already been dereferenced on all paths leading to the check." Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Fixes: ff963bfa7cb1 ("net/ice: support RSS") Cc: sta...@dpdk.org Signed-off-by: We

Re: [dpdk-dev] [RFC v2 2/2] eal: introduce random generator function with upper bound

2019-04-22 Thread Mattias Rönnblom
On 2019-04-22 06:33, Wiles, Keith wrote: From a performance point of view, the high-loop-count cases are rare enough not to pose a serious threat. For example, being forced to redo rte_rand() more than five times is only a ~3% risk. Even a few loops can have an effect on performance when we