[dpdk-dev] How to set up meson cross build?

2019-04-29 Thread Ruifeng Wang (Arm Technology China)
Hi Luca, I'm setting up a cross compiling environment, and hit meson cross compiling issue. Could you take a look and help? I have installed cross toolchain and numactl according to https://doc.dpdk.org/guides/linux_gsg/cross_build_dpdk_for_arm64.html Currently, cross compiling with 'make' is s

Re: [dpdk-dev] [PATCH] ethdev: add size and align to compose dma zone name strings

2019-04-29 Thread David Marchand
On Sat, Apr 27, 2019 at 11:48 AM wangyunjian wrote: > From: Yunjian Wang > > The current dma zone name consists of the port_id, queue_id and > ring_name. If a port_id is reused, a new nic maybe use same dma > zone name. At this time, the zone size of the new driver is > differnt. When the zone i

[dpdk-dev] [PATCH 00/11] Aquantia atlantic bugfixes

2019-04-29 Thread Igor Russkikh
This patchset contains various bugfixes found during verification and integration testing. Most notable is eeprom access cleanup, fix for broadcast filter, flow control logic tracking, some code style cleanups. Igor Russkikh (7): net/atlantic: enable broadcast traffic net/atlantic: extra line

[dpdk-dev] [PATCH 04/11] net/atlantic: eeprom get/set should consider offset

2019-04-29 Thread Igor Russkikh
From: Pavel Belous EEPROM get/set offset logic should take offset into account. Data transfers to/from FW should also correctly use dword based transfer interface, taking into account the remainder. We also check error code returned from FW. cc: sta...@dpdk.org Fixes: ce4e8d418097 ("net/atlantic

[dpdk-dev] [PATCH 05/11] net/atlantic: fix max eeprom size

2019-04-29 Thread Igor Russkikh
Maximum size should be 256 bytes. Move declaration to the top of the file Fixes: ce4e8d418097 ("net/atlantic: implement EEPROM get/set") Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous cc: sta...@dpdk.org --- drivers/net/atlantic/atl_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1

[dpdk-dev] [PATCH 02/11] net/atlantic: extra line at eof

2019-04-29 Thread Igor Russkikh
Remove extra empty line at EOF Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_rxtx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index f1519594adad..fe0077044097 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b

[dpdk-dev] [PATCH 01/11] net/atlantic: enable broadcast traffic

2019-04-29 Thread Igor Russkikh
Broadcast was not correctly and fully initialized Signed-off-by: Igor Russkikh Fixes: 7906661edac6 ("net/atlantic: add b0 hardware layer") cc: sta...@dpdk.org --- drivers/net/atlantic/hw_atl/hw_atl_b0.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_b0.c

[dpdk-dev] [PATCH 09/11] net/atlantic: use capability bits to detect eeprom access

2019-04-29 Thread Igor Russkikh
From: Pavel Belous Its better to use capability bits FW provides to detect whether firmware has APIs for EEPROM access. Before that explicit FW version comparison was used and that may cause conflicts. Signed-off-by: Igor Russkikh Signed-off-by: Pavel Belous --- drivers/net/atlantic/hw_atl/h

[dpdk-dev] [PATCH 07/11] net/atlantic: bad logic with offsets talking with firmware

2019-04-29 Thread Igor Russkikh
From: Pavel Belous eeprom write accesses start using non zero configuration memory accesses. This revealed an issue where firmware interface was actually always did the uploads starting with zero offset Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") cc: sta...@dpdk.org Signe

[dpdk-dev] Crypto-dev schedular - Support for multiple crypto algorithms concurrently

2019-04-29 Thread Jitendra Saini
Hi All, Context: Using dpdk + vpp for telecom network user plane processing Desired: want to use dpdk crypto-dev scheduler to have 2 cores dedicated for crypto operations Issue: crypto devices of different types (AES_MB & AES_GCM) are not supported concurrently. Query: Have anyone used crypto sche

[dpdk-dev] [PATCH 03/11] net/atlantic: bad indentation

2019-04-29 Thread Igor Russkikh
Make indentation correct. No functional impact. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index 4

[dpdk-dev] [PATCH 06/11] net/atlantic: validity check for eeprom dev address

2019-04-29 Thread Igor Russkikh
Clients may not fillin magic field, thus causing garbage to be passed as a device addr. Limit that to maximum SMbus address. Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/

[dpdk-dev] [PATCH 10/11] net/atlantic: typo on args check

2019-04-29 Thread Igor Russkikh
Found by coverity scan, two pointer args should be not zero checked Coverity issue: 337929 Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[dpdk-dev] [PATCH 08/11] net/atlantic: flow control settings synchronization on rx

2019-04-29 Thread Igor Russkikh
From: Pavel Belous Driver should track negotiated PHY flow control settings during link state changes and update MAC level flow control configuration. Otherwise there could be unexpected pause frames generation which could lockup the datapath. Fixes: 4c1c8f76463f ("net/atlantic: add flow contro

[dpdk-dev] [PATCH 11/11] net/atlantic: extra err check

2019-04-29 Thread Igor Russkikh
Found by coverity scan - dead code Coverity issue: 337665 Fixes: 7943ba05f67c ("net/atlantic: add link status and interrupt management") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/d

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags

2019-04-29 Thread Shahaf Shuler
Monday, April 22, 2019 10:03 PM, Shahaf Shuler: > Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modification action flags > > > ‫ב-22 באפר׳ 2019, בשעה 21:06, ‏‏Ori Kam ‏ כתב/ה:‬ > > > When creating the modify action using Direct Rules, we need to add > > flags to mark, if the action will be d

Re: [dpdk-dev] [PATCH v3 0/2] net/mlx5: share Memory Regions for multiport devices

2019-04-29 Thread Shahaf Shuler
Saturday, April 27, 2019 7:33 AM, Viacheslav Ovsiienko: > Subject: [PATCH v3 0/2] net/mlx5: share Memory Regions for multiport > devices > > The patches [1] and [2] are both related to Memory Regions sharing and their > applying order matters, this series just combines ones. > > The multiport Inf

Re: [dpdk-dev] [PATCH] net/mlx5: inherit master link settings for representors

2019-04-29 Thread Shahaf Shuler
Saturday, April 27, 2019 7:20 AM¸ Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH] net/mlx5: inherit master link settings for > representors > > There are some physical link settings can be queried from Ethernet devices: > link status, link speed, speed capabilities, duplex mode, etc. These set

Re: [dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface

2019-04-29 Thread Shahaf Shuler
Thursday, April 18, 2019 4:11 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx4: add support for multicast address list interface > > Since this driver does not distinguish unicast/multicast addresses, > applications could always rely on the standard MAC add/remove/set > interface to configure bot

Re: [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support.

2019-04-29 Thread Burakov, Anatoly
On 28-Apr-19 5:58 AM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add an exit_with_primary option to make pdump exit with primary. Suggested-by: Varghese, Vipin Suggested-by: Burakov, Anatoly Signed-off-by: Suanming.Mou --- ap

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Ferruh Yigit
On 4/28/2019 5:23 PM, Stephen Hemminger wrote: > On Sun, 28 Apr 2019 17:58:48 +0300 > Arnon Warshavsky wrote: > > These deprecation notices are unnecessary. These are not public API's. +1 > >> +* eal: Modify function return value for the sake of removing rte_panic >> + from the init sequ

Re: [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support.

2019-04-29 Thread Suanming . Mou
On 2019/4/29 17:14, Burakov, Anatoly wrote: On 28-Apr-19 5:58 AM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add an exit_with_primary option to make pdump exit with primary. Suggested-by: Varghese, Vipin Suggested-by: Burakov,

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-04-29 Thread Thomas Monjalon
25/04/2019 17:27, Ferruh Yigit: > On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > > 25/04/2019 13:47, Ferruh Yigit: > >> On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > >>> 25/04/2019 00:03, Ferruh Yigit: > This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > > Not all PMDs

[dpdk-dev] [PATCH v1] hash: simplify signature compare neon process

2019-04-29 Thread Ruifeng Wang
Replaced multiple neon instructions with single equivalent instruction. This made simpler code and a bit higher performance. Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 platforms. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- lib/librte_hash/rte_cuckoo_hash.c | 1

Re: [dpdk-dev] Editor Config

2019-04-29 Thread Ray Kinsella
+1, nice idea. On 26/04/2019 13:50, Wiles, Keith wrote: > > >> On Apr 26, 2019, at 3:13 AM, Burakov, Anatoly >> wrote: >> >> On 25-Apr-19 6:19 PM, Stephen Hemminger wrote: >>> Systemd uses this and it looks like a useful addition to the DPDK source >>> base. Especially since we now have Window

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes

2019-04-29 Thread Mohammad Abdul Awal
On 24/04/2019 13:37, Jasvinder Singh wrote: Add deprecation note for making changes in data structures, APIs and macros in order to have more traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes and queues, etc. These changes are aligned to i

Re: [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support.

2019-04-29 Thread Burakov, Anatoly
On 29-Apr-19 10:43 AM, Suanming.Mou wrote: :)     /* true if x is a power of 2 */   #define POWEROF2(x) x)-1) & (x)) == 0) @@ -143,12 +147,14 @@ struct parse_val {   static struct rte_eth_conf port_conf_default;   static volatile uint8_t quit_signal;   static uint8_t multiple_core_captu

Re: [dpdk-dev] [PATCH v3] vhost: support inflight share memory protocol feature

2019-04-29 Thread Tiwei Bie
On Mon, Apr 29, 2019 at 12:07:05PM +0800, lin li wrote: > Tiwei Bie 于2019年4月28日周日 下午7:18写道: > > On Fri, Apr 26, 2019 at 05:40:21AM -0400, Li Lin wrote: [...] > > > @@ -98,12 +102,26 @@ struct rte_vhost_memory { > > > struct rte_vhost_mem_region regions[]; > > > }; > > > > > > +typedef struc

[dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files

2019-04-29 Thread Dekel Peled
During work on Rx feature I did some cleanup actions. This series includes those changes divided by their type. Dekel Peled (4): net/mlx5: remove unused functions net/mlx5: add missing validation of null pointer net/mlx5: fix description of function return value net/mlx5: move locally used

[dpdk-dev] [PATCH 3/4] net/mlx5: fix description of function return value

2019-04-29 Thread Dekel Peled
Return value of function mlx5_rxq_releasable() was not described correctly in function description. This patch updates the description to correctly describe the optional return values. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") cc: sta...@dpdk.org Signed-off-by: Dekel

[dpdk-dev] [PATCH 2/4] net/mlx5: add missing validation of null pointer

2019-04-29 Thread Dekel Peled
Function mlx5_rxq_ibv_release() is called in several places. Before each call except one, the input parameter is validated to make sure it is not null. This patch adds the missing validation where it is missing. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_rxq.c | 3 ++- 1 file changed,

[dpdk-dev] [PATCH 1/4] net/mlx5: remove unused functions

2019-04-29 Thread Dekel Peled
Functions implemented but never called: mlx5_rxq_ibv_releasable() mlx5_rxq_cleanup() mlx5_txq_ibv_releasable() Function declared but not implemented: rxq_alloc_mprq_buf() This patch removes these functions from code and header file. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_rxq.c |

[dpdk-dev] [PATCH 4/4] net/mlx5: move locally used functions to static

2019-04-29 Thread Dekel Peled
Multiple functions were declared in header file mlx5_rxtx.h, inplemented in mlx5_rxq.c, and called only in mlx5_rxq.c. This patch moves all these functions declarations into mlx5_rxq.c, as static functions. Some functions implementation was copied higher in the file to precede the functions calls.

Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number

2019-04-29 Thread Zhang, Qi Z
> -Original Message- > From: Xiao, QimaiX > Sent: Sunday, April 28, 2019 2:51 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Peng, Yuan > > Subject: RE: [PATCH] net/i40e: remove useless check for queue number > > Tested-by: Xiao, QimaiX > > -Original Mess

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Burakov, Anatoly
On 25-Apr-19 6:17 PM, Herakliusz Lipiec wrote: When secondary to primary process synchronization occours there is no check for number of fds which could cause buffer overrun. Bugzilla ID: 252 Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: rasl...@mellanox.com C

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Ferruh Yigit
On 4/25/2019 6:17 PM, Herakliusz Lipiec wrote: > When secondary to primary process synchronization occours > there is no check for number of fds which could cause buffer overrun. > > Bugzilla ID: 252 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") > Cc: rasl...@mell

Re: [dpdk-dev] [PATCH 02/11] net/atlantic: extra line at eof

2019-04-29 Thread Ferruh Yigit
On 4/29/2019 9:20 AM, Igor Russkikh wrote: > Remove extra empty line at EOF > > Signed-off-by: Igor Russkikh > --- > drivers/net/atlantic/atl_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c > index f1519594adad..fe

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Wiles, Keith
> On Apr 25, 2019, at 10:17 AM, Lipiec, Herakliusz > wrote: > > When secondary to primary process synchronization occours > there is no check for number of fds which could cause buffer overrun. > > Bugzilla ID: 252 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary

[dpdk-dev] [PATCH] ipc: handle more invalid parameter cases

2019-04-29 Thread Anatoly Burakov
Length of buffer and number of fd's to send are signed values, so they can be negative, but the API doesn't check for that. Fix it by checking for negative values as well. Fixes: bacaa2754017 ("eal: add channel for multi-process communication") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Burakov, Anatoly
On 29-Apr-19 2:53 PM, Ferruh Yigit wrote: On 4/25/2019 6:17 PM, Herakliusz Lipiec wrote: When secondary to primary process synchronization occours there is no check for number of fds which could cause buffer overrun. Bugzilla ID: 252 Fixes: c9aa56edec8e ("net/tap: access primary process queues

Re: [dpdk-dev] [PATCH v2] net/tap: fix potential buffer overrun

2019-04-29 Thread Burakov, Anatoly
On 29-Apr-19 2:58 PM, Wiles, Keith wrote: On Apr 25, 2019, at 10:17 AM, Lipiec, Herakliusz wrote: When secondary to primary process synchronization occours there is no check for number of fds which could cause buffer overrun. Bugzilla ID: 252 Fixes: c9aa56edec8e ("net/tap: access primary p

[dpdk-dev] [PATCH] ipc: harden message receive function

2019-04-29 Thread Anatoly Burakov
Currently, IPC does not check received messages for invalid data and passes them to user code unchanged. This may result in buffer overruns on reading message data. Fix this by checking the message length and fd number on receive, and discard any messages that are not valid. Fixes: bacaa2754017 ("

[dpdk-dev] [PATCH] test: load tests symbols from binary at init

2019-04-29 Thread David Marchand
Rather than call nm on the test application binary for each test to consider, call it once at the object init. Signed-off-by: David Marchand --- With a little patch of mine, before: # make O=master test /root/dpdk/master/app/test -c f -n 4 Filtering tests took 24s <=== Running tests with 4 work

[dpdk-dev] [PATCH] test: clean remaining trace of removed devargs ut

2019-04-29 Thread David Marchand
This test has been removed by the commit 83945fbd7c49 ("test: remove devargs unit tests") which left some trace in meson and reintroduced in autotest by the second commit 9eabcb682493 ("test: update autotest list"). Fixes: 83945fbd7c49 ("test: remove devargs unit tests") Fixes: 9eabcb682493 ("test

[dpdk-dev] [PATCH v2] doc: update references to removed function

2019-04-29 Thread Erik Gabriel Carrillo
Remove references to the (deleted) rte_event_port_enqueue_depth() function in the Doxygen comments for rte_event_enqueue_burst() and friends, and replace with references to rte_event_port_attr_get(). Fixes: 78ffab961155 ("eventdev: add port attribute function") Fixes: c9bf83947e2e ("eventdev: add

Re: [dpdk-dev] [PATCH] test: load tests symbols from binary at init

2019-04-29 Thread Burakov, Anatoly
On 29-Apr-19 3:28 PM, David Marchand wrote: Rather than call nm on the test application binary for each test to consider, call it once at the object init. Signed-off-by: David Marchand --- With a little patch of mine, before: # make O=master test /root/dpdk/master/app/test -c f -n 4 Filtering

Re: [dpdk-dev] [PATCH] net/bonding: fix test bonding MAC assignment

2019-04-29 Thread Ferruh Yigit
On 4/26/2019 11:30 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Fix test_set_bonded_port_initialization_mac_assignment so that it works > after 're run' test_link_bonding. > > Fixes: f2ef6f21ee2e ("bond: fix mac assignment to slaves") > Cc: declan.dohe...@intel.com > > Signed-off-b

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2019 10:28:36 +0100 Ferruh Yigit wrote: > > > > > >> +* kni: Modify function return value for the sake of removing rte_panic > >> + from the init sequence in version 19.08. > >> + - In ``lib/librte_kni/rte_kni_fifo.h`` replace > >> +``static void kni_fifo_init(struct

[dpdk-dev] DPDK and Link-time Optimizations

2019-04-29 Thread Mattias Rönnblom
Hi. Did anyone on the list successfully build DPDK with GCC Link-time Optimizations (LTO) enabled? I tried and failed a while back, although the detailed reasons of my failure eludes me for the moment. If LTO builds would work "out of the box", DPDK could gradually migrate from away from hav

Re: [dpdk-dev] [PATCH] net/bonding: fix test bonding MAC assignment

2019-04-29 Thread Chas Williams
Seems fine. Acked-by: Chas Williams On 4/29/19 10:56 AM, Ferruh Yigit wrote: On 4/26/2019 11:30 PM, kka...@marvell.com wrote: From: Krzysztof Kanas Fix test_set_bonded_port_initialization_mac_assignment so that it works after 're run' test_link_bonding. Fixes: f2ef6f21ee2e ("bond: fix mac

Re: [dpdk-dev] DPDK and Link-time Optimizations

2019-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2019 18:39:47 +0200 Mattias Rönnblom wrote: > Hi. > > Did anyone on the list successfully build DPDK with GCC Link-time > Optimizations (LTO) enabled? I tried and failed a while back, although > the detailed reasons of my failure eludes me for the moment. > > If LTO builds woul

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2019-04-29 Thread Ferruh Yigit
On 4/18/2019 11:59 AM, Thomas Monjalon wrote: > Hi all, > > Since DPDK 18.11, the behaviour of the close operation is changed > if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > port is released (i.e. totally freed and data erased) on close. > This new behaviour is enabled per driver for a m

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Ferruh Yigit
On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > Since 18.11, it is suggested that driver should release all its private > resources at the dev_close routine. So all resources previously released > in remove routine are now released at the dev_close routine, and the > dev_close routine will be called in

Re: [dpdk-dev] [PATCH v1 2/2] net/af_xdp: set MAC addrs field to NULL

2019-04-29 Thread Ferruh Yigit
On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > As af_xdp pmd doesn't allocate MAC addresses dynamically, it needs to be > set as NULL, so it won't be released by rte_eth_dev_release_port(), > otherwise, there would be "EAL: Error: Invalid memory" error. > > Signed-off-by: Xiaolong Ye > --- > drivers

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-04-29 Thread Ferruh Yigit
On 4/29/2019 5:24 PM, Stephen Hemminger wrote: > On Mon, 29 Apr 2019 10:28:36 +0100 > Ferruh Yigit wrote: > >>> >>> +* kni: Modify function return value for the sake of removing rte_panic + from the init sequence in version 19.08. + - In ``lib/librte_kni/rte_kni_fifo.h``

[dpdk-dev] [PATCH v3] net/tap: fix potential buffer overrun

2019-04-29 Thread Herakliusz Lipiec
When secondary to primary process synchronization occours there is no check for number of fds which could cause buffer overrun. Bugzilla ID: 252 Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") Cc: rasl...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Herakliusz Lip

[dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity

2019-04-29 Thread Yipeng Wang
rte_hash_hash is multi-thread safe but not multi-process safe because of the use of function pointers. Previous document and comment says the other way around. This commit fixes the issue. Fixes: fc1f2750a3ec ("doc: programmers guide") Fixes: 48a399119619 ("hash: replace with cuckoo hash implement

Re: [dpdk-dev] Hugepages not being deleted

2019-04-29 Thread Michael Santana Francisco
ping Hello, I am currently working on a patch to fix the eal_flags_autotest test as it currently fails on many platforms. I have made some progress, however I stumbled upon a possible issue with EAL and hugepages. Looking at the code and some documentation it appears to me that hupepages are

Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity

2019-04-29 Thread Dharmik Thakkar
> On Apr 29, 2019, at 4:40 AM, Yipeng Wang wrote: > > rte_hash_hash is multi-thread safe but not multi-process safe > because of the use of function pointers. Previous document > and comment says the other way around. This commit fixes > the issue. > > Fixes: fc1f2750a3ec ("doc: programmers gu

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Thomas Monjalon
29/04/2019 19:00, Ferruh Yigit: > On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > > Since 18.11, it is suggested that driver should release all its private > > resources at the dev_close routine. So all resources previously released > > in remove routine are now released at the dev_close routine, and th

Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2019-04-29 Thread Thomas Monjalon
29/04/2019 18:51, Ferruh Yigit: > On 4/18/2019 11:59 AM, Thomas Monjalon wrote: > > Hi all, > > > > Since DPDK 18.11, the behaviour of the close operation is changed > > if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > > port is released (i.e. totally freed and data erased) on close. > > Th

Re: [dpdk-dev] [PATCH v8 1/4] rcu: add RCU library supporting QSBR mechanism

2019-04-29 Thread Thomas Monjalon
> Compiled DPDK as both static library and shared library. > Ran UT on ARMv8 LS2088a DPAA2 platform, 3 to 8 cores were used, tests passed. > > Tested-by: Ruifeng Wang Hemant, did you have the opportunity to test it yourself?

[dpdk-dev] [PATCH 2/2] net/netvsc: free all queues on close

2019-04-29 Thread Stephen Hemminger
When dev_close is called, the netvsc driver will clean up all queues including the primary ring buffer. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 8 +-- drivers/net/netvsc/hn_rxtx.c | 39 -- drivers/net/netvsc/hn_var.h| 1 +

[dpdk-dev] [PATCH 1/2] net/netvsc: reset mbuf port on VF receive

2019-04-29 Thread Stephen Hemminger
Redo the receive logic to set m->port on packets received on VF. When using VF, still need to check for packets and completions arriving on the VMBus path even if application is not doing bursting (ie n_rx == 0). Also, fix comment. Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxt

[dpdk-dev] [PATCH 0/2] netvsc pmd fixes for 19.05

2019-04-29 Thread Stephen Hemminger
Netvsc needed to reset incoming port as was recently done for failsafe. Implement the new close semantics. Stephen Hemminger (2): net/netvsc: reset mbuf port on VF receive net/netvsc: free all queues on close drivers/net/netvsc/hn_ethdev.c | 8 +++- drivers/net/netvsc/hn_rxtx.c | 86 +

Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-29 Thread Thomas Monjalon
Please, could you check details like alignment or alphabetical sorting? Thanks 26/04/2019 06:39, Honnappa Nagarahalli: > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -111,6 +111,8 @@ test_sources = files('commands.c', > 'test_timer_racecond.c', > 'test_timer_seconda

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Ferruh Yigit
On 4/29/2019 9:14 PM, Thomas Monjalon wrote: > 29/04/2019 19:00, Ferruh Yigit: >> On 4/26/2019 6:09 AM, Xiaolong Ye wrote: >>> Since 18.11, it is suggested that driver should release all its private >>> resources at the dev_close routine. So all resources previously released >>> in remove routine a

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Thomas Monjalon
30/04/2019 00:28, Ferruh Yigit: > On 4/29/2019 9:14 PM, Thomas Monjalon wrote: > > 29/04/2019 19:00, Ferruh Yigit: > >> On 4/26/2019 6:09 AM, Xiaolong Ye wrote: > >>> Since 18.11, it is suggested that driver should release all its private > >>> resources at the dev_close routine. So all resources p

[dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-29 Thread Suanming . Mou
When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Suggested-by: Varghese, Vipin Suggested-by: Burakov, Anatoly Signed-off-by: Suanming.Mou --- app/pdump/main.c | 16 1 file changed, 16 insertions(+)

Re: [dpdk-dev] [PATCH v1 2/2] net/af_xdp: set MAC addrs field to NULL

2019-04-29 Thread Ye Xiaolong
On 04/29, Ferruh Yigit wrote: >On 4/26/2019 6:09 AM, Xiaolong Ye wrote: >> As af_xdp pmd doesn't allocate MAC addresses dynamically, it needs to be >> set as NULL, so it won't be released by rte_eth_dev_release_port(), >> otherwise, there would be "EAL: Error: Invalid memory" error. >> >> Signed-o

Re: [dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Ye Xiaolong
Hi, Ferruh On 04/29, Ferruh Yigit wrote: >On 4/26/2019 6:09 AM, Xiaolong Ye wrote: >> Since 18.11, it is suggested that driver should release all its private >> resources at the dev_close routine. So all resources previously released >> in remove routine are now released at the dev_close routine,

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-29 Thread Varghese, Vipin
Thanks for the patch work with rte_eal_alaram. But I am not able to find 1. the documentation update. 2. cover letter. 3. for signal SIGINT, set for ` rte_eal_alarm_cancel`. Can you share a new patch as v5 with these changes? Thanks Vipin Varghese > -Original Message- > From: Suanming

[dpdk-dev] [PATCH v2] net/af_xdp: remove resources when port is closed

2019-04-29 Thread Xiaolong Ye
Since 18.11, it is suggested that driver should release all its private resources at the dev_close routine. So all resources previously released in remove routine are now released at the dev_close routine, and the dev_close routine will be called in driver remove routine in order to support removin

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-04-29 Thread Honnappa Nagarahalli
> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli > wrote: > > Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto > extension > > CONFIG_RTE_MACHINE="armv8a" > +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y > >>> > >>> This approach is not scalable. Even, it is not good f

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-29 Thread Suanming . Mou
On 2019/4/30 10:33, Varghese, Vipin wrote: Thanks for the patch work with rte_eal_alaram. But I am not able to find 1. the documentation update. I'd like to reconfirm that since Anatoly suggested to make the option default, I deleted the option supporting code. Is it aligned that we can m

Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-29 Thread Honnappa Nagarahalli
> > Please, could you check details like alignment or alphabetical sorting? I don't see any alignment issues (there is mixed use of tabs and spaces in this file, will use the same). > Thanks > > 26/04/2019 06:39, Honnappa Nagarahalli: > > --- a/app/test/meson.build > > +++ b/app/test/meson.buil

[dpdk-dev] [Bug 259] unable to run sample t3 as bpf-load for testpmd

2019-04-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=259 Bug ID: 259 Summary: unable to run sample t3 as bpf-load for testpmd Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major

Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.

2019-04-29 Thread Varghese, Vipin
snipped > > > > 1. the documentation update. > > I'd like to reconfirm that since Anatoly suggested to make the option > default, I > deleted the option supporting code. > > Is it aligned that we can make it default? > > If it is aligned to make it default, then if I understand correctly, to ad

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow action destroy

2019-04-29 Thread Shahaf Shuler
Wednesday, April 24, 2019 3:56 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow action destroy > > ibv_destroy_flow_action() refers to QP. QP must not be freed until > corresponding action is destroyed. > > Fixes: 3eb004431072 ("net/mlx5: fix release of jump to queue action") >

Re: [dpdk-dev] [PATCH v2 0/3] improve IPsec_MB dependency checks

2019-04-29 Thread Akhil Goyal
> > Series-acked-by: Luca Boccassi > > Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [Bug 260] bugDPDK lock-free hash deletion

2019-04-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=260 Bug ID: 260 Summary: bugDPDK lock-free hash deletion Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal Priority: Norm

Re: [dpdk-dev] [PATCH v2] lib/crypto: include dependency in asym header

2019-04-29 Thread Akhil Goyal
> > > -Original Message- > > From: Ayuj Verma [mailto:ayve...@marvell.com] > > Sent: Tuesday, April 23, 2019 4:41 PM > > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > Trahe, Fiona > > > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade...@marvell.com; > > dev

[dpdk-dev] [PATCH] net/i40e: fix link speed issue for X722

2019-04-29 Thread Beilei Xing
If disable LSC when launching testpmd with X722, shown link speed is 20G but not 10G. It's caused by wrongly parsed link speed. Correct it according to X722 datasheet. Fixes: eef2daf2e199 ("net/i40e: fix link update no wait") Cc: sta...@dpdk.org Signed-off-by: Beilei Xing --- drivers/net/i40e/i

Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice

2019-04-29 Thread Akhil Goyal
Hi Anoob/Shally, Could you please review this patch and provide Ack. Thanks, Akhil > > > This patch adds deprecation notice of changing iv behaviour > when using Galois Counter Mode of operation. Right now IV of > all supported sizes can be used. > > Signed-off-by: Arek Kusztal > --- > doc