[dpdk-dev] [PATCH v2] net/ice: add link-up and link-down functions

2019-05-02 Thread Haiyue Wang
Support link up and down functions for ice, and when stop the ice, makes the link down also. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_ethdev.c | 85 1 file changed, 85 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ic

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-02 Thread Honnappa Nagarahalli
> On 3/22/2019 11:57 AM, Jakub Grajciar wrote: > > Memory interface (memif), provides high performance packet transfer > > over shared memory. > > > > Signed-off-by: Jakub Grajciar > > <...> > > > @@ -0,0 +1,200 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > +Copyright(c) 2018-2019 Ci

Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox BlueField

2019-05-02 Thread Honnappa Nagarahalli
> > On May 1, 2019, at 9:12 PM, Honnappa Nagarahalli > wrote: > > > >> > >> Mellanox BlueField has a variant which doesn't have armv8 crypto > extension. > >> If crypto enabled binary runs on such a pltform, rte_eal_init() > >> fails. To have binary compatibility across multiple variants, it is >

Re: [dpdk-dev] [PATCH 1/2] build: add option for armv8 crypto extension

2019-05-02 Thread Honnappa Nagarahalli
> > On May 1, 2019, at 9:13 PM, Honnappa Nagarahalli > wrote: > > > >> Per armv8 crypto extension support, make build always enable it by > >> default as long as compiler supports the feature while meson build > >> only enables it for 'default' machine of generic armv8 architecture. > >> For examp

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-02 Thread Honnappa Nagarahalli
> >>> On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli > >>> wrote: > >>> > >>> Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto > >>> extension > >>> > >>> CONFIG_RTE_MACHINE="armv8a" > >>> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y > >> > >> This approach is not

[dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Suanming . Mou
When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Signed-off-by: Suanming.Mou Reviewed-by: Anatoly Burakov Reviewed-by: Vipin Varghese --- V8: * reword the print info in monitor_primary. * add release_19_05.rst update.

Re: [dpdk-dev] [PATCH v1] net/ice: add link-up and link-down functions

2019-05-02 Thread Wang, Haiyue
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 1, 2019 09:09 > To: Wang, Haiyue ; dev@dpdk.org; Lu, Wenzhuo > > Subject: RE: [PATCH v1] net/ice: add link-up and link-down functions > > > > > -Original Message- > > From: Wang, Haiyue > > Sent: Tuesday, April 30,

Re: [dpdk-dev] [PATCH v3] examples/vm_power_manager: fix string null termination

2019-05-02 Thread Thomas Monjalon
26/04/2019 16:10, Burakov, Anatoly: > On 26-Apr-19 3:04 PM, David Hunt wrote: > > coverity complains about a null-termination after a read, > > so we terminate once we exit the do-while read loop. > > > > Coverity issue: 337680 > > Fixes: a63504a90f ("examples/power: add JSON string handling") > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] examples/vm_power_manager: fix buffer overrun

2019-05-02 Thread Thomas Monjalon
26/04/2019 10:42, David Hunt: > The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, > yet the code can attempt to look at the index at RTE_MAX_LCORE, > which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to > RTE_MAX_LCORE_FREQS. > > Fixes: d26c18c93260 ("examples/

Re: [dpdk-dev] [PATCH] examples/multi_process: fix buffer underrun

2019-05-02 Thread Thomas Monjalon
10/04/2019 21:41, Yongseok Koh: > For client_server_mp, the total number of buffers for the mbuf mempool > should be correctly calculated. Otherwise, having more clients will stop > traffic. > > Fixes: af75078fece3 ("first public release") > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh A

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 4:08 PM, Yongseok Koh wrote: > >> >> On May 2, 2019, at 3:13 AM, Jerin Jacob Kollanukkaran >> wrote: >> >>> -Original Message- >>> From: Honnappa Nagarahalli >>> Sent: Tuesday, April 30, 2019 9:04 AM >>> To: ys...@mellanox.com >>> Cc: Jerin Jacob Kollanukkaran

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection

2019-05-02 Thread Thomas Monjalon
10/04/2019 09:29, Pavan Nikhilesh Bhagavatula: > From: Pavan Nikhilesh > > Currently, l3wfd em mode has two datapath modes em_sequential and > em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to > one or zero. > The code checks if NO_HASH_MULTI_LOOKUP is defined or not instea

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: support separate buffer pool per port

2019-05-02 Thread Thomas Monjalon
25/04/2019 11:40, Shreyansh Jain: > Traditionally, only a single buffer pool per port > (or, per-port-per-socket) is created in l3fwd application. > > If separate pools are created per-port, it might lead to gain in > performance as packet alloc/dealloc requests would be isolated > across ports (a

Re: [dpdk-dev] [PATCH v2 0/5] make lcore_config internal

2019-05-02 Thread Stephen Hemminger
On Wed, 10 Apr 2019 10:15:58 -0700 Stephen Hemminger wrote: > This set of patches makes the lcore_config structure less visible > as part of the ABI. This version does not break the ABI (yet) > follow on patch moves lcore_config into eal_private.h > > The changes in v2 is to: > - new patch to

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 3:13 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Honnappa Nagarahalli >> Sent: Tuesday, April 30, 2019 9:04 AM >> To: ys...@mellanox.com >> Cc: Jerin Jacob Kollanukkaran ; >> bruce.richard...@intel.com; Pavan Nikhilesh Bhagavatula >> ;

Re: [dpdk-dev] [PATCH v2 1/2] doc: fix spelling errors reported by aspell

2019-05-02 Thread Thomas Monjalon
30/04/2019 13:26, Mcnamara, John: > > > If it agreed that change to CollectD should be reverted, not sure that a > > new V3 should be sent, this is a huge patch; if reverting can be done via > > merge, it will be better. > > Agreed. Also the following change is incorrect: > > -uin8t_t

Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs

2019-05-02 Thread Thomas Monjalon
Hi, 01/05/2019 00:33, David Christensen: > The memory barrier test fails on IBM Power 9 systems. Add additional > barriers to accommodate the weakly ordered model used on Power CPUs. > > Signed-off-by: David Christensen [...] > --- a/app/test/test_barrier.c > +++ b/app/test/test_barrier.c > @@

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr

2019-05-02 Thread Thomas Monjalon
> > In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never > > closed > > thus leading a fd leak. This patch avoids this. > > > > Coverity issue: 279441 > > Fixes: ef1e8ede3da59e("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Li

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/5] raw/dpaa2_qdma: fix spin lock release condition

2019-05-02 Thread Thomas Monjalon
24/04/2019 13:45, Hemant Agrawal: > The code shall be unlock post the lock. > > Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant Agrawal Series applied, thanks

Re: [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues

2019-05-02 Thread Thomas Monjalon
02/05/2019 18:51, Bruce Richardson: > Split off from the previous set to test the pkg-config file, this set > includes only the fixes encountered during that work. > > V4: Removed the changes to the test script and to hard-code the list of > example apps, so that only the more important patche

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-02 Thread Thomas Monjalon
02/05/2019 20:31, Ferruh Yigit: > On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > > 25/04/2019 17:27, Ferruh Yigit: > >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: > >>> 25/04/2019 13:47, Ferruh Yigit: > On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > > 25/04/2019 00:03, Ferruh Yigit: > >

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread Stephen Hemminger
On Thu, 2 May 2019 16:53:50 +0100 "Burakov, Anatoly" wrote: > On 02-May-19 3:13 PM, Reshma Pattan wrote: > > gcc 9 on Fedora 30 gives an error > > "taking address of packed member may result in an > > unaligned pointer value" for -Waddress-of-packed-member. > > > > Report it as warning instead o

[dpdk-dev] [PATCH] doc: fix some formatting errors in testpmd guide

2019-05-02 Thread Kevin Traynor
Minor formatting error related to code block noticed when reading the doc. Fix it and some other errors. Fixes: c7217b9dd8ef ("app/testpmd: change log level at run time") Fixes: 3c272b280a50 ("app/testpmd: add commands for RSS queue region") Fixes: e38ea44f1714 ("app/testpmd: add configuration for

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-02 Thread Ferruh Yigit
On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > 25/04/2019 17:27, Ferruh Yigit: >> On 4/25/2019 2:29 PM, Thomas Monjalon wrote: >>> 25/04/2019 13:47, Ferruh Yigit: On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > 25/04/2019 00:03, Ferruh Yigit: >> This reverts commit bdca79053b6aea504d02

Re: [dpdk-dev] [PATCH v2 0/2] netvsc PMD fixes for 19.05

2019-05-02 Thread Ferruh Yigit
On 4/30/2019 7:12 PM, Stephen Hemminger wrote: > Netvsc needed to reset incoming port as was recently done > for failsafe. Implement the new close semantics. > > Stephen Hemminger (2): > net/netvsc: reset mbuf port on VF receive > net/netvsc: free all queues on close Series applied to dpdk-ne

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote: > > Multiple functions were declared in header file mlx5_rxtx.h, > inplemented in mlx5_rxq.c, and called only in mlx5_rxq.c. > > This patch moves all these functions declarations into mlx5_rxq.c, > as static functions. > Some functions implement

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote: > > Return value of function mlx5_rxq_releasable() was not described > correctly in function description. > > This patch updates the description to correctly describe the optional > return values. > > Fixes: a6d83b6a9209 ("net/mlx5: standardize

Re: [dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote: > > Functions implemented but never called: > mlx5_rxq_ibv_releasable() > mlx5_rxq_cleanup() > mlx5_txq_ibv_releasable() > > Function declared but not implemented: > rxq_alloc_mprq_buf() > > This patch removes these functions from code and head

Re: [dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer

2019-05-02 Thread Yongseok Koh
> On May 2, 2019, at 8:01 AM, Dekel Peled wrote: > > Function mlx5_rxq_ibv_release() is called in several places. > Before each call except one, the input parameter is validated to make > sure it is not null. > > This patch adds the missing validation where it is missing. > > Fixes: af4f09f28

[dpdk-dev] [PATCH v4 4/4] build: add libbsd to pkg-config file if enabled

2019-05-02 Thread Bruce Richardson
If libbsd is enabled in DPDK, the strlcpy and strlcat functions in rte_string_fns.h redirect to the varients in libbsd, only using the fallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs to be called out as a DPDK dependency in the pkgconfig file. To ensure that we don't have

[dpdk-dev] [PATCH v4 3/4] build: fix ninja install on FreeBSD

2019-05-02 Thread Bruce Richardson
The post-install script to symlink the PMDs from their own PMD directory to the regular lib directory (so they would be found by ld at runtime) was using the "-r" flag to ln to create relative symlinks. This flag is unsupported by ln on FreeBSD causing the ninja install step to fail. Reworking the

[dpdk-dev] [PATCH v4 1/4] examples/l3fwd: fix compile on FreeBSD

2019-05-02 Thread Bruce Richardson
On freebsd we need to include sys/socket.h to get the definition of AF_INET in order to compile. Fixes: d5ceea4ab160 ("examples/l3fwd: format IP addresses for printing") Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- examples/l3fwd/l3fwd_lpm.c | 1 + 1 file changed, 1 insertion(+)

[dpdk-dev] [PATCH v4 2/4] examples: install examples as part of ninja install

2019-05-02 Thread Bruce Richardson
When we install dpdk onto a system, we want to put the examples into the /usr/share/dpdk (or /usr/local/share) directory for reference. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- examples/meson.build | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues

2019-05-02 Thread Bruce Richardson
Split off from the previous set to test the pkg-config file, this set includes only the fixes encountered during that work. V4: Removed the changes to the test script and to hard-code the list of example apps, so that only the more important patches are included. V3: Minor style changes to pat

Re: [dpdk-dev] [PATCH] net/vmxnet3: add VLAN filter capability

2019-05-02 Thread Ferruh Yigit
On 5/1/2019 7:02 PM, Yong Wang wrote: > -Original Message- > From: Mark Gillott > Date: Wednesday, May 1, 2019 at 8:30 AM > To: Yong Wang > Cc: "dev@dpdk.org" , Mark Gillott > Subject: [PATCH] net/vmxnet3: add VLAN filter capability > > The driver supports VLAN filtering, but the op

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/tap: fix potential buffer overrun

2019-05-02 Thread Ferruh Yigit
On 4/29/2019 6:31 PM, Herakliusz Lipiec wrote: > When secondary to primary process synchronization occours > there is no check for number of fds which could cause buffer overrun. > > Bugzilla ID: 252 > Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary") > Cc: rasl...@mell

[dpdk-dev] DPDK Release Status Meeting 2/5/2019

2019-05-02 Thread Ferruh Yigit
Minutes 2 May 2019 -- Agenda: * Release Dates * RC2 status * Subtrees * OvS * Conferences * Opens Participants: * Debian * Intel * Mellanox * RedHat Release Dates - * v19.05 dates, RC3 date pushed to Friday, 3 May: * RC3: *Friday, 3 May* * RC4: Wednesday, 8 May

Re: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority core

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 2, 2019 12:18 PM > To: dev@dpdk.org > Cc: Hunt, David > Subject: [dpdk-dev] [PATCH v1 3/3] lib/power: clarify comment on priority > core > > As part of the documentation update

Re: [dpdk-dev] [PATCH V3] doc: add guideines for initial PMD submission

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: Rami Rosen [mailto:ramir...@gmail.com] > Sent: Friday, April 12, 2019 11:27 AM > To: dev@dpdk.org > Cc: Trahe, Fiona ; akhil.go...@nxp.com; Mcnamara, > John ; Kovacevic, Marko > ; sta...@dpdk.org; Rami Rosen > > Subject: [PATCH V3] doc: add guideines for ini

Re: [dpdk-dev] [PATCH v2] doc: update release notes for windows support

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pallavi Kadam > Sent: Tuesday, April 23, 2019 7:13 PM > To: dev@dpdk.org > Cc: Menon, Ranjit ; Kadam, Pallavi > > Subject: [dpdk-dev] [PATCH v2] doc: update release notes for windows > support > Acked-by: Joh

Re: [dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday, April 24, 2019 12:45 PM > To: dev@dpdk.org > Cc: shreyansh.j...@nxp.com > Subject: [dpdk-dev] [PATCH 4/5] doc: update the dpaaX platform guides > > Update the dpaa platform guid

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-02 Thread Thomas Monjalon
02/05/2019 17:00, David Marchand: > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan > wrote: > > > gcc 9 on Fedora 30 gives an error > > "taking address of packed member may result in an > > unaligned pointer value" warnings. > > > > For clang builds this warning is already disabled, > > so disable

Re: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 2, 2019 12:18 PM > To: dev@dpdk.org > Cc: Hunt, David > Subject: [dpdk-dev] [PATCH v1 2/3] doc: add release note for power changes > > In the Power Library, a new bit has been a

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread Burakov, Anatoly
On 02-May-19 3:13 PM, Reshma Pattan wrote: gcc 9 on Fedora 30 gives an error "taking address of packed member may result in an unaligned pointer value" for -Waddress-of-packed-member. Report it as warning instead of error to fix the build. Snippet of build before fix ...lib/librte_eal/linux/eal

Re: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement info

2019-05-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Hunt > Sent: Thursday, May 2, 2019 12:18 PM > To: dev@dpdk.org > Cc: Hunt, David > Subject: [dpdk-dev] [PATCH v1 1/3] doc/distributor: add SST-BF enhancement > info > > The distributor sample application h

Re: [dpdk-dev] [PATCH] maintainers: fix added or removed files

2019-05-02 Thread Thomas Monjalon
02/05/2019 17:01, Thomas Monjalon: > Reference to test/Makefile was forgotten when removing this file. > Reference to app/test/test_rcu* was forgotten when adding the files. > > Fixes: a9de470cc7c0 ("test: move to app directory") > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] build: fix meson binutils workaround

2019-05-02 Thread Thomas Monjalon
02/05/2019 15:44, Ferruh Yigit: > On 5/2/2019 2:35 PM, Ferruh Yigit wrote: > > The '-mno-avx512f' compiler flag is not passed to the compiler, > > detection of the binutils and setting flags works fine, but the flag > > itself not used by compiler. > > > > Removing the interim 'march_opt' variable

[dpdk-dev] [PATCH] app/testpmd: add warning message when user sets rxq greater than txq

2019-05-02 Thread Herakliusz Lipiec
add a warning message when user sets port config all rxq value larger than txq in interactive mode. Signed-off-by: Herakliusz Lipiec --- app/test-pmd/cmdline.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 5a10c5f38..94be3c6f8 1

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 05:38:17PM +0200, Thomas Monjalon wrote: > 02/05/2019 17:30, Bruce Richardson: > > On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote: > > > 02/05/2019 16:08, Luca Boccassi: > > > > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > > > > > On Thu, May

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Thomas Monjalon
02/05/2019 17:30, Bruce Richardson: > On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote: > > 02/05/2019 16:08, Luca Boccassi: > > > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > > > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > > > > > 26/04/2019

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote: > 02/05/2019 16:08, Luca Boccassi: > > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > > > > 26/04/2019 16:56, Bruce Richardson: > > > > > On Wed, Apr

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Thomas Monjalon
02/05/2019 16:08, Luca Boccassi: > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > > > 26/04/2019 16:56, Bruce Richardson: > > > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > > > On Wed, 2019-

[dpdk-dev] [PATCH v2 3/4] net/mlx5: fix description of function return value

2019-05-02 Thread Dekel Peled
Return value of function mlx5_rxq_releasable() was not described correctly in function description. This patch updates the description to correctly describe the optional return values. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") cc: sta...@dpdk.org Signed-off-by: Dekel

[dpdk-dev] [PATCH v2 4/4] net/mlx5: move locally used functions to static

2019-05-02 Thread Dekel Peled
Multiple functions were declared in header file mlx5_rxtx.h, inplemented in mlx5_rxq.c, and called only in mlx5_rxq.c. This patch moves all these functions declarations into mlx5_rxq.c, as static functions. Some functions implementation was copied higher in the file to precede the functions calls.

[dpdk-dev] [PATCH v2 1/4] net/mlx5: remove unused functions

2019-05-02 Thread Dekel Peled
Functions implemented but never called: mlx5_rxq_ibv_releasable() mlx5_rxq_cleanup() mlx5_txq_ibv_releasable() Function declared but not implemented: rxq_alloc_mprq_buf() This patch removes these functions from code and header file. Signed-off-by: Dekel Peled --- drivers/net/mlx5/mlx5_rxq.c |

[dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null pointer

2019-05-02 Thread Dekel Peled
Function mlx5_rxq_ibv_release() is called in several places. Before each call except one, the input parameter is validated to make sure it is not null. This patch adds the missing validation where it is missing. Fixes: af4f09f28294 ("net/mlx5: prefix all functions with mlx5") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-02 Thread Dekel Peled
During work on Rx feature I did some cleanup actions. This series includes those changes divided by their type. --- v2: change 2nd patch type to "fix" --- Dekel Peled (4): net/mlx5: remove unused functions net/mlx5: fix missing validation of null pointer net/mlx5: fix description of functio

[dpdk-dev] [PATCH] maintainers: fix added or removed files

2019-05-02 Thread Thomas Monjalon
Reference to test/Makefile was forgotten when removing this file. Reference to app/test/test_rcu* was forgotten when adding the files. Fixes: a9de470cc7c0 ("test: move to app directory") Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") Signed-off-by: Thomas Monjalon --- MAINTAINER

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 11:33 AM Reshma Pattan wrote: > gcc 9 on Fedora 30 gives an error > "taking address of packed member may result in an > unaligned pointer value" warnings. > > For clang builds this warning is already disabled, > so disable "-Waddress-of-packed-member" for gcc builds > also.

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 4:42 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 04:24:37PM +0200, David Marchand wrote: > >On Thu, May 2, 2019 at 4:13 PM Reshma Pattan > ><[1]reshma.pat...@intel.com> wrote: > > > > gcc 9 on Fedora 30 gives an error > > "taking address of packed

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 04:24:37PM +0200, David Marchand wrote: >On Thu, May 2, 2019 at 4:13 PM Reshma Pattan ><[1]reshma.pat...@intel.com> wrote: > > gcc 9 on Fedora 30 gives an error > "taking address of packed member may result in an > unaligned pointer value" for -Waddre

Re: [dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 4:13 PM Reshma Pattan wrote: > gcc 9 on Fedora 30 gives an error > "taking address of packed member may result in an > unaligned pointer value" for -Waddress-of-packed-member. > > Report it as warning instead of error to fix the build. > > Snippet of build before fix > ...l

[dpdk-dev] [PATCH v2] mk: report address of packed member as warning

2019-05-02 Thread Reshma Pattan
gcc 9 on Fedora 30 gives an error "taking address of packed member may result in an unaligned pointer value" for -Waddress-of-packed-member. Report it as warning instead of error to fix the build. Snippet of build before fix ...lib/librte_eal/linux/eal/eal_memalloc.c: In function ‘alloc_seg_walk’

Re: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-02 Thread Shahaf Shuler
Hi Dekel, Monday, April 29, 2019 2:01 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH 0/4] net/mlx5: code cleanup in rx and tx files > > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. Good cleanup. I am basically OK w/ the series,

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Luca Boccassi
On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote: > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > > 26/04/2019 16:56, Bruce Richardson: > > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrot

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 03:53:36PM +0200, David Marchand wrote: >On Thu, May 2, 2019 at 3:46 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > >On Thu, May 2, 2019 at 3:24 PM Bruce Richardson >

Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Thomas Monjalon
02/05/2019 15:21, Bruce Richardson: > On Thu, May 02, 2019 at 02:38:49PM +0200, Thomas Monjalon wrote: > > Hi, > > > > I will probably have a ton of comments about adding a new compilation tests, > > and I think it is a bit late for such an addition. > > However, all the fixes should go in 19.05.

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 3:46 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: > >On Thu, May 2, 2019 at 3:24 PM Bruce Richardson > ><[1]bruce.richard...@intel.com> wrote: > > > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote

Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-02 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 2, 2019 8:04 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize > > On 02-May-19 1:19 PM, Carrillo, Erik G wro

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 03:32:20PM +0200, David Marchand wrote: >On Thu, May 2, 2019 at 3:24 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > >On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] build: fix meson binutils workaround

2019-05-02 Thread Ferruh Yigit
On 5/2/2019 2:35 PM, Ferruh Yigit wrote: > The '-mno-avx512f' compiler flag is not passed to the compiler, > detection of the binutils and setting flags works fine, but the flag > itself not used by compiler. > > Removing the interim 'march_opt' variable and using directly > 'machine_args' and set

[dpdk-dev] [PATCH v3 1/3] build: fix meson binutils workaround

2019-05-02 Thread Ferruh Yigit
The '-mno-avx512f' compiler flag is not passed to the compiler, detection of the binutils and setting flags works fine, but the flag itself not used by compiler. Removing the interim 'march_opt' variable and using directly 'machine_args' and setting '-mno-avx512f' to 'machine_args' Fixes: 566b4d7

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 3:24 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: > >On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1] > tho...@monjalon.net> > >wrote: > > > > 01/05/2019 21:50, Bruce Richardson: > > > This set of changes

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-02 Thread Pattan, Reshma
From: David Marchand [mailto:david.march...@redhat.com] Sent: Thursday, May 2, 2019 2:31 PM To: Richardson, Bruce Cc: Pattan, Reshma ; dev Subject: Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30 On Thu, May 2, 2019 at 3:26 PM Bruce Richardson mailto:bruce.richard...@inte

[dpdk-dev] [PATCH v3 2/3] build: fix crash by disabling AVX512 with binutils 2.31

2019-05-02 Thread Ferruh Yigit
On Skylake platform, with native build, KNI kernel module crashes because of the corrupted values passed to kernel module. The corruption occurs because the userspace kni library works unexpectedly. Compiler [1] is using AVX512 instructions and generated binary is wrong [2]. It turned around gcc

[dpdk-dev] [PATCH v3 3/3] build: reduce indentation in meson check

2019-05-02 Thread Ferruh Yigit
Just syntax change to reduce indentation, no functional change. Signed-off-by: Ferruh Yigit Acked-by: Bruce Richardson --- config/x86/meson.build | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/config/x86/meson.build b/config/x86/meson.build index 0a7bed75e..bb23771b

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 3:26 PM Bruce Richardson wrote: > On Thu, May 02, 2019 at 12:07:17PM +0200, David Marchand wrote: > > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan > > wrote: > > > > > gcc 9 on Fedora 30 gives an error > > > "taking address of packed member may result in an > > > unaligne

Re: [dpdk-dev] [PATCH] mk: disable warning with gcc 9 on Fedora 30

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 12:07:17PM +0200, David Marchand wrote: > On Thu, May 2, 2019 at 11:33 AM Reshma Pattan > wrote: > > > gcc 9 on Fedora 30 gives an error > > "taking address of packed member may result in an > > unaligned pointer value" warnings. > > > > For clang builds this warning is al

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 02:32:41PM +0200, David Marchand wrote: >On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon <[1]tho...@monjalon.net> >wrote: > > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on > Fedora 30. > > I

Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 02:38:49PM +0200, Thomas Monjalon wrote: > Hi, > > I will probably have a ton of comments about adding a new compilation tests, > and I think it is a bit late for such an addition. > However, all the fixes should go in 19.05. > > 26/04/2019 18:50, Bruce Richardson: > > The

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Bruce Richardson
On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote: > 26/04/2019 16:56, Bruce Richardson: > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi

Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Thomas Monjalon
26/04/2019 16:56, Bruce Richardson: > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote: > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote: > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi wrote: > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote:

Re: [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode

2019-05-02 Thread Shahaf Shuler
Thursday, May 2, 2019 12:08 PM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH v3 2/2] net/mlx: support IOVA VA mode > > Set RTE_PCI_DRV_IOVA_AS_VA to driver's drv_flags as device's IOMMU > takes virtual address. > > Cc: sta...@dpdk.org > > Signed-off-by: Yongseok Koh Acked-by: Shahaf Shuler > -

Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-02 Thread Burakov, Anatoly
On 02-May-19 1:19 PM, Carrillo, Erik G wrote: -Original Message- From: Burakov, Anatoly Sent: Thursday, May 2, 2019 4:18 AM To: Carrillo, Erik G ; rsanf...@akamai.com; tho...@monjalon.net Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize On 01-May-1

Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Luca Boccassi
On Thu, 2019-05-02 at 14:38 +0200, Thomas Monjalon wrote: > > +$ninja_cmd -C $build_path install > > + > > +pc_file=$(find $DESTDIR -name libdpdk.pc) > > +PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH > > + > > +# rather than hacking our environment, just edit the .pc file > > prefix

Re: [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file

2019-05-02 Thread Thomas Monjalon
Hi, I will probably have a ton of comments about adding a new compilation tests, and I think it is a bit late for such an addition. However, all the fixes should go in 19.05. 26/04/2019 18:50, Bruce Richardson: > The pkg-config file generated as part of the build of DPDK should allow > applicatio

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-02 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
From: Ferruh Yigit Sent: Monday, March 25, 2019 9:58 PM To: Jakub Grajciar; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC v5] /net: memory interface (memif) On 3/22/2019 11:57 AM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > p

Re: [dpdk-dev] [PATCH v7] app/pdump: add pudmp exits with primary support

2019-05-02 Thread mousuanming
Ah, yes! I'm so sorry that I have left the company today. It's not able to update the patch now. I think it will be done tomorrow. Thanks again for your suggestions enriched that simple patch. (May the reply on mobile phone won't break any mail formats) ---

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread David Marchand
On Thu, May 2, 2019 at 2:19 PM Thomas Monjalon wrote: > 01/05/2019 21:50, Bruce Richardson: > > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > > In most cases these warnings appear to be false positives, which means we > > have the option to just disable the warning.

Re: [dpdk-dev] [PATCH 4/4] raw/dpaa2_cmdif: fix warnings with GCC 9 on Fedora 30

2019-05-02 Thread David Marchand
On Wed, May 1, 2019 at 9:51 PM Bruce Richardson wrote: > GCC9 gives warnings if the parameter passed to printf for "%s" could be > NULL, so we need to add checks in some cases to ensure that is not the > case. > > Fixes: 3298fa4853b8 ("raw/dpaa2_cmdif: introduce DPAA2 command interface > driver")

Re: [dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30

2019-05-02 Thread David Marchand
On Wed, May 1, 2019 at 9:51 PM Bruce Richardson wrote: > GCC9 gives warnings if the parameter passed to printf for "%s" could be > NULL, so we need to add checks in some cases to ensure that is not the > case. > > Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver") > Cc: shreya

Re: [dpdk-dev] [PATCH 1/4] net/ixgbe: fix warning with GCC 9 on Fedora 30

2019-05-02 Thread David Marchand
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson wrote: > Compiling on Fedora 30, we get the following warning, causing build failure > when Werror flag is set: > > ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: ‘nmb’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > 214

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: fix printf of null pointer

2019-05-02 Thread David Marchand
On Wed, May 1, 2019 at 9:50 PM Bruce Richardson wrote: > Printing a null pointer with %s is flagged as a warning by GCC 9, and > should not be done. Replace the %s with the word "null" itself. > > Fixes: 828d51d8fc3e ("bus/fslmc: refactor scan and probe functions") > Cc: shreyansh.j...@nxp.com >

Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize

2019-05-02 Thread Carrillo, Erik G
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 2, 2019 4:18 AM > To: Carrillo, Erik G ; rsanf...@akamai.com; > tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] timer: fix resource leak in finalize > > On 01-May-19 8:00 PM, Erik Gabriel Carrill

Re: [dpdk-dev] [PATCH 0/4] fix warnings with gcc 9 on Fedora 30

2019-05-02 Thread Thomas Monjalon
01/05/2019 21:50, Bruce Richardson: > This set of changes fixes warnings seen when compiling DPDK on Fedora 30. > In most cases these warnings appear to be false positives, which means we > have the option to just disable the warning. Because the changes required > to the code to silence the warnin

[dpdk-dev] [PATCH v4 2/3] mlx5: Implement support for read_clock

2019-05-02 Thread Tom Barbette
Implements support for read_clock for the mlx5 driver. mlx5 supports hardware timestamp offload, setting packets timestamp field to the device clock. rte_eth_read_clock allows to read the device's current clock value and therefore compare values on similar time base. See rxtx_callbacks for an exam

[dpdk-dev] [PATCH v4 0/3] Add rte_eth_read_clock API

2019-05-02 Thread Tom Barbette
Some NICs allow to timestamp packets, but do not support the full PTP synchronization process. Hence, the value set in the mbuf timestamp field is only the raw value of an internal clock. To make sense of this value, one at least needs to be able to query the current hardware clock value. This pat

[dpdk-dev] [PATCH v4 1/3] rte_ethdev: Add API function to read dev clock

2019-05-02 Thread Tom Barbette
Add rte_eth_read_clock to read the raw clock of a device. The main use is to get the device clock conversion co-efficients to be able to translate the raw clock of the timestamp field of the pkt mbuf to a local synced time value. This function was missing to allow users to convert the Rx timestam

[dpdk-dev] [PATCH v4 3/3] rxtx_callbacks: Add support for HW timestamp

2019-05-02 Thread Tom Barbette
Use rxtx callback to demonstrate a way to use rte_eth_read_clock to convert the hardware timestamps to an amount of cycles. This allows to get the amount of time the packet spent since its entry in the device. While the regular latency only shows the latency from when it entered the software stack

Re: [dpdk-dev] [PATCH v7] app/pdump: add pudmp exits with primary support

2019-05-02 Thread Burakov, Anatoly
On 02-May-19 1:35 PM, Suanming.Mou wrote: When primary app exits, the residual running pdump will stop the primary app to restart. Add pdump exits with primary support. Signed-off-by: Suanming.Mou --- <...> + if (rte_eal_primary_proc_alive(NULL)) { + rte_eal_alarm_set(MO

  1   2   >