Re: [dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 4:42 PM, Ori Kam: > Subject: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules > > When Direct Rules API is not supported we don't set the errno. > this results in failing the function but with errno equals to zero. > The result of this is that a function that fa

Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 10:26 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue > object > > Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some > actions on the returned rxq_ibv. > It doens't release the rxq_ibv when all is completed with

Re: [dpdk-dev] [PATCH] net/mlx5: fix Multi-Packet RQ mempool name

2019-05-07 Thread Shahaf Shuler
Tuesday, May 7, 2019 2:22 AM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix Multi-Packet RQ mempool name > > Currently, the name of MPRQ mempool is set by > snprintf(name, sizeof(name), "%s-mprq", dev->device->name); For > port representor, the name is duplicate of its master and failed to

Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files

2019-05-07 Thread Shahaf Shuler
Dekel, Sunday, May 5, 2019 4:09 PM, Dekel Peled: > Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files > > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. > > --- > v2: Change 2nd patch type to "fix". > v3: Apply min

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues

2019-05-07 Thread Shahaf Shuler
Sunday, May 5, 2019 2:44 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH v3] net/mlx5: fix init with zero Rx queues > > Recent patch [1] added, at the end of mlx5_dev_configure(), a call to > mlx5_proc_priv_init(), initializing process_private data of eth_dev. > This call is not reached if PMD is st

[dpdk-dev] [PATCH] doc: add Mellanox BlueField platform guide

2019-05-07 Thread Yongseok Koh
Platform specific guide for Mellanox BlueField SoC is added. Signed-off-by: Yongseok Koh --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 2 + doc/guides/platform/bluefield.rst | 141 ++ doc/guides/platform/index.rst | 1 + doc/guides/rel_notes/

Re: [dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables to uint64_t

2019-05-07 Thread Ananyev, Konstantin
> -Original Message- > From: David Christensen [mailto:d...@linux.vnet.ibm.com] > Sent: Tuesday, May 7, 2019 6:38 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables > to uint64_t > > >> @@ -65,8 +65,8 @@ struct ploc

Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support

2019-05-07 Thread Stillwell Jr, Paul M
> -Original Message- > From: dev On Behalf Of Igor Russkikh > Sent: Monday, May 6, 2019 4:22 AM > To: Ido Goshen ; Ananyev, Konstantin > ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support > > > >>> > >>> The hw->allow_unsupported

Re: [dpdk-dev] [PATCH] doc: prepare security process for vulnerabilities

2019-05-07 Thread Luca Boccassi
On Tue, 2019-05-07 at 18:02 +0200, Thomas Monjalon wrote: > In case a vulnerability is discovered, the process to follow > is described in this document. > It has been inspired by the process of some referenced projects > and with the help of experts from Intel, RedHat, Mellanox > and the Linux Fou

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-07 Thread Carrillo, Erik G
Hi Anatoly, Thanks for the review. Comments in-line: <...snipped...> > > #define RTE_MAX_DATA_ELS 64 > > +static const struct rte_memzone *rte_timer_data_mz; static > > +rte_atomic16_t *rte_timer_mz_refcnt; > > static struct rte_timer_data *rte_timer_data_arr; > > static const uint32_t de

[dpdk-dev] [PATCH v3] build: disable armv8 crypto extension

2019-05-07 Thread Yongseok Koh
Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. It is known that not all the armv8 platforms have the crypto extension. For example, Mellanox B

Re: [dpdk-dev] [PATCH] doc: prepare security process for vulnerabilities

2019-05-07 Thread Thomas Monjalon
07/05/2019 21:06, Stephen Hemminger: > Thomas Monjalon wrote: > > > In case a vulnerability is discovered, the process to follow > > is described in this document. [...] > Maybe there should be a keysigning at the DPDK summit Yes it is must for using GPG in the security process.

Re: [dpdk-dev] [PATCH] doc: prepare security process for vulnerabilities

2019-05-07 Thread Stephen Hemminger
On Tue, 7 May 2019 18:02:31 +0200 Thomas Monjalon wrote: > In case a vulnerability is discovered, the process to follow > is described in this document. > It has been inspired by the process of some referenced projects > and with the help of experts from Intel, RedHat, Mellanox > and the Linux F

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-07 Thread Trahe, Fiona
Hi Shally > > > > + > > > > +There are some exceptions whereby errors can occur on the > > ``enqueue``. > > > > +For any error which can occur in a production environment and can > > > > +be successful after a retry with the same op the PMD may return the > > > > +error on the enqueue. > > > This

Re: [dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables to uint64_t

2019-05-07 Thread David Christensen
@@ -65,8 +65,8 @@ struct plock_test { */ struct lcore_plock_test { struct plock_test *pt[2]; /* shared, lock-protected data */ - uint32_t sum[2]; /* local copy of the shared data */ - uint32_t iter;/* number of iterations to perfom */ + uint64_t

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-05-07 Thread Shally Verma
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, April 30, 2019 10:04 PM > To: Shally Verma ; dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; Daly, Lee > ; Sunila Sahu ; sta...@dpdk.org; > Trahe, Fiona > Subject: RE: [PATCH v2] doc/compress: clarify error handling on d

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Bruce Richardson
On Tue, May 07, 2019 at 04:53:00PM +0100, Luca Boccassi wrote: > On Tue, 2019-05-07 at 16:17 +0100, Bruce Richardson wrote: > > On Tue, May 07, 2019 at 02:28:11PM +0100, Luca Boccassi wrote: > > > On Tue, 2019-05-07 at 11:50 +0100, Bruce Richardson wrote: > > > > On Tue, May 07, 2019 at 11:09:51AM

[dpdk-dev] [PATCH] doc: prepare security process for vulnerabilities

2019-05-07 Thread Thomas Monjalon
In case a vulnerability is discovered, the process to follow is described in this document. It has been inspired by the process of some referenced projects and with the help of experts from Intel, RedHat, Mellanox and the Linux Foundation. Signed-off-by: Thomas Monjalon Signed-off-by: Maxime Coqu

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Luca Boccassi
On Tue, 2019-05-07 at 16:17 +0100, Bruce Richardson wrote: > On Tue, May 07, 2019 at 02:28:11PM +0100, Luca Boccassi wrote: > > On Tue, 2019-05-07 at 11:50 +0100, Bruce Richardson wrote: > > > On Tue, May 07, 2019 at 11:09:51AM +0100, Luca Boccassi wrote: > > > > On Fri, 2019-05-03 at 14:35 +0100,

Re: [dpdk-dev] [PATCH] doc: fix some formatting errors in testpmd guide

2019-05-07 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kevin Traynor > Sent: Thursday, May 2, 2019 7:44 PM > To: Mcnamara, John ; Kovacevic, Marko > ; dev@dpdk.org > Cc: Kevin Traynor ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix some formatting errors in tes

Re: [dpdk-dev] [PATCH] doc: update release notes for timer library changes

2019-05-07 Thread Mcnamara, John
> -Original Message- > From: Carrillo, Erik G > Sent: Monday, May 6, 2019 10:30 PM > To: Mcnamara, John > Cc: dev@dpdk.org > Subject: [PATCH] doc: update release notes for timer library changes > Acked-by: John McNamara

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Bruce Richardson
On Tue, May 07, 2019 at 02:28:11PM +0100, Luca Boccassi wrote: > On Tue, 2019-05-07 at 11:50 +0100, Bruce Richardson wrote: > > On Tue, May 07, 2019 at 11:09:51AM +0100, Luca Boccassi wrote: > > > On Fri, 2019-05-03 at 14:35 +0100, Bruce Richardson wrote: > > > > For testing of DPDK, we want to ove

Re: [dpdk-dev] [PATCH v1 2/2] doc: update usage field for port-queue

2019-05-07 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, May 7, 2019 7:52 AM > To: dev@dpdk.org; Kovacevic, Marko ; Mcnamara, > John ; ramir...@gmail.com; De Lara Guarch, Pablo > ; Richardson, Bruce > > Cc: Padubidri, Sanjay A ; Varghese, Vipin > > Subject: [PATCH v1 2/2] doc: upd

Re: [dpdk-dev] [PATCH] doc/testpmd: update compile steps for bpf examples

2019-05-07 Thread Mcnamara, John
> -Original Message- > From: Varghese, Vipin > Sent: Tuesday, May 7, 2019 9:41 AM > To: dev@dpdk.org; Kovacevic, Marko ; Mcnamara, > John ; Lu, Wenzhuo ; Wu, > Jingjing ; Iremonger, Bernard > > Cc: Padubidri, Sanjay A ; Varghese, Vipin > > Subject: [PATCH] doc/testpmd: update compile s

Re: [dpdk-dev] [EXT] Re: [PATCH] ipsec: include high order bytes of esn in pkt len

2019-05-07 Thread Lukas Bartosik
On 30.04.2019 17:38, Lukas Bartosik wrote: > External Email > > -- > > > > > From: Ananyev, Konstantin > Sent: Tuesday, April 30, 2019 5:05 PM > To: Lukas Bartosik > Cc: dev@dpdk.org; Anoob J

[dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules

2019-05-07 Thread Ori Kam
When Direct Rules API is not supported we don't set the errno. this results in failing the function but with errno equals to zero. The result of this is that a function that failed, is considered as a function that worked correctly. This commit fixes this issue by setting the errno to ENOTSUP and

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Luca Boccassi
On Tue, 2019-05-07 at 11:50 +0100, Bruce Richardson wrote: > On Tue, May 07, 2019 at 11:09:51AM +0100, Luca Boccassi wrote: > > On Fri, 2019-05-03 at 14:35 +0100, Bruce Richardson wrote: > > > For testing of DPDK, we want to override the prefix given by the > > > pkg-config file, so that we can get

[dpdk-dev] [Bug 277] eventdev sw rx adapter enqueue buffer may store packets indefinitely

2019-05-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=277 Bug ID: 277 Summary: eventdev sw rx adapter enqueue buffer may store packets indefinitely Product: DPDK Version: 19.05 Hardware: All OS: All Status: CONF

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Jerin Jacob Kollanukkaran
+ Nikhil Please add respective maintainer from MAINTAINERS file for quick resolution. > -Original Message- > From: dev On Behalf Of Elo, Matias (Nokia - > FI/Espoo) > Sent: Tuesday, May 7, 2019 5:33 PM > To: Mattias Rönnblom > Cc: Honnappa Nagarahalli ; dev@dpdk.org; > nd > Subject: Re

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Elo, Matias (Nokia - FI/Espoo)
On 7 May 2019, at 15:01, Mattias Rönnblom mailto:hof...@lysator.liu.se>> wrote: On 2019-05-07 13:12, Honnappa Nagarahalli wrote: Hi, The SW eventdev rx adapter has an internal enqueue buffer 'rx_adapter- event_enqueue_buffer', which stores packets received from the NIC until at least BATCH_

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

2019-05-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, May 7, 2019 4:34 PM > To: Jerin Jacob Kollanukkaran ; ys...@mellanox.com > Cc: tho...@monjalon.net; dev@dpdk.org; bruce.richard...@intel.com; Pavan > Nikhilesh Bhagavatula ; Shahaf Shuler > ; Gavin Hu (Arm Technology China)

Re: [dpdk-dev] about IOVA and namespace in DPDK 19.05

2019-05-07 Thread Burakov, Anatoly
On 02-May-19 12:31 AM, Robert Nie wrote: After some digging, I fixed it by using "--iova-mode=va". Would anyone please let me know if it was safe to use "va" instead of "pa" for veth use case? Or any performance drops? That depends. The IOVA addresses are what you would colloquially refer t

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Mattias Rönnblom
On 2019-05-07 13:12, Honnappa Nagarahalli wrote: Hi, The SW eventdev rx adapter has an internal enqueue buffer 'rx_adapter- event_enqueue_buffer', which stores packets received from the NIC until at least BATCH_SIZE (=32) packets have been received before enqueueing them to eventdev. For e

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Mattias Rönnblom
On 2019-05-07 11:52, Elo, Matias (Nokia - FI/Espoo) wrote: Hi, The SW eventdev rx adapter has an internal enqueue buffer 'rx_adapter->event_enqueue_buffer', which stores packets received from the NIC until at least BATCH_SIZE (=32) packets have been received before enqueueing them to eventdev

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-07 Thread Damjan Marion (damarion)
-- Damjan On 7 May 2019, at 13:29, Honnappa Nagarahalli mailto:honnappa.nagaraha...@arm.com>> wrote: On 3/22/2019 11:57 AM, Jakub Grajciar wrote: Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar mailto:jgraj...@cisco.com>>

Re: [dpdk-dev] [RFC v5] /net: memory interface (memif)

2019-05-07 Thread Honnappa Nagarahalli
> > > >> On 3/22/2019 11:57 AM, Jakub Grajciar wrote: > >>> Memory interface (memif), provides high performance packet transfer > >>> over shared memory. > >>> > >>> Signed-off-by: Jakub Grajciar > >> > > > > <...> > > > >>With that in mind, I believe that 23Mpps is fine performance. No > >> p

Re: [dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Honnappa Nagarahalli
> > Hi, > > The SW eventdev rx adapter has an internal enqueue buffer 'rx_adapter- > >event_enqueue_buffer', which stores packets received from the NIC until at > least BATCH_SIZE (=32) packets have been received before enqueueing them > to eventdev. For example in case of validation testing, whe

Re: [dpdk-dev] [PATCH v2] timer: fix resource leak in finalize

2019-05-07 Thread Burakov, Anatoly
On 03-May-19 11:54 PM, Erik Gabriel Carrillo wrote: The finalize function should free the memzone created in the init function, rather than freeing the allocation the memzone references, otherwise a memzone descriptor can be leaked. Fixes: c0749f7096c7 ("timer: allow management in shared memory"

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

2019-05-07 Thread Honnappa Nagarahalli
> > Subject: [EXT] Re: [dpdk-stable] [PATCH v2] build: disable armv8 > > crypto extension > > > > > On May 3, 2019, at 10:50 AM, Yongseok Koh > > wrote: > > > > > >> I think this change might have an impact on the existing users. > > >> Does this change need to be documented somewhere (at least in

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Bruce Richardson
On Tue, May 07, 2019 at 11:09:51AM +0100, Luca Boccassi wrote: > On Fri, 2019-05-03 at 14:35 +0100, Bruce Richardson wrote: > > For testing of DPDK, we want to override the prefix given by the > > pkg-config file, so that we can get correct paths for DPDK installed > > in an unusual location. > >

Re: [dpdk-dev] [PATCH v2 2/4] test: verify calloc succeeded for sum variable

2019-05-07 Thread Ananyev, Konstantin
> Code tested calloc failures for pt & lpt variables > but not for the sum variable. Add a test for calloc > failure of sum. > > Signed-off-by: David Christensen > --- > v2: > * Removed change to ITER_MAX > > app/test/test_barrier.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [dpdk-dev] [PATCH v2 1/4] test: fix typo in print statement

2019-05-07 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Christensen > Sent: Monday, May 6, 2019 8:23 PM > To: dev@dpdk.org > Cc: David Christensen > Subject: [dpdk-dev] [PATCH v2 1/4] test: fix typo in print statement > > Change "much" to "match" in a printf.

Re: [dpdk-dev] [PATCH v2 4/4] test: fix memory barrier test failure on power CPUs

2019-05-07 Thread Ananyev, Konstantin
> > The memory barrier test fails on IBM Power 9 systems. Add additional > barriers to accommodate the weakly ordered model used on Power CPUs. > > Signed-off-by: David Christensen > --- > v2: > * Removed ifdef's for PPC since the rte_smp_*mb() macros are already > customized for each CPU

Re: [dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables to uint64_t

2019-05-07 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Christensen > Sent: Monday, May 6, 2019 8:24 PM > To: dev@dpdk.org > Cc: David Christensen > Subject: [dpdk-dev] [PATCH v2 3/4] test: change memory barrier variables to > uint64_t > > Memory barrier failu

Re: [dpdk-dev] [PATCH 19.08 2/6] examples: add support for relocated DPDK install

2019-05-07 Thread Luca Boccassi
On Fri, 2019-05-03 at 14:35 +0100, Bruce Richardson wrote: > For testing of DPDK, we want to override the prefix given by the > pkg-config file, so that we can get correct paths for DPDK installed > in an unusual location. > > Signed-off-by: Bruce Richardson < > bruce.richard...@intel.com > > > --

Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"

2019-05-07 Thread Ferruh Yigit
On 5/6/2019 9:09 AM, Andrew Rybchenko wrote: > On 5/4/19 11:45 PM, Thomas Monjalon wrote: >> 02/05/2019 22:27, Thomas Monjalon: >>> 02/05/2019 20:31, Ferruh Yigit: On 4/29/2019 10:52 AM, Thomas Monjalon wrote: > 25/04/2019 17:27, Ferruh Yigit: >> On 4/25/2019 2:29 PM, Thomas Monjalon w

Re: [dpdk-dev] [PATCH] doc: announce ABI change on eal and kni

2019-05-07 Thread Arnon Warshavsky
> > > Changing 'kni_fifo_init()' return type shouldn't be a problem at all, > perhaps it would be a problem if the content of the fifo changed but it is > not > the case. > Should I move this patch to deferred or reject?

[dpdk-dev] eventdev: sw rx adapter enqueue caching

2019-05-07 Thread Elo, Matias (Nokia - FI/Espoo)
Hi, The SW eventdev rx adapter has an internal enqueue buffer 'rx_adapter->event_enqueue_buffer', which stores packets received from the NIC until at least BATCH_SIZE (=32) packets have been received before enqueueing them to eventdev. For example in case of validation testing, where often a s

[dpdk-dev] [PATCH] doc/testpmd: update compile steps for bpf examples

2019-05-07 Thread Vipin Varghese
Add the missing arguments for compiling t2.c and t3.c BPF examples. Signed-off-by: Vipin Varghese --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst ind

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] build: disable armv8 crypto extension

2019-05-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, May 7, 2019 3:17 AM > To: Honnappa Nagarahalli > Cc: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; dev@dpdk.org; bruce.richard...@intel.com; > Pavan Nikhilesh Bhagavatula ; Shahaf Shuler > ; Gavin Hu (Arm Technology China) > ; s

[dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object

2019-05-07 Thread Dekel Peled
Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs some actions on the returned rxq_ibv. It doens't release the rxq_ibv when all is completed with success. This patch adds call to mlx5_rxq_ibv_release() where it's missing. Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verb