[dpdk-dev] [dpdk-announce] public-inbox archives are available

2019-05-29 Thread Ali Alnubani
Hi, This is to announce that dpdk.org now offers public-inbox archives, which have multiple features: - Searchable archives. - Emails are stored as git objects, and are cloneable through http. - You can mirror, host and manage your instance locally. - You can download an mbox per thread.

[dpdk-dev] [dpdk-announce] Reminder DPDK Userspace Proposals due on Friday

2019-05-29 Thread Trishan de Lanerolle
*New Venue for DPDK Userspace, * *LA CITE DU VIN* *Bordeaux, France* *September 19 - 20, 2019* *Call for Proposal is due on Friday, May 31st* https://events.linuxfoundation.jp/events/dpdk-userspace-2019-bordeaux/program/call-for-proposals-cfp/ Call For Paper submissions must be received by 11:59p

Re: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue

2019-05-29 Thread Shreyansh Jain
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Wednesday, May 29, 2019 2:48 PM > To: Shreyansh Jain > Cc: ferruh.yi...@intel.com; step...@networkplumber.org; bl...@debian.org; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue > >

Re: [dpdk-dev] [PATCH v2 2/5] build: enable large file support on 32-bit

2019-05-29 Thread Shreyansh Jain
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, May 28, 2019 4:38 PM > To: dev@dpdk.org > Cc: Shreyansh Jain ; Alejandro Lucero > ; Anatoly Burakov > ; sta...@dpdk.org; Maxime Coquelin > ; Zhihong Wang ; Luca > Boccassi ; Zhang XuemingX ; Bruce > Richardson > Subject: [PA

Re: [dpdk-dev] [PATCH 05/25] net/virtio: use new memory locking API

2019-05-29 Thread Tiwei Bie
[PATCH 05/25] net/virtio: use new memory locking API A minor nit: net/virtio -> net/virtio-user For the rest, Reviewed-by: Tiwei Bie On Wed, May 29, 2019 at 05:30:51PM +0100, Anatoly Burakov wrote: > Replace usages of direct access to shared memory config with > calls to the new API. > > Sig

[dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

2019-05-29 Thread Dan Wei
Modify AFU configurations for new Blue Bitstream of A10 on N3000 card: - AFU register access: RTL changes the UPL base address and the read/write commands of register indirect access. - Add delays to wait for the HW reset completion. - Refine log for debug: print UPL_version not only for vBNG bit s

Re: [dpdk-dev] [PATCH v2 08/11] net/hinic: add hinic PMD build and doc files

2019-05-29 Thread Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
Hi Stephen, Thank you for your comments. We will fix your comments at the next patches. Thanks, Ziyang Xuan -邮件原件- 发件人: Stephen Hemminger [mailto:step...@networkplumber.org] 发送时间: 2019年5月29日 12:59 收件人: Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_

[dpdk-dev] [Bug 287] netvsc PMD/dpdk/azure: Driver lockup with multi-queue configuration

2019-05-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=287 Bug ID: 287 Summary: netvsc PMD/dpdk/azure: Driver lockup with multi-queue configuration Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CON

Re: [dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors

2019-05-29 Thread Stephen Hemminger
On Thu, 30 May 2019 00:46:30 +0200 Thomas Monjalon wrote: > 23/05/2019 15:58, David Marchand: > > From: Stephen Hemminger > > > > The fields of the internal EAL core configuration are currently > > laid bare as part of the API. This is not good practice and limits > > fixing issues with layout

Re: [dpdk-dev] [PATCH v4 2/5] eal: add lcore accessors

2019-05-29 Thread Thomas Monjalon
23/05/2019 15:58, David Marchand: > From: Stephen Hemminger > > The fields of the internal EAL core configuration are currently > laid bare as part of the API. This is not good practice and limits > fixing issues with layout and sizes. > > Make new accessor functions for the fields used by curre

[dpdk-dev] [PATCH] examples/client_server_mp: check port ownership

2019-05-29 Thread Stephen Hemminger
The mp_server would accept a port mask that included hidden (owned) ports and which later caused either lost packets or failed initialization. This fixes explictly checks for ownership when parsing the port mask. Fixes: 5b7ba31148a8 ("ethdev: add port ownership") Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] test/rcu: use existing lcore API

2019-05-29 Thread Thomas Monjalon
23/05/2019 16:20, Maxime Coquelin: > On 5/22/19 5:06 PM, David Marchand wrote: > > Prefer the existing apis rather than direct access lcore_config that is > > going to disappear. > > > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") > > Cc: sta...@dpdk.org > > > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/4] net/cxgbe: do not dereference global config struct

2019-05-29 Thread Thomas Monjalon
15/05/2019 11:29, Maxime Coquelin: > > On 5/15/19 9:54 AM, David Marchand wrote: > > Prefer the existing apis rather than direct access the configuration > > structure. > > > > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") > > Cc:sta...@dpdk.org > > > > Signed-off-by: Da

Re: [dpdk-dev] [PATCH v2 0/3] cleanup kernel meson.build file for linux

2019-05-29 Thread Thomas Monjalon
17/05/2019 15:53, Luca Boccassi: > On Fri, 2019-05-17 at 14:45 +0100, Bruce Richardson wrote: > > Small cleanups to shorten the meson.build file in the kernel/linux > > directory, removing the unneeded version check and taking advantage > > of the > > subdir_done() function introduced in meson 0.46

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix build on RHEL8

2019-05-29 Thread Thomas Monjalon
27/05/2019 06:02, michael@intel.com: > From: Luo Gaoliang > > Build error was seen on RHEL8 when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled. > > Build error log: > /root/kni/dpdk-19.05/kernel/linux/kni/ethtool/igb/kcompat.h:3928:25: > error: 'const struct net_device_ops' has no member named 'ext

Re: [dpdk-dev] [PATCH v2] kni: remove ethtool support

2019-05-29 Thread Thomas Monjalon
24/05/2019 21:27, Neil Horman: > On Fri, May 24, 2019 at 05:55:20PM +0100, Ferruh Yigit wrote: > > Current design requires kernel drivers and they need to be probed by > > Linux up to some level so that they can be usable by DPDK for ethtool > > support, this requires maintaining the Linux drivers

Re: [dpdk-dev] [PATCH 00/15] prefix network structures

2019-05-29 Thread Thomas Monjalon
29/05/2019 19:29, David Marchand: > On Wed, May 29, 2019 at 6:50 PM Olivier Matz wrote: > > By the way, here is below a script that can be used to ease the > > porting of an application. It includes modifications proposed by > > David [1]. > > > > It is probably not 100% reliable, but it will do m

[dpdk-dev] [PATCH v5 8/8] net/bnxt: update HWRM API to version 1.10.0.74

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. doc/guides/rel_notes/release_19_08.rst |1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399

[dpdk-dev] [PATCH v5 7/8] net/bnxt: update HWRM API to version 1.10.0.48

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions(+),

[dpdk-dev] [PATCH v5 6/8] net/bnxt: update HWRM API to version 1.10.0.19

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514 insertions

[dpdk-dev] [PATCH v5 5/8] net/bnxt: fix RSS RETA indirection table ops

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde We are trying to update the indirection table for all the VNICs. We should update the table only for the default vnic0. Fix the reta update function to only update table entries that are selected by the update mask. Translate queue number to firmware group ID when updating an

[dpdk-dev] [PATCH v5 4/8] net/bnxt: implement vector mode driver

2019-05-29 Thread Lance Richardson
Introduce SSE vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. v3: * Eliminated vector mode configration flag.

[dpdk-dev] [PATCH v5 0/8] bnxt patchset

2019-05-29 Thread Lance Richardson
This patchset adds the following: 1) Support for vector mode TX and RX. 2) HWRM API update (split into multiple patches). 3) Fixes for RSS reta update and query. It also updates the release notes. v2: * Squashed patches 3 and 4 from v1 patchset. * Added Meson build support for vector mode P

[dpdk-dev] [PATCH v5 3/8] net/bnxt: compute and store scattered Rx status

2019-05-29 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- v4: * Moved a fix to bnxt_scattered_rx(), which is introduced in this patch, from patch

[dpdk-dev] [PATCH v5 2/8] net/bnxt: move Tx bd checking to header file

2019-05-29 Thread Lance Richardson
To allow sharing of tx_bds_in_hw() and bnxt_tx_avail() between vector-mode and non-vector transmit functions, move these functions into bnxt_txr.h. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- drivers/net/bnxt/bnxt_txr.c | 15 --- driv

[dpdk-dev] [PATCH v5 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update release doc briefly describing updates to bnxt PMD, including transmit optimization changes in the commits identified by the "Fixes:" tags below. Fixes: 5ef3592c97b9 ("net/bnxt: support bulk free of Tx mbufs") Fixes: 220de9869bc3 ("net/bnxt: optimize Tx batching") Sign

[dpdk-dev] [PATCH] net/ena: Fix admin cq polling for 32-bit apps

2019-05-29 Thread David Harton
Recent modifications to admin command queue polling logic did not support 32-bit applications. Updated the driver to work for 32 or 64 bit applications as well as avoiding roll-over possibility. Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version") Signed-off-by: David Harton --- driv

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
I see now that you had fixed them up... sorry for the noise. On Wed, May 29, 2019 at 4:35 PM Lance Richardson wrote: > > On Wed, May 29, 2019 at 4:28 PM Lance Richardson > wrote: > > > > On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > > > > > On 29/05/2019 16:02, Lance Richardson wrote

Re: [dpdk-dev] [PATCH 2/2] meson: make build configurable

2019-05-29 Thread Luca Boccassi
On Wed, 2019-05-29 at 19:39 +0300, Ilya Maximets wrote: > The first thing many developers do before start building DPDK is > disabling all the not needed divers and libraries. This happens > just because more than a half of DPDK dirvers and libraries are not > needed for the particular reason. For

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
On Wed, May 29, 2019 at 4:28 PM Lance Richardson wrote: > > On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > > > On 29/05/2019 16:02, Lance Richardson wrote: > > > From: Ajit Khaparde > > > > > > Update release doc briefly describing updates to bnxt PMD, > > > including transmit optimiza

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Lance Richardson
On Wed, May 29, 2019 at 2:16 PM Kevin Traynor wrote: > > On 29/05/2019 16:02, Lance Richardson wrote: > > From: Ajit Khaparde > > > > Update release doc briefly describing updates to bnxt PMD, > > including transmit optimization changes in the following > > commits: > > > > commit 5c26b1706862

Re: [dpdk-dev] [PATCH 2/2] meson: make build configurable

2019-05-29 Thread Michael Santana Francisco
On 5/29/19 12:39 PM, Ilya Maximets wrote: The first thing many developers do before start building DPDK is disabling all the not needed divers and libraries. This happens just because more than a half of DPDK dirvers and libraries are not needed for the particular reason. For example, you don't n

Re: [dpdk-dev] [PATCH 25/25] eal: hide shared memory config

2019-05-29 Thread David Marchand
On Wed, May 29, 2019 at 6:32 PM Anatoly Burakov wrote: > diff --git a/lib/librte_eal/common/eal_memcfg.h > b/lib/librte_eal/common/eal_memcfg.h > new file mode 100644 > index 0..75891e6cb > --- /dev/null > +++ b/lib/librte_eal/common/eal_memcfg.h > @@ -0,0 +1,75 @@ > Missing a license ba

Re: [dpdk-dev] [PATCH 00/25] Make shared memory config non-public

2019-05-29 Thread David Marchand
On Wed, May 29, 2019 at 6:31 PM Anatoly Burakov wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > The patchset is mostly a search-and-replace job and should > be pretty easy to review. However, the changes t

[dpdk-dev] [PATCH 09/12] net/enic: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic.h b/drivers/net/enic/enic.h index bd2783430c08..b

[dpdk-dev] [PATCH 12/12] net/mlx5: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index

[dpdk-dev] [PATCH 11/12] net/ixgbe: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 14 +- 2 files changed, 16 insertions(+), 31

[dpdk-dev] [PATCH 10/12] net/i40e: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drive

[dpdk-dev] [PATCH 07/12] net/e1000: remove unnecessary cast of void *

2019-05-29 Thread Stephen Hemminger
dev_private is void * so cast is unnecessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_ethdev.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index bd1c64c0367d..2e9fe

[dpdk-dev] [PATCH 08/12] net/ena: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/ena/ena_ethdev.c | 66 +--- 1 file changed, 24 insertions(+), 42 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.

[dpdk-dev] [PATCH 04/12] net/bnxt: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/bnxt/bnxt_ethdev.c | 86 - drivers/net/bnxt/bnxt_flow.c| 10 ++-- drivers/net/bnxt/bnxt_irq.c | 2 +- drivers

[dpdk-dev] [PATCH 05/12] net/bonding: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_p

[dpdk-dev] [PATCH 06/12] net/cxgbe: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/base/adapter.h | 2 +- drivers/net/cxgbe/cxgbe_ethdev.c | 60 +++--- drivers/net/cxgbe/cxgbe_filter.c | 2 +- dri

[dpdk-dev] [PATCH 02/12] net/ark: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/ark/ark_ethdev.c| 51 +++-- drivers/net/ark/ark_ethdev_rx.c | 4 +-- drivers/net/ark/ark_ethdev_tx.c | 2 +- 3 files

[dpdk-dev] [PATCH 03/12] net/axgbe: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/axgbe/axgbe_ethdev.c | 24 +++- drivers/net/axgbe/axgbe_rxtx.c | 2 +- 2 files changed, 16 insertions(+), 10 deletions(-) diff

[dpdk-dev] [PATCH 01/12] net/atlantic: remove unnecessary cast

2019-05-29 Thread Stephen Hemminger
The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger --- drivers/net/atlantic/atl_ethdev.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atl

[dpdk-dev] [PATCH 00/12] cleanup useless casts of void *

2019-05-29 Thread Stephen Hemminger
Many DPDK drivers have unnecessary cast of the void * pointer dev->data->dev_private. Stephen Hemminger (12): net/atlantic: remove unnecessary cast net/ark: remove unnecessary cast net/axgbe: remove unnecessary cast net/bnxt: remove unnecessary cast net/bonding: remove unnecessary cast

Re: [dpdk-dev] [PATCH 20/25] stack: use new tailq locking API

2019-05-29 Thread Eads, Gage
> Replace usages of direct access to shared memory config with calls to the > new API. > > Signed-off-by: Anatoly Burakov Acked-by: Gage Eads

Re: [dpdk-dev] [PATCH v4 1/8] net/bnxt: update release notes for bnxt

2019-05-29 Thread Kevin Traynor
On 29/05/2019 16:02, Lance Richardson wrote: > From: Ajit Khaparde > > Update release doc briefly describing updates to bnxt PMD, > including transmit optimization changes in the following > commits: > > commit 5c26b1706862 ("net/bnxt: support bulk free of Tx mbufs") > commit f8dea49ef89b ("

[dpdk-dev] [PATCH] net: fix the way how L4 checksum choice is tested

2019-05-29 Thread Ivan Malov
The API to prepare checksum offloads mistreats L4 checksum type enum values as self-contained flags. Turning these flag checks into enum checks causes warnings by GCC about possibly uninitialised IPv4 header pointer. The issue was found to show up in the case of GCC versions 4.8.5 and 5.4.0, howev

Re: [dpdk-dev] [PATCH 00/15] prefix network structures

2019-05-29 Thread David Marchand
On Wed, May 29, 2019 at 6:50 PM Olivier Matz wrote: > On Wed, May 29, 2019 at 09:59:11AM +0200, David Marchand wrote: > > On Fri, May 24, 2019 at 1:38 PM Ferruh Yigit > wrote: > > > > > On 5/21/2019 5:13 PM, Olivier Matz wrote: > > > > The rte_net headers conflict with the libc headers, because

Re: [dpdk-dev] [RFC v9] /net: memory interface (memif)

2019-05-29 Thread Ferruh Yigit
On 5/20/2019 11:18 AM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > packet transfer over shared memory. Can you please update the patch title as following in next version: net/memif: introduce memory interface (memif) PMD Can you please drop the RFC from next vers

Re: [dpdk-dev] [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c

2019-05-29 Thread Zhang, Qi Z
> -Original Message- > From: Richardson, Bruce > Sent: Friday, May 17, 2019 3:21 AM > To: David Harton > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: Re: [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c > > On Thu, May 16, 2019 at 02:28:03PM -0400, David Harton

Re: [dpdk-dev] [PATCH 22/25] mempool: use new mempool list locking API

2019-05-29 Thread Andrew Rybchenko
On 5/29/19 7:31 PM, Anatoly Burakov wrote: Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 17/25] mempool: use new tailq locking API

2019-05-29 Thread Andrew Rybchenko
On 5/29/19 7:31 PM, Anatoly Burakov wrote: Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov Reviewed-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH 01/25] eal: add API to lock/unlock memory hotplug

2019-05-29 Thread Stephen Hemminger
On Wed, 29 May 2019 17:30:47 +0100 Anatoly Burakov wrote: > +rte_eal_mcfg_mem_read_lock(void) > +{ > + struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; > + rte_rwlock_read_lock(&mcfg->memory_hotplug_lock); > +} > + We should also make eal configuration private but t

Re: [dpdk-dev] [PATCH 25/25] eal: hide shared memory config

2019-05-29 Thread Stephen Hemminger
On Wed, 29 May 2019 17:31:11 +0100 Anatoly Burakov wrote: > +static inline void > +rte_eal_mcfg_wait_complete(struct rte_mem_config *mcfg) > +{ > + /* wait until shared mem_config finish initialising */ > + while (mcfg->magic != RTE_MAGIC) > + rte_pause(); > +} > Not fast pat

[dpdk-dev] [PATCH 2/2] meson: make build configurable

2019-05-29 Thread Ilya Maximets
The first thing many developers do before start building DPDK is disabling all the not needed divers and libraries. This happens just because more than a half of DPDK dirvers and libraries are not needed for the particular reason. For example, you don't need dpaa*, octeon*, various croypto devices,

[dpdk-dev] [PATCH 1/2] meson: don't check dependencies for tests if not required

2019-05-29 Thread Ilya Maximets
Don't need to check dependencies if test apps will not be built anyway. Signed-off-by: Ilya Maximets --- app/test/meson.build | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/app/test/meson.build b/app/test/meson.build index 83391cef0..

[dpdk-dev] [PATCH 0/2] Make meson configurable.

2019-05-29 Thread Ilya Maximets
See the full description in patch #2. Please, let me know if I'm missing some obvious way to disable libs and drivers in meson. Ilya Maximets (2): meson: don't check dependencies for tests if not required meson: make build configurable app/meson.build | 5 + app/test/meson

[dpdk-dev] [PATCH 25/25] eal: hide shared memory config

2019-05-29 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. Signed-off-by: Anatoly Burakov --- a

[dpdk-dev] [PATCH 23/25] eal: remove unused macros

2019-05-29 Thread Anatoly Burakov
These macros are not used anymore and can be removed. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_eal.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h index 73754aaf2..a93a

[dpdk-dev] [PATCH 24/25] net/ena: fix direct access to shared memory config

2019-05-29 Thread Anatoly Burakov
The ENA driver calculates a ring's NUMA node affinity by directly accessing the memzone list. Fix it to do it through the public API's instead. Signed-off-by: Anatoly Burakov --- drivers/net/ena/ena_ethdev.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/

[dpdk-dev] [PATCH 21/25] eal: add new API to lock/unlock mempool list

2019-05-29 Thread Anatoly Burakov
Currently, in order to lock access to the mempool list, a direct access to the shared memory structure is needed. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 28 +++ .../common/include/rte_eal_memconfig.h|

[dpdk-dev] [PATCH 22/25] mempool: use new mempool list locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_mempool/rte_mempool.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_

[dpdk-dev] [PATCH 20/25] stack: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_stack/rte_stack.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_stack/rte_stack.c b/lib/librte_stack/rte_stack.c in

[dpdk-dev] [PATCH 19/25] ring: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_ring/rte_ring.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c index b8

[dpdk-dev] [PATCH 18/25] reorder: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_reorder/rte_reorder.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_reorder/rte_reorder.c b/lib/librte_reorder/rte_reor

[dpdk-dev] [PATCH 17/25] mempool: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_mempool/rte_mempool.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c i

[dpdk-dev] [PATCH 13/25] eventdev: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eventdev/rte_event_ring.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_eventdev/rte_event_ring.c b/lib/librte_event

[dpdk-dev] [PATCH 16/25] member: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_member/rte_member.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/librte_member/rte_member.c b/lib/librte_member/rte_member.

[dpdk-dev] [PATCH 15/25] lpm: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_lpm/rte_lpm.c | 24 lib/librte_lpm/rte_lpm6.c | 14 +++--- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH 14/25] hash: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_hash/rte_cuckoo_hash.c | 16 lib/librte_hash/rte_fbk_hash.c| 14 +++--- lib/librte_kni/rte_kni.c | 16 3 files c

[dpdk-dev] [PATCH 12/25] efd: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_efd/rte_efd.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_efd/rte_efd.c b/lib/librte_efd/rte_efd.c index 14e493bc3..7

[dpdk-dev] [PATCH 09/25] eal: add EAL tailq list lock/unlock API

2019-05-29 Thread Anatoly Burakov
Currently, locking/unlocking the TAILQ list requires direct access to the shared memory config. Add an API to do the same. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 28 +++ .../common/include/rte_eal_memconfig.h| 24 +++

[dpdk-dev] [PATCH 11/25] distributor: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_distributor/rte_distributor.c | 4 ++-- lib/librte_distributor/rte_distributor_v20.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/l

[dpdk-dev] [PATCH 10/25] acl: use new tailq locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_acl/rte_acl.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_acl/rte_acl.c b/lib/librte_acl/rte_acl.c index c436a9bf

[dpdk-dev] [PATCH 08/25] vfio: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/linux/eal/eal_vfio.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/li

[dpdk-dev] [PATCH 07/25] malloc: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/malloc_heap.c | 14 ++--- lib/librte_eal/common/rte_malloc.c | 32 + 2 files changed, 20 insertions(+), 26 deletions(-)

[dpdk-dev] [PATCH 06/25] mem: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_memory.c | 43 ++- 1 file changed, 18 insertions(+), 25 deletions(-) diff --git a/lib/librte_eal/common/eal_common_memory.c

[dpdk-dev] [PATCH 05/25] net/virtio: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/dr

[dpdk-dev] [PATCH 04/25] net/mlx5: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- drivers/net/mlx5/mlx5_mr.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c index 66e8e874e

[dpdk-dev] [PATCH 03/25] net/mlx4: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- drivers/net/mlx4/mlx4_mr.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c index 48d458ad4

[dpdk-dev] [PATCH 00/25] Make shared memory config non-public

2019-05-29 Thread Anatoly Burakov
This patchset removes the shared memory config from public API, and replaces all usages of said config with new API calls. The patchset is mostly a search-and-replace job and should be pretty easy to review. However, the changes to ENA driver are of particular interest, because they're using the s

[dpdk-dev] [PATCH 01/25] eal: add API to lock/unlock memory hotplug

2019-05-29 Thread Anatoly Burakov
Currently, the memory hotplug is locked automatically by all memory-related _walk() functions, but sometimes locking the memory subsystem outside of them is needed. There is no public API to do that, so it creates a dependency on shared memory config to be public. Fix this by introducing a new API

[dpdk-dev] [PATCH 02/25] bus/fslmc: use new memory locking API

2019-05-29 Thread Anatoly Burakov
Replace usages of direct access to shared memory config with calls to the new API. Signed-off-by: Anatoly Burakov --- drivers/bus/fslmc/fslmc_vfio.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index 1

[dpdk-dev] [PATCH] doc: update quickstart guide for building with meson

2019-05-29 Thread Bruce Richardson
The build-sdk-meson.txt file is a little out of date, so update it with information on the latest build requirements, and remove any content no longer needed. Since the cross-compilation file quoted in the document is now considerably longer and more complex than previous, replace the contents of

Re: [dpdk-dev] [PATCH 1/4] build: fix quoting on RTE_ARCH string value

2019-05-29 Thread Luca Boccassi
On Wed, 2019-05-29 at 16:41 +0100, Bruce Richardson wrote: > The value for RTE_ARCH needs to be quoted when output to the > rte_build_config.h file, so use "set_quoted" rather than "set" when > assigning it. > > Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja > builds") > Fixes

[dpdk-dev] [PATCH 3/4] eal: allow checking CPU flags by name

2019-05-29 Thread Bruce Richardson
Rather than using enum values for CPU flags, which means the symbols don't exist on other architectures, provide a flag lookup by name, allowing us to unconditionally check for a CPU flag. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/eal_common_cpuflags.c | 41 + .

[dpdk-dev] [PATCH 4/4] net: replace ifdefs with runtime branches

2019-05-29 Thread Bruce Richardson
Use the flag checking functions and a couple of empty stubs to remove the ifdefs from the middle of the C code, and replace them with more readable regular if statements. Other ifdefs at the top of the file are kept, but are not mixed with C code, so there is a clean separation. Signed-off-by: Bru

[dpdk-dev] [PATCH 2/4] config/arm: fix missing define for arm platforms

2019-05-29 Thread Bruce Richardson
The RTE_ARCH macro was defined for all platforms when using make, but was only defined for x86 and ppc platforms when using meson. Fix this omission. Fixes: b1d48c41189a ("build: support ARM with meson") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- config/arm/meson.build | 2 ++ 1 fi

[dpdk-dev] [PATCH 0/4] Enhance CPU flag support

2019-05-29 Thread Bruce Richardson
Currently in DPDK, any checks for the presence or absense of specific CPU flags has to be enclosed in #ifdef blocks, since the flags are conditionally defined per architecture as enums. This set attempts to improve this situation by allowing the flags to be queried as strings, with a CPU architectu

[dpdk-dev] [PATCH 1/4] build: fix quoting on RTE_ARCH string value

2019-05-29 Thread Bruce Richardson
The value for RTE_ARCH needs to be quoted when output to the rte_build_config.h file, so use "set_quoted" rather than "set" when assigning it. Fixes: a25a650be5f0 ("build: add infrastructure for meson and ninja builds") Fixes: 54d609a13876 ("build: add ppc64 meson build") Cc: bl...@debian.org Cc:

Re: [dpdk-dev] 19.08 scheduling question

2019-05-29 Thread Ferruh Yigit
On 5/29/2019 4:29 PM, Lance Richardson wrote: > This page gives a "proposal deadline" of June 3 for the 19.08 release: > > https://core.dpdk.org/roadmap/ > > Apologies if this is a faq, but is the "proposal" simply a v1 patch > set implementing the proposed change, or is some other mechanism

[dpdk-dev] 19.08 scheduling question

2019-05-29 Thread Lance Richardson
This page gives a "proposal deadline" of June 3 for the 19.08 release: https://core.dpdk.org/roadmap/ Apologies if this is a faq, but is the "proposal" simply a v1 patch set implementing the proposed change, or is some other mechanism to be used? Thanks, Lance

[dpdk-dev] [PATCH v4 7/8] net/bnxt: update HWRM API to version 1.10.0.48

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM version to 1.10.0.48 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3156 +--- 1 file changed, 2874 insertions(+),

[dpdk-dev] [PATCH v4 8/8] net/bnxt: update HWRM API to version 1.10.0.74

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.74 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. doc/guides/rel_notes/release_19_08.rst |1 + drivers/net/bnxt/hsi_struct_def_dpdk.h | 1399

[dpdk-dev] [PATCH v4 6/8] net/bnxt: update HWRM API to version 1.10.0.19

2019-05-29 Thread Lance Richardson
From: Ajit Khaparde Update HWRM API to version 1.10.0.19 Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Signed-off-by: Lance Richardson --- v3: * Fixed headline in commit log. drivers/net/bnxt/hsi_struct_def_dpdk.h | 3112 +++- 1 file changed, 2514 insertions

[dpdk-dev] [PATCH v4 4/8] net/bnxt: implement vector mode driver

2019-05-29 Thread Lance Richardson
Introduce SSE vector mode support for the bnxt pmd. Signed-off-by: Lance Richardson Signed-off-by: Ajit Khaparde --- v2: * Squashed with v1 patch 4 ("fix double counting VLAN tags"). * Dropped two unnecessary coding style changes from bnxt_txr.h. v3: * Eliminated vector mode configration flag.

[dpdk-dev] [PATCH v4 3/8] net/bnxt: compute and store scattered Rx status

2019-05-29 Thread Lance Richardson
In preparation for a bnxt vector-mode driver, compute and store scattered_rx status for the device when started. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Maxime Coquelin --- v4: * Moved a fix to bnxt_scattered_rx(), which is introduced in this patch, from patch

  1   2   >