Re: [dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb

2019-06-07 Thread Stephen Hemminger
On Fri, 7 Jun 2019 17:19:56 -0700 Stephen Hemminger wrote: > +++ b/kernel/linux/kni/kni_net.c > @@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni) > data_kva = kva2data_kva(kva); > kni->va[i] = pa2va(kni->pa[i], kva); > > - skb = dev_alloc_skb(

[dpdk-dev] [PATCH 6/9] kni: drop unused status element

2019-06-07 Thread Stephen Hemminger
Yet another ethtool leftover. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index e39af97feaa7..f3e6c3ca4efa 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni

[dpdk-dev] [PATCH 9/9] doc: update KNI documentation

2019-06-07 Thread Stephen Hemminger
Make the KNI documentation reflect modern kernel networking. Ifconfig has been superseded by iproute2 for 15 years. Iproute2 is well maintained, supports current feature set. Ethtool is no longer supported by KNI. Tshark is a better replacement for tcpdump. Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH 7/9] kni: use proper type for kni fifo's

2019-06-07 Thread Stephen Hemminger
Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644

[dpdk-dev] [PATCH 8/9] kni: return -EFAULT if copy_from_user fails

2019-06-07 Thread Stephen Hemminger
The correct thing to return if user gives a bad data is to return -EFAULT. Logging is also discouraged because it could be used as a DoS attack. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_misc.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/

[dpdk-dev] [PATCH 5/9] kni: drop unused group_id and device_id

2019-06-07 Thread Stephen Hemminger
Kni devices no longer are restricted to PCI and device_id in kni_dev is no longer used. The group_id is set but never used. The fields do need to stay in the ABI (dev_info) but kernel can ignore them. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 4 kernel/linux/kni/k

[dpdk-dev] [PATCH 4/9] kni: don't keep stats in kni_net

2019-06-07 Thread Stephen Hemminger
Since kernel 2.6.28 the network subsystem has provided dev->stats for devices to use statistics handling and is the default if no ndo_get_stats is provided. This allow allows for 64 bit (rather than just 32 bit) statistics with KNI. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.

[dpdk-dev] [PATCH 3/9] kni: drop unused field

2019-06-07 Thread Stephen Hemminger
The kni net structure only exists in driver no API/ABI. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index 44a5a61f7279..0117941e5a6c 100644 --- a/kernel/linux/kni/kni

[dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb

2019-06-07 Thread Stephen Hemminger
netdev_alloc_skb is optimized to any alignment or setup of skb->dev that is required. The kernel has chosen to not pad packets on x86 (for many years), because it is faster. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 17 +++-- 1 file changed, 3 insertions(+), 1

[dpdk-dev] [PATCH 1/9] kni: don't need stubs for rx_mode or ioctl

2019-06-07 Thread Stephen Hemminger
The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net

[dpdk-dev] [PATCH 0/9] kni: cleanups and improvements

2019-06-07 Thread Stephen Hemminger
Going over using KNI with netvsc, saw lots of remove for improvment (deleting code). This is still mostly "putting lipstick on a pig" all users would be better off using virtio_user rather than KNI. Stephen Hemminger (9): kni: don't need stubs for rx_mode or ioctl kni: use netdev_alloc_skb

[dpdk-dev] [PATCH v4] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-07 Thread Nicolas Chautru
Supports for FEC 4G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nicolas Chautru --- config/common_base |6 + doc/guides/bbdevs/fpga_lte_fec.rst | 318 +++ doc/guides/bbdevs/index.rst|1 + drivers/baseband/Makef

[dpdk-dev] [PATCH v4] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-07 Thread Nicolas Chautru
Update v4: Fix warning for the DEBUG configuration Update v3: Squashing 3 previous patches into one as recommended. This is adding a new PMD driver for BBDEV device based on FPGA implementation on PAC N3000 HW to provide FEC 4G acceleration. v1 was shared earlier on this patchwork : https://pa

[dpdk-dev] [PATCH v4 3/3] baseband/turbo_sw: meson build support for PMD driver

2019-06-07 Thread Nicolas Chautru
Signed-off-by: Nicolas Chautru --- drivers/baseband/meson.build | 2 +- drivers/baseband/turbo_sw/meson.build | 30 ++ meson_options.txt | 2 ++ 3 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 drivers/baseband/turbo_s

[dpdk-dev] [PATCH v4 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK

2019-06-07 Thread Nicolas Chautru
Adding compile flag to allow to build the turbo_sw PMD without dependency to have the SDK libraries installed. Signed-off-by: Nicolas Chautru --- config/common_base | 3 +- drivers/baseband/turbo_sw/Makefile | 13 +++ drivers/baseband/turbo_sw/bbd

[dpdk-dev] [PATCH v4 2/3] docs/guides: updating turbo_sw building steps

2019-06-07 Thread Nicolas Chautru
The documentation is clarified to point to steps on building the SDK libraries which are now publicly available: https://software.intel.com/en-us/articles/flexran-lte-and-5g-nr-fec-software-development-kit-modules Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/turbo_sw.rst | 81 +++

[dpdk-dev] [PATCH v4 0/3] BBDEV turbo_sw PMD compilation fix

2019-06-07 Thread Nicolas Chautru
Update v4: Missed one file for meson build path and minor change to prevent warning for some configurations due to unused symbols. Update v3: Cosmetic changes in documentation commit to be more 4G/AVX2 specific. Update v2: Splitting into 3 patches as recommended (ignore previous v2 which had

[dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"

2019-06-07 Thread Stephen Hemminger
From: Stephen Hemminger This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. That commit breaks support for netvsc PMD with MLX SRIOV on both Hyper-V and Azure. Signed-off-by: Stephen Hemminger --- drivers/net/mlx4/mlx4.c | 4 ++-- drivers/net/mlx5/mlx5.c | 4 ++-- 2 files changed, 4

Re: [dpdk-dev] Please revert mlx IOVA VA mode patch

2019-06-07 Thread Yongseok Koh
We'll have to look into the issue. It doesn't seem simple though. Thomas, can you please revert the patch from the master? Thanks, Yongseok > On Jun 7, 2019, at 11:33 AM, Stephen Hemminger > wrote: > > The Netvsc PMD got broken on DPDK 19.08 by a bad patch in Mellanox driver. > On a simple se

Re: [dpdk-dev] [PATCH 14/14] test: skip tests when missing requirements

2019-06-07 Thread Honnappa Nagarahalli
> > Let's mark as skipped the tests when they are missing some requirements like a > number of used cores or specific hardware availability, like compress, crypto > or > eventdev devices. > > Signed-off-by: David Marchand > --- > app/test/test.c | 24 ---

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-07 Thread Richardson, Bruce
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, June 7, 2019 7:35 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Richardson, Bruce ; Andrew > Rybchenko > Subject: Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses > as b

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-07 Thread Richardson, Bruce
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, June 7, 2019 6:00 PM > To: Stephen Hemminger ; dev@dpdk.org > Cc: Richardson, Bruce ; Andrew Rybchenko > > Subject: RE: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses > as being 2-byte aligned > > > > > ---

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-07 Thread Stephen Hemminger
On Fri, 7 Jun 2019 16:59:32 + "Ananyev, Konstantin" wrote: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Wednesday, June 5, 2019 7:10 PM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Stephen Hemminger > > ; Andrew Rybch

[dpdk-dev] Please revert mlx IOVA VA mode patch

2019-06-07 Thread Stephen Hemminger
The Netvsc PMD got broken on DPDK 19.08 by a bad patch in Mellanox driver. On a simple setup with SRIOV enabled and using netvsc PMD with the testpmd. It worked in 19.05 and does not work with current master. The probe code gets stuck because netvsc PMD sends a request to host and never sees a res

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-07 Thread Wiles, Keith
> On Jun 7, 2019, at 10:42 AM, Ray Kinsella wrote: > > > > On 06/06/2019 16:03, Neil Horman wrote: >> On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Neil Horman Sent: Thursday, June 6, 2019 7:05 PM To: Jerin Ja

Re: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

2019-06-07 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, June 5, 2019 7:10 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Stephen Hemminger > ; Andrew Rybchenko > > Subject: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addre

Re: [dpdk-dev] [PATCH] net/failsafe: fix reported device info

2019-06-07 Thread Ferruh Yigit
On 6/7/2019 1:18 PM, Gaëtan Rivet wrote: > On Fri, Jun 07, 2019 at 11:58:27AM +0100, Ferruh Yigit wrote: >> On 5/16/2019 4:53 AM, Stephen Hemminger wrote: >>> The failsafe driver device info had several issues in the >>> info it reported in dev_info_get: >>> - it cleared dev_info->device set in r

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get link status nowait

2019-06-07 Thread Scott Daniels
Acked-by: Scott Daniels dani...@research.att.com On Fri, 7 Jun 2019, Haiyue Wang wrote: To get the VF's link status by calling 'rte_eth_link_get_nowait()', the VF not only check PF's physical link status, but also check the mailbox running status. And mailbox checking will generate mailbox i

Re: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-07 Thread Iremonger, Bernard
Hi Viacheslav, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Viacheslav Ovsiienko > Sent: Monday, May 27, 2019 6:47 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst routines > > There is the te

[dpdk-dev] [PATCH v2] net/ixgbevf: add an option pflink_fullchk to get link status nowait

2019-06-07 Thread Haiyue Wang
To get the VF's link status by calling 'rte_eth_link_get_nowait()', the VF not only check PF's physical link status, but also check the mailbox running status. And mailbox checking will generate mailbox interrupt in PF, it will be worse if many VFs are running in the system, the PF will have to han

Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional switch rules

2019-06-07 Thread Stillwell Jr, Paul M
> -Original Message- > From: Maxime Coquelin > Sent: Friday, June 7, 2019 5:41 AM > To: Stillwell Jr, Paul M ; Rong, Leyi > ; Zhang, Qi Z > Cc: dev@dpdk.org; Nowlin, Dan > Subject: Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional > switch rules > > > > On 6/5/19 6:34 PM, S

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-07 Thread Ray Kinsella
On 06/06/2019 16:03, Neil Horman wrote: > On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: >>> -Original Message- >>> From: Neil Horman >>> Sent: Thursday, June 6, 2019 7:05 PM >>> To: Jerin Jacob Kollanukkaran >>> Cc: Bruce Richardson ; dev@dpdk.org; >>> Thom

Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-07 Thread Wang, Haiyue
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Friday, June 7, 2019 22:38 > To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Lu, > Wenzhuo ; Wang, Liang-min ; > dani...@research.att.com > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add the description for opt

Re: [dpdk-dev] [PATCH] doc: update NIC support guide for bnxt and release notes

2019-06-07 Thread Ferruh Yigit
On 6/7/2019 2:33 PM, Lance Richardson wrote: > From: Ajit Khaparde > > Add support for the Broadcom NetXtreme-E (BCM57500) family of controllers > (aka Thor). The BCM57500 device is a 200G Ethernet controller with > 50G PAM-4 and PCIe 4.0 > > Signed-off-by: Ajit Khaparde > Signed-off-by: Lance

Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-07 Thread Kevin Traynor
On 07/06/2019 14:55, Wang, Haiyue wrote: >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Friday, June 7, 2019 20:25 >> To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z >> ; Lu, >> Wenzhuo ; Wang, Liang-min ; >> dani...@research.att.com >> Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-07 Thread Ferruh Yigit
On 6/7/2019 2:45 PM, Lance Richardson wrote: > On Fri, Jun 7, 2019 at 6:52 AM Ferruh Yigit wrote: >> >> On 6/7/2019 11:48 AM, Ferruh Yigit wrote: >>> On 6/2/2019 6:42 PM, Lance Richardson wrote: NOTE: This patch series has dependencies on the "bnxt patchset" series that is currently unde

Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-06-07 Thread Iremonger, Bernard
Hi Wei, > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > > > There is no need to do such a check when set macsec for ixgbe, > > reconfig_device_queueand is also useless. If we do not delete this Typo: space missing before "and" in previous line. > > unnessary code, us

Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-07 Thread Wang, Haiyue
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Friday, June 7, 2019 20:25 > To: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Lu, > Wenzhuo ; Wang, Liang-min ; > dani...@research.att.com > Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add the description for opt

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-07 Thread Honnappa Nagarahalli
> >> > > >> > Thomas Monjalon writes: > >> > > >> > > >> > > >> > The compilation of the master branch is failing for aarch64: > >> > > >> > https://travis-ci.com/DPDK/dpdk > >> > > >> > The log is so much verbose that I am not able to understand what > >> > > >> > is really wrong. > >> > > >>

Re: [dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-07 Thread Lance Richardson
On Fri, Jun 7, 2019 at 6:52 AM Ferruh Yigit wrote: > > On 6/7/2019 11:48 AM, Ferruh Yigit wrote: > > On 6/2/2019 6:42 PM, Lance Richardson wrote: > >> NOTE: This patch series has dependencies on the "bnxt patchset" > >> series that is currently under review. > >> > >> This patch series adds suppo

[dpdk-dev] [PATCH] doc: update NIC support guide for bnxt and release notes

2019-06-07 Thread Lance Richardson
From: Ajit Khaparde Add support for the Broadcom NetXtreme-E (BCM57500) family of controllers (aka Thor). The BCM57500 device is a 200G Ethernet controller with 50G PAM-4 and PCIe 4.0 Signed-off-by: Ajit Khaparde Signed-off-by: Lance Richardson --- doc/guides/nics/bnxt.rst | 6 +

Re: [dpdk-dev] [PATCH] app/testpmd: add warning message when user sets rxq greater than txq

2019-06-07 Thread Iremonger, Bernard
Hi Herakliusz, > -Original Message- > From: Lipiec, Herakliusz > Sent: Thursday, May 2, 2019 4:45 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Xiao, QimaiX ; Wang, Ying A > ; Lipiec, Herakliusz > Subject: [PATCH] app/testpmd: add warning message when use

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-07 Thread Aaron Conole
Honnappa Nagarahalli writes: >> > >> > Thomas Monjalon writes: >> > >> > >> > >> > The compilation of the master branch is failing for aarch64: >> > >> > https://travis-ci.com/DPDK/dpdk >> > >> > The log is so much verbose that I am not able to understand what >> > >> > is really wrong. >> >

Re: [dpdk-dev] [PATCH 00/49] shared code update

2019-06-07 Thread Maxime Coquelin
Hi Leyi, On 6/6/19 7:44 AM, Rong, Leyi wrote: -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, June 5, 2019 12:56 AM To: Rong, Leyi ; Zhang, Qi Z Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 00/49] shared code update Hi Leyi, On 6/4/19

Re: [dpdk-dev] [PATCH 04/39] examples/l2fwd-event: move global vars to common header

2019-06-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Friday, June 7, 2019 4:15 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org; > Lukas Bartosik ; Pavan Nik

Re: [dpdk-dev] [PATCH 47/49] net/ice/base: enable additional switch rules

2019-06-07 Thread Maxime Coquelin
On 6/5/19 6:34 PM, Stillwell Jr, Paul M wrote: if (!s_rule) @@ -5576,8 +5606,8 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups, s_rule->pdata.lkup_tx_rx.recipe_id = CPU_TO_LE16(rid); s_rule->pdata.lkup_tx_rx.act = CPU_TO_LE32(act); - ice_

Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-07 Thread Kevin Traynor
On 07/06/2019 04:10, Haiyue Wang wrote: > Add the detail description for this pflink_fullchk option, when it will > be used, and it is used for fixing what kind of issue. > You can squash the docs into the 1/2 patch. > Signed-off-by: Haiyue Wang > --- > doc/guides/nics/ixgbe.rst | 18 +

Re: [dpdk-dev] [PATCH] net/failsafe: fix reported device info

2019-06-07 Thread Gaëtan Rivet
On Fri, Jun 07, 2019 at 11:58:27AM +0100, Ferruh Yigit wrote: > On 5/16/2019 4:53 AM, Stephen Hemminger wrote: > > The failsafe driver device info had several issues in the > > info it reported in dev_info_get: > > - it cleared dev_info->device set in rte_eth_dev_info_get > > - many fields (for

Re: [dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-07 Thread Scott Daniels
Acked-by: Scott Daniels dani...@research.att.com On Thu, 6 Jun 2019, Haiyue Wang wrote: Add the detail description for this pflink_fullchk option, when it will be used, and it is used for fixing what kind of issue. Signed-off-by: Haiyue Wang

Re: [dpdk-dev] [PATCH] net/failsafe: fix reported device info

2019-06-07 Thread Ferruh Yigit
On 5/16/2019 4:53 AM, Stephen Hemminger wrote: > The failsafe driver device info had several issues in the > info it reported in dev_info_get: > - it cleared dev_info->device set in rte_eth_dev_info_get > - many fields (for example max_rx_queue) should be the minimum > of all sub devices >

Re: [dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-07 Thread Ferruh Yigit
On 6/7/2019 11:48 AM, Ferruh Yigit wrote: > On 6/2/2019 6:42 PM, Lance Richardson wrote: >> NOTE: This patch series has dependencies on the "bnxt patchset" >> series that is currently under review. >> >> This patch series adds support to the bnxt PMD for the >> BCM57508 Ethernet controller (a.k.a

Re: [dpdk-dev] [PATCH 00/11] add support for BCM57508 controller

2019-06-07 Thread Ferruh Yigit
On 6/2/2019 6:42 PM, Lance Richardson wrote: > NOTE: This patch series has dependencies on the "bnxt patchset" > series that is currently under review. > > This patch series adds support to the bnxt PMD for the > BCM57508 Ethernet controller (a.k.a the "Thor" controller). Can you please send doc

Re: [dpdk-dev] [PATCH 04/39] examples/l2fwd-event: move global vars to common header

2019-06-07 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Friday, June 7, 2019 3:33 PM > To: Anoob Joseph ; Nikhil Rao ; > Erik Gabriel Carrillo ; Abhinandan Gujjar > ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Pra

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-07 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Thursday, June 6, 2019 8:49 PM > To: Varghese, Vipin > Cc: olivier.m...@6wind.com; Pattan, Reshma ; Wiles, > Keith ; dev@dpdk.org; > Padubidri, Sanjay A > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] rte_eth_dev_count() returns 0 with ENA device

2019-06-07 Thread Michał Krawczyk
Hi Reeve, On 07.06.2019 02:21, Reeve Yang wrote: some followup ... I debugged more, it looks like rte_pci_probe is not happening, so the rte_eth_dev_allocate is not called at all ..., buy why is that? I ran testpmd, it shows no probed ethernet device. > # /opt/bluecoat/sslv/bin/testpmd testpm

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-07 Thread Neil Horman
On Fri, Jun 07, 2019 at 09:41:07AM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 10:26 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PAT

[dpdk-dev] [PATCH v2 2/3] test/ipsec: add extra test configuration

2019-06-07 Thread Bernard Iremonger
Add extra test configuration for BURST_SIZE packets Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index cce15a7..b92068e 100644 --- a/app/test/test_ipsec.c +++ b/app

[dpdk-dev] [PATCH v2 3/3] test/ipsec: improve debug in group tests

2019-06-07 Thread Bernard Iremonger
Add dump_grp_pkt() function. Dump invalid mbuf data in case of error in group tests 12 and 13. Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c index b

[dpdk-dev] [PATCH v2 0/3] test/ipsec: fixes and improvements

2019-06-07 Thread Bernard Iremonger
The following patches contain one fix and improvements to test_ipsec.c Changes in v2: - Patch 1 has been dropped as it hides the issue with QAT PMD. Patch 3 has been dropped as the hang issue with QAT device is not occurring with the latest DPDK 18.08 code. The commit message for patc

[dpdk-dev] [PATCH v2 1/3] test/ipsec: fix log messages in tests

2019-06-07 Thread Bernard Iremonger
Error log messages after the create_sa() function calls were using the wrong function name. The function name is replaced with create_sa. Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- app/test/test_ipsec.c | 44

[dpdk-dev] [PATCH v2 09/10] doc/crypto: document digest-encrypted limitations in qat

2019-06-07 Thread Damian Nowak
This patch adds description of limitation when using digest-appended auth-cipher operations on QuickAssist Technology driver. Signed-off-by: Damian Nowak --- doc/guides/cryptodevs/qat.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qa

[dpdk-dev] [PATCH v2 06/10] test/crypto: add kasumi test cases for auth-cipher

2019-06-07 Thread Damian Nowak
This patch adds test cases for kasumi in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 20

[dpdk-dev] [PATCH v2 10/10] doc: update release notes for 19.08

2019-06-07 Thread Damian Nowak
This patch adds release note entries for hash-cipher digest-encrypted operations and new digest_encrypted feature flag. Signed-off-by: Damian Nowak --- doc/guides/rel_notes/release_19_08.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc

[dpdk-dev] [PATCH v2 08/10] test/crypto: return correct value if feature not supported

2019-06-07 Thread Damian Nowak
This patch makes unsupported tests visible in the testsuite summary. Signed-off-by: Damian Nowak --- app/test/test_cryptodev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index fa2b5df..ac63bc6 100644 --- a/app

[dpdk-dev] [PATCH v2 07/10] test/crypto: add sgl test cases for ip and oop

2019-06-07 Thread Damian Nowak
This patch adds test cases for snow3g in-place and out-of-place auth-cipher operations with scatter-gather lists as input and output mbufs. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. It also adds cases where digest i

[dpdk-dev] [PATCH v2 03/10] crypto/qat: handle buffer size for digest-encrypted auth-cipher

2019-06-07 Thread Damian Nowak
This patch adds condition to be met when using wireless algorithms (SNOW3G, KASUMI, ZUC) in out-of-place auth-cipher operations. It checks if the digest location overlaps with the data to be encrypted or decrypted and if so, treats as a digest-encrypted case. It also checks if the digest is being e

[dpdk-dev] [PATCH v2 05/10] test/crypto: add snow3g test cases for auth-cipher

2019-06-07 Thread Damian Nowak
This patch adds test cases for snow3g in-place and out-of-place auth-cipher operations. Test cases include buffer appended digest generation with encryption and buffer decryption with appended digest verification. It also adds cases where digest is encrypted only partially. Signed-off-by: Damian N

[dpdk-dev] [PATCH v2 04/10] crypto/qat: add digest encrypted feature flag

2019-06-07 Thread Damian Nowak
This patch adds feature flag for QuickAssist Technology to emphasize it's support for digest appended auth-cipher operations. Signed-off-by: Damian Nowak --- drivers/crypto/qat/qat_sym_pmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/

[dpdk-dev] [PATCH v2 01/10] cryptodev: document usage of digest-appended operations

2019-06-07 Thread Damian Nowak
This patch explains what are the conditions and how to use digest appended for auth-cipher operations. Signed-off-by: Damian Nowak --- lib/librte_cryptodev/rte_crypto_sym.h | 43 +++ 1 file changed, 43 insertions(+) diff --git a/lib/librte_cryptodev/rte_crypto_sy

[dpdk-dev] [PATCH v2 00/10] cryptodev: support encrypted-digest use-cases

2019-06-07 Thread Damian Nowak
This patchset adds support for digest appended and encrypted auth-cipher operations on QAT, API clarification and extension with dedicated feature flag and a set of tests for KASUMI and SNOW3G in-place, out-of-place and SGL using operations. --- v2: - extend support for partial digest encryption -

[dpdk-dev] [PATCH v2 02/10] cryptodev: add digest encrypted feature flag

2019-06-07 Thread Damian Nowak
Some PMDs can only support digest being encrypted separately in auth-cipher operations. Thus it is required to add feature flag in PMD to reflect if it does support digest-appended both: digest generation with encryption and decryption with digest verification. Signed-off-by: Damian Nowak --- li

Re: [dpdk-dev] [PATCH 04/39] examples/l2fwd-event: move global vars to common header

2019-06-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library

2019-06-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anoob Joseph > Sent: Monday, June 3, 2019 11:02 PM > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bar

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 10:26 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 04:23:26PM +, Jerin

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-07 Thread Bruce Richardson
On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote: > On Fri, 7 Jun 2019 00:03:54 +0530 > Vipin Varghese wrote: > > > Add callback event handler for enqueue dequeue operation on ring. > > The pre-enqueue and post-dequeue operation on ring is selected to > > invoke user callback ha

Re: [dpdk-dev] Incorrect install_dir for Linux kernel modules

2019-06-07 Thread Bruce Richardson
On Thu, Jun 06, 2019 at 09:33:09PM +0300, Igor Ryzhov wrote: > Hi everyone, > > I faced an issue today with install directory for rte_kni and igb_uio. > Modules are installed to '/usr/src/...' instead of '/lib/modules/...'. > > Right now install_dir for both modules is set to: > > install_dir: k

Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

2019-06-07 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 9:50 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; John > McNamara ; Marko Kovacevic > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > > Cc: Harman Kalra > Subject: Re: [dpdk-dev] [PATCH v1 25/58] net/

Re: [dpdk-dev] [PATCH 0/2] power: add fifo per core for JSON interface

2019-06-07 Thread Hajkowski, MarcinX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lukasz Krakowiak > Sent: Monday, April 8, 2019 12:45 PM > To: Hunt, David > Cc: dev@dpdk.org; Krakowiak, LukaszX > Subject: [dpdk-dev] [PATCH 0/2] power: add fifo per core for JSON interface > > This patch impl

Re: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature

2019-06-07 Thread Hajkowski, MarcinX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lukasz Krakowiak > Sent: Wednesday, April 3, 2019 12:33 PM > To: Hunt, David > Cc: Burakov, Anatoly ; dev@dpdk.org; > Krakowiak, LukaszX > Subject: [dpdk-dev] [PATCH v2 3/3] test: add UT for power turbo feature

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-07 Thread David Marchand
On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > return 0 or negative error code. Bus code returns positive values > if device wasn't recognized by any driver, so the result of > 'bus->plug/unplug()' must be converted. 'local

Re: [dpdk-dev] [PATCH v3 1/2] power: add fifo per core for JSON interface

2019-06-07 Thread Hajkowski, MarcinX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lukasz Gosiewski > Sent: Wednesday, April 24, 2019 10:22 AM > To: Hunt, David > Cc: dev@dpdk.org; Krakowiak, LukaszX ; > Gosiewski, LukaszX > Subject: [dpdk-dev] [PATCH v3 1/2] power: add fifo per core for JSON