Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec

2019-06-09 Thread Zhao1, Wei
Thank you, update in v3. > -Original Message- > From: Iremonger, Bernard > Sent: Friday, June 7, 2019 9:59 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Yigit, Ferruh > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for > ma

[dpdk-dev] [PATCH v3] app/testpmd: remove port stop check for macsec

2019-06-09 Thread Wei Zhao
There is no need to do such a check when set macsec for ixgbe, and reconfig_device_queueand is also useless. If we do not delete this unnessary code, users have to stop port before enable or disable macsec, then restart this port after make configuration. All these process are useless. As this cmdl

[dpdk-dev] [PATCH v2 2/2] examples/l2fwd-crypto: add callback handlers

2019-06-09 Thread Vipin Varghese
Register user callback handlers for pre-enqueue and pst-dequeue for crypto device instance 0 with port 0. Signed-off-by: Vipin Varghese --- examples/l2fwd-crypto/main.c | 38 1 file changed, 38 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b/exampl

[dpdk-dev] [PATCH v2 1/2] lib/crypto: add callback handlers for crypto

2019-06-09 Thread Vipin Varghese
Add callback handlers for enqueue-dequeue operation on crypto device. The pre-enqueue and post-dequeue are selected on invoke user registered callback functions. Use cases: - allow user to investigate the contents pre-enqueue. - allow user to investigate the contents post-dequeue. - modify pre-

Re: [dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

2019-06-09 Thread Wei, Dan
Thank you for your comments. > > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c > > b/drivers/net/ipn3ke/ipn3ke_ethdev.c > > index 9079b57..84eb0e9 100644 > > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c > > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c > > @@ -223,15 +223,25 @@ > >

Re: [dpdk-dev] [PATCH] net/i40e: i40e rework for ipn3ke

2019-06-09 Thread Pei, Andy
Hi, Rosen Your ACK is needed if there is no other issue except the CC list -Original Message- From: Xu, Rosen Sent: Friday, May 24, 2019 9:05 AM To: Pei, Andy ; dev@dpdk.org Cc: Zhang, Roy Fan ; Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei ; Yigit, Ferruh Subject: RE: [PATCH] net/i40e:

[dpdk-dev] [PATCH v3] doc/testpmd: update compile steps for bpf examples

2019-06-09 Thread Vipin Varghese
Add note in the missing arguments for compiling BPF examples. Signed-off-by: Vipin Varghese Acked-by: John McNamara --- V3: - update the dependency for DPDK and others - Thomas Monjalon V2: - ACK for documentation - John McNamara - move to compile section - Thomas Monjalon --- doc/guides/

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-09 Thread Honnappa Nagarahalli
> > > > -- > > > Subject: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 > > > compiler > > > > > > From: Jerin Jacob > > > > > > Some compilers reporting the following error, though the existing > > > code doesn't have a

[dpdk-dev] DPDK Windows Community call - 28 May 2019

2019-06-09 Thread Ranjit Menon
Attendees: (present/accepted) - Cathal Pallavi Ranjit Thomas tho...@monjalon.net Tal Shnaiderman Raslan rasl...@mellanox.com; Harini harini.ramakrish...@microsoft.com; Omar Cardona ; Rani Sharoni ; Absent/apologies: - Adham Masarwah Eilon Greenstein Yohad Tor Bruce

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-09 Thread Varghese, Vipin
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, June 7, 2019 4:15 PM > To: Stephen Hemminger ; Varghese, Vipin > > Cc: olivier.m...@6wind.com; Pattan, Reshma ; > Wiles, Keith ; dev@dpdk.org; Padubidri, Sanjay A > > Subject: RE: [dpdk-dev] [PATCH v1 1/2] lib/ring: add e

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-09 Thread Varghese, Vipin
> -Original Message- > From: Richardson, Bruce > Sent: Friday, June 7, 2019 3:01 PM > To: Stephen Hemminger > Cc: Varghese, Vipin ; olivier.m...@6wind.com; > Pattan, Reshma ; Wiles, Keith > ; dev@dpdk.org; Padubidri, Sanjay A > > Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueu

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-09 Thread Varghese, Vipin
Hi Honnappa, snipped > > > > Add callback event handler for enqueue dequeue operation on ring. > > The pre-enqueue and post-dequeue operation on ring is selected to > > invoke user callback handler. > Can you provide a use case for this to better understand the need? Use cases: - allow user to in

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-09 Thread Varghese, Vipin
Hi Stephen, snipped > NAK > What is the use case for this? Use cases: - allow user to investigate the contents pre-enqueue. - allow user to investigate the contents post-dequeue. - modify pre-enqueue and post-dequeue stage content. - investigate PMD meta data. Rings are one of the most used

[dpdk-dev] [PATCH v1 1/2] lib/crypto: add callback handlers for crypto

2019-06-09 Thread Vipin Varghese
Add callback handlers for enqueue-dequeue operation on crypto device. The pre-enqueue and post-dequeue are selected on invoke user registered callback functions. Use cases: - allow user to investigate the contents pre-enqueue. - allow user to investigate the contents post-dequeue. - modify pre-

[dpdk-dev] [PATCH v1 2/2] examples/l2fwd-crypto: add callback handlers

2019-06-09 Thread Vipin Varghese
Register user callback handlers for pre-enqueue and pst-dequeue for crypto device instance 0 with port 0. Signed-off-by: Vipin Varghese --- examples/l2fwd-crypto/main.c | 36 1 file changed, 36 insertions(+) diff --git a/examples/l2fwd-crypto/main.c b/exampl

Re: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-09 Thread Slava Ovsiienko
Hi, Bernard Thanks for the comment. > > -#ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES > > - uint64_t start_tsc; > > - uint64_t end_tsc; > > - uint64_t core_cycles; > > +#if defined(RTE_TEST_PMD_RECORD_CORE_TX_CYCLES) > > + uint64_t start_tx_tsc; > > Should the RTE_TEST_PMD_RECORD_CORE_CYCLES

Re: [dpdk-dev] [PATCH 1/2] eventdev: replace mbufs with events in Rx callback

2019-06-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nikhil Rao > Sent: Thursday, May 30, 2019 6:50 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Nikhil Rao > Subject: [EXT] [PATCH 1/2] eventdev: replace mbufs with events in Rx > callback > > Replace the mbuf pointer array in the event eth Rx adapt

Re: [dpdk-dev] [PATCH] eventdev: remove event copy in Rx adapter

2019-06-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nikhil Rao > Sent: Wednesday, May 22, 2019 3:23 AM > To: Jerin Jacob Kollanukkaran ; > mattias.ronnb...@ericsson.com > Cc: dev@dpdk.org; Nikhil Rao > Subject: [PATCH] eventdev: remove event copy in Rx adapter > > Remove copy from temporary event array on th

Re: [dpdk-dev] [PATCH] eventdev: optimize Rx adapter event enqueue

2019-06-09 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nikhil Rao > Sent: Tuesday, May 28, 2019 6:35 AM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Nikhil Rao > Subject: [PATCH] eventdev: optimize Rx adapter event enqueue > > Setup event when the Rx queue is added to the adapter in place of > generating

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-09 Thread Wang, Haiyue
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Sunday, June 9, 2019 22:24 > To: Yongseok Koh ; shah...@mellanox.com; > tho...@monjalon.net; Yigit, Ferruh > ; adrien.mazarg...@6wind.com; olivier.m...@6wind.com > Cc: dev@dpdk.org > Subjec

Re: [dpdk-dev] [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno

2019-06-09 Thread Wang, Xiao W
Hi, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Wednesday, June 5, 2019 4:16 PM > To: Zhang, Qi Z ; Wang, Xiao W > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH 05/11] net/fm10k: fix Tx prepare to set positive rte_errno > > Fixes: 9b13

Re: [dpdk-dev] [PATCH v2 5/6] usertools/dpdk-devbind.py: add support for ntb

2019-06-09 Thread Li, Xiaoyun
Well. Seems a good idea. I don't think there will be too many communication devices or dma devices anyway. So use misc_devices? I can align with you. > -Original Message- > From: Richardson, Bruce > Sent: Thursday, June 6, 2019 16:23 > To: Li, Xiaoyun > Cc: Wu, Jingjing ; Wiles, Keith >

Re: [dpdk-dev] [PATCH 1/2] lib/librte_ethdev: add in default value of rte_eth_dev_info

2019-06-09 Thread Andrew Rybchenko
On 5/27/19 11:35 AM, Sunil Kumar Kori wrote: rte_eth_dev_info structure exposes, nb_seg_max & nb_mtu_seg_max to provide maximum number of supported segments for a given platform. Defining UINT16_MAX as default value of above mentioned variables to expose support of infinite/maximum segments. Ba

Re: [dpdk-dev] [RFC 1/3] ethdev: extend flow metadata

2019-06-09 Thread Andrew Rybchenko
On 6/4/19 12:32 AM, Yongseok Koh wrote: Currently, metadata can be set on egress path via mbuf tx_meatadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_RX_META matches metadata. This patch extends the usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx me

Re: [dpdk-dev] [PATCH v2] rcu/test: make gloabl variable per core

2019-06-09 Thread Thomas Monjalon
07/06/2019 15:30, Honnappa Nagarahalli: > > > > Bad start, there is a typo in the title :) > I guess, my apologies do not have any meaning anymore > > > > > 16/05/2019 03:14, Honnappa Nagarahalli: > > > Each hash entry has a pointer to one uint32 memory location. > > > However, all the readers i