[dpdk-dev] [PATCH v2] doc: support new i40e device

2019-06-17 Thread Beilei Xing
Add support for new i40e device. Signed-off-by: Beilei Xing --- v2 change: - Change indentation. doc/guides/rel_notes/release_19_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index b9510f9..8da66f

[dpdk-dev] [PATCH] doc: support new i40e device

2019-06-17 Thread Beilei Xing
Add support for new i40e device. Signed-off-by: Beilei Xing --- doc/guides/rel_notes/release_19_08.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index b9510f9..549b600 100644 --- a/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v1 1/5] vhost: fix add a missing include

2019-06-17 Thread Noa Ezra
Hi, Does anyone else want to review this patch? Thanks, Noa. -Original Message- From: Matan Azrad Sent: Sunday, May 26, 2019 1:23 PM To: Noa Ezra ; dev@dpdk.org; maxime.coque...@redhat.com Cc: Noa Ezra ; sta...@dpdk.org Subject: RE: [PATCH v1 1/5] vhost: fix add a missing include Fro

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

2019-06-17 Thread Matan Azrad
Hi Jerin From: Jerin Jacob > Sent: Thursday, June 6, 2019 3:16 PM > To: Matan Azrad ; Adrien Mazarguil > ; dev@dpdk.org > Subject: RE: [PATCH] [RFC] ethdev: support flow aging > > > -Original Message- > > From: Matan Azrad > > Sent: Thursday, June 6, 2019 4:22 PM > > To: Jerin Jacob Koll

Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Tiwei Bie
On Mon, Jun 17, 2019 at 12:31:38PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > VLAN tag insertion should be in Tx prepare, not in Tx burst functions. > One of Tx prepare goals is to be able to do preparations in advance > (possibliy on different CPU core) and then transmit it fast.

Re: [dpdk-dev] [PATCH v2] kni: fix possible kernel crash with va2pa

2019-06-17 Thread Dey, Souvik
Hi Yigit, I was facing the kernel crash issue, at skb_over_put(), using dpdk using 18.11 on 4.19.28 kernel. On checking I did find this patch and this patch is solving the issue also. But then I saw you comment in the patch and that’s looks scary to have the patch. Is there any im

[dpdk-dev] [PATCH v2] net/ice: support Tx checksum offload for tunneling packets

2019-06-17 Thread Beilei Xing
Enable Tx checksum offload for tunneling packets by configuring tunneling parameters in Tx descriptors, including outer L3/L4 checksum offload. Signed-off-by: Beilei Xing --- v2 changes: - Uuter udp checksum in tunneling parameter. drivers/net/ice/ice_ethdev.c | 3 +- drivers/net/ice/ice_rxtx

Re: [dpdk-dev] [PATCH v2 1/3] net/ice: enable switch filter

2019-06-17 Thread Ye Xiaolong
On 06/12, Qiming Yang wrote: >From: wei zhao > >The patch enables the backend of rte_flow. It transfers >rte_flow_xxx to device specific data structure and >configures packet process engine's binary classifier >(switch) properly. > >Signed-off-by: Wei Zhao >--- > drivers/net/ice/Makefile

Re: [dpdk-dev] [PATCH] vfio: fix expanding DMA area in ppc64le

2019-06-17 Thread Mo, YufengX
Sorry, missed send this mail. Ignore it pls. > -Original Message- > From: Mo, YufengX > Sent: Tuesday, June 18, 2019 10:38 AM > To: Mo, YufengX ; dev@dpdk.org > Cc: d...@ibm.com; prad...@us.ibm.com; Takeshi Yoshimura > Subject: [dpdk-dev] [PATCH] vfio: fix expanding DMA area in ppc64le >

[dpdk-dev] [PATCH v6 5/6] usertools/dpdk-devbind.py: add support for ntb

2019-06-17 Thread Xiaoyun Li
In order to allow binding/unbinding of devices for use by the ntb_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. And only support skx platform right now. Signed-off-by: Xiaoyun Li --- usertools/dpdk-devbind.py | 9

[dpdk-dev] [PATCH v6 3/6] raw/ntb: add handshake process

2019-06-17 Thread Xiaoyun Li
Add handshake process using doorbell so that two hosts can communicate to start and stop. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/ntb_rawdev.c | 336 +++- 1 file changed, 335 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c b/dr

[dpdk-dev] [PATCH v6 4/6] examples/ntb: enable an example for ntb

2019-06-17 Thread Xiaoyun Li
Enable an example for rawdev ntb. Support interactive mode to send file on one host and receive file from another host. The command line would be 'send [filepath]' and 'receive [filepath]'. But since the FIFO is not enabled right now, use rte_memcpy as the enqueue and dequeue functions and only su

[dpdk-dev] [PATCH v6 6/6] doc: update docs for ntb driver

2019-06-17 Thread Xiaoyun Li
Update related documents for ntb pmd and example. Signed-off-by: Xiaoyun Li --- MAINTAINERS| 8 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/ntb_rawdev.rst | 41 ++ doc/guides/rel_notes/release_19_08.rst | 15 ++

[dpdk-dev] [PATCH v6 0/6] rawdev driver for ntb

2019-06-17 Thread Xiaoyun Li
This patch set adds support for Intel NTB device with Skylake platform. It is a raw device for allowing two hosts to communicate with each other and access the peer memory. This patch set also provides a simple example to transmit a file between two hosts. But since there is no FIFO here, only sup

[dpdk-dev] [PATCH v6 2/6] raw/ntb: add intel ntb support

2019-06-17 Thread Xiaoyun Li
Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 368 ++

[dpdk-dev] [PATCH v6 1/6] raw/ntb: introduce ntb rawdev driver

2019-06-17 Thread Xiaoyun Li
Introduce rawdev driver support for NTB (Non-transparent Bridge) which can help to connect two separate hosts with each other. Signed-off-by: Xiaoyun Li --- config/common_base| 5 + drivers/raw/Makefile | 1 + drivers/raw/meson.build

[dpdk-dev] [PATCH v2] net/af_xdp: support need wakeup feature

2019-06-17 Thread Xiaolong Ye
This patch enables need_wakeup flag for Tx and fill rings, when this flag is set by the driver, it means that the userspace application has to explicitly wake up the kernel Rx or kernel Tx processing by issuing a syscall. Poll() can wake up both and sendto() or its alternatives will wake up Tx proc

Re: [dpdk-dev] [PATCH v2 1/3] net/ice: enable switch filter

2019-06-17 Thread Zhao1, Wei
> -Original Message- > From: Wang, Xiao W > Sent: Monday, June 17, 2019 4:28 PM > To: Zhao1, Wei ; Yang, Qiming > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/ice: enable switch filter > > Hi Wei, > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, Jun

Re: [dpdk-dev] [PATCH v2 1/3] net/ice: enable switch filter

2019-06-17 Thread Xing, Beilei
Hi Wei, > -Original Message- > From: Zhao1, Wei > Sent: Monday, June 17, 2019 4:52 PM > To: Xing, Beilei ; Yang, Qiming > ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/3] net/ice: enable switch filter > > Hi , Beilei > > > > -Original Message- > > From: Xing, Beilei > > S

Re: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver

2019-06-17 Thread Li, Xiaoyun
Yes. Thanks for catching that. > -Original Message- > From: Wang, Xiao W > Sent: Monday, June 17, 2019 20:49 > To: Li, Xiaoyun ; Wu, Jingjing ; > Wiles, Keith ; Liang, Cunming > ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: RE: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce

Re: [dpdk-dev] [PATCH v3 25/27] mempool/octeontx2: add optimized dequeue operation for arm64

2019-06-17 Thread Aaron Conole
writes: > From: Pavan Nikhilesh > > This patch adds an optimized arm64 instruction based routine to leverage > CPU pipeline characteristics of octeontx2. The theme is to fill the > pipeline with CASP operations as much HW can do so that HW can do alloc() > HW ops in full throttle. > > Cc: Olivie

Re: [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal

2019-06-17 Thread Neil Horman
On Mon, Jun 17, 2019 at 04:09:26PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 13, 2019 7:54 PM > > To: dev@dpdk.org > > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > > ; Bruce Richardson ; > > Thomas Monjalon > > Subject:

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of BBDEV

2019-06-17 Thread Nicolas Chautru
As discussed with Akhil and within Intel teams, there has been a reorg within Intel teams which causes BBDEV maitainership to switch hands. Nicolas Chautru (1): maintainers: claim maintainership of BBDEV MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 1.8.3.1

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of BBDEV

2019-06-17 Thread Nicolas Chautru
Reorg within Intel teams causing transfer of maintainership Signed-off-by: Nicolas Chautru --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 15d0829..d0e1b25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -355,7 +355,7 @@ M: Cristi

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of BBDEV

2019-06-17 Thread Nic Chautru
From: Nicolas Chautru Reorg within Intel teams causing transfer of maintainership Signed-off-by: Nic Chautru --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 15d0829..d0e1b25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -355,7

Re: [dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum

2019-06-17 Thread Kovacevic, Marko
> Subject: [dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum > > This patch fixes the inferred misuse of enum of crypto algorithms. > > Coverity issue: 325879 > Fixes: e80a98708166 ("vhost/crypto: add session message handler") > Cc: sta...@dpdk.org > > Signed-off-by: Fan Zhang > ---

Re: [dpdk-dev] [PATCH v2 09/10] octeonx: mark internal functions with __rte_internal

2019-06-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 13, 2019 7:54 PM > To: dev@dpdk.org > Cc: Neil Horman ; Jerin Jacob Kollanukkaran > ; Bruce Richardson ; > Thomas Monjalon > Subject: [EXT] [PATCH v2 09/10] octeonx: mark internal functions with > __rte_internal > > + > +DPDK

[dpdk-dev] [PATCH 2/2] doc/security: clarify experimental API status

2019-06-17 Thread Ferruh Yigit
Explicitly note that experimental APIs also part of security process. Signed-off-by: Ferruh Yigit --- doc/guides/contributing/vulnerability.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/vulnerability.rst b/doc/guides/contributing/vulnerability.r

[dpdk-dev] [PATCH 1/2] doc/security: clarify pre-release end of the embargo date

2019-06-17 Thread Ferruh Yigit
Clarify that a fixed date will be used for end of embargo (public disclosure) date while communicating with downstream stakeholders. Initial document got a review that it gives an impression that communicated embargo date can be a range like 'less than a week' which is not the case. The range appl

[dpdk-dev] [PATCH v3 25/27] mempool/octeontx2: add optimized dequeue operation for arm64

2019-06-17 Thread jerinj
From: Pavan Nikhilesh This patch adds an optimized arm64 instruction based routine to leverage CPU pipeline characteristics of octeontx2. The theme is to fill the pipeline with CASP operations as much HW can do so that HW can do alloc() HW ops in full throttle. Cc: Olivier Matz Cc: Aaron Conole

[dpdk-dev] [PATCH v3 26/27] mempool/octeontx2: add devargs for max pool selection

2019-06-17 Thread jerinj
From: Jerin Jacob The maximum number of mempools per application needs to be configured on HW during mempool driver initialization. HW can support up to 1M mempools, Since each mempool costs set of HW resources, the max_pools devargs parameter is being introduced to configure the number of mempoo

[dpdk-dev] [PATCH v3 27/27] doc: add Marvell OCTEON TX2 mempool documentation

2019-06-17 Thread jerinj
From: Jerin Jacob Add Marvell OCTEON TX2 mempool documentation. This patch also updates the MAINTAINERS file and updates shared library versions in release_19_08.rst. Cc: John McNamara Cc: Thomas Monjalon Signed-off-by: Jerin Jacob Signed-off-by: Vivek Sharma Signed-off-by: Vamsi Attunuru

[dpdk-dev] [PATCH v3 24/27] mempool/octeontx2: add fast path mempool ops

2019-06-17 Thread jerinj
From: Jerin Jacob Add enqueue and dequeue mempool fastpath operations. Cc: Olivier Matz Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 57 1 file changed, 57 insertions(+) diff --git a/drivers/mempool/octeon

[dpdk-dev] [PATCH v3 23/27] mempool/octeontx2: add remaining slow path ops

2019-06-17 Thread jerinj
From: Jerin Jacob Add remaining get_count(), calc_mem_size() and populate() slow path mempool operations. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 62 1 file changed, 62 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH v3 22/27] mempool/octeontx2: add mempool free op

2019-06-17 Thread jerinj
From: Jerin Jacob The DPDK mempool free operation frees HW AURA and POOL reserved in alloc operation. In addition to that it free all the memory resources allocated in mempool alloc operations. Cc: Olivier Matz Signed-off-by: Jerin Jacob --- drivers/mempool/octeontx2/otx2_mempool_ops.c | 104

[dpdk-dev] [PATCH v3 19/27] mempool/octeontx2: add NPA IRQ handler

2019-06-17 Thread jerinj
From: Jerin Jacob Register and implement NPA IRQ handler for RAS and all type of error interrupts to get the fatal errors from HW. Signed-off-by: Jerin Jacob Signed-off-by: Harman Kalra --- drivers/mempool/octeontx2/Makefile | 3 +- drivers/mempool/octeontx2/meson.build|

[dpdk-dev] [PATCH v3 21/27] mempool/octeontx2: add mempool alloc op

2019-06-17 Thread jerinj
From: Jerin Jacob The DPDK mempool allocation reserves a single HW AURA and POOL in 1:1 map mode. Upon reservation, SW programs the slow path operations such as allocate stack memory for DMA and bunch HW configurations to respective HW blocks. Cc: Olivier Matz Signed-off-by: Jerin Jacob ---

[dpdk-dev] [PATCH v3 20/27] mempool/octeontx2: add context dump support

2019-06-17 Thread jerinj
From: Jerin Jacob Add a helper function to dump aura and pool context for NPA debugging. Signed-off-by: Jerin Jacob Signed-off-by: Vivek Sharma --- drivers/mempool/octeontx2/Makefile| 3 +- drivers/mempool/octeontx2/meson.build | 1 + drivers/mempool/octeontx2/otx2_mem

[dpdk-dev] [PATCH v3 18/27] mempool/octeontx2: add NPA HW operations

2019-06-17 Thread jerinj
From: Jerin Jacob Implement the low-level NPA HW operations such as alloc, free memory, etc. Signed-off-by: Jerin Jacob Signed-off-by: Kiran Kumar K --- drivers/mempool/octeontx2/otx2_mempool.h | 146 +++ 1 file changed, 146 insertions(+) diff --git a/drivers/mempool/octe

[dpdk-dev] [PATCH v3 17/27] drivers: add init and fini on octeontx2 NPA object

2019-06-17 Thread jerinj
From: Jerin Jacob NPA object needs to initialize memory for queue interrupts context, pool resource management, etc. This patch adds support for initializing and finalizing the NPA object. This patch also updates the otx2_npa_lf definition to meet the init/fini requirements. Signed-off-by: Jeri

[dpdk-dev] [PATCH v3 16/27] mempool/octeontx2: add build infra and device probe

2019-06-17 Thread jerinj
From: Jerin Jacob Add the make and meson based build infrastructure along with the mempool(NPA) device probe. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- config/common_base| 5 ++ drivers/common/Makefile | 3 + drivers/memp

[dpdk-dev] [PATCH v3 12/27] common/octeontx2: add VF mailbox IRQ and msg handler

2019-06-17 Thread jerinj
From: Jerin Jacob This patch adds support for PF <-> VF mailbox interrupt mailbox message interrupt handling. Signed-off-by: Jerin Jacob --- drivers/common/octeontx2/otx2_dev.c | 78 - 1 file changed, 76 insertions(+), 2 deletions(-) diff --git a/drivers/common/oct

[dpdk-dev] [PATCH v3 14/27] common/octeontx2: add FLR IRQ handler

2019-06-17 Thread jerinj
From: Nithin Dabilpuram Upon receiving FLR request from VF, It is PF responsibly forward to AF and enable FLR for VFs. This patch adds support for VF FLR support in PF. This patch also add otx2_dev_active_vfs() API to find the number of active VF for given PF. Signed-off-by: Nithin Dabilpuram

[dpdk-dev] [PATCH v3 13/27] common/octeontx2: add uplink message support

2019-06-17 Thread jerinj
From: Nithin Dabilpuram The events like PHY link status change by AF or PHY configuration change by PF would call for the uplink message. The AF initiated uplink would land it in PF and PF would further forward to VF(if it is intended for that specific VF) The PF initiated uplink would be distri

[dpdk-dev] [PATCH v3 11/27] common/octeontx2: add PF to VF mailbox IRQ and msg handlers

2019-06-17 Thread jerinj
From: Nithin Dabilpuram PF has additional responsibility being server for VF messages and forward to AF and once AF process it then forward the response back to VF. otx2_vf_pf_mbox_irq() will process the VF mailbox request and af_pf_wait_msg() will until getting a response back from AF. Signed-o

[dpdk-dev] [PATCH v3 10/27] common/octeontx2: add AF to PF mailbox IRQ and msg handlers

2019-06-17 Thread jerinj
From: Nithin Dabilpuram This patch adds support for AF to PF mailbox interrupt and message handling. PF writes the message on mapped mailbox region followed by writing the mailbox doorbell register. Upon receiving, the mailbox request in AF(In Linux kernel), It processes the messages and update t

[dpdk-dev] [PATCH v3 07/27] common/octeontx2: introduce common device class

2019-06-17 Thread jerinj
From: Jerin Jacob Introduce otx2_dev class to hold octeontx2 PCIe device specific information and operations. All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2, inherits this base object to avail the common functionalities such as mailbox creation, interrupt registration, et

[dpdk-dev] [PATCH v3 09/27] common/octeontx2: handle intra device operations

2019-06-17 Thread jerinj
From: Jerin Jacob The mempool device(NPA) may be provisioned as a standalone device or it can be part of ethdev/eventdev device. In order to address mempool as standalone or integrated with ethdev/eventdev device, An intra device structure being introduced. When the _first_ ethdev/eventdev PCIe

[dpdk-dev] [PATCH v3 08/27] common/octeontx2: introduce irq handling functions

2019-06-17 Thread jerinj
From: Jerin Jacob All PCIe drivers(ethdev, mempool, cryptodev and eventdev) in octeontx2, needs to handle interrupt for mailbox and error handling. Create a helper function over rte interrupt API to register, unregister, disable interrupts. Signed-off-by: Jerin Jacob Signed-off-by: Vamsi Attunu

[dpdk-dev] [PATCH v3 05/27] common/octeontx2: add runtime log infra

2019-06-17 Thread jerinj
From: Jerin Jacob Various consumers of this common code need runtime logging infrastructure. This patch adds the same. Signed-off-by: Jerin Jacob --- drivers/common/octeontx2/Makefile | 1 + drivers/common/octeontx2/meson.build | 1 + drivers/common/octeontx2/otx2_common

[dpdk-dev] [PATCH v3 03/27] common/octeontx2: add mbox request and response definition

2019-06-17 Thread jerinj
From: Jerin Jacob The admin function driver sits in Linux kernel as mailbox server. The DPDK AF mailbox client, send the message to mailbox server to complete the administrative task such as get mac address. This patch adds mailbox request and response definition of existing mailbox defined betw

[dpdk-dev] [PATCH v3 06/27] common/octeontx2: add mailbox send and receive support

2019-06-17 Thread jerinj
From: Jerin Jacob Each RVU device has a dedicated 64KB mailbox region shared with its peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and an RVU PF has a separate region shared with each of it's VF. This patch add use 64KB memory and implemented mailbox s

[dpdk-dev] [PATCH v3 01/27] common/octeontx2: add build infrastructure and HW definition

2019-06-17 Thread jerinj
From: Jerin Jacob Add the make and meson based build infrastructure along with HW definition header file. This patch adds skeleton otx2_mbox.c file to make sure all header files are intact, subsequent patches add content to otx2_mbox.c This patch also updates CONFIG_RTE_MAX_VFIO_GROUPS value to

[dpdk-dev] [PATCH v3 04/27] common/octeontx2: add mailbox base support infra

2019-06-17 Thread jerinj
From: Jerin Jacob This patch adds mailbox init and fini support. Each RVU device has a dedicated 64KB mailbox region shared with its peer for communication. RVU AF has a separate mailbox region shared with each of RVU PFs and an RVU PF has a separate region shared with each of it's VF. Signed-of

[dpdk-dev] [PATCH v3 02/27] common/octeontx2: add IO handling APIs

2019-06-17 Thread jerinj
From: Jerin Jacob Various octeontx2 drivers use IO handling API, added octeontx2 specific IO handling routines in the common code. Since some of those implementations are based on arm64 instructions added the stub to compile the code on non arm64 ISA. The non arm64 ISA stub is possible due to th

[dpdk-dev] [PATCH v3 00/27] OCTEON TX2 common and mempool driver

2019-06-17 Thread jerinj
From: Jerin Jacob This patch set adds initial driver support for OCTEON TX2 SoC. OCTEON TX2 is an armv8.2 SoC with integrated HW based mempool, ethdev, cryptodev, compressdev, and eventdev devices. This patch set adds common driver and mempool device driver for OCTEON TX2 SoC. There will be thr

Re: [dpdk-dev] [PATCH v1 1/2] lib/lpm: memory orderings to avoid race conditions for v1604

2019-06-17 Thread Medvedkin, Vladimir
Hi Wang, On 17/06/2019 16:27, Ruifeng Wang (Arm Technology China) wrote: Hi Vladimir, From: Medvedkin, Vladimir Sent: Monday, June 10, 2019 23:23 To: Honnappa Nagarahalli ; Ruifeng Wang (Arm Technology China) ; bruce.richard...@intel.com Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; nd

Re: [dpdk-dev] [PATCH v1 1/2] lib/lpm: memory orderings to avoid race conditions for v1604

2019-06-17 Thread Ruifeng Wang (Arm Technology China)
Hi Vladimir, From: Medvedkin, Vladimir Sent: Monday, June 10, 2019 23:23 To: Honnappa Nagarahalli ; Ruifeng Wang (Arm Technology China) ; bruce.richard...@intel.com Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; nd Subject: Re: [PATCH v1 1/2] lib/lpm: memory orderings to avoid race cond

[dpdk-dev] [PATCH 3/3] drivers/net: fix double free on init failure cleanup

2019-06-17 Thread David Marchand
If we don't clear mac_addrs, ethdev will double free it on cleanup. Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/ark/ark_ethdev.c| 6 +++--- drivers/net/axgbe/axgbe_ethdev.c| 1 + drivers/n

[dpdk-dev] [PATCH 2/3] net/bnx2x: fix invalid free on unplug

2019-06-17 Thread David Marchand
mac_addrs points to a field in dev_private. We can't let ethdev free it. Fixes: e16adf08e54d ("ethdev: free all common data when releasing port") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/bnx2x/bnx2x_ethdev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 1/3] net/nfb: avoid memory leak on unplug

2019-06-17 Thread David Marchand
Clearing mac_addrs on remove will prevent ethdev from freeing it. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Signed-off-by: David Marchand --- drivers/net/nfb/nfb_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev

[dpdk-dev] [PATCH 0/3] ethdev mac_addrs cleanups

2019-06-17 Thread David Marchand
A little series of fixes caught by code review. I do not have all those hw and reaching those error branch is not an easy thing to do anyway, so please review carefully. Thanks. -- David Marchand David Marchand (3): net/nfb: avoid memory leak on unplug net/bnx2x: fix invalid free on unplug

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: drop the workaround for virtio-user

2019-06-17 Thread Maxime Coquelin
On 6/5/19 11:43 AM, Tiwei Bie wrote: The RTE_ETH_DEV_CLOSE_REMOVE support has been enabled in virtio-user, private resources for the port will be freed by rte_eth_dev_close(), so there is no need to have this workaround anymore. Signed-off-by: Tiwei Bie --- app/test-pmd/testpmd.c | 13 -

Re: [dpdk-dev] [PATCH 4/5] net/virtio: release port upon close

2019-06-17 Thread Maxime Coquelin
On 6/5/19 11:43 AM, Tiwei Bie wrote: Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources for the port can be freed by rte_eth_dev_close(). Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c| 42 --- .../net/virtio/virtio_user/virtio

[dpdk-dev] [PATCH v2] aesni_mb: fix out-of-bounds access

2019-06-17 Thread Fan Zhang
This patch fixes the out-of-bounds coverity issue by adding missed algorithms to the array. Coverity issue: 337683 Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros") Signed-off-by: Fan Zhang --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 17 -

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread David Marchand
On Mon, Jun 17, 2019 at 1:57 PM Bruce Richardson wrote: > On Mon, Jun 17, 2019 at 01:41:21PM +0200, David Marchand wrote: > >On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson > ><[1]bruce.richard...@intel.com> wrote: > > > > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wro

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

2019-06-17 Thread Mattias Rönnblom
On 2019-06-14 11:18, Anoob Joseph wrote: Hi Mattias, A more extensive description of the purpose of the eventmode helper library would be helpful. Is this supposed to be a generic framework for real-world applications, or only something to simplify DPDK the implementation of DPDK example pro

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration

2019-06-17 Thread Ferruh Yigit
On 6/17/2019 2:51 AM, Zhao1, Wei wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, June 14, 2019 11:42 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo >> ; Kevin Traynor >> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix off

Re: [dpdk-dev] [PATCH v5 1/6] raw/ntb: introduce ntb rawdev driver

2019-06-17 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Friday, June 14, 2019 10:20 AM > To: Wu, Jingjing ; Wiles, Keith > ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [dpdk-dev] [PATCH v5 1/6] raw/ntb: intr

Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD

2019-06-17 Thread Smoczynski, MarcinX
Is my action required to merge patches? e.g. do I need to send rebased patches (however there are no conflicts at the moment)? > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, June 5, 2019 12:16 PM > To: Smoczynski, MarcinX ; Richardson, > Bruce ; tho...@monjalon.net >

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2019 at 01:41:21PM +0200, David Marchand wrote: >On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > >On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson >

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread David Marchand
On Mon, Jun 17, 2019 at 1:18 PM Bruce Richardson wrote: > On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: > >On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson > ><[1]bruce.richard...@intel.com> wrote: > > > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wr

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Andrew Rybchenko
On 6/17/19 11:54 AM, Tiwei Bie wrote: On Sun, Jun 16, 2019 at 11:17:09AM +0100, Andrew Rybchenko wrote: From: Dilshod Urazov VLAN tag insertion should be in Tx prepare, not in Tx burst functions. Please add some details in the commit log. Done, please, see v4. Also, please, note that the f

[dpdk-dev] [PATCH v4 1/2] net/virtio: add Tx preparation

2019-06-17 Thread Andrew Rybchenko
From: Dilshod Urazov Virtio requires pseudo-header checksum in TCP/UDP checksum to do offload, but it was lost when Tx prepare is introduced. Also rte_validate_tx_offload() should be used to validate Tx offloads. Also it is incorrect to do virtio_tso_fix_cksum() after prepend to mbuf without tak

[dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Andrew Rybchenko
From: Dilshod Urazov VLAN tag insertion should be in Tx prepare, not in Tx burst functions. One of Tx prepare goals is to be able to do preparations in advance (possibliy on different CPU core) and then transmit it fast. Also Tx prepare can report that a packet does not pass Tx offloads check. E.

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

2019-06-17 Thread Thomas Monjalon
17/06/2019 13:02, Bruce Richardson: > On Mon, Jun 17, 2019 at 12:33:58PM +0300, Thomas Monjalon wrote: > > 13/06/2019 17:11, Thomas Monjalon: > > > A script used with meson was missing in the list of files. > > > > > > Fixes: 4c773788e05a ("build: generate Windows exports file") > > > Cc: bruce.ri

Re: [dpdk-dev] [PATCH] kni: remove PCI related information

2019-06-17 Thread Thomas Monjalon
06/06/2019 17:16, Ferruh Yigit: > On 6/6/2019 2:26 PM, Igor Ryzhov wrote: > > As there is no ethtool support in KNI anymore, > > PCI related information is no longer needed. > > > > Signed-off-by: Igor Ryzhov > > Fixes: ea6b39b5b847 ("kni: remove ethtool support") > > Acked-by: Ferruh Yigit A

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2019 at 12:46:03PM +0200, David Marchand wrote: >On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wrote: > > This is a joint effort to make the unit tests ready f

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix logically dead code

2019-06-17 Thread Kovacevic, Marko
> Subject: [dpdk-dev] [PATCH] examples/fips_validation: fix logically dead > code > > Coverity issue: 336866 > Coverity issue: 336841 > Coverity issue: 336838 > Fixes: 41d561cbdd24 ("examples/fips_validation: add power on self test") > > Signed-off-by: Fan Zhang > --- > examples/fips_validation

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-17 Thread Ilya Maximets
On 06.06.2019 13:02, Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > return 0 or negative error code. Bus code returns positive values > if device wasn't recognized by any driver, so the result of > 'bus->plug/unplug()' must be converted. 'local_dev_probe()'

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread David Marchand
On Mon, Jun 17, 2019 at 12:02 PM Bruce Richardson < bruce.richard...@intel.com> wrote: > On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wrote: > > This is a joint effort to make the unit tests ready for CI. > > The first patches are fixes that I had accumulated. > > Then the second part

Re: [dpdk-dev] [PATCH] aesni_mb: fix out-of-bounds access

2019-06-17 Thread De Lara Guarch, Pablo
Hi Fan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Wednesday, May 15, 2019 4:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan > Subject: [dpdk-dev] [PATCH] aesni_mb: fix out-of-bounds access > > This patch fixes the out

Re: [dpdk-dev] [EXT] Re: [PATCH 32/39] eventdev: add routine to launch eventmode workers

2019-06-17 Thread Anoob Joseph
Hi Erik, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Carrillo, Erik G > Sent: Monday, June 10, 2019 8:02 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Rao, Nikhil ; Gujjar, > Abhinandan S ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: N

Re: [dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf

2019-06-17 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:55 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Pr

Re: [dpdk-dev] [PATCH 19/39] eventdev: add common initialize routine for eventmode devs

2019-06-17 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:54 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Pr

Re: [dpdk-dev] [PATCH 16/39] eventdev: add eventmode CL options framework

2019-06-17 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:49 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Pr

Re: [dpdk-dev] [PATCH v1] net/af_xdp: support need wakeup feature

2019-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2019 at 10:51:52AM +0200, David Marchand wrote: > On Mon, Jun 17, 2019 at 10:45 AM Ye Xiaolong wrote: > > > On 06/17, David Marchand wrote: > > >On Mon, Jun 17, 2019 at 9:42 AM Xiaolong Ye > > wrote: > > > > > >> This patch adds a new devarg to support the need_wakeup flag for Tx

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

2019-06-17 Thread Bruce Richardson
On Mon, Jun 17, 2019 at 12:33:58PM +0300, Thomas Monjalon wrote: > 13/06/2019 17:11, Thomas Monjalon: > > A script used with meson was missing in the list of files. > > > > Fixes: 4c773788e05a ("build: generate Windows exports file") > > Cc: bruce.richard...@intel.com > > > > Signed-off-by: Thoma

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

2019-06-17 Thread Bruce Richardson
On Sat, Jun 15, 2019 at 08:42:15AM +0200, David Marchand wrote: > This is a joint effort to make the unit tests ready for CI. > The first patches are fixes that I had accumulated. > Then the second part of the series focuses on skipping tests when some > requirements are not fulfilled so that we ca

Re: [dpdk-dev] [PATCH] maintainers: add Windows exports script

2019-06-17 Thread Thomas Monjalon
13/06/2019 17:11, Thomas Monjalon: > A script used with meson was missing in the list of files. > > Fixes: 4c773788e05a ("build: generate Windows exports file") > Cc: bruce.richard...@intel.com > > Signed-off-by: Thomas Monjalon Bruce, do you agree with following addition? > --- a/MAINTAINERS

Re: [dpdk-dev] [PATCH v1] maintainers: claim maintainership of BBDEV

2019-06-17 Thread Thomas Monjalon
Hi, Please add a Signed-off-by line. 10/06/2019 20:45, Nicolas Chautru: > Reorg within Intel teams causing transfer of maintainership > ---

Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code

2019-06-17 Thread Kovacevic, Marko
> Subject: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code > > This patch fixes a few same class bugs that causes the logically dead code in > vhost_crypto. > > Coverity issue: 277236 > Coverity issue: 277233 > Coverity issue: 277220 > Coverity issue: 277214 > > Fixes: 3bb595ecd682 ("vh

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value

2019-06-17 Thread Kovacevic, Marko
> Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return > value > > This patch tries to fix the coverity issue of unchecked return value. Since > the > function that causes the problem is unused, it is removed completely. > > Coverity issue: 336816 > Fixes: f5188211c721 ("examp

Re: [dpdk-dev] [PATCH v2 2/3] net/ice: add generic flow API

2019-06-17 Thread Wang, Xiao W
Hi Qiming, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Wednesday, June 12, 2019 3:50 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v2 2/3] net/ice: add generic flow API > > This patch adds ice_flow_create, ice_fl

Re: [dpdk-dev] [PATCH v2 1/6] event/octeontx2: add event eth Rx adapter support

2019-06-17 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, June 3, 2019 4:04 PM > To: Jerin Jacob Kollanukkaran ; Pavan Nikhilesh > Bhagavatula > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 1/6] event/octeontx2: add event eth Rx adapter > support > > From: Pavan Nikhilesh

Re: [dpdk-dev] [PATCH 15/39] eventdev: add routines for logging eventmode helper

2019-06-17 Thread Anoob Joseph
Hi Jerin, Please see inline. Thanks, Anoob > -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:43 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Pr

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value

2019-06-17 Thread Zhang, Roy Fan
Hi Jens, You are right. Sorry the code wasn't cleaned up properly in the first place. Do you want me to send a v2 with new title? Regards, Fan > -Original Message- > From: Jens Freimann [mailto:jfreim...@redhat.com] > Sent: Thursday, May 16, 2019 9:07 AM > To: Zhang, Roy Fan > Cc: dev@d

Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"

2019-06-17 Thread Ye Xiaolong
On 06/17, David Marchand wrote: >This check on Linux environment has been added at a time when we already >had switched to using the boolean RTE_EXEC_ENV_LINUXAPP. >It was then missed when converting to RTE_EXEC_ENV_LINUX. > >Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA") >F

Re: [dpdk-dev] [PATCH v1] net/af_xdp: support need wakeup feature

2019-06-17 Thread Ye Xiaolong
On 06/17, David Marchand wrote: >On Mon, Jun 17, 2019 at 10:45 AM Ye Xiaolong wrote: > >> On 06/17, David Marchand wrote: >> >On Mon, Jun 17, 2019 at 9:42 AM Xiaolong Ye >> wrote: >> > >> >> This patch adds a new devarg to support the need_wakeup flag for Tx and >> >> fill rings, when this flag i

Re: [dpdk-dev] [PATCH v3 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-17 Thread Tiwei Bie
On Sun, Jun 16, 2019 at 11:17:09AM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > VLAN tag insertion should be in Tx prepare, not in Tx burst functions. Please add some details in the commit log. Thanks, Tiwei > > Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") > Cc: sta...@dpd

  1   2   >