This patch adds ice_flow_create, ice_flow_destroy,
ice_flow_flush and ice_flow_validate support,
these are used to handle all the generic filters.
Signed-off-by: Qiming Yang
---
drivers/net/ice/Makefile | 1 +
drivers/net/ice/ice_ethdev.c | 44 +++
drivers/net/ice/ice_ethdev.h
Enabled UDP tunnel port add and delete functions.
Signed-off-by: Qiming Yang
---
drivers/net/ice/ice_ethdev.c | 54
1 file changed, 54 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8ee06d1..949d293 10064
From: wei zhao
The patch enables the backend of rte_flow. It transfers
rte_flow_xxx to device specific data structure and
configures packet process engine's binary classifier
(switch) properly.
Signed-off-by: Wei Zhao
---
drivers/net/ice/Makefile| 1 +
drivers/net/ice/ice_ethdev.
This patch set enables the backend of rte_flow, and the generic
filter related functions in ice driver. Supported flows include
ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch
set depends on shared code update.
---
v2 changes:
- added UDP tunnel port support.
- fixed compile issu
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Monday, June 24, 2019 11:11 PM
> To: tho...@monjalon.net; Phil Yang (Arm Technology China)
>
> Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org;
> hemant.agra...@nxp.com; Gavin Hu (Arm Technology China)
> ; Honnappa Nagarahalli
> ; nd
> -Original Message-
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 24, 2019 11:43 AM
> To: Erik Gabriel Carrillo ;
> jerin.ja...@caviumnetworks.com
> Cc: mattias.ronnb...@ericsson.com; pbhagavat...@caviumnetworks.com;
> honnappa.nagaraha...@arm.com; dev@dpdk.org
> Subject: RE: [dp
From: Jerin Jacob
Claim the maintainership of the sub tree dpdk-next-net-mrvl,
which covers all the Marvell network PMDs.
Cc: Maciej Czekaj
Cc: Shijith Thotton
Cc: Liron Himi
Cc: Zyta Szpak
Cc: Rasesh Mody
Cc: Shahed Shaikh
Cc: Ferruh Yigit
Cc: Thomas Monjalon
Signed-off-by: Jerin Jacob
Adding a new field, ff_disable, to allow applications to control the
features enabled on the crypto device. This would allow for efficient
usage of HW/SW offloads.
Signed-off-by: Anoob Joseph
---
v2:
* Updated test & example applications to incorporate the default setting
for ff_disable field.
Hi Thomas,
A reminder about this patch.
On Wed, May 29, 2019 at 01:46:20PM +0530, Nithin Dabilpuram wrote:
> Hi Thomas,
>
> On Mon, May 20, 2019 at 06:20:53PM +0530, Nithin Dabilpuram wrote:
> > On Fri, May 17, 2019 at 10:59:38AM +0200, Thomas Monjalon wrote:
> > > 17/05/2019 10:55, Nithin Dabil
From: Kiran Kumar K
Patch adds support for kernel module to work in IOVA = VA mode,
the idea is to get physical address from iova address using
iommu_iova_to_phys API and later use phys_to_virt API to
convert the physical address to kernel virtual address.
When compared with IOVA = PA mode, ther
From: Vamsi Attunuru
PCI related information is needed in KNI kernel module,
since it requires iommu domain info for address
translations(using iommu_iova_to_phys() call) when
KNI runs in IOVA = VA mode.
Signed-off-by: Vamsi Attunuru
---
lib/librte_eal/linux/eal/include/rte_kni_common.h | 7 ++
From: Vamsi Attunuru
Current KNI implementation operates in IOVA = PA mode,
Patch adds support for IOVA = VA mode by addressing
the issues with page address translations(IOVA <==> KVA).
In this patch KNI application creates mempool with
"MEMPOOL_F_NO_PAGE_BOUND" flag to ensure all mbuf memory
is
From: Vamsi Attunuru
V6 Changes:
* Added new mempool flag to ensure mbuf memory is not scattered
across page boundaries.
* Added KNI kernel module required PCI device information.
* Modified KNI example application to create mempool with new
mempool flag.
V5 changes:
* Fixed build issue wit
From: Vamsi Attunuru
Patch adds new mempool flag to avoid scattering mbuf memory
across page boundaries. Mempool created with this flag set,
populated with mbufs which are exactly inside the page boundaries.
Signed-off-by: Vamsi Attunuru
---
lib/librte_mempool/rte_mempool.c | 2 +-
Attendees: (present)
-
Cathal
Pallavi
Ranjit
Thomas tho...@monjalon.net
Tal Shnaiderman
Raslan rasl...@mellanox.com;
Harini harini.ramakrish...@microsoft.com;
Absent/apologies:
Adham Masarwah
Eilon Greenstein
Yohad Tor
Bruce
Anan Saif ;
Jeff jeffrey.tip...@micro
The cmdline_parse_ether_addr does not need to be used everywhere
in testpmd. Can use rte_ether_unformat_addr instead.
As an added bonus it eliminates some code for copying.
Signed-off-by: Stephen Hemminger
---
app/test-pmd/cmdline_flow.c | 5 ++---
app/test-pmd/config.c | 10 +++---
a
Using bit operations like or and xor is faster than a loop
on all architectures. Really just explicit unrolling.
Similar cast to uint16 unaligned is already done in
other functions here.
Signed-off-by: Stephen Hemminger
Reviewed-by: Andrew Rybchenko
---
lib/librte_net/rte_ether.h | 17 +++-
The cmdline library used to be the only way to parse a
mac address. Now there is rte_ether_unformat_addr.
Signed-off-by: Stephen Hemminger
---
drivers/net/bonding/Makefile| 2 +-
drivers/net/bonding/meson.build | 2 +-
drivers/net/bonding/rte_eth_bond_args.c | 6 +-
3 fil
Now that there is a version of ether_aton in rte_ether, it can
be used by the cmdline ethernet address parser.
Note: ether_aton_r can not be used in cmdline because
the old code would accept either bytes XX:XX:XX:XX:XX:XX
or words :: and we need to keep compatiablity.
Signed-off-by: S
From: Bruce Richardson
When including the rte_ether.h header in applications with warnings
enabled, a warning was given because of the assumption of 2-byte alignment
of ethernet addresses when processing them.
.../include/rte_ether.h:149:2: warning: converting a packed ‘const
struct ether_addr
This is a collection of patches around the ethernet address
manipulation routines in librte_net/rte_ether.
v5
reword commit messages to workaround check-log complaints
v4
fix meson build
reword commit messages
add bonding and tespmd patches
v3
rebase to use rte_ether prefix
drop
Use rte_eth_unformat_addr, so that ethdev can be built and work
without the cmdline library. The dependency on cmdline was
an arrangement of convenience anyway.
Signed-off-by: Stephen Hemminger
---
lib/Makefile | 1 -
lib/librte_ethdev/Makefile| 2 +-
lib/librte_ethd
Make a function that can be used in place of eth_aton_r
to convert a string to rte_ether_addr. This function
allows both byte (xx:xx:xx:xx:xx:xx) and word (::)
format and has the same lack of error handling as the original.
This also allows ethdev to no longer have a hard dependency
on
Formatting Ethernet address and getting a random value are
not in critical path so they should not be inlined.
Signed-off-by: Stephen Hemminger
Acked-by: Rami Rosen
Reviewed-by: Andrew Rybchenko
---
lib/librte_net/Makefile| 1 +
lib/librte_net/meson.build | 2 +-
lib/libr
> Add new unittest-like mechanism which uses scapy to craft custom
> packets and a set of assertions to check how ipsec-secgw example
> application is processing them. Python3 with scapy module is
> required by pkttest.sh to run test scripts.
>
> A new mechanism is used to test IPv6 transport m
>
> Reconstructing IPv6 header after encryption or decryption requires
> updating 'next header' value in the preceding protocol header, which
> is determined by parsing IPv6 header and iteratively looking for
> next IPv6 header extension.
>
> It is required that 'l3_len' in the mbuf metadata co
>
> Using transport with IPv6 and header extensions requires calculating
> total header length including extensions up to ESP header which is
> achieved with iteratively parsing extensions when preparing traffic
> for processing. Calculated l3_len is later used to determine SPI
> field offset fo
> -Original Message-
> From: Smoczynski, MarcinX
> Sent: Monday, June 24, 2019 2:40 PM
> To: Kovacevic, Marko ; or...@mellanox.com;
> Richardson, Bruce ; De Lara
> Guarch, Pablo ; Nicolau, Radu
> ; akhil.go...@nxp.com; Kantecki, Tomasz
> ; Ananyev, Konstantin
> ; Iremonger, Bernard
>
More information is provided:
Fedora30 GCC:
gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/9/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-redhat-linux
Configured with: ../configure --enable-bootstrap
--
Hi,
After upgrading the Fedora29 to 30, then met the flow cmdline parse issue, like
testpmd> flow create 0 ingress pattern end actions rss queues 1 4 7 end / end
Bad arguments
After debug by adding bellow checking code:
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
inde
>
> 24/06/2019 18:12, Honnappa Nagarahalli:
> > > > > + } else {
> > > > > + rte_panic("Invalid memory order\n");
> > > >
> > > >
> > > > rte_panic should be removed from library. In this case, I think,
> > > > invalid mo can go for strongest barrier.
> >
> > It is added here to ca
Hi Reshma,
I am still seeing build issue when rebasing to this : ie. checking uint32_t is
negative in rte_telemetry.c:558
Thanks
Nic
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Monday, June 24, 2019 7:54 AM
To: Pattan, Reshma
Cc: dev@dpd
rte_kni does not follow standard style rules.
Noticed some extra \ line continuation etc.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 7 ---
lib/librte_kni/rte_kni.c | 38 +++---
2 files changed, 23 insertions(+), 22 deletions(-)
diff
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, June 24, 2019 4:17 PM
>
> Shared library linking is failing:
> undefined reference to symbol 'round@@GLIBC_2.2.5'
>
>
v4 sent.
The correct thing to return if user gives a bad data
is to return -EFAULT. Logging is also discouraged because
it could be used as a DoS attack.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_misc.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/
Some applications use ethtool so add the minimum ethtool ops.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 2 ++
kernel/linux/kni/kni_misc.c | 1 +
kernel/linux/kni/kni_net.c | 14 ++
3 files changed, 17 insertions(+)
diff --git a/kernel/linux/kni/kni_dev.h
Update KNI documentation to reflect current ethtool support.
Replace references to out dated tools (ifconfig) with
modern iproute2. Tshark is a better replacement for tcpdump.
Signed-off-by: Stephen Hemminger
---
.../prog_guide/kernel_nic_interface.rst | 9 +++
.../sample_app_ug/ker
Several fields were either totally unused or set and never used.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 5 -
kernel/linux/kni/kni_misc.c | 1 -
2 files changed, 6 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index 21e4b0d92368
Using void * instead of proper type is unsafe practice.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index f3e6c3ca4efa..ceba5f73c1d9 100644
The netdev subsystem already handles case where
network sevice does not support ioctl.
If device has no rx_mode hook it is not called.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/kernel/linux/kni/kni_net
Since kernel 2.6.28 the network subsystem has provided
dev->stats for devices to use statistics handling and is the
default if no ndo_get_stats is provided.
This allow allows for 64 bit (rather than just 32 bit)
statistics with KNI.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.
netdev_alloc_skb is optimized to any alignment or setup
of skb->dev that is required. The kernel has chosen to not pad
packets on x86 (for many years), because it is faster.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 17 +++--
1 file changed, 3 insertions(+), 1
While testing KNI with netvsc, saw lots of places more code
could be safely removed from KNI kernel driver.
v6 - more updates to documentation
v5 - add minimal ethtool, fix checkpath author complaints
v4 - add more style fixes
v3 - rebase to current master, add style fix patch
v2 - get rid of unne
On 6/24/19 1:08 PM, Noa Ezra wrote:
Hi,
What do you say about this patch?
I acknowledge we miss a way to get the queue state, but I don't like
introducing new APIs for PMD drivers.
I looked at ethdev ops on Friday, but it seems no one currently
available can do the job.
I would suggest to
Add new telemetry mode support for l3fwd-power.
This is a standalone mode, in this mode l3fwd-power
does simple l3fwding along with calculating
empty polls, full polls, and busy percentage for
each forwarding core. The aggregation of these
values of all cores is reported as application
level teleme
On 6/21/2019 12:29 PM, Morten Brørup wrote:
> Hi Olivier and Ferruh,
>
>
>
> I haven’t followed the discussions about adding the RTE prefix in details. Was
> there a conclusion about adding the RTE prefix in public identifiers of other
> (core) libraries, e.g. the IP Fragmentation and GRO/GSO l
On Mon, Jun 24, 2019 at 08:23:38AM -0700, Stephen Hemminger wrote:
> On Mon, 24 Jun 2019 10:15:58 +0200
> Gaëtan Rivet wrote:
>
> > Hello Stephen,
> >
> > On Fri, Jun 21, 2019 at 03:08:24PM -0700, Stephen Hemminger wrote:
> > > When secondary process is run was noticing that the log always
> > >
24/06/2019 18:12, Honnappa Nagarahalli:
> > > > + } else {
> > > > + rte_panic("Invalid memory order\n");
> > >
> > >
> > > rte_panic should be removed from library. In this case, I think,
> > > invalid mo can go for strongest barrier.
>
> It is added here to capture programming
> > >
> > > Add 128-bit atomic compare exchange on aarch64.
> > >
> > > Signed-off-by: Phil Yang
> > > Reviewed-by: Honnappa Nagarahalli
> > > Tested-by: Honnappa Nagarahalli
> > > ---
> > > This patch depends on 'eal/stack: fix 'pointer-sign' warning'
> > > http://patchwork.dpdk.org/patch/548
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Monday, June 24, 2019 5:28 PM
>
> On Mon, 24 Jun 2019 16:04:15 +0100
> "Burakov, Anatoly" wrote:
>
> > On 24-Jun-19 3:53 PM, Ferruh Yigit wrote:
> > > On 6/23/2019 11:46 PM, Thomas Monja
The default policy for offload-specific fields is that
they are undefined unless the corresponding offloads are
requested in mbuf ol_flags. This is also the case for outer
L2 and L3 length fields which must not be assumed to contain
zeros for non-tunnel packets. The patch clarifies this behaviour
i
This patch fixes the out-of-bounds coverity issue by adding
missed algorithms to the array.
Coverity issue: 337683
Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
Signed-off-by: Fan Zhang
---
v3:
- fixed a compile issue
v2:
- added missed size data.
drivers/crypt
Hi Jerin,
Thank you for your comments. I will modify these in the next version.
Thanks,
Phil
> -Original Message-
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 24, 2019 2:41 PM
> To: Phil Yang (Arm Technology China) ; dev@dpdk.org
> Cc: tho...@monjalon.net; hemant.agra...@nxp.c
This series patchs are based on RFC [1], which enable the matching on
GRE's key field.
And enabled MLX5 device supports on this.
[1] https://patches.dpdk.org/patch/53432/
Xiaoyu Min (4):
ethdev: add GRE key field to flow API
net/mlx5: support match GRE protocol on DR engine
net/mlx5: match
support matching on the present bits (C,K,S)
as well as the optional key field.
If the rte_flow_item_gre_key is specified in pattern,
it will set K present match automatically.
Signed-off-by: Xiaoyu Min
---
drivers/net/mlx5/mlx5_flow.c| 49 +++-
drivers/net/mlx5/mlx5_flow.h
Add new rte_flow_item_gre_key in order to match the optional key field.
Signed-off-by: Xiaoyu Min
---
doc/guides/prog_guide/rte_flow.rst | 9 +
lib/librte_ethdev/rte_flow.c | 1 +
lib/librte_ethdev/rte_flow.h | 27 +++
3 files changed, 37 insertions(
support matching on GRE key and present bits (C,K,S)
example testpmd command could be:
testpmd>flow create 0 ingress group 1 pattern eth / ipv4 /
gre crksv is 0x2000 crksv mask 0xb000 /
gre_key key is 0x12345678 / end
actions rss queues 1 0 end / mark id 196 / end
DR engine support matching on GRE protocol field without MPLS supports.
So bypassing the MPLS check when DR is enabled.
Signed-off-by: Xiaoyu Min
---
drivers/net/mlx5/mlx5_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
ind
Hi,
I’m running into an issue where I have a VF used by OVS-DPDK and from
the kernel side change the MAC.
I used the following command to change the mac:
ip link set p5p2 vf 0 mac 52:54:00:92:d3:30
In the kernel log I see the following:
[ 3420.075736] i40e :05:00.1: Bring down and up th
This patch intend to support
action_raw_encap/decap [1] in a generic and convenient way.
Two new commands - set raw_encap, set raw_decap are introduced just
like the other commands for encap/decap, i.e. set vxlan.
These two commands have corresponding global buffers
which can be used by PMD as th
Open the MPLS's TC and S bits of rte_flow_item_mpls in command line.
Signed-off-by: Xiaoyu Min
---
app/test-pmd/cmdline_flow.c | 20
1 file changed, 20 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index e7da0fad2a..f3c0b7902f 100644
-
This series is based on RFC [1], which enable the testpmd to support
the raw_encap/raw_decap actions in a generic and convenient way.
Some rte_flow_item's fields are also opened in testpmd cmdline
i.e. MPLS's TC & S in order to make sure the encapsulated tunnel header
has the correct data.
[1] ht
> -Original Message-
> From: Eads, Gage
> Sent: Monday, June 24, 2019 10:46 PM
> To: Phil Yang (Arm Technology China) ; dev@dpdk.org
> Cc: tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com;
> Honnappa Nagarahalli ; Gavin Hu (Arm
> Technology China) ; nd
> Subject: RE: [PATCH
> -Original Message-
> From: Eads, Gage
> Sent: Monday, June 24, 2019 11:10 PM
> To: Phil Yang (Arm Technology China) ; dev@dpdk.org
> Cc: tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com;
> Honnappa Nagarahalli ; Gavin Hu (Arm
> Technology China) ; nd
> Subject: RE: [PATCH
On Mon, 24 Jun 2019 16:04:15 +0100
"Burakov, Anatoly" wrote:
> On 24-Jun-19 3:53 PM, Ferruh Yigit wrote:
> > On 6/23/2019 11:46 PM, Thomas Monjalon wrote:
> >> 21/06/2019 21:56, Stephen Hemminger:
> >>> Just tried make doc on current DPDK tree and it fails:
> >>>
> >>> /home/shemminger/git/dp
On Mon, 24 Jun 2019 10:15:58 +0200
Gaëtan Rivet wrote:
> Hello Stephen,
>
> On Fri, Jun 21, 2019 at 03:08:24PM -0700, Stephen Hemminger wrote:
> > When secondary process is run was noticing that the log always
> > contained complaints about unable to parse devargs.
> >
> > It turns out that an
> -Original Message-
> From: Eads, Gage
> Sent: Monday, June 24, 2019 11:15 PM
> To: Phil Yang (Arm Technology China) ; dev@dpdk.org
> Cc: tho...@monjalon.net; jer...@marvell.com; hemant.agra...@nxp.com;
> Honnappa Nagarahalli ; Gavin Hu (Arm
> Technology China) ; nd
> Subject: RE: [PATCH
13/06/2019 15:44, Reshma Pattan:
> Add new telemetry mode support for l3fwd-power.
> This is a standalone mode, in this mode l3fwd-power
> does simple l3fwding along with calculating
> empty polls, full polls, and busy percentage for
> each forwarding core. The aggregation of these
> values of all
> Subject: [PATCH v2 3/3] eal/stack: enable lock-free stack for aarch64
>
> Enable both c11 atomic and non c11 atomic lock-free stack for aarch64.
>
> Signed-off-by: Phil Yang
> Reviewed-by: Honnappa Nagarahalli
> Tested-by: Honnappa Nagarahalli
> ---
> doc/guides/rel_notes/release_19_08.rst
Hi Phil,
Looks good overall, just a few documentation issues.
> + *
> + * - Test "128b compare and swap" (aarch64 and x86_64 only)
> + *
> + * - Initialize 128-bit atomic variables to zero.
> + *
> + * - Invoke ``test_atomici128_cmp_exchange()`` on each lcore. Before
> doing
> + * anyth
On 24-Jun-19 3:53 PM, Ferruh Yigit wrote:
On 6/23/2019 11:46 PM, Thomas Monjalon wrote:
21/06/2019 21:56, Stephen Hemminger:
Just tried make doc on current DPDK tree and it fails:
/home/shemminger/git/dpdk/doc/guides/faq/faq.rst:7: WARNING: undefined label:
linux_gsg (if the link has no capti
18/06/2019 15:49, Reshma Pattan:
> telemetry has support for fetching port based stats
> from metrics library.
>
> Metrics library also has global stats which are
> not fetched by telemetry, so extend telemetry to
> fetch the global metrics.
>
> Signed-off-by: Reshma Pattan
> Acked-by: Kevin Laa
On 6/23/2019 11:46 PM, Thomas Monjalon wrote:
> 21/06/2019 21:56, Stephen Hemminger:
>> Just tried make doc on current DPDK tree and it fails:
>>
>> /home/shemminger/git/dpdk/doc/guides/faq/faq.rst:7: WARNING: undefined
>> label: linux_gsg (if the link has no caption the label must precede a
>> s
Hi Phil,
> diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h
> b/lib/librte_eal/common/include/generic/rte_atomic.h
> index 9958543..7dd1aa4 100644
> --- a/lib/librte_eal/common/include/generic/rte_atomic.h
> +++ b/lib/librte_eal/common/include/generic/rte_atomic.h
> @@ -1081,6 +1081
From: Krzysztof Kanas
Kernel validates block size to be aligned to page size. Code works on
platforms with page size 4k, but on others e.g. Arm64 fails with default
parameters.
Signed-off-by: Krzysztof Kanas
---
drivers/net/af_packet/rte_eth_af_packet.c | 4 ++--
1 file changed, 2 insertions(+
From: Dilshod Urazov
Layer 2 length must be updated after the prepend to mbuf to keep
the length right to be used by other Tx offloads.
If the packet has tunnel encapsulation, outer_l2_len should be
updated. Otherwise l2_len should be updated.
Fixes: c974021a5949 ("ether: add soft vlan encap/de
Reconstructing IPv6 header after encryption or decryption requires
updating 'next header' value in the preceding protocol header, which
is determined by parsing IPv6 header and iteratively looking for
next IPv6 header extension.
It is required that 'l3_len' in the mbuf metadata contains a total
le
Using transport with IPv6 and header extensions requires calculating
total header length including extensions up to ESP header which is
achieved with iteratively parsing extensions when preparing traffic
for processing. Calculated l3_len is later used to determine SPI
field offset for an inbound tr
Add new unittest-like mechanism which uses scapy to craft custom
packets and a set of assertions to check how ipsec-secgw example
application is processing them. Python3 with scapy module is
required by pkttest.sh to run test scripts.
A new mechanism is used to test IPv6 transport mode traffic wit
Add support for IPv6 with header extensions (IPv6 options) and IPsec
transport mode:
1. Add IPv6 header extension parsing method in librte_net
2. Fix IPv6 header with extension parsing in both librte_ipsec and
ipsec sample application using abovementioned function
3. Add new testing mechanism fo
Introduce new function for IPv6 header extension parsing able to
determine extension length and next protocol number.
This function is helpful when implementing IPv6 header traversing.
Signed-off-by: Marcin Smoczynski
---
lib/librte_net/rte_ip.h | 49 +
1
This patch changes the key pointer data types in cipher, auth,
and aead xforms from "uint8_t *" to "const uint8_t *" for a
more intuitive and safe sessionn creation.
Signed-off-by: Fan Zhang
Acked-by: Arek Kusztal
Acked-by: Akhil Goyal
---
v4:
- Removed deprecation notice and updated release no
20/06/2019 16:35, Ferruh Yigit:
> On 6/19/2019 9:24 AM, Qi Zhang wrote:
> > Xiaolong Ye will replace Beilei Xing as co-maintainer of
> > dpdk-next-net-intel.
> >
> > Signed-off-by: Qi Zhang
>
> Acked-by: Ferruh Yigit
Applied, thanks
Xiaolong may require some training from Qi and Ferruh.
Welco
On 6/24/19 3:59 PM, Ananyev, Konstantin wrote:
Hi Andrew,
Hi Konstantin,
On 6/21/19 2:10 PM, Ananyev, Konstantin wrote:
Hi Ivan,
Make sure that outer L2 and L3 header length fields are
equal to zero for non-tunnel packets in order to ensure
consistent and predictable behaviour in network driv
24/06/2019 13:31, Ferruh Yigit:
> On 6/24/2019 10:25 AM, Morten Brørup wrote:
> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> >> Sent: Wednesday, June 19, 2019 8:22 PM
> >>
> >> This driver had a bogus assert which could never happen.
> >> This triggers "expression is
Hi All,
Since Ian's change didn't include MTU interpretation issue, we want to see if
we can send out a patch for this discussion to conclude as we have a similar
problem.
Currently two ways are as below.
#1 Konstantin's solution of adding new api rte_ethdev_mtu_to_frame_size(devid,
mtu), that
> On Jun 24, 2019, at 4:22 AM, Xia Rui wrote:
>
> Thank you for your reply. I am trying to use the latest version of
> pktgen-dpdk, ovs, and dpdk. But I meet some problem when setting up the
> platform.
>
> The version of my platform:
> 1. OVS: 2.11.1
> 2. DPDK: 18.11
> 3. pktgen-dpdk: 3.6.6
24/06/2019 13:17, Ferruh Yigit:
> On 6/24/2019 8:53 AM, Andrew Rybchenko wrote:
> > Hi Thomas,
> >
> > On 6/24/19 1:37 AM, Thomas Monjalon wrote:
> >> 18/06/2019 09:52, Ferruh Yigit:
> >>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote:
> checkpatches.sh generates warnings/errors because of a b
Hi Andrew,
> Hi Konstantin,
>
> On 6/21/19 2:10 PM, Ananyev, Konstantin wrote:
> Hi Ivan,
>
> Make sure that outer L2 and L3 header length fields are
> equal to zero for non-tunnel packets in order to ensure
> consistent and predictable behaviour in network drivers.
> Explain this expectation in
Thanks Maxime.
> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
> Sent: Thursday, June 20, 2019 10:44 AM
> To: Zhang, Roy Fan ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [PATCH] examples/vhost_crypto: fix unchecked return value
>
>
>
> On 5/15/19
On 6/24/19 3:01 PM, Ananyev, Konstantin wrote:
-Original Message-
From: Ananyev, Konstantin
Sent: Monday, June 24, 2019 12:52 PM
To: 'Ivan Malov' ; Olivier Matz
Cc: dev@dpdk.org; Kulasek, TomaszX ; sta...@dpdk.org
Subject: RE: [dpdk-dev] [PATCH] net: fix the way how L4 checksum choice
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Monday, June 24, 2019 12:52 PM
> To: 'Ivan Malov' ; Olivier Matz
>
> Cc: dev@dpdk.org; Kulasek, TomaszX ;
> sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net: fix the way how L4 checksum choice is
> tested
>
>
> > The API
> The API to prepare checksum offloads mistreats L4
> checksum type enum values as self-contained flags.
>
> Turning these flag checks into enum checks causes
> warnings by GCC about possibly uninitialised IPv4
> header pointer. The issue was found to show up in
> the case of GCC versions 4.8.5
Hi Akhil,
I've double checked and there is no problem with linking application against
shared libraries, because inline functions are being inlined during compilation
and before linking is done. To be more specific: there is not such symbol as
rte_ipv6_get_next_ext in ipsec-secgw.o (which uses t
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Malov
> Sent: Friday, May 24, 2019 3:57 PM
> To: Olivier Matz
> Cc: dev@dpdk.org; Kulasek, TomaszX ;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net: fix encapsulation markers for inner L3 offset
>
>
On 6/24/2019 10:25 AM, Morten Brørup wrote:
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
>> Sent: Wednesday, June 19, 2019 8:22 PM
>>
>> This driver had a bogus assert which could never happen.
>> This triggers "expression is always false warnings" with some
>> compiler
On 6/24/2019 8:53 AM, Andrew Rybchenko wrote:
> Hi Thomas,
>
> On 6/24/19 1:37 AM, Thomas Monjalon wrote:
>> 18/06/2019 09:52, Ferruh Yigit:
>>> On 6/10/2019 8:38 AM, Andrew Rybchenko wrote:
checkpatches.sh generates warnings/errors because of a bit different
coding style in base driver.
Hi,
What do you say about this patch?
Thanks,
Noa.
> -Original Message-
> From: Noa Ezra [mailto:n...@mellanox.com]
> Sent: Wednesday, June 19, 2019 9:15 AM
> To: maxime.coque...@redhat.com
> Cc: Matan Azrad ; dev@dpdk.org; Noa Ezra
>
> Subject: [Suspected-Phishing][PATCH] net/vhost: add
Morten Brørup would like to recall the message, "[dpdk-dev] [PATCH 2/2]
net/qede: fix warnings from invalid assert".
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, June 19, 2019 8:22 PM
>
> This driver had a bogus assert which could never happen.
> This triggers "expression is always false warnings" with some
> compilers which causes build failure.
> Just remove it.
>
1 - 100 of 107 matches
Mail list logo
