Re: [dpdk-dev] [EXT] [PATCH] cryptodev: free memzone when releasing cryptodev

Hi Anoob, > > > > -- > > When a cryptodev is created in a primary process, rte_cryptodev_data_alloc > > reserves a memzone. > > However, this memzone was not released when the cryptodev is uninitialized. > > After that, new cryptod

Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and mempool driver

> -Original Message- > From: dev On Behalf Of Jerin Jacob Kollanukkaran > Sent: Thursday, June 27, 2019 1:45 PM > To: Ferruh Yigit > Cc: dev@dpdk.org; Thomas Monjalon ; Amit Gupta > > Subject: Re: [dpdk-dev] [PATCH v4 00/27] OCTEON TX2 common and > mempool driver > > > > Hi Jerin, > >

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Friday, June 28, 2019 12:35 > To: Ruifeng Wang (Arm Technology China) > Cc: bruce.richard...@intel.com; vladimir.medved...@intel.com; > dev@dpdk.org; Honnappa Nagarahalli ; > Gavin Hu (Arm Technology China) ; nd > Subjec

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: free memzone when releasing cryptodev

Hi, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Junxiao Shi > Sent: Thursday, May 30, 2019 10:38 PM > To: dev@dpdk.org > Subject: [EXT] [dpdk-dev] [PATCH] cryptodev: free memzone when releasing > cryptodev > > External Email > > -

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/3] test/hash: free allocated memory

On Thu, Jun 27, 2019 at 5:25 AM Honnappa Nagarahalli mailto:honnappa.nagaraha...@arm.com>> wrote: Free allocated memory. Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli mailto:honnappa.nagaraha

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] test/hash: init hash parameters in the correct function

static int test_rwc_reader(__attribute__((unused)) void *arg) { @@ -1254,7 +1257,6 @@ test_hash_readwrite_lf_main(void) */ int rwc_lf = 0; int htm; - int use_jhash = 0; int ext_bkt = 0; if (rte_lcore_count() == 1) { printf("More th

[dpdk-dev] [PATCH v2 2/3] test/hash: init hash parameters in the correct function

Each test case initializes its hash parameters in the test case function. To be consistent, generate keys function should initialize hash parameters similarly. Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dh

[dpdk-dev] [PATCH v2 3/3] test/hash: free allocated memory

Free allocated memory. Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_hash_readwrite_lf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app

[dpdk-dev] [PATCH v2 1/3] test/hash: reset global variable to discard old data

Reset tbl_rwc_test_param to discard data from previous run of the test. Fixes: c7eb0972e74b ("test/hash: add lock-free r/w concurrency") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Dharmik Thakkar --- app/test/test_hash_readwrite_lf.c | 3 +++ 1 file changed, 3 inserti

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

On Fri, 28 Jun 2019 02:44:54 + "Ruifeng Wang (Arm Technology China)" wrote: > > > > > Tests showed that the function inlining caused performance drop on > > > some x86 platforms with the memory ordering patches applied. > > > By force no-inline functions, the performance was better than be

Re: [dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

On Fri, 28 Jun 2019 06:13:09 +0300 Ivan Malov wrote: > The API to prepare checksum offloads mistreats L4 > checksum type enum values as self-contained flags. > > Turning these flag checks into enum checks causes > warnings by GCC about possibly uninitialised IPv4 > header pointer. The issue was

[dpdk-dev] [PATCH 2/2] test/rcu: address test case failure

Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Rui

[dpdk-dev] [PATCH 1/2] test/rcu: increase the size of num cores variable

num_cores is of type uint8_t. This results in the following compilation error. test_rcu_qsbr_perf.c:649:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (num_cores >= RTE_MAX_LCORE) { ^~ RTE_MAX_LCORE is set to 256 for armv8 config

Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library

> -Original Message- > From: Anoob Joseph > Sent: Thursday, June 27, 2019 10:58 AM > To: Jerin Jacob Kollanukkaran ; Mattias Rönnblom > ; Nikhil Rao ; Erik > Gabriel Carrillo ; Abhinandan Gujjar > ; Bruce Richardson > ; Pablo de Lara > > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org; > L

[dpdk-dev] [PATCH 1/1] net/hinic: solve compilation issues

This patch fixes ci/Intel-compilation issues for hinic PMD on 32-bits platform. Signed-off-by: Ziyang Xuan --- drivers/net/hinic/Makefile | 18 ++ drivers/net/hinic/base/meson.build | 12 2 files changed, 30 insertions(+) diff --git a/drivers/net/hinic/Makef

[dpdk-dev] Strange cache sync problem(?) with reading mbuf

Hello all, I am aware that this is some caching/synchronization problem but for some reason despite using the barrier macros it does not seem to go away.What makes it go away though is to give a rte_delay of 100us and re-reading the value again like so: cons_rx_buf = &rxr

[dpdk-dev] [PATCH v4] net/af_xdp: support need wakeup feature

This patch enables need_wakeup flag for Tx and fill rings, when this flag is set by the driver, it means that the userspace application has to explicitly wake up the kernel Rx or kernel Tx processing by issuing a syscall. Poll() can wake up both and sendto() or its alternatives will wake up Tx proc

[dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

The API to prepare checksum offloads mistreats L4 checksum type enum values as self-contained flags. Turning these flag checks into enum checks causes warnings by GCC about possibly uninitialised IPv4 header pointer. The issue was found to show up in the case of GCC versions 4.8.5 and 5.4.0, howev

[dpdk-dev] [PATCH v9 5/6] usertools/dpdk-devbind.py: add support for ntb

In order to allow binding/unbinding of devices for use by the ntb_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. And only support skx platform right now. Signed-off-by: Xiaoyun Li --- usertools/dpdk-devbind.py | 9

[dpdk-dev] [PATCH v9 6/6] doc: update docs for ntb driver

Update related documents for ntb pmd and example. Signed-off-by: Xiaoyun Li --- MAINTAINERS| 9 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/ntb_rawdev.rst | 41 ++ doc/guides/rel_notes/release_19_08.rst | 15 ++

[dpdk-dev] [PATCH v9 2/6] raw/ntb: add intel ntb support

Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 369 ++

[dpdk-dev] [PATCH v9 4/6] examples/ntb: enable an example for ntb

Enable an example for rawdev ntb. Support interactive mode to send file on one host and receive file from another host. The command line would be 'send [filepath]' and 'receive [filepath]'. But since the FIFO is not enabled right now, use rte_memcpy as the enqueue and dequeue functions and only su

[dpdk-dev] [PATCH v9 0/6] rawdev driver for ntb

This patch set adds support for Intel NTB device with Skylake platform. It is a raw device for allowing two hosts to communicate with each other and access the peer memory. This patch set also provides a simple example to transmit a file between two hosts. But since there is no FIFO here, only sup

[dpdk-dev] [PATCH v9 3/6] raw/ntb: add handshake process

Add handshake process using doorbell so that two hosts can communicate to start and stop. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/ntb_rawdev.c | 336 +++- 1 file changed, 335 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c b/dr

[dpdk-dev] [PATCH v9 1/6] raw/ntb: introduce ntb rawdev driver

Introduce rawdev driver support for NTB (Non-transparent Bridge) which can help to connect two separate hosts with each other. Signed-off-by: Xiaoyun Li --- config/common_base| 5 + drivers/raw/Makefile | 1 + drivers/raw/meson.build

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, June 27, 2019 23:25 > To: Ruifeng Wang (Arm Technology China) > Cc: bruce.richard...@intel.com; vladimir.medved...@intel.com; > dev@dpdk.org; Honnappa Nagarahalli ; > Gavin Hu (Arm Technology China) ; nd > Subj

Re: [dpdk-dev] [PATCH v3] net/af_xdp: support need wakeup feature

Hi, Ferruh On 06/27, Ferruh Yigit wrote: >On 6/21/2019 2:19 PM, Xiaolong Ye wrote: >> This patch enables need_wakeup flag for Tx and fill rings, when this flag >> is set by the driver, it means that the userspace application has to >> explicitly wake up the kernel Rx or kernel Tx processing by iss

Re: [dpdk-dev] [PATCH v8 4/6] examples/ntb: enable an example for ntb

Hi > -Original Message- > From: Wu, Jingjing > Sent: Friday, June 28, 2019 01:30 > To: Li, Xiaoyun ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 4/6] examples/ntb: enable an example for ntb > > > -Original Message- > > From: Li,

Re: [dpdk-dev] [PATCH v8 2/6] raw/ntb: add intel ntb support

Hi > -Original Message- > From: Wu, Jingjing > Sent: Friday, June 28, 2019 01:07 > To: Li, Xiaoyun ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 2/6] raw/ntb: add intel ntb support > > Few minor comments. > > > + case XEON_PPD_CONN_T

Re: [dpdk-dev] [PATCH v8 3/6] raw/ntb: add handshake process

Yes. Thx. > -Original Message- > From: Wu, Jingjing > Sent: Friday, June 28, 2019 01:20 > To: Li, Xiaoyun ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 3/6] raw/ntb: add handshake process > > > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH v2] net: fix the way how L4 checksum choice is tested

On Fri, 28 Jun 2019 00:52:02 +0300 Ivan Malov wrote: > + /* > + * Initialise ipv4_hdr beforehand to mute false positive > + * compiler warnings about this variable being possibly used > + * uninitialised in L4 parsing branches below albeit it is clearly > + * initialised i

[dpdk-dev] [PATCH v4 6/6] app/test-compress-perf: add force process termination

From: Tomasz Jozwiak This patch adds a possibility to force controlled process termination as a result of two signals: SIGTERM and SIGINT Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options.h| 1 + app/test-compress-perf/comp_perf_test_benchmark.c | 13 +

[dpdk-dev] [PATCH v4 3/6] app/test-compress-perf: add verification test case

From: Tomasz Jozwiak This patch adds a verification part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile| 1 + app/test-compress-perf/comp_perf_test_verify.c | 122 ++

[dpdk-dev] [PATCH v4 4/6] app/test-compress-perf: add benchmark test case

From: Tomasz Jozwiak This patch adds a benchmark part to compression-perf-tool as a separate test case, which can be executed multi-threaded. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 1 + app/test-compress-perf/comp_

[dpdk-dev] [PATCH v4 2/6] app/test-compress-perf: add ptest command line option

From: Tomasz Jozwiak This patch adds --ptest option to make possible a choose of test case from command line. Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/comp_perf_options_parse.c | 32 1 file changed, 32 insertions(+) diff

[dpdk-dev] [PATCH v4 5/6] doc: update dpdk-test-compress-perf description

From: Tomasz Jozwiak This patch updates a dpdk-test-compress-perf documentation. Signed-off-by: Tomasz Jozwiak --- doc/guides/tools/comp_perf.rst | 34 +++--- 1 file changed, 31 insertions(+), 3 deletions(-) diff --git a/doc/guides/tools/comp_perf.rst b/doc/guides/

[dpdk-dev] [PATCH v4 1/6] app/test-compress-perf: add weak functions for multi-cores test

From: Tomasz Jozwiak This patch adds a template functions for multi-cores performance version of compress-perf-tool and updates release notes for 19.08 Signed-off-by: Tomasz Jozwiak Signed-off-by: Tomasz Jozwiak --- app/test-compress-perf/Makefile | 3 +- app/test-compress-

[dpdk-dev] [PATCH v4 0/6] add multiple cores feature to test-compress-perf

This patchset adds multiple cores feature to compression perf tool. All structures have been aligned and are consistent with crypto perf tool. All test cases have constructor, runner and destructor and can use more cores and compression devices at the same time. v2 changes: - fixed checkpatch w

[dpdk-dev] [PATCH v2] net: fix the way how L4 checksum choice is tested

The API to prepare checksum offloads mistreats L4 checksum type enum values as self-contained flags. Turning these flag checks into enum checks causes warnings by GCC about possibly uninitialised IPv4 header pointer. The issue was found to show up in the case of GCC versions 4.8.5 and 5.4.0, howev

Re: [dpdk-dev] [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option

Hi Shally, -Original Message- From: Tomasz Jozwiak Sent: Wednesday, June 26, 2019 11:05 PM To: Shally Verma ; dev@dpdk.org; fiona.tr...@intel.com; arturx.tryb...@intel.com Subject: Re: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option Hi Shally, -Orig

Re: [dpdk-dev] [PATCH v3 6/6] eal: add PRNG to MAINTAINERS and release notes

05/06/2019 12:44, Mattias Rönnblom: > Add a section on PRNG in MAINTAINERS, and information on the PRNG > improvements in the 19.08 release notes. > > Signed-off-by: Mattias Rönnblom > Acked-by: Bruce Richardson > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > +Pseudo-random Number Generation > +

Re: [dpdk-dev] [PATCH v3 7/7] doc: update release notes for 19.08

Hi Thomas, W dniu 26.06.2019 o 23:26, Thomas Monjalon pisze: 26/06/2019 18:30, Tomasz Jozwiak: --- a/doc/guides/rel_notes/release_19_08.rst +++ b/doc/guides/rel_notes/release_19_08.rst +* **Updated test-compress-perf tool application.** + + Added multiple cores feature to compression perf too

Re: [dpdk-dev] [PATCH v3 2/6] eal: add pseudo-random number generation performance test

05/06/2019 12:43, Mattias Rönnblom: > Add performance test for rte_rand(). > > Signed-off-by: Mattias Rönnblom > Acked-by: Bruce Richardson > --- > app/test/Makefile | 1 + > app/test/test_rand_perf.c | 75 +++ > 2 files changed, 76 insertions(+) Wh

Re: [dpdk-dev] [PATCH] bpf: fix invalid array size

21/06/2019 16:26, Konstantin Ananyev: > Array ins_chk in lib/librte_bpf/bpf_validate.c has 255 entries. > So the instruction with opcode == 255 will reading beyond array > boundaries. > For more details please refer to: > https://bugs.dpdk.org/show_bug.cgi?id=283 > > Fixes: 6e12ec4c4d6d ("bpf: add

Re: [dpdk-dev] [PATCH v2] bus/vmbus: skip non-network devices

06/06/2019 02:37, Stephen Hemminger: > From: Stephen Hemminger > > The vmbus scan code can just skip non-network devices. > More importantly, this fixes the bug where some vmbus devices > don't have all the attributes (like monitor_id) and a single > failure would cause the scan to break the loop

[dpdk-dev] [PATCH v3] mbuf: outer offsets are undefined for non-tunnel packets

The default policy for offload-specific fields is that they are undefined unless the corresponding offloads are requested in mbuf ol_flags. This is also the case for outer L2 and L3 length fields which must not be assumed to contain zeros for non-tunnel packets. The patch clarifies this behaviour i

Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI

15/06/2019 08:42, David Marchand: > This is a joint effort to make the unit tests ready for CI. Applied, thanks Remaining work below from your list: [...] > - the tests on --file-prefix are still ko, and have been isolated in a > test that we could disable while waiting for the fixes, > - rwloc

[dpdk-dev] [PATCH] telemetry: fix build

Build error: ../lib/librte_telemetry/rte_telemetry.c:558:28: error: comparison of unsigned expression < 0 is always false [-Werror,-Wtautological-compare] Build error not observed in default make build because telemetry library disabled by default but easier to reproduce via meson. Fixing by

Re: [dpdk-dev] [PATCH 2/2] timer: fix resource leak in finalize

> -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 11:12 AM > To: dev@dpdk.org > Cc: Robert Sanford ; Carrillo, Erik G > > Subject: [PATCH 2/2] timer: fix resource leak in finalize > > Currently, whenever timer library is initialized, the memory is leaked because

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix typos in rte flow guide

On 6/18/2019 3:07 PM, Xiaolong Ye wrote: > Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") > Cc: sta...@dpdk.org > > Signed-off-by: Xiaolong Ye Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/2] eal: add internal locks for timer lib into EAL

Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 11:12 AM > To: dev@dpdk.org > Cc: Carrillo, Erik G > Subject: [PATCH 1/2] eal: add internal locks for timer lib into EAL > > Currently, timer library has a memory leak because there is no way to > co

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] net/netvsc: xstat fixes

On 6/20/2019 11:09 PM, Stephen Hemminger wrote: > A couple of fixes for the xstats functionality in netvsc PMD. > > Mohsin Mazhar Shaikh (1): > net/netvsc: set id in xstats_get > > Stephen Hemminger (1): > net/netvsc: fix xstats for VF device Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/af_packet: set default blocksize to pagesize

On 6/24/2019 3:32 PM, kka...@marvell.com wrote: > From: Krzysztof Kanas > > Kernel validates block size to be aligned to page size. Code works on > platforms with page size 4k, but on others e.g. Arm64 fails with default > parameters. What is the pagesize in arm64? > > Signed-off-by: Krzysztof

Re: [dpdk-dev] [PATCH v3] net/af_xdp: support need wakeup feature

On 6/21/2019 2:19 PM, Xiaolong Ye wrote: > This patch enables need_wakeup flag for Tx and fill rings, when this flag > is set by the driver, it means that the userspace application has to > explicitly wake up the kernel Rx or kernel Tx processing by issuing a > syscall. Poll() can wake up both and

Re: [dpdk-dev] [PATCH 0/2] net/netvsc: RSS parameter support

On 6/13/2019 4:03 PM, Stephen Hemminger wrote: > A couple of patches to allow programming RSS in the netvsc PMD. > > Stephen Hemminger (2): > net/netvsc: return correct RSS offload settings > net/netvsc: support configuring RSS parameters Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 19.08 v3 2/2] net/pcap: enable infinitely rxing a pcap file

On 6/14/2019 3:43 PM, Cian Ferriter wrote: > It can be useful to use pcap files for some rudimental performance > > At a high level, this works by creaing a ring of sufficient size to > store the packets in the pcap file passed to the application. When the > rx function for this mode is called, pa

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields

On 6/27/19 8:39 PM, Dekel Peled wrote: Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK

Re: [dpdk-dev] [PATCH] net/nfb: add Silicom Mango card support

On 6/13/2019 1:33 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Add support for Silicom FB2CGG3 smart NIC > > Signed-off-by: Rastislav Cernay Applied to dpdk-next-net/master, thanks. Is this requires any release notes or web update, because of the new device support? If so please

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

On 6/13/2019 2:01 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Add support for Silicom FB2CGG3 smart NIC > > Signed-off-by: Rastislav Cernay Applied to dpdk-next-net/master, thanks. (But this requires Ack from maintainer, Jan if you agree please ack the patch, or I will drop from

[dpdk-dev] [PATCH v7 3/3] net/mlx5: update modify header using Direct Verbs

This patch implements additional actions of packet header modifications. Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP

[dpdk-dev] [PATCH v7 2/3] app/testpmd: add actions to modify TCP header fields

Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

[dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields

Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

[dpdk-dev] [PATCH v7 0/3] add actions to modify header fields

Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2]. This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD. Original work by Xiaoyu Min. [1] http://patches.dpdk.org/patch/4931

Re: [dpdk-dev] [PATCH v8 5/6] usertools/dpdk-devbind.py: add support for ntb

> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, June 26, 2019 3:12 PM > To: Wu, Jingjing ; Wiles, Keith > ; Liang, > Cunming ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v8 5/6] usertools/dpdk-devbind.py: add support for ntb > > In order to allow bi

Re: [dpdk-dev] [PATCH v8 6/6] doc: update docs for ntb driver

> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, June 26, 2019 3:12 PM > To: Wu, Jingjing ; Wiles, Keith > ; Liang, > Cunming ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v8 6/6] doc: update docs for ntb driver > > Update related documents for ntb pm

Re: [dpdk-dev] [PATCH v8 4/6] examples/ntb: enable an example for ntb

> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, June 26, 2019 3:12 PM > To: Wu, Jingjing ; Wiles, Keith > ; Liang, > Cunming ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v8 4/6] examples/ntb: enable an example for ntb > > Enable an example for rawdev n

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: remove port stop check for macsec

On 6/10/2019 7:07 AM, Wei Zhao wrote: > There is no need to do such a check when set macsec for ixgbe, and > reconfig_device_queueand is also useless. If we do not delete this > unnessary code, users have to stop port before enable or disable > macsec, then restart this port after make configuratio

Re: [dpdk-dev] [PATCH v8 3/6] raw/ntb: add handshake process

> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, June 26, 2019 3:12 PM > To: Wu, Jingjing ; Wiles, Keith > ; Liang, > Cunming ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v8 3/6] raw/ntb: add handshake process > > Add handshake process using doorbell

Re: [dpdk-dev] [PATCH v8 2/6] raw/ntb: add intel ntb support

Few minor comments. > +static int > +intel_ntb_dev_init(struct rte_rawdev *dev) > +{ > + struct ntb_hw *hw = dev->dev_private; > + uint8_t reg_val, bar; > + int ret, i; > + > + if (hw == NULL) { > + NTB_LOG(ERR, "Invalid device."); > + return -EINVAL; > +

Re: [dpdk-dev] [PATCH v2 0/3] Improve automatic selection of IOVA mode

Help in review would be much appreciated here, thanks. 14/06/2019 11:39, David Marchand: > In SPDK, not all drivers are registered with DPDK at start up time. > Previously, that meant DPDK always chose to set itself up in IOVA_PA > mode. Instead, when the correct iova choice is unclear based on th

Re: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 27, 2019 11:41 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start

Re: [dpdk-dev] [PATCH 00/14] Unit tests fixes for CI

04/06/2019 17:49, Michael Santana Francisco: > On 6/4/19 4:59 AM, David Marchand wrote: > > - the "perf" tests are taking way too long for my taste, > > We should still fix them. However I don't know if we should be running > the perf test for every job and every patch on travis. It takes too >

Re: [dpdk-dev] [PATCH v8 1/6] raw/ntb: introduce ntb rawdev driver

> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, June 26, 2019 3:12 PM > To: Wu, Jingjing ; Wiles, Keith > ; Liang, > Cunming ; Maslekar, Omkar > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v8 1/6] raw/ntb: introduce ntb rawdev driver > > Introduce rawdev driver suppor

Re: [dpdk-dev] [PATCH v2] eal: promote some service core functions to stable

On Thu, Jun 20, 2019 at 9:03 PM Gage Eads mailto:gage.e...@intel.com>> wrote: The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK 18.08. They can be considered non-experimental for the 19.08 release. r

Re: [dpdk-dev] [PATCH] ip_frag: fix IPv6 fragment size calculation

06/06/2019 13:33, Konstantin Ananyev: > Take into account IPv6 fragment extension header when > calculating data size for each fragment. > > Fixes: 7a838c8798a9 ("ip_frag: fix IPv6 when MTU sizes not aligned to 8 > bytes") > Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support") > Cc: st

Re: [dpdk-dev] [PATCH v2] eal/stack: fix 'pointer-sign' warning

Title changed to "stack: fix sign of list length" (it does not belong to EAL) 18/06/2019 17:43, Eads, Gage: > > clang raise 'pointer-sign' warnings in __atomic_compare_exchange when > > passing 'uint64_t *' to parameter of type 'int64_t *' converts between > > pointers to integer types with differ

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix 32-bit build

On 6/27/2019 4:10 PM, Ali Alnubani wrote: > This is to fix the error: > ``` > drivers/net/mlx5/mlx5_defs.h:14:26: error: format '%lx' expects argument > of type 'long unsigned int', but argument 5 has type 'off_t {aka long > long int}' [-Werror=format=] >#define MLX5_DRIVER_NAME "net_ml

[dpdk-dev] [RFC PATCH v1] regexdev: introduce regexdev subsystem

From: Jerin Jacob Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. The Doxygen generated RFC API documentation ava

Re: [dpdk-dev] [PATCH] drivers/net/nfb: add timestamp support

On 6/13/2019 1:05 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > This patch adds timestamping support to nfb driver. > > Signed-off-by: Rastislav Cernay > --- > config/common_base | 1 + > doc/guides/nics/nfb.rst | 22 ++ > drivers/net/nfb/Makefile

Re: [dpdk-dev] [dpdk-announce] DPDK development process and tools survey

Howdy, Thank you for all those who took the survey, there were 59 responses finally. Thank you for being patient as well to hear the results. Short summary: Out of the 59 responses, majority voted to show confidence in the current process. This means there will not be a second survey. Ho

Re: [dpdk-dev] [PATCH 0/4] lacp rx/tx handlers fixes for bonding pmd

On 6/27/19 4:08 AM, Ferruh Yigit wrote: > On 4/10/2019 1:53 PM, David Marchand wrote: >> Another series with focus on the fast/normal rx/tx handlers for 802.3ad. >> >> The first two patches make sure that the rx (resp. tx) fast and normal >> handlers are equivalent. >> >> The third one will most li

Re: [dpdk-dev] [PATCH] net/ena: Fix admin cq polling for 32-bit apps

On 5/29/2019 10:01 PM, David Harton wrote: > Recent modifications to admin command queue polling logic > did not support 32-bit applications. Updated the driver to > work for 32 or 64 bit applications as well as avoiding > roll-over possibility. > > Fixes: 3adcba9a89 ("net/ena: update HAL to the

Re: [dpdk-dev] [PATCH v3 00/14] Make shared memory config non-public

On Thu, 27 Jun 2019 12:38:55 +0100 Anatoly Burakov wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > A lot of the patchset is a search-and-replace job and should > be pretty easy to review. The rest are pre

Re: [dpdk-dev] [PATCH v2] kernel/linux: fix modules install path

11/06/2019 12:11, Bruce Richardson: > On Tue, Jun 11, 2019 at 11:49:34AM +0300, Igor Ryzhov wrote: > > Currently kernel modules are installed into /usr/src instead of > > /lib/modules when meson build system is used. This patch fixes that. > > > > Signed-off-by: Igor Ryzhov > > --- > > v2 - don't

Re: [dpdk-dev] [PATCH v3 0/8] raw/ioat: driver for Intel QuickData Technology

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, June 27, 2019 11:41 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; jer...@marvell.com; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH v3 0/8] raw/ioat: driver for Intel QuickD

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix encapsulation markers for inner L3 offset

On 6/24/2019 12:35 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Malov >> Sent: Friday, May 24, 2019 3:57 PM >> To: Olivier Matz >> Cc: dev@dpdk.org; Kulasek, TomaszX ; >> sta...@dpdk.org >> Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] kernel/freebsd: fix module build on latest head

06/06/2019 17:40, Bruce Richardson: > Internal changes in the freebsd kernel have meant that additional includes > are now necessary to build the kernel modules for DPDK. Tested with latest > bsd HEAD revision. > > Bugzilla ID: 282 > Cc: sta...@dpdk.org > > Signed-off-by: Bruce Richardson Appli

Re: [dpdk-dev] [PATCH] net/mlx5: fix 32-bit build

On Thu, 27 Jun 2019 18:10:07 +0300 Ali Alnubani wrote: > + DRV_LOG(DEBUG, "port %u: uar_mmap_offset 0x%"PRIx64"", Minor nitpick: You don't need empty string at the end of the format.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal/linux: fix return after alarm registration failure

27/06/2019 01:09, Stephen Hemminger: > On Wed, 26 Jun 2019 16:02:34 +0200 > Thomas Monjalon wrote: > > > When adding an alarm, if an error happen when registering > > the common alarm callback, it is not considered as a major failure. > > The alarm is then inserted in the list. > > However it was

Re: [dpdk-dev] [PATCH] app/testpmd: add warning message when user sets rxq greater than txq

On 5/2/2019 4:44 PM, Herakliusz Lipiec wrote: > add a warning message when user sets port config all rxq value larger > than txq in interactive mode. > > Signed-off-by: Herakliusz Lipiec Hi Hero, Can you please give some context that why we need this check? What is broken without this check?

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

On Thu, 27 Jun 2019 17:37:49 +0800 Ruifeng Wang wrote: > Tests showed that the function inlining caused performance drop > on some x86 platforms with the memory ordering patches applied. > By force no-inline functions, the performance was better than > before on x86 and no impact to arm64 platfor

[dpdk-dev] [PATCH] net/mlx5: fix 32-bit build

This is to fix the error: ``` drivers/net/mlx5/mlx5_defs.h:14:26: error: format '%lx' expects argument of type 'long unsigned int', but argument 5 has type 'off_t {aka long long int}' [-Werror=format=] #define MLX5_DRIVER_NAME "net_mlx5" ^ RTE_SDK/i686-nativ

Re: [dpdk-dev] [PATCH v2] eal: correct error log for alarm

05/06/2019 09:31, David Marchand: > On Wed, Jun 5, 2019 at 9:28 AM Xiaolong Ye wrote: > > > Fixes: af75078fece3 ("first public release") > > Fixes: 764bf26873b9 ("add FreeBSD support") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Xiaolong Ye > > > Reviewed-by: David Marchand Applied, thanks

[dpdk-dev] [Bug 298] BPF: eval_call() is messing bounds of return types different of RTE_BPF_ARG_RAW

https://bugs.dpdk.org/show_bug.cgi?id=298 Bug ID: 298 Summary: BPF: eval_call() is messing bounds of return types different of RTE_BPF_ARG_RAW Product: DPDK Version: 19.08 Hardware: All OS: All S

Re: [dpdk-dev] [PATCH] app/test-compress-perf: report header improvement

> -Original Message- > From: Trybula, ArturX > Sent: Thursday, June 27, 2019 5:17 PM > To: Shally Verma ; dev@dpdk.org; Trahe, Fiona > ; Dybkowski, AdamX > > Subject: [EXT] RE: [dpdk-dev] [PATCH] app/test-compress-perf: report > header improvement > > External Email > > --

Re: [dpdk-dev] [PATCH v6 00/15] A new net PMD - hinic

On 6/27/2019 9:10 AM, Ziyang Xuan wrote: > This patch set adds support of a new net PMD > for Huawei Intelligent nic. This patch provides supoort > for basic RX/TX and the contorl path needed for it. > Later on new features will be added like VLAN, VFs, etc. > > Basic features: > 1. Basic device o

Re: [dpdk-dev] [PATCH v2 1/2] lib/crypto: add callback handlers for crypto

Hi Vipin, > > Add callback handlers for enqueue-dequeue operation on crypto > device. The pre-enqueue and post-dequeue are selected on invoke > user registered callback functions. > > Use cases: > - allow user to investigate the contents pre-enqueue. > - allow user to investigate the contents

Re: [dpdk-dev] [PATCH] cryptodev: free memzone when releasing cryptodev

> > When a cryptodev is created in a primary process, > rte_cryptodev_data_alloc reserves a memzone. > However, this memzone was not released when the cryptodev > is uninitialized. After that, new cryptodev cannot be > created due to memzone name conflict. > > This commit frees the memzone when a

[dpdk-dev] [PATCH v2] doc: add search feature to API doc page

I modified the API config file to incorperate a search button into the API documentation page. Signed-off-by: A.McLoughlin --- V2: Adding description for patch --- doc/api/doxy-api.conf.in | 2 +- mk/rte.sdkdoc.mk | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/do

[dpdk-dev] [PATCH] doc: add search feature to API doc page

Signed-off-by: A.McLoughlin --- doc/api/doxy-api.conf.in | 2 +- mk/rte.sdkdoc.mk | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index 1fa064b36..908cee8f7 100644 --- a/doc/api/doxy-api.conf.in +++ b/doc/api/doxy-ap

  1   2   3   >