Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-06-28 Thread David Marchand
On Sat, Jun 29, 2019 at 7:57 AM David Marchand wrote: > On Fri, Jun 28, 2019 at 9:20 PM David Marchand > wrote: > >> >> On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon >> wrote: >> >>> 27/06/2019 13:33, David Marchand: >>> > We had some inconsistencies between functions prototypes and actual >>

Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 9:20 PM David Marchand wrote: > > On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon > wrote: > >> 27/06/2019 13:33, David Marchand: >> > We had some inconsistencies between functions prototypes and actual >> > definitions. >> > Let's avoid this by only adding the experiment

Re: [dpdk-dev] [PATCH v3 3/3] eal/stack: enable lock-free stack for aarch64

2019-06-28 Thread Eads, Gage
> Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. > > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > Tested-by: Honnappa Nagarahalli Acked-by: Gage Eads Thanks, Gage

Re: [dpdk-dev] [PATCH v3 2/3] test/atomic: add 128b compare and swap test

2019-06-28 Thread Eads, Gage
> Add 128b atomic compare and swap test for aarch64 and x86_64. > > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli Acked-by: Gage Eads

Re: [dpdk-dev] [PATCH v3 6/8] raw/ioat: add configure, start and stop functions

2019-06-28 Thread Bruce Richardson
On Thu, Jun 27, 2019 at 05:37:33PM +0100, Pattan, Reshma wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, June 27, 2019 11:41 AM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net; jer...@marvell.com; Richardson,

Re: [dpdk-dev] [PATCH v3 5/8] raw/ioat: add device info function

2019-06-28 Thread Bruce Richardson
On Thu, Jun 27, 2019 at 01:16:01PM +0100, Burakov, Anatoly wrote: > On 27-Jun-19 11:40 AM, Bruce Richardson wrote: > > Add in the "info_get" function to the driver, to allow us to query the > > device. This allows us to have the unit test pick up the presence of > > supported hardware or not. > >

[dpdk-dev] [PATCH] eal: use 32-bit RDSEED to allow 32-bit x86 usage

2019-06-28 Thread Mattias Rönnblom
When seeding the pseudo-random number generator, replace the 64-bit RDSEED with two 32-bit RDSEED instructions to allow building and running on 32-bit x86. Fixes: faf8fd252785 ("eal: improve entropy for initial PRNG seed") Reported-by: Ferruh Yigit Signed-off-by: Mattias Rönnblom --- lib/librt

Re: [dpdk-dev] [PATCH v4 3/5] eal: improve entropy for initial PRNG seed

2019-06-28 Thread Mattias Rönnblom
On 2019-06-28 21:01, Ferruh Yigit wrote: On 6/28/2019 10:01 AM, Mattias Rönnblom wrote: Replace the use of rte_get_timer_cycles() with getentropy() for seeding the pseudo-random number generator. getentropy() provides a more truly random value. getentropy() requires glibc 2.25 and Linux kernel

Re: [dpdk-dev] [PATCH 0/9] experimental tags fixes

2019-06-28 Thread Neil Horman
On Thu, Jun 27, 2019 at 01:33:46PM +0200, David Marchand wrote: > Here is a new series on __rte_experimental tags. > > Following the build error reported by Aaron [1], I noticed that some > experimental functions could go unnoticed because of a gcc peculiarity. > > To catch those, I went and adde

Re: [dpdk-dev] [PATCH] devtools: return error on failure

2019-06-28 Thread Bruce Richardson
On Fri, Jun 28, 2019 at 09:27:47AM -0700, Stephen Hemminger wrote: > On Tue, 25 Jun 2019 18:01:06 +0100 > Ferruh Yigit wrote: > > > Currently script is always returning success, returning failure on error > > helps on using script on automation tools. > > > > Signed-off-by: Ferruh Yigit > > Lo

Re: [dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil wrote: > Rather than prefixing the return type of function prototypes with > __rte_experimental, move it to a separate line to enhance readability. > > Except for checkpatches.sh, this patch was automatically generated by: > > sed -i \ > -e '

Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 5:57 PM Thomas Monjalon wrote: > 27/06/2019 13:33, David Marchand: > > We had some inconsistencies between functions prototypes and actual > > definitions. > > Let's avoid this by only adding the experimental tag to the prototypes. > > Tests with gcc and clang show it is e

[dpdk-dev] [PATCH v2] cryptodev: free memzone when releasing cryptodev

2019-06-28 Thread Junxiao Shi
When a cryptodev is created in a primary process, rte_cryptodev_data_alloc reserves a memzone. However, this memzone was not released when the cryptodev is uninitialized. After that, new cryptodev cannot be created due to memzone name conflict. This commit frees the memzone when a cryptodev is uni

Re: [dpdk-dev] [PATCH] examples/flow_filtering: remove out-of-date comment

2019-06-28 Thread Ferruh Yigit
On 6/23/2019 6:22 AM, Ori Kam wrote: > > >> -Original Message- >> From: Xiaolong Ye >> Sent: Tuesday, June 18, 2019 4:46 PM >> To: Ferruh Yigit ; Marko Kovacevic >> ; Ori Kam ; Bruce >> Richardson ; Pablo de Lara >> ; Radu Nicolau ; >> Akhil Goyal ; Tomasz Kantecki >> >> Cc: dev@dpdk.or

Re: [dpdk-dev] [PATCH v4 3/5] eal: improve entropy for initial PRNG seed

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 10:01 AM, Mattias Rönnblom wrote: > Replace the use of rte_get_timer_cycles() with getentropy() for > seeding the pseudo-random number generator. getentropy() provides a > more truly random value. > > getentropy() requires glibc 2.25 and Linux kernel 3.17. In case > getentropy() is no

Re: [dpdk-dev] [PATCH v3 1/2] test/rcu: increase the size of num cores variable

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 8:44 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > num_cores is of type uint8_t. This results in the following > compilation error. > > test_rcu_qsbr_perf.c:649:16: error: comparison is always false > due to limited range of data type [-Werror=type-limits

Re: [dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position

2019-06-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, June 25, 2019 2:15 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; honnappa.nagaraha...@arm.com >Cc: gavin...@arm.com; ruifeng.w...@arm.com; dev@dp

[dpdk-dev] [PATCH v3 2/2] test/rcu: address test case failure

2019-06-28 Thread Honnappa Nagarahalli
Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Rui

[dpdk-dev] [PATCH v3 1/2] test/rcu: increase the size of num cores variable

2019-06-28 Thread Honnappa Nagarahalli
num_cores is of type uint8_t. This results in the following compilation error. test_rcu_qsbr_perf.c:649:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (num_cores >= RTE_MAX_LCORE) { ^~ RTE_MAX_LCORE is set to 256 for armv8 config

Re: [dpdk-dev] [PATCH 2/3] lib/hash: load pData after full key compare

2019-06-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, June 25, 2019 2:15 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; honnappa.nagaraha...@arm.com >Cc: gavin...@arm.com; ruifeng.w...@arm.com; dev@dp

[dpdk-dev] [PATCH v3 40/42] event/octeontx2: add even timer adapter start and stop

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer adapter start and stop functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 66 1 file changed, 66 insertions(+) diff --git a/drivers/event/octeontx2/otx2_tim_evdev.c b/drivers/event/octeontx2/

[dpdk-dev] [PATCH v3 41/42] event/octeontx2: add devargs to limit timer adapters

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs to limit the max number of TIM rings reserved on probe. Since, TIM rings are HW resources we can avoid starving other applications by not grabbing all the rings. Example: --dev "0002:0e:00.0,tim_rings_lmt=2" Signed-off-by: Pavan Nikhilesh --- doc/guid

Re: [dpdk-dev] [PATCH v3] net/memif: multi-process support

2019-06-28 Thread Ferruh Yigit
On 6/25/2019 11:26 AM, Burakov, Anatoly wrote: > On 25-Jun-19 11:05 AM, Jakub Grajciar wrote: >> Multi-process support for memif PMD. >> Primary process handles connection establishment. >> Secondary process queries for memory regions. >> >> Signed-off-by: Jakub Grajciar >> --- > > Acked-by: Anat

[dpdk-dev] [PATCH v3 38/42] event/octeontx2: add event timer cancel function

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add function to cancel event timer that has been armed. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 1 + drivers/event/octeontx2/otx2_tim_evdev.h | 4 +++ drivers/event/octeontx2/otx2_tim_worker.c | 29 ++ drivers/even

[dpdk-dev] [PATCH v3 39/42] event/octeontx2: add event timer stats get and reset

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer adapter statistics get and reset functions. Stats are disabled by default and can be enabled through devargs. Example: --dev "0002:0e:00.0,tim_stats_ena=1" Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst| 8 +++ driv

[dpdk-dev] [PATCH v3 42/42] event/octeontx2: add devargs to control adapter parameters

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs to control each event timer adapter i.e. TIM rings internal parameters uniquely. The following dict format is expected [ring-chnk_slots-disable_npa-stats_ena]. 0 represents default values. Example: --dev "0002:0e:00.0,tim_ring_ctl=[2-1023-1-0]" Signed-o

[dpdk-dev] [PATCH v3 33/42] event/octeontx2: allow adapters to resize inflight buffers

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add internal SSO functions to allow event adapters to resize SSO buffers that are used to hold in-flight events in DRAM. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build| 1 + drivers/event/

[dpdk-dev] [PATCH v3 37/42] event/octeontx2: add event timer arm timeout burst

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm timeout burst function. All the timers requested to be armed have the same timeout. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 9 +++ drivers/event/octeontx2/otx2_tim_evdev.h | 16 drivers/event/octeontx2/otx2

[dpdk-dev] [PATCH v3 35/42] event/octeontx2: add TIM bucket operations

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM bucket operations used for event timer arm and cancel. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build | 1 + drivers/event/octeontx2/otx2_tim_evdev.h | 36 +++ drivers/event/o

[dpdk-dev] [PATCH v3 34/42] event/octeontx2: add timer adapter info get function

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM event timer adapter info get function. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/octeontx2/otx2_tim_evdev.c b/drivers/event/octeontx2/otx2_tim_evdev

[dpdk-dev] [PATCH v3 36/42] event/octeontx2: add event timer arm routine

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm routine. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 20 +++ drivers/event/octeontx2/otx2_tim_evdev.h | 33 drivers/event/octeontx2/otx2_tim_worker.c | 77 drivers/event/octeontx2/otx2_tim_worker.h |

[dpdk-dev] [PATCH v3 32/42] event/octeontx2: add TIM IRQ handlers

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Register and implement TIM IRQ handlers for error interrupts Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev_irq.c | 97 drivers/event/octeontx2/otx2_tim_evdev.c | 37 + drivers/event/octeontx2/otx2_tim_evdev.h | 14 +

[dpdk-dev] [PATCH v3 28/42] event/octeontx2: create and free timer adapter

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh When the application calls timer adapter create the following is used: - Allocate a TIM lf based on number of lf's provisioned. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate

[dpdk-dev] [PATCH v3 27/42] event/octeontx2: add timer adapter capabilities

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add function to retrieve event timer adapter capabilities. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 2 ++ drivers/event/octeontx2/otx2_tim_evdev.c | 19 +++ drivers/event/octeontx2/otx2_tim_evdev.h | 5 + 3 files

[dpdk-dev] [PATCH v3 30/42] event/octeontx2: add devargs to disable NPA

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh If the chunks are allocated from NPA then TIM can automatically free them when traversing the list of chunks. Add devargs to disable NPA and use software mempool to manage chunks. Example: --dev "0002:0e:00.0,tim_disable_npa=1" Signed-off-by: Pavan Nikhilesh ---

[dpdk-dev] [PATCH v3 31/42] event/octeontx2: add devargs to modify chunk slots

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs support to modify number of chunk slots. Chunks are used to store event timers, a chunk can be visualised as an array where the last element points to the next chunk and rest of them are used to store events. TIM traverses the list of chunks and enqueues the even

[dpdk-dev] [PATCH v3 29/42] event/octeontx2: allow TIM to optimize config

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Allow TIM to optimize user supplied configuration based on RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES flag. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 1 + drivers/event/octeontx2/otx2_tim_evdev.c | 62 +++- drivers/event/

[dpdk-dev] [PATCH v3 25/42] event/octeontx2: add SSO selftest

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add selftest to verify sanity of SSO. Can be run by passing devargs to SSO PF as follows: --dev "0002:0e:00.0,selftest=1" Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- app/test/test_eventdev.c |8 + doc/guides/eventdevs/o

[dpdk-dev] [PATCH v3 26/42] event/octeontx2: add event timer support

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer adapter aka TIM initilization on SSO probe. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst | 6 ++ drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build | 1 + drivers/event/octeontx2/otx2_

[dpdk-dev] [PATCH v3 24/42] event/octeontx2: add device stop and close functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event device stop and close callback functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 39 1 file changed, 39 insertions(+) diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/octeontx2/ot

[dpdk-dev] [PATCH v3 23/42] event/octeontx2: add devargs to control SSO GGRP QoS

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh SSO GGRPs i.e. queue uses DRAM & SRAM buffers to hold in-flight events. By default the buffers are assigned to the SSO GGRPs to satisfy minimum HW requirements. SSO is free to assign the remaining buffers to GGRPs based on a preconfigured threshold. We can control the QoS of

[dpdk-dev] [PATCH v3 22/42] event/octeontx2: add device start function

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add eventdev start function along with few cleanup API's to maintain sanity. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 127 +- drivers/event/octeontx2/otx2_evdev.h | 6 ++ drivers/event/octeontx2/otx2_worker.c |

[dpdk-dev] [PATCH v3 20/42] event/octeontx2: add worker dual GWS dequeue functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add workder dual workslot mode dequeue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 9 +++ drivers/event/octeontx2/otx2_worker_dual.c | 66 ++ 2 files changed, 75 insertions(+) diff --git a/drivers/event/

[dpdk-dev] [PATCH v3 21/42] event/octeontx2: add devargs to force legacy mode

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Octeontx2 SSO by default is set to use dual workslot mode. Add devargs option to force legacy mode i.e. single workslot mode. Example: --dev "0002:0e:00.0,single_ws=1" Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/octeontx2.rst | 8 drivers/e

[dpdk-dev] [PATCH v3 19/42] event/octeontx2: add worker dual GWS enqueue functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add dual workslot mode event enqueue functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- drivers/event/octeontx2/otx2_evdev.h | 9 ++ drivers/event/octeontx2/otx2_worker_dual.c | 135 + 2 files changed, 144 insertions(+)

[dpdk-dev] [PATCH v3 18/42] event/octeontx2: add SSO dual GWS HW device operations

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO dual workslot mode GWS HW device operations. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build| 1 + drivers/event/octeontx2/otx2_worker_dual.c | 6 ++ dr

[dpdk-dev] [PATCH v3 17/42] event/octeontx2: add octeontx2 SSO dual workslot mode

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh OcteonTx2 AP core SSO cache contains two entires each entry caches state of an single GWS aka event port. AP core requests events from SSO by using following sequence : 1. Write to SSOW_LF_GWS_OP_GET_WORK 2. Wait for SSO to complete scheduling by polling on SSOW_LF_GWS_TAG[6

[dpdk-dev] [PATCH v3 15/42] event/octeontx2: add worker enqueue functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add worker event enqueue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 8 ++ drivers/event/octeontx2/otx2_worker.c | 136 ++ 2 files changed, 144 insertions(+) diff --git a/drivers/event/octeontx2/otx2_evd

[dpdk-dev] [PATCH v3 16/42] event/octeontx2: add worker dequeue functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add worker event dequeue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 10 + drivers/event/octeontx2/otx2_worker.c | 55 +++ 2 files changed, 65 insertions(+) diff --git a/drivers/event/octeontx2/otx2_ev

[dpdk-dev] [PATCH v3 14/42] event/octeontx2: add SSO HW device operations

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HW device operations used for enqueue/dequeue. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build | 3 +- drivers/event/octeontx2/otx2_evdev.h | 22 +++ drivers/ev

[dpdk-dev] [PATCH v3 12/42] event/octeontx2: add register dump functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS and GGRP register dump function to aid debugging. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 68 1 file changed, 68 insertions(+) diff --git a/drivers/event/octeontx2/otx2_evdev.c b/drivers/event/oc

[dpdk-dev] [PATCH v3 13/42] event/octeontx2: add xstats support

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving statistics from SSO GWS and GGRP. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob Signed-off-by: Nithin Dabilpuram --- drivers/event/octeontx2/otx2_evdev.c | 5 + drivers/event/octeontx2/otx2_evdev_stats.h | 242 +

[dpdk-dev] [PATCH v3 08/42] event/octeontx2: add event port config functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add default config, setup and release functions for event ports i.e. SSO GWS. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 110 ++- drivers/event/octeontx2/otx2_evdev.h | 59 ++ 2 files changed, 168 inserti

[dpdk-dev] [PATCH v3 11/42] event/octeontx2: add SSO GWS and GGRP IRQ handlers

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Register and implement SSO GWS and GGRP IRQ handlers for error interrupts. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- drivers/event/octeontx2/Makefile | 1 + drivers/event/octeontx2/meson.build | 4 +- drivers/event/octeontx2/otx2_evde

[dpdk-dev] [PATCH v3 10/42] event/octeontx2: support dequeue timeout tick conversion

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add function to convert dequeue timeout from ns to ticks. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 11 +++ drivers/event/octeontx2/otx2_evdev.h | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/event/octeontx2/otx2_ev

[dpdk-dev] [PATCH v3 09/42] event/octeontx2: support linking queues to ports

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Links between queues and ports are controlled by setting/clearing GGRP membership in SSOW_LF_GWS_GRPMSK_CHG. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 73 1 file changed, 73 insertions(+) diff --git a/drivers/e

[dpdk-dev] [PATCH v3 07/42] event/octeontx2: add devargs for inflight buffer count

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh The number of events for a *open system* event device is specified as -1 as per the eventdev specification. Since, Octeontx2 SSO inflight events are only limited by DRAM size, the xae_cnt devargs parameter is introduced to provide upper limit for in-flight events. Example:

[dpdk-dev] [PATCH v3 06/42] event/octeontx2: allocate event inflight buffers

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Allocate buffers in DRAM that hold inflight events. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/Makefile | 2 +- drivers/event/octeontx2/otx2_evdev.c | 116 ++- drivers/event/octeontx2/otx2_evdev.h | 8 ++ 3 files changed, 12

[dpdk-dev] [PATCH v3 05/42] event/octeontx2: add event queue config functions

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add default config, setup and release functions for event queues i.e. SSO GGRPS. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 50 drivers/event/octeontx2/otx2_evdev.h | 17 ++ 2 files changed, 67 insertions

[dpdk-dev] [PATCH v3 04/42] event/octeontx2: add device configure function

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add the device configure function that attaches the requested number of SSO GWS(event ports) and GGRP(event queues) LF's to the PF. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 258 +++ drivers/event/octeontx2/otx2_evde

[dpdk-dev] [PATCH v3 03/42] event/octeontx2: add device capabilities function

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add the info_get function to return details on the queues, flow, prioritization capabilities, etc. which this device has. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.c | 31 1 file changed, 31 insertions(+) diff --gi

[dpdk-dev] [PATCH v3 01/42] event/octeontx2: add build infra and device probe

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh Add the make and meson based build infrastructure along with the eventdev(SSO) device probe. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- MAINTAINERS | 6 ++ config/common_base

[dpdk-dev] [PATCH v3 02/42] event/octeontx2: add init and fini for octeontx2 SSO object

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh SSO object needs to be initialized to communicate with the kernel AF driver through mbox using the common API's. Also, initialize the internal eventdev structure to defaults. Attach NPA lf to the PF if needed. Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh Sign

[dpdk-dev] [PATCH v3 00/42] OCTEONTX2 event device driver

2019-06-28 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds OCTEON TX2 event device driver and event timer adapter driver. More details can be found in under doc/guides/eventdevs/octeontx2 v3 Changes: - Organize config flags. - Merge doc into appropriate patches. v2 Changes: - Add tim finit to teardown on exit.

Re: [dpdk-dev] [PATCH 1/3] lib/hash: use ordered loads only if signature matches

2019-06-28 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Tuesday, June 25, 2019 2:15 PM >To: Wang, Yipeng1 ; Gobriel, Sameh >; Richardson, Bruce >; De Lara Guarch, Pablo >; honnappa.nagaraha...@arm.com >Cc: gavin...@arm.com; ruifeng.w...@arm.com; dev@dp

Re: [dpdk-dev] [PATCH v4] net/af_xdp: support need wakeup feature

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 11:07 AM, Xiaolong Ye wrote: > This patch enables need_wakeup flag for Tx and fill rings, when this flag > is set by the driver, it means that the userspace application has to > explicitly wake up the kernel Rx or kernel Tx processing by issuing a > syscall. Poll() can wake up both and

Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

2019-06-28 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Friday, June 28, 2019 5:11 PM > To: Trahe, Fiona ; Akhil Goyal ; > Kusztal, ArkadiuszX > ; dev@dpdk.org > Subject: RE: [PATCH] cryptodev: extend api of asymmetric crypto by sessionless > > Hi Finoa,

Re: [dpdk-dev] [PATCH v2 1/2] test/rcu: increase the size of num cores variable

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 6:36 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > num_cores is of type uint8_t. This results in the following > compilation error. > > test_rcu_qsbr_perf.c:649:16: error: comparison is always false > due to limited range of data type [-Werror=type-limits

Re: [dpdk-dev] [EXT] [PATCH 1/3] cryptodev: rework api of rsa algorithm

2019-06-28 Thread Trahe, Fiona
Hi Arek, Shally, Comments below. @Arek, I'd suggest sending a v2 after this, updated with whatever issues can be closed and a listing of the issues still open. As getting hard to follow the thread. @Shally, can you reply please - just with whatever items below you're ok with, so Arek can do the

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 6:37 PM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli < > honnappa.nagaraha...@arm.com> wrote: > Test case for rte_rcu_qsbr_get_memsize is written specifically > for 12

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable

2019-06-28 Thread Honnappa Nagarahalli
> > 28/06/2019 11:09, David Marchand: > > On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli > > > --- a/app/test/test_rcu_qsbr.c > > > +++ b/app/test/test_rcu_qsbr.c > > > @@ -27,7 +27,7 @@ > > > #define TEST_RCU_QSBR_CNT_INIT 1 > > > > > > uint16_t enabled_core_ids[RTE_MAX_LCORE]; -uint8_t n

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] test/rcu: address test case failure

2019-06-28 Thread Honnappa Nagarahalli
On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli mailto:honnappa.nagaraha...@arm.com>> wrote: Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Does it mean this test can only work on arm with 2

[dpdk-dev] [PATCH v2 2/2] test/rcu: address test case failure

2019-06-28 Thread Honnappa Nagarahalli
Test case for rte_rcu_qsbr_get_memsize is written specifically for 128 threads. Do not use RTE_MAX_LCORE as it changes for different configurations. Fixes: e6a14121f4ae ("test/rcu: remove arbitrary limit on max core count") Cc: sta...@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Rui

[dpdk-dev] [PATCH v2 1/2] test/rcu: increase the size of num cores variable

2019-06-28 Thread Honnappa Nagarahalli
num_cores is of type uint8_t. This results in the following compilation error. test_rcu_qsbr_perf.c:649:16: error: comparison is always false due to limited range of data type [-Werror=type-limits] if (num_cores >= RTE_MAX_LCORE) { ^~ RTE_MAX_LCORE is set to 256 for armv8 config

Re: [dpdk-dev] [PATCH] devtools: return error on failure

2019-06-28 Thread Stephen Hemminger
On Tue, 25 Jun 2019 18:01:06 +0100 Ferruh Yigit wrote: > Currently script is always returning success, returning failure on error > helps on using script on automation tools. > > Signed-off-by: Ferruh Yigit Looks good, but maybe this script is getting complex enough that it should be python?

Re: [dpdk-dev] [PATCH 1/9] eal: hide internal hotplug symbol

2019-06-28 Thread Stephen Hemminger
On Thu, 27 Jun 2019 13:33:47 +0200 David Marchand wrote: > This api was experimental and not properly marked in the map file. > But looking more closely, this is just an internal wrapper for EAL init. > Hide it in the hotplug code. > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process")

Re: [dpdk-dev] [PATCH 3/9] vfio: remove incorrect experimental tag

2019-06-28 Thread Stephen Hemminger
On Thu, 27 Jun 2019 13:33:49 +0200 David Marchand wrote: > The incriminated commit promoted this symbol as stable but the > definition still has the tag. > > Fixes: 787ae736a3d9 ("vfio: remove experimental tag") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Stephen H

Re: [dpdk-dev] [PATCH v3] net: fix the way how L4 checksum choice is tested

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 11:47 AM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Ivan Malov [mailto:ivan.ma...@oktetlabs.ru] >> Sent: Friday, June 28, 2019 4:13 AM >> To: Olivier Matz >> Cc: dev@dpdk.org; Ananyev, Konstantin ; Andrew >> Rybchenko ; Stephen >> Hemminger ; Kulasek, To

Re: [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 5:57 PM Adrien Mazarguil wrote: > Its presence on the function prototype in the header file is enough. > > Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound") > Cc: Mattias Rönnblom > > Signed-off-by: Adrien Mazarguil > --- > lib/librte_eal/common/r

Re: [dpdk-dev] [PATCH 2/9] devargs: remove incorrect experimental tags

2019-06-28 Thread Stephen Hemminger
On Thu, 27 Jun 2019 13:33:48 +0200 David Marchand wrote: > The incriminated commit promoted those symbols as stable but the > prototypes still have the tag. > > Fixes: 73eca2f77f4c ("devargs: promote experimental API as stable") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Acked-by

Re: [dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release

2019-06-28 Thread Bruce Richardson
On Thu, Jun 27, 2019 at 01:09:03PM +0100, Burakov, Anatoly wrote: > On 27-Jun-19 11:40 AM, Bruce Richardson wrote: > > Add the create/destroy driver functions so that we can actually allocate > > a rawdev and destroy it when done. No rawdev API functions are actually > > implemented at this point.

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: add actions to modify TCP header fields

2019-06-28 Thread Adrien Mazarguil
On Thu, Jun 27, 2019 at 08:54:57PM +0300, Andrew Rybchenko wrote: > On 6/27/19 8:39 PM, Dekel Peled wrote: > > Add actions: > > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > > - INC_TCP_ACK - Increas

Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

2019-06-28 Thread Shally Verma
Hi Finoa, Akhil > -Original Message- > From: Trahe, Fiona > Sent: Thursday, June 27, 2019 5:25 PM > To: Akhil Goyal ; Kusztal, ArkadiuszX > ; dev@dpdk.org; Shally Verma > > Cc: Trahe, Fiona > Subject: [EXT] RE: [PATCH] cryptodev: extend api of asymmetric crypto by > sessionless > > Ext

Re: [dpdk-dev] [PATCH] maintainers: update for szedata2 PMD

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 4:24 PM, Jan Remeš wrote: > Rastislav will co-maintain the szedata2 PMD with me. > > Signed-off-by: Jan Remes Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag

2019-06-28 Thread Stephen Hemminger
On Fri, 28 Jun 2019 17:56:34 +0200 Adrien Mazarguil wrote: > Its presence on the function prototype in the header file is enough. > > Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound") > Cc: Mattias Rönnblom > > Signed-off-by: Adrien Mazarguil > --- > lib/librte_eal/com

[dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag

2019-06-28 Thread Adrien Mazarguil
Its presence on the function prototype in the header file is enough. Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound") Cc: Mattias Rönnblom Signed-off-by: Adrien Mazarguil --- lib/librte_eal/common/rte_random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH 2/2] Fix __rte_experimental clutter

2019-06-28 Thread Adrien Mazarguil
Rather than prefixing the return type of function prototypes with __rte_experimental, move it to a separate line to enhance readability. Except for checkpatches.sh, this patch was automatically generated by: sed -i \ -e '/^\([^#].*\)\?__rte_experimental */{' \ -e 's//\1/; s/ *$//; i\'

[dpdk-dev] [PATCH 0/2] Fix remaining issues with __rte_experimental

2019-06-28 Thread Adrien Mazarguil
This is a follow-up series to David's [1], addressing one remaining minor issue and moving __rte_experimental on its own line where it belongs. [1] "[PATCH 0/9] experimental tags fixes" https://mails.dpdk.org/archives/dev/2019-June/136009.html Adrien Mazarguil (2): eal: fix duplicate experi

Re: [dpdk-dev] [PATCH 8/9] remove experimental tags from all symbol definitions

2019-06-28 Thread Thomas Monjalon
27/06/2019 13:33, David Marchand: > We had some inconsistencies between functions prototypes and actual > definitions. > Let's avoid this by only adding the experimental tag to the prototypes. > Tests with gcc and clang show it is enough. > > git grep -l __rte_experimental |grep \.c$ |while read f

Re: [dpdk-dev] [PATCH] net/ena: Fix admin cq polling for 32-bit apps

2019-06-28 Thread David Harton (dharton)
> -Original Message- > From: Michał Krawczyk > Sent: Friday, June 28, 2019 11:03 AM > To: David Harton (dharton) > Cc: dev@dpdk.org; Marcin Wojtas ; Tzalik, Guy > ; Schmeilin, Evgeny > Subject: Re: [PATCH] net/ena: Fix admin cq polling for 32-bit apps > > Hi, > > sorry for the late r

Re: [dpdk-dev] [dpdk-users] Unable to Forward the Packet after UDP Payload Modification

2019-06-28 Thread Stephen Hemminger
On Thu, 27 Jun 2019 23:00:35 +0530 satyavalli rama wrote: > Hi > > > With Scapy we are sending UDP Packets to ‘P0’ of DPDK - VM -1 as below > > >>>sendp(Ether(src="52:00:00:00:00:4a",dst="50:00:00:00:00:8F")/IP(dst="20.20.20.20",proto=17)/UDP(sport=4009,dport=4019)/Raw(load=('Helllo > >>> Bash

Re: [dpdk-dev] [PATCH] net/szedata2: add Silicom Mango support

2019-06-28 Thread Ferruh Yigit
On 6/28/2019 3:08 PM, Jan Remeš wrote: > On Thu, Jun 27, 2019 at 7:49 PM Ferruh Yigit wrote: >> >> On 6/13/2019 2:01 PM, Rastislav Cernay wrote: >>> From: Rastislav Cernay >>> >>> Add support for Silicom FB2CGG3 smart NIC >>> >>> Signed-off-by: Rastislav Cernay >> >> Applied to dpdk-next-net/mas

Re: [dpdk-dev] [PATCH v3 1/3] lib/lpm: not inline unnecessary functions

2019-06-28 Thread Stephen Hemminger
On Fri, 28 Jun 2019 15:16:30 +0100 "Medvedkin, Vladimir" wrote: > Hi Honnappa, > > On 28/06/2019 14:57, Honnappa Nagarahalli wrote: > >> Hi all, > >> > >> On 28/06/2019 05:34, Stephen Hemminger wrote: > >>> On Fri, 28 Jun 2019 02:44:54 + > >>> "Ruifeng Wang (Arm Technology China)" wrote:

Re: [dpdk-dev] [PATCH 19.08 v3 1/2] net/pcap: use a struct to pass user options

2019-06-28 Thread Ferruh Yigit
On 6/14/2019 3:43 PM, Cian Ferriter wrote: > The argument lists on some of the device creation functions are quite > large. Using a struct to hold the user options parsed in > 'pmd_pcap_probe' will allow for cleaner function calls and definitions. > Adding user options will also be easier. > > Sig

[dpdk-dev] [PATCH] maintainers: update for szedata2 PMD

2019-06-28 Thread Jan Remeš
Rastislav will co-maintain the szedata2 PMD with me. Signed-off-by: Jan Remes --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bbec1982c..5a212be08 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -715,6 +715,7 @@ F: doc/guides/nics/features/netvsc

Re: [dpdk-dev] [PATCH v2 02/14] drivers: use new memory locking API

2019-06-28 Thread Yongseok Koh
> On Jun 25, 2019, at 9:05 AM, Anatoly Burakov > wrote: > > Replace usages of direct access to shared memory config with > calls to the new API. > > Signed-off-by: Anatoly Burakov > --- > drivers/bus/fslmc/fslmc_vfio.c | 8 +++- > drivers/net/mlx4/mlx4_mr.c

Re: [dpdk-dev] [PATCH] net/ena: Fix admin cq polling for 32-bit apps

2019-06-28 Thread Michał Krawczyk
Hi, sorry for the late reply. śr., 29 maj 2019 o 23:01 David Harton napisał(a): > > Recent modifications to admin command queue polling logic > did not support 32-bit applications. Updated the driver to > work for 32 or 64 bit applications as well as avoiding > roll-over possibility. > > Fixes:

Re: [dpdk-dev] [Bug 285] rte_table unit test crashes in ipv6

2019-06-28 Thread David Marchand
On Fri, Jun 28, 2019 at 4:43 PM Pattan, Reshma wrote: > +CC; Jananee. Can someone assign Bugzilla bug to Janannee > Sure. Thanks. -- David Marchand

Re: [dpdk-dev] [Bug 285] rte_table unit test crashes in ipv6

2019-06-28 Thread Pattan, Reshma
+CC; Jananee. Can someone assign Bugzilla bug to Janannee. From: Dumitrescu, Cristian Sent: Friday, June 28, 2019 3:37 PM To: David Marchand Cc: dev ; Thomas Monjalon ; Yigit, Ferruh ; Singh, Jasvinder ; Pattan, Reshma Subject: RE: [dpdk-dev] [Bug 285] rte_table unit test crashes in ipv6 Hi

Re: [dpdk-dev] [Bug 285] rte_table unit test crashes in ipv6

2019-06-28 Thread Dumitrescu, Cristian
Hi David, Jasvinder and Reshma mentioned this is looked at by someone in our team. Reshma, can you please add the relevant person to this email and have them take ownership of this issue in Bugzilla. Thanks, Cristian From: David Marchand [mailto:david.march...@redhat.com] Sent: Friday, June 28

  1   2   3   >