[dpdk-dev] [PATCH] net/i40e: fix unexpected skip fdir setup

In i40e_flow_flush_fdir_filter, i40e_fdir_teardown is called, so i40e_fdir_setup is required to be called before create a new fdir flow. Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_flow.c | 4 ++-- 1

Re: [dpdk-dev] [PATCH v2] net/mlx5: support matching on ICMP/ICMP6

On Wed, 19-07-03, 14:14, Slava Ovsiienko wrote: > Hi, Xiaoyu > > Please, see below. > With best regards, > Slava > > > -Original Message- > > From: dev On Behalf Of Xiaoyu Min > > Sent: Tuesday, July 2, 2019 9:26 > > To: Raslan Darawsheh ; Shahaf Shuler > > ; Yongseok Koh ; John > > McNa

Re: [dpdk-dev] [PATCH v10 3/3] net/mlx5: update modify header using Direct Verbs

> -Original Message- > From: Dekel Peled > Sent: Tuesday, July 2, 2019 17:44 > To: Adrien Mazarguil ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; Slava Ovsiienko > ; arybche...@solarflare.com > Cc: dev@dpdk.org; Ori Kam >

Re: [dpdk-dev] [PATCH v10 2/3] app/testpmd: add actions to modify TCP header fields

> -Original Message- > From: Dekel Peled > Sent: Tuesday, July 2, 2019 17:44 > To: Adrien Mazarguil ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; Slava Ovsiienko > ; arybche...@solarflare.com > Cc: dev@dpdk.org; Ori Kam >

Re: [dpdk-dev] [PATCH v2] net/mlx5: support matching on ICMP/ICMP6

Hi, Xiaoyu Please, see below. With best regards, Slava > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Tuesday, July 2, 2019 9:26 > To: Raslan Darawsheh ; Shahaf Shuler > ; Yongseok Koh ; John > McNamara ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATC

[dpdk-dev] [PATCH] app/testpmd: fix to add offloads confguration for queue

When adding offloads from commandline, not only port related configuration bits should be set, but also queue related offloads configuration bits, or it will cause error. For example, test in this process for ixgbe: (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 -- -i --portmask=0x1 --port

[dpdk-dev] [PATCH] app/test-eventdev: optimize producer routine

From: Pavan Nikhilesh When using synthetic and timer event producer reduce the calls made to mempool library by using get_bulk() instead of get(). Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_common.c | 61 +++- 1 file changed, 33 insertions(+), 28 del

[dpdk-dev] [RFC PATCH] bus/pci: avoid depending on private value in kernel source

The value 40 used in VFIO_GET_REGION_ADDR() is a private value (VFIO_PCI_OFFSET_SHIFT) defined in Linux kernel source [1]. It is not part of VFIO API, and we should not depend on it. [1] https://github.com/torvalds/linux/blob/6fbc7275c7a9/drivers/vfio/pci/vfio_pci_private.h#L19 Signed-off-by: Ti

[dpdk-dev] [PATCH] net/mvneta: remove resources when port is closed

From: yuric Since 18.11, it is suggested that driver should release all its private resources at the dev_close routine. So all resources previously released in remove routine are now released at the dev_close routine, and the dev_close routine will be called in driver remove routine in order to s

[dpdk-dev] [PATCH v4 1/3] lib/lpm: memory orderings to avoid race conditions for v1604

When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v4 2/3] lib/lpm: memory orderings to avoid race conditions for v20

When a tbl8 group is getting attached to a tbl24 entry, lookup might fail even though the entry is configured in the table. For ex: consider a LPM table configured with 10.10.10.1/24. When a new entry 10.10.10.32/28 is being added, a new tbl8 group is allocated and tbl24 entry is changed to point

[dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with next hot is updated. Changed to use atomic store to update whole table entry. Suggested-by: Medvedkin Vladimir

Re: [dpdk-dev] [PATCH] app/testpmd: change port detach interface

On Tue, Jul 02, 2019 at 04:58:17PM +0100, Yigit, Ferruh wrote: > On 5/29/2019 9:16 AM, Nithin Dabilpuram wrote: > > Hi Thomas, > > > > On Mon, May 20, 2019 at 06:20:53PM +0530, Nithin Dabilpuram wrote: > >> On Fri, May 17, 2019 at 10:59:38AM +0200, Thomas Monjalon wrote: > >>> 17/05/2019 10:55, Ni

Re: [dpdk-dev] [PATCH v10 1/3] ethdev: add actions to modify TCP header fields

> -Original Message- > From: Dekel Peled > Sent: Tuesday, July 2, 2019 17:44 > To: Adrien Mazarguil ; > wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com; Yongseok Koh ; > Shahaf Shuler ; Slava Ovsiienko > ; arybche...@solarflare.com > Cc: dev@dpdk.org; Ori Kam >

[dpdk-dev] [pull-request] next-eventdev 19.08 RC1

The following changes since commit 19f3f971123429b92fbfaa5175fa29724e94c8c9: mk: fix -march for octeontx2 target (2019-07-02 23:55:35 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to 22ea5755e1f5bcd151bf99c18e6084b356d

[dpdk-dev] [PATCH] net/fm10k: fix descriptor filling in vector Tx

The shift left operation "pkt->vlan_tci << 16" gets vlan_tci extended to signed type and may cause invalid descriptor. Also the same issue for the "data_len" field. This patch fixes it by casting them to uint64_t. Fixes: 21f13c541eb0 ("fm10k: add vector Tx") Cc: sta...@dpdk.org Signed-off-by: Xia

Re: [dpdk-dev] [PATCH v5 9/9] raw/ioat: add local API to perform copies

Acked-by: Jiayu Hu > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:13 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 9/9] raw/ioat: add local API to perform copies > > Add local

Re: [dpdk-dev] [PATCH v5 8/9] raw/ioat: add statistics functions

Acked-by: Jiayu Hu > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 8/9] raw/ioat: add statistics functions > > Add stats functio

Re: [dpdk-dev] [PATCH v5 7/9] raw/ioat: add configure, start and stop functions

Acked-by: Jiayu Hu > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 7/9] raw/ioat: add configure, start and stop functions > > Al

Re: [dpdk-dev] [PATCH v5 6/9] raw/ioat: add device info function

Acked-by: Jiayu Hu > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 6/9] raw/ioat: add device info function > > Add in the "info_

Re: [dpdk-dev] [PATCH v5 5/9] raw/ioat: create device on probe and destroy on release

Acked-by: Jiayu Hu > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 5/9] raw/ioat: create device on probe and destroy on > release

Re: [dpdk-dev] [PATCH v5 3/9] usertools/dpdk-devbind.py: add support for IOAT devices

> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 3/9] usertools/dpdk-devbind.py: add support for IOAT > devices > > In order to

Re: [dpdk-dev] [PATCH v5 2/9] raw/ioat: add initial support for ioat rawdev driver

> -Original Message- > From: Richardson, Bruce > Sent: Tuesday, July 2, 2019 10:12 PM > To: dev@dpdk.org > Cc: Hu, Jiayu ; Richardson, Bruce > ; Burakov, Anatoly > ; Van Haaren, Harry > > Subject: [PATCH v5 2/9] raw/ioat: add initial support for ioat rawdev driver > > Add stubs for ioat

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

Hi Mattias, Please see inline. Thanks, Anoob > -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, July 2, 2019 11:08 PM > To: Anoob Joseph ; Thomas Monjalon > ; Bruce Richardson > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Nikhil Rao > ; Erik Gabriel Carrillo ; > Abhinanda

[dpdk-dev] [PATCH v7 11/12] net/vdev_netvsc: use common ethernet address parsing

Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/vdev_netvsc/vdev_netvsc.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index 1fcf90d7bc

[dpdk-dev] [PATCH v7 08/12] app/testpmd: use new ethernet address parser

The cmdline_parse_ether_addr does not need to be used everywhere in testpmd. Can use rte_ether_unformat_addr instead. As an added bonus it eliminates some code for copying. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline_flow.c | 5 ++--- app/test-pmd/config.c | 10 +++--- a

[dpdk-dev] [PATCH v7 10/12] net/failsafe: use common ether address parsing routine

Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_args.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c index d2e725bcea13..7

[dpdk-dev] [PATCH v7 12/12] net/memif: use common ethernet address parsing routine

Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/memif/rte_eth_memif.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index e9ddf6413597..00c9b396ab85

[dpdk-dev] [PATCH v7 09/12] net/virtio: use new ether addr parsing

Use rte_ether_unformat_addr rather than sscanf. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/

[dpdk-dev] [PATCH v7 01/12] net/rte_ether: deinline non-critical functions

Formatting Ethernet address and getting a random value are not in critical path so they should not be inlined. Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Andrew Rybchenko --- drivers/net/axgbe/Makefile | 2 +- drivers/net/memif/Makefile | 2 +- lib/lib

[dpdk-dev] [PATCH v7 03/12] ethdev: use new ethernet parsing function

Use rte_eth_unformat_addr, so that ethdev can be built and work without the cmdline library. The dependency on cmdline was an arrangement of convenience anyway. Signed-off-by: Stephen Hemminger --- lib/Makefile | 1 - lib/librte_ethdev/Makefile| 2 +- lib/librte_ethd

[dpdk-dev] [PATCH v7 07/12] net/bonding: use new ethernet address parser

The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile| 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +- 3 fil

[dpdk-dev] [PATCH v7 06/12] cmdline: use new ethernet address parser

Now that there is a version of ether_aton in rte_ether, it can be used by the cmdline ethernet address parser. Note: ether_aton_r can not be used in cmdline because the old code would accept either bytes XX:XX:XX:XX:XX:XX or words :: and we need to keep compatiablity. Signed-off-by: S

[dpdk-dev] [PATCH v7 02/12] net/ether: add function to convert string to ethernet address

Make a function that can be used in place of eth_aton_r to convert a string to rte_ether_addr. This function allows both byte (xx:xx:xx:xx:xx:xx) and word (::) format and has the same lack of error handling as the original. This also allows ethdev to no longer have a hard dependency on

[dpdk-dev] [PATCH v7 04/12] net/ether: use bitops to speedup comparison

Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++-

[dpdk-dev] [PATCH v7 05/12] net/ether: mark ethernet addresses as being 2-byte aligned

From: Bruce Richardson When including the rte_ether.h header in applications with warnings enabled, a warning was given because of the assumption of 2-byte alignment of ethernet addresses when processing them. .../include/rte_ether.h:149:2: warning: converting a packed ‘const struct ether_addr

[dpdk-dev] [PATCH v7 00/12] ether: improvements and optimizations

This is a collection of patches around the ethernet address manipulation routines in librte_net/rte_ether. v7 use rte_ether_unformat_addr in more drivers v6 add librte_net to axgbe and memif Makefile v5 reword commit messages to workaround check-log complaints v4 fix meson build rew

Re: [dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations

On Tue, 02 Jul 2019 23:37:29 +0200 Thomas Monjalon wrote: > > Stephen Hemminger (7): > > net/rte_ether: deinline non-critical functions > > net/ether: add function to convert string to ethernet address > > ethdev: use new ethernet parsing function > > net/ether: use bitops to speedup comp

Re: [dpdk-dev] [PATCH] mk: fix march for octeontx2 target

02/07/2019 17:06, jer...@marvell.com: > From: Jerin Jacob > > Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for > octeontx2 target. Since rte_cc_has_argument drops invalid > CFLAG and -mcpu=octeontx2 picks up the correct optimization, > this typo is not noticed in performance testing. >

Re: [dpdk-dev] [PATCH v6 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, July 2, 2019 5:50 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Stephen Hemminger > ; Andrew Rybchenko > > Subject: [dpdk-dev] [PATCH v6 5/8] net/ether: mark ethernet address

Re: [dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations

> Stephen Hemminger (7): > net/rte_ether: deinline non-critical functions > net/ether: add function to convert string to ethernet address > ethdev: use new ethernet parsing function > net/ether: use bitops to speedup comparison > cmdline: use new ethernet address parser > net/bonding: u

Re: [dpdk-dev] [PATCH 00/10] enhance meson summary - list disabled components

05/06/2019 22:39, Luca Boccassi: > On Wed, 2019-06-05 at 21:22 +0100, Bruce Richardson wrote: > > After using meson to configure a build, we output a brief list of all > > components that are enabled. However, of more use to most users is a > > list of what is not being enabled, so that they can lo

[dpdk-dev] [PATCH v2 0/2] lib/hash: perf improvements for lock-free

While using the rte_hash library, there are 2 sets of stores that happen. 1) The application writes its data to memory (whose address is provided in rte_hash_add_key_with_hash_data API (or NULL)) 2) The rte_hash library writes to its own internal data structures; key store entry and the hash table

[dpdk-dev] [PATCH v2 2/2] lib/hash: load pData after full key compare

When a hash entry is added, there are 2 sets of stores. 1) The application writes its data to memory (whose address is provided in rte_hash_add_key_with_hash_data API (or NULL)) 2) The rte_hash library writes to its own internal data structures; key store entry and the hash table. The only orderi

[dpdk-dev] [PATCH v2 1/2] lib/hash: use ordered loads only if signature matches

Relaxed signature comparison is done first. Further ordered loads are done only if the signature matches. Any false positives are caught by the full key comparison. This provides performance benefits as load-acquire is executed only when required. Fixes: e605a1d36 ("hash: add lock-free r/w concurr

Re: [dpdk-dev] [PATCH v2 09/28] sched: update pkt read and write API

> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, July 2, 2019 12:25 AM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Tovar, AbrahamX ; Krakowiak, LukaszX > > Subject: RE: [PATCH v2 09/28] sched: update pkt read and write API > > > > > -Original Message- > > Fr

Re: [dpdk-dev] [v3] kni: fix possible kernel crash with va2pa

I am battling a related problem as reported on https://bugs.dpdk.org/show_bug.cgi?id=183 and this patch seems relevant, so I applied this patch on 196a46fab6eeb3ce2039e3bcaca80f8ba43ffc8d However, this patch does not work for me: with CONFIG_RTE_LIBRTE_MBUF_DEBUG enabled, kni_free_mbufs's invocati

Re: [dpdk-dev] [PATCH] net: add definition for dscp and ecn masks

On 7/2/2019 10:32 AM, Olivier Matz wrote: > On Mon, Jul 01, 2019 at 03:59:04PM +0200, Morten Brørup wrote: >> Added definitions of DSCP and ECN masks. >> >> Signed-off-by: Morten Brørup > > Acked-by: Olivier Matz > Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net: fix definition of ipv6 traffic class mask

On 7/2/2019 10:38 AM, Olivier Matz wrote: > On Mon, Jul 01, 2019 at 04:00:44PM +0200, Olivier Matz wrote: >> On Mon, Jul 01, 2019 at 03:38:05PM +0200, Morten Brørup wrote: >>> IPv6 header TC field is 8 bits, not 4. >>> >>> Signed-off-by: Morten Brørup >> >> Acked-by: Olivier Matz >> >> Thanks >

Re: [dpdk-dev] [PATCH] Define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h

On 7/1/2019 2:11 PM, Olivier Matz wrote: > On Fri, Jun 21, 2019 at 12:55:06PM +0200, Morten Brørup wrote: >> TCP flags were moved to the TCP header file from the Ethernet control >> header file, and the RTE prefix was added to their names. >> >> Missing TCP ECN flags were added. >> >> The ALL mask

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

On 7/2/2019 6:56 PM, Ferruh Yigit wrote: > On 6/12/2019 2:04 AM, Zhao1, Wei wrote: >> >> >>> -Original Message- >>> From: Yigit, Ferruh >>> Sent: Tuesday, June 11, 2019 10:42 PM >>> To: Zhao1, Wei ; Kevin Traynor >>> ; dev@dpdk.org >>> Cc: sta...@dpdk.org >>> Subject: Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error

On 6/12/2019 2:04 AM, Zhao1, Wei wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, June 11, 2019 10:42 PM >> To: Zhao1, Wei ; Kevin Traynor >> ; dev@dpdk.org >> Cc: sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads default set error >> >>

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] ethdev: avoid error on PCI unplug of already closed ethdev

On 6/21/2019 11:15 AM, Andrew Rybchenko wrote: > On 6/21/19 12:52 PM, David Marchand wrote: >> On Fri, Jun 21, 2019 at 11:41 AM Andrew Rybchenko >> wrote: >>> If PCI Ethernet device driver removes it on close >>> (RTE_ETH_DEV_CLOSE_REMOVE) and later PCI device itself is unplugged, >>> it should no

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

On 2019-07-02 18:18, Anoob Joseph wrote: Hi Thomas, Bruce, For what exactly is being proposed, is there a short version of the suggested approach and the logic behind it? I think eventdev should be simple to use and could be added to any example like l2fwd. The idea of forking an example, wher

Re: [dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position

> > > >tbl_chng_cnt is one of the first elements of the structure used in the > >lookup. Move it to the beginning of the cache line to gain performance. > > > >Fixes: e605a1d36 ("hash: add lock-free r/w concurrency") > >Cc: sta...@dpdk.org > > > >Signed-off-by: Honnappa Nagarahalli > >Reviewed-b

[dpdk-dev] [PATCH v6 8/8] app/testpmd: use new ethernet address parser

The cmdline_parse_ether_addr does not need to be used everywhere in testpmd. Can use rte_ether_unformat_addr instead. As an added bonus it eliminates some code for copying. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline_flow.c | 5 ++--- app/test-pmd/config.c | 10 +++--- a

[dpdk-dev] [PATCH v6 7/8] net/bonding: use new ethernet address parser

The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile| 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +- 3 fil

[dpdk-dev] [PATCH v6 5/8] net/ether: mark ethernet addresses as being 2-byte aligned

From: Bruce Richardson When including the rte_ether.h header in applications with warnings enabled, a warning was given because of the assumption of 2-byte alignment of ethernet addresses when processing them. .../include/rte_ether.h:149:2: warning: converting a packed ‘const struct ether_addr

[dpdk-dev] [PATCH v6 6/8] cmdline: use new ethernet address parser

Now that there is a version of ether_aton in rte_ether, it can be used by the cmdline ethernet address parser. Note: ether_aton_r can not be used in cmdline because the old code would accept either bytes XX:XX:XX:XX:XX:XX or words :: and we need to keep compatiablity. Signed-off-by: S

[dpdk-dev] [PATCH v6 1/8] net/rte_ether: deinline non-critical functions

Formatting Ethernet address and getting a random value are not in critical path so they should not be inlined. Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen Reviewed-by: Andrew Rybchenko --- drivers/net/axgbe/Makefile | 2 +- drivers/net/memif/Makefile | 2 +- lib/lib

[dpdk-dev] [PATCH v6 4/8] net/ether: use bitops to speedup comparison

Using bit operations like or and xor is faster than a loop on all architectures. Really just explicit unrolling. Similar cast to uint16 unaligned is already done in other functions here. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 17 +++-

[dpdk-dev] [PATCH v6 3/8] ethdev: use new ethernet parsing function

Use rte_eth_unformat_addr, so that ethdev can be built and work without the cmdline library. The dependency on cmdline was an arrangement of convenience anyway. Signed-off-by: Stephen Hemminger --- lib/Makefile | 1 - lib/librte_ethdev/Makefile| 2 +- lib/librte_ethd

[dpdk-dev] [PATCH v6 2/8] net/ether: add function to convert string to ethernet address

Make a function that can be used in place of eth_aton_r to convert a string to rte_ether_addr. This function allows both byte (xx:xx:xx:xx:xx:xx) and word (::) format and has the same lack of error handling as the original. This also allows ethdev to no longer have a hard dependency on

[dpdk-dev] [PATCH v6 0/8] net/ether: enhancements and optimizations

This is a collection of patches around the ethernet address manipulation routines in librte_net/rte_ether. v6 add librte_net to axgbe and memif Makefile v5 reword commit messages to workaround check-log complaints v4 fix meson build reword commit messages add bonding and tespmd patc

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

Hi Thomas, Bruce, > For what exactly is being proposed, is there a short version of the suggested > approach and the logic behind it? > I think eventdev should be simple to use and could be added to any example > like > l2fwd. The idea of forking an example, where we should be able to have an >

Re: [dpdk-dev] [PATCH v3 0/5] improve building examples

> Bruce Richardson (5): > examples: add support for relocated DPDK install > devtools/test-meson-builds: remove dependency on clang > devtools/test-meson-builds: add testing of pkg-config file > examples/vdpa: support building from pkg-config info > examples/vhost_crypto: support building

Re: [dpdk-dev] [PATCH 24/30] examples/vhost_scsi: fix spelling errors

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Monday, July 1, 2019 20:26 To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 24/30] examples/vhost_scsi: fix spelling errors Spelling errors found by codespell. Signed-off-b

Re: [dpdk-dev] [PATCH] app/testpmd: change port detach interface

On 5/29/2019 9:16 AM, Nithin Dabilpuram wrote: > Hi Thomas, > > On Mon, May 20, 2019 at 06:20:53PM +0530, Nithin Dabilpuram wrote: >> On Fri, May 17, 2019 at 10:59:38AM +0200, Thomas Monjalon wrote: >>> 17/05/2019 10:55, Nithin Dabilpuram: On Wed, May 15, 2019 at 09:27:22AM +0200, Thomas Monj

Re: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Monday, July 1, 2019 20:25 To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error Spelling errors found by codespell. Signed-off-by: Stephen He

Re: [dpdk-dev] [PATCH 22/30] examples/service_cores: fix spelling errors

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Monday, July 1, 2019 20:25 To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 22/30] examples/service_cores: fix spelling errors Spelling errors found by codespell. Signed-of

Re: [dpdk-dev] [PATCH 16/30] examples/ethtool: fix spelling errors

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Monday, July 1, 2019 20:25 To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 16/30] examples/ethtool: fix spelling errors Spelling errors found by codespell. Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

Hi, > -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:53 PM > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; srinivas.nara...@att.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling > mlx5_link_update_u

Re: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value

Hi, > -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:46 > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return > value > > rte_calloc functions returns a

Re: [dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup comparison

On Tue, 2 Jul 2019 11:26:15 +0200 Olivier Matz wrote: > On Tue, Jul 02, 2019 at 09:53:14AM +0200, Olivier Matz wrote: > > Hi, > > > > On Mon, Jun 24, 2019 at 01:44:31PM -0700, Stephen Hemminger wrote: > > > Using bit operations like or and xor is faster than a loop > > > on all architectures.

Re: [dpdk-dev] [PATCH v10 0/3] add actions to modify header fields

On Tue, Jul 02, 2019 at 05:44:25PM +0300, Dekel Peled wrote: > Patch [1] implemented set of header modification actions in MLX PMD, based on > ethdev and testpmd updates included in [2]. > This series implements support of additional header modification actions, in > ethdev, testpmd, and MLX5 PMD

Re: [dpdk-dev] [PATCH v2] ethdev: support action with any config object type

On Tue, Jul 02, 2019 at 05:17:26PM +0300, Dekel Peled wrote: > In current implementation, an action which requires parameters > must accept them enclosed in a structure. > Some actions require a single, trivial type parameter, but it still > must be enclosed in a structure. > This obligation result

Re: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Monday, July 1, 2019 20:25 To: dev@dpdk.org Cc: Stephen Hemminger Subject: [dpdk-dev] [PATCH 12/30] ip_frag: fix spelling error Spelling errors found by codespell. Signed-off-by: Stephen He

Re: [dpdk-dev] [PATCH v2] ethdev: support action with any config object type

On 02.07.2019 17:17, Dekel Peled wrote: In current implementation, an action which requires parameters must accept them enclosed in a structure. Some actions require a single, trivial type parameter, but it still must be enclosed in a structure. This obligation results in multiple, action-specifi

[dpdk-dev] [PATCH] mk: fix march for octeontx2 target

From: Jerin Jacob Correct the wrong -march=-mcpu=armv8.2-a+crc+crypto+lse for octeontx2 target. Since rte_cc_has_argument drops invalid CFLAG and -mcpu=octeontx2 picks up the correct optimization, this typo is not noticed in performance testing. Fixes: 01d184798731 ("config: add octeontx2 machin

Re: [dpdk-dev] [PATCH v3 0/3] fixes and improvements for rawdev

> Bruce Richardson (3): > app/test: add missing rawdev autotest to meson build > raw/skeleton: remove compile-time constant for device id > rawdev: pass the device id as parameter to selftest Applied, thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset

> -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:53 > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; srinivas.nara...@att.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling > mlx5_link_update_unlocked_

Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

On 5/16/2019 10:12 AM, David Marchand wrote: > Hello Chas, > > On Fri, Apr 19, 2019 at 12:50 AM Chas Williams <3ch...@gmail.com> wrote: > >> On 4/18/19 3:11 AM, David Marchand wrote: >>> Hello Chas, >>> >>> On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3ch...@gmail.com >>>

Re: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value

> -Original Message- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:46 > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value > > rte_calloc functions returns a non-nu

Re: [dpdk-dev] [PATCH v2 4/5] examples/vdpa: support building from pkg-config info

02/07/2019 16:35, Bruce Richardson: > On Tue, Jul 02, 2019 at 09:57:48AM +0200, Thomas Monjalon wrote: > > It seems "CFLAGS += -DALLOW_EXPERIMENTAL_API" > > is reset by the call to pkg-config. > > > > No, it's not, it's reset by the call to the DPDK make build system in > the other leg of the code

[dpdk-dev] [PATCH v3 2/5] devtools/test-meson-builds: remove dependency on clang

Allow the script to run with a reduced set of builds if clang, or other compilers, are missing. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- devtools/test-meson-builds.sh | 38 ++- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/dev

[dpdk-dev] [PATCH v10 3/3] net/mlx5: update modify header using Direct Verbs

This patch implements additional actions of packet header modifications. Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

02/07/2019 16:26, Jerin Jacob Kollanukkaran: > From: Anoob Joseph > > Hi Thomas, Jerin, > > > > Is there any consensus on how we should proceed? Can this be taken up by > > techboard? OK, let me give my detailed opinion. Summary: I don't like this situation at all. I think eventdev should be sim

[dpdk-dev] [PATCH v10 2/3] app/testpmd: add actions to modify TCP header fields

Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

[dpdk-dev] [PATCH v10 1/3] ethdev: add actions to modify TCP header fields

Add actions: - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP header. - DEC_TCP_ACK - Decrease acknowledgment number in the

[dpdk-dev] [PATCH v3 1/5] examples: add support for relocated DPDK install

For testing of DPDK, we want to override the prefix given by the pkg-config file, so that we can get correct paths for DPDK installed in an unusual location. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- examples/bbdev_app/Makefile | 10 ++ examples/bond/Makefi

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

On Tue, Jul 02, 2019 at 02:26:34PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Anoob Joseph > > Sent: Tuesday, July 2, 2019 7:47 PM > > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > > > Cc: dev@dpdk.org; Mattias Rönnblom ; > > Nikhil Rao ; Erik Gabriel Ca

[dpdk-dev] [PATCH v3 4/5] examples/vdpa: support building from pkg-config info

The vdpa example app did not check for a libdpdk pkg-config file and attempt to build using that. Add support for that method of compile to align the app with the other examples. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- examples/vdpa/Makefile | 51

[dpdk-dev] [PATCH v3 0/5] improve building examples

This patchset adds support for testing a number of examples using the DPDK pkgconfig file, allowing us to check that the file works. It also includes some more general cleanups for the examples, including adding support for building from pkg-config to a couple of examples which were missing that.

[dpdk-dev] [PATCH v10 0/3] add actions to modify header fields

Patch [1] implemented set of header modification actions in MLX PMD, based on ethdev and testpmd updates included in [2]. This series implements support of additional header modification actions, in ethdev, testpmd, and MLX5 PMD. Original work by Xiaoyu Min. [1] http://patches.dpdk.org/patch/49

[dpdk-dev] [PATCH v3 5/5] examples/vhost_crypto: support building from pkg-config info

The vhost_crypto example app did not check for a libdpdk pkg-config file and attempt to build using that. Add support for that method of compile to align the app with the other examples. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- examples/vhost_crypto/Makefile | 51

[dpdk-dev] [PATCH v3 3/5] devtools/test-meson-builds: add testing of pkg-config file

The pkg-config file generated as part of the build of DPDK should allow applications to be built with an installed DPDK. We can test this as part of the build by doing an install of DPDK to a temporary directory within the build folder, and by then compiling up a few sample apps using make working

Re: [dpdk-dev] [PATCH v2 4/5] examples/vdpa: support building from pkg-config info

On Tue, Jul 02, 2019 at 09:57:48AM +0200, Thomas Monjalon wrote: > 17/05/2019 13:47, Bruce Richardson: > > The vdpa example app did not check for a libdpdk pkg-config file and > > attempt to build using that. Add support for that method of compile to > > align the app with the other examples. > >

Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library

> -Original Message- > From: Anoob Joseph > Sent: Tuesday, July 2, 2019 7:47 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Mattias Rönnblom ; > Nikhil Rao ; Erik Gabriel Carrillo > ; Abhinandan Gujjar ; > Bruce Richardson ; Pablo de Lara > ; Narayana Prasad Raj

[dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9

Suppress the unaligned packed member address warnings by extending the telemetry library build flags with -Wno-address-of-packed-member option, through the WERROR_FLAGS makefile variable. With this change additional warnings are turned on to be treated as errors, which causes the following build i

Re: [dpdk-dev] [PATCH 2/2] test/eventdev: fix producer core validity checks

> -Original Message- > From: dev On Behalf Of Jerin Jacob Kollanukkaran > Sent: Tuesday, July 2, 2019 10:59 AM > To: Pavan Nikhilesh Bhagavatula > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] test/eventdev: fix producer core valid

  1   2   >