> -Original Message-
> From: Phil Yang
> Sent: Friday, June 28, 2019 1:42 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com;
> gavin...@arm.com; n...@arm.com; gage.e...@intel.com
> Subject: [EXT] [PATCH v3 1/
Remove an unnecessary rte_intr_disable() call to disable interrupt
during device init.
Fixes: c09f57b49c13 ("net/bnxt: add start/stop/link update operations")
Cc: sta...@dpdk.org
Signed-off-by: Kalesh AP
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ---
1 file changed, 3
Update the HWRM version to the latest version used by the bnxt PMD
from 1.10.0.74 to 1.10.0.91
Signed-off-by: Ajit Khaparde
---
doc/guides/rel_notes/release_19_08.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/release_19_08.rst
b/doc/guides/rel_note
From: Lance Richardson
The vector mode transmit path does not currently support VLAN tag
insertion, so we need to disable vector transmit when transmit
VLAN insertion offload is enabled.
Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
Reviewed-by: Ajit Khaparde
Signed-off-by: Lance
From: Stephen Hemminger
The receive interrupt vector should be offset by the constant
RTE_INTR_VEC_RXTX_OFFSET; otherwise setting up some queue interrupts
will fail.
Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Stephen Hemminger
Reviewed
Patchset based after an earlier submission
https://patchwork.dpdk.org/patch/56690/
This set mostly contains bug fixes, an update to the bnxt.rst doc
and a adds a VF PCI device ID for Thor based network controller.
Please apply.
Ajit Khaparde (2):
net/bnxt: remove unnecessary interrupt disable
From: Santoshkumar Karanappa Rastapur
BCM57500-based adapters use a variable number of RSS contexts
depending upon the number of receive rings in use. The current
implementation is erroneously using the maximum possible number
of RSS contexts instead of the actual number allocated when
setting up
From: Kalesh AP
Added support for new thor device.
Signed-off-by: Kalesh AP
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 87
From: Rahul Gupta
Rearm will intimate hardware that current interrupts are processed
and it can continue to send more.
Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
Cc: sta...@dpdk.org
Signed-off-by: Rahul Gupta
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_rxq.
Is it really needed for mlx4? mlx4 uses neither Netlink nor shared context.
With best regards, Slava
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Saturday, July 13, 2019 0:04
> To: bugzi...@dpdk.org
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [Bug 320] mlx4: i
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiao Zhang
> Sent: Monday, July 8, 2019 9:37 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo ; Zhao1, Wei
> ; Zhang, Xiao
> Subject: [dpdk-dev] [DPDK] net/e1000: fix buffer overrun while i219
> processing DMA transaction
TAILQ_FOREACH macro is not safe to remove elements
during iterating tailq lists. Replace it with
TAILQ_FOREACH_SAFE.
Fixes: d76116a4678f ("net/ice: add generic flow API")
Signed-off-by: Beilei Xing
---
drivers/net/ice/ice_generic_flow.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On Thu, 19-07-18, 22:42, Dekel Peled wrote:
> In functions flow_dv_translate() and flow_dv_validate(), the flow
> items are scanned and each item is marked in item_flags bitmap.
> The code handling some of the items was ported from another project,
> where items are marked in a slightley different
This reverts commit e28111ac9864af09e826241a915dfff87a9c00ad.
The netlink requests are replaced by ifindex caching and
not needed anymore.
Signed-off-by: Viacheslav Ovsiienko
Fixes: e28111ac9864 ("net/mlx5: fix master device Netlink socket sharing")
---
drivers/net/mlx5/mlx5.h| 6 ---
The associated device index is retrieved via Netlink request to
underlying Infiniband device driver. This network device index
is permanent throughout the lifetime of device. We do not
spawn the rte_eth_dev ports without associated network device, and
if network device is being unbound we get the r
In mlx5 PMD the associated device index is retrieved via Netlink request to
underlying Infiniband device driver. This network device index is permanent
throughout the lifetime of device. We do not spawn the rte_eth_dev ports
without associated network device, and if network device is being unbound
> -Original Message-
> From: Wang, Haiyue
> Sent: Friday, July 19, 2019 10:18 AM
> To: Zhang, Xiao ; dev@dpdk.org
> Cc: Xing, Beilei ; Zhang, Qi Z ;
> sta...@dpdk.org
> Subject: RE: [v4] net/i40e: fix SFP X722 not work with FW4.16
>
> > -Original Message-
> > From: Zhang, Xiao
>
> -Original Message-
> From: Jerin Jacob Kollanukkaran
> Sent: Friday, July 19, 2019 1:03 PM
> To: Eads, Gage ; Phil Yang (Arm Technology China)
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; hemant.agra...@nxp.com; Honnappa
> Nagarahalli ; Gavin Hu (Arm Technology
> China) ; nd
> Subject: R
> > --
> > Asymmetric nature of RSA algorithm suggest to use additional field for
> > output. In place operations still can be done by setting cipher and
> > message pointers with the same memory address.
> >
> > Signed-off-by: Are
Hi, Ferruh
Please, see below
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, July 17, 2019 17:56
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: bernard.iremon...@intel.com; sta...@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix display capabilities
> routine
>
>
> > Can we remove this all #ifdef clutter by adding the following
> >
> > $ git diff
> > diff --git a/lib/librte_stack/rte_stack_lf.h
> > b/lib/librte_stack/rte_stack_lf.h index f5581f0c2..46af08b83 100644
> > --- a/lib/librte_stack/rte_stack_lf.h
> > +++ b/lib/librte_stack/rte_stack_lf.h
> > @@ -5
> -Original Message-
> From: Arek Kusztal
> Sent: Thursday, July 18, 2019 9:40 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma
> ; damianx.no...@intel.com; Arek Kusztal
>
> Subject: [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in asymmetric
> c
> -Original Message-
> From: Arek Kusztal
> Sent: Thursday, July 18, 2019 9:40 PM
> To: dev@dpdk.org
> Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma
> ; damianx.no...@intel.com; Arek Kusztal
>
> Subject: [EXT] [PATCH v5 2/7] cryptodev: add cipher field to RSA op
>
> Ext
> -Original Message-
> From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com]
> Sent: Thursday, July 18, 2019 11:18 PM
> To: Phil Yang ; dev@dpdk.org
> Cc: tho...@monjalon.net; hemant.agra...@nxp.com;
> honnappa.nagaraha...@arm.com; gavin...@arm.com; n...@arm.com; Eads,
> Gage
> Su
Hi Slava,
Thank you, I will file it.
regards,
Yasu
From: Slava Ovsiienko
Subject: Re: [dpdk-dev] ConnectX-4/mlx5 crashes around rxq_cqe_comp_en?
Date: Fri, 19 Jul 2019 03:53:54 +
Message-ID:
> Hi, Yasuhiro
>
> Could you, please, create the ticket in Bugzilla.dpdk.org to store the
> d
> -Original Message-
> From: Dekel Peled
> Sent: Thursday, July 18, 2019 22:41
> To: Yongseok Koh ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: correct spelling mistakes in comments
>
> Some spelling mistakes were found in
> -Original Message-
> From: Dekel Peled
> Sent: Thursday, July 18, 2019 22:42
> To: Yongseok Koh ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Jack Min ; Ori Kam ;
> dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix setting of item flags bitmap
>
> In functions flow_dv_translate() and flow_dv_
> -Original Message-
> From: Dekel Peled
> Sent: Thursday, July 18, 2019 22:42
> To: Yongseok Koh ; Slava Ovsiienko
> ; Shahaf Shuler
> Cc: Jack Min ; Ori Kam ;
> dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix define of added tunnel layer bit
>
> The new define MLX5_FLOW_LAYER_IPIP is usi
> -Original Message-
> From: dev On Behalf Of Dekel Peled
> Sent: Thursday, July 18, 2019 22:37
> To: Matan Azrad ; Shahaf Shuler
>
> Cc: Ori Kam ; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx4: correct spelling mistake in comment
>
> A spelling mistake was found in comment.
> This
> -Original Message-
> From: Phil Yang
> Sent: Friday, June 28, 2019 1:42 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com;
> gavin...@arm.com; n...@arm.com; gage.e...@intel.com
> Subject: [EXT] [PATCH v3 3/
...
> Comment under rte_crypto_rsa_op_param.cipher:
> Pointer to input data
>* - to be decrypted for RSA private decrypt.
>
> Pointer to output data
>* - for RSA public encrypt.
> In this case the underlying array should have been
> allocated with
>
> -Original Message-
> From: Phil Yang
> Sent: Friday, June 28, 2019 1:42 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; honnappa.nagaraha...@arm.com;
> gavin...@arm.com; n...@arm.com; gage.e...@intel.com
> Subject: [EXT] [PATCH v3 2/
Hi, Yasuhiro
Could you, please, create the ticket in Bugzilla.dpdk.org to store the details?
The Rx CQE compression can be disabled with specifying "rxq_cqe_comp_en=0".
WBR, Slava
> -Original Message-
> From: dev On Behalf Of Yasuhiro Ohara
> Sent: Friday, July 19, 2019 5:20
> To: dev@d
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, July 17, 2019 12:18 AM
> To: Jerin Jacob Kollanukkaran
> Cc: dev@dpdk.org
> Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
> All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned
From: Zhu Tao
When the VF configuration is larger than the number of queues reserved
by PF, VF sends the request queue command through admin queue. When PF
received this command, it may reset the VF and send a notification
before resetting. If this notification is read by the timed task alarm,
Ta
From: Kiran Kumar K
Adding support for ipv6_ext header parsing in the octeontx2 flow.
Signed-off-by: Kiran Kumar K
---
doc/guides/nics/octeontx2.rst | 6 --
drivers/net/octeontx2/otx2_flow_parse.c | 7 +++
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/doc/gu
On Thu, 19-07-18, 22:41, Dekel Peled wrote:
> The new define MLX5_FLOW_LAYER_IPIP is using the same value as
> existing define MLX5_FLOW_LAYER_GRE_KEY.
> This patch updates the values to be in order.
>
> Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
> Signed-off-by: Dekel Peled
> ---
The same goes with DPDK-19.05 too.
When crash happens,
mcqe_n == t_pkt->data_len == 124.
struct rte_mbuf **elts (which seems to be prepared somewhere)
looks like it's supposed to contain valid mbufs,
but (when under a significant load?) it doesn't.
(gdb) p/x (void*[124])elts[0]
$31 = {0x1d0bd0
> -Original Message-
> From: Zhang, Xiao
> Sent: Friday, July 19, 2019 19:00
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Wang, Haiyue
> ; Zhang, Qi Z
> ; Zhang, Xiao ; sta...@dpdk.org
> Subject: [v4] net/i40e: fix SFP X722 not work with FW4.16
>
> The code checked the NVM API version of FW to
The code checked the NVM API version of FW to check if support adminq
operation, when version is 1.7 or above adminq operation is support
and the adminq flag will be set. The code will use adminq to set TPID if
the flags set or to use register. The NVM API version of SFP X722 old
versions are low
set_switch_config adminq operation was used to set TPID for SFP X722
with FW4.16, but adminq is not supported which lead to failure. Since
all FW versions of SFP X722 do not support adminq, disable adminq flag
to use resigter setting to make it work.
Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch
> -Original Message-
> From: Wang, Haiyue
> Sent: Friday, July 19, 2019 9:02 AM
> To: Zhang, Qi Z ; Zhang, Xiao ;
> dev@dpdk.org
> Cc: Xing, Beilei
> Subject: RE: [v2] net/i40e: fix SFP X722 not work with FW4.16
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Friday, J
> -Original Message-
> From: Zhang, Qi Z
> Sent: Friday, July 19, 2019 08:57
> To: Zhang, Xiao ; dev@dpdk.org
> Cc: Xing, Beilei ; Wang, Haiyue
> Subject: RE: [v2] net/i40e: fix SFP X722 not work with FW4.16
>
>
>
> > -Original Message-
> > From: Zhang, Xiao
> > Sent: Friday, Ju
> -Original Message-
> From: Xing, Beilei
> Sent: Friday, July 19, 2019 8:54 AM
> To: Lipiec, Herakliusz ; Zhang, Qi Z
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] net/i40e: add return check coverity
>
>
>
> > -Original Message-
> > From: Lipiec, Herakliusz
> -Original Message-
> From: Zhang, Xiao
> Sent: Friday, July 19, 2019 6:52 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Wang, Haiyue
> ; Zhang, Qi Z ; Zhang, Xiao
>
> Subject: [v2] net/i40e: fix SFP X722 not work with FW4.16
Please add fix line and Cc stable.
Fixes: 73cd7d6dc8e1 ("net/i
> -Original Message-
> From: Lipiec, Herakliusz
> Sent: Thursday, July 18, 2019 10:45 PM
> To: Xing, Beilei ; Zhang, Qi Z
> Cc: dev@dpdk.org; Lipiec, Herakliusz ;
> sta...@dpdk.org
> Subject: [PATCH v2] net/i40e: add return check coverity
>
> add return check for i40e_vsi_delete_mac ca
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, July 18, 2019 11:06 AM
> To: Wang, Ying A ; Zhang, Qi Z
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH 3/3] net/ice: add flow ipv6 tc support
>
>
>
> -Original Message-
> From: Wang, Ying A
> Sent: Thurs
> -Original Message-
> From: Yang, Qiming
> Sent: Thursday, July 18, 2019 11:07 AM
> To: Wang, Ying A ; Zhang, Qi Z
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH 2/3] net/ice: fix flow action validation
>
>
>
> -Original Message-
> From: Wang, Ying A
> Sent: Thu
> -Original Message-
> From: Wang, Ying A
> Sent: Thursday, July 18, 2019 10:52 AM
> To: Yang, Qiming ; Zhang, Qi Z
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH 1/3] net/ice: fix flow get inputset check
>
>
>
> > -Original Message-
> > From: Yang, Qiming
> > Se
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, July 17, 2019 12:56 PM
> To: Zhang, Qi Z
> Cc: Wu, Jingjing ; Lu, Wenzhuo
> ; dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix Rx bytes stats
>
> On Wed, 1
> -Original Message-
> From: Singh, Jasvinder
> Sent: Wednesday, July 17, 2019 4:43 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Tovar, AbrahamX
> ; Krakowiak, LukaszX
>
> Subject: [PATCH v5 06/11] sched: improve doxygen comments
>
> Improve doxygen comments.
>
> Signed-off-by:
> -Original Message-
> From: Singh, Jasvinder
> Sent: Wednesday, July 17, 2019 4:43 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian ; Tovar, AbrahamX
> ; Krakowiak, LukaszX
>
> Subject: [PATCH v5 02/11] sched: add config flexibility to tc queue sizes
>
> Add support for zero queue siz
> -Original Message-
> From: Singh, Jasvinder
> Sent: Wednesday, July 17, 2019 4:43 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian
> Subject: [PATCH v5 00/11] sched: feature enhancements
>
> This patchset refactors the dpdk qos sched library to allow flexibile
> configuration of the
18/07/2019 19:18, Stephen Hemminger:
> Small cleanups to cfgfile library.
>
> Stephen Hemminger (3):
> cfgfile: remove unnecessary initialization
> cfgfile: use RTE_LOG for errors
> cfgfile: use calloc
>
> lib/Makefile | 1 +
> lib/librte_cfgfile/rte_cfgfile.c | 55 +++
18/07/2019 19:18, Stephen Hemminger:
> In general, DPDK libraries to not print error messages to
> stdout because that is often redirected to /dev/null for daemons.
> This patch changes cfgfile library to use RTE_LOG with its
> own type.
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/Makefile
17/07/2019 22:42, Andrew Rybchenko:
> On 7/17/19 8:50 PM, Ferruh Yigit wrote:
> > Adding Andrew as co-maintainer to next-net sub-tree.
> >
> > Signed-off-by: Ferruh Yigit
> > ---
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > Next-net Tree
> > M: Ferruh Yigit
> > +M: Andrew Rybchenko
> > T:
18/07/2019 16:03, Herakliusz Lipiec:
> When building dpdk with differnt kernel headers by specifying
> RTE_KERNELDIR igb_uio is compiled to directory with a name of the
> version of kernel thats running on the system instead of the one that
> dpdk is actually compiled against. Fixed by replacing ha
> > From: Pavan Nikhilesh
> >
> > Since direct register access is used in npa_lf_aura_op_alloc_bulk() use
> > __rte_noinline instead of __rte_always_inline to preserve ABI.
> > Based on the compiler npa_lf_aura_op_alloc_bulk might be inlined
> > differently which may lead to undefined behaviour d
17/07/2019 17:55, jer...@marvell.com:
> From: Jerin Jacob
>
> Add LBK HW block abstraction details and the application
> usage models.
>
> This patch also updates missing DPI HW block to DPDK
> subsystem mapping as well.
>
> Signed-off-by: Jerin Jacob
Applied, thanks
Tell users about upcoming changes to rte_ether_addr and
rte_ether_header.
Signed-off-by: Stephen Hemminger
---
doc/guides/rel_notes/deprecation.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst
b/doc/guides/rel_notes/deprecation.rst
index a779
19/07/2019 00:01, Thomas Monjalon:
> Some machine (like on dpdk.org) may fail to build the prog guide PDF
> because of a table characher being "+" instead of "|".
>
> Some figure references are also fixed with automatic numbering.
>
> Fixes: 3f3f608142cf ("doc: update bbdev guide for 5GNR operati
Some machine (like on dpdk.org) may fail to build the prog guide PDF
because of a table characher being "+" instead of "|".
Some figure references are also fixed with automatic numbering.
Fixes: 3f3f608142cf ("doc: update bbdev guide for 5GNR operations")
Signed-off-by: Thomas Monjalon
Signed-o
18/07/2019 08:24, Nicolas Chautru:
> Some machine (like on dpdk.org) may fail to build the prog guide PDF because
> of the complex table inserted in the bbdev chapter.
>
> Fixes: 3f3f608142cf ("doc: update bbdev guide for 5GNR operations")
>
> Signed-off-by: Nicolas Chautru
> ---
> --- a/doc/gu
18/07/2019 23:24, Thomas Monjalon:
> 11/07/2019 17:33, Stephen Hemminger:
> > On Thu, 11 Jul 2019 13:35:07 +0100
> > Ferruh Yigit wrote:
> >
> > > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> > > that case will be wrong and some values can cause buffer overflow
> > > in
11/07/2019 17:33, Stephen Hemminger:
> On Thu, 11 Jul 2019 13:35:07 +0100
> Ferruh Yigit wrote:
>
> > 'kni_net_rx_lo_fifo()' can get segmented buffers, using 'pkt_len' for
> > that case will be wrong and some values can cause buffer overflow
> > in destination mbuf data.
> >
> > Signed-off-by: F
15/07/2019 17:39, Erik Gabriel Carrillo:
> A crash occurs in the examples/performance-thread/l3fwd-thread when it calls
> into rte_timer_manage() from the LThread library it utilizes. This happens
> because the application omitted a call to rte_timer_subsystem_init(), which
> leaves a pointer set
18/07/2019 12:11, Konstantin Ananyev:
> v1 -> v2
> As requested, split one patch into two
>
> Konstantin Ananyev (2):
> examples/ip_fragmentation: fix fail to send un-fragmented packets
> examples/ip_fragmentation: fix set IPv4 for unknown packet types
Applied, thanks
16/07/2019 19:04, Haiyue Wang:
> The state of virtio device has been defined in both header file and
> source file, keep the definition in header file for public use.
>
> Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Haiyue Wang
Appl
> Marcin Zapolski (3):
> examples/l3fwd*: fix use of internal struct
> examples/ip_fragmentation: fix use of internal struct
> examples/ipsec-secgw: fix use of internal struct
Applied, thanks
In functions flow_dv_translate() and flow_dv_validate(), the flow
items are scanned and each item is marked in item_flags bitmap.
The code handling some of the items was ported from another project,
where items are marked in a slightley different manner.
This patch fixes the setting of items in b
NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol
value 0x6558.
These should be matched when item_nvgre is provided.
This patch adds validation function of NVGRE item, to validate that
the input values, if exist, are as required.
It also updates the translate function of NVGRE item
The new define MLX5_FLOW_LAYER_IPIP is using the same value as
existing define MLX5_FLOW_LAYER_GRE_KEY.
This patch updates the values to be in order.
Fixes: 1b5624cd9062 ("net/mlx5: support IP-in-IP tunnel")
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_flow.h | 4 ++--
1 file changed, 2
Some spelling mistakes were found in comments.
This patch fixes them.
Cc: sta...@dpdk.org
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5.h | 2 +-
drivers/net/mlx5/mlx5_flow.c | 2 +-
drivers/net/mlx5/mlx5_rxq.c | 2 +-
drivers/net/mlx5/mlx5_txq.c | 2 +-
4 files changed, 4 inserti
A spelling mistake was found in comment.
This patch fixes it.
Signed-off-by: Dekel Peled
---
drivers/net/mlx4/mlx4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
index cd0d637..9bdbc6d 100644
--- a/drivers/net/mlx4/mlx4.h
+
The current ether_unformat_addr code was based off of
BSD ether_aton. That version changed what was allowed
by the cmdline ether address parser.
For example, it allows dropping leading zeros.
Change the code to be more restrictive and only allow the fully
expanded standard formats.
Bugzilla ID: 3
On Thu, 18 Jul 2019 09:47:03 +0200
Olivier Matz wrote:
> Hi,
>
> I'm fine with a more strict version like you proposed here. I checked
> that the cmdline tests pass.
>
> Few minor comments below.
>
> On Wed, Jul 17, 2019 at 11:49:45AM -0700, Stephen Hemminger wrote:
> > The current code acts m
Better to use calloc when allocating arrays.
Signed-off-by: Stephen Hemminger
---
lib/librte_cfgfile/rte_cfgfile.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index 388415147930..9049fd9c2319 100
In general, DPDK libraries to not print error messages to
stdout because that is often redirected to /dev/null for daemons.
This patch changes cfgfile library to use RTE_LOG with its
own type.
Signed-off-by: Stephen Hemminger
---
lib/Makefile | 1 +
lib/librte_cfgfile/rte_cf
No need to initialize variable if it is immediately overwritten.
It is better style not do unnecessary initialization with modern
tools since it lets compiler and other static checkers detect
uninitialized data.
Signed-off-by: Stephen Hemminger
---
lib/librte_cfgfile/rte_cfgfile.c | 8
Small cleanups to cfgfile library.
Stephen Hemminger (3):
cfgfile: remove unnecessary initialization
cfgfile: use RTE_LOG for errors
cfgfile: use calloc
lib/Makefile | 1 +
lib/librte_cfgfile/rte_cfgfile.c | 55 +---
2 files changed, 37 inse
On Thu, 18 Jul 2019 15:36:45 +0100
Bruce Richardson wrote:
> On Thu, Jul 18, 2019 at 07:34:59AM -0700, Stephen Hemminger wrote:
> > On Thu, 18 Jul 2019 09:31:11 +0100
> > Bruce Richardson wrote:
> >
> > > On Wed, Jul 17, 2019 at 05:48:21PM -0700, Stephen Hemminger wrote:
> > > > In general,
This patch removes RSA PKCS1_5 BT0 padding from test cases
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 97f3430..95e7d34 100644
---
This patch removes RSA PKCS1_5 BT0 padding from openssl PMD.
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/rte_openssl_pmd.c
index
BT0 block type padding after rfc2313 has been discontinued.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
This patch adds cipher field to RSA test cases
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 4dee164..97f3430 100644
--- a/app/test/test_cryptodev_asym.
Ramoved patches that was not acked by Shally.
So open things:
1. Creating padding struct.
2. Padding parameters (seedlen, optional label etc).
3. Leading zeroes questions.
4. Random number requirements.
5. Capabilities.
6. Verify signature field when none padding.
7. Padding none.
8. Signature inpu
This commit adds cipher field to openssl pmd to comfort to
API change.
Signed-off-by: Arek Kusztal
---
drivers/crypto/openssl/rte_openssl_pmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c
b/drivers/crypto/openssl/rte_opens
Asymmetric nature of RSA algorithm suggest to use
additional field for output. In place operations
still can be done by setting cipher and message pointers
with the same memory address.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 43 --
RSA modulus cannot be prime as its security depends on the problem
of integer factorization.
Signed-off-by: Arek Kusztal
---
lib/librte_cryptodev/rte_crypto_asym.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_crypt
Sent from Workspace ONE Boxer
On 12-Jul-2019 6:45 PM, "Kusztal, ArkadiuszX"
mailto:arkadiuszx.kusz...@intel.com>> wrote:
>
> In future we could unify tests even more (i.e. passing padding type as a
> param, or even information if it is encryption or signature generation) like
> Fan once done
> >
> > This patch updates the constant names and function names used
> > in code snippets in the Compression Device Library documentation.
> >
> > Signed-off-by: Adam Dybkowski
> Acked-by: Fiona Trahe
Applied to dpdk-next-crypto
Thanks.
> >
> > This patch adds checking if device support ZUC
> > algorithms before running ZUC test cases.
> > It also removes unnecessary checks of digest
> > appended space and fixes some comments wording.
> >
> > Signed-off-by: Damian Nowak
> Acked-by: Fiona Trahe
Applied to dpdk-next-crypto
Th
> >
> > From: Tomasz Jozwiak
> >
> > This patch fixes fail status returned from compression PMD in case
> > destination buffer size is not enough to store all data.
> >
> > Fixes: 3dc9ef2d23fe ("compress/qat: fix returned status on overflow")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Tomas
> >
> > Use ERR rather than INFO to warn that it's a negative test else the
> > errors are seen but the warning to expect them isn't.
> > Also add comment to make it easier to follow code.
> >
> > Signed-off-by: Fiona Trahe
> > ---
>
> Acked-by: Adam Dybkowski
Applied to dpdk-next-crypto
Th
>
> >
> > Fix for seg-faults occurring:
> > 1) in buffer re-alignment in-place sgl case
> > 2) case where data end is exactly at end of an sgl segment.
> > Also renamed variable and increased comments for clearer code.
> >
> > Fixes: 40002f6c2a24 ("crypto/qat: extend support for digest-encrypte
>
>
> Hi guys,
>
> >
> > Hi Tao
> >
> > > -Original Message-
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of
> > > taox@intel.com
> > > Sent: Thursday, July 18, 2019 3:22 PM
> > > To: Nicolau, Radu ; akhil.go...@nxp.com
> > > Cc: dev@dpdk.org; Zhu, TaoX
> > > Subject:
18/07/2019 16:59, Chautru, Nicolas:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >18/07/2019 15:33, Chautru, Nicolas:
> >> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >> >Anyway all the documentation about the API details should be removed.
> >> >The guide is expected to give an
From: Thomas Monjalon [mailto:tho...@monjalon.net]
>18/07/2019 16:43, Chautru, Nicolas:
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>> >3 comments above the change of references:
>> >
>> >- there are a lot more, please search for the word "section"
>>
>> All the ones I could see are sim
18/07/2019 16:51, Chautru, Nicolas:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >About the tables, there are simpler syntax in RsT:
> >http://docutils.sourceforge.net/docs/user/rst/quickref.html#tables
>
> To be honest, I cannot see the problem with the current format which is
> follo
18/07/2019 16:43, Chautru, Nicolas:
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >3 comments above the change of references:
> >
> >- there are a lot more, please search for the word "section"
>
> All the ones I could see are similar to "as per 3GPP TS 38.212 section 5.2.2"
> which is
1 - 100 of 169 matches
Mail list logo
