Re: [dpdk-dev] [PATCH v2] net/i40e: fix request queue fail in VF

2019-07-22 Thread Zhang, Qi Z
> -Original Message- > From: Zhu, TaoX > Sent: Friday, July 19, 2019 11:18 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhu, TaoX ; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix request queue fail in VF > > From: Zhu Tao > > When the VF configuration is larger than t

Re: [dpdk-dev] [PATCH v2 00/28] net/mlx5: support LRO

2019-07-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Monday, July 22, 2019 5:52 PM > To: Ferruh Yigit ; Shahaf Shuler > ; Yongseok Koh ; Slava > Ovsiienko > Cc: dev@dpdk.org; Dekel Peled > Subject: [dpdk-dev] [PATCH v2 00/28] net/mlx5: support LRO > > Introduction: > L

Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow

2019-07-22 Thread Raslan Darawsheh
Tested-by: Raslan Darawsheh Seems OK for me, Kindest regards, Raslan Darawsheh > -Original Message- > From: Stephen Hemminger > Sent: Monday, July 22, 2019 8:20 PM > To: Ferruh Yigit > Cc: Adrien Mazarguil ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; dev@dpdk.org; Raslan > Dar

Re: [dpdk-dev] [PATCH v3 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-22 Thread Vamsi Krishna Attunuru
Ping V3 review request.. > -Original Message- > From: vattun...@marvell.com > Sent: Friday, July 12, 2019 12:13 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > david.march...@redhat.com; acon...@redhat.com; Vamsi Krishna Attunuru > > Subject: [PATCH v3 1/1

[dpdk-dev] [PATCH v7 3/3] eal/stack: enable lock-free stack for aarch64

2019-07-22 Thread Phil Yang
Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. Introduced a new header to reduce the ifdef clutter across generic and c11 files. The rte_stack_lf_stubs.h contains stub implementations of __rte_stack_lf_count, __rte_stack_lf_push_elems and __rte_stack_lf_pop_elems. Suggeste

[dpdk-dev] [PATCH v7 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-22 Thread Phil Yang
Add 128-bit atomic compare exchange on aarch64. Suggested-by: Jerin Jacob Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Tested-by: Honnappa Nagarahalli Acked-by: Jerin Jacob --- v7: 1. Adjust code comment. v6: 1. Put the RTE_ARM_FEATURE_ATOMICS flag into EAL group. (Jerin Jocob

[dpdk-dev] [PATCH v7 2/3] test/atomic: add 128b compare and swap test

2019-07-22 Thread Phil Yang
Add 128b atomic compare and swap test for aarch64 and x86_64. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Acked-by: Gage Eads Acked-by: Jerin Jacob Tested-by: Jerin Jacob --- app/test/test_atomic.c | 120 - 1 file changed, 118 i

[dpdk-dev] [PATCH v8 5/5] kni: modify IOVA mode checks to support VA

2019-07-22 Thread vattunuru
From: Vamsi Attunuru Patch addresses checks in KNI and eal that enforce IOVA=PA when IOVA=VA mode is enabled, since KNI kernel module supports VA mode for kernel versions >= 4.4.0. Updated KNI documentation with above details. Signed-off-by: Vamsi Attunuru Signed-off-by: Kiran Kumar K --- do

[dpdk-dev] [PATCH v8 2/5] add IOVA -VA support in KNI lib

2019-07-22 Thread vattunuru
From: Vamsi Attunuru Current KNI implementation only operates in IOVA=PA mode, patch adds required functionality in KNI lib to support IOVA=VA mode. KNI kernel module requires device info to get iommu domain related information for IOVA addr related translations. Patch defines device related inf

[dpdk-dev] [PATCH v8 1/5] mempool: populate mempool with page sized chunks of memory

2019-07-22 Thread vattunuru
From: Vamsi Attunuru Patch adds a routine to populate mempool from page aligned and page sized chunks of memory to ensures memory objs do not fall across the page boundaries. It's useful for applications that require physically contiguous mbuf memory while running in IOVA=VA mode. Signed-off-by:

[dpdk-dev] [PATCH v8 4/5] kni: add IOVA=VA support in KNI module

2019-07-22 Thread vattunuru
From: Kiran Kumar K Patch adds support for kernel module to work in IOVA = VA mode, the idea is to get physical address from IOVA address using iommu_iova_to_phys API and later use phys_to_virt API to convert the physical address to kernel virtual address. When compared with IOVA = PA mode, ther

[dpdk-dev] [PATCH v8 3/5] kni: add app specific mempool create & free routine

2019-07-22 Thread vattunuru
From: Vamsi Attunuru When KNI operates in IOVA = VA mode, it requires mbuf memory to be physically contiguous to ensure KNI kernel module could translate IOVA addresses properly. Patch adds a KNI specific mempool create routine to populate the KNI packet mbuf pool with memory objects that are bei

[dpdk-dev] [PATCH v8 0/5] kni: add IOVA=VA support

2019-07-22 Thread vattunuru
From: Vamsi Attunuru --- V8 Changes: * Remove default mempool populate() routine changes. * Add kni app specific mempool create & free routines. * Add new mempool populate routine to allocate page-aligned memzones with page size to make sure all mempool objects reside on a page. * Update release

Re: [dpdk-dev] [RFC 0/4] mempool: avoid objects allocations across pages

2019-07-22 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Olivier Matz > Sent: Friday, July 19, 2019 7:09 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: Andrew Rybchenko ; Thomas Monjalon > ; Anatoly Burakov ; Jerin > Jacob Kollanukkaran ; Kiran Kumar Kokkilagadda > ; Ferruh Yigit > Subject: [RFC 0/4] mempoo

Re: [dpdk-dev] [EXT] Re: [PATCH v4 0/3] vfio: fix broken msix interrupt initialization

2019-07-22 Thread Nithin Kumar Dabilpuram
On 7/23/2019 1:08 AM, David Marchand wrote: > External Email > > -- > On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram > wrote: >> A final patch for below mentioned RFC patch discussions. >> >> [RFC PATCH v3 1/3] vfio: revert ch

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix ether pattern rule for fdir

2019-07-22 Thread Xing, Beilei
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, July 22, 2019 8:07 PM > To: Yigit, Ferruh ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; sta...@dpdk.org > Subject: [PATCH 1/2] net/i40e: fix ether pattern rule for fdir > > i40e FDIR doesn't allow to create f

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Tuesday, July 23, 2019 10:24 AM > To: Jerin Jacob Kollanukkaran ; Thomas Monjalon > ; David Marchand ; > Burakov, Anatoly > Cc: dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection > > > -Orig

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Stojaczyk, Dariusz
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Tuesday, July 23, 2019 6:19 AM > > > -Original Message- > > From: Stojaczyk, Dariusz > > Sent: Tuesday, July 23, 2019 9:06 AM > > To: Thomas Monjalon ; David Marchand > > ; Burakov, Anatoly

[dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error

2019-07-22 Thread Wei Zhao
There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta table size get function for vf port, and this will cause error when update reta for x550 vf port. And also when function ixgbe_reta_size_get() is called, it should return other ixgbe NIC vf reta support or not, not only x

[dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error

2019-07-22 Thread Wei Zhao
There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta table size get function for vf port, and this will cause error when update reta for x550 vf port. And also when function is ixgbe_reta_size_get() called, it should return other ixgbe NIC vf reta support or not, not only x

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Stojaczyk, Dariusz > Sent: Tuesday, July 23, 2019 9:06 AM > To: Thomas Monjalon ; David Marchand > ; Burakov, Anatoly > ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org > Subject: [EXT] RE: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection > > This intro

[dpdk-dev] [PATCH 2/2] net/i40e: fix fdir rule destroy failure

2019-07-22 Thread Xiaolong Ye
We should tear down the fdir when the last flow is destroyed, current logic is opposite to expected behavior, this patch fixes this issue. Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") Cc: sta...@dpdk.org Cc: xiaoyun...@intel.com Signed-off-by: Xiaolong Ye --- drivers/net

[dpdk-dev] [PATCH 1/2] net/i40e: fix ether pattern rule for fdir

2019-07-22 Thread Xiaolong Ye
i40e FDIR doesn't allow to create flow with empty spec and mask for ethertype pattern. Without this patch, below flow would be created successfully which is unexpected. > flow create 0 ingress pattern eth / end actions drop / end Fixes: 7d83c152a207 ("net/i40e: parse flow director filter") Cc: st

[dpdk-dev] [PATCH 6/6] net/ice/base: fix for and/or bitmap routines

2019-07-22 Thread Qi Zhang
There was an issue with ice_and_bitmap and ice_or_bitmap when dealing with bit array sizes that are not even multiples of 32, where some of relevant bits in the highest 32 bits were being cleared. This patch fixes those problems. Fixes: c9e37832c95f ("net/ice/base: rework on bit ops") Cc: sta...@d

[dpdk-dev] [PATCH 5/6] net/ice/base: cleanup hardware register macros

2019-07-22 Thread Qi Zhang
Cleanup hardware registers macros in ice_auto_generator.h. Fixes: 51c7f09f3f81 ("net/ice/base: add registers for Intel E800 Series NIC") Cc:sta...@dpdk.org Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 - drivers/net/ice/base/ice_hw_

[dpdk-dev] [PATCH 2/6] net/ice/base: fix resource leak

2019-07-22 Thread Qi Zhang
We don't free s_rule if ice_aq_sw_rules() returns a non-zero status. If it returned a zero status, s_rule would be freed right after, so this implies it should be freed within the scope of the function regardless. Fixes: c7dd15931183 ("net/ice/base: add virtual switch code") Cc: sta...@dpdk.org S

[dpdk-dev] [PATCH 4/6] net/ice/base: use macro instead of function name

2019-07-22 Thread Qi Zhang
use __func__ instead of function name in ice_debug calls. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_controlq.c | 2 +- drivers/net/ice/base/ice_flex_pipe.c | 12 ++-- drivers/net/ice/base/ice_n

[dpdk-dev] [PATCH 1/6] net/ice/base: fix inner TCP and UDP support for GRE

2019-07-22 Thread Qi Zhang
The dummy packets for GRE were set up for IP, but not inner TCP or UDP. There are some applications that want to be able to parse on those inner L4 headers so add them to the dummy packets. Also, the GRE dummy packet was formatted differently from the other dummy packets so change the formatting t

[dpdk-dev] [PATCH 3/6] net/ice/base: fix ptype variable size

2019-07-22 Thread Qi Zhang
Change ptype variable to correctly be 16-bits in ice_prof_map structure. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Cc: sta...@dpdk.org Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 3 ++-

[dpdk-dev] [PATCH 0/6] net/ice/base: couple share code fix

2019-07-22 Thread Qi Zhang
Qi Zhang (6): net/ice/base: fix inner TCP and UDP support for GRE net/ice/base: fix resource leak net/ice/base: fix ptype variable size net/ice/base: use macro instead of function name net/ice/base: cleanup hardware register macros net/ice/base: fix for and/or bitmap routines drivers/

[dpdk-dev] [PATCH 5/6] net/ice/base: cleanup hardware register macros

2019-07-22 Thread Qi Zhang
Cleanup hardware registers macros in ice_auto_generator.h. Fixes: 51c7f09f3f81 ("net/ice/base: add registers for Intel E800 Series NIC") Cc:sta...@dpdk.org Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 - drivers/net/ice/base/ice_hw_

[dpdk-dev] [PATCH 4/6] net/ice/base: use macro instead of function name

2019-07-22 Thread Qi Zhang
use __func__ instead of function name in ice_debug calls. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c| 2 +- drivers/net/ice/base/ice_controlq.c | 2 +- drivers/net/ice/base/ice_flex_pipe.c | 12 ++-- drivers/net/ice/base/ice_n

[dpdk-dev] [PATCH 6/6] net/ice/base: fix for and/or bitmap routines

2019-07-22 Thread Qi Zhang
There was an issue with ice_and_bitmap and ice_or_bitmap when dealing with bit array sizes that are not even multiples of 32, where some of relevant bits in the highest 32 bits were being cleared. This patch fixes those problems. Fixes: c9e37832c95f ("net/ice/base: rework on bit ops") Cc: sta...@d

[dpdk-dev] [PATCH 3/6] net/ice/base: fix ptype variable size

2019-07-22 Thread Qi Zhang
Change ptype variable to correctly be 16-bits in ice_prof_map structure. Fixes: 51d04e4933e3 ("net/ice/base: add flexible pipeline module") Cc: sta...@dpdk.org Signed-off-by: Dan Nowlin Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 3 ++-

[dpdk-dev] [PATCH 2/6] net/ice/base: fix resource leak

2019-07-22 Thread Qi Zhang
We don't free s_rule if ice_aq_sw_rules() returns a non-zero status. If it returned a zero status, s_rule would be freed right after, so this implies it should be freed within the scope of the function regardless. Fixes: c7dd15931183 ("net/ice/base: add virtual switch code") Cc: sta...@dpdk.org S

[dpdk-dev] [PATCH 1/6] net/ice/base: fix inner TCP and UDP support for GRE

2019-07-22 Thread Qi Zhang
The dummy packets for GRE were set up for IP, but not inner TCP or UDP. There are some applications that want to be able to parse on those inner L4 headers so add them to the dummy packets. Also, the GRE dummy packet was formatted differently from the other dummy packets so change the formatting t

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Stojaczyk, Dariusz
This introduces a regression where uio-bound devies are attached to a DPDK app at runtime. When there are no devices attached at initialization, the only safe default should be RTE_IOVA_PA. With RTE_IOVA_VA we just won't be able to do any DMA to uio-bound PCI devices. Can we revert this patch?

Re: [dpdk-dev] [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-22 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Tuesday, July 23, 2019 12:57 AM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; gage.e...@intel.com; > hemant.agra...@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error

2019-07-22 Thread Zhao1, Wei
Add cc HaiyangX > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, July 23, 2019 11:21 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z > Subject: RE: [PATCH] net/ixgbe: fix x550 reta set fail error > > Tested-by: Zhao HaiyangX > > > > -Original Message- > > Fro

Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error

2019-07-22 Thread Zhao1, Wei
Tested-by: Zhao HaiyangX > -Original Message- > From: Zhao1, Wei > Sent: Monday, July 22, 2019 2:05 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: fix x550 reta set fail error > > There is a bug in function ixgbevf_dev_info_get(),

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix NVGRE matching

2019-07-22 Thread Jack Min
On Mon, 19-07-22, 18:36, Dekel Peled wrote: > NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol > value 0x6558. > These should be matched when item_nvgre is provided. > > This patch adds validation function of NVGRE item. > It also updates the translate function of NVGRE item, to a

Re: [dpdk-dev] [PATCH v4 0/3] vfio: fix broken msix interrupt initialization

2019-07-22 Thread David Marchand
On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram wrote: > > A final patch for below mentioned RFC patch discussions. > > [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe > http://mails.dpdk.org/archives/dev/2019-July/138358.html > [RFC PATCH v3 2/3] eal: add mask and

Re: [dpdk-dev] [PATCH v4 2/3] eal: add ack interrupt API

2019-07-22 Thread David Marchand
On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram wrote: > > Add new ack interrupt API to avoid using > VFIO_IRQ_SET_ACTION_TRIGGER(rte_intr_enable()) for > acking interrupt purpose for VFIO based interrupt handlers. > This implementation is specific to Linux. > > Using rte_intr_enable() for ackin

Re: [dpdk-dev] [PATCH v4 3/3] drivers/net: use ack API in interrupt handlers

2019-07-22 Thread David Marchand
On Thu, Jul 18, 2019 at 4:37 PM Nithin Dabilpuram wrote: > > Replace rte_intr_enable() with rte_intr_ack() API > for acking an interrupt in interrupt handlers and > rx_queue_intr_enable() callbacks of PMD's. > > This is inline with original intent of this change in PMDs > to ack interrupts after h

Re: [dpdk-dev] [PATCH v4 1/3] vfio: revert change that does intr eventfd setup at probe

2019-07-22 Thread David Marchand
On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram wrote: > > This reverts commit 89aac60e0be9ed95a87b16e3595f102f9faaffb4. > "vfio: fix interrupts race condition" > > The above mentioned commit moves the interrupt's eventfd setup > to probe time but only enables one interrupt for all types of > in

Re: [dpdk-dev] [PATCH] net/mlx5: fix icc compilation issue with type qualifier

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 7:26 PM, Viacheslav Ovsiienko wrote: > This fixes icc warning "type qualifier is meaningless on cast type". > > [1] http://patches.dpdk.org/patch/56810/ > > Fixes: aa0d2b1bec2d ("net/mlx5: introduce Tx burst routine template") > > Signed-off-by: Viacheslav Ovsiienko Squashed into

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-22 Thread Slava Ovsiienko
> >> On 7/21/2019 3:24 PM, Viacheslav Ovsiienko wrote: > >>> Mellanox NICs support the wide set of Tx offloads. The supported > >>> offloads are reported by the mlx5 PMD in rte_eth_dev_info > >>> tx_offload_capa field. An application may choose any combination of > >>> supported offloads and config

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2019 19:31:08 +0200 Thomas Monjalon wrote: > 22/07/2019 19:13, Stephen Hemminger: > > Thomas Monjalon wrote: > > > Are the constructors run on dlopen of the bus driver? > > > > Yes, constructors are run on dlopen. > > But application should not have to ask DPDK to dlopen the

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 6:57 PM, Lance Richardson wrote: > On Mon, Jul 22, 2019 at 11:06 AM Thomas Monjalon wrote: >> >> 22/07/2019 16:57, Ferruh Yigit: >>> On 7/18/2019 4:36 AM, Ajit Khaparde wrote: From: Lance Richardson --- a/config/common_base +++ b/config/common_base @@ -212,6 +212,

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2019 19:31:08 +0200 Thomas Monjalon wrote: > 22/07/2019 19:13, Stephen Hemminger: > > Thomas Monjalon wrote: > > > Are the constructors run on dlopen of the bus driver? > > > > Yes, constructors are run on dlopen. > > But application should not have to ask DPDK to dlopen the

[dpdk-dev] [PATCH] net/mlx5: fix icc compilation issue with type qualifier

2019-07-22 Thread Viacheslav Ovsiienko
This fixes icc warning "type qualifier is meaningless on cast type". [1] http://patches.dpdk.org/patch/56810/ Fixes: aa0d2b1bec2d ("net/mlx5: introduce Tx burst routine template") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-22 Thread Lance Richardson
On Mon, Jul 22, 2019 at 11:06 AM Thomas Monjalon wrote: > > 22/07/2019 16:57, Ferruh Yigit: > > On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > > From: Lance Richardson > > > --- a/config/common_base > > > +++ b/config/common_base > > > @@ -212,6 +212,7 @@ CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Thomas Monjalon
22/07/2019 19:13, Stephen Hemminger: > Thomas Monjalon wrote: > > Are the constructors run on dlopen of the bus driver? > > Yes, constructors are run on dlopen. > But application should not have to ask DPDK to dlopen the bus devices. > > The core principle is that dynamic build of DPDK should ac

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2019 19:04:55 +0200 Thomas Monjalon wrote: > 22/07/2019 18:43, Stephen Hemminger: > > On Mon, 22 Jul 2019 10:06:11 +0100 > > Bruce Richardson wrote: > > > On Mon, Jul 22, 2019 at 09:38:27AM +0200, Thomas Monjalon wrote: > > > > 19/07/2019 22:55, Stephen Hemminger: > > > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow

2019-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2019 18:02:09 +0100 Ferruh Yigit wrote: > On 7/22/2019 5:58 PM, Ferruh Yigit wrote: > > MAC address parsing was causing failure [1], > > this patch partially reverts the commit > > commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") > > > > [1] > > testpmd> flow

Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 6:02 PM, Ferruh Yigit wrote: > On 7/22/2019 5:58 PM, Ferruh Yigit wrote: >> MAC address parsing was causing failure [1], >> this patch partially reverts the commit >> commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") >> >> [1] >> testpmd> flow validate 0 priority 2

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 6:03 PM, Iremonger, Bernard wrote: > Hi Ferruh, > > > >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip >> offload >> >> On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: >>> From: Vivek Sharma >>> >>> Support QinQ strip RX offload co

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Iremonger, Bernard
Hi Ferruh, > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip > offload > > On 7/17/2019 8:45 AM, viveksha...@marvell.com wrote: > > From: Vivek Sharma > > > > Support QinQ strip RX offload configuration through testpmd > > command line and boo

Re: [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct

2019-07-22 Thread Thomas Monjalon
22/07/2019 14:21, Ananyev, Konstantin: > From: Marcin Zapolski > > The eth_dev_info was used with content that was obsolete. Added update > > of struct content prior to use. > > > > Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device > > array") Cc: sta...@dpdk.org > > >

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Thomas Monjalon
22/07/2019 18:43, Stephen Hemminger: > On Mon, 22 Jul 2019 10:06:11 +0100 > Bruce Richardson wrote: > > On Mon, Jul 22, 2019 at 09:38:27AM +0200, Thomas Monjalon wrote: > > > 19/07/2019 22:55, Stephen Hemminger: > > > > The root cause is that recent gcc won't run constructor on unused > > > > l

Re: [dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement

2019-07-22 Thread Thomas Monjalon
22/07/2019 18:55, Thomas Monjalon: > When using --no-huge mode, dynamic allocation is not supported. > Because of this limitation, the option --legacy-mem is implied > and -m may be needed to specify the amount of memory to allocate. > Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be al

Re: [dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 5:58 PM, Ferruh Yigit wrote: > MAC address parsing was causing failure [1], > this patch partially reverts the commit > commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") > > [1] > testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst > is 98:03:9B:5C

Re: [dpdk-dev] [EXT] [PATCH v6 3/3] eal/stack: enable lock-free stack for aarch64

2019-07-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Phil Yang > Sent: Monday, July 22, 2019 9:53 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > gage.e...@intel.com; hemant.agra...@nxp.com; > honnappa.nagaraha...@arm.com; gavin...@arm.com; n...@arm.com > Subject: [EXT] [PATCH v6 3/

[dpdk-dev] [PATCH] app/testpmd: fix MAC addr parser for flow

2019-07-22 Thread Ferruh Yigit
MAC address parsing was causing failure [1], this patch partially reverts the commit commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") [1] testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad arguments

Re: [dpdk-dev] [EXT] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Phil Yang > Sent: Monday, July 22, 2019 9:53 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > gage.e...@intel.com; hemant.agra...@nxp.com; > honnappa.nagaraha...@arm.com; gavin...@arm.com; n...@arm.com > Subject: [EXT] [PATCH v6 1/

[dpdk-dev] [PATCH v2] eal: warn on legacy memory allocation requirement

2019-07-22 Thread Thomas Monjalon
When using --no-huge mode, dynamic allocation is not supported. Because of this limitation, the option --legacy-mem is implied and -m may be needed to specify the amount of memory to allocate. Otherwise the default amount MEMSIZE_IF_NO_HUGE_PAGE will be allocated. Signed-off-by: Thomas Monjalon -

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 2:07 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, July 22, 2019 14:53 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Yongseok Koh >> Subject: Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine >> template >> >> On 7/21/

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx5: introduce Tx burst routine template

2019-07-22 Thread Yongseok Koh
> On Jul 22, 2019, at 9:45 AM, Ferruh Yigit wrote: > > On 7/22/2019 2:07 PM, Slava Ovsiienko wrote: >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Monday, July 22, 2019 14:53 >>> To: Slava Ovsiienko ; dev@dpdk.org >>> Cc: Yongseok Koh >>> Subject: Re: [dpdk-dev] [PATCH v4 6/8

Re: [dpdk-dev] [PATCH] pci: fix missing pci bus with shared library build

2019-07-22 Thread Stephen Hemminger
On Mon, 22 Jul 2019 10:06:11 +0100 Bruce Richardson wrote: > On Mon, Jul 22, 2019 at 09:38:27AM +0200, Thomas Monjalon wrote: > > 19/07/2019 22:55, Stephen Hemminger: > > > On Tue, 16 Jul 2019 09:46:04 +0100 > > > Bruce Richardson wrote: > > > > > > > On Mon, Jul 15, 2019 at 05:19:12PM -070

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/librte_eal: fix unrecongized telemetry eal arg

2019-07-22 Thread Thomas Monjalon
19/07/2019 12:04, Laatz, Kevin: > On 15/07/2019 11:54, Sean Morrissey wrote: > > Added telemetry to EAL long options so that when > > --telemetry is passed as an EAL arg that there is > > no unrecognized argument error message printed. > > > > Fixes: 8877ac688b52 ("telemetry: introduce infrastructu

Re: [dpdk-dev] [EXT] [PATCH v5 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-22 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, July 22, 2019 10:20 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; gage.e...@intel.com; > hemant.agra...@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > S

[dpdk-dev] [PATCH v6 2/3] test/atomic: add 128b compare and swap test

2019-07-22 Thread Phil Yang
Add 128b atomic compare and swap test for aarch64 and x86_64. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Acked-by: Gage Eads Acked-by: Jerin Jacob Tested-by: Jerin Jacob --- app/test/test_atomic.c | 120 - 1 file changed, 118 i

[dpdk-dev] [PATCH v6 3/3] eal/stack: enable lock-free stack for aarch64

2019-07-22 Thread Phil Yang
Enable both c11 atomic and non c11 atomic lock-free stack for aarch64. Introduced a new header to reduce the ifdef clutter across generic and c11 files. The rte_stack_lf_stubs.h contains stub implementations of __rte_stack_lf_count, __rte_stack_lf_push_elems and __rte_stack_lf_pop_elems. Suggeste

[dpdk-dev] [PATCH v6 1/3] eal/arm64: add 128-bit atomic compare exchange

2019-07-22 Thread Phil Yang
Add 128-bit atomic compare exchange on aarch64. Suggested-by: Jerin Jacob Signed-off-by: Phil Yang Tested-by: Honnappa Nagarahalli Reviewed-by: Honnappa Nagarahalli --- v6: 1. Put the RTE_ARM_FEATURE_ATOMICS flag into EAL group. (Jerin Jocob) 2. Keep rte_stack_lf_stubs.h doing nothing. (Gage

Re: [dpdk-dev] [PATCH v9 07/11] app/testpmd: use new ethernet address parser

2019-07-22 Thread Ferruh Yigit
On 7/21/2019 2:42 PM, Raslan Darawsheh wrote: > Hi Guys, > > We have a failure in testpmd commands when parsing rte_flow commands as > following which were interduce by this patch: > > This rule is a valid rule to be added to testpmd: > flow validate 0 priority 2 ingress group 0 pattern eth d

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix rxq start

2019-07-22 Thread Ferruh Yigit
On 7/20/2019 8:19 AM, Ajit Khaparde wrote: > From: Kalesh AP > > 1. Added a missing return in bnxt_alloc_hwrm_rx_ring(). > 2. Added a missing return value check > 3. Moved the log message to right place. > > Fixes: 05b5e4821c1e ("net/bnxt: use dedicated CPR for async events") > > Reviewed-by: L

Re: [dpdk-dev] [EXT] Re: [PATCH v3] app/testpmd: add device related cmds

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 7:15 AM, Nithin Kumar Dabilpuram wrote: > > On 7/22/2019 11:31 AM, Hemant Agrawal wrote: >> HI, >>> On 7/18/2019 6:27 AM, Nithin Kumar Dabilpuram wrote: Hi Ferruh, On 7/17/2019 10:21 PM, Ferruh Yigit wrote: > External Email > > --

Re: [dpdk-dev] [PATCH 1/2] net/ark: remove queue offset based on port id

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 1:35 PM, Ed Czeck wrote: > Queue index was incorrectly incremented with port, which > caused incorrect queue packet placement. This manifested > when port number was != 0. > > Fixes: c33d45af3633 ("net/ark: add Tx initial version") > Cc: sta...@dpdk.org > > Signed-off-by: Ed Czeck

Re: [dpdk-dev] [PATCH] eal/freebsd: add support for base virtaddr option

2019-07-22 Thread Thomas Monjalon
16/07/2019 13:25, Anatoly Burakov: > According to our docs, only Linuxapp supports base-virtaddr option. > That is, strictly speaking, not true because most of the things > that are attempting to respect base-virtaddr are in common files, > so FreeBSD already *mostly* supports this option in practi

Re: [dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration

2019-07-22 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: kka...@marvell.com > Sent: Monday, July 22, 2019 8:29 PM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: Krzysztof Kanas > Subject: [dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration >

Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"

2019-07-22 Thread Thomas Monjalon
11/07/2019 00:18, Thomas Monjalon: > 09/07/2019 16:39, Stephen Hemminger: > > On Fri, 7 Jun 2019 16:08:41 -0700 > > Stephen Hemminger wrote: > > > > > From: Stephen Hemminger > > > > > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. > > > That commit breaks support for netvsc P

Re: [dpdk-dev] [PATCH v4 0/4] Fixes on IOVA mode selection

2019-07-22 Thread Thomas Monjalon
22/07/2019 14:56, David Marchand: > Following the issues reported by Jerin and the discussion that emerged > from it, here are fixes to restore and document the behavior of the EAL > and the pci bus driver. > > I pondered all the arguments and tried to have the less changes > possible. > I can't f

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Ferruh Yigit
On 7/22/2019 3:55 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Monday, July 22, 2019 3:27 PM >> To: Iremonger, Bernard ; >> viveksha...@marvell.com; dev@dpdk.org >> Cc: intoviveksha...@gmail.com >> Subject: Re: [dpdk-dev] [PATCH] app/te

Re: [dpdk-dev] [PATCH] net/mlx5: fix NVGRE matching

2019-07-22 Thread Dekel Peled
Thanks, sent v2. > -Original Message- > From: Jack Min > Sent: Monday, July 22, 2019 3:10 PM > To: Dekel Peled > Cc: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler ; Ori > Kam ; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix NVGRE matching > > On Mon, 19-07-22, 19:33, Dekel Peled wr

[dpdk-dev] [PATCH v2] net/mlx5: fix NVGRE matching

2019-07-22 Thread Dekel Peled
NVGRE has a GRE header with c_rsvd0_ver value 0x2000 and protocol value 0x6558. These should be matched when item_nvgre is provided. This patch adds validation function of NVGRE item. It also updates the translate function of NVGRE item, to add the required values, if they were not specified. Ori

[dpdk-dev] SR-IOV set_mc_addr_list differences in i40evf and ixgbevf drivers

2019-07-22 Thread Anthony Dempsey
Hi, In the i40evf driver when trying to add a list of addresses that contains the broadcast MAC address the call to i40evf_set_mc_addr_list will error out complaining that the broadcast address isn't a valid address. I haven't seen this happen in a similar set up using the ixgbevf driver. Is this

Re: [dpdk-dev] [EXT] [PATCH v5 3/3] eal/stack: enable lock-free stack for aarch64

2019-07-22 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, July 22, 2019 10:15 PM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org > Cc: tho...@monjalon.net; gage.e...@intel.com; > hemant.agra...@nxp.com; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > S

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-22 Thread Thomas Monjalon
22/07/2019 16:57, Ferruh Yigit: > On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > > From: Lance Richardson > > --- a/config/common_base > > +++ b/config/common_base > > @@ -212,6 +212,7 @@ CONFIG_RTE_LIBRTE_BNX2X_DEBUG_PERIODIC=n > > # Compile burst-oriented Broadcom BNXT PMD driver > > # > > CONF

Re: [dpdk-dev] [PATCH 09/22] net/bnxt: use dedicated cpr for async events

2019-07-22 Thread Ferruh Yigit
On 7/18/2019 4:36 AM, Ajit Khaparde wrote: > From: Lance Richardson > > This commit enables the creation of a dedicated completion > ring for asynchronous event handling instead of handling these > events on a receive completion ring. > > For the stingray platform and other platforms needing tig

[dpdk-dev] [PATCH v2] net/octeontx2: fix driver reconfiguration

2019-07-22 Thread kkanas
From: Krzysztof Kanas When configure returns error, e.g. in case not supported offloads (outer ip and sctp) driver released Rx,Tx queues. Then in case of correct configuration the driver could not start due to queues already released but the driver thought it was configured correctly. Secondly i

Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload

2019-07-22 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Monday, July 22, 2019 3:27 PM > To: Iremonger, Bernard ; > viveksha...@marvell.com; dev@dpdk.org > Cc: intoviveksha...@gmail.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support QinQ strip offload > > On 7/22/2019 1:04 PM

[dpdk-dev] [PATCH v2 27/28] net/mlx5: adjust the maximum LRO message size

2019-07-22 Thread Matan Azrad
LRO message is contained in the MPRQ strides. While the LRO message size cannot be bigger than 65280 according to the PRM, the strides which contain it may be bigger than the maximum buffer size allowed in dpdk mbuf - 0x. Adjust the maximum LRO message size to avoid buffer length overflow. Si

[dpdk-dev] [PATCH v2 28/28] doc: update MLX5 doc and release notes with LRO

2019-07-22 Thread Matan Azrad
From: Dekel Peled Add documentation of LRO feature. Signed-off-by: Dekel Peled Acked-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 14 ++ doc/guides/rel_notes/release_19_08.rst | 2 +- 3

[dpdk-dev] [PATCH v2 26/28] net/mlx5: zero the LRO mbuf headroom

2019-07-22 Thread Matan Azrad
LRO packet may consume all the stride memory, hence the PMD cannot guaranty head-room for the LRO mbuf. The issue is lack in HW support to write the packet in offset from the stride start. A new striding RQ feature may be added in CX6 DX to allow head-room and tail-room for the LRO strides. Sign

[dpdk-dev] [PATCH v2 25/28] net/mlx5: handle LRO packets in Rx queue

2019-07-22 Thread Matan Azrad
When LRO offload is configured in Rx queue, the HW may coalesce TCP packets from same TCP connection into single packet. In this case the SW should fix the relevant packet headers because the HW doesn't update them according to the new created packet characteristics. Add update header code to the

[dpdk-dev] [PATCH v2 16/28] net/mlx5: rename hash RxQ verbs to general

2019-07-22 Thread Matan Azrad
From: Dekel Peled Prepare for introducing use of DevX TIR object. Hash Rx queue is currently created using verbs QP only. The next patches will add the option to create it with a TIR object using DevX. This patch renames hrxq_ibv to hrxq wherever relevant, and adds the DevX items to relevant stru

[dpdk-dev] [PATCH v2 24/28] net/mlx5: update LRO fields in completion entry

2019-07-22 Thread Matan Azrad
Update the CQE structure to include LRO fields. Some reserved values were changed, hence also data-path code used the reserved values were updated accordingly. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_prm.h | 12 +--- drivers/net/mlx5

[dpdk-dev] [PATCH v2 19/28] net/mlx5: func to create Rx verbs completion queue

2019-07-22 Thread Matan Azrad
From: Dekel Peled Verbs CQ for RxQ is created inside function mlx5_rxq_obj_new(). This patch moves the creation of CQ to dedicated function mlx5_ibv_cq_new(). Signed-off-by: Dekel Peled Acked-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_rxq.c | 159 +++

[dpdk-dev] [PATCH v2 14/28] net/mlx5: rename RxQ verbs to general RxQ object

2019-07-22 Thread Matan Azrad
From: Dekel Peled Prepare for introducing of DevX RxQ object. RxQ object is currently created using verbs only. The next patches will add the option to create RxQ object using DevX. This patch renames rxq_ibv to rxq_obj wherever relevant, and adds the DevX items to relevant structs. Signed-off-b

[dpdk-dev] [PATCH v2 15/28] net/mlx5: rename verbs indirection table to obj

2019-07-22 Thread Matan Azrad
From: Dekel Peled Prepare for introducing of DevX RQT object. Rx indirection table object is currently created using verbs only. The next patches will add the option to create an RQT object using DevX. This patch renames ind_table_ibv to ind_table_obj wherever relevant, and adds the DevX items to

  1   2   3   >