Re: [dpdk-dev] [EXT] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-26 Thread Shally Verma
> -Original Message- > From: Fiona Trahe > Sent: Thursday, July 25, 2019 10:34 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; fiona.tr...@intel.com; Shally Verma > > Subject: [EXT] [PATCH] compressdev: clarify destination buffer size for > corner case > > External Email > > ---

Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward

2019-07-26 Thread Ye Xiaolong
On 07/26, Wang Ying A wrote: >The patch fix the issue that lldp packet can't be forwarded to host. > >Fixes: 59d151de6673 ("net/ice: stop LLDP by default") >Cc: sta...@dpdk.org > >Signed-off-by: Wang Ying A >--- >--- >V2: Remove redundant macro definiton and function argument; >Modify the func

Re: [dpdk-dev] [PATCH v2] net/ice: fix LLDP forward

2019-07-26 Thread Yang, Qiming
Hi, Ying > -Original Message- > From: Wang, Ying A > Sent: Thursday, July 25, 2019 4:36 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Yang, Qiming ; Wang, Ying A > ; sta...@dpdk.org > Subject: [PATCH v2] net/ice: fix LLDP forward > > The patch fix the issue that lldp packet can't be forwarded

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Stephen Hemminger > Sent: Friday, July 26, 2019 1:51 PM > To: Hyong Youb Kim (hyonkim) > Cc: John Daley (johndale) ; Ferruh Yigit > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging > > On Fri, 26 Jul 2019 04:21:23

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 04:21:23 + "Hyong Youb Kim (hyonkim)" wrote: > > -Original Message- > > From: John Daley (johndale) > > Sent: Friday, July 26, 2019 5:26 AM > > To: Ferruh Yigit > > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > > Subject: RE: [PATCH] net/enic: retain previous mess

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 26, 2019 3:01 AM > To: John Daley (johndale) > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: Re: [PATCH] net/enic: retain previous message logging > > On 7/26/2019 9:17 AM, John Daley (johndale) wrote: > > Actually

[dpdk-dev] [PATCH v2] net/enic: retain previous message logging

2019-07-26 Thread John Daley
Prior to the fix, RTE_LOGTYPE_INFO messages were displayed by default. After the fix, only NOTICE level and higher were displayed by default and INFO level were not. There are INFO level vNIC config related messages which customers and tech support currently depend on for debugging and so on and to

Re: [dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 09/11] port: replace license text with SPDX tag > > Signed-off-by: Xiaolong Ye > Acked-by: Bruce Richards

Re: [dpdk-dev] [PATCH v2 07/11] ethdev: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > ; Thomas Monjalon > ; Andrew Rybchenko > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 07/11] ethdev: replace license text with SPDX tag > > Signed-off-

Re: [dpdk-dev] [PATCH v2 05/11] examples/qos_sched: replace license text with SPDX tag

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Ye, Xiaolong > Sent: Friday, July 26, 2019 5:44 PM > To: Yigit, Ferruh ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH v2 05/11] examples/qos_sched: replace license text with > SPDX tag > > Signed-off-by: Xiaolong Ye > Acked-by

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer to sched library

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, July 26, 2019 5:42 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] maintainers: add co-maintainer to sched library > > Add myself as a co-maintainer to dpdk sched library. > > Signed-off-by: Jasvinder Si

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> From: Burakov, Anatoly > > On 26-Jul-19 5:44 PM, Lipiec, Herakliusz wrote: > > > > > >> -Original Message- > >> From: Burakov, Anatoly > >> > >> On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: > >>> > >>> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, > Anato

Re: [dpdk-dev] [PATCH v2 08/11] lpm: replace license text with SPDX tag

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Xiaolong Ye > Sent: Friday, July 26, 2019 10:14 PM > To: Ferruh Yigit ; Jerin Jacob Kollanukkaran > ; Gavin Hu ; Bruce Richardson > ; Vladimir Medvedkin > > Cc: dev@dpdk.org; Xiaolong Ye > Subject: [PATCH v2 08/11] lpm: replace license text with SPDX tag

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 5:44 PM, Lipiec, Herakliusz wrote: -Original Message- From: Burakov, Anatoly On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53

Re: [dpdk-dev] [PATCH v2 06/11] app/test-eventdev: replace license text with SPDX tag

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Xiaolong Ye > Sent: Friday, July 26, 2019 10:14 PM > To: Ferruh Yigit ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Xiaolong Ye > Subject: [EXT] [PATCH v2 06/11] app/test-eventdev: replace license text with > SPDX tag > > -

[dpdk-dev] [PATCH v4 4/4] examples/multi_process/client_server_mp/mp_server: use ether format address

2019-07-26 Thread Stephen Hemminger
No need to use snprintf to print ethernet address. Signed-off-by: Stephen Hemminger --- .../client_server_mp/mp_server/main.c | 32 ++- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/mult

[dpdk-dev] [PATCH v4 3/4] examples/multi_process/client_server_mp/mp_server: fix style

2019-07-26 Thread Stephen Hemminger
Lots of little style complaints from checkpatch. Signed-off-by: Stephen Hemminger --- .../client_server_mp/mp_server/args.c | 37 ++-- .../client_server_mp/mp_server/init.c | 58 +++ .../client_server_mp/mp_server/main.c | 44 +++--- 3 file

[dpdk-dev] [PATCH v4 0/4] examples/client_server_mp: fix port issues

2019-07-26 Thread Stephen Hemminger
The client_server_mp application does not work correctly with failsafe or other devices using port ownership. v4 - fix checkpatch warning add patches to fix style issues and use ether format addr v3 - merge both patches in one series use alternative algorithm to check port ownership (N^

[dpdk-dev] [PATCH v4 2/4] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports

2019-07-26 Thread Stephen Hemminger
From: Stephen Hemminger The mp_client crashes if run on Azure or any system where ethdev ports are owned. In that case, the tx_buffer and tx_stats for the real port were initialized correctly, but the wrong port was used. For example if the server has Ports 3 and 5. Then calling rte_eth_tx_buffe

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> -Original Message- > From: Burakov, Anatoly > > On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: > > > > > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > >> On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: > >>> On Fri, 26 Jul 2019 10:53:58 +0100 > >>> "Burakov

[dpdk-dev] [PATCH v4 1/4] examples/multi_process/client_server_mp: check port validity

2019-07-26 Thread Stephen Hemminger
From: Stephen Hemminger The mp_server incorrectly allows a port mask that included hidden ports and which later caused either lost packets or failed initialization. This fixes explicitly checking that each bit in portmask is a valid port before using it. Fixes: 5b7ba31148a8 ("ethdev: add port o

[dpdk-dev] [PATCH v2 09/11] port: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_port/rte_port_kni.c | 35 +++--- lib/librte_port/rte_port_kni.h | 35 +++--- 2 files changed, 6 insertions(+), 64 deletions(-) diff --git a/lib/librte_port/rte_port_kni.c

[dpdk-dev] [PATCH v2 00/11] add SPDX tags to files with Intel copyright

2019-07-26 Thread Xiaolong Ye
This patchset replaces full BSD-3 license header with spdx tag for the remaining files that have Intel copyright. V2 changes: 1. remove "All rights reserved" 2. change "Intel shannon Ltd" to "Intel Corporation" 3. add ack tag from Bruce Xiaolong Ye (11): net/ixgbe: replace license text with

[dpdk-dev] [PATCH v2 11/11] eal: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- .../common/include/arch/x86/rte_atomic_32.h | 33 ++- .../common/include/arch/x86/rte_atomic_64.h | 33 ++- lib/librte_eal/common/include/rte_keepalive.h | 32 ++ lib/librte_eal/freebsd/

[dpdk-dev] [PATCH v2 02/11] net/i40e: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/i40e/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 84f191fad..8a5339cff 100644 --- a/drive

[dpdk-dev] [PATCH v2 08/11] lpm: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_lpm/rte_lpm_neon.h | 39 +++ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/lib/librte_lpm/rte_lpm_neon.h b/lib/librte_lpm/rte_lpm_neon.h index 28c815902..6c131d312 100644 --- a/l

[dpdk-dev] [PATCH v2 10/11] hash: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_hash/rte_jhash.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h index 42c45685b..7a1eeff74 100644 --- a/lib/librt

[dpdk-dev] [PATCH v2 06/11] app/test-eventdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- app/test-eventdev/parser.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/app/test-eventdev/parser.c b/app/test-eventdev/parser.c index 9de41bf4a..24f1855e9 100644 --- a/app/test-e

[dpdk-dev] [PATCH v2 07/11] ethdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- lib/librte_ethdev/rte_mtr.h | 36 lib/librte_ethdev/rte_tm.h | 37 - 2 files changed, 8 insertions(+), 65 deletions(-) diff --git a/lib/librte_ethdev/rte_mtr.h b/l

[dpdk-dev] [PATCH v2 05/11] examples/qos_sched: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- examples/qos_sched/profile.cfg| 32 ++- examples/qos_sched/profile_ov.cfg | 32 ++- 2 files changed, 4 insertions(+), 60 deletions(-) diff --git a/examples/qos_sched/profile.cfg

[dpdk-dev] [PATCH v2 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/vmxnet3/base/README | 34 +++-- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/vmxnet3/base/README b/drivers/net/vmxnet3/base/README index 599a3661e..aaf5d3086 100644 ---

[dpdk-dev] [PATCH v2 01/11] net/ixgbe: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/ixgbe/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 431be0260..b6b420e2f 100644 --- a/dr

[dpdk-dev] [PATCH v2 03/11] net/e1000: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye Acked-by: Bruce Richardson --- drivers/net/e1000/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index de1ae4cf7..56738d001 100644 --- a/dr

[dpdk-dev] [PATCH] maintainers: add co-maintainer to sched library

2019-07-26 Thread Jasvinder Singh
Add myself as a co-maintainer to dpdk sched library. Signed-off-by: Jasvinder Singh --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c2b575a94..fa4bad88a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1202,6 +1202,7 @@ F: doc/guides/sample_app_u

[dpdk-dev] [PATCH v2 2/2] mk: fix missing mempool driver registration

2019-07-26 Thread Stephen Hemminger
Since mempool driver is now registered during constructor, the mempool driver must always be linked in during shared library build. Otherwise, application will fail because of missing default mbuf pool operations. Fixes: c6b3570f9e14 ("mk: link app with ring mempool by default") Cc: sta...@dpdk.or

[dpdk-dev] [PATCH v2 1/2] bus: fix missing pci bus with shared library build

2019-07-26 Thread Stephen Hemminger
If DPDK is built as a shared library, then any application linked with rte.app.mk will not find any buses (including PCI devices). This is because the linker will not call the initializers of the bus libraries since they are not directly called by application or EAL. Bugzilla ID: 333 Fixes: c7529

[dpdk-dev] [PATCH v2 0/2] mk: fix build with shared library

2019-07-26 Thread Stephen Hemminger
If RTE_BUILD_SHARED_LIB is enabled, infrastruture libraries that use registration API's need to always be included. v2 - fix typo in Cc: for second patch Stephen Hemminger (2): bus: fix missing pci bus with shared library build mk: fix missing mempool driver registration mk/rte.app.mk | 9 +

[dpdk-dev] [PATCH] net/kni: remove resources when port is closed

2019-07-26 Thread Ferruh Yigit
Add .dev_close to clean resources on device close, also set RTE_ETH_DEV_CLOSE_REMOVE device flag to cause all ethdev resources removed on 'rte_eth_dev_close()' call. Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 38 +++ 1 file changed, 25 inserti

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 10:06 AM, David Marchand wrote: Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- Changelog since v1: - rte_service symbols who got promoted to stable got reintroduced in experimental when reba

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: NP to disallow it. In fact, I think it would be easier for ever

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: > > On Fri, 26 Jul 2019 10:53:58 +0100 > > "Burakov, Anatoly" wrote: > > > >>> > >>> NP to disallow it. > >>> In fact, I think it would be easier for everyone just to drop > >

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: NP to disallow it. In fact, I think it would be easier for everyone just to drop current DPDK MP model, and keep just standalone DPDK instances. That's the dream, but i don't think i

[dpdk-dev] [PATCH v4] eal: pick IOVA as PA if IOMMU is not available

2019-07-26 Thread Anatoly Burakov
When IOMMU is not available, /sys/kernel/iommu_groups will not be populated. This is happening since at least 3.6 when VFIO support was added. If the directory is empty, EAL should not pick IOVA as VA as the default IOVA mode. Signed-off-by: Anatoly Burakov Tested-by: Darek Stojaczyk Tested-by:

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 3:06 PM, David Marchand wrote: > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 3:09 AM, David Marchand wrote: Hello Michael, On Thu, Jul 25, 2019 at 11:31 PM Michael Santana wrote: This patch reduces the memory footprint of tables for the unit test. Lower memory footprint means the test now passes when trying to allocate the tables. This is mainly for tests i

Re: [dpdk-dev] [PATCH v3] eal: pick IOVA as PA if IOMMU is not available

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anatoly Burakov > Sent: Thursday, July 25, 2019 4:36 PM > To: dev@dpdk.org > Cc: John McNamara ; Marko Kovacevic > ; dariusz.stojac...@intel.com; > tho...@monjalon.net; david.march...@redhat.com; Jerin Jacob > Kollanukkaran > Subject: [EXT] [PATCH v3] eal: pic

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: > > > > NP to disallow it. > > In fact, I think it would be easier for everyone just to drop current DPDK > > MP model, > > and keep just standalone DPDK instances. > > That's the dream, but i don't think it'll ever come to fruitio

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread David Marchand
Thomas, On Fri, Jul 26, 2019 at 4:06 PM David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand > --- > Changelog since v1: > - rte_service symbols who got promoted to stable got reintro

Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-26 Thread Anoob Joseph
> -Original Message- > From: dev On Behalf Of Bernard Iremonger > Sent: Wednesday, July 24, 2019 3:43 PM > To: dev@dpdk.org; konstantin.anan...@intel.com; akhil.go...@nxp.com > Cc: Bernard Iremonger > Subject: [EXT] [dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec- > secgw > >

Re: [dpdk-dev] [PATCH] security: remove duplicated symbols from map file

2019-07-26 Thread Akhil Goyal
> > Fixes: f63ffee26f9c ("security: restore experimental tag for unimplemented > APIs") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > lib/librte_security/rte_security_version.map | 3 --- > 1 file changed, 3 deletions(-) > Good fix, Not sure how it went unnoticed. Acked-by:

[dpdk-dev] [PATCH] security: remove duplicated symbols from map file

2019-07-26 Thread Ferruh Yigit
Fixes: f63ffee26f9c ("security: restore experimental tag for unimplemented APIs") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- lib/librte_security/rte_security_version.map | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_sec

Re: [dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-26 Thread Akhil Goyal
Hi Anoob, Could you please Ack this patch if there is no issue? Thanks, Akhil > +Anoob, Jerin > > > > > All the functionality of the legacy code path in now available in > > the librte_ipsec library. It is planned to deprecate the legacy > > code path in the 19.11 release and remove the legacy

[dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread David Marchand
Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- Changelog since v1: - rte_service symbols who got promoted to stable got reintroduced in experimental when rebasing this patch on master --- lib/librte_eal

Re: [dpdk-dev] [PATCH] cryptodev: fix typo

2019-07-26 Thread Akhil Goyal
> > Remove extra ';' which is probably added unintentionally, reported by > ./devtools/check-includes.sh script. > > Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > lib/librte_cryptodev/rte_crypto_asym.h

Re: [dpdk-dev] [PATCH] eal: order experimental symbols per release

2019-07-26 Thread David Marchand
On Fri, Jul 26, 2019 at 3:52 PM David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Rebase damage... v2 in progress, sorry. -- David Marchand

Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow

2019-07-26 Thread Akhil Goyal
> > > > This patch fixes the issue of memory overwrite after the end of > > the output buffer by calculating its size as the number of all > > segments multipled by the output segment size. > > Additionally buffer overflow errors returned by PMD driver are > > detected and shown, ending the test.

[dpdk-dev] [PATCH v4] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning

2019-07-26 Thread Akhil Goyal
> Add missing return after setting the error status in case of > invalid flush_flag in the operation. > The issue was found by the coverity scan as the fin_flush variable, > not initialized in such case, was used later in the flow. > > CID 340859: Uninitialized variables (UNINIT) > > Fixes: c

Re: [dpdk-dev] [PATCH v1] test/crypto: improve asymmetric crypto testsuite setup

2019-07-26 Thread Akhil Goyal
> > Improve logic: > * to get list of valid devices based on driver id so that to > eliminate unnecessary if check for driver id match in device loop > * loop till 1st device supporting asymmetric feature is found unlike > previous logic which breaks on 1st device > > Signed-off-by:

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > > > Update release notes for recently supported features in IPsec library and > > IPsec Security Gateway application. > > > > Signed-off-by: Bernard Iremonger > > --- > > doc/guides/rel_notes/release_19_08.rst | 13 + > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > Ack

[dpdk-dev] [PATCH] eal: order experimental symbols per release

2019-07-26 Thread David Marchand
Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- lib/librte_eal/rte_eal_version.map | 110 + 1 file changed, 62 insertions(+), 48 deletions(-) diff --git a/lib/librte_eal

Re: [dpdk-dev] [PATCH] eal: resort symbols in EXPERIMENTAL section

2019-07-26 Thread David Marchand
On Thu, Jun 20, 2019 at 7:23 PM David Marchand wrote: > > > > On Fri, Jun 14, 2019 at 5:32 PM Ferruh Yigit wrote: >> >> On 6/14/2019 8:44 AM, David Marchand wrote: >> > On Fri, Jun 14, 2019 at 9:39 AM Thomas Monjalon >> > wrote: >> > >> >> 06/04/2019 05:30, Stephen Hemminger: >> >>> The symbols

[dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Bernard Iremonger
Update release notes for recently supported features in IPsec library and IPsec Security Gateway application. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_19_08.rst | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH] doc: announce cpuflags check symbol removal

2019-07-26 Thread Aaron Conole
David Marchand writes: > This symbol has been deprecated for quite some time. > Let's drop it in the next release. > > Signed-off-by: David Marchand > --- I don't know how many out-of-tree users there are. OVS doesn't use this symbol - and a brief look at github (first 25 pages of results) sho

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > Update release notes for recently supported features in IPsec library and > IPsec Security Gateway application. > > Signed-off-by: Bernard Iremonger > --- > doc/guides/rel_notes/release_19_08.rst | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > Acked-by: Akhil Goya

[dpdk-dev] [PATCH] cryptodev: fix typo

2019-07-26 Thread Ferruh Yigit
Remove extra ';' which is probably added unintentionally, reported by ./devtools/check-includes.sh script. Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- lib/librte_cryptodev/rte_crypto_asym.h | 2 +- 1 file changed

Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline

2019-07-26 Thread Babu Radhakrishnan, AgalyaX
Hi, > -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, July 9, 2019 3:01 PM > To: Babu Radhakrishnan, AgalyaX ; > dev@dpdk.org > Cc: Pattan, Reshma > Subject: RE: [PATCH] examples: modify error message for ip pipeline > > > > > -Original Message- > > From: Babu

Re: [dpdk-dev] [PATCH v3 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-26 Thread David Marchand
Hello, On Fri, Jul 12, 2019 at 8:43 AM wrote: > > From: Vamsi Attunuru > > eal flag autotest fails when multiple mem size flags are passed > to --socket-mem option irrespective of RTE_MAX_NUMA_NODES. > > Patch fixes --socket-mem option by setting enough numbers > of numa node mem flags based on

Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 2:27 PM, hgovindh wrote: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: s

Re: [dpdk-dev] [PATCH v1 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Ye Xiaolong
On 07/26, Ferruh Yigit wrote: >On 7/26/2019 10:29 AM, Xiaolong Ye wrote: >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/vmxnet3/base/README | 34 +++-- >> 1 file changed, 3 insertions(+), 31 deletions(-) >> >> diff --git a/drivers/net/vmxnet3/base/README >> b/dr

Re: [dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > I did a pass on the pmds about oerrors some time ago, but still did not > find the motivation to finish yet. > For now, here is a series of cleanups on the virtual pmds. > > The former patches are just about removing counters that adds nothing to > th

[dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [PATCH v2 8/9] net/ring: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage > to send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. >

Re: [dpdk-dev] [PATCH v2 7/9] net/memif: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > n_err reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. > >

Re: [dpdk-dev] [PATCH v2 6/9] net/kni: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. >

Re: [dpdk-dev] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > The delta between what the application asked to receive and what was > indeed received, can not be called an error counter. > This counter is not reported anywhere, remove it. > > Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Iremonger, Bernard
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 26, 2019 1:36 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; Mcnamara, John > ; Zhang, Roy Fan > Subject: RE: [PATCH v4] doc: release note for the IPsec library and >

Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow

2019-07-26 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, July 23, 2019 10:53 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] app/compress-perf: prevent output buffer overflow > > This patch fixes the issue of memory overwrite af

Re: [dpdk-dev] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-26 Thread Akhil Goyal
Hi Shally, > > > > Clarify the corner case with incompressible data whereby the output can > > actually be greater than the uncompressed data. > > > > Signed-off-by: Fiona Trahe > > --- > > Acked-by: Adam Dybkowski Are you Ok with this change at this point in lib? Normally no change is accept

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > Update release notes for changes to the IPsec library. > Update release notes for changes to the IPsec Security Gateway application Description and the release note updates use redundant words which can be avoided. It could be something like "Update release notes for recently supported fe

Re: [dpdk-dev] [PATCH v7 1/1] app/test-compress-perf: provide more detailed report

2019-07-26 Thread Akhil Goyal
> > > > From: Artur Trybula > > > > This patch adds extra features to the compress performance > > test. Some important parameters (memory allocation, > > number of ops, number of segments) are calculated and > > printed out. > > Information about threads, cores, devices and queue-pairs > > is als

Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

2019-07-26 Thread Akhil Goyal
> > > > > > > > CID 340857: Null pointer dereferences (NULL_RETURNS) > > > > > > > > CID 340856: (CONSTANT_EXPRESSION_RESULT) > > > > > > > > Fixes: 3be12ea52ad8 ("test/compress: improve debug trace setup") > > > > > > > > Signed-off-by: Adam Dybkowski > > > > --- > > > > app/test/test_compressde

Re: [dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-26 Thread Akhil Goyal
> > > > Asymmetric crypto is not required for test-crypto-perf application. > > Disabling the feature using 'ff_disable' field. > > > > Signed-off-by: Anoob Joseph > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-07-26 Thread Olivier Matz
Hi, On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: > When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws > compilation error > virtio_ethdev.c:1851:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’ > RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM > < sizeof(struct virti

[dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Bernard Iremonger
Update release notes for changes to the IPsec library. Update release notes for changes to the IPsec Security Gateway application Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_19_08.rst | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/doc

Re: [dpdk-dev] [EXT] Re: [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: David Christensen > Sent: Friday, July 26, 2019 3:36 AM > To: Jerin Jacob Kollanukkaran ; Bruce Richardson > ; hgovindh > > Cc: Remy Horton ; Marko Kovacevic > ; Ori Kam ; Pablo de > Lara ; Radu Nicolau > ; Akhil Goyal ; Tomasz > Kantecki ; dev@dpdk.org; > m

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-26 Thread Iremonger, Bernard
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 26, 2019 11:27 AM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; Mcnamara, John > > Subject: RE: [PATCH v3] doc: release note for the IPsec library > > Hi Bernard, > >

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-26 Thread Akhil Goyal
Hi Bernard, > > Update release notes for changes to the IPsec library. > > Signed-off-by: Bernard Iremonger > --- > changes in v3: > revised content > > doc/guides/rel_notes/release_19_08.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/release_19_08.

[dpdk-dev] [PATCH v2 7/9] net/memif: do not count unsent packets as errors

2019-07-26 Thread David Marchand
n_err reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface

[dpdk-dev] [PATCH v2 9/9] net/vhost: do not count unsent packets as errors

2019-07-26 Thread David Marchand
missed_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 5f05e95cd5d9 ("net/vhost: fix Tx error countin

[dpdk-dev] [PATCH v2 8/9] net/ring: do not count unsent packets as errors

2019-07-26 Thread David Marchand
err_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: e1e4017751f1 ("ring: add new driver") Cc: sta...@

[dpdk-dev] [PATCH v2 6/9] net/kni: do not count unsent packets as errors

2019-07-26 Thread David Marchand
err_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@

[dpdk-dev] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter

2019-07-26 Thread David Marchand
The delta between what the application asked to receive and what was indeed received, can not be called an error counter. This counter is not reported anywhere, remove it. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/kni/rte_eth_

[dpdk-dev] [PATCH v2 4/9] net/virtio: remove unused Tx error counter

2019-07-26 Thread David Marchand
This Tx counter has never been used. Fixes: 9658d17da27b ("virtio: maintain stats per queue") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v2 2/9] net/af_xdp: remove unused Tx counter

2019-07-26 Thread David Marchand
This Tx counter is now unused. Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent") Signed-off-by: David Marchand Reviewed-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c

[dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds

2019-07-26 Thread David Marchand
I did a pass on the pmds about oerrors some time ago, but still did not find the motivation to finish yet. For now, here is a series of cleanups on the virtual pmds. The former patches are just about removing counters that adds nothing to the stats. The latter patches make sure that unsent packet

Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 1:35 AM, simei wrote: > From: Simei Su > > This RFC reserves several bits as input set selection from bottom > of the 64 bits. The flow type is combined with input set to > represent rss types. > > Correct the input set mask to align with the definition in rte_ethdev.h. > for exampl

[dpdk-dev] [PATCH v2 1/9] net/af_packet: remove unused Rx counter

2019-07-26 Thread David Marchand
This Rx counter has never been used. Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v2 3/9] net/null: remove unused Tx error counter

2019-07-26 Thread David Marchand
This Tx counter has never been used. Fixes: c743e50c475f ("null: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/null/

Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 8:24 AM, David Marchand wrote: > On Thu, Jul 25, 2019 at 9:07 PM David Marchand > wrote: >> >> On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: >>> >>> On 7/25/2019 10:14 AM, David Marchand wrote: err_pkts reflects the number of packets that the driver did not manage to

  1   2   >