[dpdk-dev] [v2] net/fm10k: fix segment fault at calling fm10k_stats_get() from secondary process.

2019-08-05 Thread Lu Qiuwen
>From 5658ee7d69023cc4b22315cd9f8e10a832aafdb0 Mon Sep 17 00:00:00 2001 From: Lu Qiuwen Date: Sat, 15 Jun 2019 14:28:01 +0800 Subject: [PATCH] net/fm10k: fix segment fault at calling fm10k_stats_get() from secondary process. The function pointers in fm10k_stats_get() which setup from primary pro

Re: [dpdk-dev] [PATCH V2] net/bnxt: fix traffic stall on RX queue stop/start

2019-08-05 Thread Thomas Monjalon
01/08/2019 17:45, Ajit Khaparde: > From: Kalesh AP > > Fixed a check in bnxt_alloc_hwrm_rx_ring() while initializing > the rx ring. > > Driver should not change "deferred_start" status of rx/tx queues. > It should get the status in queue_setup_op() and use that value. > > Fixes: 9b63c6fd70e3 ("

Re: [dpdk-dev] [PATCH v3 1/1] common/octeontx2: fix unaligned mbox memory accesses

2019-08-05 Thread Thomas Monjalon
02/08/2019 11:55, Jerin Jacob Kollanukkaran: > > From: Vamsi Attunuru > > > > Octeontx2 PMD's mailbox client uses device memory to send messages to > > mailbox server in the admin function Linux kernel driver. > > The device memory used for the mailbox communication needs to be > > qualified as v

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ena: fix L4 cksum flags condition for TX

2019-08-05 Thread Thomas Monjalon
01/08/2019 14:08, Michał Krawczyk: > czw., 1 sie 2019 o 13:45 Maciej Bielski napisał(a): > > > > During an if-condition evaluation, a 2-bit flag evaluates to 'true' for > > '0x1', '0x2' and '0x3'. Thus, from this perspective these flags are > > indistinguishable. To make them distinct, respective

Re: [dpdk-dev] [PATCH] net/mvpp2: remove resources when port is closed

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: lir...@marvell.com > Sent: Monday, August 5, 2019 3:47 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Liron Himi > Subject: [PATCH] net/mvpp2: remove resources when port is closed > > From: Liron Himi > > Since 18.11, it is suggested that driver sh

Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-08-05 Thread Thomas Monjalon
05/08/2019 15:07, Maxime Coquelin: > On 8/1/19 10:09 AM, Hemant Agrawal wrote: > >> On 7/26/19 2:25 PM, Olivier Matz wrote: > >>> On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: > When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws > compilation error >

Re: [dpdk-dev] [PATCH] net/thunderx: fix nicvf cleanup on detaching PCI dev

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: agup...@marvell.com > Sent: Monday, August 5, 2019 1:31 PM > To: Jerin Jacob Kollanukkaran ; Maciej Czekaj > ; Anatoly Burakov > Cc: dev@dpdk.org; sta...@dpdk.org; Amit Gupta > Subject: [PATCH] net/thunderx: fix nicvf cleanup on detaching PCI dev > > From: A

Re: [dpdk-dev] [PATCH] drivers/octeontx2: fix coverity issues

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Jerin Jacob Kollanukkaran > Sent: Monday, August 5, 2019 9:35 AM > To: Harman Kalra ; Nithin Kumar Dabilpuram > ; Vamsi Krishna Attunuru > ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH

[dpdk-dev] [PATCH v7 0/2] examples/client_server_mp: port id (fixes only)

2019-08-05 Thread Stephen Hemminger
v7 - widen port mask to allow 64 ports v6 - just include fixes; cleanups can wait until 19.11 v5 - change logic in server_mp for evaluating port mask v4 - fix checkpatch warning add patches to fix style issues and use ether format addr v3 - merge both patches in one series use alterna

[dpdk-dev] [PATCH v7 1/2] examples/multi_process/client_server_mp: check port validity

2019-08-05 Thread Stephen Hemminger
From: Stephen Hemminger The mp_server incorrectly allows a port mask that included hidden ports and which later caused either lost packets or failed initialization. This fixes explicitly checking that each bit in portmask is a valid port before using it. Fixes: 5b7ba31148a8 ("ethdev: add port o

[dpdk-dev] [PATCH v7 2/2] examples/multi_process/client_server_mp - fix crash in mp_client with sparse ports

2019-08-05 Thread Stephen Hemminger
From: Stephen Hemminger The mp_client crashes if run on Azure or any system where ethdev ports are owned. In that case, the tx_buffer and tx_stats for the real port were initialized correctly, but the wrong port was used. For example if the server has Ports 3 and 5. Then calling rte_eth_tx_buffe

Re: [dpdk-dev] [PATCH] net/octeontx2: add 96xx A1 silicon revision support

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Nithin Dabilpuram > Sent: Monday, August 5, 2019 11:11 AM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org > Subject: [PATCH] net/octeontx2: add 96xx A1 silicon revision supp

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe buffer count

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: vattun...@marvell.com > Sent: Monday, August 5, 2019 9:08 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > Vamsi Krishna Attunuru > Subject: [dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe > buffer count > > F

Re: [dpdk-dev] [PATCH] common/octeontx2: update ready message response

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: jer...@marvell.com > Sent: Sunday, August 4, 2019 12:12 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Nithin > Kumar Dabilpuram ; Vamsi Krishna Attunuru > > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] common/octeontx2: update ready message > r

Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity

2019-08-05 Thread Stephen Hemminger
On Sun, 4 Aug 2019 08:31:54 + Matan Azrad wrote: > > > > /* convert parameter to a number and verify */ > > > > pm = strtoul(portmask, &end, 16); > > > > - if (end == NULL || *end != '\0' || pm == 0) > > > > + if (end == NULL || *end != '\0' || pm > UINT16_MAX || p

Re: [dpdk-dev] [PATCH] net/octeontx2: drop Rx and L2 error packets

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Sunday, August 4, 2019 8:52 AM > To: Jerin Jacob Kollanukkaran ; Jerin Jacob > Kollanukkaran ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org; tho...@monjalon.net; ferruh.yi...@intel.com > Subject:

Re: [dpdk-dev] [v2 0/5] fix dereference after null check coverity

2019-08-05 Thread Ye Xiaolong
On 08/06, Xiao Zhang wrote: >This patch tries to fix (dereference after null check) coverity issue. >The address of first segmented packets for ice, iavf, i40e fm10k and ixgbe >was not set correctly during reassembling packets which led to this issue. > >Coverity issue: 343452 >Coverity issue: 3434

Re: [dpdk-dev] [PATCH v2] doc: add tested Marvell integrated NIC platforms

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Mcnamara, John > Sent: Friday, August 2, 2019 7:16 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; > Kovacevic, Marko > Cc: tho...@monjalon.net; Vijaya Bhaskar Annayyolla > Subject: RE: [dpdk-dev] [PATCH v2] doc: add tested Marvell integrated NIC > platfor

[dpdk-dev] [PATCH v2 1/1] net/octeontx2: fix optimal default sqe buffer count

2019-08-05 Thread vattunuru
From: Vamsi Attunuru Patch extends minimum supported max_sqb_count devarg value such that it can limit the max sqb count to 8 buffers and also defines NIX_DEF_SQB and uses it to compute the number of sqe buffers required for the egress traffic. NIX_DEF_SQB is defined as 16 which is optimal acros

[dpdk-dev] [PATCH 4/5] doc: add mlx5 design details

2019-08-05 Thread Thomas Monjalon
Some details about libibverbs were missing: - automatic detection by meson - main ways to access the device Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/

[dpdk-dev] [PATCH 3/5] doc: remove useless console syntax in mlx guides

2019-08-05 Thread Thomas Monjalon
It is not needed to use "console" syntax highlighting for literal blocks. The file is easier to read by removing the code-block lines and simply having double colons in previous line. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx4.rst | 92 +++- doc/guides/nics/

[dpdk-dev] [PATCH 5/5] doc: add more details about mlx5 offloads

2019-08-05 Thread Thomas Monjalon
Add firmware config for MPLS and DevX (required by LRO and DR). Add a table for queue offloads requirements. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/mlx5.

[dpdk-dev] [PATCH 2/5] doc: fix wording and formatting of mlx5 guide

2019-08-05 Thread Thomas Monjalon
These are simple fixes of punctuation, anchor placement or wording. The table format is fixed to avoid having a long line in the first column. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mlx5.rst | 57 +++- 1 file changed, 27 insertions(+), 30 deletions

[dpdk-dev] [PATCH 1/5] doc: improve firmware configuration in mlx5 guide

2019-08-05 Thread Thomas Monjalon
The command mlxconfig was not enough explained and too much verbose at the same time. The syntax is now explained in introduction before listing the options, without repeating the commands. Some options, which are explained elsewhere in the doc, are added to this list. Signed-off-by: Thomas Monjal

[dpdk-dev] [PATCH 0/5] improve mlx5 guide

2019-08-05 Thread Thomas Monjalon
The mlx5 guide is a bit complex. It needs some clean-up in some areas, some details are missing, etc. This series is a first step of improvement for 19.08. More in-depth improvements are expected for 19.11. Thomas Monjalon (5): doc: improve firmware configuration in mlx5 guide doc: fix wording

Re: [dpdk-dev] [PATCH v2] doc: add a co-existence consideration for qede PMD

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Rasesh Mody > Sent: Monday, August 5, 2019 2:50 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: Rasesh Mody ; John McNamara > ; Jerin Jacob Kollanukkaran > ; GR-Everest-DPDK-Dev d...@marvell.com>; sta...@dpdk.org > Subject: [PATCH v2] doc: add a co-existence con

Re: [dpdk-dev] [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide

2019-08-05 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Rasesh Mody > Sent: Monday, August 5, 2019 2:54 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: Rasesh Mody ; Hemant Agrawal > ; Jerin Jacob Kollanukkaran > ; John McNamara ; GR- > Everest-DPDK-Dev > Subject: [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide

Re: [dpdk-dev] [PATCH v3 2/2] devtools: allow misc options in null test

2019-08-05 Thread Thomas Monjalon
30/07/2019 19:34, Thomas Monjalon: > In order to ease basic testing with customized options, > EAL and testpmd options can be added as third and fourth arguments > of the "null PMD" script. > > Also, the first argument becomes more flexible by accepting > the testpmd path as an alternative to the

Re: [dpdk-dev] [PATCH] net/mlx5: fix link speed info when link is down

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Monday, August 5, 2019 11:02 AM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix link speed info when link is down > > When the link

Re: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, August 5, 2019 2:51 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; Eli Britstein > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop > > Function flow

Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal

2019-08-05 Thread Thomas Monjalon
05/08/2019 17:05, David Marchand: > On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon wrote: > > 02/08/2019 15:29, David Marchand: > > > This symbol has been deprecated for quite some time. > > > Let's drop it in the next release. > > > --- > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b

Re: [dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in selection logic

2019-08-05 Thread David Marchand
On Mon, Aug 5, 2019 at 4:46 PM wrote: > > From: Krzysztof Kanas > > Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id > but those arrays are 8 entries long. Idem http://mails.dpdk.org/archives/dev/2019-July/140020.html I did not get a reply from you. -- David Marchand

Re: [dpdk-dev] [PATCH 0/6] add SPDX tag to files for Power architecture

2019-08-05 Thread Thomas Monjalon
30/07/2019 22:01, David Christensen: > This patchset replaces the full BSD 3 clause license headers with the > SPDX tag for remaining files used for Power architecture. > > David Christensen (6): > config: replace license text with SPDX tag > librte_eal: replace license text with SPDX tag >

Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal

2019-08-05 Thread David Marchand
On Mon, Aug 5, 2019 at 4:39 PM Thomas Monjalon wrote: > > 02/08/2019 15:29, David Marchand: > > This symbol has been deprecated for quite some time. > > Let's drop it in the next release. > > --- > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > +* e

[dpdk-dev] [PATCH 1/2] net/bonding: fix stack overflow in selection logic

2019-08-05 Thread kkanas
From: Krzysztof Kanas Bonding selection logic uses agg_bandwidth, agg_count indexed by port_id but those arrays are 8 entries long. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzysztof Kanas --- drivers/net/bonding/rte_eth_b

[dpdk-dev] [PATCH 2/2] net/bonding: fix selection logic

2019-08-05 Thread kkanas
From: Krzysztof Kanas Fix max_index to return uint16_t as it is valid slave_id type. Arrays agg_count and agg_bandwidth should be indexed by slave_id not by aggregator port_id. Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Signed-off-by: Krzys

Re: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inline

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Monday, August 5, 2019 4:04 PM > To: dev@dpdk.org > Cc: Yongseok Koh ; Matan Azrad > > Subject: [dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inline > > The patch [Fixes] sets the default value

Re: [dpdk-dev] [PATCH] doc: announce malloc virt2phys symbol removal

2019-08-05 Thread Thomas Monjalon
02/08/2019 15:29, David Marchand: > This symbol has been deprecated for quite some time. > Let's drop it in the next release. > --- > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > +* eal: The ``rte_malloc_virt2phy`` function has been deprecated and replac

Re: [dpdk-dev] unimplemented API heads-up notice

2019-08-05 Thread Thomas Monjalon
Ping What is the status of this deprecation plan? 28/12/2018 17:18, Ananyev, Konstantin: > Hi everyone, > As you probably know, all un-implemented API inside DPDK > planned to be deprecated in 19.05 and removed in 19.08. > For more details, please refer to: > https://mails.dpdk.org/archives/dev/20

[dpdk-dev] [PATCH v2 5/5] net/fm10k: fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343416 Fixes: fe65e1e1 ("fm10k: add vector scatter Rx") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang

[dpdk-dev] [PATCH v2 1/5] net/ixgbe: fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 13245 Fixes: 8a44c15a ("net/ixgbe: extract non-x86 specific code from vector driver") Cc: sta...@dpdk.o

[dpdk-dev] [PATCH v2 2/5] net/ice: fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343452 Coverity issue: 343407 Fixes: c68a52b8 ("net/ice: support vector SSE in Rx") Cc: sta...@dpdk.org

[dpdk-dev] [PATCH v2 4/5] net/iavf: fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343447 Fixes: 319c421f ("net/avf: enable SSE Rx Tx") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang ---

[dpdk-dev] [PATCH v2 3/5] net/i40e: fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch fixes (dereference after null check) coverity issue. The address of first segmented packets was not set correctly during reassembling packets which led to this issue. Coverity issue: 343422 Coverity issue: 343403 Fixes: ca74903b ("net/i40e: extract non-x86 specific code from vector driv

[dpdk-dev] [v2 0/5] fix dereference after null check coverity

2019-08-05 Thread Xiao Zhang
This patch tries to fix (dereference after null check) coverity issue. The address of first segmented packets for ice, iavf, i40e fm10k and ixgbe was not set correctly during reassembling packets which led to this issue. Coverity issue: 343452 Coverity issue: 343407 Fixes: c68a52b8 ("net/ice: supp

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-05 Thread Thomas Monjalon
05/08/2019 16:18, Aaron Conole: > One thing I notice is that some of the tests are still failing > 'sporadically' and that's difficult to discern. So we might just use > the robot as 'warn' rather than 'error' for now and maintainers will > have to make a best determination. Yes it can be a good

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-05 Thread Aaron Conole
Michael Santana Francisco writes: > On Mon, Aug 5, 2019 at 8:52 AM David Marchand > wrote: >> >> On Mon, Aug 5, 2019 at 8:26 AM David Marchand >> wrote: >> > >> > On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon >> > wrote: >> > > >> > > 02/08/2019 23:25, Aaron Conole: >> > > > This series t

Re: [dpdk-dev] [PATCH] doc: change tools guide to SPDX license

2019-08-05 Thread Thomas Monjalon
01/08/2019 09:15, Hemant Agrawal: > Hi Thomas, > Please apply this patch. > Regards, > Hemant > On Wed, Jun 6, 2018 at 5:39 PM Hemant Agrawal wrote: > > > > Christian, > > Will you please ack it? A ack from canonical is must to change the > > license (even if it is just the style).

Re: [dpdk-dev] [PATCH] vhost: replace iotlb licence text with SPDX tag

2019-08-05 Thread Thomas Monjalon
> Acked-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH] doc: replace PVP text licence with SPDX tag

2019-08-05 Thread Thomas Monjalon
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-05 Thread Michael Santana Francisco
On Mon, Aug 5, 2019 at 8:52 AM David Marchand wrote: > > On Mon, Aug 5, 2019 at 8:26 AM David Marchand > wrote: > > > > On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon wrote: > > > > > > 02/08/2019 23:25, Aaron Conole: > > > > This series turns the fast unit tests on for a limited set of > > >

Re: [dpdk-dev] [PATCH v2] Update supported Intel NIC driver version and firmware version

2019-08-05 Thread Thomas Monjalon
29/07/2019 05:36, Chen, Zhaoyan: > Update supported Intel NIC driver version and firmware version > > Signed-off-by: Chen, Zhaoyan Applied with updated title and author name: http://git.dpdk.org/dpdk/commit/?id=cb8a35c22

Re: [dpdk-dev] [PATCH 0/3] testpmd: fixes for 19.08

2019-08-05 Thread Thomas Monjalon
> Stephen Hemminger (3): > testpmd: allow configuring log level on command line > testpmd: block secondary process > testpmd: use exit instead of panic Applied, thanks

Re: [dpdk-dev] [PATCH] net/mlx5: fix link speed info when link is down

2019-08-05 Thread Slava Ovsiienko
> -Original Message- > From: Xiaoyu Min > Sent: Monday, August 5, 2019 11:02 > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix link speed info when link is down > > When the link is down, the link speed returned by

[dpdk-dev] [PATCH v1 1/1] net/octeontx2: fix optimal default smq buffer count

2019-08-05 Thread vattunuru
From: Vamsi Attunuru Patch extends minimum supported max_sqb_count devarg value such that it can limit the max sqb count to 8 buffers and also defines NIX_DEF_SQB and uses it to compute the number of smq buffers required for the egress traffic. NIX_DEF_SQB is defined as 16 which is optimal acros

Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes

2019-08-05 Thread Thomas Monjalon
31/07/2019 17:38, Bruce Richardson: > On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote: > > Using a simple shell script which cleans up trailing whitespace > > found several places with extra lines at end of file. > > > > More in base drivers but they are known to be problematic.

Re: [dpdk-dev] [PATCH] doc: update release note for i40e support for MARK+RSS

2019-08-05 Thread Zhang, Qi Z
> -Original Message- > From: Mcnamara, John > Sent: Tuesday, July 30, 2019 5:33 PM > To: Ergin, Mesut A ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org; Ergin, Mesut A > Subject: RE: [dpdk-dev] [PATCH] doc: update release note for i40e support for > MARK+RSS > > > > > -Origina

Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-08-05 Thread Maxime Coquelin
On 8/1/19 10:09 AM, Hemant Agrawal wrote: > HI, >> On 7/26/19 2:25 PM, Olivier Matz wrote: >>> Hi, >>> >>> On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws compilation error virtio_ethdev.c:1851:2: no

[dpdk-dev] [PATCH v2 6/6] net/mlx5: fix completion queue overflow for large bursts

2019-08-05 Thread Viacheslav Ovsiienko
There is the limit on completion descriptor fetch to improve latency. If burst size is large there might be not enough resources freed in completion processing. This fix reiterates sending loop and allows multiple completion descriptor fetch and processing. Fixes: 18a1c20044c0 ("net/mlx5: implemen

[dpdk-dev] [PATCH v2 3/6] net/mlx5: fix completion queue drain loop

2019-08-05 Thread Viacheslav Ovsiienko
The completion loop speed optimizations for error-free operations are done - no CQE field fetch on each loop iteration. Also, code size is oprimized - the flush buffers routine is invoked once. Fixes: 318ea4cfa1b1 ("net/mlx5: fix Tx completion descriptors fetching loop") Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v2 4/6] net/mlx5: fix inline data settings

2019-08-05 Thread Viacheslav Ovsiienko
If the minimal inline data are required the data inline feature must be engaged. There were the incorrect settings enabling the entire small packet inline (in size up to 82B) which may result in sending rate declining if there is no enough cores. The same problem was raised if inline was enabled to

[dpdk-dev] [PATCH v2 2/6] net/mlx5: fix inline data len assert condition

2019-08-05 Thread Viacheslav Ovsiienko
The debug assert wrongly triggers on the inline data 18B, this should be passed successfully. Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[dpdk-dev] [PATCH v2 5/6] net/mlx5: fix packet size inline settings

2019-08-05 Thread Viacheslav Ovsiienko
This patch fixes the default settings for packet size to inline with Enhanced Multi-Packet Write feature, allowing 256B packets to be inlined with Out-Of-the-Box settings. Fixes: 50724e1bba76 ("net/mlx5: update Tx definitions") Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- doc/

[dpdk-dev] [PATCH v2 0/6] fix transmit datapath cumulative series

2019-08-05 Thread Viacheslav Ovsiienko
This series provides the fixes for mlx5 Tx datapath, mostly resolving the minor performance and setup issues: - various inline data settings - wrong assert condition on minimal data length - large burst SQ overflow due to inefficient CQ drain Signed-off-by: Viacheslav Ovsiienko Acked-by: M

[dpdk-dev] [PATCH v2 1/6] net/mlx5: fix default minimal data inline

2019-08-05 Thread Viacheslav Ovsiienko
The patch [Fixes] sets the default value of required minimal inline data to 0 bytes. On some configurations (depends on switchdev/legacy settings and FW version/settings) the ConnectX-4LX NIC requires minimal 18 bytes of Tx descriptor inline data to operate correctly. Wrongly set to 0 default valu

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN inner type matching on DR/DV

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Friday, August 2, 2019 12:18 PM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN inner type matching on > DR/DV > > The rte_flow_item_v

Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, August 5, 2019 10:07 AM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive > > Part of the code in functi

Re: [dpdk-dev] [PATCH v2 0/2] Enable fast-unit tests under travis

2019-08-05 Thread David Marchand
On Mon, Aug 5, 2019 at 8:26 AM David Marchand wrote: > > On Sat, Aug 3, 2019 at 12:00 AM Thomas Monjalon wrote: > > > > 02/08/2019 23:25, Aaron Conole: > > > This series turns the fast unit tests on for a limited set of > > > builds under the travis build system. An example run is available > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop

2019-08-05 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Monday, August 5, 2019 14:51 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; Eli Britstein > > Subject: [PATCH] net/mlx5: fix order of lines in loop > > Function flow_dv_zero_encap_udp_csum() uses a wh

[dpdk-dev] [PATCH] doc: remove major in designation of normal releases

2019-08-05 Thread Thomas Monjalon
The word "major" was used to differentiate with release candidates or stable maintenance releases. However the word "major" can be understood as "LTS", so it is less confusing to avoid this word. Reported-by: Ori Kam Signed-off-by: Thomas Monjalon --- doc/guides/contributing/documentation.rst |

[dpdk-dev] [PATCH] app/testpmd: remove duplicated support for Rx offloading

2019-08-05 Thread Flavia Musatescu
The testpmd application provides two sets of commands for RX offload flags configuration. The purpose of this patch is to eliminate this duplication by removing the old set of commands: “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-vlan| hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|

[dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop

2019-08-05 Thread Dekel Peled
Function flow_dv_zero_encap_udp_csum() uses a while loop to iterate over vlan items in flow rule. Pointer next_hdr is incremented to the next item before it is used, so the first item is skipped. This patch moves the incrementing of next_hdr to the correct place. Fixes: bf1d7d9a033a ("net/mlx5: z

Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant use of directive

2019-08-05 Thread Slava Ovsiienko
> -Original Message- > From: Dekel Peled > Sent: Monday, August 5, 2019 10:07 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix redundant use of directive > > Part of the code in function flow_dv_matcher_enable() is enclo

Re: [dpdk-dev] [PATCH v4 1/2] vhost: support inflight share memory protocol feature

2019-08-05 Thread Yu, Jin
Thanks Tiwei. > -Original Message- > From: Bie, Tiwei > Sent: Thursday, August 1, 2019 2:38 PM > To: Yu, Jin > Cc: dev@dpdk.org; Liu, Changpeng ; > maxime.coque...@redhat.com; Wang, Zhihong ; > Lin Li ; Xun Ni ; Yu Zhang > > Subject: Re: [PATCH v4 1/2] vhost: support inflight share memor

Re: [dpdk-dev] [PATCH] net/iavf: fix Rx bytes stats

2019-08-05 Thread Andrew Rybchenko
On 7/17/19 7:55 AM, Stephen Hemminger wrote: On Wed, 17 Jul 2019 12:31:00 +0800 Qi Zhang wrote: Exclude 4 bytes CRC for rx bytes stats. This also aligned Rx stats calculation with PF. Fixes: f4a41a6953af ("net/avf: support stats") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/ne

Re: [dpdk-dev] [PATCH] ethdev: sort experimental symbols per release

2019-08-05 Thread Thomas Monjalon
31/07/2019 15:45, Ferruh Yigit: > On 7/31/2019 1:27 PM, David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > > check for how long we have them. > > > > Signed-off-by: David Marchand > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests

2019-08-05 Thread Thomas Monjalon
03/08/2019 11:51, David Marchand: > On Fri, Aug 2, 2019 at 10:57 PM Thomas Monjalon wrote: > > > > 01/08/2019 14:27, David Marchand: > > > The memory tests currently check that, for normal mode (not legacy mode), > > > there is no memory left behind when exiting. > > > > I think this is the real b

Re: [dpdk-dev] [PATCH] doc: add a co-existence consideration for qede PMD

2019-08-05 Thread Thomas Monjalon
05/08/2019 11:26, Rasesh Mody: > Hi Thomas, > > >From: Thomas Monjalon > >Sent: Wednesday, July 31, 2019 1:31 AM > > > >31/07/2019 10:02, Rasesh Mody: > >> Add and update co-existence considerations for qede PMD > >> > >> Signed-off-by: Rasesh Mody > >> --- > >> doc/guides/nics/qede.rst | 21 ++

Re: [dpdk-dev] [PATCH] doc: announce API change in mbuf

2019-08-05 Thread Thomas Monjalon
05/08/2019 10:05, Andrew Rybchenko: > On 8/1/19 3:41 PM, Thomas Monjalon wrote: > > In order to prepare for a long term stable API, the mbuf library > > has to change: allowing more features as dynamic fields, > > and fixing the lack of rte_ prefix in the namespace. > > The namespace fix should not

Re: [dpdk-dev] [PATCH v2] bus/pci: always check IOMMU capabilities

2019-08-05 Thread Thomas Monjalon
05/08/2019 08:23, David Marchand: > IOMMU capabilities won't change and must be checked even if no PCI device > seem to be supported yet when EAL initialised. > > This is to accommodate with SPDK that registers its drivers after > rte_eal_init(), especially on PPC platform where the IOMMU does not

Re: [dpdk-dev] [PATCH] bus/pci: remove unused x86 Linux macro

2019-08-05 Thread Thomas Monjalon
02/08/2019 11:54, David Marchand: > This macro is unused after a previous fix. > > Fixes: fe822eb8c565 ("bus/pci: use IOVA DMA mask check when setting IOVA > mode") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: hide internal function

2019-08-05 Thread Thomas Monjalon
31/07/2019 14:07, David Marchand: > This function has never been used outside of this code unit. > Mark it static and remove it from the eal internal header. > > Fixes: 9e29251b2afa ("eal: thread affinity API") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied, thanks

Re: [dpdk-dev] [PATCH v3] eal: warn on legacy memory allocation requirement

2019-08-05 Thread Thomas Monjalon
31/07/2019 11:15, Burakov, Anatoly: > On 30-Jul-19 6:21 PM, Thomas Monjalon wrote: > > When using --no-huge mode, dynamic allocation is not supported. > > Because of this limitation, the option --legacy-mem is implied > > and -m may be needed to specify the amount of memory to allocate. > > Otherwi

Re: [dpdk-dev] [PATCH 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-08-05 Thread Rasesh Mody
>From: Thomas Monjalon >Sent: Wednesday, July 31, 2019 1:33 AM > >31/07/2019 10:02, Rasesh Mody: >> Add and update co-existence considerations for bnx2x PMD >> >> Signed-off-by: Rasesh Mody >> --- >> doc/guides/nics/bnx2x.rst | 15 --- >> 1 file changed, 12 insertions(+), 3 deletions

Re: [dpdk-dev] [PATCH] doc: add a co-existence consideration for qede PMD

2019-08-05 Thread Rasesh Mody
Hi Thomas, >From: Thomas Monjalon >Sent: Wednesday, July 31, 2019 1:31 AM > >31/07/2019 10:02, Rasesh Mody: >> Add and update co-existence considerations for qede PMD >> >> Signed-off-by: Rasesh Mody >> --- >> doc/guides/nics/qede.rst | 21 +++-- >> 1 file changed, 19 insertions

[dpdk-dev] [PATCH v2 1/2] doc: use SPDX tag for bnx2x PMD guide

2019-08-05 Thread Rasesh Mody
Use SPDX tag for bnx2x PMD guide v2: add short patch description Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index cecbfc2e7..a7dee0c10 100644 --- a/doc/guide

[dpdk-dev] [PATCH v2 2/2] doc: add a co-existence consideration for bnx2x PMD

2019-08-05 Thread Rasesh Mody
Add and update co-existence considerations for bnx2x PMD Cc: sta...@dpdk.org v2: Made co-existence considerations for QLogic adapters more specific Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) dif

[dpdk-dev] [PATCH v2] doc: add a co-existence consideration for qede PMD

2019-08-05 Thread Rasesh Mody
Add and update co-existence considerations for qede PMD v2: Made co-existence considerations for QLogic adapters more specific Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- doc/guides/nics/qede.rst | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --gi

[dpdk-dev] [PATCH v2] net/ice: fix potential null pointer dereferences

2019-08-05 Thread Xiaolong Ye
This patch fixes two null pointer dereferences in flow code detected by coverity scan. Coverity issue: 345815, 345816 Fixes: 94f00800d78b ("net/ice: fix VXLAN/NVGRE flow matching") Cc: ying.a.w...@intel.com Signed-off-by: Xiaolong Ye --- v2 change: - add coverity ids drivers/net/ice/ice_gener

[dpdk-dev] [PATCH v2] net/memif: fix coverity defects

2019-08-05 Thread Jakub Grajciar
fixes CID: 343440, 343459, 343464, 343394 Signed-off-by: Jakub Grajciar --- drivers/net/memif/memif_socket.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) V2: - fix coding style diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 01a935f8

[dpdk-dev] [PATCH] net/memif: fix coverity defects

2019-08-05 Thread Jakub Grajciar
fixes CID: 343440, 343459, 343464, 343394 Signed-off-by: Jakub Grajciar --- drivers/net/memif/memif_socket.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 01a935f87..65dff321c 100644 ---

[dpdk-dev] [PATCH v2 3/3] examples/ipsec-secgw: support IPv6 tunnel for lookaside proto

2019-08-05 Thread Akhil Goyal
IPv6 tunnels are already supported in case of inline and lookaside none cases. In case of protocol offload, the details for IPv6 header need to be added in session configuration for security session create. Signed-off-by: Akhil Goyal --- examples/ipsec-secgw/ipsec.c | 14 +- 1 file c

[dpdk-dev] [PATCH v2 1/3] crypto/dpaa_sec: support IPv6 tunnel for protocol offload

2019-08-05 Thread Akhil Goyal
outer IP header is formed at the time of session initialization using the ipsec xform. This outer IP header will be appended by hardware for each packet. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 71 ++ drivers/crypto/dpaa_sec/dpaa_sec.h | 7

[dpdk-dev] [PATCH v2 2/3] crypto/dpaa2_sec: support IPv6 tunnel for protocol offload

2019-08-05 Thread Akhil Goyal
outer IP header is formed at the time of session initialization using the ipsec xform. This outer IP header will be appended by hardware for each packet. Signed-off-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 73 +++-- drivers/crypto/dpaa2_sec/dpaa2_sec_priv

[dpdk-dev] [PATCH v2 0/3] support IPv6 tunnel for lookaside crypto

2019-08-05 Thread Akhil Goyal
changes in v2: used RTE_IPV6_HDR_* macros instead of localized driver specific macros. Akhil Goyal (3): crypto/dpaa_sec: support IPv6 tunnel for protocol offload crypto/dpaa2_sec: support IPv6 tunnel for protocol offload examples/ipsec-secgw: support IPv6 tunnel for lookaside proto driv

Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of VLAN pcp item

2019-08-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Monday, July 29, 2019 6:15 PM > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of VLAN pcp item > > Function m

Re: [dpdk-dev] [PATCH] doc: announce API change in mbuf

2019-08-05 Thread Andrew Rybchenko
On 8/1/19 3:41 PM, Thomas Monjalon wrote: In order to prepare for a long term stable API, the mbuf library has to change: allowing more features as dynamic fields, and fixing the lack of rte_ prefix in the namespace. The namespace fix should not break the compatibility by keeping some aliases dur

[dpdk-dev] [PATCH] net/mvpp2: remove resources when port is closed

2019-08-05 Thread lironh
From: Liron Himi Since 18.11, it is suggested that driver should release all its private resources at the dev_close routine. So all resources previously released in remove routine are now released at the dev_close routine, and the dev_close routine will be called in driver remove routine in order

[dpdk-dev] [PATCH] net/mlx5: fix link speed info when link is down

2019-08-05 Thread Xiaoyu Min
When the link is down, the link speed returned by ethtool is UINT32_MAX and the link status is 0. In this case, the DPDK ethdev link speed should be set to ETH_SPEED_NUM_NONE. Otherwise since link speed is non-zero but link status is zero, this is an inconsistent situation and -EAGAIN is returned,

[dpdk-dev] [PATCH] net/thunderx: fix nicvf cleanup on detaching PCI dev

2019-08-05 Thread agupta3
From: Amit Gupta There was a bug while doing PCI detach because of that app gets seg fault as eth_dev is released without stopping/cleaning up mapped nicvf. Fixed this bug by adding nicvf cleanup stupport on PCI detach. Fixes: fdf91e0f2fac ("drivers/net: do not use ethdev driver") Signed-off-by

  1   2   >