Re: [dpdk-dev] [PATCH] examples/qos_meter: fix meter color type conversion

2019-08-10 Thread Thomas Monjalon
09/08/2019 13:56, Dumitrescu, Cristian: > From: Singh, Jasvinder > > In APP_MODE_SRTCM_COLOR_AWARE mode, sample app compilation fails > > due to wrong meter color type conversion. > > > > Fixes: fc8a10d8527a ("examples/qos_meter: add color policy") This is not the root cause. Replaced with: Fixe

Re: [dpdk-dev] [PATCH] net/bnxt: revert fix traffic stall on stop/start

2019-08-10 Thread Thomas Monjalon
09/08/2019 19:46, Ajit Khaparde: > On Fri, Aug 9, 2019 at 10:22 AM Lance Richardson < > lance.richard...@broadcom.com> wrote: > > > This reverts commit aa2c00702bad7b2c742e11a86cb9dbbb8364fd88, which > > introduced the possibility of an invalid address exception when running > > an application wit

Re: [dpdk-dev] [PATCH 1/2] doc: announce ethdev ABI change for LRO fields

2019-08-10 Thread Thomas Monjalon
06/08/2019 17:27, Andrew Rybchenko: > On 8/6/19 5:56 PM, Matan Azrad wrote: > > It may be needed by the user to limit the LRO session packet size. > > In order to allow the above limitation, a new Rx configuration may be > > added for the maximum LRO session size. > > > > A new capability may be a

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2019-08-10 Thread Thomas Monjalon
06/08/2019 20:17, Andrew Rybchenko: > On 8/6/19 5:56 PM, Matan Azrad wrote: > > The API breakage is because the ``tso_segsz`` field was documented for > > LRO. > > > > The ``tso_segsz`` field in mbuf indicates the size of each segment in > > the LRO packet in Rx path and should be provided by the L

Re: [dpdk-dev] [patch v5] doc: announce API change in ethdev offload flags

2019-08-10 Thread Thomas Monjalon
> > Add new offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and > > ``DEV_RX_OFFLOAD_FLOW_MARK``. > > Add new function ``rte_eth_dev_set_supported_ptypes`` to allow application > > to set specific ptypes to be updated in ``rte_mbuf::packet_type`` > > > > Signed-off-by: Pavan Nikhilesh > > Acked-by: And

Re: [dpdk-dev] [PATCH] doc: announce ABI change for RSS hash funtion

2019-08-10 Thread Thomas Monjalon
06/08/2019 16:45, Ananyev, Konstantin: > From: Thomas Monjalon > > 04/07/2019 06:43, simei: > > > From: Simei Su > > > > > > Add new field SYMMETRIC_TOEPLITZ in rte_eth_hash_function. This > > > can support symmetric hash function by rte_flow RSS action. > > > > > > Signed-off-by: Simei Su > > >

Re: [dpdk-dev] [PATCH v2] doc: announce removal of old port count function

2019-08-10 Thread Thomas Monjalon
> >> The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05 > >> in commit d9a42a69febf ("ethdev: deprecate port count function"). > >> It is planned to be removed after the next LTS release. > >> > >> Signed-off-by: Thomas Monjalon > >> Acked-by: David Marchand > > Acked-by: Kon

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to fix ethdev API returning void

2019-08-10 Thread Thomas Monjalon
06/08/2019 13:24, Thomas Monjalon: > 23/07/2019 16:22, Ferruh Yigit: > > On 7/23/2019 3:07 PM, Andrew Rybchenko wrote: > > > void return value is bad for get API (like rte_eth_dev_info-get()) > > > since caller does not know if the function does its job or not and > > > output value is filled in. >

Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice about changes to ethernet structures

2019-08-10 Thread Thomas Monjalon
06/08/2019 13:26, Thomas Monjalon: > > >> Tell users about upcoming changes to rte_ether_addr and > > >> rte_ether_header. > > >> > > >> Signed-off-by: Stephen Hemminger > > >> Acked-by: Bruce Richardson > > > > > > Acked-by: Andrew Rybchenko > > > > Acked-by: Ferruh Yigit > > Acked-by: Thom

Re: [dpdk-dev] [PATCH] net/nfb: remove resources when dev is closed

2019-08-10 Thread Ye Xiaolong
On 08/09, Rastislav Cernay wrote: >From: Rastislav Cernay > >The rte_eth_dev_close() function now handles freeing resources for >devices (e.g., mac_addrs). To conform with the new close() behaviour we >are asserting the RTE_ETH_DEV_CLOSE_REMOVE flag so that >rte_eth_dev_close() releases all devic