[dpdk-dev] [PATCH 17/17] net/ice/base: update version info

2019-12-02 Thread Qi Zhang
Update base code version info in readme. Signed-off-by: Qi Zhang --- drivers/net/iavf/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/base/README b/drivers/net/iavf/base/README index f57e1048f..e8c49c36f 100644 --- a/drivers/net/iavf/base/READ

Re: [dpdk-dev] [PATCH] net/ice: add TSO offload use basic path

2019-12-02 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of taox@intel.com > Sent: Tuesday, December 3, 2019 11:29 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [dpdk-dev] [PATCH] net/ice: add TSO offload use basic path > > From: Zhu Tao > > ICE choices VECTO

[dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value

2019-12-02 Thread Qi Zhang
When send a adminq, if get IAVF_AQ_RC_BUSY, we should return IAVF_ERR_NOT_READY. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 2 ++ 1 file changed, 2 insertions(+) diff --gi

[dpdk-dev] [PATCH 12/17] net/iavf/base: update FW API version for X722

2019-12-02 Thread Qi Zhang
Update FW API version from 1.5 to 1.6 for X722 Also added NVM update related APIs. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq_cmd.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/base/iavf_adminq_cmd.

[dpdk-dev] [PATCH 16/17] net/iavf: move device state flag

2019-12-02 Thread Qi Zhang
Move device state flag from ice_hw to ice_adatper since it should not be a part of base code. Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_type.h | 1 - drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_ethdev.c| 13 + 3 files changed, 6 insertions(+), 9

[dpdk-dev] [PATCH 14/17] net/iavf/base: update copyright date

2019-12-02 Thread Qi Zhang
Update copyright date to cover 2019. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 2 +- drivers/net/iavf/base/iavf_adminq.h | 2 +- drivers/net/iavf/base/iavf_adminq_cmd.h | 2 +- drivers/net/iavf/base/iavf_alloc.h | 2 +- dri

[dpdk-dev] [PATCH 13/17] net/iavf/base: add more link speed support

2019-12-02 Thread Qi Zhang
Add 2.5G and 5G link speed support. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq_cmd.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/iavf/base/iavf_adminq_cmd.h b/drivers/net/iavf/base/iavf_adminq_cmd.h index f7cfc0dda..

[dpdk-dev] [PATCH 10/17] net/iavf/base: increase max VSI count for VFs

2019-12-02 Thread Qi Zhang
Change max VSI per VF from 3 to 4. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_type.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/iavf/base/iavf_type.h b/drivers/net/iavf/base/iavf_type.h index 6d63f4396..9fe5cb1

[dpdk-dev] [PATCH 11/17] net/iavf/base: fix command buffer memory free

2019-12-02 Thread Qi Zhang
Allocated resources were not freed in the event of failure in iavf_init_asq function. This patch gracefully handles all failures. Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") Cc: sta...@dpdk.org Signed-off-by: Maharajan Pandi Kumar Signed-off-by: Paul M Stillwell Jr Signed-of

[dpdk-dev] [PATCH 08/17] net/iavf/base: update virtual channel

2019-12-02 Thread Qi Zhang
Update virtual channel API to align with latest spec. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/virtchnl.h | 343 ++- 1 file changed, 232 insertions(+), 111 deletions(-) diff --git a/drivers/net/iavf/base/virtchnl.h

[dpdk-dev] [PATCH 07/17] net/iavf/base: rename functions

2019-12-02 Thread Qi Zhang
Rename iavf_parse_hw_config to iavf_vf_parse_hw_config. Rename iavf_reset to iavf_vf_reset. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_common.c| 8 drivers/net/iavf/base/iavf_prototype.h | 4 ++-- drivers/net/iavf/iavf_vchnl.c

[dpdk-dev] [PATCH 09/17] net/iavf/base: adjust code indent

2019-12-02 Thread Qi Zhang
Adjust the indent in function and macro defination. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_alloc.h | 14 +++--- drivers/net/iavf/base/iavf_common.c| 22 +++--- drivers/net/iavf/base/iavf_prototype.h | 16

[dpdk-dev] [PATCH 05/17] net/iavf/base: remove unused code

2019-12-02 Thread Qi Zhang
Remove unused APIs in iavf_prototype.h, iavf_adminq_cmd.h iavf_type.h, iavf_adminq.h and iavf_common.c Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 27 +- drivers/net/iavf/base/iavf_adminq.h | 43 - drivers/net/iavf/base/iavf_a

[dpdk-dev] [PATCH 06/17] net/iavf/base: remove unnecessary compile option

2019-12-02 Thread Qi Zhang
Remove compile option INTEGRATED_VF. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 19 --- drivers/net/iavf/base/iavf_common.c | 9 ++--- drivers/net/iavf/base/iavf_type.h | 8 3 files changed, 2 insertions(

[dpdk-dev] [PATCH 04/17] net/iavf/base: update device id

2019-12-02 Thread Qi Zhang
Add all supported device id. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_common.c | 8 +--- drivers/net/iavf/base/iavf_devids.h | 5 - 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/base/iavf_common.c b/driv

[dpdk-dev] [PATCH 03/17] net/iavf/base: rename register macro

2019-12-02 Thread Qi Zhang
Rename all register macro to align with kernel driver's implementation. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c | 34 +-- drivers/net/iavf/base/iavf_common.c | 4 +- drivers/net/iavf/base/iavf_osdep.h| 2 +- drivers/net/iav

[dpdk-dev] [PATCH 02/17] net/iavf/base: rename error code enum

2019-12-02 Thread Qi Zhang
Rename iavf_status_code to iavf_status to align with kernel driver's implementation. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_adminq.c| 56 - drivers/net/iavf/base/iavf_alloc.h | 8 +-- drivers/net/iavf/base/iavf_common

[dpdk-dev] [PATCH 01/17] net/iavf/base: remove unnecessary header file

2019-12-02 Thread Qi Zhang
Delete iavf_hmc.h and iavf_lan_hmc.h since its not necessary. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/iavf/base/iavf_hmc.h | 216 --- drivers/net/iavf/base/iavf_lan_hmc.h | 171 --- drivers/net/iavf/b

[dpdk-dev] [PATCH 00/17] iavf base code update

2019-12-02 Thread Qi Zhang
Update iavf base code to latest. main changes 1) Add more supported device ID 2) update virtual channel to latest AVF spec. 3) code clean. 4) couple bug fixes Qi Zhang (17): net/iavf/base: remove unnecessary header file net/iavf/base: rename error code enum net/iavf/base: rename register m

[dpdk-dev] [PATCH] net/ixgbe: add or remove MAC address

2019-12-02 Thread Guinan Sun
Ixgbe PMD pf host code needs to support ixgbevf mac address add and remove. For this purpose, a response was added between pf and vf to update the mac address. Signed-off-by: Guinan Sun --- drivers/net/ixgbe/ixgbe_ethdev.h | 1 + drivers/net/ixgbe/ixgbe_pf.c | 35 +++

Re: [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation APIs instead

2019-12-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, December 3, 2019 12:53 AM > To: Morten Brørup > Cc: tho...@monjalon.net; Gavin Hu (Arm Technology China) > ; Joyce Kong (Arm Technology China) > ; dev@dpdk.org; jer...@marvell.com; Bruce > Richardson ; nd ; > david.march...

[dpdk-dev] [PATCH] net/ice: add TSO offload use basic path

2019-12-02 Thread taox . zhu
From: Zhu Tao ICE choices VECTOR TX path or Basic TX path by macro ICE_NO_VECTOR_FLAGS. TSO offload only processed by Basic TX path. Fixes: f88de4694d ("net/ice: support Tx SSE vector") Signed-off-by: Zhu Tao --- drivers/net/ice/ice_rxtx_vec_common.h | 1 + 1 file changed, 1 insertion(+) dif

[dpdk-dev] [PATCH] net/iavf: add TSO offload use basic path

2019-12-02 Thread taox . zhu
From: Zhu Tao IAVF choices VECTOR TX path or Basic TX path by macro IAVF_NO_VECTOR_FLAGS. TSO offload only processed by Basic TX path. Fixes: 605c6f9ca5 ("net/avf: convert to new Rx and Tx offload API") Signed-off-by: Zhu Tao --- drivers/net/iavf/iavf_rxtx.h | 1 + 1 file changed, 1 insertion

[dpdk-dev] [PATCH 4/4] net/ixgbe: cleanup Tx buffers

2019-12-02 Thread Chenxu Di
From: Di ChenxuX Add support to the ixgbe driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Di ChenxuX --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ drivers/net/ixgbe/ixgbe_rxtx.c | 39 drivers/net/ixgbe/ixg

[dpdk-dev] [PATCH 0/4] drivers/net: cleanup Tx buffers

2019-12-02 Thread Chenxu Di
From: Di ChenxuX Add support to the drivers inclulding fm10k, i40e, ice, ixgbe for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Di ChenxuX (4): net/fm10k: cleanup Tx buffers net/i40e: cleanup Tx buffers net/ice: cleanup Tx buffers net/ixgbe: cleanup Tx buf

[dpdk-dev] [PATCH 1/4] net/fm10k: cleanup Tx buffers

2019-12-02 Thread Chenxu Di
From: Di ChenxuX Add support to the fm10k driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Di ChenxuX --- drivers/net/fm10k/fm10k.h| 2 ++ drivers/net/fm10k/fm10k_ethdev.c | 1 + drivers/net/fm10k/fm10k_rxtx.c | 45 ++

[dpdk-dev] [PATCH 2/4] net/i40e: cleanup Tx buffers

2019-12-02 Thread Chenxu Di
From: Di ChenxuX Add support to the i40e driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Di ChenxuX --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c | 40 +

[dpdk-dev] [PATCH 3/4] net/ice: cleanup Tx buffers

2019-12-02 Thread Chenxu Di
From: Di ChenxuX Add support to the ice driver for the API rte_eth_tx_done_cleanup to force free consumed buffers on Tx ring. Signed-off-by: Di ChenxuX --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 41 drivers/net/ice/ice_rxtx.h

[dpdk-dev] [PATCH v3 1/3] doc: add skeleton for eventdevs feature matrices

2019-12-02 Thread Sunil Kumar Kori
Patch adds skeleton for feature matrices for event dev and Rx/Tx adapters. Along with, .ini files are added for all supported PMDs. Signed-off-by: Sunil Kumar Kori --- v3: - Removed .txt files to generate tables. - Use conf.py script to generate tables. - Add .ini file for all supported PMDs.

[dpdk-dev] [PATCH v3 3/3] doc: update eventdev feature matrix for octeontx

2019-12-02 Thread Sunil Kumar Kori
Patch updates eventdev and adapters feature matrices for octeontx platform. Signed-off-by: Sunil Kumar Kori --- v3: - Removed .txt files to generate tables. v2: - Review comments incorporated doc/guides/eventdevs/features/octeontx.ini | 8 1 file changed, 8 insertions(+) diff --git

[dpdk-dev] [PATCH v3 2/3] doc: update eventdev feature matrix for octeontx2

2019-12-02 Thread Sunil Kumar Kori
Patch updates eventdev and adapters feature matrices for octeontx2 platform. Signed-off-by: Sunil Kumar Kori --- v3: - Removed .txt files to generate tables. v2: - Review comments incorporated doc/guides/eventdevs/features/octeontx2.ini | 9 + 1 file changed, 9 insertions(+) diff --g

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In

[dpdk-dev] [PATCH v2] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Xiaolong Ye
kernel_dir option in meson build is equivalent to RTE_KERNELDIR in make system, for cross-compilation case, users would specify it as local kernel src dir like //target-arm_glibc/linux-arm/linux-4.19.81/ Current meson build would fail to compile kernel module if user specify kernel_dir as above,

Re: [dpdk-dev] [EXT] Re: [RFC] ethdev: allow multiple security sessions to use one rte flow

2019-12-02 Thread Anoob Joseph
Hi Akhil, Can you see my responses below and see if I can pursue this RFC? Thanks, Anoob > -Original Message- > From: dev On Behalf Of Anoob Joseph > Sent: Wednesday, October 9, 2019 4:25 PM > To: Yigit, Ferruh ; Akhil Goyal > ; Adrien Mazarguil ; > Declan Doherty ; Pablo de Lara > ; Th

[dpdk-dev] [PATCH] net/i40e: enable multi-queue Rx interrupt for VF

2019-12-02 Thread Lunyuan Cui
Current implementation is that only one Rx queue can support interrupt, because all queues are mapped in the same vector id in vfio_enable_msix(). So VF can not support multi-queue Rx interrupt in the interrupt mode. In this patch, if the packet I/O interrupt on datapath is enabled (rte_intr_dp_is

[dpdk-dev] [PATCH] net/ixgbe: enable jumbo frame for VF

2019-12-02 Thread Junyu Jiang
Enable jumbo frame for VF by configuring DPDK PF. Signed-off-by: Junyu Jiang --- drivers/net/ixgbe/ixgbe_pf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c index d0d85e138..66b856e11 100644 --- a/drivers/net/ixgbe/i

Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

2019-12-02 Thread Wiles, Keith
> On Dec 2, 2019, at 3:20 PM, Frank Li wrote: > > Hi Keith, > > Thanks for fixing my macros from ETHER_TYPE_IPv6 to PG_ETHER_TYPE_IPv6 in > your latest commit. > > I tested the 'dev' branch with tap interfaces running the command: > `pktgen l 1-5 -n 4 --proc-type auto --log-level debug --fil

Re: [dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

2019-12-02 Thread Frank Li
Hi Keith, Thanks for fixing my macros from ETHER_TYPE_IPv6 to PG_ETHER_TYPE_IPv6 in your latest commit. I tested the 'dev' branch with tap interfaces running the command: `pktgen l 1-5 -n 4 --proc-type auto --log-level debug --file-prefix pg --vdev=net_tap0 --vdev=net_tap1 -- -T -P -m [2:3].0 -m

Re: [dpdk-dev] [PATCH 57/69] net/i40e/base: update virtchnl header with advanced features

2019-12-02 Thread Stillwell Jr, Paul M
NACK, this code is not properly stripped and should not be released externally. Additionally, APF is NOT released and is only for Mt Evans and should not be in the code. Paul > -Original Message- > From: dev On Behalf Of Xiaolong Ye > Sent: Sunday, December 1, 2019 11:49 PM > To: Xing,

Re: [dpdk-dev] [PATCH 52/69] net/i40e/base: exposing missing LED functionality

2019-12-02 Thread Stillwell Jr, Paul M
NACK, this code is not properly stripped and should not be released externally. Additionally, the commit message shouldn't mention anything about wrapping the code so if you want to include this you will need to re-write the commit message to make sense without mentioning wrapping the code. Pau

Re: [dpdk-dev] [PATCH 35/69] net/i40e/base: update FPK FW API version to 1.9

2019-12-02 Thread Stillwell Jr, Paul M
NACK, no code names in public commit messages. Paul > -Original Message- > From: dev On Behalf Of Xiaolong Ye > Sent: Sunday, December 1, 2019 11:49 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Azarewicz, Piotr > > Subject: [dpdk-dev] [PATCH 35/69] net/i40e/ba

[dpdk-dev] [Bug 374] Meson build failure due to libibverbs-dev upgrade (version=45mlnx1-1.45101)

2019-12-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=374 Bug ID: 374 Summary: Meson build failure due to libibverbs-dev upgrade (version=45mlnx1-1.45101) Product: DPDK Version: unspecified Hardware: All OS: All

[dpdk-dev] [Bug 355] Meson build failure due to libibverbs-dev upgrade (version=45mlnx1-1.45101)

2019-12-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=355 Dharmik Thakkar (dharmik.thak...@arm.com) changed: What|Removed |Added Resolution|--- |FIXED Stat

Re: [dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread Kinsella, Ray
+1 > -Original Message- > From: Thomas Monjalon > Sent: Monday 2 December 2019 16:13 > To: Kinsella, Ray > Cc: Richardson, Bruce ; David Marchand > ; dev ; Neil Horman > > Subject: Re: [dpdk-dev] [PATCH] version: 20.02-rc0 > > 02/12/2019 16:43, Kinsella, Ray: > > QQ. > > > > What do yo

Re: [dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread Kinsella, Ray
QQ. What do you plan to do then, when you go for longer periods of ABI stability? Ray K > -Original Message- > From: Bruce Richardson > Sent: Monday 2 December 2019 15:40 > To: David Marchand > Cc: Thomas Monjalon ; dev ; Neil > Horman ; Kinsella, Ray > Subject: Re: [dpdk-dev] [PATCH]

Re: [dpdk-dev] [PATCH 60/69] net/i40e/base: clarify requirements

2019-12-02 Thread Williams, Mitch A
NAK Code wrapped in EXTERNAL_RELEASE must not be released publicly. > -Original Message- > From: Ye, Xiaolong > Sent: Sunday, December 01, 2019 11:49 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Williams, Mitch A > > Subject: [PATCH 60/69] net/i40e/base: clari

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-12-02 Thread Nirmal Sarkar
Hi Keith, I've taken all the changes [in pktgen-3.7.1] you made to support Jumbo Frame. I'm sending packet of 9000 bytes from the sender. [sending screenshot attached]. In the receiver side: (1) started testpmd: [ testpmd -c 0x0f -n 2 -b 03:00.0 -- -i --rxd=1024 --txd=1024 --burst=144 --txpt=32

Re: [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation APIs instead

2019-12-02 Thread Stephen Hemminger
On Mon, 2 Dec 2019 10:24:32 +0100 Morten Brørup wrote: > Thomas, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, December 2, 2019 10:12 AM > > > > 02/12/2019 07:09, Gavin Hu (Arm Technology China): > > > Hi Bruce, Tho

Re: [dpdk-dev] [PATCH v2 04/17] net/ionic: register and initialize the adapter

2019-12-02 Thread Stephen Hemminger
On Tue, 15 Oct 2019 10:22:22 +0200 Alfredo Cardigliano wrote: > + /* BAR0: dev_cmd and interrupts */ > + if (num_bars < 1) { > + ionic_init_print(ERR, "No bars found, aborting\n"); Since ionic_init_print already adds a newline. All your log messages will be double spaced.

Re: [dpdk-dev] [PATCH v2 02/17] net/ionic: add hardware structures definitions

2019-12-02 Thread Stephen Hemminger
On Tue, 15 Oct 2019 10:22:20 +0200 Alfredo Cardigliano wrote: > Add hardware structures and message commands definitions for > Pensando network adapters. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > drivers/net/ionic/ionic_if.h | 2491 ++

Re: [dpdk-dev] [PATCH] service: don't walk out of bounds when checking services

2019-12-02 Thread David Marchand
On Tue, Nov 26, 2019 at 3:56 PM Aaron Conole wrote: > > The service_valid call is used without properly bounds checking the > input parameter. Almost all instances of the service_valid call are > inside a for() loop that prevents excessive walks, but some of the > public APIs don't bounds check a

Re: [dpdk-dev] [PATCH] service: don't walk out of bounds when checking services

2019-12-02 Thread Eads, Gage
> -Original Message- > From: Aaron Conole > Sent: Tuesday, November 26, 2019 8:56 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Richardson, Bruce > ; Pavan Nikhilesh > ; Eads, Gage ; Thomas > Monjalon ; David Marchand > > Subject: [PATCH] service: don't walk out of bounds when checking

Re: [dpdk-dev] [PATCH v2 08/17] net/ionic: add adminq support

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add support for the admin queue, which is used for most > of the NIC configurations. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +int > +ionic_cq_init(struct ionic_lif *lif, struct ionic_cq *cq, > +

Re: [dpdk-dev] [PATCH v2 16/17] net/ionic: add TX checksum support

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add support for TX checksumming. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +static void > +ionic_tx_tcp_pseudo_csum(struct rte_mbuf *txm) > +{ > + struct ether_hdr *eth_hdr = rte_pktmbuf_mtod(txm, struct

Re: [dpdk-dev] [PATCH v2 15/17] net/ionic: add stats

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add basic, per queue and extended statistics for > RX and TX, both from the adapter and the driver. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > +static void > +ionic_lif_get_abs_stats(struct ionic_lif *lif, st

Re: [dpdk-dev] [PATCH v2 13/17] net/ionic: add RX and TX handling

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add RX and TX queues setup and handling. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -502,6 +614,8 @@ eth_ionic_dev_uninit(struct rte_eth_dev *eth_dev) > ionic_lif_free(lif); > > eth_dev->dev_

Re: [dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread Thomas Monjalon
02/12/2019 16:43, Kinsella, Ray: > QQ. > > What do you plan to do then, when you go for longer periods of ABI stability? Very good point Ray! For longer periods it would not mach DPDK version number. So we keep standard scheme of increasing by +1 every quarter? > From: Bruce Richardson > > O

Re: [dpdk-dev] [PATCH v2 10/17] net/ionic: add basic port operations

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add support for port start/stop and handle basic features > including mtu and link up/down. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > doc/guides/nics/features/ionic.ini | 4 + > drivers/net/ionic/ionic.h

Re: [dpdk-dev] [PATCH v2 04/17] net/ionic: register and initialize the adapter

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Register the Pensando ionic PMD (net_ionic) and define initial probe > and remove callbacks with adapter initialization. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > doc/guides/nics/features/ionic.ini | 2 + >

Re: [dpdk-dev] [PATCH v2 03/17] net/ionic: add log

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add debug options to the config file. > Define macros used for logs and make use of config file options > to enable them. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > drivers/net/ionic/Makefile | 2 +- >

Re: [dpdk-dev] [PATCH v2 02/17] net/ionic: add hardware structures definitions

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add hardware structures and message commands definitions for > Pensando network adapters. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > drivers/net/ionic/ionic_if.h | 2491 ++ > 1

Re: [dpdk-dev] [PATCH v2 01/17] net/ionic: add skeleton

2019-12-02 Thread Ferruh Yigit
On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > Add makefile and config file options to compile the Pensando ionic PMD. > Add feature and version map file. > Update maintainers file. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson > --- > MAINTAINERS

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Bruce Richardson wrote: >On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: >> On 12/02, Igor Ryzhov wrote: >> >We should at least install it into /lib/modules/kernel-version. For >> >convenience, dpdk modules are installed into >> >/lib/modules/kernel-version/extra/dpdk. >> >In

[dpdk-dev] [PATCH 4/4] eal: remove limitation on cpuset with --lcores

2019-12-02 Thread David Marchand
Contrary to the -c/-l options, where a logical core runs on the same physical core in a 1:1 fashion (example: lcore 0 runs on core 0, lcore 16 runs on core 16), the --lcores option makes it possible to select the physical cores on which runs a logical core. However the current parsing code still l

[dpdk-dev] [PATCH 1/4] eal/windows: fix cpuset macro name

2019-12-02 Thread David Marchand
Fix the name of CPU_SETSIZE in hope we can reuse it in other parts of the dpdk manipulating some rte_cpuset_t. Fixes: 4dc2b4d2a4cd ("eal/windows: add headers for compatibility") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_eal/windows/eal/include/sched.h | 8 1 file

[dpdk-dev] [PATCH 3/4] eal: display all detected cores at startup

2019-12-02 Thread David Marchand
Add debug logs to have a trace of unused cores for -c/-l options on systems with more cores than RTE_MAX_LCORE. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/eal_common_lcore.c b/lib/l

[dpdk-dev] [PATCH 2/4] eal: do not cache lcore detection state

2019-12-02 Thread David Marchand
We use this state in control path only for services cores and -c/-l options. The value is not updated when using --lcores. Use the internal helper where needed. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 4 +--- lib/librte_eal/common/eal_common_options.c | 1

Re: [dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread Bruce Richardson
On Mon, Dec 02, 2019 at 04:29:06PM +0100, David Marchand wrote: > On Mon, Dec 2, 2019 at 3:57 PM Thomas Monjalon wrote: > > > > Start a new release cycle with empty release notes. > > > > Signed-off-by: Thomas Monjalon > > > > --- > > > > I would prefer increasing the ABI version to 20.2 > > for

[dpdk-dev] i40evf_del_mac_addr_by_addr in - i40e_ethdev_vf.c

2019-12-02 Thread Kamaraj P
Hello All, Currently i40evf_del_mac_addr_by_addr() API uses i40e_validate_mac_addr() to check the mac address and delete the mac address from the table. Why cant we use rte_is_zero_ether_addr() ? in this case ? >From the i40evf_add_mac_addr() we are using the rte_is_zero_ether_addr() API to val

[dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2019-12-02 Thread David Marchand
We are currently stuck with no option but recompile a DPDK if the system has more cores than RTE_MAX_LCORE. A bit of a pity when you get a system with more than 200+ cores and your testpmd has been built and packaged with RTE_MAX_LCORE == 128. The --lcores does not need to care about the underlyin

Re: [dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread David Marchand
On Mon, Dec 2, 2019 at 3:57 PM Thomas Monjalon wrote: > > Start a new release cycle with empty release notes. > > Signed-off-by: Thomas Monjalon > > --- > > I would prefer increasing the ABI version to 20.2 > for an easy mapping with code version: > DPDK 19.11 = ABI 20 > libs 19.1

[dpdk-dev] [PATCH] mark experimental variables

2019-12-02 Thread David Marchand
So far, we did not pay attention to direct access to variables but they are part of the API/ABI too and should be clearly identified. Introduce a __rte_experimental_var tag and mark existing exported variables. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") Cc: s

[dpdk-dev] [PATCH] version: 20.02-rc0

2019-12-02 Thread Thomas Monjalon
Start a new release cycle with empty release notes. Signed-off-by: Thomas Monjalon --- I would prefer increasing the ABI version to 20.2 for an easy mapping with code version: DPDK 19.11 = ABI 20 libs 19.11 = .so.20.0 DPDK 20.02 = ABI 20 libs 20.02 = .so.20.2

[dpdk-dev] [PATCH] vhost: add config change slave msg support

2019-12-02 Thread Li Feng
This msg is used to notify qemu that should get the config of backend. For example, vhost-user-blk uses this msg to notify guest os the compacity of backend has changed. Signed-off-by: Li Feng --- lib/librte_vhost/vhost_user.c | 31 +++ lib/librte_vhost/vhost_user.h

[dpdk-dev] [PATCH] net/octeontx2: fix VF configuration fail

2019-12-02 Thread Harman Kalra
Returning -ENOTSUP only in case loopback mode is enabled and device is VF or SDP. Fixes: c2c0aa75cd01 ("net/octeontx2: fix loopback config return for VF") Cc: sta...@dpdk.org Signed-off-by: Harman Kalra --- drivers/net/octeontx2/otx2_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [dpdk-dev] [PATCH 7/7] test: add SPDX headers

2019-12-02 Thread Trahe, Fiona
> > > -Original Message- > > > From: dev On Behalf Of Stephen Hemminger > > > Sent: Wednesday, September 25, 2019 9:22 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [dpdk-dev] [PATCH 7/7] test: add SPDX headers > > > > > > These are minor test files that never got c

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-12-02 Thread Nirmal Sarkar
Hello Keith, Thanks a lot for your help. I'm using pktgen-3.7.1. So I'll pull your changes there and check it. Regards, N. Sarkar On Sat, Nov 30, 2019 at 5:31 AM Wiles, Keith wrote: > > > > On Nov 19, 2019, at 11:42 AM, Roberts, Lee A. > wrote: > > > > Nirmal, > > > > Here are the changes tha

[dpdk-dev] [Bug 373] i40e: TSO breaks for packets larger than 16k

2019-12-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=373 Bug ID: 373 Summary: i40e: TSO breaks for packets larger than 16k Product: DPDK Version: 19.08 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Bruce Richardson
On Mon, Dec 02, 2019 at 07:34:54PM +0800, Ye Xiaolong wrote: > On 12/02, Igor Ryzhov wrote: > >We should at least install it into /lib/modules/kernel-version. For > >convenience, dpdk modules are installed into > >/lib/modules/kernel-version/extra/dpdk. > >In the cross-compilation case, you can use

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix unnecessary boolean casts

2019-12-02 Thread Ferruh Yigit
On 12/2/2019 9:15 AM, Ciara Power wrote: > The values already boolean types, so the use of !! is unnecessary as > it is used to convert to boolean. > > Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") > Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") > Cc: oliv

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

2019-12-02 Thread Andrew Rybchenko
On 12/2/19 2:09 PM, Jerin Jacob wrote: > On Mon, Dec 2, 2019 at 6:16 PM Thomas Monjalon wrote: >> >> 02/12/2019 05:21, Jerin Jacob: >>> On Mon, Nov 25, 2019 at 8:39 PM Thomas Monjalon wrote: 25/11/2019 11:44, Jerin Jacob: > On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon > wro

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
On 12/02, Igor Ryzhov wrote: >We should at least install it into /lib/modules/kernel-version. For >convenience, dpdk modules are installed into >/lib/modules/kernel-version/extra/dpdk. >In the cross-compilation case, you can use DEST_DIR to set some prefix. > >I don't really see the issue here. The

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

2019-12-02 Thread Jerin Jacob
On Mon, Dec 2, 2019 at 6:16 PM Thomas Monjalon wrote: > > 02/12/2019 05:21, Jerin Jacob: > > On Mon, Nov 25, 2019 at 8:39 PM Thomas Monjalon wrote: > > > > > > 25/11/2019 11:44, Jerin Jacob: > > > > On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon > > > > wrote: > > > > > > > > > > 23/11/2019 10

Re: [dpdk-dev] [PATCH v7 1/1] fbarray: fix duplicated fbarray file in secondary

2019-12-02 Thread Burakov, Anatoly
On 29-Nov-19 5:44 AM, Yasufumi Ogawa wrote: Hi Anatoly, On 2019/11/27 19:26, Burakov, Anatoly wrote: On 26-Nov-19 7:40 PM, Yasufumi Ogawa wrote: Hi David, Sorry for slow reply. On 2019/11/14 21:27, David Marchand wrote: On Thu, Nov 14, 2019 at 12:42 PM Yasufumi Ogawa wrote: On 2019/11/14

Re: [dpdk-dev] [PATCH v4] add drop statistic for af_packet

2019-12-02 Thread Ferruh Yigit
On 11/29/2019 2:59 PM, Vadim Podovinnikov wrote: > Signed-off-by: Vadim Podovinnikov > --- > drivers/net/af_packet/rte_eth_af_packet.c | 33 +-- > 1 file changed, 25 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c > b/drivers/net/af_p

Re: [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation APIs instead

2019-12-02 Thread Thomas Monjalon
02/12/2019 10:24, Morten Brørup: > Thomas, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Monday, December 2, 2019 10:12 AM > > > > 02/12/2019 07:09, Gavin Hu (Arm Technology China): > > > Hi Bruce, Thomas, > > > > > > This seri

Re: [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation APIs instead

2019-12-02 Thread Morten Brørup
Thomas, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, December 2, 2019 10:12 AM > > 02/12/2019 07:09, Gavin Hu (Arm Technology China): > > Hi Bruce, Thomas, > > > > This series of patches was reported a compilation issue[1] on

[dpdk-dev] [PATCH] lib: fix unnecessary boolean casts

2019-12-02 Thread Ciara Power
The values already boolean types, so the use of !! is unnecessary as it is used to convert to boolean. Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") Cc: olivier.m...@6wind.com Cc: bruce.richard...@intel.com Cc:

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Igor Ryzhov
We should at least install it into /lib/modules/kernel-version. For convenience, dpdk modules are installed into /lib/modules/kernel-version/extra/dpdk. In the cross-compilation case, you can use DEST_DIR to set some prefix. I don't really see the issue here. The description clearly says that head

Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

2019-12-02 Thread Thomas Monjalon
02/12/2019 05:21, Jerin Jacob: > On Mon, Nov 25, 2019 at 8:39 PM Thomas Monjalon wrote: > > > > 25/11/2019 11:44, Jerin Jacob: > > > On Sun, Nov 24, 2019 at 3:12 AM Thomas Monjalon > > > wrote: > > > > > > > > 23/11/2019 10:42, Jerin Jacob: > > > > > On Sat, Nov 23, 2019 at 3:58 AM Thomas Monjal

Re: [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bit operation APIs instead

2019-12-02 Thread Thomas Monjalon
02/12/2019 07:09, Gavin Hu (Arm Technology China): > Hi Bruce, Thomas, > > This series of patches was reported a compilation issue[1] on 32bit Ubuntu. > On mainstream 64-bit OS, "unsigned long" is 64-bit in size and we uses the > 64-bit variant of APIs. But the 32-bit OS expect 32-bit 'unsigned

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Ye Xiaolong
Hi, Igor Thanks for the feedback. On 12/02, Igor Ryzhov wrote: >Hi Xiaolong, > >Nack from me. It's just an incorrect revert of my fix. >Kernel modules will be installed in wrong directory, just check install_dir Is there any convention that we must install kernel modules to which directory? And

Re: [dpdk-dev] [PATCH v2] doc: introduce openwrt how-to guide

2019-12-02 Thread Ye Xiaolong
On 12/02, Jerin Jacob wrote: >On Mon, Dec 2, 2019 at 3:38 PM Xiaolong Ye wrote: >> >> This doc describes how to enable DPDK on openwrt in both virtual and >> physical x86 environment. > > >Could you split the documentation into generic and x86 specific? So >other architectures >can add the archite

Re: [dpdk-dev] [PATCH] kernel/linux: fix kernel dir for meson

2019-12-02 Thread Igor Ryzhov
Hi Xiaolong, Nack from me. It's just an incorrect revert of my fix. Kernel modules will be installed in wrong directory, just check install_dir parameter in kni/meson.build and igb_uio/meson.build. Igor On Mon, Dec 2, 2019 at 9:18 AM Xiaolong Ye wrote: > kernel_dir option in meson build is equ

[dpdk-dev] [PATCH 69/69] net/i40e/base: update version

2019-12-02 Thread Xiaolong Ye
Update version to 2019.11.14. Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 8a5339cff..6511f9a2f 100644 --- a/drivers/net/i40e/base/README +++ b/dri

[dpdk-dev] [PATCH 68/69] net/i40e/base: add missing 0 length checks

2019-12-02 Thread Xiaolong Ye
Other RSS-related opcodes allow 0 as a valid length for the number of elements in their variable-sized structs, so allow 0 for VIRTCHNL_OP_CONFIG_RSS_KEY and VIRTCHNL_OP_CONFIG_RSS_LUT, too. This avoids a situation where a struct with a number of elements of 0 must shrink the size of the default s

[dpdk-dev] [PATCH 66/69] net/i40e/base: support for additional flow type

2019-12-02 Thread Xiaolong Ye
This patch adds/supports following: - Separate flow type for TCP and UDP for IPv4[6] - added new offload capability such as ADQ_V2 which will be used to support advanced ADQ features such as more filter types, 16 TCs, usage of ADQ performance code Signed-off-by: Parthasarathy Sarangam Signed-off-

[dpdk-dev] [PATCH 62/69] net/i40e/base: add USO offload flag for AVF

2019-12-02 Thread Xiaolong Ye
Add new virtchl offload flag to indicate ability to support UDP segmentation offload in driver Signed-off-by: Vignesh Sridhar Reviewed-by: Creeley Brett Reviewed-by: Aggarwal Mitu Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 1 + 1 file changed, 1 insertion(+) diff --git

[dpdk-dev] [PATCH 67/69] net/i40e/base: change GET/SET_RSS_LUT valid_len check

2019-12-02 Thread Xiaolong Ye
Each lut entry is a u16, so fix the valid_len check using sizeof(u16) Signed-off-by: Christopher Pau Reviewed-by: Shanmugam Jayaprakash Reviewed-by: Burra Phani R Reviewed-by: Kirsher Jeffrey T Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 2 +- 1 file changed, 1 insertio

[dpdk-dev] [PATCH 65/69] net/i40e/base: change all zero-sized arrays

2019-12-02 Thread Xiaolong Ye
C++ compilers do not allow zero-sized arrays. Convert structs to use single element arrays. Signed-off-by: Christopher Pau Reviewed-by: Joyner Eric Reviewed-by: Kirsher Jeffrey T Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/virtchnl.h | 77 +++- 1 file chan

  1   2   >