Re: [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

thanks for your correction I will rewrite my commit log and send email again 方统浩50450 邮箱：fangtong...@sangfor.com.cn 签名由 网易邮箱大师 定制 On 01/10/2020 15:30, Jeff Guo wrote: hi, tonghao On 1/9/2020 8:27 PM, Fang TongHao wrote: > Hi all，I am from Sangfor Tech.I found a bug when using DPDK in > m

Re: [dpdk-dev] [PATCH v4 0/6] OCTEON TX2 End Point Driver

On Tue, Jan 7, 2020 at 7:53 PM Mahipal Challa wrote: > > This patchset adds support for OCTEON TX2 end point mode of operation. > The driver implementation uses DPDK rawdevice sub-system. > > v2: > * Updated memory barrior API's as per Gavin Hu suggestion. > > v3: > * Fixed memory leak possibility

Re: [dpdk-dev] [PATCH v4 0/6] OCTEON TX2 End Point Driver

Hi Thomas, Assuming that this series is ready for merging now, would you please merge this series. Thank you Gavin for reviewing the series. Thanks, Mahipal > -Original Message- > From: Gavin Hu > Sent: Wednesday, January 8, 2020 1:45 PM > To: Mahipal Challa ; dev@dpdk.org; > tho...@mo

Re: [dpdk-dev] [PATCH] ethdev: fix secondary process change share memory

hi, tonghao On 1/9/2020 8:27 PM, Fang TongHao wrote: Hi all，I am from Sangfor Tech.I found a bug when using DPDK in multiprocess scenario.The secondary process enters "rte_eth_dev_pci_copy_info" function when initializing.Then it sets the value of struct "rte_eth_dev_data.dev_flags" to zero, bu

Re: [dpdk-dev] [PATCH] app/testpmd: fix missing GENEVE item in helper func

On 1/8/20 6:07 PM, Dekel Peled wrote: > Previous patch added support of GENEVE pattern item in flow rule. > Function flow_item_default_mask() was not updated, so using it with > GENEVE item returns null. > Using testpmd command "set raw_decap" or "set raw_encap" with > GENEVE item, without specifyi

[dpdk-dev] [RFC 6/7] config/common_base: add igc PMD flags

From: Alvin Zhang Add control flags for compiling igc PMD. Signed-off-by: Alvin Zhang --- config/common_base | 8 1 file changed, 8 insertions(+) diff --git a/config/common_base b/config/common_base index 7dec7ed..90ce3bc 100644 --- a/config/common_base +++ b/config/common_base @@ -2

[dpdk-dev] [RFC 7/7] doc: add igc guide and feature list

From: Alvin Zhang Add igc.rst and igc.ini files. Signed-off-by: Alvin Zhang --- doc/guides/nics/features/igc.ini | 36 ++ doc/guides/nics/igc.rst | 65 2 files changed, 101 insertions(+) create mode 100644 doc/guides/nics/f

[dpdk-dev] [RFC 5/7] drivers/net: add meson build for igc

From: Alvin Zhang Add meson build files to igc PMD. Signed-off-by: Alvin Zhang --- drivers/net/igc/base/meson.build| 43 + drivers/net/igc/meson.build | 15 drivers/net/igc/rte_pmd_igc_version.map | 3 +++ drivers/net/meson.buil

[dpdk-dev] [RFC 3/7] drivers/net: add igc make

From: Alvin Zhang Add make files to igc PMD. Signed-off-by: Alvin Zhang --- drivers/net/Makefile | 1 + drivers/net/igc/Makefile | 83 2 files changed, 84 insertions(+) create mode 100644 drivers/net/igc/Makefile diff --git a/drivers/net/

[dpdk-dev] [RFC 4/7] igc: add igc library

From: Alvin Zhang Add igc library file for compiling app. Signed-off-by: Alvin Zhang --- mk/rte.app.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 05ea034..a46d6a3 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -184,6 +184,7 @@ _LDLIBS-$(CONFIG_RT

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

> -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 09, 2020 18:42 > To: Xu, Rosen ; Thomas Monjalon > > Cc: Matan Azrad ; Bie, Tiwei ; > Wang, Zhihong ; Wang, Xiao W > ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy > Subject: Re: [dpdk-dev] [PATCH v1 0/3] Introduce new

Re: [dpdk-dev] [PATCH v1 0/3] Introduce new class for vDPA device drivers

> -Original Message- > From: Matan Azrad > Sent: Thursday, January 09, 2020 19:34 > To: Xu, Rosen ; Thomas Monjalon > > Cc: Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong ; Wang, > Xiao W ; Yigit, Ferruh ; > dev@dpdk.org; Pei, Andy ; Roni Bar Yanai > > Subject: RE: [dpdk-dev] [PATCH v

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

> -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Friday, January 10, 2020 01:26 > To: Matan Azrad ; Maxime Coquelin > ; Bie, Tiwei > ; Wang, Zhihong ; Wang, Xiao W > > Cc: Yigit, Ferruh ; dev@dpdk.org; Thomas Monjalon > ; > Andrew Rybchenko > Subject: Re: [dpdk-dev] [

[dpdk-dev] [PATCH v5] net/iavf/base: change the base as driver common

Change the iavf base code as driver common library, it is used by iavf PMD now, and it can be used by other Intel SR-IOV PMDs in the future. Signed-off-by: Haiyue Wang Acked-by: Qi Zhang --- v5: update the MAINTAINERS v4: keep the iavf spinlock & memmory function prototype in osdep.h v3: updat

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

> > > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > > > Signed-off-by: Bernard Iremonger > > > --- > > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > > b/d

Re: [dpdk-dev] [PATCH v4 6/9] eal: add function to detect process type

On 1/8/2020 10:35 PM, Stephen Hemminger wrote: On Wed, 8 Jan 2020 19:13:09 -0800 Pallavi Kadam wrote: Minor comments /* Address of global and public configuration */ -static struct rte_config rte_config; +static struct rte_config rte_config = { + .mem_config = &early_mem_co

Re: [dpdk-dev] [PATCH 01/14] examples/ipsec-secgw: add default rte_flow for inline Rx

> >>> > >>> Signed-off-by: Ankur Dwivedi > >>> Signed-off-by: Anoob Joseph > >>> --- > >>> examples/ipsec-secgw/ipsec-secgw.c | 56 > >> ++ > >>> examples/ipsec-secgw/ipsec.c | 8 ++ > >>> examples/ipsec-secgw/ipsec.h | 6 > >>> 3 files

Re: [dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes

On Thu, Jan 9, 2020 at 7:03 PM David Marchand wrote: > > On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson > wrote: > > > > Add proper support for calling sphinx whenever a file in the doc > > directory changes. This is accomplished by using a wrapper script > > for sphinx, which runs sphinx but al

Re: [dpdk-dev] [PATCH v3 3/6] doc/api: fix warning with meson build

On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson wrote: > > The install parameter to configure_file is new in 0.50 and generates a > warning since it is newer than our minimum version of 0.47.1. The > parameter, however, is unneeded as the documentation states: > > "When omitted it defaults to true

Re: [dpdk-dev] [PATCH v3 1/6] kernel/linux/kni: fix meson warning about console keyword

On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson wrote: > > Since kni no longer includes the ethtool code and so is faster to build, we > no longer need the console parameter to have incremental screen updates as > it builds. Therefore, we drop the keyword which removes the warning. > > Fixes: b78f

Re: [dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes

On Thu, Jan 9, 2020 at 4:31 PM Bruce Richardson wrote: > > Add proper support for calling sphinx whenever a file in the doc > directory changes. This is accomplished by using a wrapper script > for sphinx, which runs sphinx but also emits a gcc-format dependency > file listing all the doc files. T

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

Honnappa Nagarahalli writes: > > >> > >> >> > >> > Add Travis compilation jobs for aarch64. gcc/clang compilations >> > >> > for static/shared libraries are added. >> > >> > >> > >> > Some limitations for current aarch64 Travis support: >> > >> > 1. Container is used. Huge page is not available

Re: [dpdk-dev] [EXTERNAL] Re: 18.11.6 (LTS) patches review and test

I agree with Kevin. We should investigate the previous performance issue. Lili, please add yourself to the list. Thanks, Ju -Original Message- From: Kevin Traynor Sent: Thursday, January 9, 2020 6:03 AM To: Lili Deng Cc: sta...@dpdk.org; dev@dpdk.org; Abhishek Marathe ; Akhil Goyal ;

Re: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

Hi Ali, On Thu, Jan 09, 2020 at 04:06:53PM +, Ali Alnubani wrote: > Hi Olivier, > > > -Original Message- > > From: dev On Behalf Of Olivier Matz > > Sent: Thursday, January 9, 2020 3:28 PM > > To: dev@dpdk.org > > Cc: Andrew Rybchenko ; Anatoly Burakov > > ; sta...@dpdk.org > > Subje

Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class

Small typo inline. From: Matan Azrad > A new vDPA class was recently introduced. > > IFC driver implements the vDPA operations, hence it should be moved to > the vDPA class. > > Move it. > > Signed-off-by: Matan Azrad > --- > MAINTAINERS | 14 +- > doc/guides/ni

[dpdk-dev] [PATCH v3 4/4] net/mlx5: engage free on completion queue

The free on completion queue keeps the indices of elts array, all mbuf stored below this index should be freed on arrival of normal send completion. In debug version it also contains an index of completed transmitting descriptor (WQE) to check queues synchronization. Signed-off-by: Viacheslav Ovsi

[dpdk-dev] [PATCH v3 1/4] net/mlx5: move Tx complete request routine

The complete request flag is set once per Tx burst call, the code of appropriate routine moved to the end of sending loop. This is preparation step to remove WQE reserved field usage to store index of elts to free. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/m

[dpdk-dev] [PATCH v3 2/4] net/mlx5: update Tx error handling routine

This is preparation step, we are going to store the index of elts to free on completion in the dedicated free on completion queue, this patch updates the elts freeing routine and updates Tx error handling routine to be synched with coming new queue. Signed-off-by: Viacheslav Ovsiienko Acked-by: M

[dpdk-dev] [PATCH v3 0/4] net/mlx5: remove Tx descriptor reserved field usage

The current Tx datapath implementation in mlx5 PMD uses the 16-bit reserved field within transmit descriptor to store the indices of the elts array keeping the mbuf pointers to be freed on transmit completion. On completion PMD fetches the descriptor index, then fetches the elts array index from re

[dpdk-dev] [PATCH v3 3/4] net/mlx5: add free on completion queue

The new software manged entity is introduced in Tx datapath - free on completion queue. This queue keeps the information how many buffers stored in elts array must freed on send comletion. Each element of the queue contains transmitting descriptor index to be in synch with completion entries (in de

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

Thank Julien and Kevin for investigating. We'll investigate option 2 from Kevin's suggestions. > -Original Message- > From: Kevin Traynor > Sent: Thursday, January 9, 2020 2:18 PM > To: Julien Meunier ; Yu, PingX > ; sta...@dpdk.org; > Trahe, Fiona > Cc: dev@dpdk.org; Abhishek Marathe

Re: [dpdk-dev] [dpdk-stable] [PATCH] mark experimental variables

On Thu, Jan 9, 2020 at 3:13 PM Thomas Monjalon wrote: > > 02/12/2019 16:20, David Marchand: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_var tag and mark existing

Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system

On 1/9/20 4:45 PM, Maxime Coquelin wrote: > > > On 1/9/20 3:40 PM, Maxime Coquelin wrote: >> >> >> On 12/4/19 4:07 PM, Adrian Moreno wrote: >>> Currently there are a couple of limitations on the logging system: Most >>> of the logs are compiled out and both datapath and controlpath logs >>> share

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 9, 2020 17:44 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion > queue > > On 1/9/2020

Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit

On Thu, 9 Jan 2020 11:31:30 + Ferruh Yigit wrote: > On 1/9/2020 11:16 AM, Ferruh Yigit wrote: > > On 1/8/2020 3:28 PM, Stephen Hemminger wrote: > >> On Wed, 8 Jan 2020 09:45:54 + > >> "Iremonger, Bernard" wrote: > >> > >>> Hi Stephen, > >>> > -Original Message- >

Re: [dpdk-dev] [Bug 382] rte_eth: rx/tx callbacks invoked without lock protection

On Thu, 09 Jan 2020 07:52:34 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=382 > > Bug ID: 382 >Summary: rte_eth: rx/tx callbacks invoked without lock > protection >Product: DPDK >Version: 18.11 >

Re: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

Hi Olivier, > -Original Message- > From: dev On Behalf Of Olivier Matz > Sent: Thursday, January 9, 2020 3:28 PM > To: dev@dpdk.org > Cc: Andrew Rybchenko ; Anatoly Burakov > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools > > When allocatin

Re: [dpdk-dev] [PATCH v7 02/17] lib/ring: apis to support configurable element size

> > > > > > > > > > > + > > > > > > > > > > > +static __rte_always_inline void > > > > > > > > > > > +enqueue_elems_128(struct rte_ring *r, uint32_t > > > > > > > > > > > +prod_head, const void *obj_table, uint32_t n) { > > > > > > > > > > > +unsigned int i; const uint32_t size = > > > > > > > > >

Re: [dpdk-dev] [Bug 383] dpdk virtio_user lack of notifications make vhost_net+napi stops tx buffers

Proposal for patch - Requesting For Comments. Just running the shadow copy-flush-call unconditionally in vhost_flush_dequeue_packed solve the issue, and it gives the best latency I can get in the tests (8101.959 trans/sec if I run netperf TCP_RR, 1331.735 trans/sec if I run TCP_STREAM at the same

Re: [dpdk-dev] [PATCH v2] vhost-blk: fix the unused return value

On 11/27/19 1:57 PM, Maxime Coquelin wrote: > > > On 11/27/19 1:16 PM, Jin Yu wrote: >> add the assert to handle error. >> >> Coverity issue: 350592 >> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Jin Yu >> --- >> v2 -

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/virtio_user: do not close invalid file descriptor

On 1/7/20 2:41 AM, Tiwei Bie wrote: > On Mon, Jan 06, 2020 at 11:18:37AM -0800, Stephen Hemminger wrote: >> Valgrind complains that virtio_user is calling close(-1). >> Fix this by adding check in virtio that is similar to existing code. >> >> Fixes: 37a7eb2ae816 ("net/virtio-user: add device em

Re: [dpdk-dev] [PATCH] vhost: fix socket initial value

On 1/7/20 2:49 AM, Tiwei Bie wrote: > On Fri, Jan 03, 2020 at 01:36:21PM -0500, Xiao Wang wrote: >> By default, a vhost socket is created without attaching VDPA device, >> this patch fixes the initial value of vdpa_dev_id. >> >> Fixes: b4953225cea4 ("vhost: add APIs for datapath configuration")

Re: [dpdk-dev] [PATCH v3 2/2] ci: add travis ci support for aarch64

> > >> > > >> > Add Travis compilation jobs for aarch64. gcc/clang compilations > > >> > for static/shared libraries are added. > > >> > > > >> > Some limitations for current aarch64 Travis support: > > >> > 1. Container is used. Huge page is not available due to security > > >> > reason. > > >>

Re: [dpdk-dev] [PATCH v3] net/vhost: fix return value of vhost creates not checked

On 1/7/20 6:08 AM, Tiwei Bie wrote: > On Tue, Jan 07, 2020 at 11:25:48AM +0800, Yunjian Wang wrote: >> The function eth_dev_vhost_create() could return errors, >> the return value need to be checked. >> >> Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >> Cc: sta...@dpdk.org >>

Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system

On 1/9/20 4:45 PM, Maxime Coquelin wrote: > > > On 1/9/20 3:40 PM, Maxime Coquelin wrote: >> >> >> On 12/4/19 4:07 PM, Adrian Moreno wrote: >>> Currently there are a couple of limitations on the logging system: Most >>> of the logs are compiled out and both datapath and controlpath logs >>> sh

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

On Fri, Jun 07, 2019 at 06:21:21PM +, Wiles, Keith wrote: > > > > On Jun 7, 2019, at 10:42 AM, Ray Kinsella wrote: > > > > > > > > On 06/06/2019 16:03, Neil Horman wrote: > >> On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: > -Original Message- > >>

[dpdk-dev] [Bug 383] dpdk virtio_user lack of notifications make vhost_net+napi stops tx buffers

https://bugs.dpdk.org/show_bug.cgi?id=383 Bug ID: 383 Summary: dpdk virtio_user lack of notifications make vhost_net+napi stops tx buffers Product: DPDK Version: unspecified Hardware: All OS: Linux

Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system

On 1/9/20 3:40 PM, Maxime Coquelin wrote: > > > On 12/4/19 4:07 PM, Adrian Moreno wrote: >> Currently there are a couple of limitations on the logging system: Most >> of the logs are compiled out and both datapath and controlpath logs >> share the same loglevel. >> >> This patch tries to help

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

On 1/9/2020 3:27 PM, Slava Ovsiienko wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, January 9, 2020 17:19 >> To: Slava Ovsiienko ; dev@dpdk.org >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Ori Kam ; Thomas >> Monjalon >> Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5

[dpdk-dev] [PATCH v2 1/2] net/ena: upgrade HAL for new HW features

This version of the HAL allows to use the latest HW features, like rx offsets. Driver was adjusted to the new version to fix the build. Signed-off-by: Michal Krawczyk Signed-off-by: Maciej Bielski --- v2: * Fix compilation with debug options enabled by using PRIu64 for printout variable type

[dpdk-dev] [PATCH v3 6/6] doc/api: reduce indentation in meson build file

When building the API docs, we can make the meson.build file easier to read, and allow more code per line, by using subdir_done() to quit early. Signed-off-by: Bruce Richardson Acked-by: Aaron Conole --- doc/api/meson.build | 98 +++-- 1 file changed, 50

[dpdk-dev] [PATCH v3 5/6] doc/guides: rebuild with meson whenever a file changes

Add proper support for calling sphinx whenever a file in the doc directory changes. This is accomplished by using a wrapper script for sphinx, which runs sphinx but also emits a gcc-format dependency file listing all the doc files. This is used by ninja so that any change to the doc files triggers

[dpdk-dev] [PATCH v3 4/6] doc/guides: reduce whitespace in meson build file

For building the guides, we can make the meson.build easier to read by using the subdir_done function to quit early. Signed-off-by: Bruce Richardson Acked-by: Aaron Conole --- doc/guides/meson.build | 44 ++ 1 file changed, 23 insertions(+), 21 deletions(

[dpdk-dev] [PATCH v3 2/6] build: skip processing docs folder if docs disabled

While each target is set to be ignored if the docs are disabled in the meson build, there is little reason to process the docs folder at all. Signed-off-by: Bruce Richardson Acked-by: Aaron Conole --- doc/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/doc/meson.build b/doc/

[dpdk-dev] [PATCH v3 3/6] doc/api: fix warning with meson build

The install parameter to configure_file is new in 0.50 and generates a warning since it is newer than our minimum version of 0.47.1. The parameter, however, is unneeded as the documentation states: "When omitted it defaults to true when install_dir is set and not empty, false otherwise." Given th

[dpdk-dev] [PATCH v3 0/6] meson build improvements

These patches make some improvements to the meson build, particularly for documentation. They also remove many, but not all warnings issued by meson e.g. warnings about newer features unsupported in baseline. The biggest change is to improve the handling of the guide html docs. The change here is

[dpdk-dev] [PATCH v3 1/6] kernel/linux/kni: fix meson warning about console keyword

Since kni no longer includes the ethtool code and so is faster to build, we no longer need the console parameter to have incremental screen updates as it builds. Therefore, we drop the keyword which removes the warning. Fixes: b78f32cff94d ("kni: support meson build") Cc: bl...@debian.org Signed-

Re: [dpdk-dev] [PATCH v2 0/6] meson build improvements

On Thu, 2020-01-09 at 12:07 +, Bruce Richardson wrote: > These patches make some improvements to the meson build, particularly > for documentation. They also remove many, but not all warnings issued > by > meson e.g. warnings about newer features unsupported in baseline. > > The biggest change

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 9, 2020 17:19 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion > queue > > On 1/9/2020

Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

czw., 9 sty 2020 o 15:27 Ferruh Yigit napisał(a): > > On 12/13/2019 8:01 PM, Michał Krawczyk wrote: > > pt., 13 gru 2019 o 17:34 Stephen Hemminger > > napisał(a): > >> > >> On Fri, 13 Dec 2019 14:32:15 +0100 > >> Michal Krawczyk wrote: > >> > >>> This version of the HAL allows to use the latest

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: add free on completion queue

> -Original Message- > From: Ferruh Yigit > Sent: Thursday, January 9, 2020 17:12 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: add free on completion > queue > > On 1/9/2020 10:56 AM, Viacheslav O

Re: [dpdk-dev] [PATCH] maintainers: add co-maintainer for flow API

On 1/6/2020 3:37 PM, Ferruh Yigit wrote: > On 1/6/2020 10:37 AM, Adrien Mazarguil wrote: >> On Sun, Dec 29, 2019 at 08:56:58AM +, Ori Kam wrote: >>> I volunteer to be co maintainer for the rte_flow lib. >>> >>> Signed-off-by: Ori Kam >> >> Welcome :) >> >> Acked-by: Adrien Mazarguil >> > > W

Re: [dpdk-dev] [PATCH v2 4/4] net/mlx5: engage free on completion queue

On 1/9/2020 10:56 AM, Viacheslav Ovsiienko wrote: > The free on completion queue keeps the indices of elts array, > all mbuf stored below this index should be freed on arrival > of normal send completion. In debug version it also contains > an index of completed transmitting descriptor (WQE) to che

Re: [dpdk-dev] [PATCH v2 3/4] net/mlx5: add free on completion queue

On 1/9/2020 10:56 AM, Viacheslav Ovsiienko wrote: > The new software manged entity is introduced in Tx datapath > - free on completion queue. This queue keeps the information > how many buffers stored in elts array must freed on send > comletion. Each element of the queue contains transmitting > de

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On Thu, Jan 09, 2020 at 02:29:08PM +, Burakov, Anatoly wrote: > On 09-Jan-20 2:23 PM, Olivier Matz wrote: > > On Thu, Jan 09, 2020 at 01:52:41PM +, Burakov, Anatoly wrote: > > > On 09-Jan-20 1:27 PM, Olivier Matz wrote: > > > > To populate a mempool with a virtual area, the mempool code cal

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

On 12/20/2019 12:43 PM, cnamb...@amd.com wrote: > From: Chandu Babu N > > Implements eth dev ops xstats_get, xstats_reset, xstats_get_names, > xstats_get_names_by_id, xstats_get_by_id > > Signed-off-by: Chandu Babu N +maintainer of the PMD Hi Ravi, Can you please review this patch? Thanks,

Re: [dpdk-dev] [PATCH v2 5/6] doc/guides: rebuild with meson whenever a file changes

On Thu, Jan 09, 2020 at 09:27:42AM -0500, Aaron Conole wrote: > Bruce Richardson writes: > > > Add proper support for calling sphinx whenever a file in the doc > > directory changes. This is accomplished by using a wrapper script > > for sphinx, which runs sphinx but also emits a gcc-format depen

Re: [dpdk-dev] [PATCH] vhost: use dynamic log type

Hi Stephen, On 11/12/19 10:47 PM, Stephen Hemminger wrote: > Rather than overloading USER1 and USER2 logtypes, > use a DPDK dynamic log type. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_vhost/vhost.c | 12 > lib/librte_vhost/vhost.h | 5 +++-- > 2 files changed, 15 ins

Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system

On 12/4/19 4:07 PM, Adrian Moreno wrote: > Currently there are a couple of limitations on the logging system: Most > of the logs are compiled out and both datapath and controlpath logs > share the same loglevel. > > This patch tries to help fix that situation by: > - Splitting control plane and

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

Hi Qi, > > > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director packet > > > > > > Hi Bernard: > > > > > > > -Original Message- > > > > From: Iremonger, Bernard > > > > Sent: Thursday, January 9, 2020 8:17 PM > > > > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi > > > > Z ; Dohert

Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

On 12/13/2019 1:32 PM, Michal Krawczyk wrote: > This version of the HAL allows to use the latest HW features, like > rx offsets. > > Driver was adjusted to the new version to fix the build. > > Signed-off-by: Michal Krawczyk > Signed-off-by: Maciej Bielski <...> > @@ -2080,7 +2103,7 @@ void e

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On 09-Jan-20 2:23 PM, Olivier Matz wrote: On Thu, Jan 09, 2020 at 01:52:41PM +, Burakov, Anatoly wrote: On 09-Jan-20 1:27 PM, Olivier Matz wrote: To populate a mempool with a virtual area, the mempool code calls rte_mempool_populate_iova() for each iova-contiguous area. It happens (rarely)

Re: [dpdk-dev] [PATCH v2 6/6] doc/api: reduce indentation in meson build file

Bruce Richardson writes: > When building the API docs, we can make the meson.build file easier to > read, and allow more code per line, by using subdir_done() to quit early. > > Signed-off-by: Bruce Richardson > --- Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 5/6] doc/guides: rebuild with meson whenever a file changes

Bruce Richardson writes: > Add proper support for calling sphinx whenever a file in the doc > directory changes. This is accomplished by using a wrapper script > for sphinx, which runs sphinx but also emits a gcc-format dependency > file listing all the doc files. This is used by ninja so that an

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst routines set

Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Thursday, January 9, 2020 1:10 PM > To: Ferruh Yigit ; dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; > sta...@dpdk.org; Thomas Monjalon > Subject: RE: [dpdk-stable] [PATCH] net/mlx5: fix ConnectX-4LX Tx burst > ro

Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features

On 12/13/2019 8:01 PM, Michał Krawczyk wrote: > pt., 13 gru 2019 o 17:34 Stephen Hemminger > napisał(a): >> >> On Fri, 13 Dec 2019 14:32:15 +0100 >> Michal Krawczyk wrote: >> >>> This version of the HAL allows to use the latest HW features, like >>> rx offsets. >>> >>> Driver was adjusted to the

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On Thu, Jan 09, 2020 at 01:52:41PM +, Burakov, Anatoly wrote: > On 09-Jan-20 1:27 PM, Olivier Matz wrote: > > To populate a mempool with a virtual area, the mempool code calls > > rte_mempool_populate_iova() for each iova-contiguous area. It happens > > (rarely) that this area is too small to s

Re: [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 2:09 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 4/9] net/i40e: handle ESP tunnel >

Re: [dpdk-dev] [PATCH v2 0/4] net/mlx5: remove Tx descriptor reserved field usage

Hi, Series applied on next-net-mlx, Kindest regards, Raslan Darawsheh > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, January 9, 2020 12:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH v2 0/4] net/mlx5: remove Tx descripto

Re: [dpdk-dev] [PATCH v2 4/6] doc/guides: reduce whitespace in meson build file

Bruce Richardson writes: > For building the guides, we can make the meson.build easier to read by > using the subdir_done function to quit early. > > Signed-off-by: Bruce Richardson > --- Nice. Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH v2 3/6] doc/api: fix warning with meson build

Bruce Richardson writes: > The install parameter to configure_file is new in 0.50 and generates a > warning since it is newer than our minimum version of 0.47.1. The > parameter, however, is unneeded as the documentation states: > > "When omitted it defaults to true when install_dir is set and no

Re: [dpdk-dev] [PATCH v2 2/6] build: skip processing docs folder if docs disabled

Bruce Richardson writes: > While each target is set to be ignored if the docs are disabled in the > meson build, there is little reason to process the docs folder at all. > > Signed-off-by: Bruce Richardson > --- Makes sense. Acked-by: Aaron Conole

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

On 09/01/2020 08:30, Julien Meunier wrote: > Hi, > Hi Julien, > I launched UT on my target which has a QAT VF device, binded to igb_uio. > > + TestCase [97] : test_null_auth_only_operation failed > + TestCase [99] : test_null_cipher_auth_operation failed > > When I did some debug, I saw th

Re: [dpdk-dev] [PATCH v2 1/6] kernel/linux/kni: fix meson warning about console keyword

Bruce Richardson writes: > Since kni no longer includes the ethtool code and so is faster to build, we > no longer need the console parameter to have incremental screen updates as > it builds. Therefore, we drop the keyword which removes the warning. > > Fixes: b78f32cff94d ("kni: support meson b

Re: [dpdk-dev] [PATCH 2/2] ci: use meson 0.47.1

David Marchand writes: > meson 0.53.0 has a compatibility issue [1] with the python 3.5.2 that comes > in Ubuntu 16.04. > On the other hand, the minimal version supported in dpdk is 0.47.1. > > Stick to this version to avoid getting hit by regressions in meson latest > shiny release. > > 1: https

Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

David Marchand writes: > Using version 0.47.1, meson is unable to find the math library in Travis > for the 32bits job. > Quite surprisingly, this problem is not seen with the 64bits jobs. > > Switching to 0.48.0, the problem disappears. > > But we should pass 'm' to find_library instead of 'libm

Re: [dpdk-dev] [dpdk-stable] [PATCH] mark experimental variables

02/12/2019 16:20, David Marchand: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing exported > variables. > > Fixes: a4bcd61de82d ("buildtools: add

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 10:03 PM > To: Zhang, Qi Z ; dev@dpdk.org; Xing, Beilei > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director pack

Re: [dpdk-dev] [PATCH 1/2] build: fix libm detection in meson

On Thu, Jan 9, 2020 at 2:09 PM Bruce Richardson wrote: > > On Thu, Jan 09, 2020 at 01:59:15PM +0100, David Marchand wrote: > > Using version 0.47.1, meson is unable to find the math library in Travis > > for the 32bits job. > > Quite surprisingly, this problem is not seen with the 64bits jobs. > >

Re: [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel

Hi Bernard: > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:16 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 4/9] net/i40e:

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

On 30/12/2019 08:56, Lili Deng wrote: > Hi Kevin, > > > > I'd like to sign off validation dpdk-stable-18.11.6-rc1 against Azure gallery > images. > > Version used - > https://git.dpdk.org/dpdk-stable/snapshot/dpdk-stable-18.11.6-rc1.tar.xz

Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet

Hi Qi, > -Original Message- > From: Zhang, Qi Z > Sent: Thursday, January 9, 2020 12:44 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Doherty, Declan > > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Direc

Re: [dpdk-dev] [PATCH v7 3/4] net/ixgbe: cleanup Tx buffers

Hi Chenxu, Good progress wih _full_version, but still some issues remains I think. More comments inline. Konstantin > > Signed-off-by: Chenxu Di > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 + > drivers/net/ixgbe/ixgbe_rxtx.c | 156 ++- > drivers/net/ixgbe/ixg

Re: [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows

Hi Bernard: > -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:17 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 5/9] net/i40e

Re: [dpdk-dev] [PATCH] mempool: fix slow allocation of large mempools

On 09-Jan-20 1:27 PM, Olivier Matz wrote: When allocating a mempool which is larger than the largest available area, it can take a lot of time: a- the mempool calculate the required memory size, and tries to allocate it, it fails b- then it tries to allocate the largest available area (this

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On 09-Jan-20 1:27 PM, Olivier Matz wrote: To populate a mempool with a virtual area, the mempool code calls rte_mempool_populate_iova() for each iova-contiguous area. It happens (rarely) that this area is too small to store one object. In this case, rte_mempool_populate_iova() returns an error, w

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On Thu, Jan 09, 2020 at 02:40:06PM +0100, David Marchand wrote: > On Thu, Jan 9, 2020 at 2:27 PM Olivier Matz wrote: > > > > To populate a mempool with a virtual area, the mempool code calls > > rte_mempool_populate_iova() for each iova-contiguous area. It happens > > (rarely) that this area is to

Re: [dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug

> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, January 9, 2020 8:16 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Doherty, Declan > Cc: Ananyev, Konstantin ; Byrne, Stephen1 > ; Zhang, Helin ; > Iremonger, Bernard > Subject: [PATCH v3 3/9] net/i40e: improve

Re: [dpdk-dev] 18.11.6 (LTS) patches review and test

On 26/12/2019 13:35, Ali Alnubani wrote: > Hi, > >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, December 18, 2019 1:42 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Akhil Goyal ; Ali Alnubani ; >> benjamin.wal...@intel.com; David Christensen ; >> H

Re: [dpdk-dev] [PATCH] mempool: fix mempool virt populate with small chunks

On Thu, Jan 9, 2020 at 2:27 PM Olivier Matz wrote: > > To populate a mempool with a virtual area, the mempool code calls > rte_mempool_populate_iova() for each iova-contiguous area. It happens > (rarely) that this area is too small to store one object. In this case, > rte_mempool_populate_iova() r

  1   2   >