[dpdk-dev] [PATCH] net/octeontx: fix memory leak of MAC address table

2020-01-29 Thread Sunil Kumar Kori
MAC address table is allocated during octeontx device create and same is used to maintain list of MAC address associated to port. This table is not getting freed niether in case of error nor during graceful shutdown of port. Patch fixes memory required memory for both the cases as mentioned. Fixe

[dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error

2020-01-29 Thread Vitaliy Mysak
According to recvmsg() specification, 0 is a valid return code when client is disconnecting. Therefore, it should not be reported as error, unless there are other dependencies that require message to not be empty. But there are none, since the next immediate caller of recvmsg() reports "vhost peer

[dpdk-dev] [PATCH v2 02/13] vdpa/mlx5: support queues number operation

2020-01-29 Thread Matan Azrad
Support get_queue_num operation to get the maximum number of queues supported by the device. This number comes from the DevX capabilities. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/vdpa/mlx5/mlx5_vdpa.c | 54 ++- 1 file change

[dpdk-dev] [PATCH v2 00/13] Introduce mlx5 vDPA driver

2020-01-29 Thread Matan Azrad
v2: - Reorder patches for 2 serieses - this is the seccond part of the previous series splitting. - Fix spelling and per patch complition issues. - moved to use claim_zero instead of pure asserts. Matan Azrad (13): drivers: introduce mlx5 vDPA driver vdpa/mlx5: support queues number operation

[dpdk-dev] [PATCH v2 01/13] drivers: introduce mlx5 vDPA driver

2020-01-29 Thread Matan Azrad
Add a new driver to support vDPA operations by Mellanox devices. The first Mellanox devices which support vDPA operations are ConnectX6DX and Bluefield1 HCA for their PF ports and VF ports. This driver is depending on rdma-core like the mlx5 PMD, also it is going to use mlx5 DevX to create HW obj

[dpdk-dev] [PATCH v2 03/13] vdpa/mlx5: support features get operations

2020-01-29 Thread Matan Azrad
Add support for get_features and get_protocol_features operations. Part of the features are reported by the DevX capabilities. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- doc/guides/vdpadevs/features/mlx5.ini | 7 drivers/vdpa/mlx5/mlx5_vdpa.c | 66 +

[dpdk-dev] [PATCH v2 04/13] vdpa/mlx5: prepare memory regions

2020-01-29 Thread Matan Azrad
In order to map the guest physical addresses used by the virtio device guest side to the host physical addresses used by the HW as the host side, memory regions are created. By this way, for example, the HW can translate the addresses of the packets posted by the guest and to take the packets from

[dpdk-dev] [PATCH v2 06/13] vdpa/mlx5: prepare virtio queues

2020-01-29 Thread Matan Azrad
The HW virtq object represents an emulated context for a VIRTIO_NET virtqueue which was created and managed by a VIRTIO_NET driver as defined in VIRTIO Specification. Add support to prepare and release all the basic HW resources needed the user virtqs emulation according to the rte_vhost configura

[dpdk-dev] [PATCH v2 07/13] vdpa/mlx5: support stateless offloads

2020-01-29 Thread Matan Azrad
Add support for the next features in virtq configuration: VIRTIO_F_RING_PACKED, VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_TSO6, VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, VIRTIO_F_VERSION_1, These features support depends in the DevX capabilities re

Re: [dpdk-dev] [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover

2020-01-29 Thread Ferruh Yigit
On 1/26/2020 5:25 PM, David Harton wrote: > Modified UPDATE_VF_STAT to properly handle rollover conditions. > > Fixes: d82170d27918 ("igb: add VF support") > Cc: intel.com > > Signed-off-by: David Harton > --- > drivers/net/e1000/igb_ethdev.c | 14 +- > 1 file changed, 9 insertions(

[dpdk-dev] [PATCH v2 05/13] vdpa/mlx5: prepare HW queues

2020-01-29 Thread Matan Azrad
As an arrangement to the vitrio queues creation, a 2 QPs and CQ may be created for the virtio queue. The design is to trigger an event for the guest and for the vdpa driver when a new CQE is posted by the HW after the packet transition. This patch add the basic operations to create and destroy th

[dpdk-dev] [PATCH v2 11/13] vdpa/mlx5: support live migration

2020-01-29 Thread Matan Azrad
Add support for live migration feature by the HW: Create a single Mkey that maps the memory address space of the VHOST live migration log file. Modify VIRTIO_NET_Q object and provide vhost_log_page, dirty_bitmap_mkey, dirty_bitmap_size, dirty_bitmap_a

[dpdk-dev] [PATCH v2 08/13] vdpa/mlx5: add basic steering configurations

2020-01-29 Thread Matan Azrad
Add a steering object to be managed by a new file mlx5_vdpa_steer.c. Allow promiscuous flow to scatter the device Rx packets to the virtio queues using RSS action. In order to allow correct RSS in L3 and L4, split the flow to 7 flows as required by the device. Signed-off-by: Matan Azrad Acked-b

[dpdk-dev] [PATCH v2 13/13] vdpa/mlx5: disable ROCE

2020-01-29 Thread Matan Azrad
In order to support virtio queue creation by the FW, ROCE mode should be disabled in the device. Do it by netlink which is like the devlink tool commands: 1. devlink dev param set pci/[pci] name enable_roce value false cmode driverinit 2. devlink dev reload pci/[pci] Or

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: add link speed devarg

2020-01-29 Thread Adrian Moreno
On 1/20/20 6:05 PM, Ivan Dyukov wrote: > Some applications like pktgen use link_speed to calculate > transmit rate. It limits outcome traffic to hardcoded 10G. > > This patch adds link_speed devarg which allows to configure > link_speed of virtio device. > > Signed-off-by: Ivan Dyukov > --- > d

[dpdk-dev] [PATCH v2 09/13] vdpa/mlx5: support queue state operation

2020-01-29 Thread Matan Azrad
Add support for set_vring_state operation. Using DevX API the virtq state can be changed as described in PRM: enable - move to ready state. disable - move to suspend state. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/vdpa/mlx5/mlx5_vdpa.c | 23 ++

[dpdk-dev] [PATCH v2 10/13] vdpa/mlx5: map doorbell

2020-01-29 Thread Matan Azrad
The HW supports only 4 bytes doorbell writing detection. The virtio device set only 2 bytes when it rings the doorbell. Map the virtio doorbell detected by the virtio queue kickfd to the HW VAR space when it expects to get the virtio emulation doorbell. Use the EAL interrupt mechanism to get noti

[dpdk-dev] [PATCH v2 12/13] vdpa/mlx5: support close and config operations

2020-01-29 Thread Matan Azrad
Support dev_conf and dev_conf operations. These operations allow vdpa traffic. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/vdpa/mlx5/mlx5_vdpa.c | 58 --- drivers/vdpa/mlx5/mlx5_vdpa.h | 1 + 2 files changed, 55 insertions(+), 4

Re: [dpdk-dev] [PATCH v3] net/i40e: fix i40e flow director merge

2020-01-29 Thread Sexton, Rory
> > Subject: [PATCH v3] net/i40e: fix i40e flow director merge > > Merge of ESP and L2TP code in i40e_fdir.c added checks on cus_pctype->index > which caused flow creation for ESP to fail. > > Added fill_ipv4_function() > Refactored code to have one path for customized and non customized pctype

[dpdk-dev] [PATCH] vhost/crypto: fix missed user protocol flag

2020-01-29 Thread Fan Zhang
Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: sta...@dpdk.org This patch fixes the vhost crypto missed "VHOST_USER_PROTOCOL_F_CONFIG" flag problem during initialization. Newer Qemu version requires this feature enabled. Signed-off-by: Fan Zhang --- lib/librte_vhos

Re: [dpdk-dev] [PATCH] example/vhost_crypto: fix incorrect fetch size

2020-01-29 Thread Zhang, Roy Fan
Hi Maxime, Sorry for the late reply. This patch is incorrect. I have sent the correct version http://patchwork.dpdk.org/patch/65302/ Regards, Fan > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 14, 2020 9:30 AM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: Re: [P

[dpdk-dev] [PATCH] vhost/crypto: fix incorrect fetch size

2020-01-29 Thread Fan Zhang
Coverity issue: 343401 This patch fixes the incorrect rte_vhost_crypto_fetch_requests return value. Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Cc: roy.fan.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 10 +- 1 file cha

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: update VF_STAT macros to handle rollover

2020-01-29 Thread Ferruh Yigit
On 1/26/2020 5:32 PM, David Harton wrote: > Added rollover logic to UPDATE_VF_STAT and UPDATE_VF_STAT_36BIT macros. > > Fixes: af75078fece3 ("first public release") > Cc: intel.com > > Signed-off-by: David Harton > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 12 ++-- > 1 file changed, 10 i

[dpdk-dev] [PATCH v2 1/2] net/mlx5: add fine grain dynamic flag support

2020-01-29 Thread Viacheslav Ovsiienko
From: Ori Kam The inline feature is designed to save PCI bandwidth by copying some of the data to the wqe. This feature if enabled works for all packets. In some cases when using external memory, the PCI bandwidth is not relevant since the memory can be accessed by other means. This commit intr

[dpdk-dev] [PATCH v2 2/2] net/mlx5: update Tx datapath to support no inline hint

2020-01-29 Thread Viacheslav Ovsiienko
This patch adds support for dynamic flag that hints transmit datapath do not copy data to the descriptors. This flag is useful when data are located in the memory of another (not NIC) physical device and copying to the host memory is undesirable. This hint flag is per mbuf for multi-segment packet

[dpdk-dev] [PATCH v2 0/2] mlx5/net: hint PMD not to inline packet

2020-01-29 Thread Viacheslav Ovsiienko
Some PMDs inline the mbuf data buffer directly to device transmit descriptor. This is in order to save the overhead of the PCI headers imposed when the device DMA reads the data by buffer pointer. For some devices it is essential in order to provide the full bandwidth. However, there are cases whe

Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix user supplied index in MAC address add

2020-01-29 Thread Harman Kalra
On Wed, Jan 29, 2020 at 12:12:42PM +0530, Sunil Kumar Kori wrote: > Earlier after a successful mac_addr_add operation, index was returned > by underlying layer which was unused but same as provided by DPDK API. > > So API is enhanced to use application provided index location to add > MAC address

Re: [dpdk-dev] [PATCH] net/octeontx: fix memory leak of MAC address table

2020-01-29 Thread Harman Kalra
On Wed, Jan 29, 2020 at 02:47:04PM +0530, Sunil Kumar Kori wrote: > MAC address table is allocated during octeontx device create and > same is used to maintain list of MAC address associated to port. > This table is not getting freed niether in case of error nor during > graceful shutdown of port.

[dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
Duplicated the existing symbol and versioned one as experimental and other as stable. Created VERSION_SYMBOL_EXPERIMENTAL helper macro. Updated the 'check-experimental-syms.sh' buildtool, which was complaining that the symbol is in EXPERIMENTAL tag in .map file but it is not in the .experimental

[dpdk-dev] app/test: unit test problem with testing mbuf in forked child process

2020-01-29 Thread Slava Ovsiienko
While working on the unit test for the mbuf with pinned external buffers I found that: app/test/test_mbuf.c: - test_failing_mbuf_sanity_check() - verify_mbuf_check_panics(buf) - fork() - child process() Does not work (either over regular mbufs, not pinned ones) in correct way. The mbu

Re: [dpdk-dev] [PATCH v3 9/9] net/bnxt: fix coverity warnings

2020-01-29 Thread Ferruh Yigit
On 1/28/2020 9:01 PM, Ajit Khaparde wrote: > From: Kalesh AP > > return value stored in "ret" but it has been overwritten before use. > > CID 353621: Code maintainability issues (UNUSED_VALUE) > Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") > Fixes: df6cd7c1f73a ("net/bnxt: h

[dpdk-dev] [PATCH v4 00/25] Introduce mlx5 common library

2020-01-29 Thread Matan Azrad
Steps: - Prepare net/mlx5 for code sharing. - Introduce new common lib for mlx5 devices. - Share code from net/mlx5 to common/mlx5. v2: - Reorder patches for 2 serieses - this is the first one for common directory and vDPA preparation, the second will be sent later for vDPA new driver part. - F

[dpdk-dev] [PATCH v4 05/25] common/mlx5: share mlx5 devices information

2020-01-29 Thread Matan Azrad
Move the vendor information, vendor ID and device IDs from net/mlx5 PMD to the common mlx5 file. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_common.h | 21 + drivers/net/mlx5/mlx5.h | 21 - drivers/net/

[dpdk-dev] [PATCH v4 04/25] common/mlx5: share mlx5 PCI device detection

2020-01-29 Thread Matan Azrad
Move PCI detection by IB device from mlx5 PMD to the common code. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_commo

[dpdk-dev] [PATCH v4 01/25] net/mlx5: separate DevX commands interface

2020-01-29 Thread Matan Azrad
The DevX commands interface is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the DevX commands shared with different PMDs, this patch moves the DevX interface to a new file called mlx5_devx_cmds.h. Also remove shared device structure dependency on DevX

[dpdk-dev] [PATCH v4 06/25] common/mlx5: share CQ entry check

2020-01-29 Thread Matan Azrad
The CQE has owner bit to indicate if it is in SW control or HW. Share a CQE check for all the mlx5 drivers. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_common.h | 41 +++ drivers/net/mlx5/mlx5_rxtx.h | 39 +

[dpdk-dev] [PATCH v4 03/25] common/mlx5: share the mlx5 glue reference

2020-01-29 Thread Matan Azrad
A new Mellanox vdpa PMD will be added to support vdpa operations by Mellanox adapters. Both, the mlx5 PMD and the vdpa mlx5 PMD should initialize the glue. The glue initialization should be only one per process, so all the mlx5 PMDs using the glue should share the same glue object. Move the glue

[dpdk-dev] [PATCH v4 07/25] common/mlx5: add query vDPA DevX capabilities

2020-01-29 Thread Matan Azrad
Add the DevX capabilities for vDPA configuration and information of Mellanox devices. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 90 drivers/common/mlx5/mlx5_devx_cmds.h | 24 ++ drivers/commo

[dpdk-dev] [PATCH v4 08/25] common/mlx5: glue null memory region allocation

2020-01-29 Thread Matan Azrad
Add support for rdma-core API to allocate NULL MR. When the device HW get a NULL MR address, it will do nothing with the address, no read and no write. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_glue.c | 13 + drivers/common/mlx5/mlx5_glu

[dpdk-dev] [PATCH v4 11/25] common/mlx5: glue event interrupt commands

2020-01-29 Thread Matan Azrad
Add the next commands to glue in order to support interrupt event channel operations associated to events in the EQ: devx_create_event_channel, devx_destroy_event_channel, devx_subscribe_devx_event, devx_subscribe_devx_event_fd, devx_get_event. Signed-off-by

[dpdk-dev] [PATCH v4 09/25] common/mlx5: support DevX indirect mkey creation

2020-01-29 Thread Matan Azrad
Add option to create an indirect mkey by the current mlx5_devx_cmd_mkey_create command. Indirect mkey points to set of direct mkeys. By this way, the HW\SW can reference fragmented memory by one object. Align the net/mlx5 driver usage in the above command. Signed-off-by: Matan Azrad Acked-by: V

[dpdk-dev] [PATCH v4 13/25] common/mlx5: add DevX command to create CQ

2020-01-29 Thread Matan Azrad
HW implements completion queues(CQ) used to post completion reports upon completion of work request. Used for Rx and Tx datapath. Add DevX command to create a CQ. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 57 +++

[dpdk-dev] [PATCH v4 10/25] common/mlx5: glue event queue query

2020-01-29 Thread Matan Azrad
The event queue is managed only by the kernel. Add the rdma-core command in glue to query the kernel event queue details. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_glue.c | 15 +++ drivers/common/mlx5/mlx5_glue.h | 2 ++ 2 files changed

[dpdk-dev] [PATCH v4 17/25] common/mlx5: allow type configuration for DevX RQT

2020-01-29 Thread Matan Azrad
Allow virtio queue type configuration in the RQ table. The needed fields and configuration was added. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 5 ++

[dpdk-dev] [PATCH v4 12/25] common/mlx5: glue UAR allocation

2020-01-29 Thread Matan Azrad
The isolated, protected and independent direct access to the HW by multiple processes is implemented via User Access Region (UAR) mechanism. The UAR is part of PCI address space that is mapped for direct access to the HW from the CPU. UAR is comprised of multiple pages, each page containing registe

[dpdk-dev] [PATCH v4 19/25] common/mlx5: add DevX command to modify RQT

2020-01-29 Thread Matan Azrad
RQ table can be changed to support different list of queues. Add DevX command to modify DevX RQT object to point on new RQ list. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 47 + drivers/common/mlx5/mlx

[dpdk-dev] [PATCH v4 15/25] common/mlx5: add DevX virtq commands

2020-01-29 Thread Matan Azrad
Virtio emulation offload allows SW to offload the I/O operations of a virtio virtqueue, using the device, allowing an improved performance for its users. While supplying all the relevant Virtqueue information (type, size, memory location, doorbell information, etc.). The device can then offload the

[dpdk-dev] [PATCH v4 14/25] common/mlx5: glue VAR allocation

2020-01-29 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/m

[dpdk-dev] [PATCH v4 16/25] common/mlx5: add support for DevX QP operations

2020-01-29 Thread Matan Azrad
QP creation is needed for vDPA virtq support. Add 2 DevX commands to create QP and to modify QP state. The support is for RC QP only in force loopback address mode. By this way, the packets can be sent to other inernal destinations in the nic. For example: other QPs or virtqs. Signed-off-by: Ma

[dpdk-dev] [PATCH v4 18/25] common/mlx5: add TIR field constants

2020-01-29 Thread Matan Azrad
The DevX TIR object configuration should get L3 and L4 protocols expected to be forwarded by the TIR. Add the PRM constant values needed to configure the L3 and L4 protocols. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_prm.h | 10 ++ 1 file ch

[dpdk-dev] [PATCH v4 20/25] common/mlx5: get DevX capability for max RQT size

2020-01-29 Thread Matan Azrad
In order to allow RQT size configuration which is limited to the correct maximum value, add log_max_rqt_size for DevX capability structure. Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + 2 fi

[dpdk-dev] [PATCH v4 22/25] net/mlx5: separate Netlink command interface

2020-01-29 Thread Matan Azrad
The Netlink commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the Netlink commands shared with different PMDs, this patch moves the Netlink interface to a new file called mlx5_nl.h. Move non Netlink pure vlan commands from mlx5_nl.c t

[dpdk-dev] [PATCH v4 21/25] net/mlx5: select driver by class device argument

2020-01-29 Thread Matan Azrad
There might be a case that one Mellanox device can be probed by multiple mlx5 drivers. One case is that any mlx5 vDPA device can be probed by bothe net/mlx5 and vdpa/mlx5. Add a new mlx5 common API to get the requested driver by devargs: class=[net/vdpa]. Skip net/mlx5 PMD probing while the devi

[dpdk-dev] [PATCH v4 25/25] common/mlx5: support ROCE disable through Netlink

2020-01-29 Thread Matan Azrad
Add new 4 Netlink commands to support enable/disable ROCE: 1. mlx5_nl_devlink_family_id_get to get the Devlink family ID of Netlink general command. 2. mlx5_nl_enable_roce_get to get the ROCE current status. 3. mlx5_nl_driver_reload - to reload the device kernel d

[dpdk-dev] [PATCH v4 24/25] common/mlx5: share Netlink commands

2020-01-29 Thread Matan Azrad
Move Netlink mechanism and its dependencies from net/mlx5 to common/mlx5 in order to be ready to use by other mlx5 drivers. The dependencies are BITFIELD defines, the ppc64 compilation workaround for bool type and the function mlx5_translate_port_name. Update build mechanism accordingly. Signed-

[dpdk-dev] [PATCH v4 23/25] net/mlx5: reduce Netlink commands dependencies

2020-01-29 Thread Matan Azrad
As an arrangment for Netlink command moving to the common library, reduce the net/mlx5 dependencies. Replace ethdev class command parameters. Improve Netlink sequence number mechanism to be controlled by the mlx5 Netlink mechanism. Move mlx5_nl_check_switch_info to mlx5_nl.c since it is the only

[dpdk-dev] [PATCH 2/2] 6.10 png replaced with svg

2020-01-29 Thread prateekag
From: prateekagarwal88 --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 52346 -> 0 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 791 ++ 2 files changed, 791 insertions(+) delete mode 100644 doc/guides/prog_guide/img/ring-mp-enqueue3.png create mode 100644 doc/g

[dpdk-dev] [PATCH 1/2] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-29 Thread prateekag
From: PRATEEK AGARWAL --- .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- doc/guides/prog_guide/rcu_lib.rst | 2 +- 3 files changed, 1 insertion(+), 786 deletions(-) create mode 100644 do

Re: [dpdk-dev] ACL priority field

2020-01-29 Thread Ananyev, Konstantin
Hi, > > Hello, > > Can someone clarify what I am interpreting as a documentation conflict > regarding the "priority" field for rte_table_acl_rule_add_params? > Below documentation says "highest priority wins", but the header file comment > says 0 is highest priority. Based on my testing with

[dpdk-dev] [PATCH v5 3/6] examples/ipsec-secgw: integrate inbound SAD

2020-01-29 Thread Vladimir Medvedkin
Integrate ipsec SAD support into secgw app: 1. Use SAD library for inbound SA lookup 2. Changes in struct sa_ctx: - sa array allocates dynamically depending on number of configured sa - All SA's are kept one by one without using SPI2IDX 3. SP's userdata now contain index of SA in sa_ctx instea

[dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw

2020-01-29 Thread Vladimir Medvedkin
This series integrates SA database (SAD) capabilities from ipsec library. The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. Also patch series removes hardcoded limitation for maximum number of SA's and SP's. According to our measurements, after this series of patches, ipsec-secgw

[dpdk-dev] [PATCH v5 1/6] ipsec: move ipsec sad name length into .h

2020-01-29 Thread Vladimir Medvedkin
Move IPSEC_SAD_NAMESIZE into public header and rename it to RTE_IPSEC_SAD_NAMESIZE Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/librte_ipsec/ipsec_sad.c | 20 ++-- lib/librte_ipsec/rte_ipsec_sad.h | 2 ++ 2 files changed, 12 insertions(+), 10 delet

[dpdk-dev] [PATCH v5 2/6] examples/ipsec-secgw: implement inbound SAD

2020-01-29 Thread Vladimir Medvedkin
Add initial support for librte_ipsec SAD library Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/ipsec.h | 7 +++ examples/ipsec-secgw/sad.c | 109 +++ examples/ipsec-secgw/sad.h | 75

[dpdk-dev] [PATCH v5 4/6] examples/ipsec-secgw: get rid of maximum sa limitation

2020-01-29 Thread Vladimir Medvedkin
Get rid of maximum SA limitation. Keep parsed SA's into the sorted by SPI value array. Use binary search in the sorted SA array to find appropriate SA for a given SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/ipsec.h | 1 - examples/ipsec-secgw/p

[dpdk-dev] [PATCH v5 5/6] examples/ipsec-secgw: get rid of maximum sp limitation

2020-01-29 Thread Vladimir Medvedkin
Get rid of maximum SP limitation. Keep parsed SP's into the sorted by SPI value array. Use binary search in the sorted SP array to find appropriate SP for a given SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/parser.c | 2 + examples/ipsec-secgw/p

[dpdk-dev] [PATCH v5 6/6] examples/ipsec-secgw: add SAD cache

2020-01-29 Thread Vladimir Medvedkin
Introduce SAD cache. Stores the most recent SA in a per lcore cache. Cache represents flat array containing SA's indexed by SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/ipsec-secgw.c | 30 +- examples/ipsec-secgw/ipsec.h | 1 + ex

Re: [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet

2020-01-29 Thread Jerin Jacob
On Wed, Jan 29, 2020 at 7:13 AM Rasesh Mody wrote: > > For VLAN packet the tci is saved in rx_mb->vlan_tci, however the > STRIPPED offload flag is not set along with PKT_RX_VLAN flag. > Set the PKT_RX_VLAN_STRIPPED flag as well. > > Fixes: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") > Fixe

Re: [dpdk-dev] [PATCH] ring: fix namespace prefix of inline functions

2020-01-29 Thread Olivier Matz
On Thu, Jan 23, 2020 at 09:30:22AM +0100, Thomas Monjalon wrote: > When adding custom element size feature, some internal inline functions > were added in a public header without rte_ prefix. > It is fixed by adding __rte_ring_. > > Fixes: cc4b218790f6 ("ring: support configurable element size") >

Re: [dpdk-dev] [PATCH v2 12/12] examples/ipsec-secgw: add cmd line option for bufs

2020-01-29 Thread Ananyev, Konstantin
> > From: Lukasz Bartosik > > Add command line option -s which can be used to configure number > of buffers in a pool. Default number of buffers is 8192. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > examples/ipsec-secgw/ipsec-secgw.c | 23 +++

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Bruce Richardson
On Wed, Jan 29, 2020 at 12:29:53PM +, Ferruh Yigit wrote: > Duplicated the existing symbol and versioned one as experimental and > other as stable. > > Created VERSION_SYMBOL_EXPERIMENTAL helper macro. > > Updated the 'check-experimental-syms.sh' buildtool, which was > complaining that the sy

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 1:29 PM, Ferruh Yigit wrote: [...] > Updated meson build system to allow the versioning, > 'use_function_versioning = true', not sure why it was disabled by > default. AFAIR this is to save build time with meson. By default static build is made and from the objects from the static buil

Re: [dpdk-dev] [PATCH v2 2/4] buildtools: get static mlx dependencies for meson

2020-01-29 Thread Bruce Richardson
On Mon, Jan 27, 2020 at 04:44:00PM +0100, Thomas Monjalon wrote: > The shell script options-ibverbs-static.sh was used with make > in forcing static linkage of ibverbs libraries. > > When choosing to link with a static dependency in meson, > the generated .pc file will not force such static linkag

Re: [dpdk-dev] [PATCH v2 11/12] examples/ipsec-secgw: add app mode worker

2020-01-29 Thread Ananyev, Konstantin
> Add application inbound/outbound worker thread and > IPsec application processing code for event mode. > > Exampple ipsec-secgw command in app mode: > ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=128 > -w 0002:03:00.0,ipsec_in_max_spi=128 -w 0002:0e:00.0 -w 0002:10:00.1 > --log-level=8 -c 0x1 --

[dpdk-dev] [PATCH v2] devtools: add new SPDX license compliance checker

2020-01-29 Thread Stephen Hemminger
Simple script to look for drivers and scripts that are missing requires SPDX header. Signed-off-by: Stephen Hemminger --- devtools/spdx-check.sh | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 devtools/spdx-check.sh diff --git a/devtools/spdx-check.sh b/devtoo

[dpdk-dev] [PATCH] build: remove function versioning from meson files

2020-01-29 Thread Andrzej Ostruszka
Timer, LPM and Distributor libraries no longer use function versioning and therefore do not need separate build for static and shared version of libraries. This patch removes use_function_versioning from their meson build files. Signed-off-by: Andrzej Ostruszka Fixes: f2fb215843a9 ("timer: remov

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: > On 1/29/20 1:29 PM, Ferruh Yigit wrote: > [...] >> Updated meson build system to allow the versioning, >> 'use_function_versioning = true', not sure why it was disabled by >> default. > > AFAIR this is to save build time with meson. By default stat

Re: [dpdk-dev] ACL priority field

2020-01-29 Thread Bly, Mike
Konstantin, Ah, I see now. Yes, we are using rte_table_acl. Is there a reason these two differ in precedence selection? Regards, Mike Hi, > > Hello, > > Can someone clarify what I am interpreting as a documentation conflict > regarding the "priority" field

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 5:25 PM, Ferruh Yigit wrote: > On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: [...] >> I've now noticed that LPM, Distributor and Timer libraries no longer use >> function versioning but have it still set in their meson.build. > > Right, I can remove them. Bruce was kind enough to give

Re: [dpdk-dev] [PATCH] build: remove function versioning from meson files

2020-01-29 Thread Richardson, Bruce
> -Original Message- > From: Andrzej Ostruszka > Sent: Wednesday, January 29, 2020 4:24 PM > To: dev@dpdk.org; Hunt, David ; Richardson, Bruce > ; Medvedkin, Vladimir > ; Robert Sanford ; > Carrillo, Erik G > Cc: Baran, MarcinX > Subject: [PATCH] build: remove function versioning from

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 4:30 PM, Andrzej Ostruszka wrote: > On 1/29/20 5:25 PM, Ferruh Yigit wrote: >> On 1/29/2020 2:57 PM, Andrzej Ostruszka wrote: > [...] >>> I've now noticed that LPM, Distributor and Timer libraries no longer use >>> function versioning but have it still set in their meson.build. >> >> R

[dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
Duplicated the existing symbol and versioned one as experimental and other as stable. Created VERSION_SYMBOL_EXPERIMENTAL helper macro. Updated the 'check-experimental-syms.sh' buildtool, which was complaining that the symbol is in EXPERIMENTAL tag in .map file but it is not in the .experimental

Re: [dpdk-dev] [PATCH 1/2] Documentation errata:RCU_lib.rst and Ring fig 6.10 corrected

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 2:31 AM, pratee...@cse.iitb.ac.in wrote: > From: PRATEEK AGARWAL > > --- > .../prog_guide/img/ring-mp-enqueue3.png | Bin 0 -> 52346 bytes > .../prog_guide/img/ring-mp-enqueue3.svg | 785 -- > doc/guides/prog_guide/rcu_lib.rst | 2 +- > 3 fi

Re: [dpdk-dev] [PATCH v2 12/12] examples/ipsec-secgw: add cmd line option for bufs

2020-01-29 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 29, 2020 8:11 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju

Re: [dpdk-dev] [PATCH v2 11/12] examples/ipsec-secgw: add app mode worker

2020-01-29 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 29, 2020 9:05 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu ; Thomas Monjalon > > Cc: Lukas Bartosik ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju

[dpdk-dev] [PATCH] net/octeontx2: configure RSS adder as tag lsb bits

2020-01-29 Thread jerinj
From: Jerin Jacob Before C0 HW revision, The RSS adder was computed based the following static formula. rss_adder<7:0> = flow_tag<7:0> ^ flow_tag<15:8> ^ flow_tag<23:16> ^ flow_tag<31:24> The above scheme has the following drawbacks: 1) It is not in line with other standard NIC behavior. 2) The

[dpdk-dev] [PATCH v2 1/4] hash: fix meson headers packaging

2020-01-29 Thread David Marchand
Those headers are internal and should not be distributed. Fixes: 5b9656b157d3 ("lib: build with meson") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/librte_hash/meson.build | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/librte_hash/meson.build b/lib/lib

[dpdk-dev] [PATCH v2 2/4] build: split build helper

2020-01-29 Thread David Marchand
No functional change intended, prepare for reusing this code. The config and compilation parts are separated in helpers. Unsetting CC is moved to the caller of the helper. Signed-off-by: David Marchand --- devtools/test-meson-builds.sh | 46 --- 1 file changed, 32

[dpdk-dev] [PATCH v2 0/4] add ABI checks

2020-01-29 Thread David Marchand
Here is the current state of the ABI checks. libabigail has some issues when mixing dump and so files compiled with clang [1], so for now, all checks are done on dumps only. libabigail 1.0-rc3 in Xenial reported issues that disappear with the version 1.2 in Bionic. To avoid getting warnings on in

[dpdk-dev] [PATCH v2 3/4] build: test meson installation

2020-01-29 Thread David Marchand
Let's test installing with meson as part of Travis and the devtools/test-meson-builds.sh script. The resulting headers and binaries make more sense to run checks against, since they should be the same as what the final users get. In this patch, test-null.sh is now called on an installed testpmd. F

[dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-29 Thread David Marchand
For normal developers, those checks are disabled. Enabling them requires a configuration that will trigger the ABI dumps generation as part of the existing devtools/test-build.sh and devtools/test-meson-builds.sh scripts. Those checks are enabled in the CI for the default meson options on x86 and

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-29 Thread Thomas Monjalon
Anoob, Akhil, Please we need to revert or fix the ABI breakages in cryptodev very soon. The FIXME section below must be empty. Thanks 29/01/2020 18:26, David Marchand: > We currently have issues reported for librte_crypto recent changes for > which suppression rules have been added too. [..] > -

Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-29 Thread David Marchand
On Tue, Jan 28, 2020 at 6:35 PM Ferruh Yigit wrote: > On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote: > > In current version, there is a function which parses > > the corelist based on user value. A new generic > > function eal_parse_optionlist is added which will > > parse corelist as well

Re: [dpdk-dev] [PATCH v2 2/4] buildtools: get static mlx dependencies for meson

2020-01-29 Thread Thomas Monjalon
29/01/2020 16:37, Bruce Richardson: > Error message I got is below. This is on Ubuntu 19.10 with gcc 9.2: > > LD librte_pmd_mlx5.so.20.0.1 > /usr/bin/ld: /lib/x86_64-linux-gnu/libmlx5.a(mlx5.c.o): relocation > R_X86_64_PC32 against symbol `stderr@@GL I think -fPIC is missing. Which version of

Re: [dpdk-dev] [PATCH v2 2/4] buildtools: get static mlx dependencies for meson

2020-01-29 Thread Bruce Richardson
On Wed, Jan 29, 2020 at 03:37:51PM +, Bruce Richardson wrote: > On Mon, Jan 27, 2020 at 04:44:00PM +0100, Thomas Monjalon wrote: > > The shell script options-ibverbs-static.sh was used with make > > in forcing static linkage of ibverbs libraries. > > > > When choosing to link with a static dep

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 5:43 PM, Ferruh Yigit wrote: [...] > diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c > index da01429a8..5244537fa 100644 > --- a/lib/librte_meter/rte_meter.c > +++ b/lib/librte_meter/rte_meter.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include

Re: [dpdk-dev] [PATCH v2 2/4] buildtools: get static mlx dependencies for meson

2020-01-29 Thread Bruce Richardson
On Wed, Jan 29, 2020 at 06:48:14PM +0100, Thomas Monjalon wrote: > 29/01/2020 16:37, Bruce Richardson: > > Error message I got is below. This is on Ubuntu 19.10 with gcc 9.2: > > > > LD librte_pmd_mlx5.so.20.0.1 > > /usr/bin/ld: /lib/x86_64-linux-gnu/libmlx5.a(mlx5.c.o): relocation > > R_X86_64

Re: [dpdk-dev] [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover

2020-01-29 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 29, 2020 5:10 AM > To: David Harton (dharton) ; dev@dpdk.org > Cc: wenzhuo...@intel.com; konstantin.anan...@intel.com; > xiaolong...@intel.com; intel@cisco.com > Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: update U

Re: [dpdk-dev] [PATCH v2] net/ixgbevf: update VF_STAT macros to handle rollover

2020-01-29 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 29, 2020 6:23 AM > To: David Harton (dharton) ; dev@dpdk.org > Cc: wenzhuo...@intel.com; konstantin.anan...@intel.com; > xiaolong...@intel.com; intel@cisco.com > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbevf: updat

Re: [dpdk-dev] DPDK Windows Build

2020-01-29 Thread Jeremy Plsek
Hi Dmitry, There is a bug in Meson: '/OPT:REF' must be prefixed with '-Wl,' when using Clang with link.exe, because Clang does not recognize '/OPT:REF' as an argument to pass to linker, but treats it as a filename instead. A patch is not under review: https://github.com/mesonbuild/meson/pull/648

Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-29 Thread Ferruh Yigit
On 1/29/2020 5:44 PM, David Marchand wrote: > On Tue, Jan 28, 2020 at 6:35 PM Ferruh Yigit wrote: >> On 1/27/2020 10:30 AM, Hariprasad Govindharajan wrote: >>> In current version, there is a function which parses >>> the corelist based on user value. A new generic >>> function eal_parse_optionlist

  1   2   >