Re: [dpdk-dev] [PATCH v3] doc: add inline protocol in feature list

2020-02-17 Thread Akhil Goyal
> > Update feature list to include inline protocol offload. > > Signed-off-by: Anoob Joseph > --- > v3 > * Added inline protocol in octeontx2_vf.ini > > v2 > * Reworded doc following suggestions from Akhil > > doc/guides/nics/features.rst | 27 ++- > doc

Re: [dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-17 Thread James Huang
No. We didn't see noticable throughput difference in our test. On Mon., Feb. 17, 2020, 11:04 p.m. Victor Huertas wrote: > Thanks James for your quick answer. > I guess that this configuration modification implies that the packets must > be written one by one in the sw ring. Did you notice loose

Re: [dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-17 Thread Victor Huertas
Thanks James for your quick answer. I guess that this configuration modification implies that the packets must be written one by one in the sw ring. Did you notice loose of performance (in throughput) in your aplicación because of that? Regards El mar., 18 feb. 2020 0:10, James Huang escribió:

[dpdk-dev] [PATCH V1] doc: add testbed Intel platforms with Intel NICs

2020-02-17 Thread Chen, Zhaoyan
From: "Chen,Bo" Add tested Intel platforms with Intel NICs to v20.02 release note. Signed-off-by: Chen,Bo --- doc/guides/rel_notes/release_20_02.rst | 106 + 1 file changed, 106 insertions(+) diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/r

[dpdk-dev] [PATCH V1] doc: Update i40e driver/firmware version mapping table

2020-02-17 Thread Chen, Zhaoyan
Update driver/firmware version mapping table for new driver/firmware supported in 20.02 release Signed-off-by: Chen, Zhaoyan --- doc/guides/nics/i40e.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index 5d7ebb4ab..cc8724a19 100644

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-17 Thread Stephen Hemminger
On Mon, 17 Feb 2020 15:38:05 + Ferruh Yigit wrote: > For the ABI compatibility it is better to hide internal data structures > from the application as much as possible. But because of some inline > functions 'struct eth_dev_ops' can't be hidden completely. > > Plan is to split the 'struct et

Re: [dpdk-dev] [PATCH] net/i40e: fix multiple interrupt for VF

2020-02-17 Thread Zhang, Qi Z
> -Original Message- > From: Wang, ShougangX > Sent: Monday, February 17, 2020 11:10 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Wang, ShougangX > Subject: [PATCH] net/i40e: fix multiple interrupt for VF > > Interrupt mapping should be 1:n queue(s).This patch fixes the

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-17 Thread Jerin Jacob
On Thu, Feb 13, 2020 at 5:14 PM Doherty, Declan wrote: > > On 06/02/2020 5:13 PM, Jerin Jacob wrote: > > On Thu, Feb 6, 2020 at 10:01 PM Coyle, David wrote: > > > > Hi David, > > > >>> > >>> > >> - XGS-PON MAC: Crypto-CRC-BIP > >> - Order: > >> - Downstream:

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-17 Thread Jerin Jacob
On Thu, Feb 13, 2020 at 5:20 PM Doherty, Declan wrote: > > On 07/02/2020 2:18 PM, Jerin Jacob wrote: > > On Fri, Feb 7, 2020 at 6:08 PM Coyle, David wrote: > >> > >> Hi Jerin, see below > > > > Hi David, > > > >>> > >>> On Thu, Feb 6, 2020 at 10:01 PM Coyle, David > >>> wrote: > >>> > > > >>> >

Re: [dpdk-dev] [RFC] Accelerator API to chain packet processing functions

2020-02-17 Thread Jerin Jacob
On Thu, Feb 13, 2020 at 5:01 PM Doherty, Declan wrote: > > On 06/02/2020 10:54 AM, Jerin Jacob wrote: > > On Thu, Feb 6, 2020 at 3:35 PM Coyle, David wrote: > >> > >> Hi Jerin, > > > > Hi David, > > > >> Thanks for the comments. Please see replies below. > >> > >> Kind Regards, > >> David > >> >

Re: [dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-17 Thread Jerin Jacob
On Mon, Feb 17, 2020 at 9:08 PM Ferruh Yigit wrote: > > For the ABI compatibility it is better to hide internal data structures > from the application as much as possible. But because of some inline > functions 'struct eth_dev_ops' can't be hidden completely. > > Plan is to split the 'struct eth_d

[dpdk-dev] [PATCH v4] net/ixgbe: fix flow ctrl mode setting

2020-02-17 Thread Guinan Sun
When the port starts, the hw register is reset first, and then the required parameters are set again. If the parameters to be used are not set after resetting the register, a read register error will occur. This patch is used to fix the problem. Fixes: af75078fece3 ("first public release") Cc: sta

[dpdk-dev] [PATCH v3 3/7] eal/windows: support builing with MinGW-w64

2020-02-17 Thread Dmitry Kozlyuk
Disable bundled getopt implementation and GNU extensions shim when building in GNU environment. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/meson.build | 3 +++ lib/librte_eal/windows/eal/eal.c| 6 -- lib/librte_eal/windows/eal/include/getopt.h | 4 lib

[dpdk-dev] [PATCH v3 6/7] doc: guide for Windows build using MinGW-w64

2020-02-17 Thread Dmitry Kozlyuk
Instructions for different toolchains presented as options on the corresponging steps of the guide, so that common parts may be reused. Signed-off-by: Dmitry Kozlyuk --- doc/guides/windows_gsg/build_dpdk.rst | 63 +++ 1 file changed, 54 insertions(+), 9 deletions(-) diff

[dpdk-dev] [PATCH v3 7/7] build: fix linker warnings with Clang on Windows

2020-02-17 Thread Dmitry Kozlyuk
Clang on Windows doesn't use pthread for now, while MinGW does. Removing `-pthread` option with MS linker fixes the following warning: clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument] Option `--no-as-needed` is meaningless for PE output. Disabli

[dpdk-dev] [PATCH v3 5/7] build: add cross-file for MinGW-w64

2020-02-17 Thread Dmitry Kozlyuk
Add Meson configuration to cross-compile for Windows using MinGW-w64. It may require adjustments in some cases, but at least it provides the foundation. Signed-off-by: Dmitry Kozlyuk --- config/x86/meson_mingw.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 config/x

[dpdk-dev] [PATCH v3 4/7] build: MinGW-w64 support for Meson

2020-02-17 Thread Dmitry Kozlyuk
MinGW-w64 linker does not mimic MS linker options, so the build system must differentiate between linkers on Windows. Use GNU linker options with GCC and MS linker options with Clang. MinGW-w64 by default uses MSVCRT stdio, which does not comply to ANSI, most notably its formatting and string hand

[dpdk-dev] [PATCH v3 1/7] eal: introduce portable format attribute

2020-02-17 Thread Dmitry Kozlyuk
When using __attribute__((format(...)) on functions, GCC on Windows assumes MS-specific format string by default, even if the underlying stdio implementation is ANSI-compliant (either MS Unicersal CRT or MinGW implementation). Wrap attribute into a macro that forces GNU-specific format string when

[dpdk-dev] [PATCH v3 0/7] MinGW-w64 support

2020-02-17 Thread Dmitry Kozlyuk
This patch series add support for building DPDK using MinGW-w64. MinGW-w64 provides GNU toolchain and independent platform SDK on Windows. It also supports cross-compilation to Windows from POSIX systems by providing cross tollchains and libraries [0]. It does NOT emulate a full POSIX environment,

[dpdk-dev] [PATCH v3 2/7] eal/windows: use lowercase filenames for system headers

2020-02-17 Thread Dmitry Kozlyuk
Mixed case in Windows header names causes errors when cross-compiling from Linux with case-sensitive filesystem using MinGW, because MinGW distribution provides all platform SDK headers in lowercase. The change does not affect Windows native builds on case-insensitive filesystems (NTFS default). R

[dpdk-dev] [PATCH v2] eal/windows: fix out-of-memory check

2020-02-17 Thread Dmitry Kozlyuk
Check vsnprintf() result to prevent calling malloc() with negative size. Check actual malloc() result and terminate asprintf() with documented error code to prevent the use of NULL pointer. Fixes: e8428a9d8 ("eal/windows: add some basic functions and macros") Signed-off-by: Dmitry Kozlyuk --- l

[dpdk-dev] [PATCH] build: fix soname for experimental libraries

2020-02-17 Thread Thomas Monjalon
Because of an original mistake in ABI numbering, and a temporary workaround for ABI 20, for experimental libs, numbering would lead to consider ABI 20.1 > ABI 21.0 Before this patch: DPDK 19.11: ABI version 0.200 and soname 0.20 DPDK 20.02: ABI version 0.2001 and soname 0.201 Numbers are

[dpdk-dev] ABI version of experimental libraries

2020-02-17 Thread Thomas Monjalon
Hi, I would like to remind everybody our mistake when defining ABI versions. It has been "fixed" in this commit: http://git.dpdk.org/dpdk/commit/?id=f26c2b39 Please let's think about the consequence for the experimental libraries. In DPDK 19.11, we use the ABI version 0.200 with soname 0

Re: [dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-17 Thread James Huang
Yes, I experienced similar issue in my application. In a short answer, set the swqs write burst value to 1 may reduce the latency significantly. The default write burst value is 32. On Mon., Feb. 17, 2020, 8:41 a.m. Victor Huertas wrote: > Hi all, > > I am developing my own DPDK application basi

[dpdk-dev] [PATCH v2 2/2] ci: enable more drivers in Travis builds

2020-02-17 Thread Thomas Monjalon
The Travis compilation is missing some dependencies to build these PMDs: - af_xdp (libbpf) - ipn3ke (libfdt) - mlx (libibverbs) Note: libbpf is not yet available on Ubuntu. Signed-off-by: Thomas Monjalon Acked-by: Aaron Conole --- .travis.yml | 2 +- 1 file changed, 1 i

[dpdk-dev] [PATCH v2 0/2] improve Travis coverage

2020-02-17 Thread Thomas Monjalon
Remove some useless jobs and add more packages to build more PMDs in Travis. v2: remove libbpf because not available Thomas Monjalon (2): ci: remove redundant configs disabling kmods ci: enable more drivers in Travis builds .travis.yml | 30 +- 1 file changed, 5

[dpdk-dev] [PATCH v2 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Thomas Monjalon
The kernel modules are not built by default since below commit. The Travis CI matrix can be simplified by removing the redundant option enable_kmods=false, and by removing some jobs which become redundant. Note: there is no benefit in checking kmods in Travis Ubuntu. Anyway different kernel versio

[dpdk-dev] [PATCH] devtools: forbid variable declaration inside for

2020-02-17 Thread Thomas Monjalon
Some compilers raise an error when declaring a variable in the middle of a function. This is a C99 allowance. Even if DPDK switches globally to C99 or C11 standard, the coding rules are for declarations at the beginning of a block: http://doc.dpdk.org/guides/contributing/coding_style.html#local-var

Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds

2020-02-17 Thread Aaron Conole
Thomas Monjalon writes: > 17/02/2020 19:00, Aaron Conole: >> Thomas Monjalon writes: >> >> > The Travis compilation is missing some dependencies to build these PMDs: >> >- af_xdp (libbpf) >> >- ipn3ke (libfdt) >> >- mlx (libibverbs) >> > >> > Signed-off-by: Thomas Monjalon >> >> I

Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds

2020-02-17 Thread Thomas Monjalon
17/02/2020 19:00, Aaron Conole: > Thomas Monjalon writes: > > > The Travis compilation is missing some dependencies to build these PMDs: > > - af_xdp (libbpf) > > - ipn3ke (libfdt) > > - mlx (libibverbs) > > > > Signed-off-by: Thomas Monjalon > > I was going to wait until travis fin

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-17 Thread Aaron Conole
David Marchand writes: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > can be kept.

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread Thomas Monjalon
17/02/2020 14:06, Jerin Jacob: > On Mon, Feb 17, 2020 at 1:39 PM wrote: > > > > From: Tao Zhu > > > > Change the definition of C99 style to C90 style. > > compile log as below: > > > > otx2_mempool_ops.c: In function ‘otx2_npa_populate’: > > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread Thomas Monjalon
17/02/2020 19:04, Jeremy Plsek: > On Mon, Feb 17, 2020 at 9:57 AM David Marchand > wrote: > > > > Jeremy, > > > > On Mon, Feb 17, 2020 at 12:19 PM David Marchand > > wrote: > > > > > > This patch has been sent with a date in the future. > > > Date: Mon, 17 Feb 2020 16:43:45 + > > > > > > Plea

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread Jeremy Plsek
On Mon, Feb 17, 2020 at 9:57 AM David Marchand wrote: > > Jeremy, > > On Mon, Feb 17, 2020 at 12:19 PM David Marchand > wrote: > > > > This patch has been sent with a date in the future. > > Date: Mon, 17 Feb 2020 16:43:45 + > > > > Please fix your mail setup, this triggers an error with meso

Re: [dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds

2020-02-17 Thread Aaron Conole
Thomas Monjalon writes: > The Travis compilation is missing some dependencies to build these PMDs: > - af_xdp (libbpf) > - ipn3ke (libfdt) > - mlx (libibverbs) > > Signed-off-by: Thomas Monjalon > --- I was going to wait until travis finished to ACK this but I think it's okay.

Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Thomas Monjalon
17/02/2020 17:46, Bruce Richardson: > On Mon, Feb 17, 2020 at 11:42:37AM -0500, Aaron Conole wrote: > > Thomas Monjalon writes: > > > > > The kernel modules are not built by default since below commit. > > > The Travis CI matrix can be simplified > > > by removing the redundant option enable_kmod

[dpdk-dev] [PATCH] doc: add note on build issues with gcc < 5.0

2020-02-17 Thread Pablo de Lara
The following crypto PMDs use the Intel Multi-buffer library: - AESNI MB PMD - AESNI GCM PMD - ZUC PMD - KASUMI PMD - SNOW3G PMD When this library is built with gcc < 5.0, it might throw some compilation issues. A workaround has been added in the repo of this library, so a note on this has been ad

[dpdk-dev] [PATCH] kernel: remove unused directory for Windows

2020-02-17 Thread Thomas Monjalon
The netuio driver will be hosted in a separate repository: http://git.dpdk.org/dpdk-kmods/ Signed-off-by: Thomas Monjalon --- MAINTAINERS| 1 - kernel/windows/meson.build | 4 2 files changed, 5 deletions(-) delete mode 100644 kernel/windows/meson.build diff --git

[dpdk-dev] [PATCH] introduce dpdk-kmods repository

2020-02-17 Thread Thomas Monjalon
Write first lines of the README file about the intent (upstream first) and the licenses allowed so far in DPDK. Signed-off-by: Thomas Monjalon --- README | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 README diff --git a/README b/README new file mode 100644 index 000.

Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Bruce Richardson
On Mon, Feb 17, 2020 at 11:42:37AM -0500, Aaron Conole wrote: > Thomas Monjalon writes: > > > The kernel modules are not built by default since below commit. > > The Travis CI matrix can be simplified > > by removing the redundant option enable_kmods=false, > > and by removing some jobs which bec

Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Aaron Conole
Thomas Monjalon writes: > The kernel modules are not built by default since below commit. > The Travis CI matrix can be simplified > by removing the redundant option enable_kmods=false, > and by removing some jobs which become redundant. > > Note: there is no benefit in checking kmods in Travis U

[dpdk-dev] Fwd: high latency detected in IP pipeline example

2020-02-17 Thread Victor Huertas
Hi all, I am developing my own DPDK application basing it in the dpdk-stable ip_pipeline example. At this moment I am using the 17.11 LTS version of DPDK and I amb observing some extrange behaviour. Maybe it is an old issue that can be solved quickly so I would appreciate it if some expert can sha

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Harman Kalra
On Mon, Feb 17, 2020 at 04:17:53PM +, Ferruh Yigit wrote: > On 2/17/2020 3:30 PM, Harman Kalra wrote: > > On Mon, Feb 17, 2020 at 03:19:53PM +, Ferruh Yigit wrote: > >> On 2/17/2020 3:06 PM, Harman Kalra wrote: > >>> On Mon, Feb 17, 2020 at 02:54:13PM +, Ferruh Yigit wrote: > On 2/

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Ferruh Yigit
On 2/17/2020 3:30 PM, Harman Kalra wrote: > On Mon, Feb 17, 2020 at 03:19:53PM +, Ferruh Yigit wrote: >> On 2/17/2020 3:06 PM, Harman Kalra wrote: >>> On Mon, Feb 17, 2020 at 02:54:13PM +, Ferruh Yigit wrote: On 2/17/2020 2:35 PM, Harman Kalra wrote: > On Mon, Feb 17, 2020 at 01:21

[dpdk-dev] [PATCH] net/ionic: fix ABI version

2020-02-17 Thread Ferruh Yigit
Changed the ABI version to 20.0.1. Fixes: a72cf98cc93e ("net/ionic: add skeleton") Reported-by: David Marchand Signed-off-by: Ferruh Yigit --- Cc: Alfredo Cardigliano --- drivers/net/ionic/rte_pmd_ionic_version.map | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

[dpdk-dev] Fwd: Proposal to add a new toolchain for dpdk: g++

2020-02-17 Thread Victor Huertas
Hi Neil, Well, the thing is that I wanted to keep on using g++ as compiling tool (and reduce impact on my original develoment environment). My source code is composed by *.cpp extension files I decided to modify the dpdk makefiles to accept such extension as well as disable some -W flags that are

[dpdk-dev] Fwd: Proposal to add a new toolchain for dpdk: g++

2020-02-17 Thread Victor Huertas
Thanks Bruce for your answer, I will try it and let you know. Although I guess that it makes no difference if, instead of an exe file, I am compiling a static library (libmylibrary.a), right? BTW, I would like to insist on the second issue I was referring to in my first reply about ip pipeline exa

Re: [dpdk-dev] [v2] net/ixgbe: check illegal packets

2020-02-17 Thread Ye Xiaolong
On 02/17, Xiao Zhang wrote: >Some illegal packets will lead to TX hang. This patch checks those >illegal packets and protects TX from hanging. > >Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") >Cc: sta...@dpdk.org > >Signed-off-by: Xiao Zhang >--- >v2 change the minimum packet length accord

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-17 Thread Ray Kinsella
On 17/02/2020 15:44, Ye Xiaolong wrote: > Hi, Ray > > On 02/17, Ray Kinsella wrote: >> On 17/02/2020 02:47, Xiaolong Ye wrote: >>> This doc describes how to enable DPDK on Openwrt in both virtual and >>> physical x86 environment. >>> >>> Signed-off-by: Xiaolong Ye >>> Acked-by: John McNamara

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-17 Thread Ye Xiaolong
Hi, Ray On 02/17, Ray Kinsella wrote: >On 17/02/2020 02:47, Xiaolong Ye wrote: >> This doc describes how to enable DPDK on Openwrt in both virtual and >> physical x86 environment. >> >> Signed-off-by: Xiaolong Ye >> Acked-by: John McNamara >> --- >> >> V6 changes: >> >> 1. addressed review co

[dpdk-dev] [PATCH v3] doc: add inline protocol in feature list

2020-02-17 Thread Anoob Joseph
Update feature list to include inline protocol offload. Signed-off-by: Anoob Joseph --- v3 * Added inline protocol in octeontx2_vf.ini v2 * Reworded doc following suggestions from Akhil doc/guides/nics/features.rst | 27 ++- doc/guides/nics/features/default

[dpdk-dev] [PATCH] doc: plan splitting the ethdev ops struct

2020-02-17 Thread Ferruh Yigit
For the ABI compatibility it is better to hide internal data structures from the application as much as possible. But because of some inline functions 'struct eth_dev_ops' can't be hidden completely. Plan is to split the 'struct eth_dev_ops' into two as ones used by inline functions and ones not u

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-17 Thread Neil Horman
On Mon, Feb 17, 2020 at 02:23:15PM +, Ray Kinsella wrote: > > > On 14/02/2020 20:48, Neil Horman wrote: > > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: > >> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: > >>> On Thu, Feb 13, 2020 at 05:40:43PM +, Ray K

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Harman Kalra
On Mon, Feb 17, 2020 at 03:19:53PM +, Ferruh Yigit wrote: > On 2/17/2020 3:06 PM, Harman Kalra wrote: > > On Mon, Feb 17, 2020 at 02:54:13PM +, Ferruh Yigit wrote: > >> On 2/17/2020 2:35 PM, Harman Kalra wrote: > >>> On Mon, Feb 17, 2020 at 01:21:13PM +, Ferruh Yigit wrote: > Exter

[dpdk-dev] [PATCH v2] doc: add inline protocol in feature list

2020-02-17 Thread Anoob Joseph
Update feature list to include inline protocol offload. Signed-off-by: Anoob Joseph --- doc/guides/nics/features.rst | 27 ++- doc/guides/nics/features/default.ini | 1 + doc/guides/nics/features/octeontx2.ini | 1 + 3 files changed, 28 insertions(+), 1 dele

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Ferruh Yigit
On 2/17/2020 3:06 PM, Harman Kalra wrote: > On Mon, Feb 17, 2020 at 02:54:13PM +, Ferruh Yigit wrote: >> On 2/17/2020 2:35 PM, Harman Kalra wrote: >>> On Mon, Feb 17, 2020 at 01:21:13PM +, Ferruh Yigit wrote: External Email

Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-17 Thread Thomas Monjalon
17/02/2020 14:59, David Marchand: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > ca

Re: [dpdk-dev] [v2] net/ixgbe: check illegal packets

2020-02-17 Thread Ananyev, Konstantin
> > Some illegal packets will lead to TX hang. This patch checks those > illegal packets and protects TX from hanging. > > Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") > Cc: sta...@dpdk.org > > Signed-off-by: Xiao Zhang > --- > v2 change the minimum packet length according to the dat

Re: [dpdk-dev] [PATCH v6] doc: introduce openwrt how-to guide

2020-02-17 Thread Ray Kinsella
On 17/02/2020 02:47, Xiaolong Ye wrote: > This doc describes how to enable DPDK on Openwrt in both virtual and > physical x86 environment. > > Signed-off-by: Xiaolong Ye > Acked-by: John McNamara > --- > > V6 changes: > > 1. addressed review comments raised by Thomas > > V5 changes: > > 1. i

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Harman Kalra
On Mon, Feb 17, 2020 at 02:54:13PM +, Ferruh Yigit wrote: > On 2/17/2020 2:35 PM, Harman Kalra wrote: > > On Mon, Feb 17, 2020 at 01:21:13PM +, Ferruh Yigit wrote: > >> External Email > >> > >> -- > >> On 2/15/2020 8:35 AM,

[dpdk-dev] [v2] net/ixgbe: check illegal packets

2020-02-17 Thread Xiao Zhang
Some illegal packets will lead to TX hang. This patch checks those illegal packets and protects TX from hanging. Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") Cc: sta...@dpdk.org Signed-off-by: Xiao Zhang --- v2 change the minimum packet length according to the datasheet. --- drivers/ne

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread David Marchand
On Mon, Feb 17, 2020 at 2:06 PM Jerin Jacob wrote: > > On Mon, Feb 17, 2020 at 1:39 PM wrote: > > > > From: Tao Zhu > > > > Change the definition of C99 style to C90 style. > > compile log as below: > > > > otx2_mempool_ops.c: In function ‘otx2_npa_populate’: > > /dpdk/drivers/mempool/octeontx2/

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread David Marchand
Jeremy, On Mon, Feb 17, 2020 at 12:19 PM David Marchand wrote: > > This patch has been sent with a date in the future. > Date: Mon, 17 Feb 2020 16:43:45 + > > Please fix your mail setup, this triggers an error with meson in UNH > CI (at least). Do you use the tools/pwclient script from dpdk-

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Ferruh Yigit
On 2/17/2020 2:35 PM, Harman Kalra wrote: > On Mon, Feb 17, 2020 at 01:21:13PM +, Ferruh Yigit wrote: >> External Email >> >> -- >> On 2/15/2020 8:35 AM, Harman Kalra wrote: >>> PTP functionality has been broken after a change

Re: [dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-17 Thread Bruce Richardson
On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote: > Hi all, > > I am using DPDK development environment to develop an application from > which I have to access C++ code. > I managed to modify some internal mk files in the dpdk-stable repository to > allow g++ compiler to be supported

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Harman Kalra
On Mon, Feb 17, 2020 at 01:21:13PM +, Ferruh Yigit wrote: > External Email > > -- > On 2/15/2020 8:35 AM, Harman Kalra wrote: > > PTP functionality has been broken after a change in kernel > > where enum npc_kpu_lc_ltype is ch

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-17 Thread Ray Kinsella
On 14/02/2020 20:48, Neil Horman wrote: > On Fri, Feb 14, 2020 at 11:36:34AM +, Bruce Richardson wrote: >> On Thu, Feb 13, 2020 at 09:40:40PM -0500, Neil Horman wrote: >>> On Thu, Feb 13, 2020 at 05:40:43PM +, Ray Kinsella wrote: On 05/02/2020 11:32, Neil Horman wrote: >>>

[dpdk-dev] [PATCH] net/mlx5: fix the matching for ICMP fragments

2020-02-17 Thread Bing Zhao
The hardware can recognize and mark the layer 4 protocol type for TCP, UDP and IPSec non-fragmented packets. For all the fragmented packets, L4 type will be considered as None. This can be used when creating a flow with L4 matching, then hops number will be reduced and a better performance could be

Re: [dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Thomas Monjalon
17/02/2020 12:35, Thomas Monjalon: > The kernel modules are not built by default since below commit. > The Travis CI matrix can be simplified > by removing the redundant option enable_kmods=false, > and by removing some jobs which become redundant. > > Note: there is no benefit in checking kmods i

[dpdk-dev] [PATCH] ci: build and use libabigail 1.6

2020-02-17 Thread David Marchand
libabigail 1.2 (at least) reports changes in 'const' property as an ABI breakage [1]. This was fixed upstream in libabigail 1.4 [2], and a bug has been opened in launchpad [3]. But for now, build and use the last version 1.6 so that the ABI checks can be kept. 1: https://travis-ci.com/DPDK/dpdk/j

[dpdk-dev] [PATCH] net/mlx5: fix the hairpin queue capacity

2020-02-17 Thread Bing Zhao
The hairpin TX/RX queue depth and packet size is fixed in the past. When the firmware has some fix or improvement, the PMD will not make full use of it. And also, 32 packets for a single queue will not guarantee a good performance for hairpin flows. The parameter of hairpin queue setup needs to be

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/octeontx2: fix ptp functionality

2020-02-17 Thread Ferruh Yigit
On 2/15/2020 8:35 AM, Harman Kalra wrote: > PTP functionality has been broken after a change in kernel > where enum npc_kpu_lc_ltype is change to allow adjustment of > LTYPE_MASK to detect all types of IP headers. > Syncing the required changes in DPDK to fix the issue. Hi Harman, Can you please

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread Jerin Jacob
On Mon, Feb 17, 2020 at 1:39 PM wrote: > > From: Tao Zhu > > Change the definition of C99 style to C90 style. > compile log as below: > > otx2_mempool_ops.c: In function ‘otx2_npa_populate’: > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \ > ‘for’ loop initial declarat

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix blocking system events

2020-02-17 Thread Ferruh Yigit
On 2/15/2020 3:41 PM, Ye Xiaolong wrote: > On 01/15, taox@intel.com wrote: >> From: Zhu Tao >> >> IXGBE link status task use rte alarm thread in old implementation. > > s/use/uses > >> Sometime ixgbe link status task takes up to 9 seconds. This will >> severely affect the rte-alarm-thread-de

Re: [dpdk-dev] [PATCH v8 1/1] fbarray: fix duplicated fbarray file in secondary

2020-02-17 Thread Yasufumi Ogawa
14/02/2020 16:08, David Marchand: On Fri, Feb 14, 2020 at 8:46 AM Yasufumi Ogawa wrote: Hi, Could I confirm that this patch is going to be merged in 20.02? Sorry, but I can't take this patch in 20.02. It breaks compilation on FreeBSD. http://mails.dpdk.org/archives/test-report/2019-November

Re: [dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-17 Thread Neil Horman
On Mon, Feb 17, 2020 at 11:01:21AM +0100, Victor Huertas wrote: > Hi all, > > I am using DPDK development environment to develop an application from > which I have to access C++ code. > I managed to modify some internal mk files in the dpdk-stable repository to > allow g++ compiler to be supported

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-17 Thread Neil Horman
On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote: > Now that Python 2 is officially not maintained anymore, prepare the > removal of support in DPDK. > > Add a deprecation notice indicating the removal schedule. > > Cc: Bruce Richardson > Cc: Kevin Traynor > Cc: Timothy Redaelli >

[dpdk-dev] [PATCH 1/2] ci: remove redundant configs disabling kmods

2020-02-17 Thread Thomas Monjalon
The kernel modules are not built by default since below commit. The Travis CI matrix can be simplified by removing the redundant option enable_kmods=false, and by removing some jobs which become redundant. Note: there is no benefit in checking kmods in Travis Ubuntu. Anyway different kernel versio

[dpdk-dev] [PATCH 2/2] ci: enable more drivers in Travis builds

2020-02-17 Thread Thomas Monjalon
The Travis compilation is missing some dependencies to build these PMDs: - af_xdp (libbpf) - ipn3ke (libfdt) - mlx (libibverbs) Signed-off-by: Thomas Monjalon --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml ind

[dpdk-dev] [PATCH 0/2] improve Travis coverage

2020-02-17 Thread Thomas Monjalon
Remove some useless jobs and add more packages to build more PMDs in Travis. Warning: not tested yet! Hope Travis will do it well :-) Thomas Monjalon (2): ci: remove redundant configs disabling kmods ci: enable more drivers in Travis builds .travis.yml | 30 +- 1

Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread David Marchand
This patch has been sent with a date in the future. Date: Mon, 17 Feb 2020 16:43:45 + Please fix your mail setup, this triggers an error with meson in UNH CI (at least). -- David Marchand On Mon, Feb 17, 2020 at 9:09 AM wrote: > > From: Tao Zhu > > Change the definition of C99 style to C

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-17 Thread Jerin Jacob
On Mon, Feb 17, 2020 at 2:08 PM Thomas Monjalon wrote: > > Hi Jerin, Hi Thomas, Thanks for starting this discussion now. It is an interesting discussion. Some thoughts below. We can decide based on community consensus and follow a single rule across the components. > > 17/02/2020 08:19, Jerin

Re: [dpdk-dev] [PATCH] test/crypto: replace wireless algos test vectors

2020-02-17 Thread Trahe, Fiona
Hi Akhil, Thomas, Can you please hold off on applying this patch for the moment - it seems we may get approval on licensing for the original vectors. Fiona > -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, February 13, 2020 1:44 PM > To: Akhil Goyal ; dev@dpdk.org; Trahe,

Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-17 Thread Bruce Richardson
On Mon, Feb 17, 2020 at 01:17:49PM +0530, agup...@marvell.com wrote: > From: Amit Gupta > > Add a condition to check if octeontx drivers are disabled. > octeontx drivers are built only if dependent drivers i.e. > ethdev, mempool and common/octeontx are enabled. > > BugZilla ID # BUG 387 > > Sig

Re: [dpdk-dev] [PATCH v1] doc: rework vm power manager user guide

2020-02-17 Thread Hunt, David
Hi Thomas, On 16/2/2020 11:13 AM, Thomas Monjalon wrote: 07/01/2020 10:13, David Hunt: Review and re-work of vm_power_manager documentation. Hopefully this is clearer, easier to follow. Signed-off-by: David Hunt checkpatch is reporting a typo done several times: s/virutal/virtual/

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-17 Thread Bruce Richardson
On Mon, Feb 17, 2020 at 10:26:59AM +0100, Robin Jarry wrote: > Now that Python 2 is officially not maintained anymore, prepare the > removal of support in DPDK. > > Add a deprecation notice indicating the removal schedule. > > Cc: Bruce Richardson > Cc: Kevin Traynor > Cc: Timothy Redaelli >

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-02-17 Thread Jerin Jacob
On Mon, Feb 17, 2020 at 3:05 PM Mattias Rönnblom wrote: > > On 2020-02-15 11:21, Jerin Jacob wrote: > > On Fri, Jan 17, 2020 at 4:24 PM Jerin Jacob wrote: > >> On Fri, Jan 17, 2020 at 4:00 PM Mattias Rönnblom > >> wrote: > LTTng kernel tracing only needs kmod support. > For the userspa

[dpdk-dev] Proposal to add a new toolchain for dpdk: g++

2020-02-17 Thread Victor Huertas
Hi all, I am using DPDK development environment to develop an application from which I have to access C++ code. I managed to modify some internal mk files in the dpdk-stable repository to allow g++ compiler to be supported. I have all the modified files well identified and I wonder if the support

Re: [dpdk-dev] CONFIG_RTE_MAX_MEM_MB fails in DPDK18.05

2020-02-17 Thread Kamaraj P
Hi Anatoly, Thanks for the clarifications. Currently we are migrating to the new DPDK 18.11 ( from 17.05). Here is our configuration: === We have configured the "--legacy-mem" option and changed the CONFIG_RTE_MAX_MEM_MB to 2048

Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled

2020-02-17 Thread David Marchand
On Mon, Feb 17, 2020 at 8:48 AM wrote: > > From: Amit Gupta > > Add a condition to check if octeontx drivers are disabled. > octeontx drivers are built only if dependent drivers i.e. > ethdev, mempool and common/octeontx are enabled. > > BugZilla ID # BUG 387 Interesting format, but we prefer co

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix hot-unplug detaching

2020-02-17 Thread Kevin Traynor
On 16/02/2020 09:47, Thomas Monjalon wrote: > 16/02/2020 09:09, Matan Azrad: >> Hi Thomas >> >> Thanks for the patches, I Saw it just now. >> please see small comment below: >> >> From: Thomas Monjalon >>> There is a possible race condition in the hotplug path in >>> rmv_port_callback(). >>> If

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-02-17 Thread Mattias Rönnblom
On 2020-02-15 11:21, Jerin Jacob wrote: > On Fri, Jan 17, 2020 at 4:24 PM Jerin Jacob wrote: >> On Fri, Jan 17, 2020 at 4:00 PM Mattias Rönnblom >> wrote: LTTng kernel tracing only needs kmod support. For the userspace tracing at minium following libraries are required. a) LTT

[dpdk-dev] [PATCH] doc: add deprecation notice for python 2 support

2020-02-17 Thread Robin Jarry
Now that Python 2 is officially not maintained anymore, prepare the removal of support in DPDK. Add a deprecation notice indicating the removal schedule. Cc: Bruce Richardson Cc: Kevin Traynor Cc: Timothy Redaelli Signed-off-by: Robin Jarry --- doc/guides/rel_notes/deprecation.rst | 6 +

Re: [dpdk-dev] Dropping python 2 support

2020-02-17 Thread Robin Jarry
2020-02-13, Bruce Richardson: > Yes. I'd suggest for 20.05 perhaps putting a deprecation notice in the docs > and then later (20.08) putting warnings in the code. Perhaps full removal of > support should be done for 20.11, or do we need one more LTS release with > the support still present? I'll p

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-02-17 Thread Thomas Monjalon
Hi Jerin, 17/02/2020 08:19, Jerin Jacob: > I got initial comments from Ray and Stephen on this RFC[1]. Thanks for > the comments. > > Is anyone else planning to have an architecture level or API usage > level review or any review of other top-level aspects? If we add rte_graph to DPDK, we will h

[dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue

2020-02-17 Thread taox . zhu
From: Tao Zhu Change the definition of C99 style to C90 style. compile log as below: otx2_mempool_ops.c: In function ‘otx2_npa_populate’: /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \ ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 0; i <

[dpdk-dev] [PATCH v3] net/ixgbe: fix flow ctrl mode setting

2020-02-17 Thread Guinan Sun
When the port starts, the hw register is reset first, and then the required parameters are set again. If the parameters to be used are not set after resetting the register, a read register error will occur. This patch is used to fix the problem. Fixes: af75078fece3 ("first public release") Cc: sta