Re: [dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-03-11 Thread Akhil Goyal
Hi Anoob, Please send a release note update as a reply to this mail. I will update it while merging the patchset. Regards, Akhil > > Hi Akhil, > > Reminder. > > Do you have any further review comments? > > Thanks, > Anoob > > > -Original Message- > > From: Ananyev, Konstantin > > S

Re: [dpdk-dev] [PATCH v5 00/15] add eventmode to ipsec-secgw

2020-03-11 Thread Anoob Joseph
Hi Akhil, Reminder. Do you have any further review comments? Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, March 3, 2020 11:30 PM > To: Lukas Bartosik ; Akhil Goyal > ; Nicolau, Radu ; Thomas > Monjalon > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasa

Re: [dpdk-dev] [PATCH v1 03/15] net/igc: device initialization

2020-03-11 Thread Ye Xiaolong
Better to use imperative mode like "add device initialization" for the commit subject. And the subject doesn't match what this patch really does, it's more about adding OS specific functions and definitions other than 'device initialization'. On 03/09, alvinx.zh...@intel.com wrote: >From: Alvin Z

Re: [dpdk-dev] [RFC PATCH 1/3] librte_ethdev: support device recovery event

2020-03-11 Thread Kalesh Anakkur Purayil
Hi Thomas, On Wed, Mar 11, 2020 at 6:50 PM Thomas Monjalon wrote: > 22/01/2020 11:16, Kalesh A P: > > From: Kalesh AP > > > > Adding support for recovery event in rte_eth_event framework. > > FW error and FW reset conditions would be managed by PMD. > > In such cases, PMD would need recovery ev

Re: [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support

2020-03-11 Thread Kalesh Anakkur Purayil
Hi Thomas, On Wed, Mar 11, 2020 at 6:49 PM Thomas Monjalon wrote: > 22/01/2020 11:16, Kalesh A P: > > From: Kalesh AP > > > > This patch adds support for recovery event in rte_eth_event framework. > > FW error and FW reset conditions would be managed by PMD. Driver uses > > "Driver"? THE driver

Re: [dpdk-dev] [PATCH v1 01/15] net/igc: add igc PMD

2020-03-11 Thread Ye Xiaolong
On 03/09, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >Implement device detection and loading. > >Signed-off-by: Alvin Zhang >--- > MAINTAINERS | 7 + > config/common_base | 7 + > doc/guides/nics/features/igc.ini| 8 + > doc/guid

[dpdk-dev] [PATCH v7] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb. Fixes: ccad39ea0712 ("eal/arm: add cpu cycle operations for ARMv8") Cc: sta...@dpdk.org Reviewed-by: David Marchand Reviewed-by: Jerin Jacob Reviewed-by: Gavin Hu Signed-off-by: Haifeng Lin --- lib/librte_eal/common/in

Re: [dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
> > +static inline void > > +isb(void) > > +{ > > + asm volatile("isb" : : : "memory"); } > > NAK. > > Don't export badly named stuff like this. > Just use asm volatile("isb" : : : "memory") in rte_rdtsc_precise or which file I should use to define this maco > > + > > +static inline voi

Re: [dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

2020-03-11 Thread Webster, Steven
> gcc 10.0.1 reports: > > ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: > ../drivers/net/avp/avp_ethdev.c:1791:24: > warning: ‘avp_bufs[count]’ may be used uninitialized in this function [- > Wmaybe-uninitialized] > 1791 | tx_bufs[i] = avp_bufs[count]; > |

[dpdk-dev] [PATCH v3] vhost: make iotlb cache name unique among multi processes

2020-03-11 Thread Itsuro Oda
Currently, iotlb cache name is comprised of vid and virtqueue index. For example, "iotlb_cache_0_0". Because vid is assigned per process, iotlb cache name is not unique among multi processes. For example a secondary process uses a vhost (ex. eth_vhost0,iface=/tmp/sock0) and another secondary proces

[dpdk-dev] [PATCH 1/3] doc: fix matrix CSS for recent sphinx

2020-03-11 Thread Thomas Monjalon
It seems sphinx >= 2.0 is inserting a tag in each table cell. The feature table (matrix) style needs to be updated to avoid cells being too big. The margin, padding and line height are overriden. The font size in percentage is replaced with an equivalent pixel size. The border is explicit because

[dpdk-dev] [PATCH 3/3] doc: remove similar columns from NIC features matrix

2020-03-11 Thread Thomas Monjalon
The PMDs bnx2x and nfp have a separate column for VF. Such separation is unneeded because the features are the same. Signed-off-by: Thomas Monjalon --- doc/guides/nics/features/bnx2x.ini| 1 + doc/guides/nics/features/bnx2x_vf.ini | 18 - doc/guides/nics/features/nfp_vf.ini

[dpdk-dev] [PATCH 0/3] refresh NIC features matrix

2020-03-11 Thread Thomas Monjalon
This series aims to clean-up the big table of ethdev features: http://doc.dpdk.org/guides/nics/overview.html#id1 We could reorganize the information in this table, maybe split it or add/remove some rows. Before going to such reorganization, we should clean it up. The first patch is fixing the l

[dpdk-dev] [PATCH 2/3] doc: remove empty columns from NIC features matrix

2020-03-11 Thread Thomas Monjalon
The virtual PMDs bonding, KNI, null, ring, softnic and vdev_netvsc have no real feature to advertise so they can be removed from the (too) big matrix of ethdev features. Signed-off-by: Thomas Monjalon --- doc/guides/nics/features/bonding.ini | 6 -- doc/guides/nics/features/kni.ini

Re: [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support

2020-03-11 Thread Kadam, Pallavi
On 2/26/2020 8:25 PM, Dmitry Kozlyuk wrote: This patch series add support for building DPDK using MinGW-w64. MinGW-w64 provides GNU toolchain and independent platform SDK on Windows. It also supports cross-compilation to Windows from POSIX systems by providing cross tollchains and libraries [

[dpdk-dev] [PATCH v3 5/7] vfio/pci: Add sriov_configure support

2020-03-11 Thread Alex Williamson
With the VF Token interface we can now expect that a vfio userspace driver must be in collaboration with the PF driver, an unwitting userspace driver will not be able to get past the GET_DEVICE_FD step in accessing the device. We can now move on to actually allowing SR-IOV to be enabled by vfio-pc

[dpdk-dev] [PATCH v3 6/7] vfio/pci: Remove dev_fmt definition

2020-03-11 Thread Alex Williamson
It currently results in messages like: "vfio-pci :03:00.0: vfio_pci: ..." Which is quite a bit redundant. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/

[dpdk-dev] [PATCH v3 7/7] vfio/pci: Cleanup .probe() exit paths

2020-03-11 Thread Alex Williamson
The cleanup is getting a tad long. Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c | 54 --- 1 file changed, 25 insertions(+), 29 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c index af1ba9867201..6c6b

[dpdk-dev] [PATCH v3 1/7] vfio: Include optional device match in vfio_device_ops callbacks

2020-03-11 Thread Alex Williamson
Allow bus drivers to provide their own callback to match a device to the user provided string. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/vfio.c | 20 include/linux/vfio.h |4 2 files changed, 20 insertions(+), 4 deletions(-) dif

[dpdk-dev] [PATCH v3 4/7] vfio: Introduce VFIO_DEVICE_FEATURE ioctl and first user

2020-03-11 Thread Alex Williamson
The VFIO_DEVICE_FEATURE ioctl is meant to be a general purpose, device agnostic ioctl for setting, retrieving, and probing device features. This implementation provides a 16-bit field for specifying a feature index, where the data porition of the ioctl is determined by the semantics for the given f

[dpdk-dev] [PATCH v3 2/7] vfio/pci: Implement match ops

2020-03-11 Thread Alex Williamson
This currently serves the same purpose as the default implementation but will be expanded for additional functionality. Reviewed-by: Cornelia Huck Signed-off-by: Alex Williamson --- drivers/vfio/pci/vfio_pci.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/vfio/pci/vfio_

[dpdk-dev] [PATCH v3 3/7] vfio/pci: Introduce VF token

2020-03-11 Thread Alex Williamson
If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not fully isolated from the PF. The PF can always cause a denial of service to the VF, even if by simply resetting itself. The degree to which a PF can access the data passed through a VF or interfere with its operation is dependen

[dpdk-dev] [PATCH v3 0/7] vfio/pci: SR-IOV support

2020-03-11 Thread Alex Williamson
Only minor tweaks since v2, GET and SET on VFIO_DEVICE_FEATURE are enforced mutually exclusive except with the PROBE option as suggested by Connie, the modinfo text has been expanded for the opt-in to enable SR-IOV support in the vfio-pci driver per discussion with Kevin. I have not incorporated r

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-03-11 Thread Thinh Tran
Hi David, Thanks for your response. We were worry about breaking the DPDK/FreeBSD on power, may hit the similar bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241146 From my understanding, and also from the documentation https://doc.dpdk.org/guides/freebsd_gsg/install_from_ports.html

Re: [dpdk-dev] Coverity scan

2020-03-11 Thread Aaron Conole
Thomas Monjalon writes: > 11/03/2020 18:34, Aaron Conole: >> Thomas Monjalon writes: >> >> > We have a public Coverity scan triggered by John for the community: >> >https://scan.coverity.com/projects/dpdk-data-plane-development-kit >> > Note there is a tool to help with this task: >> >

Re: [dpdk-dev] Coverity scan

2020-03-11 Thread Thomas Monjalon
11/03/2020 18:34, Aaron Conole: > Thomas Monjalon writes: > > > We have a public Coverity scan triggered by John for the community: > > https://scan.coverity.com/projects/dpdk-data-plane-development-kit > > Note there is a tool to help with this task: > > > > http://thyrsus.com/gitweb/?p

Re: [dpdk-dev] Coverity scan

2020-03-11 Thread Aaron Conole
Thomas Monjalon writes: > We have a public Coverity scan triggered by John for the community: > https://scan.coverity.com/projects/dpdk-data-plane-development-kit > Note there is a tool to help with this task: > > http://thyrsus.com/gitweb/?p=coverity-submit.git;a=shortlog;h=refs/tag

Re: [dpdk-dev] [PATCH v4 0/7] MinGW-w64 support

2020-03-11 Thread William Tu
On Wed, Feb 26, 2020 at 8:25 PM Dmitry Kozlyuk wrote: > > This patch series add support for building DPDK using MinGW-w64. > > MinGW-w64 provides GNU toolchain and independent platform SDK on > Windows. It also supports cross-compilation to Windows from POSIX > systems by providing cross tollchain

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Aaron Conole
David Marchand writes: > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > wrote: >> >> This commit releases all service cores from their role, >> returning them to ROLE_RTE on rte_service_finalize(). >> >> This may fix an issue relating to the service cores causing > > You don't seem convinced

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Wednesday, March 11, 2020 4:16 PM > To: Van Haaren, Harry > Cc: dev ; Aaron Conole ; dpdk stable > > Subject: Re: [PATCH v2] eal/service: fix exit by resetting service lcores > > On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren > wrot

Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread David Marchand
On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing You don't seem convinced. > a race-condition on eal_cleanup

Re: [dpdk-dev] [PATCH 2/3] crypto/qat: optimise check for chained mbufs

2020-03-11 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Wednesday, March 11, 2020 1:26 PM > To: dev@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com; Dybkowski, AdamX > Subject: [dpdk-dev] [PATCH 2/3] crypto/qat: optimise check for chained > mbufs > > From: Fiona Trahe >

Re: [dpdk-dev] [PATCH 1/3] crypto/qat: improve out-of-place conditional check

2020-03-11 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Wednesday, March 11, 2020 1:26 PM > To: dev@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com; Dybkowski, AdamX > Subject: [dpdk-dev] [PATCH 1/3] crypto/qat: improve out-of-place > conditional check > > From: Fiona Trah

Re: [dpdk-dev] [PATCH 3/3] common/qat: optimise calculation of cookie index

2020-03-11 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev On Behalf Of Adam Dybkowski > Sent: Wednesday, March 11, 2020 1:26 PM > To: dev@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com; Dybkowski, AdamX > Subject: [dpdk-dev] [PATCH 3/3] common/qat: optimise calculation of cookie > index > > From: Fiona Trahe

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-11 Thread Ananyev, Konstantin
> -Original Message- > From: Doherty, Declan > Sent: Wednesday, March 11, 2020 1:36 PM > To: Anoob Joseph ; Shetty, Praveen > ; dev@dpdk.org; Iremonger, Bernard > ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah > DDP file > > On

[dpdk-dev] [PATCH v1] examples/ipsec-secgw: support flow director feature

2020-03-11 Thread Praveen Shetty
Modified Secuirty gateway application to support configuration of flow director rule to direct inbound IPsec SA to a specified queue. Signed-off-by: Praveen Shetty --- examples/ipsec-secgw/ep0.cfg | 11 + examples/ipsec-secgw/ipsec-secgw.c | 56 - examples/ipsec

[dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores

2020-03-11 Thread Harry van Haaren
This commit releases all service cores from their role, returning them to ROLE_RTE on rte_service_finalize(). This may fix an issue relating to the service cores causing a race-condition on eal_cleanup(), where the service core could still be executing while the main thread has already free-d the

Re: [dpdk-dev] [PATCH 2/2] doc: fix QAT GEN3 marketing name in release notes

2020-03-11 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, March 4, 2020 1:19 PM > To: dev@dpdk.org; sta...@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH 2/2] doc: fix QAT GEN3 marketing name in release notes > > This patch fixes the ma

Re: [dpdk-dev] [PATCH 1/2] compress/qat: fix QAT GEN3 marketing name

2020-03-11 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, March 4, 2020 1:19 PM > To: dev@dpdk.org; sta...@dpdk.org; Trahe, Fiona ; > akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH 1/2] compress/qat: fix QAT GEN3 marketing name > > This patch fixes the marketing

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-11 Thread Doherty, Declan
On 10/03/2020 4:24 PM, Anoob Joseph wrote: Hi Praveen, [Anoob] Rather than calling PMD specific functions from all applications, it might be better to introduce the same via 'devargs' to the PMD. [Praveen Shetty] We will investigate further on this. Probably let's converge on this before send

Re: [dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value

2020-03-11 Thread Ferruh Yigit
On 3/9/2020 10:07 AM, Chauskin, Igor wrote: > Acked inline > > From: Vladislav Zolotarov > Sent: Friday, March 6, 2020 12:28 AM > To: dev@dpdk.org; Schmeilin, Evgeny ; Chauskin, Igor > > Subject: RE: [EXTERNAL][dpdk-dev] [PATCH v1] ena_ethdev: don't override the > user provided queue length va

Re: [dpdk-dev] [RFC PATCH 1/3] librte_ethdev: support device recovery event

2020-03-11 Thread Thomas Monjalon
22/01/2020 11:16, Kalesh A P: > From: Kalesh AP > > Adding support for recovery event in rte_eth_event framework. > FW error and FW reset conditions would be managed by PMD. > In such cases, PMD would need recovery events to notify application > about PMD has recovered from FW reset or FW error.

Re: [dpdk-dev] [RFC PATCH 0/3] librte_ethdev: error recovery support

2020-03-11 Thread Thomas Monjalon
22/01/2020 11:16, Kalesh A P: > From: Kalesh AP > > This patch adds support for recovery event in rte_eth_event framework. > FW error and FW reset conditions would be managed by PMD. Driver uses "Driver"? THE driver? :) > RTE_ETH_EVENT_INTR_RESET event to notify the applications about the > FW

Re: [dpdk-dev] [PATCH 0/9] net/cxgbe: updates for rte_flow support

2020-03-11 Thread Ferruh Yigit
On 3/11/2020 9:05 AM, Rahul Lakkireddy wrote: > From: Karra Satwik > > This series of patches contain rte_flow support for matching > Q-in-Q VLAN, IP TOS, PF, and VF fields. Also, adds Destination > MAC rewrite and Source MAC rewrite actions. > > Apart from the 4-tuple (IP src/dst addresses and

[dpdk-dev] [PATCH 3/3] common/qat: optimise calculation of cookie index

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe Avoid costly division, use shift instead. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_qp.c | 9 ++--- drivers/common/qat/qat_qp.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c inde

[dpdk-dev] [PATCH 2/3] crypto/qat: optimise check for chained mbufs

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe To detect if sgl, use nb_segs > 1, instead of checking for next pointer, as nb_segs is in first cache-line while next is in second cache-line. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH 1/3] crypto/qat: improve out-of-place conditional check

2020-03-11 Thread Adam Dybkowski
From: Fiona Trahe Improve case where application set m_dst to same as m_src so really an in-place operation, though would have been treated as out-of-place. No functional change but this path can now benefit from DMA alignment. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_sym.c | 8 ++

Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-11 Thread Jerin Jacob
On Wed, Mar 11, 2020 at 5:52 PM Ananyev, Konstantin wrote: > > > > > -Original Message- > > From: ZY Qiu > > Sent: Thursday, March 5, 2020 4:47 PM > > To: Thomas Monjalon ; Yigit, Ferruh > > ; Andrew Rybchenko > > Cc: dev@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > ;

Re: [dpdk-dev] [PATCH v3] rte_ethdev: safer memory access by calling Rx/Tx callback

2020-03-11 Thread Ananyev, Konstantin
> -Original Message- > From: ZY Qiu > Sent: Thursday, March 5, 2020 4:47 PM > To: Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > Cc: dev@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > ; ZY Qiu > > Subject: [PATCH v3] rte_ethdev: safer memory access by calling Rx

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-11 Thread Bruce Richardson
On Wed, Mar 11, 2020 at 10:04:33AM +0100, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gavin Hu > > Sent: Wednesday, March 11, 2020 8:50 AM > > > > Hi Morten, > > > > > From: Morten Brørup > > > Sent: Monday, March 9, 2020 9:31 PM > > > > > > > From: dev [mailto:

[dpdk-dev] [PATCH] examples/l2fwd-keepalive: fix packet drops limited mbufs

2020-03-11 Thread Louise Kilheeney
MBUF pool of size 8192 was causing packet loss when using four ports. To fix this issue this patch specifies the number of MBUF's per port instead of having one set MBUF pool size, this way it will adapt to any number of ports. Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-03-11 Thread Ananyev, Konstantin
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, March 11, 2020 11:33 AM > To: dev@dpdk.org > Cc: Kevin Traynor ; sta...@dpdk.org; Ananyev, Konstantin > ; Nicolau, Radu > ; Akhil Goyal > Subject: [PATCH v2 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized > warning >

[dpdk-dev] Regarding ENIC driver dpdk 17.11.4 vs dpdk 19.05

2020-03-11 Thread chetan bhasin
Hi, We are using VPP , which internally using dpdk. *With vpp 18.01(dpdk 17.11.4)* : Whenever we set MTU of interface as 1500 , we can get 1500 size of untagged and tagged packet. *With vpp 19.0.5* (dpdk 19.05) : Whenever we set mtu as 1500 , we have seen issue with vlan packets, those are not e

[dpdk-dev] [PATCH v2 1/2] net/avp: fix gcc 10 maybe-uninitialized warning

2020-03-11 Thread Kevin Traynor
gcc 10.0.1 reports: ../drivers/net/avp/avp_ethdev.c: In function ‘avp_xmit_scattered_pkts’: ../drivers/net/avp/avp_ethdev.c:1791:24: warning: ‘avp_bufs[count]’ may be used uninitialized in this function [-Wmaybe-uninitialized] 1791 | tx_bufs[i] = avp_bufs[count]; |~~~

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-03-11 Thread Kevin Traynor
gcc 10.0.1 reports: ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: ../examples/ipsec-secgw/ipsec_process.c:132:34: error: ‘grp.m’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 132 |grp[n].cnt = pkts + i - grp[n].m; |

Re: [dpdk-dev] [PATCH 0/5] net/sfc: fix manual and auto filters clash handling

2020-03-11 Thread Ferruh Yigit
On 3/10/2020 9:48 AM, Andrew Rybchenko wrote: > RTE flow API allows to add filters which clash with filters > installed by the driver itself. The series fixes the case > handling. > > Igor Romanov (5): > net/sfc: set priority of created filters to manual > net/sfc/base: reduce filter prioritie

Re: [dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Jerin Jacob
On Wed, Mar 11, 2020 at 3:35 PM Linhaifeng wrote: > > > > > -Original Message- > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Tuesday, March 10, 2020 6:47 PM > > To: Linhaifeng > > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > > chenchanghu ; xudingke > > ; Lilijun (

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-11 Thread Luca Boccassi
On Wed, 2020-03-11 at 08:58 +0530, Kalesh Anakkur Purayil wrote: > Hi Luca, > > Testing with dpdk v19.11.1-rc1 from Broadcom looks good. > > - Basic functionality: > Send and receive multiple types of traffic. > - Changing/checking link status through testpmd. > - RSS tests. > - TSO tests > - V

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix promiscuous and allmulticast toggles errors

2020-03-11 Thread Ferruh Yigit
On 3/10/2020 9:42 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > Returned errors of ethdev callbacks are negative. Internal > sfc funtions return positive errors, so convert them to > negative value. > > Fixes: 9039c8125730 ("ethdev: change promiscuous callbacks to return status") > Cc: st

Re: [dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, March 10, 2020 6:47 PM > To: Linhaifeng > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > chenchanghu ; xudingke > ; Lilijun (Jerry) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: Re:

Re: [dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread David Marchand
On Wed, Mar 11, 2020 at 8:24 AM Linhaifeng wrote: > > In order to get more accurate the cntvct_el0 reading, > SW must invoke isb and arch_counter_enforce_ordering. > > Reference of linux kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ > linux.git/tree/arch/arm64/include/asm/arc

[dpdk-dev] [PATCH v2] net/ixgbe: fix setting VF MAC address

2020-03-11 Thread Guinan Sun
The reason why PF cannot receive data normally is that vf performed the clear_rar operation through dev close without adding a mac address.  This will cause the association between the index and rx address set by VMDq to be cancelled,thus affecting the data reception of PF. The correction method is

[dpdk-dev] [PATCH 8/9] net/cxgbe: use firmware API for validating filter spec

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add new firmware API FW_PARAM_DEV_FILTER_MODE_MASK to fetch the filtermode and filtermask values configured in hardware, which are used to validate the match combinations in the filter spec before offloading the filter rules to hardware. For older firmware that doesn't support

[dpdk-dev] [PATCH 9/9] net/cxgbe: add devargs to control filtermode and filtermask values

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Apart from the 4-tuple (IP src/dst addresses and TCP/UDP src/dst port addresses), there are only 40-bits available to match other fields in packet headers. Not all combinations of packet header fields can fit in the 40-bit tuple. Currently, the combination of packet header fie

[dpdk-dev] [PATCH 4/9] net/cxgbe: add rte_flow support for matching all packets on VF

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support to match all packets received on the underlying VF. Use new firmware API to fetch the Virtual Interface Number (VIN) allocated to each VF by the firmware. The VIN is required to write filter rules to match all packets on VFs, whose identifier is beyond max 7-bit va

[dpdk-dev] [PATCH 5/9] net/cxgbe: add rte_flow support for overwriting destination MAC

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support for overwriting destination MAC addresses. The new MAC address is written into a free entry in the L2T table and the corresponding L2T index is used by hardware to overwrite the destination MAC address of the packets hitting the flow Signed-off-by: Karra Satwik Si

[dpdk-dev] [PATCH 7/9] net/cxgbe: add rte_flow support for Source MAC Rewrite

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support to rewrite Source MAC addresses. The new Source MAC address is written into a free entry in the SMT table and the corresponding SMT index is used by hardware to rewrite the Source MAC address of the packets hitting the flow. Signed-off-by: Karra Satwik Signed-off-

[dpdk-dev] [PATCH 6/9] net/cxgbe: add Source MAC Table (SMT) support

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Source MAC Table (SMT) is used for storing Source MAC addresses to be written in packets transmitted on the wire. Hence, the SMT table can be used for overwriting Source MAC addresses in packets, hitting corresponding filter rules inserted by the rte_flow API. Query firmware f

[dpdk-dev] [PATCH 3/9] net/cxgbe: add rte_flow support for matching all packets on PF

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support to match all packets received on the underlying PF Note that the same 17-bit hardware tuple is shared between QinQ and PF match. Hence, match on either QinQ or PF only can be done at a time. Both QinQ and PF match can't be enabled at the same time. Also, remove ch

[dpdk-dev] [PATCH 2/9] net/cxgbe: add rte_flow support for matching IP TOS

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support to match Type of Service (TOS) field in IPv4/IPv6 header Signed-off-by: Karra Satwik Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/common.h | 1 + drivers/net/cxgbe/base/t4_hw.c | 1 + drivers/net/cxgbe/cxgbe_filter.c | 7 +- drivers/net/c

[dpdk-dev] [PATCH 0/9] net/cxgbe: updates for rte_flow support

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik This series of patches contain rte_flow support for matching Q-in-Q VLAN, IP TOS, PF, and VF fields. Also, adds Destination MAC rewrite and Source MAC rewrite actions. Apart from the 4-tuple (IP src/dst addresses and TCP/UDP src/dst port addresses), there are only 40-bits avai

[dpdk-dev] [PATCH 1/9] net/cxgbe: add rte_flow support for matching Q-in-Q VLAN

2020-03-11 Thread Rahul Lakkireddy
From: Karra Satwik Add support to match fields in 802.1ad Q-in-Q VLAN packets. Relax check for repeated pattern items for RTE_FLOW_ITEM_TYPE_VLAN item, since the same item is used to represent both QinQ and VLAN packets. When QinQ match is enabled, the ethertype field in the hardware spec must c

Re: [dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-11 Thread David Marchand
On Tue, Mar 10, 2020 at 5:38 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, March 10, 2020 4:31 PM > > To: Van Haaren, Harry > > Cc: dev ; Aaron Conole > > Subject: Re: [PATCH] eal/service: fix exit by resetting service lcores > > > > On

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-11 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gavin Hu > Sent: Wednesday, March 11, 2020 8:50 AM > > Hi Morten, > > > From: Morten Brørup > > Sent: Monday, March 9, 2020 9:31 PM > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > > Sent: Monday, March 9, 2020

Re: [dpdk-dev] Arm roadmap for 20.05

2020-03-11 Thread Mattias Rönnblom
On 2020-03-10 17:42, Honnappa Nagarahalli wrote: > Hello, > Following are the work items planned for 20.05: > > 1) Use C11 atomic APIs in timer library > 2) Use C11 atomic APIs in service cores > 3) Use C11 atomics in VirtIO split ring > 4) Performance optimizations in i40e and MLX drivers fo

Re: [dpdk-dev] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-03-11 Thread Gavin Hu
Hi Morten, > -Original Message- > From: Morten Brørup > Sent: Monday, March 9, 2020 9:31 PM > To: Ferruh Yigit ; Gavin Hu ; > dev@dpdk.org > Cc: nd ; david.march...@redhat.com; > tho...@monjalon.net; ktray...@redhat.com; jer...@marvell.com; > Honnappa Nagarahalli ; Ruifeng Wang > ; Phil Y

Re: [dpdk-dev] [PATCH] net/ixgbe: fix setting VF MAC address

2020-03-11 Thread Ye Xiaolong
Hi, Guinan On 03/10, Guinan Sun wrote: >This problem occurs because clear_rar is executed at the wrong time, > so PF cannot receive data normally. Could you elaborate what problem you've encountered, and how this patch solves it? Thanks, Xiaolong >This patch is used to modify the calling logic

[dpdk-dev] [PATCH v6] eal/arm64: fix rdtsc precise version

2020-03-11 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/ linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Fixes: ccad39ea0712 ("eal/arm: add cpu cy