The ice_memdup doesn't check the new allocated memory pointer, it calls
the rte_memcpy directly. It should check it.
Fixes: 5f0978e96220 ("net/ice/base: add OS specific implementation")
Cc: sta...@dpdk.org
Signed-off-by: Haiyue Wang
---
drivers/net/ice/base/ice_osdep.h | 16 +++-
1
> -Original Message-
> From: Zhang, Xiao
>
> Hi Ori,
>
> > -Original Message-
> > From: Ori Kam
> >
> > Hi Xiao,
> >
> > > -Original Message-
> > > From: Zhao1, Wei
> > >
> > > Hi, Ori
> > >
> > > > -Original Message-
> > > > From: Ori Kam
> > > >
> > > > Hi
From: Ophir Munk
> File mlx5_devx_cmds.c should contain pure DevX calls. It must be OS agnostic
> and not include any references to ibv or dv structs (defined in ibverbs and
> rdma-core linux libraries). This commit replaces all ibv and dv references
> with
> 'void *'. Specifically, the follo
The MLX5 device supports up to 256 MAC addresses.
The code flushes all MAC devices.
If DPDK is compiled with MLX5_DEBUG this would an assert.
PANIC in mlx5_nl_mac_addr_flush():
line 775assert "(size_t)(i) < sizeof(mac_own) * 8" failed
The root cause is that mac_own is a pointer and is bei
> -Original Message-
> From: Su, Simei
> Sent: Wednesday, March 18, 2020 1:42 PM
> To: Ye, Xiaolong ; Zhang, Qi Z
> Cc: dev@dpdk.org; Cao, Yahui ; Wu, Jingjing
> ; Su, Simei
> Subject: [PATCH 1/5] net/iavf: add support for FDIR basic rule
>
> This patch adds FDIR create/destroy/valid
> -Original Message-
> From: Su, Simei
> Sent: Wednesday, March 18, 2020 1:42 PM
> To: Ye, Xiaolong ; Zhang, Qi Z
> Cc: dev@dpdk.org; Cao, Yahui ; Wu, Jingjing
> ; Su, Simei
> Subject: [PATCH 5/5] net/iavf: add support for FDIR mark action
>
> This patch enables mark action support a
On Tue, Mar 31, 2020 at 10:12 AM Stephen Hemminger
wrote:
>
> Accidental use of PMD logtype rather than per-driver logtype.
>
> Fixes: 14255b351537 ("net/bnxt: fix queue start/stop operations")
> Cc: ajit.khapa...@broadcom.com
> Signed-off-by: Stephen Hemminger
> ---
> drivers/net/bnxt/bnxt_ring
The PMD logtype is a legacy from original DPDK logging.
All drivers must use their own dynamic log type.
Fixes: b1bc1afa4a0e ("net/pfe: support dynamic logging")
Cc: g.si...@nxp.com
Signed-off-by: Stephen Hemminger
---
drivers/net/pfe/pfe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
The PMD static logtype is original DPDK legacy and should not be used.
Fixes: 43362c6a7647 ("net/thunderx: support RSS and RETA query and update")
Cc: jerin.ja...@caviumnetworks.com
Signed-off-by: Stephen Hemminger
---
drivers/net/thunderx/nicvf_ethdev.c | 17 +
1 file changed, 9
The static PMD logtype should not be used by drivers.
Instead, use existing log macros in this driver.
Also use standard rte_ether routine to format ether address.
Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")
Cc: shreyansh.j...@nxp.com
Signed-off-by: Stephen Hemminger
---
dri
The PMD logtype is legacy and drivers should use their own logtype.
Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)")
Cc: ophi...@mellanox.com
Signed-off-by: Stephen Hemminger
---
drivers/net/tap/rte_eth_tap.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --g
Accidental use of PMD logtype rather than per-driver logtype.
Fixes: 14255b351537 ("net/bnxt: fix queue start/stop operations")
Cc: ajit.khapa...@broadcom.com
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
While working on netvsc driver, noticed that there are still some places
in some drivers using the old PMD static logtype. Would like to
eradicate all of these and even mark it as deprecated in a future
release.
Stephen Hemminger (7):
net/mvneta: do not use PMD logtype
net/virtio: do not use
Virtio driver has its own logtype adn should not use legacy
PMD logtype.
Signed-off-by: Stephen Hemminger
---
drivers/net/virtio/virtio_rxtx.c| 6 +++---
drivers/net/virtio/virtio_user_ethdev.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio/virt
The PMD logtype is legacy and should not be used.
Fixes: 3378383dceab ("net/mvneta: support statistics reset")
Cc: nsams...@marvell.com
Signed-off-by: Stephen Hemminger
---
drivers/net/mvneta/mvneta_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mvneta/m
On 03/31, Beilei Xing wrote:
>Add a new ops "redirect" to flow engine, it's used to implement the
>function that redirect a flow's destination. Currently only support
>VSI-Redirect which will be used by DCF for handling VF-VSI mapping
>table change.
>A new API "ice_flow_redirect" is exposed, curren
On 03/31, Beilei Xing wrote:
>This patchset adds flow redirect function, also supports
>flow ops thread safe
>
>V2 changes:
> - Rework commit log.
> - Make a patchset.
>
>Beilei Xing (2):
> net/ice: support flow redirect function
> net/ice: support flow ops thread safe
>
> drivers/net/ice/ice_eth
Hi Thomas,
As long as pmd or application doesn't access
dev->mem_resource[i].addr, secondary process works with igb_uio.
But for pci devices like crypto_qat, pmd checks for
dev->mem_resource[i].addr and bails out if the address is null.
Root cause is, not initializing the mapped address in rte_pci
06/03/2020 13:28, Ferruh Yigit:
> On 3/6/2020 12:02 AM, Vijaya Mohan Guvva wrote:
> > For pci devices presented through igb_uio, pcidev->mem_resource[] is
> > not populated when the device is initialized for secondary process.
> >
> > Initialize pcidev->mem_resource[] with pci-bar mapped addresses
27/03/2020 09:13, Olivier Matz:
> On Fri, Mar 20, 2020 at 03:55:15PM +, Alexander Kozyrev wrote:
> > Introduction of pinned external buffers doubled memory loads in the
> > rte_pktmbuf_prefree_seg() function. Analysis of the generated assembly
> > code shows unnecessary load of the pool field o
14/02/2020 09:24, Gaetan Rivet:
> On 14/02/2020 07:43, Somnath Kotur wrote:
> > As per the comments in this code section, since there is a matching device,
> > it is now its responsibility to manage the devargs we've just inserted.
> > But the matching device ptr's devargs is still uninitialized or
>
> > >
> > > > Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring
> > > >
> > > > Upfront note - that RFC is not a complete patch.
> > > > It introduces an ABI breakage, plus it doesn't update ring_elem
> > > > code properly,
> > > As per the current rules, these changes (in the current form)
> >
> > > Subject: [dpdk-dev] [RFC 0/6] New sync modes for ring
> > >
> > > Upfront note - that RFC is not a complete patch.
> > > It introduces an ABI breakage, plus it doesn't update ring_elem code
> > > properly,
> > As per the current rules, these changes (in the current form) will be
> > acc
> -Original Message-
> From: Medvedkin, Vladimir
> Sent: Thursday, March 26, 2020 9:47 AM
> To: dev@dpdk.org
> Cc: Wang, Yipeng1 ; Gobriel, Sameh
> ; Richardson, Bruce
>
> Subject: [PATCH v2 2/2] test: update hash performance tests
>
> Add preformance test for rte_hash_lookup_with_hash_b
> -Original Message-
> From: Medvedkin, Vladimir
> Sent: Thursday, March 26, 2020 9:47 AM
> To: dev@dpdk.org
> Cc: Wang, Yipeng1 ; Gobriel, Sameh
> ; Richardson, Bruce
>
> Subject: [PATCH v2 1/2] hash: add hash bulk lookup with hash signatures
> array
>
> Implement rte_hash_lookup_with_h
On 3/26/20 1:41 PM, Andrzej Ostruszka wrote:
> Thank you David for taking time to look at this.
>
> On 3/25/20 9:08 AM, David Marchand wrote:
>> Hello Andrzej,
>>
>> On Tue, Mar 10, 2020 at 12:11 PM Andrzej Ostruszka
> [...]
>> I can see we end up exposing structures for registering callbacks.
>
>
> 01/10/2019 08:29, Honnappa Nagarahalli:
> > This is not a new patch. This patch set is separated from the LPM
> > changes as the size of the changes in RCU library has grown due to
> > comments from community. These APIs will help reduce the changes in
> > LPM and hash libraries that are get
Hi
From: Benoit Ganne (bganne)
> > Why link speed is undefined?
> > Old kernel?
> > Kernel mlx5 driver issue?
> > Do you know?
>
> Seems to be a bug in kernel mlx5 driver:
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmails.
> dpdk.org%2Farchives%2Fusers%2F2020-
> March%2F00
> -Original Message-
> From: David Marchand
> Sent: Sunday, March 29, 2020 00:18
> To: Ruifeng Wang
> Cc: Aaron Conole ; Michael Santana
> ; Bruce Richardson
> ; Ananyev, Konstantin
> ; dev ; Burakov, Anatoly
> ; Gavin Hu ; Honnappa
> Nagarahalli ; nd
> Subject: Re: [PATCH v3 2/4] ci: g
From: Martin Spinler
The driver wrongly assumed the presence of at least one rxmac in every firmware
and accessed to non-existing unit
Signed-off-by: Martin Spinler
Acked-by: Jakub Neruda
diff --git a/drivers/net/nfb/nfb_rxmode.c b/drivers/net/nfb/nfb_rxmode.c
index 3327c8272..2d0b613d2 10064
From: Piotr Sieduszewski
Signed-off-by: Piotr Sieduszewski
---
usertools/dpdk-setup.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
index e5bbe9fee..c9660f950 100755
--- a/usertools/dpdk-setup.sh
+++ b/usertools/dpdk-setup
Some NIC hardware have private shaper attached to
every node and has a limitation where packet mode is applied
both to the scheduling of a node's children using WFQ and
shaping of traffic out of the private shaper.
This cannot be expressed using existing capabilities or configurations.
So this pat
Add TM command to enable packet mode for all SP children
in non leaf node. This is a new command as
"add tm nonleaf node pktmode".
This patch also dumps new tm capabilities
"sched_wfq_weight_mode_supported" and "sched_shaper_private_weight_mode".
Signed-off-by: Nithin Dabilpuram
---
app/test-pm
If core 0 is not included in coremask in event mode then
ipsec-secgw seg faults. This fix uses first core from
coremask in rx queue configuration instead of core 0
which was always previously used.
Signed-off-by: Lukasz Bartosik
---
examples/ipsec-secgw/ipsec-secgw.c | 2 +-
1 file changed, 1 in
When a port is handled by the i40evf dpdk pmd we could observe a cpu usage
around 70% in case of rte eth stats functions (rte_eth_stats_get and
rte_eth_xstats_get) called periodically via an application control thread.
This is due to the polling mechanism to handle communication between VF
and PF
On Fri, Mar 27, 2020 at 2:16 AM Thomas Monjalon wrote:
>
> Some clean-up is done in EAL sub-directories.
> The goal is to make organization easier to understand,
> and to prepare moving some files from common to Unix-only place.
>
> Since the kernel modules are moved to kernel/ directory,
> there
Hi Ori,
> -Original Message-
> From: Ori Kam
> Sent: Monday, March 30, 2020 4:57 PM
> To: Zhao1, Wei ; Zhang, Xiao ;
> dev@dpdk.org
> Cc: Wang, Ying A ; Zhang, Qi Z
> ; sta...@dpdk.org
> Subject: RE: app/testpmd: fix PPPOES flow API
>
> Hi Xiao,
>
> > -Original Message-
> > From
> Why link speed is undefined?
> Old kernel?
> Kernel mlx5 driver issue?
> Do you know?
Seems to be a bug in kernel mlx5 driver:
http://mails.dpdk.org/archives/users/2020-March/004758.html
I still think this test is too strict, and from what I can see mlx4 PMD do not
implement it (even if it use
On Thu, Mar 26, 2020 at 10:22:59AM +0100, Darek Stojaczyk wrote:
> Even when a PMD was disabled with meson's disable_drivers option
> its config file was still being parsed. Some of the PMD configs
> attempt to find a library they depend on and parse its header files
> with certain assumptions. If
Hi
From: Benoit Ganne
> Sent: Monday, March 30, 2020 3:03 PM
> To: Matan Azrad ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix link state update
>
> Hi Matan,
>
> mlx5 PMD refuses to update link state if link speed is defined but
> status is down or if link speed is un
> > +Developing Windows Drivers
> > +==
> > +
> > +Prerequisites
> > +-
> > +
> > +Building Windows Drivers is only possible on Windows.
> > +
> > +1. Visual Studio 2019 Community or Professional Edition
> > +2. Windows Driver Kit (WDK) for Windows 10, version 19
On Fri, Mar 27, 2020 at 2:17 AM Thomas Monjalon wrote:
>
> The EAL API (with doxygen documentation) is moved from
> common/include/ to include/, which makes more clear that
> it is the global API for all environments and architectures.
>
> Note that the arch-specific and OS-specific include files
Hi,
> -Original Message-
> From: Dekel Peled
> Sent: Sunday, March 29, 2020 12:18 PM
> To: Matan Azrad ; Slava Ovsiienko
> ; Raslan Darawsheh
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix RSS key copy to TIR context
>
> In function mlx5_devx_cmd_create_tir(), t
On Sun, Mar 29, 2020 at 08:13:10PM +0530, jer...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Add libatomic as a global dependency when compiling for 32-bit using
> clang. As we need libatomic for 64-bit atomic ops.
>
> Cc: bruce.richard...@intel.com
> Signed-off-by: Pavan Nikhilesh
> ---
>
This patch adds CPU flags which will enable the detection of ISA
features available on more recent x86 based CPUs.
The CPUID leaf information can be found in Section 1.7 of this
document:
https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programmi
Hi Matan,
mlx5 PMD refuses to update link state if link speed is defined but
status is down or if link speed is undefined but status is up, even
if the ioctl() succeeded.
This prevents application to detect link up/down event, especially
when the link speed is not correctl
Add support for PFCP, L2TP, ESP and AH RSS enabling.
Signed-off-by: Ting Xu
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_bitops.h| 31 ++
drivers/net/ice/base/ice_flow.c | 163 +--
drivers/net/ice/base
Take network order for gtpu fdir filter.
Fixes: b5c274f4e2ad ("net/ice/base: support FDIR for GTPU QFI field")
Cc: sta...@dpdk.org
Signed-off-by: Ting Xu
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.h | 6 +++---
1 file changed, 3 insertions(+),
This patch add support switch rule for PFCP and NAT-T
packet base on profile rule, PFCP and NAT-T packet will not
be matched on any packet fields, but instead matches
the profile that the packet hits in the switch block.
Signed-off-by: Wei Zhao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Q
Change ice_set_fd_desc_val to static, since it only be used
internally.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.c | 97 +++--
drivers/net/ice/base/ice_fdir.h | 3 --
2 files cha
A GTPU header can stack with a extend header or not, while
current implementation does not allow HDR bit sets like below:
ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_GTPU_EH
ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_GTPU_UP
ICE_FLOW_SEG_HDR_GTPU_IP | ICE_FLOW_SEG_HDR_GTPU_DWN
Which is not conve
Switch rules usually match packet fields to take actions. Add capability
to add a switch rule that does not match any packet fields, but instead
matches the profile that the packet hits in the switch block.
Signed-off-by: Dan Nowlin
Signed-off-by: Wei Zhao
Signed-off-by: Paul M Stillwell Jr
Sig
Added new value for cmd_flag:
Persistently set the DCB configuration mode for the current port.
Added new value for valid_flags: represent bit#1 of command flag
Signed-off-by: Sharon Haroni
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_adminq_cmd.h | 2 ++
1 file changed, 2 insertions(
Move some macro from ice_switch.c to ice_switch.h. Currently this
is only required by kernel driver, DPDK just to sync the code.
Signed-off-by: Xiao Zhang
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 22 --
drivers/net/i
A race condition between FW and SW can occur between admin queue setup and
the first command sent. A link event may occur and FW attempts to notify a
non-existent queue. FW will set the critical error bit and disable the
queue. When this happens retry queue setup.
Signed-off-by: Evan Swanson
Sign
We will remove the logic of configuring the flow control out of the
ice_set_fc(...) function. The goal is to enable any driver to combine
all PHY related flow logic, without repeatedly call ice_aq_set_phy_cfg.
Signed-off-by: Chinh T Cao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
ICE_BLK_FD and ICE_BLK_RSS are executing the same code so group the case
statements together instead of duplicating code for each block.
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_flow.c | 11 ++-
1 file changed, 2
Add new API function to allow user to choose port
on which mac vlan rule going to be added.
Signed-off-by: Michal Swiatkowski
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 58 +++
1 file changed, 46 insert
In order to support switch rule for ethertype filter
with ipv6 ethertype id, it has to check ethertype
then find a proper dummy packet.
Signed-off-by: wei zhao
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_switch.c | 7 +++
1 file changed, 7 insert
The scope of these variables can be reduced, so do so. This also eliminates
the need for the extra wrapping/braces.
Also, compact a line since it can fit within 80 columns
Signed-off-by: Tony Nguyen
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common
When setting the PHY cfg (CQ cmd 0x0601), if the firmware responds
with an EMODE error, software will ignore the error as it simply
means that manageability (ex: BMC) is in control of the link and that
the new setting may not be applied.
Signed-off-by: Chinh T Cao
Signed-off-by: Paul M Stillwell
Add macro for FDID priroty 0 and 3, also adjust the
fdid_prio position to sync with kernel driver.
Signed-off-by: Beilei Xing
Signed-off-by: Paul M Stillwell Jr
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_fdir.h | 2 +-
drivers/net/ice/base/ice_lan_tx_rx.h | 2 ++
2 files change
Main changes:
1. Add PFCP / ESP / AH / L2TP support for switch
2. Add PFCP / ESP / AH / L2TP support for RSS.
3. Improve GTPU extend header handle.
4. minor fix and code clean.
Qi Zhang (16):
net/ice/base: add more macro for FDID priority
net/ice/base: reduce scope of variables
net/ice/base
Xilinx acquired Solarflare in 2019.
Signed-off-by: Andrew Rybchenko
Acked-by: James Fox
---
doc/guides/nics/sfc_efx.rst | 4 ++--
drivers/net/sfc/Makefile| 4 ++--
drivers/net/sfc/base/README | 4 ++--
drivers/net/sfc/base/ef10_ev.
From: Igor Romanov
Unknown unicast filter creation may fail because of insufficient
permissions on VF. This failure is handled internally in libefx MAC
reconfiguration without any way for a user to know if it happened.
Making the MAC reconfiguration forward error code of filter
reconfiguration wo
From: Igor Romanov
Refactor the filters cleanup stage of the reconfigure function
to make it clearer and allow for more convenient further changes.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/base/ef10_filter.c | 44 ++
1 file ch
From: Igor Romanov
Refactor the multicast filter reconfiguration stage of the reconfigure
function to make it clearer and allow for more convenient further
changes.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/base/ef10_filter.c | 143 +++
From: Igor Romanov
Refactor the unicast filter reconfiguration stage of the reconfigure
function to make it clearer and allow for more convenient further
changes.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/base/ef10_filter.c | 83 --
VFs (as well as unpriviledged PFs) are not always allowed to
enable promiscuous and all-multicast. Handle it properly and
ensure consistency for settings applied and reported.
Base driver patches have warnings/errors from checkpatch.sh
since coding style differs a bit.
Return of non-negative errn
From: Igor Romanov
Check that unknown unicast and unknown multicast filters are
applied and return an error if they are not applied. The error
is used in promiscuous and all multicast mode enable and disable
callbacks.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
---
drivers/ne
From: Igor Romanov
Refactor the filters mark stage of the reconfigure function
to make it clearer and allow for more convenient further changes.
Signed-off-by: Igor Romanov
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/base/ef10_filter.c | 34 +++---
1 file chang
Hi Jeff,
My name is Ori 😊
I'm not an expert in GTP so this is just my thinking and maybe I'm
missing something, this is why a good explanation helps 😊
> -Original Message-
> From: Jeff Guo
> Sent: Monday, March 30, 2020 11:30 AM
> To: Ori Kam ; xiaolong...@intel.com;
> qi.z.zh...@intel.
Hi
From: Benoit Ganne (bganne)
> > From: Matan Azrad
>
> >> From: Benoît Ganne
> >> mlx5 PMD refuses to update link state if link speed is defined but
> >> status is down or if link speed is undefined but status is up, even
> >> if the ioctl() succeeded.
> >> This prevents application to detect
> From: Matan Azrad
>> From: Benoît Ganne
>> mlx5 PMD refuses to update link state if link speed is defined but
>> status is down or if link speed is undefined but status is up,
>> even if the ioctl() succeeded.
>> This prevents application to detect link up/down event, especially
>> when the lin
FVL enable src MAC address and dst MAC address as FDIR's input set
for ipv4-other. When OVS-DPDK is working as a pure L2 switch, enable
MAC address as FDIR input set with Mark+RSS action would help the
performance speed up. And FVL FDIR supports to change input set with
MAC address.
Signed-off-by:
Hi Xiao,
> -Original Message-
> From: Zhao1, Wei
> Sent: Monday, March 30, 2020 11:50 AM
> To: Ori Kam ; Zhang, Xiao ;
> dev@dpdk.org
> Cc: Wang, Ying A ; Zhang, Qi Z
> ; sta...@dpdk.org
> Subject: RE: app/testpmd: fix PPPOES flow API
>
> Hi, Ori
>
> > -Original Message-
> > Fro
Hi, Ori
> -Original Message-
> From: Ori Kam
> Sent: Monday, March 30, 2020 3:43 PM
> To: Zhang, Xiao ; dev@dpdk.org
> Cc: Wang, Ying A ; Zhang, Qi Z
> ; Zhao1, Wei ;
> sta...@dpdk.org
> Subject: RE: app/testpmd: fix PPPOES flow API
>
> Hi Xiao
>
> > -Original Message-
> > From:
This patch set added generic flow APIs and supported patterns includes:
/* L2 */
/* ARP */
/* IPv4 */
/* IPv6 */
/* GTPU */
/* ESP */
/* AH */
/* L2TPV3 */
/* PFCP */
---
v2 changes:
- fixed document error.
- fixed multiple thread not safe issue.
- use RTE_ASSERT to replace runtime check for e
Add patterns support for AH/ESP/L2TPV3OIP/PFCP.
Added patterns are as follows:
/* GTPU */
eth/ipv4/udp/gtpu
eth/ipv4/udp/gtpu/gtp_psc
/* ESP */
eth/ipv4/esp eth/ipv4/udp/esp
eth/ipv6/esp eth/ipv6/udp/esp
/* AH */
eth/ipv4/ah eth/ipv6/ah
/* L2TPV3 */
eth/ipv4/l2tpv3oip et
This patch added iavf_flow_create, iavf_flow_destroy,
iavf_flow_flush and iavf_flow_validate support,
these are used to handle all the generic filters.
This patch supported basic L2, L3, L4 and GTPU patterns.
Signed-off-by: Qiming Yang
---
doc/guides/rel_notes/release_20_05.rst | 6 +
drivers
Add a new ops "redirect" to flow engine, it's used to implement the
function that redirect a flow's destination. Currently only support
VSI-Redirect which will be used by DCF for handling VF-VSI mapping
table change.
A new API "ice_flow_redirect" is exposed, current usage is: it could
be called whe
For DCF, flow ops may be executed in different threads,
so an thread safe option for generic flow APIs is needed.
Signed-off-by: Beilei Xing
Signed-off-by: Qi Zhang
---
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_generic_flow.c | 35 +++
2 file
This patchset adds flow redirect function, also supports
flow ops thread safe
V2 changes:
- Rework commit log.
- Make a patchset.
Beilei Xing (2):
net/ice: support flow redirect function
net/ice: support flow ops thread safe
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_g
hi, orika
On 3/29/2020 4:44 PM, Ori Kam wrote:
Hi Jeff,
-Original Message-
From: dev On Behalf Of Jeff Guo
Sent: Thursday, March 26, 2020 6:41 PM
To: xiaolong...@intel.com; qi.z.zh...@intel.com
Cc: dev@dpdk.org; jingjing...@intel.com; yahui@intel.com;
simei...@intel.com; jia
Bugzilla ID: 423
Cc: sta...@dpdk.org
Signed-off-by: Sarosh Arif
---
usertools/dpdk-setup.sh | 8
1 file changed, 8 insertions(+)
diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
index e5bbe9fee..d7e4bc43d 100755
--- a/usertools/dpdk-setup.sh
+++ b/usertools/dpdk-setup.sh
@
> -Original Message-
> From: Xing, Beilei
> Sent: Tuesday, March 31, 2020 00:43
> To: dev@dpdk.org; Wang, Haiyue ; Yang, Qiming
> ; Zhang, Qi Z
> Subject: [PATCH] net/ice: support flow ops thread safe
>
> For DCF, flow ops may be executed in different threads, so an thread safe
> opti
> -Original Message-
> From: Xing, Beilei
> Sent: Tuesday, March 31, 2020 00:38
> To: dev@dpdk.org; Wang, Haiyue ; Yang, Qiming
> ; Zhang, Qi Z
> Subject: [PATCH] net/ice: support flow redirect function
>
> Add a new ops "redirect" to flow engine, it's used to implement the function
>
This patch adds a support of VIRTIO_NET_F_SPEED_DUPLEX feature
for virtio driver.
There are few ways to specify speed of the link:
'speed' devarg
negotiate speed from qemu via VIRTIO_NET_F_SPEED_DUPLEX
The highest priority is devarg. If devarg is not specified,
drivers tries to negotiate it
strtoull returns 0 if it fails to parse input string. It's ignored
in get_integer_arg.
This patch handles error cases for strtoull function.
Signed-off-by: Ivan Dyukov
---
drivers/net/virtio/virtio_user_ethdev.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/d
virtio driver already parses speed devarg. virtio-user should add
it to list of valid devargs and call eth_virtio_dev_init function
which init speed value.
eth_virtio_dev_init already is called from virtio_user_pmd_probe
function. The only change is required to enable speed devargs:
adding speed t
refactor vdpa specific devargs parsing to more generic way
Signed-off-by: Ivan Dyukov
---
drivers/net/virtio/virtio_ethdev.c | 34 +-
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev
v8 changes:
* fix code style
v7 chagnes:
* rebased to latest master
* added support of VIRTIO_NET_F_SPEED_DUPLEX
v6 changes:
* fix code style
v5 changes:
* fixed code style
* fixed commit message and logging text
v4 changes:
* link_speed renamed to speed devarg
* speed devarg is added to virt
Some applications like pktgen use link speed to calculate
transmission rate. It limits outcome traffic to hardcoded 10G.
This patch adds speed devarg which allows to configure
link speed of virtio device.
Signed-off-by: Ivan Dyukov
---
doc/guides/nics/virtio.rst | 7 +++
drivers/net/vi
implement set hash global configurations, set symmetric hash enable
and set hash input set in rte flow API.
Signed-off-by: Chenxu Di
---
v6:
-Modified the docs and various name.
v5:
-Modified the doc i40e.rst and various name.
v4:
-added check for l3 pctype with l4 input set.
v3:
-modified the d
For DCF, flow ops may be executed in different threads,
so an thread safe option for generic flow APIs is needed.
Signed-off-by: Beilei Xing
Signed-off-by: Qi Zhang
---
drivers/net/ice/ice_ethdev.h | 1 +
drivers/net/ice/ice_generic_flow.c | 35 +++
2 file
Add a new ops "redirect" to flow engine, it's used to implement the
function that redirect a flow's destination. Currently only support
VSI-Redirect which will be used by DCF for handling VSI mapping table
change.
A new API "ice_flow_redirect" is exposed, current usage is: it could
be called when V
Hi Xiao
> -Original Message-
> From: Zhang, Xiao
> Sent: Monday, March 30, 2020 5:09 AM
> To: Ori Kam ; dev@dpdk.org
> Cc: Wang, Ying A ; Zhang, Qi Z
> ; Zhao1, Wei ; sta...@dpdk.org
> Subject: RE: app/testpmd: fix PPPOES flow API
>
> Hi Ori,
>
> > -Original Message-
> > From: O
Hi, Wei
Thanks for identifying the root cause.
On 03/30, Wei Zhao wrote:
>An issue has been caused after change definations of bool,
>we had better use uint16_t to define e-tag ethertype, not 8
>bits length bool, that patch will change bool bits length, which
>introduce a bug for etag/etag_strip
30/03/2020 06:10, Dmitry Kozlyuk:
> +/**
> + * Lock region in physical memory and prevent it from swapping.
> + *
> + * @param virt
> + * The virtual address.
> + * @param size
> + * Size of the region.
> + * @return
> + * 0 on success, negative on error.
> + */
> +__rte_experimental
> +int r
On Mon, Mar 30, 2020 at 9:41 AM Dmitry Kozlyuk wrote:
>
> EAL common code uses file locking and truncation. Introduce
> OS-independent wrapeprs in order to support both POSIX and Windows:
>
> * eal_file_lock: lock or unlock an open file.
> * eal_file_truncate: enforce a given size for an open file
100 matches
Mail list logo
