On Tue, Apr 14, 2020 at 7:02 PM Jerin Jacob wrote:
>
> On Tue, Apr 14, 2020 at 6:41 PM Mattias Rönnblom
> wrote:
> >
> > On 2020-04-14 14:45, Jerin Jacob wrote:
> > > On Sat, Apr 4, 2020 at 6:05 PM Jerin Jacob wrote:
> > >> On Fri, Mar 6, 2020 at 11:35 AM Venky Venkatesh
> > >> wrote:
> > >>> H
On 30-Apr-20 6:38 PM, David Christensen wrote:
Why is this needed?
It's hardware specific to the PPC64 platform. I don't know of a
situation where the IOMMU would be present on other hardware. Even
running a VM in KVM/QEMU on a PPC64 platform results in a SPAPR V1
IOMMU which isn't support
On 30-Apr-20 6:36 PM, David Christensen wrote:
On 4/30/20 4:34 AM, Burakov, Anatoly wrote:
On 30-Apr-20 12:29 AM, David Christensen wrote:
Current SPAPR IOMMU support code dynamically modifies the DMA window
size in response to every new memory allocation. This is potentially
dangerous becaus
On 5/1/2020 7:51 AM, Matan Azrad wrote:
> Hi Ferruh
>
> From: Ferruh Yigit
>> On 4/30/2020 4:53 PM, Bill Zhou wrote:
>>> Currently, there is no way to check the aging event or to get the
>>> current aged flows in testpmd, this patch include those implements, it's
>> included:
>>> - Registering agi
>
> The rte_wait_until_equal_xxx APIs abstract the functionality of 'polling
> for a memory location to become equal to a given value'[1].
>
> Use the API for the rte spinlock and ring implementations.
>
> [1] http://patches.dpdk.org/cover/62703/
>
> Gavin Hu (2):
> spinlock: use wfe to reduc
From: Amit Gupta
On detecting outer L4 checksum as bad, both outer and
inner checksums are marked as bad. No need to explicitly
check inner L4 checksum in this case.
Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
and PKT_RX_L4_CKSUM_BAD
Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_B
>Subject: [dpdk-dev] [PATCH v4] mempool/octeontx2: add devargs to
>lock ctx in cache
>
>From: Pavan Nikhilesh
>
>Add device arguments to lock NPA aura and pool contexts in NDC cache.
>The device args take hexadecimal bitmask where each bit represent the
>corresponding aura/pool id.
>Example:
>
On 4/29/2020 10:03 AM, Bruce Richardson wrote:
> On Wed, Apr 29, 2020 at 09:45:44AM +0100, Dumitrescu, Cristian wrote:
>>
>>
>>> -Original Message-
>>> From: Thomas Monjalon
>>> Sent: Tuesday, April 28, 2020 4:54 PM
>>> To: Jerin Jacob ; Dumitrescu, Cristian
>>>
>>> Cc: Richardson, Bruce
On Thu, 2020-04-30 at 17:43 -0300, Dan Gora wrote:
> On Thu, Apr 30, 2020 at 5:29 PM Luca Boccassi wrote:
>
> > > > Adding a new dependecy happens only when building with the new version
> > > > of the library. If it's not available, then there's no new dependency.
> > >
> > > But you also do no
>
> When fragmenting ipv4 packet, the data offset should be calculated through
> the ihl field in ip header rather than using sizeof(struct
> rte_ipv4_hdr).
Patch looks good to me...
Though by some reason I couldn't find it at DPDK patchwork...
http://patches.dpdk.org/project/dpdk/list/
Did y
This commit fixes failures of the flow_classify_autotest when
ran on dual-socket servers, as the sample application does not
support more than a single socket. Increasing the NB_SOCKETS
value allows the test to run successfully.
Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Signed-of
>When eth port queue is removed from Rx adapter using
>rte_event_eth_rx_adapter_queue_del() it incorrectly
>initializes CQ context instead of modifying it. This
>might lead to a crash when CQ context is modified
>as a part of rte_eth_dev_stop() sequence as CQ will
>hold invalid entries. This is res
>Subject: [PATCH] examples/l3fwd: fix error checking
>
>Patch fixes coverity issues which handle return values from AP
>calling.
>
>Coverity issue: 354227, 354232, 354238, 354239, 354240
>
>Fixes: aaf58cb85b62 ("examples/l3fwd: add event port and queue
>setup")
>
>Signed-off-by: Sunil Kumar Kori
On Fri, Apr 17, 2020 at 12:53 PM Nithin Dabilpuram
wrote:
>
> From: Nithin Dabilpuram
>
> Introduce PKT_TX_MARK_IP_DSCP, PKT_TX_MARK_IP_ECN
> and PKT_TX_MARK_VLAN_DEI Tx offload flags to support
> packet marking.
>
> When packet marking feature in Traffic manager is enabled,
> application has to
Hi Ferruh
From: Ferruh Yigit:
> On 5/1/2020 7:51 AM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigit
> >> On 4/30/2020 4:53 PM, Bill Zhou wrote:
> >>> Currently, there is no way to check the aging event or to get the
> >>> current aged flows in testpmd, this patch include those implem
On 4/30/2020 7:59 AM, ssar...@amd.com wrote:
> From: Sardar Shamsher Singh
>
> adding below APIs for axgbe
> - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping
> - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping
> - axgbe_enable_rx_vlan_filtering: to enable vlan fil
rte_bus_scan API scans all the available PCI devices irrespective of white
or black listing parameters then further devices are probed based on white
or black listing parameters. So unnecessary CPU cycles are wasted during
rte_pci_scan.
For Octeontx2 platform with core frequency 2.4 Ghz, rte_bus_s
On 5/1/2020 12:08 PM, Harry van Haaren wrote:
> This commit fixes failures of the flow_classify_autotest when
> ran on dual-socket servers, as the sample application does not
> support more than a single socket. Increasing the NB_SOCKETS
> value allows the test to run successfully.
>
> Fixes: 9c9b
On 5/1/2020 12:28 PM, Matan Azrad wrote:
>
> Hi Ferruh
>
> From: Ferruh Yigit:
>> On 5/1/2020 7:51 AM, Matan Azrad wrote:
>>> Hi Ferruh
>>>
>>> From: Ferruh Yigit
On 4/30/2020 4:53 PM, Bill Zhou wrote:
> Currently, there is no way to check the aging event or to get the
> current aged
Hello Gaeten,
I have validated hotplug functionality using multi process hotplug application.
Devices are being attached and detached at runtime properly.
Regards
Sunil Kumar Kori
>-Original Message-
>From: Sunil Kumar Kori
>Sent: Friday, May 1, 2020 5:09 PM
>To: step...@networkplumber.
From: Ferruh Yigit:
> On 5/1/2020 12:28 PM, Matan Azrad wrote:
> >
> > Hi Ferruh
> >
> > From: Ferruh Yigit:
> >> On 5/1/2020 7:51 AM, Matan Azrad wrote:
> >>> Hi Ferruh
> >>>
> >>> From: Ferruh Yigit
> On 4/30/2020 4:53 PM, Bill Zhou wrote:
> > Currently, there is no way to check the ag
Aaron Conole writes:
> Honnappa Nagarahalli writes:
>
>> test_ring.c takes lot of time to compile with clang. It is
>> reproducable with compiler version 8.0 on Ubuntu 18.04.
>> Amount of testing is reduced, but attempt is made to keep
>> the same coverage.
>>
>> Reported-by: Aaron Conole
>> Re
On 4/27/20 12:57 PM, Ivan Dyukov wrote:
From: Thomas Monjalon
When querying the link informations, the link status is
a mandatory major information.
Other boolean values are supposed to be accurate:
- duplex mode (half/full)
- negotiation (auto/fixed)
This API update is making
On 4/27/20 12:57 PM, Ivan Dyukov wrote:
Signed-off-by: Ivan Dyukov
---
app/test-pmd/testpmd.c | 2 +-
app/test/test_pmd_perf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 99bacddbf..d4df23a93 100644
--- a/app/
On Fri, May 01, 2020 at 11:27:02AM +0100, Ferruh Yigit wrote:
> External Email
>
> --
> On 4/29/2020 10:03 AM, Bruce Richardson wrote:
> > On Wed, Apr 29, 2020 at 09:45:44AM +0100, Dumitrescu, Cristian wrote:
> >>
> >>
> >>> -
Hi Akhil,
> -Original Message-
> From: dev On Behalf Of Akhil Goyal
> Sent: Wednesday, April 22, 2020 2:44 PM
> To: Coyle, David ; Doherty, Declan
> ; Thomas Monjalon ;
> Yigit, Ferruh ; Trahe, Fiona
> Cc: techbo...@dpdk.org; dev@dpdk.org; De Lara Guarch, Pablo
> ; Ryan, Brendan
> ; Hema
On Tue, Apr 28, 2020 at 9:24 PM Thomas Monjalon wrote:
>
> 28/04/2020 17:04, Luca Boccassi:
> > On Tue, 2020-04-28 at 15:45 +0100, Bruce Richardson wrote:
> > > On Tue, Apr 28, 2020 at 03:06:20PM +0100, Ferruh Yigit wrote:
> > > > On 4/27/2020 5:59 PM, Jerin Jacob wrote:
> > > > > On Mon, Apr 27,
On Mon, Apr 27, 2020 at 11:40 PM wrote:
>
> From: Pavan Nikhilesh
>
> When probing event device in secondary process skip reinitializing
> the device data structure as it is already done in primary process.
>
> When removing event device in secondary process skip closing the
> event device as it
On 4/27/20 12:57 PM, Ivan Dyukov wrote:
Signed-off-by: Ivan Dyukov
---
doc/guides/sample_app_ug/link_status_intr.rst | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/link_status_intr.rst
b/doc/guides/sample_app_ug/link_status_intr.rst
index 5283b
On 5/1/2020 1:45 PM, Matan Azrad wrote:
>
>
> From: Ferruh Yigit:
>> On 5/1/2020 12:28 PM, Matan Azrad wrote:
>>>
>>> Hi Ferruh
>>>
>>> From: Ferruh Yigit:
On 5/1/2020 7:51 AM, Matan Azrad wrote:
> Hi Ferruh
>
> From: Ferruh Yigit
>> On 4/30/2020 4:53 PM, Bill Zhou wrote:
>>>
When fragmenting ipv4 packet, the data offset should be calculated through the
ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
Fixes: a7c528e5d71f ("net: add rte prefix to IP structure")
Cc: olivier.m...@6wind.com
Cc: sta...@dpdk.org
Signed-off-by: Pu Xu <583493...@qq.com>
This set fixes a number of minor issues with static builds when using
meson, both for linking apps/examples as part of a meson build itself or
when using pkg-config subsequently.
Following this patchset, all DPDK static builds should be linking with
--whole-archive to ensure all lib and driver con
Since all libraries are explicitly linked as part of a build, we no longer
need to track ones that should be always included for linking against apps.
Previously telemetry was special-cased for linking as it was not directly
needed by the linker when linking the apps, since they never called into
Ahead of changes to rework the file, move the pkg-config file generation to
a new directory under buildtools. This allows the meson code to be
separated out from the main meson.build for simplicity, and also allows any
additional scripts for working with the pkg-config files to be placed there
too.
When calling pkg-config --static --libs, pkg-config will always output the
regular libs first, and then the extra libs from libraries.private field,
since the assumption is that those are additional dependencies for building
statically that the .a files depend upon.
However, for DPDK, we only link
To ensure all constructors are included in static build, we need to pass
the --whole-archive flag when linking, which is used with the
"link_whole" meson option. Since we use link_whole for all libs, we no
longer need to track the lib as part of the static dependency, just the
path to the headers f
The pkg-config file was tested by building some of the examples using make,
pulling the cflags and ldflags from the pkg-config file for DPDK. However,
this only tested the shared library linkage, and not the static, so this
patch updates it to test both.
Signed-off-by: Bruce Richardson
---
devto
Rather than setting -Bstatic in the linker flags when doing a static link,
and then having to explicitly set -Bdynamic again afterwards, we can update
the pkg-config file to use -l:libfoo.a syntax to explicitly refer to the
static library in question. Since this syntax is not supported by meson's
p
Hi Vamsi & Pavan,
I like this idea, couple of queries
snipped
> +static int
> +check_port_pair_config(void)
> +{
> + uint32_t port_pair_config_mask = 0;
> + uint32_t port_pair_mask = 0;
> + uint16_t index, i, portid;
> +
> + for (index = 0; index < nb_port_pair_params; index++) {
Add the --as-needed linker flag to the DPDK library list in the pkg-config
file so as to prevent overlinking. Without this flag, when linking
statically using flags from $(pkg-config --static --libs libdpdk), all DPDK
drivers and libs were statically linked in, but the binary was also
requiring all
On Fri, 2020-05-01 at 14:53 +0100, Bruce Richardson wrote:
> This set fixes a number of minor issues with static builds when using
> meson, both for linking apps/examples as part of a meson build itself or
> when using pkg-config subsequently.
>
> Following this patchset, all DPDK static builds sh
On 4/28/2020 2:37 PM, Andrew Rybchenko wrote:
> Fixes: 4f12e20c85dc ("net/sfc/base: introduce EVB module for SR-IOV")
> Fixes: 18c8e84d7726 ("net/sfc/base: support proxy auth operations for SR-IOV")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Andrew Rybchenko
Series applied to dpdk-next-net/master,
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Wednesday, April 29, 2020 11:49 PM
> To: Van Haaren, Harry ; Phil Yang
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, Konstantin
> ; jer...@marvell.com;
> hemant.agra...@nxp.com; Gavin Hu ; nd
> ; st
From: Nithin Dabilpuram
Due to an errata red algo needs to be set to discard instead of stall
for 96XX C0 silicon for two rate shaping. This workaround is being
already handled for newly created hierarchy but not for dynamic
shaper update cases. This patch hence applies the workaround
even when f
> On Apr 30, 2020, at 11:01 AM, Power, Ciara wrote:
>
> v5:
> - General cleanup to address comments on v4 patchset.
>
> v4:
> - Internal representation now uses generic data format instead of JSON.
> - Help command added to provide help text for a command.
>
> v3:
> - Removed rte_option
On 4/24/2020 7:50 AM, Ruifeng Wang wrote:
> vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
> the intrinsic.
>
> Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Ruifeng Wang
> Reviewed-by: Gavin Hu
This fixes bui
> >
> > > > Subject: [PATCH v2 1/6] service: fix race condition for MT unsafe
> > > > service
> > > >
> > > > From: Honnappa Nagarahalli
> > > >
> > > > The MT unsafe service might get configured to run on another core
> > > > while the service is running currently. This might result in the
> > >
On 4/24/2020 7:50 AM, Ruifeng Wang wrote:
> Expand vector PMD support to aarch32.
>
> Signed-off-by: Ruifeng Wang
> Reviewed-by: Gavin Hu
> ---
> drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers
On 4/24/2020 7:50 AM, Ruifeng Wang wrote:
> Build aarch32 binary on aarch64 platform hit issues with l3fwd [1]
> and ixgbe PMD [2]. This patch set is to fix these.
>
> When building with make, please refer to guide:
> http://patches.dpdk.org/patch/62820/
>
> When building with meson, requires ser
The autotest application build was partially enabled for building with
the net/bond driver disabled, but a number of items were missed, leading
to build errors when the driver was disabled, e.g. by simply doing
"-Ddisable_drivers=net/*" when calling meson.
../app/test/test_link_bonding.c:25:10:
>Hi Vamsi & Pavan,
>
>I like this idea, couple of queries
>
>snipped
>> +static int
>> +check_port_pair_config(void)
>> +{
>> +uint32_t port_pair_config_mask = 0;
>> +uint32_t port_pair_mask = 0;
>> +uint16_t index, i, portid;
>> +
>> +for (index = 0; index < nb_port_pair_params;
From: Ferruh Yigit:
> On 5/1/2020 1:45 PM, Matan Azrad wrote:
> >
> >
> > From: Ferruh Yigit:
> >> On 5/1/2020 12:28 PM, Matan Azrad wrote:
> >>>
> >>> Hi Ferruh
> >>>
> >>> From: Ferruh Yigit:
> On 5/1/2020 7:51 AM, Matan Azrad wrote:
> > Hi Ferruh
> >
> > From: Ferruh Yigit
> >
On 4/8/2020 9:28 AM, Michal Krawczyk wrote:
> Although the RSS key still cannot be set, it is now being generated
> every time the driver is being initialized.
>
> Multiple devices can still have the same key if they're used by the same
> driver.
>
> Signed-off-by: Michal Krawczyk
> Reviewed-by:
Hi,
> When fragmenting ipv4 packet, the data offset should be calculated through
> the ihl field in ip header rather than using sizeof(struct
> rte_ipv4_hdr).
There are few checkpatch errro/warnings:
http://mails.dpdk.org/archives/test-report/2020-May/129803.html
please fix.
>
> Fixes: a7c528e
On 11/20/2019 3:48 AM, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Sync mail box data structures to version 1.1.3.
> Add mail box version verification and defer initializing octeontx
> devices if mail box version mismatches.
> Update OCTEON TX limitaion with max mempool size used.
On 5/1/2020 4:14 PM, Matan Azrad wrote:
>
>
> From: Ferruh Yigit:
>> On 5/1/2020 1:45 PM, Matan Azrad wrote:
>>>
>>>
>>> From: Ferruh Yigit:
On 5/1/2020 12:28 PM, Matan Azrad wrote:
>
> Hi Ferruh
>
> From: Ferruh Yigit:
>> On 5/1/2020 7:51 AM, Matan Azrad wrote:
>>> H
On 4/27/2020 6:13 PM, Jasvinder Singh wrote:
> For sending request messages to data plane threads, the
> caller invokes thread_msg_send_recv() function which never
> returns null response. Thus, removed redundant check on
> the returned response.
>
> Coverity Issue: 357717, 357772
> Fixes: 70709c7
On 4/27/2020 6:15 PM, Jasvinder Singh wrote:
> For sending request messages to data plane threads, the
> caller invokes pipeline_msg_send_recv() function which never
> returns null response. Thus, removed redundant check on
> the returned response.
>
> Coverity Issues: 357676, 357680, 357681, 3576
Add a performance test to the service run on app lcore auto-
test. This test runs the service in a tight loop, and measures
cycles passed, printing the results. It provides a quick cycle
cost value, enabling measuring performance of the function to
run a service on an application lcore.
Signed-off
On 4/27/2020 10:39 PM, Stephen Hemminger wrote:
> The TAP driver does not initialize all the elements of the rte_flow
> structure. This can lead to crash in rte_flow_destroy.
>
> (gdb) where
> flow=0x100e99280, error=0x0)
> at drivers/net/tap/tap_flow.c:1514
>
> (gdb) p remote_flow
> $1 =
On 4/29/2020 1:42 PM, Ferruh Yigit wrote:
> On 4/29/2020 7:41 AM, oulijun wrote:
>>
>>
>> 在 2020/4/27 21:27, Ferruh Yigit 写道:
>>> On 4/27/2020 1:49 PM, Andrew Rybchenko wrote:
On 4/27/20 3:34 PM, Lijun Ou wrote:
> When rte api checks the Rx RSS distribution is enable but the RSS
> hash
When fragmenting ipv4 packet, the data offset should be calculated through
the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper
library")
Cc: anatoly.bura...@intel.com
Cc: sta...@dpdk.org
---
lib/librte
On 5/1/2020 12:33 PM, Ferruh Yigit wrote:
> On 4/30/2020 7:59 AM, ssar...@amd.com wrote:
>> From: Sardar Shamsher Singh
>>
>> adding below APIs for axgbe
>> - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping
>> - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping
>> - a
When fragmenting ipv4 packet, the data offset should be calculated through
the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper
library")
Cc: anatoly.bura...@intel.com
Cc: sta...@dpdk.org
Signed-off-by:
On Fri, 1 May 2020 17:01:40 +0100
Ferruh Yigit wrote:
> On 4/27/2020 10:39 PM, Stephen Hemminger wrote:
> > The TAP driver does not initialize all the elements of the rte_flow
> > structure. This can lead to crash in rte_flow_destroy.
> >
> > (gdb) where
> > flow=0x100e99280, error=0x0)
> >
I'm not sure of the algorithm for "memory size" here.
Technically, DPDK can reserve memory segments anywhere in the VA
space allocated by memseg lists. That space may be far bigger than
system memory (on a typical Intel server board you'd see 128GB of VA
space preallocated even though the mach
From: Nithin Dabilpuram
Based on the discussion in below mail thread, it is concluded that
all traffic manager API's (rte_tm.h) need to be marked experimental
till few more releases to support further improvements to spec.
https://mails.dpdk.org/archives/dev/2020-April/164970.html
Adding depric
On Fri, May 1, 2020 at 4:45 PM Pavan Nikhilesh Bhagavatula
wrote:
>
> >Subject: [PATCH] examples/l3fwd: fix error checking
> >
> >Patch fixes coverity issues which handle return values from AP
> >calling.
> >
> >Coverity issue: 354227, 354232, 354238, 354239, 354240
> >
> >Fixes: aaf58cb85b62 ("ex
>
>
> Hi Honnappa,
>
> > Hi Konstantin,
> > I like the way the tests are organized and it looks good.
> >
> > I am just wondering about the way it is being tested here. The intent
> > to write the test cases the way they are currently is to mimic how the
> > APIs would be used mostly. IMO,
> -Original Message-
> From: Honnappa Nagarahalli
> Sent: Friday, May 1, 2020 3:56 PM
> To: Van Haaren, Harry ; Phil Yang
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, Konstantin
> ; jer...@marvell.com;
> hemant.agra...@nxp.com; Gavin Hu ; nd
> ; sta...@dp
Thanks for pointing out the errors, see some comments inline.
On 2020-04-29 18:13 GMT+0100 Burakov, Anatoly wrote:
> On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote:
> > + * Reservation size. Must be a multiple of system page size.
> > + * @param flags
> > + * Reservation options, a combination of
On 2020-04-28 18:18 GMT-0700 Ranjit Menon wrote:
> On 4/28/2020 4:50 PM, Dmitry Kozlyuk wrote:
[snip]
> > +void *
> > +eal_mem_reserve(void *requested_addr, size_t size, int flags)
> > +{
> > + void *virt;
> > +
> > + /* Windows requires hugepages to be committed. */
> > + if (flags & EAL_RES
>
> When fragmenting ipv4 packet, the data offset should be calculated through
> the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
>
> Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper
> library")
> Cc: anatoly.bura...@intel.com
> Cc: sta...@dpdk.
Hello Sunil,
It's pretty close, thanks. Unfortunately, I just have a few nits
remaining.
On 01/05/20 17:09 +0530, Sunil Kumar Kori wrote:
> rte_bus_scan API scans all the available PCI devices irrespective of white
> or black listing parameters then further devices are probed based on white
> or
On Fri, May 1, 2020 at 1:29 PM Luca Boccassi wrote:
> >
> > Well, no, because rdseed is used first if available and /dev/urandom
> > is used next..
> >
> > And this is not a corner case at all.. There are lots of linux
> > distributions which DPDK claims to support which do not support
> > getentr
Although the RSS key still cannot be set, it is now being generated
every time the driver is being initialized.
Multiple devices can still have the same key if they're used by the same
driver.
Signed-off-by: Michal Krawczyk
Reviewed-by: Igor Chauskin
Reviewed-by: Guy Tzalik
<...>
@@ -2
Hi Akhil, Thomas,
Following up on that previous discussion below so that to confirm whether there
is an available option to handle this usecase within DPDK repo.
Basically traditional deployment for VRAN relies on BBDEV/DPDK running within
container where the workload is processed behind BBDE
From: Mike Baucom
The current mark handling uses the meta data field of the rxcmp as the
first level check for determining gfid vs lfid. When the meta data is
zero due to only the lowest 16bits of the gfid being set, the cfa code
is incorrectly interpreted as being an lfid. Changing code to loo
The rte_atomic ops and rte_smp barriers enforce DMB barriers on aarch64.
Using c11 atomics with explicit memory ordering instead of the rte_atomic
ops and rte_smp barriers for inter-threads synchronization can uplift the
performance on aarch64 and no performance loss on x86.
This patchset contains
From: Phil Yang
The num_mapped_cores is used as a statistics. Use c11 atomics with
RELAXED ordering for num_mapped_cores instead of rte_atomic ops which
enforce unnessary barriers on aarch64.
Replace execute_lock operations to spinlock_try_lock to avoid duplicate
code.
Signed-off-by: Phil Yang
From: Phil Yang
clean up rte prefix from static functions.
remove unused parameter for service_dump_one function.
Signed-off-by: Phil Yang
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_eal/common/rte_service.c | 34 ++---
1 file changed, 11 insertions(+), 23 deletio
From: Phil Yang
The service id validation is duplicated, remove the redundant code
in the calling functions.
Signed-off-by: Phil Yang
Reviewed-by: Honnappa Nagarahalli
---
lib/librte_eal/common/rte_service.c | 28 ++--
1 file changed, 6 insertions(+), 22 deletions(-)
From: Phil Yang
The runstate, comp_runstate and app_runstate are used as guard variables
in the service core lib. To guarantee the inter-threads visibility of
these guard variables, it uses rte_smp_r/wmb. This patch use c11 atomic
built-ins to relax these barriers.
Signed-off-by: Phil Yang
Revi
The MT unsafe service might get configured to run on another core
while the service is running currently. This might result in the
MT unsafe service running on multiple cores simultaneously. Use
'execute_lock' always when the service is MT unsafe.
If the service is known to be mmapped on a single
The logic to identify if the MT unsafe service is running on another
core can return -EBUSY spuriously. In such cases, running the service
becomes costlier than using atomic operations. Assume that the
application passes the right parameters and reduces the number of
instructions for all cases.
Cc
On Fri, May 1, 2020 at 12:16 PM Ajit Khaparde
wrote:
> From: Mike Baucom
>
> The current mark handling uses the meta data field of the rxcmp as the
> first level check for determining gfid vs lfid. When the meta data is
> zero due to only the lowest 16bits of the gfid being set, the cfa code
>
- Update list of supported adapters.
- Update list of supported features.
- Add some details to describe the features.
- Remove obsolete limitations.
- Fix and update links.
Signed-off-by: JP Lee
Signed-off-by: Ajit Khaparde
---
doc/guides/nics/bnxt.rst | 1131 ++
> -Original Message-
> From: Stephen Hemminger
> Sent: Monday, April 27, 2020 6:16 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Eads, Gage
> ; Olivier Matz
> Subject: [PATCH v3 3/4] stack: check flags on creation
>
> All API's should check that they support the flag values passed. If
Hi Pavan,
snipped
> >
> >Should we check & warn the user if
> >1. port speed mismatch
> >2. on different NUMA
> >3. port pairs are physical and vdev like tap, and KNI (performance).
> >
>
> Sure, it can be a separate patch as it will be applicable for multiple
> examples.
I believe this patch is
89 matches
Mail list logo
