Re: [dpdk-dev] Non-deterministic build failure in rte_ethdev.h:4287:10 on Taishan ARM server

2020-06-02 Thread Juraj Linkeš
Hi Jerin, I forgot to mention that I'm using GCC 8 and this fixed the issue. A bit of googling illuminated why this could be so, according to https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html, the angle brackets directive looks for files in a standard list of system directories while the

[dpdk-dev] [PATCH v4] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-06-02 Thread Sarosh Arif
Combine https://patches.dpdk.org/patch/67855/ with v2 of this patch to fix the overall behaviour of dpdk-setup.sh on non-alphanumeric inputs. Instead of crashing the script will prompt the user to re-enter the input in case of non-alphanumeric input. Bugzilla ID: 419 Signed-off-by: Sarosh Arif

Re: [dpdk-dev] [PATCH v2 2/4] mempool: use generic memory management

2020-06-02 Thread Andrew Rybchenko
On 6/2/20 12:14 AM, Thomas Monjalon wrote: > 01/06/2020 21:59, Dmitry Kozlyuk: >> 1. What do you think about changing rte_ to rte_eal_ prefix for memory >> management wrappers in MM series as Andrew Rybchenko suggested for v1? Since >> the functions are DPDK-internal, this sounds reasonable to me.

Re: [dpdk-dev] [PATCH v2 4/4] mempool: mempool build on Windows

2020-06-02 Thread Andrew Rybchenko
On 6/1/20 1:31 PM, Fady Bader wrote: > Added mempool to supported libraries for Windows compilation. > > Signed-off-by: Fady Bader > --- > lib/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/meson.build b/lib/meson.build > index 30ed9e05e..c53732383 10

[dpdk-dev] [PATCH] sched: add missing 64-bit rate values

2020-06-02 Thread Archit Pandey
64-bit support was missing from the functions pipe_profile_check and rte_sched_subport_config_pipe_profile_table. Fixes: 68c1f26d4236 ("sched: support 64-bit values") Cc: jasvinder.si...@intel.com Signed-off-by: Archit Pandey --- lib/librte_sched/rte_sched.c | 4 ++-- 1 file changed, 2 insertio

Re: [dpdk-dev] Non-deterministic build failure in rte_ethdev.h:4287:10 on Taishan ARM server

2020-06-02 Thread Jerin Jacob
On Tue, Jun 2, 2020 at 12:43 PM Juraj Linkeš wrote: > > Hi Jerin, > > I forgot to mention that I'm using GCC 8 and this fixed the issue. A bit of > googling illuminated why this could be so, according to > https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html, the angle brackets > directive lo

[dpdk-dev] [RFC 0/3] mlx5: LACP handling for bonded devices

2020-06-02 Thread Shiri Kuzin
When the driver has a bond configured LACP traffic should be steered to kernel to manage the bond using a new rdma-core API. This is done by creating a new internal action and adding a new devarg that will allow the user to manage the bond and get lacp traffic if they wish. Shiri Kuzin (3):

[dpdk-dev] [RFC 1/3] common/mlx5: add default miss action

2020-06-02 Thread Shiri Kuzin
Add dv_create_action_default_miss wrapper function for the action added to the rdma-core MLX5DV_FLOW_ACTION_DEFAULT_MISS. When a packet matches MLX5DV_FLOW_ACTION_DEFAULT_MISS action it is steered to the default miss of the verbs steering domain. Signed-off-by: Shiri Kuzin --- drivers/common/ml

[dpdk-dev] [RFC 3/3] net/mlx5: add new devarg dv_lacp_by_user

2020-06-02 Thread Shiri Kuzin
The new devarg will control the steering of the lacp traffic. when setting dv_lacp_by_user = 0 the lacp traffic will be steered to kernel and managed there. When setting dv_lacp_by_user = 1 the lacp traffic will not be steered and the user will need to manage it. Signed-off-by: Shiri Kuzin ---

[dpdk-dev] [RFC 2/3] net/mlx5: add default miss action to flow engine

2020-06-02 Thread Shiri Kuzin
The new action is an internal mlx5 action that will call the rdma-core function MLX5DV_FLOW_ACTION_DEFAULT_MISS. The default miss action will be used when a bond is configured to allow traffic realted to the bond to be managed in the kernel. Signed-off-by: Shiri Kuzin --- drivers/net/mlx5/mlx5.

Re: [dpdk-dev] [PATCH] sched: add missing 64-bit rate values

2020-06-02 Thread Singh, Jasvinder
> -Original Message- > From: Archit Pandey > Sent: Tuesday, June 2, 2020 9:55 AM > To: dev@dpdk.org > Cc: Archit Pandey ; Singh, Jasvinder > > Subject: [PATCH] sched: add missing 64-bit rate values > > 64-bit support was missing from the functions pipe_profile_check and > rte_sched_su

Re: [dpdk-dev] [RFC 1/6] eal: add power management intrinsics

2020-06-02 Thread Ananyev, Konstantin
> > On Thu, May 28, 2020 at 9:08 PM Ananyev, Konstantin > wrote: > > > > > > > > Hi Anatoly, > > > > > > > >> > > > >> Add two new power management intrinsics, and provide an implementation > > > >> in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > > > >> are implemented as ra

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-02 Thread Harman Kalra
On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: > On 30-May-20 11:02 AM, Harman Kalra wrote: > > On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: > > > External Email > > > > > > -- > > > On 29-M

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v2 1/4] eal: disable function versioning on Windows

2020-06-02 Thread Neil Horman
On Mon, Jun 01, 2020 at 09:46:18PM +, Omar Cardona wrote: > >> Do we know if we have future plans of supporting dlls on windows in the > >> future? > - Hi Neil, yes this is of interest to us (Windows). > - Specifically to aid in non-disruptive granular servicing/updating. >

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v2 1/4] eal: disable function versioning on Windows

2020-06-02 Thread Thomas Monjalon
02/06/2020 12:27, Neil Horman: > On Mon, Jun 01, 2020 at 09:46:18PM +, Omar Cardona wrote: > > >> Do we know if we have future plans of supporting dlls on windows in the > > >> future? > > - Hi Neil, yes this is of interest to us (Windows). > > - Specifically to aid in non-disruptive

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-02 Thread Ananyev, Konstantin
Hi Jerin, > > > > I also share Olivier's concern about consuming 3 bits in ol_flags for > > > > that feature. > > > > Can it probably be squeezed somehow? > > > > Let say we reserve one flag that this information is present or not, and > > > > re-use one of rx-only fields for store additional inf

Re: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix flow control status get

2020-06-02 Thread Jiang, YuX
Tested-by: Chen, BoX C -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Guinan Sun Sent: Saturday, May 23, 2020 1:23 PM To: dev@dpdk.org Cc: Zhao1, Wei ; Yang, Qiming ; Sun, GuinanX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2 2/2] net/ixgbe: fix flow control st

Re: [dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-06-02 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Thursday, May 28, 2020 4:56 PM > To: dpdk-dev > Cc: Thomas Monjalon > Subject: [dpdk-dev] DPDK Release Status Meeting 28/05/2020 > > Minutes 28 May 2020 > --- > > Agenda: > * Release Dates >

Re: [dpdk-dev] Which tests are compulsory to PASS for Patch to be accepted

2020-06-02 Thread Muhammad Bilal
Thank you for your response. How will we know if a patch is failing because of some failure in the CI infrastructure or due to earlier merge? On Thu, May 28, 2020 at 1:59 AM Stephen Hemminger wrote: > > On Thu, 28 May 2020 01:13:27 +0500 > Muhammad Bilal wrote: > > > Recently I have submitted p

Re: [dpdk-dev] [EXT] Re: [PATCH 3/3] l3fwd-power: add interrupt-only mode

2020-06-02 Thread Harman Kalra
On Tue, Jun 02, 2020 at 03:53:07PM +0530, Harman Kalra wrote: > On Mon, Jun 01, 2020 at 01:50:26PM +0100, Burakov, Anatoly wrote: > > On 30-May-20 11:02 AM, Harman Kalra wrote: > > > On Fri, May 29, 2020 at 03:19:45PM +0100, Burakov, Anatoly wrote: > > > > External Email > > > > > > > > --

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Jerin Jacob
On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > > On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > > I think, original discussion[1] on this topic got lost in GitHub vs current > > workflow. > > > > > > I would like to propose GitHub "CODEOWNERS"[2] _LIKE_ scheme for DPDK > > workflow

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2020-06-02 Thread Muhammad Bilal
On Tue, May 19, 2020 at 2:35 PM Sunil Kumar Kori wrote: > > >-Original Message- > >From: Muhammad Bilal > >Sent: Tuesday, May 19, 2020 2:25 PM > >To: declan.dohe...@intel.com; tomasz.kante...@intel.com; Pavan Nikhilesh > >Bhagavatula ; Sunil Kumar Kori > > > >Cc: dev@dpdk.org; Muhammad Bi

Re: [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation

2020-06-02 Thread Wisam Monther
Hey Andrew, Sorry for late response "we were in holiday". Please see comments inline, anything that I didn't reply on, will fixed in next version. I'll wait for your reply before sending next version in order to reduce review and don't encounter Duplicate comments. Thanks for review up to now re

[dpdk-dev] [PATCH v3 1/3] devtools: standardize script arguments

2020-06-02 Thread Ciara Power
This patch modifies the arguments expected by the check-git-log script, to match the format of arguments for the checkpatches script. Both scripts now take certain argument options in the same format, making them easier to use. e.g. Both now take a commit ID range by "-r " The checkpatches help pr

[dpdk-dev] [PATCH v3 2/3] devtools: added stats print

2020-06-02 Thread Ciara Power
When all checks are completed on the specified commit logs, the script indicates if all are valid, or if there were some failures. Signed-off-by: Ciara Power Acked-by: Ferruh Yigit --- v2: Added appropriate exit codes based on failure status. --- devtools/check-git-log.sh | 45

[dpdk-dev] [PATCH v3 0/3] standardize devtools check scripts

2020-06-02 Thread Ciara Power
v3: - Fix comments on v2. - Add patch to update contributor's guide. v2: Fix comments on v1. This patchset standardizes the checkpatches and check-git-log scripts to accept the same syntax commandline arguments, to make them easier to use. The output is also standardized, check-git-log previ

[dpdk-dev] [PATCH v3 3/3] doc/guides: updated script usage for checking patches

2020-06-02 Thread Ciara Power
The contributor's guide includes the usage of both the checkpatches and check-git-log scripts, which needed to be updated to reflect the now standardised format. Signed-off-by: Ciara Power --- doc/guides/contributing/patches.rst | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

Re: [dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-06-02 Thread Ferruh Yigit
On 6/2/2020 12:39 PM, Iremonger, Bernard wrote: > Hi Ferruh, > >> -Original Message- >> From: dev On Behalf Of Ferruh Yigit >> Sent: Thursday, May 28, 2020 4:56 PM >> To: dpdk-dev >> Cc: Thomas Monjalon >> Subject: [dpdk-dev] DPDK Release Status Meeting 28/05/2020 >> >> Minutes 28 May 2

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-06-02 Thread Nithin Dabilpuram
On Tue, Jun 02, 2020 at 10:53:08AM +, Ananyev, Konstantin wrote: > Hi Jerin, > > > > > > I also share Olivier's concern about consuming 3 bits in ol_flags for > > > > > that feature. > > > > > Can it probably be squeezed somehow? > > > > > Let say we reserve one flag that this information is

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-02 Thread Andrew Rybchenko
On 5/31/20 5:43 PM, Dekel Peled wrote: > Using the current implementation of DPDK, an application cannot > match on fragmented/non-fragmented IPv6 packets in a simple way. > > In current implementation: > IPv6 header doesn't contain information regarding the packet > fragmentation. > Fragmented IP

Re: [dpdk-dev] DPDK Release Status Meeting 28/05/2020

2020-06-02 Thread Thomas Monjalon
02/06/2020 16:23, Ferruh Yigit: > On 6/2/2020 12:39 PM, Iremonger, Bernard wrote: > > From: Ferruh Yigit > >> * v20.08 dates: > >> * Proposal/V1:Friday, 12 June 2020 > > > > Is the merge deadline Friday, 3 July? > > > >> * -rc1:Wednesday, 8 July 2020 > > Hi Bernard, > > I personally find ha

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Ferruh Yigit
On 6/2/2020 1:27 PM, Jerin Jacob wrote: > On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: >> >> On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: >>> I think, original discussion[1] on this topic got lost in GitHub vs current >>> workflow. >>> >>> >>> I would like to propose GitHub "CODEOWN

[dpdk-dev] [PATCH v3 0/4] vhost: support vDPA virtio queue statistics

2020-06-02 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this series introduces new APIs to get traffic statistics and to reset them per virtio queue. Since there is no any formal statistics suggested by the virtio specs,

[dpdk-dev] [PATCH v3 3/4] vdpa/mlx5: support virtio queue statistics get

2020-06-02 Thread Matan Azrad
Add support for statistics operations. A DevX counter object is allocated per virtq in order to manage the virtq statistics. The counter object is allocated before the virtq creation and destroyed after it, so the statistics are valid only in the life time of the virtq. Signed-off-by: Matan Azra

[dpdk-dev] [PATCH v3 4/4] examples/vdpa: add statistics show command

2020-06-02 Thread Matan Azrad
A new vDPA driver feature was added to query the virtq statistics from the HW. Use this feature to show the HW queues statistics for the virtqs. Command description: stats X Y. X is the device ID. Y is the queue ID, Y=0x to show all the virtio queues statistics of the device X. Signed-off-by

[dpdk-dev] [PATCH v3 1/4] vhost: inroduce operation to get vDPA queue stats

2020-06-02 Thread Matan Azrad
The vDPA device offloads all the datapath of the vhost device to the HW device. In order to expose to the user traffic information this patch introduces new 3 APIs to get traffic statistics, the device statistics name and to reset the statistics per virtio queue. The statistics are taken directly

[dpdk-dev] [PATCH v3 2/4] common/mlx5: support DevX virtq stats operations

2020-06-02 Thread Matan Azrad
Add DevX API to create and query virtio queue statistics from the HW. The next counters are supported by the HW per virtio queue: received_desc. completed_desc. error_cqes. bad_desc_errors. exceed_max_chain. invalid_buffer. Signed-off-by: Matan Azrad

[dpdk-dev] [PATCH] test: test patch for checking patchwork auto delegation feature

2020-06-02 Thread jerinj
From: Jerin Jacob This is a test patch to test patchwork auto delegation feature from git send email. Signed-off-by: Jerin Jacob --- README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README b/README index 55df15864..adf7a7c31 100644 --- a/README +++ b/README @@ -9,3 +9,6 @@ API doc

[dpdk-dev] [PATCH 1/2] common/mlx5: add virtio queue protection domain

2020-06-02 Thread Matan Azrad
Starting from FW version 22.27.4002, it is required to configure protection domain (PD) for each virtq created by DevX. Add PD requirement in virtq DevX APIs. Cc: sta...@dpdk.org Signed-off-by: Matan Azrad Signed-off-by: Xueming Li --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 + drivers/commo

[dpdk-dev] [PATCH 2/2] vdpa/mlx5: adjust virtio queue protection domain

2020-06-02 Thread Matan Azrad
In other to fill the new requirement for virtq configuration, set the single PD managed by the driver for all the virtqs. Cc: sta...@dpdk.org Signed-off-by: Matan Azrad Signed-off-by: Xueming Li --- drivers/vdpa/mlx5/mlx5_vdpa.c | 38 ++- drivers/vdpa/mlx5

[dpdk-dev] [PATCH 1/2] common/mlx5: share kernel interface name getter

2020-06-02 Thread Matan Azrad
Some configuration of the mlx5 port are done by the kernel net device associated to the IB device represents the PCI device. The DPDK mlx5 driver uses linux system calls, for example ioctl, in order to configure per port configurations requested by the DPDK user. One of the basic knowledges requi

[dpdk-dev] [PATCH 2/2] vdpa/mlx5: support MTU feature

2020-06-02 Thread Matan Azrad
The guest virtio device may request MTU updating when the vhost backend device exposes a capability to support it. Exspose the MTU feature capability. In configuration time, check the requested MTU and update it in the HW device. Signed-off-by: Matan Azrad --- doc/guides/rel_notes/release_20_0

[dpdk-dev] [PATCH v2] test: test patch for checking patchwork auto delegation feature

2020-06-02 Thread jerinj
From: Jerin Jacob This is a test patch to test patchwork auto delegation feature from git send email. Signed-off-by: Jerin Jacob --- README | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README b/README index 55df15864..adf7a7c31 100644 --- a/README +++ b/README @@ -9,3 +9,6 @@ API doc

Re: [dpdk-dev] Suggestion to improve the code review

2020-06-02 Thread Jerin Jacob
On Tue, Jun 2, 2020 at 8:27 PM Ferruh Yigit wrote: > > On 6/2/2020 1:27 PM, Jerin Jacob wrote: > > On Wed, May 27, 2020 at 3:38 PM Gaëtan Rivet wrote: > >> > >> On 27/05/20 09:28 +, Jerin Kollanukkaran wrote: > >>> I think, original discussion[1] on this topic got lost in GitHub vs > >>> cur

Re: [dpdk-dev] Marvell DPDK v20.08 Roadmap

2020-06-02 Thread Thomas Monjalon
29/05/2020 14:50, Jerin Kollanukkaran: > Regexdev: > ~ > 11) Review regexdev: introduce regexdev subsystem If I remember well, you were targetting DPDK 20.08 to introduce a new regex PMD. I am surprised this roadmap mentions only reviewing the API.

Re: [dpdk-dev] [PATCH] test/autotest: checking for skipped or unsupported tests

2020-06-02 Thread David Christensen
]> - When running the dedault configuration of autotest of the make test it'd take 900 seconds (15 minutes) for the script TIMEOUT and marks Failed for a specific device test that is not supported on the system under test. - Adding the checking for those tests, print out as "Skipped [Not

Re: [dpdk-dev] Questions Questions about hash function enum

2020-06-02 Thread Ferruh Yigit
On 6/1/2020 2:31 AM, oulijun wrote: > Hi Ferruh Yigit and others > > I am learning data structure defined by dpdk framework and I noticed > a data structure definition below: > > enum rte_eth_hash_function { > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**

Re: [dpdk-dev] Marvell DPDK v20.08 Roadmap

2020-06-02 Thread Jerin Jacob
On Tue, Jun 2, 2020 at 10:16 PM Thomas Monjalon wrote: > > 29/05/2020 14:50, Jerin Kollanukkaran: > > Regexdev: > > ~ > > 11) Review regexdev: introduce regexdev subsystem > > If I remember well, you were targetting DPDK 20.08 > to introduce a new regex PMD. > I am surprised this roadmap m

Re: [dpdk-dev] [PATCH] doc: removed typing mistake

2020-06-02 Thread Ferruh Yigit
On 5/29/2020 3:47 PM, Muhammad Bilal wrote: > There was a duplicate command instruction in the documentation of memif > so I have removed the 1 command from it. > > Fixes: cd3365d2 ("net/memif: enable loopback") > Cc: jmilan@gmail.com > > Signed-off-by: Muhammad Bilal > --- > doc/guides

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: report valid RSS RETA size

2020-06-02 Thread Ferruh Yigit
On 5/27/2020 11:02 PM, Stephen Hemminger wrote: > On Wed, 27 May 2020 23:35:25 +0200 > Gaëtan Rivet wrote: > >> On 27/05/20 18:30 +0300, Andrew Rybchenko wrote: >>> On 5/27/20 6:07 PM, Gaëtan Rivet wrote: On 27/05/20 15:34 +0100, Andrew Rybchenko wrote: > From: Ian Dolzhansky >

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-02 Thread Song, Keesang
[AMD Official Use Only - Internal Distribution Only] Hi Thomas & David, We haven't got the final status on this patch, and I don't see this change even from the latest LTS 20.04 repo. So I'd like to confirm whether this patch has been safely submitted to the main upstream. Can you check the sta

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-02 Thread Song, Keesang
[AMD Public Use] Hi Thomas & David, We haven't got the final status on this patch, and I don't see this change even from the latest LTS 20.04 repo. So I'd like to confirm whether this patch has been safely submitted to the main upstream. Can you check the status of that commit? https://patchwo

Re: [dpdk-dev] [PATCH 0/4] Extend --lcores to run on cores > RTE_MAX_LCORE

2020-06-02 Thread Song, Keesang
[AMD Public Use] Thanks Thomas for the response. For a correction, the patchwork has not been submitted for the current LTS release, 19.11.2, but was merged into 20.02 and onward. The reason I brought this again was to address LTS users and many other application based on the LTS releases(18.11

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-02 Thread Ori Kam
Hi Andrew, PSB, Best, Ori > -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, June 2, 2020 5:33 PM > Subject: Re: [RFC] ethdev: add fragment attribute to IPv6 item > > On 5/31/20 5:43 PM, Dekel Peled wrote: > > Using the current implementation of DPDK, an application cannot

Re: [dpdk-dev] Marvell DPDK v20.08 Roadmap

2020-06-02 Thread Ori Kam
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, June 2, 2020 8:37 PM > Subject: Re: [dpdk-dev] Marvell DPDK v20.08 Roadmap > > On Tue, Jun 2, 2020 at 10:16 PM Thomas Monjalon > wrote: > > > > 29/05/2020 14:50, Jerin Kollanukkaran: > > > Regexdev: > > > ~ > > > 11) Rev

Re: [dpdk-dev] [RFC] ethdev: add fragment attribute to IPv6 item

2020-06-02 Thread Adrien Mazarguil
Hi Ori, Andrew, Delek, (been a while eh?) On Tue, Jun 02, 2020 at 06:28:41PM +, Ori Kam wrote: > Hi Andrew, > > PSB, [...] > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > > index b0e4199..3bc8ce1 100644 > > > --- a/lib/librte_ethdev/rte_flow.h > > > +++ b/l

Re: [dpdk-dev] mlx5 & pdump: convert HW timestamps to nanoseconds

2020-06-02 Thread PATRICK KEROULAS
On Tue, May 26, 2020 at 12:00 PM Slava Ovsiienko wrote: > ConnectX HW timestamp is the captured value of internal 64-bit counter > running at the frequency, > reported in the device_frequency_khz field of struct > mlx5_ifc_cmd_hca_cap_bits{}. > This structure is queried in mlx5_devx_cmd_query_hc

Re: [dpdk-dev] Marvell DPDK v20.08 Roadmap

2020-06-02 Thread Thomas Monjalon
02/06/2020 19:36, Jerin Jacob: > On Tue, Jun 2, 2020 at 10:16 PM Thomas Monjalon wrote: > > 29/05/2020 14:50, Jerin Kollanukkaran: > > > Regexdev: > > > ~ > > > 11) Review regexdev: introduce regexdev subsystem > > > > If I remember well, you were targetting DPDK 20.08 > > to introduce a n

[dpdk-dev] [PATCH v6 01/11] eal: replace rte_page_sizes with a set of constants

2020-06-02 Thread Dmitry Kozlyuk
Clang on Windows follows MS ABI where enum values are limited to 2^31-1. Enum rte_page_sizes has members valued above this limit, which get wrapped to zero, resulting in compilation error (duplicate values in enum). Using MS ABI is mandatory for Windows EAL to call Win32 APIs. Remove rte_page_size

[dpdk-dev] [PATCH v6 02/11] eal: introduce internal wrappers for file operations

2020-06-02 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers in order to support common EAL code on Unix and Windows: * eal_file_create: open an existing file. * eal_file_open: create a file or open it if exists. * eal_file_lock: lock or unlock an open file. * eal_file_truncate: enforce a given size for an open file. Imple

[dpdk-dev] [PATCH v6 03/11] eal: introduce memory management wrappers

2020-06-02 Thread Dmitry Kozlyuk
Introduce OS-independent wrappers for memory management operations used across DPDK and specifically in common code of EAL: * rte_mem_map() * rte_mem_unmap() * rte_mem_page_size() * rte_mem_lock() Windows uses different APIs for memory mapping and reservation, while Unices reserve memory by mappi

[dpdk-dev] [PATCH v6 04/11] eal/mem: extract common code for memseg list initialization

2020-06-02 Thread Dmitry Kozlyuk
All supported OS create memory segment lists (MSL) and reserve VA space for them in a nearly identical way. Move common code into EAL private functions to reduce duplication. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/common/eal_common_memory.c | 97 ++ lib/librte_eal/comm

[dpdk-dev] [PATCH v6 00/11] Windows basic memory management

2020-06-02 Thread Dmitry Kozlyuk
This patchset implements basic MM with the following features: * Hugepages are dynamically allocated in user-mode. * Only 2MB hugepages are supported. * IOVA is always PA, obtained through kernel-mode driver. * No 32-bit support (presumably not demanded). * Ni multi-process support (it is forceful

[dpdk-dev] [PATCH v6 06/11] trace: add size_t field emitter

2020-06-02 Thread Dmitry Kozlyuk
It is not guaranteed that sizeof(long) == sizeof(size_t). On Windows, sizeof(long) == 4 and sizeof(size_t) == 8 for 64-bit programs. Tracepoints using "long" field emitter are therefore invalid there. Add dedicated field emitter for size_t and use it to store size_t values in all existing tracepoin

[dpdk-dev] [PATCH v6 08/11] eal/windows: replace sys/queue.h with a complete one from FreeBSD

2020-06-02 Thread Dmitry Kozlyuk
Limited version imported previously lacks at least SLIST macros. Import a complete file from FreeBSD, since its license exception is already approved by Technical Board. Signed-off-by: Dmitry Kozlyuk --- lib/librte_eal/windows/include/sys/queue.h | 663 +++-- 1 file changed, 601

[dpdk-dev] [PATCH v6 07/11] eal/windows: add tracing support stubs

2020-06-02 Thread Dmitry Kozlyuk
EAL common code depends on tracepoint calls, but generic implementation cannot be enabled on Windows due to missing standard library facilities. Add stub functions to support tracepoint compilation, so that common code does not have to conditionally include tracepoints until proper support is added

[dpdk-dev] [PATCH v6 10/11] eal/windows: initialize hugepage info

2020-06-02 Thread Dmitry Kozlyuk
Add hugepages discovery ("large pages" in Windows terminology) and update documentation for required privilege setup. Only 2MB hugepages are supported and their number is estimated roughly due to the lack or unstable status of suitable OS APIs. Assign myself as maintainer for the implementation fil

[dpdk-dev] [PATCH v6 09/11] eal/windows: improve CPU and NUMA node detection

2020-06-02 Thread Dmitry Kozlyuk
1. Map CPU cores to their respective NUMA nodes as reported by system. 2. Support systems with more than 64 cores (multiple processor groups). 3. Fix magic constants, styling issues, and compiler warnings. 4. Add EAL private function to map DPDK socket ID to NUMA node number. Fixes: 53ffd9f080fc (

[dpdk-dev] [PATCH v6 05/11] eal/mem: extract common code for dynamic memory allocation

2020-06-02 Thread Dmitry Kozlyuk
Code in Linux EAL that supports dynamic memory allocation (as opposed to static allocation used by FreeBSD) is not OS-dependent and can be reused by Windows EAL. Move such code to a file compiled only for the OS that require it. Keep Anatoly Burakov maintainer of extracted code. Signed-off-by: Dmi

[dpdk-dev] [PATCH v6 11/11] eal/windows: implement basic memory management

2020-06-02 Thread Dmitry Kozlyuk
Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at startup. Assign myself as a maintainer for Windo

Re: [dpdk-dev] [PATCH v3 0/4] Memory corruption due to HW rings allocation

2020-06-02 Thread Zhao1, Wei
I am sure i40e FDIR filter also allocate ring for filter programing, it also has the same issue. Ice NIC the same. Although we can avoid this issue by change ring name to "igb_tx_ring" and so on, but the issue of memory for ring not freed after close is still exsit. Support this comment. If no on

Re: [dpdk-dev] [PATCH v6 01/11] eal: replace rte_page_sizes with a set of constants

2020-06-02 Thread Stephen Hemminger
On Wed, 3 Jun 2020 02:03:19 +0300 Dmitry Kozlyuk wrote: > Clang on Windows follows MS ABI where enum values are limited to 2^31-1. > Enum rte_page_sizes has members valued above this limit, which get > wrapped to zero, resulting in compilation error (duplicate values in > enum). Using MS ABI is

[dpdk-dev] [PATCH 00/52] net/ice: base code update

2020-06-02 Thread Qi Zhang
Upgrade base with below main changes 1. add more protocol support - L2TPv3/ESP/AH/PFCP. 2. Add IPv6 prefix RSS support. 3. support GENEVE and VXLAN rules with VLAN. 4. Add E823L device IDs 5. couple bug fixes and code clean. Qi Zhang (52): net/ice/base: add support for non-IP Layer2 protocol

[dpdk-dev] [PATCH 01/52] net/ice/base: add support for non-IP Layer2 protocol

2020-06-02 Thread Qi Zhang
FDIR can forward Ethernet packets with non-IP ethertype. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 15 +++ drivers/net/ice/base/ice_fdir.h | 2 ++ drivers/net/ice/base/ice_flow.c | 29

[dpdk-dev] [PATCH 04/52] net/ice/base: avoid undefined behavior

2020-06-02 Thread Qi Zhang
When writing the driver's struct ice_tlan_ctx structure, do not write the 8-bit element int_q_state with the associated internal-to-hardware field which is 122-bits, otherwise the helper function ice_write_byte() will use undefined behavior when setting the mask used for that write. This should no

[dpdk-dev] [PATCH 07/52] net/ice/base: gate devices from FW link override

2020-06-02 Thread Qi Zhang
Currently, the FW link override feature is only permitted for E810 devices. However, the ice_fw_supports_link_override() guards against FW versions irrespective of the device. This assumes FW versions between the families are aligned, which is not the case. Signed-off-by: Jeb Cramer Signed-off-b

[dpdk-dev] [PATCH 02/52] net/ice/base: add FDIR program status WB macro

2020-06-02 Thread Qi Zhang
Add descriptor field offset and mask definition. It is used to parse FDIR rx descriptor field value. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_lan_tx_rx.h | 44 1 file changed, 44 inser

[dpdk-dev] [PATCH 06/52] net/ice/base: report AOC PHY Types as Fiber

2020-06-02 Thread Qi Zhang
Report AOC types as fiber instead of unknown Signed-off-by: Doug Dziggel Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base

[dpdk-dev] [PATCH 05/52] net/ice/base: consolidate implementation of MAC config set

2020-06-02 Thread Qi Zhang
Consolidate implementation of ice_aq_set_mac_cfg for switch mode and NIC mode. As per the specification, the driver needs to call set_mac_cfg (opcode 0x0603) to be able to exercise jumbo frames. Signed-off-by: Anirudh Venkataramanan Signed-off-by: Jeb Cramer Signed-off-by: Paul M. Stillwell Jr

[dpdk-dev] [PATCH 03/52] net/ice/base: disable profile merge for FDIR

2020-06-02 Thread Qi Zhang
For Flow Director, we don't want to re-use a existed profile with the same field vector and mask. Merging two different flow_type’s field vector will also make them sharing trained rule and cause rule interference. For example: issue rule A: IPV4_TCP matching tcp src&dst port 80 to queue 8 issue

[dpdk-dev] [PATCH 10/52] net/ice/base: fix variable type for ACL

2020-06-02 Thread Qi Zhang
The commit ef92cee94cdb ("ice-shared: Fix remaining minor casting issues") changed the idx variable within ice_acl_add_entry() from a u16 to a u8. This causes the code to truncate the values greater than 255 to 255 or less when calling ice_aq_program_acl_entry() resulting in the wrong TCAM index be

[dpdk-dev] [PATCH 08/52] net/ice/base: improve VSI filters rebuild

2020-06-02 Thread Qi Zhang
This change improve VSI filter configuration rebuild for multiport configuration, ie. where 1 PF includes more than one logical port. For some functions, association between port and corresponding switch_info or port_info structure has been lost because by default the pointer to the first element o

[dpdk-dev] [PATCH 12/52] net/ice/base: consolidate VF Promiscuous mode

2020-06-02 Thread Qi Zhang
Consolidate the Promiscuous rule for SMBM on the chosen logical port. Signed-off-by: Shibin Koikkara Reeny Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 145 ++ 1 file changed, 115 insertions(+), 30 delet

[dpdk-dev] [PATCH 13/52] net/ice/base: refactor flow director filter swap

2020-06-02 Thread Qi Zhang
Move the swap of flow director addresses and ports into training packet generation. This reduces the code written for ACL. Signed-off-by: Henry Tieman Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 59 ---

[dpdk-dev] [PATCH 11/52] net/ice/base: update PHY type high max index value

2020-06-02 Thread Qi Zhang
As currently, we are supporting only 5 PHY_SPEEDs for phy_type_high. Thus, we should adjust the value of ICE_PHY_TYPE_HIGH_MAX_INDEX to 5. Signed-off-by: Chinh T Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_adminq_cmd.h | 2 +- 1 file changed, 1

[dpdk-dev] [PATCH 09/52] net/ice/base: add AUI media type

2020-06-02 Thread Qi Zhang
Add and report AUI PHY types as an AUI media type Signed-off-by: Doug Dziggel Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 5 +++-- drivers/net/ice/base/ice_type.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH 16/52] net/ice/base: cleanup comment formatting

2020-06-02 Thread Qi Zhang
Add missing space between end of comment text and comment terminator, and remove unnecessary punctuation. Signed-off-by: Bruce Allan Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_acl.c| 25 +- drivers/net/ice/base/ice_acl_ctrl.

[dpdk-dev] [PATCH 14/52] net/ice/base: change IPV6 training packet

2020-06-02 Thread Qi Zhang
Add additional UDP payload to allow for additional headers such as ESP. Signed-off-by: Dan Nowlin Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/ic

[dpdk-dev] [PATCH 17/52] net/ice/base: add FDIR support for L2TPV3 ESP AH and PFCP

2020-06-02 Thread Qi Zhang
FDIR can forward: - L2TPV3 packets with session id. - IPSEC ESP packets with security parameter index. - IPSEC AH packets with security parameter index. - NAT_T ESP packets with security parameter index. - PFCP packets with s field value. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell

[dpdk-dev] [PATCH 18/52] net/ice/base: add FD completion report option

2020-06-02 Thread Qi Zhang
This patch introduces comp_report variable so that the called can determine whether to report completion on error or on all cases. Signed-off-by: Yahui Cao Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.c | 2 +- drivers/net/ice/base/ice_fdir.h

[dpdk-dev] [PATCH 15/52] net/ice/base: group function protoypes together

2020-06-02 Thread Qi Zhang
There are some function prototypes at the beginning of the file and some at the end, group them all together so that they are in one consistent location. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_fdir.h | 83

[dpdk-dev] [PATCH 19/52] net/ice/base: initialize Set PHY Configuration FEC fields

2020-06-02 Thread Qi Zhang
Currently the caller needs to initialize the ice_cfg_phy_fec() parameter ice_aqc_set_phy_cfg_data FEC fields before calling. However, this is not necessary since ice_cfg_phy_fec() calls Get PHY Capabilities. Initialize ice_aqc_set_phy_cfg_data FEC capabilities and FEC option fields from Get PHY Ca

[dpdk-dev] [PATCH 25/52] net/ice/base: add RSS support for IPv6 prefix

2020-06-02 Thread Qi Zhang
Some IPv6 prefix related fields are defined in this patch, so that we can use prefixes instead of full IPv6 address for RSS. These prefixes include the first 32, 48, 64 bits of both SRC and DST IPV6 address. Signed-off-by: Junfeng Guo Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang

[dpdk-dev] [PATCH 21/52] net/ice/base: allow GENEVE and VXLAN rules with VLAN

2020-06-02 Thread Qi Zhang
When programming GENEVE and VXLAN switch rules, there are some instances where both VLAN tagged packets plus non-VLAN tagged packets are needed to match the rule. In order to perform this action in one rule, the switch code needs to setup the packet flag mask to ignore the VLAN packet flag. This w

[dpdk-dev] [PATCH 23/52] net/ice/base: remove unnecessary braces

2020-06-02 Thread Qi Zhang
This patch mainly does cleanups related to unnecessary braces. A few other minor fixes are included which include fixing a typo, pulling up some lines, and fixing RCT. Signed-off-by: Tony Nguyen Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe

[dpdk-dev] [PATCH 24/52] net/ice/base: adjust function signature style format

2020-06-02 Thread Qi Zhang
Where possible, cuddle multiple lines of function signatures to be consistent throughout the code. Signed-off-by: Bruce Allan Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 +-- drivers/net/ice/base/ice_controlq.c | 9 +++-- driver

[dpdk-dev] [PATCH 20/52] net/ice/baes: add NVM help functions

2020-06-02 Thread Qi Zhang
Add couple functions that DPDK would like to use for accessing the NVM. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.h | 1 - drivers/net/ice/base/ice_nvm.c| 67 +-- drivers/net/ice/base/ice_nvm.h| 10

[dpdk-dev] [PATCH 22/52] net/ice/base: increase timeout after PFR

2020-06-02 Thread Qi Zhang
To allow for resets during package download, increase the timeout period after performing a PFR. The time waited is the global config lock timeout plus the normal PFSWR timeout. Signed-off-by: Dan Nowlin Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_c

[dpdk-dev] [PATCH 29/52] net/ice/base: remove unnecessary code

2020-06-02 Thread Qi Zhang
Remove unncessary case branch. Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flow.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 030a55ba7..53ff5f4be 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers

[dpdk-dev] [PATCH 26/52] net/ice/base: use macro for sizeof

2020-06-02 Thread Qi Zhang
The definition of ICE_SW_RULE_RX_TX_ETH_HDR_SIZE open codes the size of a structure field. Replace this with the use of FIELD_SIZEOF. Signed-off-by: Jacob Keller Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.h | 17 - 1 file cha

  1   2   >