[dpdk-dev] [PATCH] net: fix unneeded replacement of 0 by ffff for TCP checksum

2020-07-09 Thread Hongzhi Guo
Per RFC768: If the computed checksum is zero, it is transmitted as all ones. An all zero transmitted checksum value means that the transmitter generated no checksum. RFC793 for TCP has no such special treatment for the checksum of zero. Fixes: 6006818cfb26 ("net: new checksum functions") Cc: sta.

Re: [dpdk-dev] [PATCH v3] eal: use c11 atomic built-ins for interrupt status

2020-07-09 Thread David Marchand
On Thu, Jul 9, 2020 at 10:35 AM Phil Yang wrote: > > The event status is defined as a volatile variable and shared between > threads. Use c11 atomic built-ins with explicit ordering instead of > rte_atomic ops which enforce unnecessary barriers on aarch64. > > The event status has been cleaned up

Re: [dpdk-dev] [PATCH v3 10/15] bus/dpaa: use warn(3) instead of error(3) to improve portability

2020-07-09 Thread Hemant Agrawal
NAK error is different from warning - the return value is also not carried. -Original Message- From: dev On Behalf Of Natanael Copa Sent: Wednesday, March 13, 2019 10:37 PM To: dev@dpdk.org Cc: Natanael Copa Subject: [dpdk-dev] [PATCH v3 10/15] bus/dpaa: use warn(3) instead of error(3)

Re: [dpdk-dev] [PATCH v3 13/15] crypto/dpaa2_sec: simplify pr_{debug, err, warn} macros

2020-07-09 Thread Hemant Agrawal
Change it to new location drivers/common/dpaax/caamflib/compat.h Acked-by: Hemant Agrawal -Original Message- From: dev On Behalf Of Natanael Copa Sent: Wednesday, March 13, 2019 10:37 PM To: dev@dpdk.org Cc: Natanael Copa Subject: [dpdk-dev] [PATCH v3 13/15] crypto/dpaa2_sec: simplify

Re: [dpdk-dev] [PATCH v3 12/15] crypto/dpaa2_sec: build fix for musl libc

2020-07-09 Thread Hemant Agrawal
The location of the file has been changed from drivers/crypto/dpaa2_sec/hw/compat.h to: drivers/common/dpaax/caamflib/compat.h In next version you can add Acked-by: Hemant Agrawal -Original Message- From: dev On Behalf Of Natanael Copa Sent: Wednesday, March 13, 2019 10:37 PM To: d

Re: [dpdk-dev] [PATCH v3 13/15] crypto/dpaa2_sec: simplify pr_{debug, err, warn} macros

2020-07-09 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v3 11/15] bus/dpaa: fix warning: "__WORDSIZE" is not defined, evaluates to 0

2020-07-09 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] Re: [PATCH 1/6] net/qede: define PCI config space specific osals

2020-07-09 Thread Jerin Jacob
On Fri, Jul 10, 2020 at 3:58 AM Manish Chopra wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Thursday, July 9, 2020 9:41 PM > > To: Manish Chopra > > Cc: Gaetan Rivet ; Jerin Jacob Kollanukkaran > > ; Ferruh Yigit ; dpdk-dev > > ; Igor Russkikh ; Rasesh Mody > > ; GR-Eve

Re: [dpdk-dev] [PATCH v3 0/8] update base code batch 3

2020-07-09 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Friday, July 10, 2020 10:14 AM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh ; > Guo, Junfeng > Subject: [PATCH v3 0/8] update base code batch 3 > > The patchset include couple bug fixes and code

[dpdk-dev] [PATCH V2] net/bonding: fix lacp negotiation failed

2020-07-09 Thread luyicai
From: Yicai Lu When two host is connected directly without any devices like switch, rx_machine_update would recieving partner lacp negotiation packets, and partner's port mac is filled with zeros in this packet, which is different with internal's mode4 mac. So in this situation, it would never go

Re: [dpdk-dev] [PATCH v2 0/6] Restrict pointer aliasing with a commonwrapper

2020-07-09 Thread Joyce Kong
> -Original Message- > From: Morten Brørup > Sent: Thursday, July 9, 2020 9:53 PM > To: Joyce Kong ; maxime.coque...@redhat.com; > jer...@marvell.com; zhihong.w...@intel.com; xiaolong...@intel.com; > beilei.x...@intel.com; jia@intel.com; john.mcnam...@intel.com; > ma...@mellanox.com; s

Re: [dpdk-dev] [PATCH v1 2/2] lib/vhost: restrict pointer aliasing for packed path

2020-07-09 Thread Joyce Kong
> -Original Message- > From: Adrian Moreno > Sent: Wednesday, July 8, 2020 12:26 AM > To: Joyce Kong ; maxime.coque...@redhat.com; > jer...@marvell.com; zhihong.w...@intel.com; xiaolong...@intel.com; > Honnappa Nagarahalli ; Phil Yang > ; Ruifeng Wang > Cc: dev@dpdk.org > Subject: Re: [dp

Re: [dpdk-dev] [PATCH v4 2/2] doc: announce deprecation of refcnt atomic member

2020-07-09 Thread Ruifeng Wang
> -Original Message- > From: Phil Yang > Sent: Thursday, July 9, 2020 11:59 PM > To: olivier.m...@6wind.com; dev@dpdk.org > Cc: step...@networkplumber.org; david.march...@redhat.com; > d...@linux.vnet.ibm.com; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > Subject: [PATCH v4 2/2] doc: a

Re: [dpdk-dev] [PATCH V2] net/i40e: i40e FDIR update rate optimization

2020-07-09 Thread Zhang, Qi Z
> -Original Message- > From: Sun, Chenmin > Sent: Thursday, July 9, 2020 10:40 PM > To: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing ; Wang, Haiyue > > Cc: dev@dpdk.org; Sun, Chenmin > Subject: [PATCH V2] net/i40e: i40e FDIR update rate optimization > > From: Chenmin Sun > > This pa

Re: [dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte restrict

2020-07-09 Thread Joyce Kong
> -Original Message- > From: David Marchand > Sent: Thursday, July 9, 2020 5:58 PM > To: Joyce Kong > Cc: Maxime Coquelin ; jer...@marvell.com; > Zhihong Wang ; Xiaolong Ye > ; Beilei Xing ; Jeff Guo > ; Mcnamara, John ; Matan > Azrad ; Shahaf Shuler ; > Viacheslav Ovsiienko ; Honnappa Na

[dpdk-dev] [PATCH v3 3/3] lib/vhost: restrict pointer aliasing for packed vpmd

2020-07-09 Thread Joyce Kong
Restrict pointer aliasing to allow the compiler to vectorize loop more aggressively. With this patch, a 9.6% improvement is observed in throughput for the packed virtio-net PVP case, and a 2.8% improvement in throughput for the packed virtio-user PVP case. All performance data are measured on Thun

[dpdk-dev] [PATCH v3 2/3] net/virtio: restrict pointer aliasing for NEON vpmd

2020-07-09 Thread Joyce Kong
Restrict pointer aliasing to allow the compiler to vectorize loops more aggressively. With this patch, a 9.6% improvement is observed in throughput for the virtio-net PVP case, and a 2.4% perf improvement in throughput for the virtio-user PVP case. All performance data are measured on ThunderX-2 p

[dpdk-dev] [PATCH v3 1/3] lib/eal: add a common wrapper for restricted pointers

2020-07-09 Thread Joyce Kong
The 'restrict' keyword is recognized in C99, while type qulifier '__restrict' compiles ok in C with all language levels. This patch is to replace the existing 'restrict' with '__rte_restrict' which is a common wrapper supported by all compilers. Signed-off-by: Joyce Kong Reviewed-by: Phil Yang R

[dpdk-dev] [PATCH v3 0/3] restrict pointer aliasing with a common wrapper

2020-07-09 Thread Joyce Kong
As the 'restrict' keyword is recognized in C99, this patchset is to add a wrapper defining '__rte_restrict' which can be supported by all compilers. Then replace the existing 'restrict' and '__restrict' in different vpmds, and optimize vhost/virtio with restricted pointer aliasing for more aggressi

Re: [dpdk-dev] [PATCH v10 3/3] test/lpm: add RCU integration performance tests

2020-07-09 Thread Ruifeng Wang
The ci/checkpatch warning is a false positive. > -Original Message- > From: dev On Behalf Of Ruifeng Wang > Sent: Friday, July 10, 2020 10:22 AM > To: Bruce Richardson ; Vladimir Medvedkin > > Cc: dev@dpdk.org; m...@ashroe.eu; konstantin.anan...@intel.com; > Honnappa Nagarahalli ; nd >

Re: [dpdk-dev] [PATCH v10 1/3] lib/lpm: integrate RCU QSBR

2020-07-09 Thread Ruifeng Wang
The ci/checkpatch warning is a false positive. > -Original Message- > From: Ruifeng Wang > Sent: Friday, July 10, 2020 10:22 AM > To: Bruce Richardson ; Vladimir Medvedkin > ; John McNamara > ; Marko Kovacevic > ; Ray Kinsella ; Neil Horman > > Cc: dev@dpdk.org; konstantin.anan...@intel.

[dpdk-dev] [PATCH v10 3/3] test/lpm: add RCU integration performance tests

2020-07-09 Thread Ruifeng Wang
From: Honnappa Nagarahalli Add performance tests for RCU integration. The performance difference with and without RCU integration is very small (~1% to ~2%) on both Arm and x86 platforms. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Vladimir Me

[dpdk-dev] [PATCH v10 0/3] RCU integration with LPM library

2020-07-09 Thread Ruifeng Wang
This patchset integrates RCU QSBR support with LPM library. Resource reclaimation implementation was splitted from the original series, and has already been part of RCU library. Rework the series to base LPM integration on RCU reclaimation APIs. New API rte_lpm_rcu_qsbr_add is introduced for appl

[dpdk-dev] [PATCH v10 1/3] lib/lpm: integrate RCU QSBR

2020-07-09 Thread Ruifeng Wang
Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR process is integrated for safe tbl8 group reclaim. Refer to RCU documentation to understand various

[dpdk-dev] [PATCH v10 2/3] test/lpm: add LPM RCU integration functional tests

2020-07-09 Thread Ruifeng Wang
Add positive and negative tests for API rte_lpm_rcu_qsbr_add. Also test LPM library behavior when RCU QSBR is enabled. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Acked-by: Vladimir Medvedkin --- app/test/test_lpm.c | 291 +++

[dpdk-dev] [PATCH v3 8/8] net/ice/base: update version

2020-07-09 Thread Junfeng Guo
From: Qi Zhang Update base code version in readme. Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 726593971..1e9c854ae 100644 ---

[dpdk-dev] [PATCH v3 7/8] net/ice/base: clear and free XLT entries on reset

2020-07-09 Thread Junfeng Guo
From: Qi Zhang This fix has been added to address memory leak issues resulting from triggering a sudden driver reset which does not allow us to follow our normal removal flows for SW XLT entries for advanced features. - Adding call to destroy flow profile locks when clearing SW XLT tables. - Ext

[dpdk-dev] [PATCH v3 3/8] net/ice/base: move LLDP function to common module

2020-07-09 Thread Junfeng Guo
From: Qi Zhang To implement a FW workaround for LFC, a set_local_mib must be performed after every link up event. For systems that do not have DCB configured, we need to move the function ice_aq_set_lldp_mib() from the DCB specific ice_dcb.c to ice_common.c so that the driver always has access t

[dpdk-dev] [PATCH v3 6/8] net/ice/base: split capability parse into separate functions

2020-07-09 Thread Junfeng Guo
From: Qi Zhang The ice_parse_caps function is used to convert the capability block data coming from firmware into a structured format used by other parts of the code. The current implementation directly updates the hw->func_caps and hw->dev_caps structures. It is directly called from within ice_

[dpdk-dev] [PATCH v3 5/8] net/ice/base: add capability list AQ function

2020-07-09 Thread Junfeng Guo
From: Qi Zhang The current implementation for reading device and function capabilities from firmware, ice_aq_discover_caps, has potentially undesirable side effects. ice_aq_discover_caps calls ice_parse_caps, resulting in overwriting the capabilities stored in the hw structure. This is ok during

[dpdk-dev] [PATCH v3 2/8] net/ice/base: cleanup some code style

2020-07-09 Thread Junfeng Guo
From: Qi Zhang Cleanup code style issue reported by kernel checkpatch. Signed-off-by: Bruce Allan Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_adminq_cmd.h | 6 -- drivers/net/ice/base/ice_common.c | 2 -- drivers/ne

[dpdk-dev] [PATCH v3 4/8] net/ice/base: clean code in flow director module

2020-07-09 Thread Junfeng Guo
From: Qi Zhang Remove unused macro and function. Declare no external referenced function as static. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_fdir.c | 23 +-- drivers/net/ice/base/ice_fdir.h | 3 --- 2 f

[dpdk-dev] [PATCH v3 1/8] net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist

2020-07-09 Thread Junfeng Guo
From: Qi Zhang An IP header combined with GTP-U header should be regarded as inner layer for RSS, otherwise it mess the field vector between an IPv4 rule and IPv6 rule e.g: testpmd> flow create 0 ingress pattern eth / ipv4 / udp / gtpu / \ gtp_psc / ipv4 / udp / end actions rss types ipv4-udp en

[dpdk-dev] [PATCH v3 0/8] update base code batch 3

2020-07-09 Thread Junfeng Guo
The patchset include couple bug fixes and code clean also update the version number. v3: - adjust code position in ice_rem_rss_cfg_sync in PATCH 1/8 - remove uncessary printf and cleanup code style in PATCH 1/8 v2: - add missing part in ice_rem_rss_cfg_sync in PATCH 1/8 - remove unnessary change

Re: [dpdk-dev] [PATCH v6 2/2] app/testpmd: add send scheduling test capability

2020-07-09 Thread Ferruh Yigit
On 7/9/2020 1:36 PM, Viacheslav Ovsiienko wrote: > This commit adds testpmd capability to provide timestamps on the packets > being sent in the txonly mode. This includes: > > - SEND_ON_TIMESTAMP support >new device Tx offload capability support added, example: > > testpmd> port config

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-09 Thread Ferruh Yigit
On 7/9/2020 1:36 PM, Viacheslav Ovsiienko wrote: > There is the requirement on some networks for precise traffic timing > management. The ability to send (and, generally speaking, receive) > the packets at the very precisely specified moment of time provides > the opportunity to support the connect

Re: [dpdk-dev] [EXT] Re: [PATCH v5 3/4] net/qede: add infrastructure for debug data collection

2020-07-09 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, July 09, 2020 9:37 AM > >On 7/8/2020 11:50 PM, Rasesh Mody wrote: >> The patch adds QEDE PMD ops and APIs to calculate the size and collect >> the debug dump for various firmware components. The patch adds new >> files qede_debug.[ch] that has all the firmware

Re: [dpdk-dev] [EXT] Re: [PATCH v5 4/4] net/qede: add support for get register operation

2020-07-09 Thread Rasesh Mody
>From: Ferruh Yigit >Sent: Thursday, July 09, 2020 9:33 AM > >On 7/8/2020 11:50 PM, Rasesh Mody wrote: >> Add support for .get_reg eth_dev ops which will be used to collect the >> firmware debug data. >> >> PMD on detecting on some HW errors will collect the FW/HW Dump to a >> buffer and then it w

Re: [dpdk-dev] [EXT] Re: [PATCH 1/6] net/qede: define PCI config space specific osals

2020-07-09 Thread Manish Chopra
> -Original Message- > From: Jerin Jacob > Sent: Thursday, July 9, 2020 9:41 PM > To: Manish Chopra > Cc: Gaetan Rivet ; Jerin Jacob Kollanukkaran > ; Ferruh Yigit ; dpdk-dev > ; Igor Russkikh ; Rasesh Mody > ; GR-Everest-DPDK-Dev d...@marvell.com> > Subject: Re: [EXT] Re: [PATCH 1/6] ne

Re: [dpdk-dev] [PATCH v1 1/1] net/hinic/base: modify ETIME errors for FreeBSD

2020-07-09 Thread Ferruh Yigit
On 7/9/2020 2:43 PM, Xiaoyun wang wrote: > Change ETIME errors to ETIMEDOUT, because ETIME is not > defined in FreeBSD which may cause build error. > > Signed-off-by: Xiaoyun wang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue

2020-07-09 Thread Ajit Khaparde
On Thu, Jul 9, 2020 at 5:11 AM Ferruh Yigit wrote: > On 7/9/2020 9:15 AM, David Marchand wrote: > > In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. > > Testing against a n value does not work and we end up with a link issue: > > > > /usr/bin/ld: tf_core/tf_em_common.o: in function > `

Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue

2020-07-09 Thread Ajit Khaparde
On Thu, Jul 9, 2020 at 1:15 AM David Marchand wrote: > In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. > Testing against a n value does not work and we end up with a link issue: > > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc': > .../dpdk/drivers/net/bnxt/

Re: [dpdk-dev] [PATCH v7 0/2] ethdev: minor bugfixes

2020-07-09 Thread Ferruh Yigit
On 7/9/2020 11:43 AM, Wei Hu (Xavier) wrote: > This series are minor bugfixes for rte_ethdev.c. > > Wei Hu (Xavier) (2): > ethdev: fix data room size verification in Rx queue setup > ethdev: fix VLAN offloads set if no relative capabilities > Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

2020-07-09 Thread Ananyev, Konstantin
Hi Olivier, > Hi Konstantin, > > On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > > v2: > > - update Release Notes (as per comments) > > > > Two new sync modes were introduced into rte_ring: > > relaxed tail sync (RTS) and head/tail sync (HTS). > > This change provides user

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix missing include

2020-07-09 Thread David Marchand
On Sun, Jun 21, 2020 at 9:49 AM Yunjian Wang wrote: > > This patch adds the missing include and fixes the build error: > /dpdk/build/include/rte_uuid.h: In function 'rte_uuid_copy': > /dpdk/build/include/rte_uuid.h:58:2: error: implicit declaration > of function 'memcpy' [-Werror=implicit-function

Re: [dpdk-dev] [PATCH] net/dpaa2: avoid multiple PtoV calls

2020-07-09 Thread Ferruh Yigit
On 6/29/2020 12:17 PM, Roman Kapl wrote: > Avoids recalculation of DPAA2_IOVA_TO_VADDR, since this is somewhat > costly function on no-IOMMU setups. > > Brings about 0.5 Gbps improvement at 19 Gbps speeds on LX2160 with 512b > packets. > > Signed-off-by: Roman Kapl > Reviewed-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2 0/3] ring clean up

2020-07-09 Thread David Marchand
On Thu, Jul 9, 2020 at 8:12 AM Feifei Wang wrote: > > From: feifei > > Do some work for ring refactoring, which includes: > 1. remove experimental tags > 2. use element APIs to implement legacy APIs > > Feifei Wang (3): > ring: remove experimental tag for ring reset API > ring: remove experim

Re: [dpdk-dev] [PATCH v5 3/4] net/qede: add infrastructure for debug data collection

2020-07-09 Thread Ferruh Yigit
On 7/8/2020 11:50 PM, Rasesh Mody wrote: > The patch adds QEDE PMD ops and APIs to calculate the size and collect > the debug dump for various firmware components. The patch adds new files > qede_debug.[ch] that has all the firmware debug data collection > infrastructure changes. > > Signed-off-by

Re: [dpdk-dev] [PATCH v5 4/4] net/qede: add support for get register operation

2020-07-09 Thread Ferruh Yigit
On 7/8/2020 11:50 PM, Rasesh Mody wrote: > Add support for .get_reg eth_dev ops which will be used to collect the > firmware debug data. > > PMD on detecting on some HW errors will collect the FW/HW Dump to a > buffer and then it will save it to a file implemented in > qede_save_fw_dump(). > > Du

Re: [dpdk-dev] [PATCH v2] mempool/ring: add support for new ring sync modes

2020-07-09 Thread Olivier Matz
Hi Konstantin, On Mon, Jun 29, 2020 at 05:10:24PM +0100, Konstantin Ananyev wrote: > v2: > - update Release Notes (as per comments) > > Two new sync modes were introduced into rte_ring: > relaxed tail sync (RTS) and head/tail sync (HTS). > This change provides user with ability to select these >

Re: [dpdk-dev] [EXT] Re: [PATCH 1/6] net/qede: define PCI config space specific osals

2020-07-09 Thread Jerin Jacob
On Thu, Jul 9, 2020 at 8:35 PM Manish Chopra wrote: > > > -Original Message- > > From: Jerin Jacob > > Sent: Friday, June 26, 2020 10:24 AM > > To: Manish Chopra ; Gaetan Rivet > > > > Cc: Jerin Jacob Kollanukkaran ; Ferruh Yigit > > ; dpdk-dev ; Igor Russkikh > > ; Rasesh Mody ; GR-Ever

Re: [dpdk-dev] [PATCH 0/2] net/enic: minor flow manager changes

2020-07-09 Thread Ferruh Yigit
On 7/3/2020 3:23 AM, Hyong Youb Kim wrote: > This series enables VLAN push/pop actions. The first patch adds code > to translate rte_flow push/pop actions to flow manager actions. The > second patch extends the debug-print function to print recently added > flow manager actions, including the ones

[dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-09 Thread Phil Yang
Use C11 atomic built-ins with explicit ordering instead of rte_atomic ops which enforce unnecessary barriers on aarch64. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang --- v4: 1. Add union for refcnt_atomic and refcnt in rte_mbuf_ext_shared_info to avoid ABI breakage. (Olivier) 2. Add notice

[dpdk-dev] [PATCH v4 2/2] doc: announce deprecation of refcnt atomic member

2020-07-09 Thread Phil Yang
refcnt_atomic member in structures rte_mbuf and rte_mbuf_ext_shared_info will be deprecated in 20.11 release. Signed-off-by: Phil Yang --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/d

Re: [dpdk-dev] [PATCH] devtools: give some hints for ABI errors

2020-07-09 Thread Dodji Seketeli
Hello, David Marchand writes: > abidiff can provide some more information about the ABI difference it > detected. > In all cases, a discussion on the mailing must happen but we can give > some hints to know if this is a problem with the script calling abidiff, > a potential ABI breakage or an un

[dpdk-dev] [PATCH v9 3/3] test/lpm: add RCU integration performance tests

2020-07-09 Thread Ruifeng Wang
From: Honnappa Nagarahalli Add performance tests for RCU integration. The performance difference with and without RCU integration is very small (~1% to ~2%) on both Arm and x86 platforms. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ruifeng Wang Acked-by: Vladimir Me

[dpdk-dev] [PATCH v9 2/3] test/lpm: add LPM RCU integration functional tests

2020-07-09 Thread Ruifeng Wang
Add positive and negative tests for API rte_lpm_rcu_qsbr_add. Also test LPM library behavior when RCU QSBR is enabled. Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Acked-by: Vladimir Medvedkin --- app/test/test_lpm.c | 291 +++

[dpdk-dev] [PATCH v9 1/3] lib/lpm: integrate RCU QSBR

2020-07-09 Thread Ruifeng Wang
Currently, the tbl8 group is freed even though the readers might be using the tbl8 group entries. The freed tbl8 group can be reallocated quickly. This results in incorrect lookup results. RCU QSBR process is integrated for safe tbl8 group reclaim. Refer to RCU documentation to understand various

[dpdk-dev] [PATCH v9 0/3] RCU integration with LPM library

2020-07-09 Thread Ruifeng Wang
This patchset integrates RCU QSBR support with LPM library. Resource reclaimation implementation was splitted from the original series, and has already been part of RCU library. Rework the series to base LPM integration on RCU reclaimation APIs. New API rte_lpm_rcu_qsbr_add is introduced for appl

Re: [dpdk-dev] [PATCH 1/2] net/netvsc: fix underflow error when external mbuf are used in the receive path

2020-07-09 Thread Ferruh Yigit
On 7/2/2020 1:06 AM, Stephen Hemminger wrote: > On Tue, 23 Jun 2020 18:11:45 -0700 > lon...@linuxonhyperv.com wrote: > >> From: Long Li >> >> When rte_pktmbuf_attach_extbuf() is used, the driver should not decrease the >> reference count in its callback function hn_rx_buf_free_cb, because the >>

[dpdk-dev] [PATCH 20.11 2/5] rawdev: allow drivers to return error from info function

2020-07-09 Thread Bruce Richardson
Since we now allow some parameter checking inside the driver info_get() functions, it makes sense to allow error return from those functions to the caller. Therefore we change the driver callback return type from void to int. Signed-off-by: Bruce Richardson --- drivers/raw/ifpga/ifpga_rawdev.c

[dpdk-dev] [PATCH 20.11 5/5] rawdev: allow queue default config query to return error

2020-07-09 Thread Bruce Richardson
The driver APIs for returning the queue default config can fail if the parameters are invalid, or other reasons, so allow them to return error codes to the rawdev layer and from hence to the app. Signed-off-by: Bruce Richardson --- drivers/raw/ntb/ntb.c | 6 -- drivers/raw/

[dpdk-dev] [PATCH 20.11 4/5] rawdev: add private data length parameter to queue fns

2020-07-09 Thread Bruce Richardson
The queue setup and queue defaults query functions take a void * parameter as configuration data, preventing any compile-time checking of the parameters and limiting runtime checks. Adding in the length of the expected structure provides a measure of typechecking, and can also be used for ABI compa

[dpdk-dev] [PATCH 20.11 3/5] rawdev: add private data length parameter to config fn

2020-07-09 Thread Bruce Richardson
Currently with the rawdev API there is no way to check that the structure passed in via the dev_private pointer in the structure passed to configure API is of the correct type - it's just checked that it is non-NULL. Adding in the length of the expected structure provides a measure of typechecking,

Re: [dpdk-dev] [PATCH v4 1/8] eal: introduce zmm type for AVX 512-bit

2020-07-09 Thread David Marchand
On Thu, Jul 9, 2020 at 4:52 PM Medvedkin, Vladimir wrote: > >> + > >> +#defineZMM_SIZE(sizeof(__x86_zmm_t)) > >> +#defineZMM_MASK(ZMM_SIZE - 1) > > > > Macros in a public header need a RTE_ prefix + this is x86 specific, > > then RTE_X86_. > > > > Looking at the who

[dpdk-dev] [PATCH 20.11 1/5] rawdev: add private data length parameter to info fn

2020-07-09 Thread Bruce Richardson
Currently with the rawdev API there is no way to check that the structure passed in via the dev_private pointer in the dev_info structure is of the correct type - it's just checked that it is non-NULL. Adding in the length of the expected structure provides a measure of typechecking, and can also b

[dpdk-dev] [PATCH 20.11 0/5] Enhance rawdev APIs

2020-07-09 Thread Bruce Richardson
This patchset proposes some internal and externally-visible changes to the rawdev API. If consensus is in favour, I will submit a deprecation notice for the changes for the 20.08 release, so that these ABI/API-breaking changes can be merged in 20.11 The changes are in two areas: * For any APIs whi

Re: [dpdk-dev] [PATCH 1/1] bus/fslmc: fix memory leak in secondary process

2020-07-09 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] Re: [PATCH 1/6] net/qede: define PCI config space specific osals

2020-07-09 Thread Manish Chopra
> -Original Message- > From: Jerin Jacob > Sent: Friday, June 26, 2020 10:24 AM > To: Manish Chopra ; Gaetan Rivet > > Cc: Jerin Jacob Kollanukkaran ; Ferruh Yigit > ; dpdk-dev ; Igor Russkikh > ; Rasesh Mody ; GR-Everest- > DPDK-Dev > Subject: [EXT] Re: [PATCH 1/6] net/qede: define PCI

Re: [dpdk-dev] [PATCH v4 1/8] eal: introduce zmm type for AVX 512-bit

2020-07-09 Thread Medvedkin, Vladimir
Hi David, Thanks for review On 09/07/2020 14:48, David Marchand wrote: On Wed, Jul 8, 2020 at 10:17 PM Vladimir Medvedkin wrote: New data type to manipulate 512 bit AVX values. The title mentions a "zmm" type that is not added by this patch. Maybe instead, "eal/x86: introduce AVX 512-bit

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: add flow translation of eCPRI header

2020-07-09 Thread Bing Zhao
Got it, I will add it. Thanks for your comments. BR. Bing > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 9, 2020 8:22 PM > To: Bing Zhao > Cc: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh > ; Matan Azrad ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] net/m

Re: [dpdk-dev] [PATCH v8 1/3] lib/lpm: integrate RCU QSBR

2020-07-09 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Thursday, July 9, 2020 7:50 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Vladimir Medvedkin > ; John McNamara > ; Marko Kovacevic > ; Ray Kinsella ; Neil Horman > ; dev ; Ananyev, Konstantin > ; Honnappa Nagarahalli > ; nd > Subject:

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

2020-07-09 Thread Thomas Monjalon
09/07/2020 15:56, Levend Sayar: > On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon wrote: > > 09/07/2020 14:32, levendsa...@gmail.com: > > > From: Levend Sayar > > > > > > "extern C" define is added to rte_service_component.h file > > > to be able to use in C++ context > > > > It is a bug. > > The

Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag

2020-07-09 Thread Lukasz Wojciechowski
W dniu 09.07.2020 o 16:09, Bruce Richardson pisze: > On Thu, Jul 09, 2020 at 03:51:25PM +0200, Lukasz Wojciechowski wrote: >> W dniu 26.06.2020 o 18:56, Bruce Richardson pisze: >>> On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: A new boolean meson build flag is introdu

Re: [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-09 Thread Phil Yang
> > > > > > > Hi Phil, > > > > > > On Thu, Jul 09, 2020 at 06:10:42PM +0800, Phil Yang wrote: > > > > Use C11 atomic built-ins with explicit ordering instead of > > > > rte_atomic ops which enforce unnecessary barriers on aarch64. > > > > > > > > Signed-off-by: Phil Yang > > > > Reviewed-by: R

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-07-09 Thread Lukasz Wojciechowski
W dniu 22.04.2020 o 14:24, Thomas Monjalon pisze: > 22/04/2020 13:29, Ananyev, Konstantin: >>> 22/04/2020 12:55, Bruce Richardson: On Wed, Apr 22, 2020 at 12:41:49PM +0200, Lukasz Wojciechowski wrote: > W dniu 21.04.2020 o 23:38, Thomas Monjalon pisze: >> 21/04/2020 22:58, Lukasz Woj

Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag

2020-07-09 Thread Bruce Richardson
On Thu, Jul 09, 2020 at 03:51:25PM +0200, Lukasz Wojciechowski wrote: > > W dniu 26.06.2020 o 18:56, Bruce Richardson pisze: > > On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: > >> A new boolean meson build flag is introduced with this patch: rte_debug. > >> To enable this o

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

2020-07-09 Thread Levend Sayar
Sure I agree Thomas. Thanks in advance. Best, Levend On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon wrote: > 09/07/2020 14:32, levendsa...@gmail.com: > > From: Levend Sayar > > > > "extern C" define is added to rte_service_component.h file > > to be able to use in C++ context > > It is a bug.

Re: [dpdk-dev] [PATCH v2 0/6] Restrict pointer aliasing with a commonwrapper

2020-07-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > Sent: Monday, July 6, 2020 9:49 AM > > As the 'restrict' keyword is recognized in C99, this patchset is to > add a wrapper defining '__rte_restrict' which can be supported by > all compilers. Then replace the existing 'restrict' a

Re: [dpdk-dev] [PATCH v2 1/3] config: introduce global rte debug flag

2020-07-09 Thread Lukasz Wojciechowski
W dniu 26.06.2020 o 18:56, Bruce Richardson pisze: > On Wed, Apr 22, 2020 at 11:45:53PM +0200, Lukasz Wojciechowski wrote: >> A new boolean meson build flag is introduced with this patch: rte_debug. >> To enable this option add -Drte_debug=true to the meson configure command. >> >> By enabling th

Re: [dpdk-dev] [PATCH v2 3/3] mbuf: standardize library debug flag

2020-07-09 Thread Lukasz Wojciechowski
W dniu 26.06.2020 o 19:00, Bruce Richardson pisze: > On Wed, Apr 22, 2020 at 11:45:55PM +0200, Lukasz Wojciechowski wrote: >> Use standardized debug macro RTE_DEBUG_MBUF instead of >> RTE_LIBRTE_MBUF_DEBUG for wrapping sanity checks. >> >> Add runtime control of running sanity checks basing on >>

[dpdk-dev] [PATCH v3 4/4] app/test: add mbuf perf tests

2020-07-09 Thread Lukasz Wojciechowski
This patch adds new test command mbuf_perf_autotest to test app, which executes six basic performance tests: * alloc_free - allocation and freeing mbufs one by one * bulk_alloc_free - as above but in bulks * data_manipulation - few command modifying mbuf * sanity_checks_without_header - only sanity

[dpdk-dev] [PATCH] app/testpmd: fix the default RSS key configuration

2020-07-09 Thread Lijun Ou
When an user runs a flow create cmd to configure an RSS rule without specifying the empty rss actions in testpmd, this mean that the flow gets the default RSS functions. However, the testpmd is not set the default RSS key incorrectly when RSS key is specified in flow create cmd. Now, it uses rte_e

[dpdk-dev] [PATCH v3 3/4] mbuf: standardize library debug flag

2020-07-09 Thread Lukasz Wojciechowski
Use standardized debug macro RTE_DEBUG_MBUF instead of RTE_LIBRTE_MBUF_DEBUG for wrapping sanity checks. Add runtime control of running sanity checks basing on rte_log_can_log() function. To run mbuf sanity checks all following conditions must occur: 1) RTE_DEBUG_MBUF - must be defined, this can

[dpdk-dev] [PATCH v3 2/4] config: remove unused config flags

2020-07-09 Thread Lukasz Wojciechowski
Following flags were still present in the common_base config, but they were not used anywhere in the code: * CONFIG_RTE_LIBRTE_ACL_DEBUG * CONFIG_RTE_LIBRTE_NFP_DEBUG_TX * CONFIG_RTE_LIBRTE_NFP_DEBUG_RX * CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO_DEBUG Signed-off-by: Lukasz Wojciechowski --- config/com

[dpdk-dev] [PATCH v3 0/4] introduce global debug flag

2020-07-09 Thread Lukasz Wojciechowski
This set of patches introduces a global rte_debug flag for dpdk. This will allow easy switch to debug build configuration using a single flag. In the debug mode a RTE_DEBUG macro is defined to 1 and for every enabled to be built library a RTE_DEBUG_{library name} and for every enabled to be built d

[dpdk-dev] [PATCH v3 1/4] config: introduce global rte debug flag

2020-07-09 Thread Lukasz Wojciechowski
A new boolean meson build flag is introduced with this patch: rte_debug. To enable this option add -Drte_debug=true to the meson configure command. By enabling this flag the globaly defined macro RTE_DEBUG becomes defined. It should be used for enabling debug code in all dpdk project components. U

Re: [dpdk-dev] [PATCH v4 1/8] eal: introduce zmm type for AVX 512-bit

2020-07-09 Thread David Marchand
On Wed, Jul 8, 2020 at 10:17 PM Vladimir Medvedkin wrote: > > New data type to manipulate 512 bit AVX values. The title mentions a "zmm" type that is not added by this patch. Maybe instead, "eal/x86: introduce AVX 512-bit type" > > Signed-off-by: Vladimir Medvedkin > Acked-by: Konstantin Anan

Re: [dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16

2020-07-09 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fady Bader > Sent: Wednesday, July 8, 2020 10:25 AM > > htons wasn't defined in Windows for the minGW compiler. > htons was replaced with rte_cpu_to_be_16 in order to compile > under Windows. > > Signed-off-by: Fady Bader > --- > lib/librte

Re: [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-09 Thread Honnappa Nagarahalli
> > > > Hi Phil, > > > > On Thu, Jul 09, 2020 at 06:10:42PM +0800, Phil Yang wrote: > > > Use C11 atomic built-ins with explicit ordering instead of > > > rte_atomic ops which enforce unnecessary barriers on aarch64. > > > > > > Signed-off-by: Phil Yang > > > Reviewed-by: Ruifeng Wang > > > ---

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

2020-07-09 Thread Thomas Monjalon
09/07/2020 14:32, levendsa...@gmail.com: > From: Levend Sayar > > "extern C" define is added to rte_service_component.h file > to be able to use in C++ context It is a bug. The title should be "service: fix C++ linkage" And these tags must be added: Fixes: 21698354c832 ("service: introduce servi

[dpdk-dev] [PATCH v1 0/1] modify ETIME errors for FreeBSD

2020-07-09 Thread Xiaoyun wang
Change ETIME to ETIMEDOUT, because ETIME is not defined in FreeBSD which may cause build error. -- v1: - modify ETIME errors for FreeBSD Xiaoyun wang (1): net/hinic/base: modify ETIME errors for FreeBSD drivers/net/hinic/base/hinic_pmd_hwdev.c | 2 +- drivers/net/hinic/base/hinic_pmd_hwif.

[dpdk-dev] [PATCH v1 1/1] net/hinic/base: modify ETIME errors for FreeBSD

2020-07-09 Thread Xiaoyun wang
Change ETIME errors to ETIMEDOUT, because ETIME is not defined in FreeBSD which may cause build error. Signed-off-by: Xiaoyun wang --- drivers/net/hinic/base/hinic_pmd_hwdev.c | 2 +- drivers/net/hinic/base/hinic_pmd_hwif.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [dpdk-dev] [EXT] RE: [PATCH 6/6] app/test-eventdev: fix eventdev queues

2020-07-09 Thread Apeksha Gupta
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, July 2, 2020 8:57 AM > To: Apeksha Gupta ; > jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; tho...@monjalon.net; Hemant Agrawal > ; Nipun Gupta ; Akhil > Goyal ; sta...@dpdk.org > Subject: [EXT] RE: [dpdk-dev

Re: [dpdk-dev] [PATCH v3] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-09 Thread Phil Yang
Hi Oliver, > -Original Message- > From: Olivier Matz > Sent: Thursday, July 9, 2020 7:04 PM > To: Phil Yang > Cc: dev@dpdk.org; step...@networkplumber.org; > david.march...@redhat.com; d...@linux.vnet.ibm.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; nd > Subject: Re: [PATCH v3] mbuf:

[dpdk-dev] [PATCH v6 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-09 Thread Viacheslav Ovsiienko
There is the requirement on some networks for precise traffic timing management. The ability to send (and, generally speaking, receive) the packets at the very precisely specified moment of time provides the opportunity to support the connections with Time Division Multiplexing using the contempora

Re: [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action

2020-07-09 Thread Thomas Monjalon
09/07/2020 14:25, Andrey Vesnovaty: > Hi, Jerin and Ferruh > > First of all it's decided to postpone this effort to 20.11. > @jer...@marvell.com I sincerely believe we can work out great API for > - shared action, context > - action update / modification / replacement > after 20.08 without time p

[dpdk-dev] [PATCH v6 2/2] app/testpmd: add send scheduling test capability

2020-07-09 Thread Viacheslav Ovsiienko
This commit adds testpmd capability to provide timestamps on the packets being sent in the txonly mode. This includes: - SEND_ON_TIMESTAMP support new device Tx offload capability support added, example: testpmd> port config 0 tx_offload send_on_timestamp on - set txtimes, registers fi

[dpdk-dev] [PATCH v3] service: support C++ linkage

2020-07-09 Thread levendsayar
From: Levend Sayar "extern C" define is added to rte_service_component.h file to be able to use in C++ context Signed-off-by: Levend Sayar Acked-by: Harry van Haaren --- lib/librte_eal/include/rte_service_component.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: introduce accurate packet Tx scheduling

2020-07-09 Thread Thomas Monjalon
08/07/2020 17:47, Viacheslav Ovsiienko: > There is the requirement on some networks for precise traffic timing > management. The ability to send (and, generally speaking, receive) > the packets at the very precisely specified moment of time provides > the opportunity to support the connections with

  1   2   >