[dpdk-dev] [PATCH v3] net/i40e: fix fdir cannot receive rx writeback issue

2020-07-16 Thread chenmin . sun
From: Chenmin Sun This patch fixes the fdir cannot receive rx writeback packet issue. The root cause is FDIR interrupt is not correctly enabled. Beside this, to make sure fdir programming works fine when the port is stopped, move the fdir interrupt configure from start/stop to setup/teardown. F

[dpdk-dev] [dpdk-dev v1] net/iavf: fix simple xor hash

2020-07-16 Thread Jeff Guo
Simple xor hash should be global congfigured in VFs. Fixes: 215a247b5f33 ("net/iavf: refactor hash flow") Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 46 +++- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_has

[dpdk-dev] [PATCH v9 1/3] doc: add optimizations using C11 atomic builtins

2020-07-16 Thread Phil Yang
Add information about possible optimizations using C11 atomic builtins. Signed-off-by: Phil Yang Signed-off-by: Honnappa Nagarahalli Reviewed-by: Honnappa Nagarahalli --- doc/guides/prog_guide/writing_efficient_code.rst | 59 +++- 1 file changed, 58 insertions(+), 1 deletio

[dpdk-dev] [PATCH v9 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
In order to deprecate the rte_atomic and rte_smp barrier APIs, prevent the patches from using these APIs and __sync builtins in new code. On x86 the __atomic_thread_fence(__ATOMIC_SEQ_CST) is quite expensive for SMP case. Flag the new code which use __atomic_thread_fence API. Signed-off-by: Phil

[dpdk-dev] [PATCH v9 3/3] eal/atomic: add wrapper for C11 atomic thread fence

2020-07-16 Thread Phil Yang
Provide a wrapper for __atomic_thread_fence builtins to support optimized code for __ATOMIC_SEQ_CST memory order for x86 platforms. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Reviewed-by: Ola Liljedahl Acked-by: Konstantin Ananyev --- lib/librte_eal/arm/include/rte_atomic_32.

[dpdk-dev] [PATCH v9 0/3] generic rte atomic APIs deprecate proposal

2020-07-16 Thread Phil Yang
DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync builtins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
Honnappa Nagarahalli writes: > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > > atomic APIs in future patches > > > > > > > > 16/07/2020 12:48, David Marchand: > > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > > > > check_forbidden_addit

Re: [dpdk-dev] [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins

2020-07-16 Thread Phil Yang
Honnappa Nagarahalli writes: > > > Subject: [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins > > > > Add information about possible optimizations using C11 atomic built-ins. > > > > Signed-off-by: Phil Yang > > Signed-off-by: Honnappa Nagarahalli > > Thanks for the changes, t

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread Phil Yang
> On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > > Just for the sake of precision, I'd like to say that in the coming 1.8 > > version of libabigail, this change won't be reported by the tooling as a > > problem anymore. This is thanks to David filing the feature request > > https://sou

[dpdk-dev] [PATCH v5 2/2] doc: announce deprecation of refcnt atomic member

2020-07-16 Thread Phil Yang
refcnt_atomic member in structures rte_mbuf and rte_mbuf_ext_shared_info will be deprecated in 20.11 release. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Acked-by: Konstantin Ananyev --- doc/guides/rel_notes/deprecation.rst | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[dpdk-dev] [PATCH v5 1/2] mbuf: use C11 atomic builtins for refcnt operations

2020-07-16 Thread Phil Yang
Use C11 atomic builtins with explicit ordering instead of rte_atomic ops which enforce unnecessary barriers on aarch64. Suggested-by: Olivier Matz Suggested-by: Dodji Seketeli Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Acked-by: Olivier Matz --- v5: 1. Change built-ins to builtins. 2.

[dpdk-dev] [dpdk-dev v1] net/iavf: fix simple xor hash

2020-07-16 Thread Jeff Guo
Simple xor hash should be global congfigured in VFs. Fixes: 215a247b5f33 (net/iavf: refactor hash flow) Signed-off-by: Jeff Guo --- drivers/net/iavf/iavf_hash.c | 46 +++- 1 file changed, 30 insertions(+), 16 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.

[dpdk-dev] [PATCH] net/ice: fix issue for GTPU and GTPU extension packet

2020-07-16 Thread Simei Su
Because of incomplete protocol header fields, GTPU_INNER_IPV4_UDP and GTPU_INNER_IPV4_TCP profile aren't included in inner ipv4 group. This patch complements header fields for GTPU/GTPU_EH ipv4 rss config. Besides, after configuring L4 port, GTPU and GTPU_EH packets don't do hash for UDP/TCP/SCTP.

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-16 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 15, 2020 7:15 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Fu, Patrick ; Wang, Yinan > Subject: [PATCH v2] vhost: support async copy free segmentations > > From: Patrick Fu > > Vhost async enq

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-16 Thread Xia, Chenbo
> -Original Message- > From: Fu, Patrick > Sent: Wednesday, July 15, 2020 11:59 PM > To: dev@dpdk.org; maxime.coque...@redhat.com; Xia, Chenbo > > Cc: Wang, Yinan ; Fu, Patrick > Subject: [PATCH v1] vhost: set zmbufs to NULL when freed > > From: Patrick Fu > > zmbufs should be set t

Re: [dpdk-dev] [PATCH] net/bnxt: remove unneeded experimental build flag

2020-07-16 Thread Ajit Khaparde
On Thu, Jul 16, 2020 at 3:50 PM Ajit Khaparde wrote: > > On Thu, Jul 16, 2020 at 12:26 AM David Marchand > wrote: > >> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation. >> See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 >> >> Fixes: 322bd6e70272 ("net/bnxt: add port represent

Re: [dpdk-dev] [PATCH v4 00/10] bnxt patches

2020-07-16 Thread Ajit Khaparde
On Wed, Jul 15, 2020 at 6:55 AM Somnath Kotur wrote: > Minor enhancments added to the TF-ULP/Core layers > > Farah Smith (1): > net/bnxt: add changes to support 2 table scopes > > Jay Ding (2): > net/bnxt: implement TF Identifier search > net/bnxt: check index range in bulk get > > Kishore

Re: [dpdk-dev] [PATCH] net/bnxt: remove unneeded experimental build flag

2020-07-16 Thread Ajit Khaparde
On Thu, Jul 16, 2020 at 12:26 AM David Marchand wrote: > -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation. > See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5 > > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > > Signed-off-by: David Marchand > Acked-by:

[dpdk-dev] [PATCH v2] net/ice: fix incorrect Rx/Tx bytes statistics

2020-07-16 Thread Junyu Jiang
This patch fixed the issue that rx/tx bytes overflowed on 40 bit limitation by enlarging the limitation. Fixes: a37bde56314d ("net/ice: support statistics") Cc: sta...@dpdk.org Signed-off-by: Junyu Jiang --- drivers/net/ice/ice_ethdev.c | 36 drivers/net/ice

Re: [dpdk-dev] [PATCH v3 0/6] vhost: improve ready state

2020-07-16 Thread Wang, Yinan
Hi Matan, In our daily regression test, we found this patch set will decrease virtio performance and causes virtio interrupt not working properly in multi queue scenarios. Could you help to take a look? Details in Bugzilla https://bugs.dpdk.org/show_bug.cgi?id=507, btw, pls use low qemu vers

Re: [dpdk-dev] [PATCH] lib/librte_eal/common/rte_malloc: remove redundant check for size and alignment

2020-07-16 Thread Lukasz Wojciechowski
W dniu 15.07.2020 o 15:31, Sarosh Arif pisze: > Since mallock_socket() always calls malloc_heap_alloc() and > this check is present inside malloc_heap_alloc() so there is > no need to place it in mallock_socket(). > > Signed-off-by: Sarosh Arif > --- > lib/librte_eal/common/rte_malloc.c | 4

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: > On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > > On Wed, 15 Jul 2020 14:28:17 +0100 > > "Burakov, Anatoly" wrote: > > > >>> -#define SKIP_MASTER SKIP_INITIAL > >>> -#define CALL_MASTER CALL_INITIAL > >>> +#define SKIP_

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 14:41:41 +0100 "Burakov, Anatoly" wrote: > On 15-Jul-20 9:29 PM, Stephen Hemminger wrote: > > On Wed, 15 Jul 2020 14:28:17 +0100 > > "Burakov, Anatoly" wrote: > > > >>> -#define SKIP_MASTER SKIP_INITIAL > >>> -#define CALL_MASTER CALL_INITIAL > >>> +#define SKIP_

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 16:59:11 + Honnappa Nagarahalli wrote: > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > > atomic APIs in future patches > > > > > > > > 16/07/2020 12:48, David Marchand: > > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang w

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 16:44:29 +0200 Robin Jarry wrote: > 2020-07-13, Bruce Richardson: > > In the absense of a "proper" solution, is the simplest option to > > change the shebangs to all be python3, but leave the python2 > > compatibility in place, and add the warnings for anyone running it > > ex

Re: [dpdk-dev] [PATCH v2 1/2] eal/windows: add needed calls to detect vdev PMD

2020-07-16 Thread Narcisa Ana Maria Vasile
On Tue, Jul 07, 2020 at 11:48:22AM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > Add needed function calls in rte_eal_init to detect vdev PMD. > > eal_option_device_parse() > rte_service_init() > rte_bus_probe() > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/common/

Re: [dpdk-dev] [PATCH v2 2/2] bus/vdev: build on Windows

2020-07-16 Thread Narcisa Ana Maria Vasile
On Tue, Jul 07, 2020 at 11:48:23AM +0300, tal...@mellanox.com wrote: > From: Tal Shnaiderman > > current support will build vdev with empty MP functions > currently unsupported for Windows. > > Signed-off-by: Tal Shnaiderman > --- > drivers/bus/vdev/meson.build | 6 -- > lib/librte_e

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Manish Chopra
> -Original Message- > From: Gaëtan Rivet > Sent: Thursday, July 16, 2020 11:26 PM > To: Thomas Monjalon > Cc: Jerin Jacob ; Manish Chopra > ; Ferruh Yigit ; Igor > Russkikh ; dpdk-dev > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add > rte_pci_regs.h > > External Email

[dpdk-dev] [20.11, PATCH v2] baseband/fpga_5gnr_fec: add companion PF config App

2020-07-16 Thread Nicolas Chautru
Adding companion application to configure HW Device from the PF. Then the device can be accessed through BBDEV from VF (or PF). Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/fpga_5gnr_fec.rst| 80 +++-- .../baseband/fpga_5gnr_fec/pf_config_app/Makefile | 36 +++ .../fpg

Re: [dpdk-dev] [PATCH v3 00/17] net/mlx5: introduce accurate packet Tx scheduling

2020-07-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Thursday, July 16, 2020 11:23 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; olivier.m...@6wind.com; Thomas Monjalon > ; ferruh.yi...@intel.com > Subject: [PATCH v3 00/17] net/mlx5: introduce accurate packet Tx

[dpdk-dev] [20.11, PATCH v2] BBDEV FPGA PF Config app

2020-07-16 Thread Nicolas Chautru
v2: Couple of typos in documentation and removed dependency on igb_uio and related PCIe VF creation feature option. Addition of an stand alone application in PMD driver to be able to configure the HW from PF. Then the VF can be used from container/VM running BBDEV/DPDK. The history of the pre

Re: [dpdk-dev] [PATCH v1] baseband/fpga_5gnr_fec: add companion PF config App

2020-07-16 Thread Chautru, Nicolas
> From: David Marchand > On Sat, Jul 11, 2020 at 12:28 AM Nicolas Chautru > wrote: > > [snip] > > > +#define SYS_DIR "/sys/bus/pci/devices" > > +#define CUR_DIR "." > > +#define PREV_DIR ".." > > + > > +#define DRIVER_LINK "driver" > > +#define DEVICE_FILE "device" > > +#define VENDOR_FILE "

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: use C11 atomic built-ins for refcnt operations

2020-07-16 Thread David Marchand
On Thu, Jul 16, 2020 at 3:21 PM Dodji Seketeli wrote: > Just for the sake of precision, I'd like to say that in the coming 1.8 > version of libabigail, this change won't be reported by the tooling as a > problem anymore. This is thanks to David filing the feature request > https://sourceware.org/

[dpdk-dev] [PATCH v2] test/crypto: skip unsupported cases

2020-07-16 Thread Akhil Goyal
blockcipher cases are either returning TEST_SUCCESS or TEST_FAILED as status, but the test may not be supported by the PMD which is also a success case for the PMD. Hence checking for status == TEST_FAILED for setting the overall status as failed. Signed-off-by: Akhil Goyal --- app/test/test_cry

Re: [dpdk-dev] [PATCH v1] test/crypto: fix AESNI-MB CPU tests

2020-07-16 Thread Akhil Goyal
> The AESNI-MB CPU test cases, which are executed via the > cryptodev_cpu_aesni_mb_autotest command, aborted when it tried to run > the DOCSIS security tests as these are not CPU type tests. The abort > happened at the following line in process_crypto_request(): > > RTE_VERIFY(gbl_action_type != R

Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro

2020-07-16 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH] eal: change the log level for test assert macro > > On Wed, Jul 15, 2020 at 10:20 PM Honnappa Nagarahalli > wrote: > > > > Change the log level for RTE_TEST_ASSERT macro to error to help log > > errors while running test cases. > > > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro

2020-07-16 Thread Honnappa Nagarahalli
> Subject: Re: [PATCH] eal: change the log level for test assert macro > > Honnappa Nagarahalli writes: > > > Change the log level for RTE_TEST_ASSERT macro to error to help log > > errors while running test cases. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > Is the default to alw

[dpdk-dev] [PATCH v2] eal: change the log level for test assert macro

2020-07-16 Thread Honnappa Nagarahalli
Change the log level for RTE_TEST_ASSERT macro to error to help log errors while running test cases. Suggested-by: David Marchand Signed-off-by: Honnappa Nagarahalli Acked-by: Aaron Conole Acked-by: Lukasz Wojciechowski --- v2 - Added the suggested-by tag lib/librte_eal/include/rte_test.h |

Re: [dpdk-dev] [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins

2020-07-16 Thread Honnappa Nagarahalli
> Subject: [PATCH v8 1/3] doc: add optimizations using C11 atomic built-ins > > Add information about possible optimizations using C11 atomic built-ins. > > Signed-off-by: Phil Yang > Signed-off-by: Honnappa Nagarahalli Thanks for the changes, they look good now. David wanted to change 'bui

Re: [dpdk-dev] [PATCH v1] baseband/fpga_5gnr_fec: add companion PF config App

2020-07-16 Thread Chautru, Nicolas
> From: Akhil Goyal > Hi Nicholas, > > > Subject: [PATCH v1] baseband/fpga_5gnr_fec: add companion PF config App > > > > Adding companion application to configure HW Device from the PF. > > Then the device can be accessed through BBDEV from VF (or PF). > > > > Signed-off-by: Nicolas Chautru > >

Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Gaëtan Rivet
On 16/07/20 18:57 +0200, Thomas Monjalon wrote: > 16/07/2020 18:43, Jerin Jacob: > > On Thu, Jul 16, 2020 at 9:25 PM Thomas Monjalon wrote: > > > > > > 16/07/2020 15:02, Jerin Jacob: > > > > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 16/07/2020 13:55, Jeri

Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Jerin Jacob
On Thu, Jul 16, 2020 at 10:27 PM Thomas Monjalon wrote: > > 16/07/2020 18:43, Jerin Jacob: > > On Thu, Jul 16, 2020 at 9:25 PM Thomas Monjalon wrote: > > > > > > 16/07/2020 15:02, Jerin Jacob: > > > > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 16/07/2020

Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

2020-07-16 Thread Akhil Goyal
> The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable device configuration option for all cryptodev tests, > including security related tests. This patch updates the cryptodev unit > tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP > security tests. > >

Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

2020-07-16 Thread Akhil Goyal
> > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable device configuration option for all crypto performance tests, > including security related tests. This patch updates the crypto > performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and > PDCP security

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Honnappa Nagarahalli
> > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte > > > atomic APIs in future patches > > > > > > 16/07/2020 12:48, David Marchand: > > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > > > check_forbidden_additions() { # > > > > > res=0 > > > > > +

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd documentation typos

2020-07-16 Thread Ferruh Yigit
On 7/15/2020 11:30 AM, Viacheslav Ovsiienko wrote: > Fix minor typos. > > Fixes: 4940344dab1d ("app/testpmd: add Tx scheduling command") > > Signed-off-by: Viacheslav Ovsiienko Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Thomas Monjalon
16/07/2020 18:43, Jerin Jacob: > On Thu, Jul 16, 2020 at 9:25 PM Thomas Monjalon wrote: > > > > 16/07/2020 15:02, Jerin Jacob: > > > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon > > > wrote: > > > > > > > > 16/07/2020 13:55, Jerin Jacob: > > > > > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjal

Re: [dpdk-dev] [PATCH v3 2/2] doc: update QAT PMD release notes

2020-07-16 Thread Akhil Goyal
Hi Adam, > > This patch separates QAT PMD paragraphs in the release notes > into three parts, for QAT Symmetric Crypto PMD, QAT Asymmetric > Crypto PMD and QAT Compression PMD. > > Signed-off-by: Adam Dybkowski > --- > doc/guides/rel_notes/release_20_08.rst | 10 +- > 1 file changed, 9

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: enable rte_flow based packet distribution

2020-07-16 Thread Akhil Goyal
Hi Ankur, > > > >From: Anoob Joseph > > > >RTE_FLOW API allows hardware parsing and steering of packets to specific > >queues which helps in distributing ingress traffic across various cores. > >Adding 'flow' rules allows user to specify the distribution required. > > > >Signed-off-by: Anoob Josep

Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Jerin Jacob
On Thu, Jul 16, 2020 at 9:25 PM Thomas Monjalon wrote: > > 16/07/2020 15:02, Jerin Jacob: > > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon wrote: > > > > > > 16/07/2020 13:55, Jerin Jacob: > > > > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 16/07/2020 1

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Thomas Monjalon
16/07/2020 18:37, Phil Yang: > Hello, > > Thomas Monjalon writes: > > > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic > > APIs in future patches > > > > 16/07/2020 12:48, David Marchand: > > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > > check_forbidde

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
Hello, Thomas Monjalon writes: > Subject: Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic > APIs in future patches > > 16/07/2020 12:48, David Marchand: > > On Thu, Jul 16, 2020 at 6:58 AM Phil Yang wrote: > > > check_forbidden_additions() { # > > > res=0 > > > +

Re: [dpdk-dev] [PATCH v3 0/8] add OCTEON TX2 lookaside IPsec support

2020-07-16 Thread Akhil Goyal
> > > This series adds lookaside IPsec support in OCTEON TX2 PMD. > > > > Features supported: > > * IPv4 > > * ESP > > * Tunnel mode > > * AES-128/192/256-GCM > > > > v3: > > * Fixed PMD documentation and release notes updates > > * Squashed enqueue and dequeue patches > > * Removed unused code >

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix uninitialized variable

2020-07-16 Thread Ferruh Yigit
On 7/15/2020 7:32 AM, Adrian Moreno wrote: > > On 7/14/20 1:03 PM, Chenbo Xia wrote: >> This patch fixes an issue that uninitialized has_reply_ack >> is used for setting message flags. >> >> Coverity issue: 360834 >> Fixes: c60208dd6384 ("net/virtio-user: support reply-ack") >> >> Signed-off-by: C

[dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup

2020-07-16 Thread David Coyle
This patch makes some minor improvements to the security instance setup for the AESNI-MB PMD. All of this setup code is now in one '#ifdef AESNI_MB_DOCSIS_SEC_ENABLED' block. Enabling the RTE_CRYPTODEV_FF_SECURITY feature for the device is also moved to this block. Fixes: fda5216fba55 ("crypto/aes

[dpdk-dev] [PATCH v1 1/2] crypto/qat: improve security instance setup

2020-07-16 Thread David Coyle
This patch makes some minor improvements to the security instance setup for the QAT SYM PMD. All of this setup code is now in one '#ifdef RTE_LIBRTE_SECURITY' block. Enabling the RTE_CRYPTODEV_FF_SECURITY feature for the device is also moved to this block. Fixes: 6f0ef237404b ("crypto/qat: support

[dpdk-dev] [PATCH v1 0/2] improve security instance setup

2020-07-16 Thread David Coyle
These patches make some minor improvements to the security instance setup for the QAT SYM and AESNI-MB PMDs. David Coyle (2): crypto/qat: improve security instance setup crypto/aesni_mb: improve security instance setup drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 13 - drivers/cr

[dpdk-dev] [PATCH v1] crypto/qat: use better variable names in CRC functions

2020-07-16 Thread David Coyle
The variable names crc_length and crc_offset have been changed to crc_data_len and crc_data_ofs respectively, to make it clearer as to their use i.e. the length and offset of the data over which the CRC is calculated. Fixes: 6f0ef237404b ("crypto/qat: support DOCSIS protocol") Signed-off-by: Davi

[dpdk-dev] [PATCH v1] crypto/qat: check for multi-segment buffers for DOCSIS

2020-07-16 Thread David Coyle
Multi-segment mbufs are not supported for DOCSIS security protocol. This patch adds an explicit check for this and returns an op error if this case is found. This limitation is also added to the QAT cryptodev documentation. Fixes: 6f0ef237404b ("crypto/qat: support DOCSIS protocol") Signed-off-by

[dpdk-dev] [PATCH v1 0/2] improve DOCSIS session creation

2020-07-16 Thread David Coyle
These patches improve the DOCSIS session creating in the QAT and AESNI-MB PMDs David Coyle (2): crypto/qat: improve DOCSIS session creation crypto/aesni_mb: improve DOCSIS session creation .../crypto/aesni_mb/rte_aesni_mb_pmd_ops.c| 11 --- drivers/crypto/qat/qat_sym_session.c

[dpdk-dev] [PATCH v1 1/2] crypto/qat: improve DOCSIS session creation

2020-07-16 Thread David Coyle
This patch improves the DOCSIS session creation as follows: - it validates the security action type as well as the protocol before creating a session and now does this validation before allocating the session from the mempool - it clears the entire private session struct before populating it wi

[dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve DOCSIS session creation

2020-07-16 Thread David Coyle
This patch improves the DOCSIS session creation as follows: - it validates the security action type as well as the protocol before creating a session and now does this validation before allocating the session from the mempool Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") Si

Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h

2020-07-16 Thread Thomas Monjalon
16/07/2020 15:02, Jerin Jacob: > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon wrote: > > > > 16/07/2020 13:55, Jerin Jacob: > > > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon > > > wrote: > > > > > > > > 16/07/2020 12:27, Jerin Jacob: > > > > > On Thu, Jul 16, 2020 at 3:48 PM Gaëtan Rivet

[dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

2020-07-16 Thread David Coyle
Set the source mbuf data and packet lengths correctly for DOCSIS performance tests. Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol") Signed-off-by: David Coyle --- app/test-crypto-perf/cperf_ops.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cper

[dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests

2020-07-16 Thread David Coyle
The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. Fixe

[dpdk-dev] [PATCH v1 0/2] enable security feature for security tests

2020-07-16 Thread David Coyle
The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev unit tests and crypto performance tests, including security related tests. These patches update the crypto test tools to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP

[dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests

2020-07-16 Thread David Coyle
The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. Fixes: ea31f2b4f

[dpdk-dev] [PATCH v1] test/crypto: fix AESNI-MB CPU tests

2020-07-16 Thread David Coyle
The AESNI-MB CPU test cases, which are executed via the cryptodev_cpu_aesni_mb_autotest command, aborted when it tried to run the DOCSIS security tests as these are not CPU type tests. The abort happened at the following line in process_crypto_request(): RTE_VERIFY(gbl_action_type != RTE_SECURITY_

[dpdk-dev] [PATCH v2] lpm: fix unchecked return value

2020-07-16 Thread Ruifeng Wang
Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. By default, defer queue size is big enough to hold all tbl8 groups. When enqueue fails, return error to the user to indicate system issue. Coverity issue: 360832 Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation")

[dpdk-dev] [PATCH v2] vhost: fix missing null dev pointer check

2020-07-16 Thread patrick . fu
From: Patrick Fu This patch adds the check of dev pointer in vhost async enqueue completion poll. If a NULL dev pointer detected, the poll function returns immediately. Coverity issue: 360839 Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- v2

[dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-16 Thread patrick . fu
From: Patrick Fu Vring should not be touched if vq is disabled. This patch adds the vq status check in async enqueue polling to avoid accessing to a disabled queue. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- lib/librte_vhost/virtio_net.

Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro

2020-07-16 Thread Lukasz Wojciechowski
W dniu 15.07.2020 o 22:20, Honnappa Nagarahalli pisze: > Change the log level for RTE_TEST_ASSERT macro to error to help > log errors while running test cases. > > Signed-off-by: Honnappa Nagarahalli > --- > lib/librte_eal/include/rte_test.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [dpdk-dev] [PATCH V4 2/4] net/i40e: FDIR flow memory management optimization

2020-07-16 Thread Wu, Jingjing
> -Original Message- > From: Sun, Chenmin > Sent: Thursday, July 16, 2020 3:53 AM > To: Zhang, Qi Z ; Xing, Beilei ; > Wu, > Jingjing ; Wang, Haiyue > Cc: dev@dpdk.org; Sun, Chenmin > Subject: [PATCH V4 2/4] net/i40e: FDIR flow memory management optimization > > From: Chenmin Sun >

Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro

2020-07-16 Thread David Marchand
On Wed, Jul 15, 2020 at 10:20 PM Honnappa Nagarahalli wrote: > > Change the log level for RTE_TEST_ASSERT macro to error to help > log errors while running test cases. > > Signed-off-by: Honnappa Nagarahalli > --- > lib/librte_eal/include/rte_test.h | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [dpdk-dev] [PATCH v8 2/3] devtools: prevent use of rte atomic APIs in future patches

2020-07-16 Thread Phil Yang
> -Original Message- > From: David Marchand > Sent: Thursday, July 16, 2020 6:49 PM > To: Phil Yang > Cc: tho...@monjalon.net; Mcnamara, John ; > Honnappa Nagarahalli ; David Christensen > ; dev ; jer...@marvell.com; > Ananyev, Konstantin ; Ola Liljedahl > ; Bruce Richardson ; > Ruifeng W

Re: [dpdk-dev] [PATCH v3 7/7] doc: update release notes and guides for eCPRI

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 7/7] doc: update release notes and guides for eCPRI > > Update the release notes of

Re: [dpdk-dev] [PATCH v3 6/7] net/mlx5: add eCPRI flex parser capacity check

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 6/7] net/mlx5: add eCPRI flex parser capacity check > > If the NIC or the FW does no

Re: [dpdk-dev] [PATCH v3 5/7] net/mlx5: create and destroy eCPRI flex parser

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 5/7] net/mlx5: create and destroy eCPRI flex parser > > eCPRI protocol has unified f

Re: [dpdk-dev] [PATCH v3 4/7] common/mlx5: adding DevX command for flex parsers

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 4/7] common/mlx5: adding DevX command for flex > parsers > > In order to use dynamic

Re: [dpdk-dev] [PATCH v3 1/7] net/mlx5: add flow validation of eCPRI header

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 1/7] net/mlx5: add flow validation of eCPRI header > > When creating a flow with eCP

Re: [dpdk-dev] [PATCH v3 3/7] common/mlx5: add flex parser DevX structures

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 3/7] common/mlx5: add flex parser DevX structures > > The structures and other defin

Re: [dpdk-dev] [PATCH v3 2/7] net/mlx5: add flow translation of eCPRI header

2020-07-16 Thread Slava Ovsiienko
> -Original Message- > From: Bing Zhao > Sent: Thursday, July 16, 2020 17:24 > To: Ori Kam ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Matan Azrad > ; dev@dpdk.org; Netanel Gonen > > Subject: [PATCH v3 2/7] net/mlx5: add flow translation of eCPRI header > > In the translation stage, th

Re: [dpdk-dev] [PATCH 0/9] python2 deprecation notice

2020-07-16 Thread Robin Jarry
2020-07-13, Bruce Richardson: > In the absense of a "proper" solution, is the simplest option to > change the shebangs to all be python3, but leave the python2 > compatibility in place, and add the warnings for anyone running it > explicitly using python2? I have found a hacky[1] but somewhat not

Re: [dpdk-dev] [PATCH] lpm: fix unchecked return value

2020-07-16 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Thursday, July 16, 2020 7:00 PM > To: Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Phil Yang > Subject: Re: [PATCH] lpm: fix unchecked return value > > Hi Ruifeng, > > On 16/07/2020 06:19,

Re: [dpdk-dev] [PATCH v7 2/8] fib: make lookup function type configurable

2020-07-16 Thread Thomas Monjalon
13/07/2020 13:56, Vladimir Medvedkin: > Add type argument to dir24_8_get_lookup_fn() > Now it supports 3 different lookup implementations: > RTE_FIB_DIR24_8_SCALAR_MACRO > RTE_FIB_DIR24_8_SCALAR_INLINE > RTE_FIB_DIR24_8_SCALAR_UNI > > Add new rte_fib_set_lookup_fn() - user can change lookup > f

[dpdk-dev] [PATCH v3 7/7] doc: update release notes and guides for eCPRI

2020-07-16 Thread Bing Zhao
Update the release notes of mlx5 PMD part by adding the support of eCPRI. Update the firmware configuration in the mlx5 NIC guide to support the usage of eCPRI. Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 5 + doc/guides/rel_notes/release_20_08.rst | 1 + 2 files ch

[dpdk-dev] [PATCH v3 6/7] net/mlx5: add eCPRI flex parser capacity check

2020-07-16 Thread Bing Zhao
If the NIC or the FW does not support the dynamic flex parser, it will return error when trying to create the parser for eCRPI. Then it is hard to know the detail error reason of the failure. Before creating the parser node and the following usage of the parser, the capacity bit saved in the HCA_CA

[dpdk-dev] [PATCH v3 3/7] common/mlx5: add flex parser DevX structures

2020-07-16 Thread Bing Zhao
The structures and other definitions will be used for the dynamic flex parser creation via Devx command interface. These structures will be used as some some intermediate variables and input parameters for the parser creation API. It is better to keep all members consistent with the PRM definition

[dpdk-dev] [PATCH v3 1/7] net/mlx5: add flow validation of eCPRI header

2020-07-16 Thread Bing Zhao
When creating a flow with eCPRI header item, the validation of it is mandatory. The detailed limitations are listed below: 1. Over Ether / VLAN, ethertype must be 0xAEFE. 2. No tunnel support is described in the specification now. 3. L3 layer is only supported when L4 is UDP, see #4. 4. Ove

[dpdk-dev] [PATCH v3 2/7] net/mlx5: add flow translation of eCPRI header

2020-07-16 Thread Bing Zhao
In the translation stage, the eCPRI item should be translated into the format that lower layer driver could use. All the fields that need to match must be in network byte order after translation, as well as the mask. Since the header in the item belongs to the network layers stack, and the input pa

[dpdk-dev] [PATCH v3 5/7] net/mlx5: create and destroy eCPRI flex parser

2020-07-16 Thread Bing Zhao
eCPRI protocol has unified format layout for the variants, over ETH layer (including .1Q) and UDP layer. The common header of the message has 4 bytes fixed length, and the message payload layers are different based on the type field. Now only type #0, #2 and #5 will be supported, and 2 bytes are n

[dpdk-dev] [PATCH v3 4/7] common/mlx5: adding DevX command for flex parsers

2020-07-16 Thread Bing Zhao
In order to use dynamic flex parser to parse protocols that is not supported natively, two steps are needed. Firstly, creating the parse graph node. There are three parts of the flex parser: node, arc and sample. Node is the whole structure of a flex parser, when creating, the length of the protoc

[dpdk-dev] [PATCH v3 0/7] add eCPRI support in mlx5 driver

2020-07-16 Thread Bing Zhao
This patch set is to add the eCPRI support of flow rules in mlx5 PMD driver. Right now, only eCPRI over Ethernet layer (including VLAN) is supported. eCPRI over UDP will be supported in the future. If the flow rule to be inserted is not supported, PMD driver will return error to indicate the reason

[dpdk-dev] [PATCH v4] app/flow-perf: fix condition of hairpin queues setup

2020-07-16 Thread Wisam Jaddo
The hairpin queue is the one that start from normal rxq, and will be less than nr_queues where nr_queues is the sum of normal and hairpin Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo Reviewed-by: Asaf Penso --- v4: * Re

[dpdk-dev] DPDK Release Status Meeting 16/07/2020

2020-07-16 Thread Ferruh Yigit
Minutes 16 July 2020 Agenda: * Release Dates * -rc1 status * Subtrees * LTS * OvS * Opens Participants: * Arm * Debian/Microsoft * Intel * Nvidia * NXP * Red Hat Release Dates - * v20.08 dates: * -rc1 is released on Sunday, 12 July 2020 * http://inbox.dpd

Re: [dpdk-dev] [PATCH V4 4/4] net/i40e: FDIR update rate optimization

2020-07-16 Thread Wu, Jingjing
[...] > +static inline unsigned char * > +i40e_find_available_buffer(struct rte_eth_dev *dev) > +{ > + struct i40e_pf *pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + struct i40e_fdir_info *fdir_info = &pf->fdir; > + struct i40e_tx_queue *txq = pf->fdir.txq; > + volatile

[dpdk-dev] [PATCH v2 5/7] net/mlx5: create and destroy eCPRI flex parser

2020-07-16 Thread Bing Zhao
eCPRI protocol has unified format layout for the variants, over ETH layer (including .1Q) and UDP layer. The common header of the message has 4 bytes fixed length, and the message payload layers are different based on the type field. Now only type #0, #2 and #5 will be supported, and 2 bytes are n

[dpdk-dev] [PATCH v2 4/7] common/mlx5: adding DevX command for flex parsers

2020-07-16 Thread Bing Zhao
In order to use dynamic flex parser to parse protocols that is not supported natively, two steps are needed. Firstly, creating the parse graph node. There are three parts of the flex parser: node, arc and sample. Node is the whole structure of a flex parser, when creating, the length of the protoc

[dpdk-dev] [PATCH v2 7/7] doc: update release notes and guides for eCPRI

2020-07-16 Thread Bing Zhao
Update the release notes of mlx5 PMD part by adding the support of eCPRI. Update the firmware configuration in the mlx5 NIC guide to support the usage of eCPRI. Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 5 + doc/guides/rel_notes/release_20_08.rst | 1 + 2 files ch

[dpdk-dev] [PATCH v2 6/7] net/mlx5: add eCPRI flex parser capacity check

2020-07-16 Thread Bing Zhao
If the NIC or the FW does not support the dynamic flex parser, it will return error when trying to create the parser for eCRPI. Then it is hard to know the detail error reason of the failure. Before creating the parser node and the following usage of the parser, the capacity bit saved in the HCA_CA

  1   2   3   >