[dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

2020-10-02 Thread Maxime Coquelin
VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel headers, causing build issue. Le's define it in IFC vDPA driver only if wasn't already. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: sta...@dpdk.org Reported-by: Brandon Lo Signed-off-by: Maxime Coquelin --- drivers/vdpa/

Re: [dpdk-dev] [PATCH v3 1/1] net/mlx5: support match ICMP identifier fields

2020-10-02 Thread Li Zhang
Hi Ori, Thanks for your comments. My answer inline. I will update them in V4 patch. Regards, Li Zhang > -Original Message- > From: Ori Kam > Sent: Thursday, October 1, 2020 4:14 PM > To: Li Zhang ; Dekel Peled ; Slava > Ovsiienko ; Matan Azrad > Cc: dev@dpdk.org; NBU-Contact-Thomas Mon

[dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

2020-10-02 Thread David Marchand
reallocarray has been introduced in glibc 2.26 but we still support glibc >= 2.7. Simply replace with realloc, as the considered sizes are unlikely to overflow. """ The reallocarray() function changes the size of the memory block pointed to by ptr to be large enough for an array of nmemb elements,

Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

2020-10-02 Thread David Marchand
On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin wrote: > > VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel > headers, causing build issue. > > Le's define it in IFC vDPA driver only if wasn't already. Let's* define it in the* IFC vDPA driver only if it* wasn't already. > > Fixes: a3f8150e

[dpdk-dev] vhost/crypto: fix initialization.

2020-10-02 Thread Fan Zhang
This patch fixes the problem that vhost crypto cannot be initialized due to the different requirement between built-in virtio-net and virtio-crypto. The fix includes the following change: - Added new internal enum type virtio_backend_type to distinguish virtio-net, virtio-crypto, and external devi

[dpdk-dev] [PATCH v4 1/1] net/mlx5: support match ICMP identifier fields

2020-10-02 Thread Li Zhang
PRM expose fields "Icmp_header_data" in IPv4 ICMP. Update ICMP mask parameter with ICMP identifier and sequence number fields. ICMP sequence number spec with mask, Icmp_header_data low 16 bits are set. ICMP identifier spec with mask, Icmp_header_data high 16 bits are set. Signed-off-by: Li Zhang

[dpdk-dev] [PATCH 2/2] baseband/fpga_lte_fec: fix API naming

2020-10-02 Thread Maxime Coquelin
DPDK APIs have to be prefixed with "rte_" in order to avoid namespace pollution. Let's fix it while fpga_lte_fec API is still experimental. Signed-off-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- doc/guides/bbdevs/fpga_lte_fec.rst | 14

[dpdk-dev] [PATCH 0/2] baseband: fix drivers API

2020-10-02 Thread Maxime Coquelin
The series prefixes drivers APIs with rte__ in order to avoid namespace pollution. These APIs are experimental, so no need to follow the deprecation process. Maxime Coquelin (2): baseband/fpga_5gnr_fec: fix API naming baseband/fpga_lte_fec: fix API naming app/test-bbdev/test_bbdev_perf.c

[dpdk-dev] [PATCH 1/2] baseband/fpga_5gnr_fec: fix API naming

2020-10-02 Thread Maxime Coquelin
DPDK APIs have to be prefixed with "rte_" in order to avoid namespace pollution. Let's fix it while fpga_5gnr_fec API is still experimental. Signed-off-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 6 +++--- doc/guides/bbdevs/fpga_5gnr_fec.rst| 14

Re: [dpdk-dev] [PATCH v5 13/20] doc: remove references to make from compressdevs guides

2020-10-02 Thread Daly, Lee
> -Original Message- > From: Power, Ciara > Sent: Monday, September 21, 2020 2:59 PM > To: dev@dpdk.org > Cc: Power, Ciara ; Daly, Lee ; > Mcnamara, John ; Kovacevic, Marko > ; Ashish Gupta ; > Sunila Sahu > Subject: [PATCH v5 13/20] doc: remove references to make from compressdevs > guid

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-02 Thread David Marchand
On Thu, Sep 17, 2020 at 4:47 PM David Marchand wrote: > > On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly > wrote: > > Anonymous hugepages shouldn't matter, yes, but single-file segments mode > > does fallocate() and remove - you have the remove part covered, but i'm > > just curious if fallocat

[dpdk-dev] [PATCH v3 0/3] aarch64 clang cross compilation

2020-10-02 Thread Juraj Linkeš
Use clang/LLVM toolchain with gcc stdlib to cross compile aarch64 target. v3: Removed AARCH_GCC and AARCH_CLANG variables in favor of CC_FOR_BUILD. Juraj Linkeš (3): build: add aarch64 clang to meson cross-compile ci: add aarch64 clang cross-compilation builds doc: add clang to aarch64 cros

[dpdk-dev] [PATCH v3 2/3] ci: add aarch64 clang cross-compilation builds

2020-10-02 Thread Juraj Linkeš
Mirror the existing gcc jobs - build static and shared libs. Use arm64_armv8_linux_clang_ubuntu1804 meson cross file. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 6 +- .travis.yml| 18 ++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/.ci/lin

[dpdk-dev] [PATCH v3 1/3] build: add aarch64 clang to meson cross-compile

2020-10-02 Thread Juraj Linkeš
Create meson cross file arm64_armv8_linux_clang_ubuntu1804. Use clang/LLVM toolchain with sysroot pointing to gcc cross stdlib. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armv8_linux_clang_ubuntu1804 | 20 +++ 1 file changed, 20 insertions(+) create mode 100644 config/arm/

[dpdk-dev] [PATCH v3 3/3] doc: add clang to aarch64 cross build guide

2020-10-02 Thread Juraj Linkeš
Reorganize and update the aarch64 cross guide with clang cross compilation. Update the GNU toolchain version which clang also uses. Reorganize into common part, GNU part and clang part. Signed-off-by: Juraj Linkeš --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 183 +- 1 file

Re: [dpdk-dev] [PATCH v10 04/11] usertools/cpu_layout: support python3 only

2020-10-02 Thread David Marchand
On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > > From: Louise Kilheeney > > Changed script to explicitly use python3 only to avoid > maintaining python 2 and removed deprecation notice. > > Signed-off-by: Louise Kilheeney > Reviewed-by: Bruce Richardson > Acked-by: Robin Jarry > Acked-by

Re: [dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

2020-10-02 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Friday, October 2, 2020 9:29 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] pipeline: fix build with glibc < 2.26 > > reallocarray has been introduced in glibc 2.26 but we still support > glibc >= 2.7. > Simply re

[dpdk-dev] mlx5: match broadcast and multicast packets using flows

2020-10-02 Thread Carasec Elena
Hello, I am trying to create flow rules that will match broadcast and multicast packets using testpmd on mlx5 'MT27800 Family [ConnectX-5] 1017'. However, after creating the following rules, they do not match any packets. My testpmd script is: port stop all port config all rss none set promi

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

2020-10-02 Thread David Marchand
On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > diff --git a/doc/guides/conf.py b/doc/guides/conf.py > index 9ebc26ed3f..ef550f68c0 100644 > --- a/doc/guides/conf.py > +++ b/doc/guides/conf.py > @@ -1,7 +1,7 @@ > +#!/usr/bin/env python3 > # SPDX-License-Identifier: BSD-3-Clause > # Copyrigh

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

2020-10-02 Thread Kevin Laatz
On 02/10/2020 12:01, David Marchand wrote: On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: [...] try: import sphinx_rtd_theme diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst index 0be9546a6a..4fc010ca49 100644 --- a/doc/guides/con

Re: [dpdk-dev] [PATCH v10 11/11] doc: support python3 only

2020-10-02 Thread Bruce Richardson
On Fri, Oct 02, 2020 at 01:01:13PM +0200, David Marchand wrote: > On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > > diff --git a/doc/guides/conf.py b/doc/guides/conf.py > > index 9ebc26ed3f..ef550f68c0 100644 > > --- a/doc/guides/conf.py > > +++ b/doc/guides/conf.py > > @@ -1,7 +1,7 @@ > > +#

Re: [dpdk-dev] [PATCH v4 2/8] test/distributor: synchronize lcores statistics

2020-10-02 Thread Lukasz Wojciechowski
Hi Honnappa, Many thanks for the review! I'll write my answers here not inline as it would be easier to read them in one place, I think. So first of all I agree with you in 2 things: 1) all uses of statistics must be atomic and lack of that caused most of the problems 2) it would be better to r

Re: [dpdk-dev] [PATCH] pipeline: fix build with glibc < 2.26

2020-10-02 Thread David Marchand
On Fri, Oct 2, 2020 at 12:38 PM Dumitrescu, Cristian wrote: > > -Original Message- > > From: David Marchand > > Sent: Friday, October 2, 2020 9:29 AM > > To: dev@dpdk.org > > Cc: Dumitrescu, Cristian > > Subject: [PATCH] pipeline: fix build with glibc < 2.26 > > > > reallocarray has been

[dpdk-dev] [PATCH] l3fwd-power: make interrupt wakeup log thread safe

2020-10-02 Thread Anatoly Burakov
Currently, the interrupt status notification prevents log spam by remembering whether previous interrupt wakeup was due to traffic or due to timeout expiring. However, it is a single variable that can potentially be accessed from multiple threads, so it is not thread-safe. Fix it by having per-lco

[dpdk-dev] [PATCH v2] l3fwd-power: make interrupt wakeup log thread safe

2020-10-02 Thread Anatoly Burakov
Currently, the interrupt status notification prevents log spam by remembering whether previous interrupt wakeup was due to traffic or due to timeout expiring. However, it is a single variable that can potentially be accessed from multiple threads, so it is not thread-safe. Fix it by having per-lco

Re: [dpdk-dev] [PATCH] eal/linux: fix memory allocations in containers+SELinux

2020-10-02 Thread Burakov, Anatoly
On 02-Oct-20 10:36 AM, David Marchand wrote: On Thu, Sep 17, 2020 at 4:47 PM David Marchand wrote: On Thu, Sep 17, 2020 at 4:17 PM Burakov, Anatoly wrote: Anonymous hugepages shouldn't matter, yes, but single-file segments mode does fallocate() and remove - you have the remove part covered,

Re: [dpdk-dev] vhost/crypto: fix initialization.

2020-10-02 Thread Maxime Coquelin
Hi Fan, Thanks for working on this. The commit message should not contain dot, please remove it in v2. On 10/2/20 10:36 AM, Fan Zhang wrote: > This patch fixes the problem that vhost crypto cannot be > initialized due to the different requirement between > built-in virtio-net and virtio-crypto.

Re: [dpdk-dev] vhost/crypto: fix initialization.

2020-10-02 Thread Zhang, Roy Fan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, October 2, 2020 1:18 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: Xia, Chenbo ; Liu, Changpeng > ; Yigit, Ferruh ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] vhost/crypto: fix initialization. > > Hi Fan, > > Thanks

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-02 Thread Maxime Leroy
Hi Dekel, On Thu, Oct 1, 2020 at 8:49 PM Dekel Peled wrote: > > From: Dekel Peled > > This patch implements the change proposes in RFC [1], adding dedicated > fields to ETH and VLAN items structs, to clearly define the required > characteristic of a packet, and enable precise match criteria. > >

Re: [dpdk-dev] [PATCH v10 00/11] adding support for python 3 only

2020-10-02 Thread David Marchand
On Wed, Sep 30, 2020 at 1:45 PM Kevin Laatz wrote: > > This patch set converts all python scripts in the project to use > python3 only and removes all deprecation notices associated with these > changes. This is due to python2 being EOL in January 2020. > Squashed all as one patch (all commit log

Re: [dpdk-dev] [PATCH v4 00/25] raw/ioat: enhancements and new hardware support

2020-10-02 Thread Nicolau, Radu
On 9/28/2020 5:42 PM, Bruce Richardson wrote: This patchset adds some small enhancements, some rework and also support for new hardware to the ioat rawdev driver. Most rework and enhancements are largely self-explanatory from the individual patches. The new hardware support is for the Intel(R)

[dpdk-dev] [PATCH v4 01/10] eal: add new x86 cpuid support for WAITPKG

2020-10-02 Thread Liang Ma
Add new x86 cpuid support for WAITPKG. This flag indicate processor support umwait/umonitor/tpause instruction. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- lib/librte_eal/x86/include/rte_cpuflags.h | 2 ++ lib/librte_eal/x86/rte_cpuflags.c | 2 ++ 2 files changed, 4 inser

[dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-02 Thread Liang Ma
Add two new power management intrinsics, and provide an implementation in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions are implemented as raw byte opcodes because there is not yet widespread compiler support for these instructions. The power management instructions provide an ar

[dpdk-dev] [PATCH v4 04/10] power: add simple power management API and callback

2020-10-02 Thread Liang Ma
Add a simple on/off switch that will enable saving power when no packets are arriving. It is based on counting the number of empty polls and, when the number reaches a certain threshold, entering an architecture-defined optimized power state that will either wait until a TSC timestamp expires, or w

[dpdk-dev] [PATCH v4 07/10] net/ice: implement power management API

2020-10-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/ice/ice_ethdev.c | 1 + drivers/net/ice/ice_rxtx.c | 23 +++

[dpdk-dev] [PATCH v4 10/10] doc: update the programming guide for PMD power management

2020-10-02 Thread Liang Ma
Update programming guide and sample application l3fwd-power document for PMD power management Signed-off-by: Liang Ma --- doc/guides/prog_guide/power_man.rst | 40 +++ .../sample_app_ug/l3_forward_power_man.rst| 15 ++- 2 files changed, 54 insertions(+), 1 delet

[dpdk-dev] [PATCH v4 06/10] net/i40e: implement power management API

2020-10-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_rxtx.c | 23 +++

[dpdk-dev] [PATCH v4 05/10] net/ixgbe: implement power management API

2020-10-02 Thread Liang Ma
Implement support for the power management API by implementing a `get_wake_addr` function that will return an address of an RX ring's status bit. Signed-off-by: Anatoly Burakov Signed-off-by: Liang Ma --- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_rxtx.c | 22 +++

[dpdk-dev] [PATCH v4 08/10] examples/l3fwd-power: enable PMD power mgmt

2020-10-02 Thread Liang Ma
Add pmd power mgmt feature support. Signed-off-by: Liang Ma --- examples/l3fwd-power/main.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index d0e6c9bd77..b1b139129a 100644 ---

[dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API

2020-10-02 Thread Liang Ma
Add a simple API allow ethdev get wake up address from PMD. Also include internal structure update. Signed-off-by: Liang Ma Signed-off-by: Anatoly Burakov --- lib/librte_ethdev/rte_ethdev.c | 19 lib/librte_ethdev/rte_ethdev.h | 24 lib/

[dpdk-dev] [PATCH v4 09/10] doc: update release notes for PMD power management

2020-10-02 Thread Liang Ma
Add release notes for PMD power management Signed-off-by: Liang Ma --- doc/guides/rel_notes/release_20_11.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst index c2175f37f3..57ac73722a 100644

Re: [dpdk-dev] [PATCH] net/netvsc: fix txq leak in error path

2020-10-02 Thread Yunjian Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Long Li > Sent: Thursday, October 1, 2020 6:27 AM > To: wangyunjian ; dev@dpdk.org > Cc: Stephen Hemminger ; KY Srinivasan > ; Haiyang Zhang ; > jerry.lili...@huawei.com; xudin...@huawei.com; sta...@dpdk.org > Subje

Re: [dpdk-dev] [PATCH] ethdev: add VLAN attributes to ETH and VLAN items

2020-10-02 Thread Thomas Monjalon
02/10/2020 14:39, Maxime Leroy: > Hi Dekel, > > On Thu, Oct 1, 2020 at 8:49 PM Dekel Peled wrote: > > > > From: Dekel Peled > > > > This patch implements the change proposes in RFC [1], adding dedicated > > fields to ETH and VLAN items structs, to clearly define the required > > characteristic o

Re: [dpdk-dev] [PATCH v4 01/10] eal: add new x86 cpuid support for WAITPKG

2020-10-02 Thread Bruce Richardson
On Fri, Oct 02, 2020 at 03:11:50PM +0100, Liang Ma wrote: > Add new x86 cpuid support for WAITPKG. > This flag indicate processor support umwait/umonitor/tpause > instruction. > > Signed-off-by: Liang Ma > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/x86/include/rte_cpuflags.h | 2 ++ >

Re: [dpdk-dev] [PATCH v5 15/20] doc: remove references to make from rawdevs guides

2020-10-02 Thread Xu, Rosen
Hi, > -Original Message- > From: Power, Ciara > Sent: Monday, September 21, 2020 21:59 > To: dev@dpdk.org > Cc: Power, Ciara ; Nipun Gupta > ; Mcnamara, John ; > Kovacevic, Marko ; Xu, Rosen > ; Zhang, Tianfei ; > Richardson, Bruce ; Li, Xiaoyun > ; Wu, Jingjing ; Satha Rao > ; Mahipal Ch

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

2020-10-02 Thread Tom Rix
On 10/1/20 2:54 PM, Thomas Monjalon wrote: > 01/10/2020 23:22, Chautru, Nicolas: >> From: t...@redhat.com >>> From: Tom Rix >>> >>> Copied from the Linux kernel MAINTAINERS file. >>> A Reviewer is designated person who wishes to review changes in areas of >>> interest. >>> >>> Added self as Rev

Re: [dpdk-dev] [PATCH v3 1/2] net: add run-time architecture specific CRC selection

2020-10-02 Thread Singh, Jasvinder
> -Original Message- > From: O'loingsigh, Mairtin > Sent: Tuesday, September 29, 2020 4:36 PM > To: Singh, Jasvinder ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Ryan, Brendan ; Coyle, David > ; O'loingsigh, Mairtin > > Subject: [PATCH v3 1/2] net: add run-time

[dpdk-dev] [dpdk-dev v2 1/2] vhost: add backend type in driver start

2020-10-02 Thread Fan Zhang
This patch adds an internal driver start function with a newly added backend type identifier as parameter. With this way different built-in driver types (net, crypto) can be identified. Signed-off-by: Fan Zhang --- lib/librte_vhost/socket.c | 39 --- lib/librt

[dpdk-dev] [dpdk-dev v2 0/2] vhost/crypto: fix initialization

2020-10-02 Thread Fan Zhang
This patch fixes the problem that vhost crypto cannot be initialized due to the different requirement between built-in virtio-net and virtio-crypto. The fix includes the following change: - Added new internal enum type virtio_backend_type to distinguish virtio-net, virtio-crypto, and external devi

[dpdk-dev] [dpdk-dev v2 2/2] vhost/crypto: fix feature negotiation

2020-10-02 Thread Fan Zhang
This patch fixes the feature negotiation for vhost crypto during initialization. The patch uses the newly created driver start function to inform the driver type with the fixed vhost features. In addtion the patch provides a new API specifically used by the application to start a vhost-crypto drive

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

2020-10-02 Thread Thomas Monjalon
02/10/2020 16:59, Tom Rix: > > On 10/1/20 2:54 PM, Thomas Monjalon wrote: > > 01/10/2020 23:22, Chautru, Nicolas: > >> From: t...@redhat.com > >>> From: Tom Rix > >>> > >>> Copied from the Linux kernel MAINTAINERS file. > >>> A Reviewer is designated person who wishes to review changes in areas

[dpdk-dev] [PATCH] doc: remove references to python 2

2020-10-02 Thread Robin Jarry
Python 2 support has now been dropped. Remove references to it in the documentation. Since all python scripts now have a proper shebang that calls python3, execute the scripts directly without specifying the interpreter. Sphinx version from most Linux distros is OK in 2020, do not encourage peopl

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

2020-10-02 Thread Bruce Richardson
On Fri, Oct 02, 2020 at 05:47:53PM +0200, Robin Jarry wrote: > Python 2 support has now been dropped. Remove references to it in the > documentation. > > Since all python scripts now have a proper shebang that calls python3, > execute the scripts directly without specifying the interpreter. > > S

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

2020-10-02 Thread Robin Jarry
2020-10-02, Bruce Richardson: > > + sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme > > Minor nit, I see no reason to preserve the big whitespace gap here. I thought about removing it but all the file is like this. I left it as-is for consistency. -- Robin

[dpdk-dev] [RFC PATCH v2 0/8] Rework build macros

2020-10-02 Thread Bruce Richardson
Following on from discussion in v1 of this RFC, this second RFC looks to completely rework the automated macros defined by meson to indicate a particular library or driver is enabled in the build. However, while it does so, it also maintains compatibility with previous releases to ease the transiti

[dpdk-dev] [RFC PATCH v2 1/8] app: fix missing dependencies

2020-10-02 Thread Bruce Richardson
A number of lib and driver dependencies for various apps were missed on build because the proper macro names for their use were mismatched between meson and make build systems. Before adding in equivalent compatibility macros we need to ensure to add the proper dependencies to ensure a valid build.

[dpdk-dev] [RFC PATCH v2 3/8] build: add defines for compatibility with make build

2020-10-02 Thread Bruce Richardson
The defines used to indicate what crypto, compression and eventdev drivers were being built were different to those used in the make build, with meson defining them with "_PMD" at the end, while make defined them with "_PMD" in the middle and the specific driver name at the end. This might cause co

[dpdk-dev] [RFC PATCH v2 2/8] examples/l2fwd-crypto: fix missing dependency

2020-10-02 Thread Bruce Richardson
When the crypto-scheduler support is enabled, we were missing the dependency on it as part of the meson build. Fixes: 89f0711f9ddf ("examples: build some samples with meson") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- examples/l2fwd-crypto/meson.build | 3 +++ 1 file changed, 3 ins

[dpdk-dev] [RFC PATCH v2 4/8] qat: build from common folder

2020-10-02 Thread Bruce Richardson
Since the drivers in the common directory can be processed out of order, in this case following the "bus" directory, we can simplify somewhat the build of the QAT driver to be done entirely from the "common/qat" folder rather than having it's build distributed across 3 folders. This also opens up

[dpdk-dev] [RFC PATCH v2 5/8] build: remove library name from version map filename

2020-10-02 Thread Bruce Richardson
Since each version map file is contained in the subdirectory of the library it refers to, there is no need to include the library name in the filename. This makes things simpler in case of library renaming. Signed-off-by: Bruce Richardson --- .../{rte_pmd_bbdev_fpga_5gnr_fec_version.map => versi

[dpdk-dev] [RFC PATCH v2 6/8] build: standardize component names and defines

2020-10-02 Thread Bruce Richardson
As discussed on the dpdk-dev mailing list[1], we can make some easy improvements in standardizing the naming of the various components in DPDK, and their associated feature-enabled macros. Following this patch, each library will have the name in format, 'librte_.so', and the macro indicating that

[dpdk-dev] [RFC PATCH v2 8/8] [v21.02] build: remove compatibility build defines

2020-10-02 Thread Bruce Richardson
As announced in the deprecation note, remove all compatibility build defines from previous make/meson versions and use only the standardized ones - RTE_LIB_ for libraries, and RTE__ for drivers. Signed-off-by: Bruce Richardson --- config/meson.build| 2 +- config/rte_compat

[dpdk-dev] [RFC PATCH v2 7/8] build: replace use of old build macros

2020-10-02 Thread Bruce Richardson
Use the newer macros defined by meson in all DPDK source code, to ensure there are no errors when the old non-standard macros are removed. Signed-off-by: Bruce Richardson --- app/proc-info/main.c | 4 +- app/test-bbdev/meson.build| 4 +- app/test-

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

2020-10-02 Thread Kevin Laatz
On 02/10/2020 16:47, Robin Jarry wrote: Python 2 support has now been dropped. Remove references to it in the documentation. Since all python scripts now have a proper shebang that calls python3, execute the scripts directly without specifying the interpreter. Sphinx version from most Linux dis

Re: [dpdk-dev] [PATCH] doc: remove references to python 2

2020-10-02 Thread Bruce Richardson
On Fri, Oct 02, 2020 at 05:55:22PM +0200, Robin Jarry wrote: > 2020-10-02, Bruce Richardson: > > > + sudo dnf -y install python3-sphinx python3-sphinx_rtd_theme > > > > Minor nit, I see no reason to preserve the big whitespace gap here. > > I thought about removing it but all the file is li

Re: [dpdk-dev] [PATCH] maintainers: New Reviewer entry type added to MAINTAINERS

2020-10-02 Thread Tom Rix
On 10/2/20 8:41 AM, Thomas Monjalon wrote: > 02/10/2020 16:59, Tom Rix: >> On 10/1/20 2:54 PM, Thomas Monjalon wrote: >>> 01/10/2020 23:22, Chautru, Nicolas: From: t...@redhat.com > From: Tom Rix > > Copied from the Linux kernel MAINTAINERS file. > A Reviewer is designated

Re: [dpdk-dev] [PATCH] vdpa/ifc: fix build issue with recent kernels

2020-10-02 Thread David Marchand
On Fri, Oct 2, 2020 at 10:33 AM David Marchand wrote: > > On Fri, Oct 2, 2020 at 9:54 AM Maxime Coquelin > wrote: > > > > VIRTIO_F_IOMMU_PLATFORM is now defined in recent kernel > > headers, causing build issue. > > > > Le's define it in IFC vDPA driver only if wasn't already. > > Let's* define i

Re: [dpdk-dev] [dpdk-ci] Fedora Rawhide Meson Compile Testing - DPDK Compile Warning

2020-10-02 Thread David Marchand
On Fri, Oct 2, 2020 at 8:51 AM David Marchand wrote: > > On Thu, Oct 1, 2020 at 8:24 PM Brandon Lo wrote: > > We have successfully added Fedora Rawhide to our production pipeline > > for Meson compile testing. > > The image for the container will be updated on a weekly basis. > > > > The version

[dpdk-dev] [PATCH v2] net/bnxt: support fast mbuf free

2020-10-02 Thread Lance Richardson
Add support for DEV_TX_OFFLOAD_MBUF_FAST_FREE to bnxt vector mode transmit. This offload may be enabled only when multi-segment transmit is not needed, all transmitted mbufs for a given queue will be allocated from the same pool, and all transmitted mbufs will have a reference count of 1. Since th

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

2020-10-02 Thread Ranjit Menon
On 10/1/2020 3:55 PM, Narcisa Ana Maria Vasile wrote: From: Narcisa Vasile The Windows netuio kernel driver provides the DPDK userspace application with direct access to hardware, by mapping the HW registers in userspace and allowing read/write operations from/to the device configuration spac

Re: [dpdk-dev] [PATCH v5] windows/netuio: add Windows NetUIO kernel driver

2020-10-02 Thread Dmitry Kozlyuk
On Thu, 1 Oct 2020 15:55:08 -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > The Windows netuio kernel driver provides the DPDK userspace application > with direct access to hardware, by mapping the HW registers in userspace > and allowing read/write operations from/to the devic

[dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-02 Thread Tal Shnaiderman
export for clang build all the functions currently built on Windows and listed in rte_eal_version.map by adding them to rte_eal_exports.def. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 156 - 1 file changed, 152 insertions(+), 4 del

[dpdk-dev] [PATCH v2] net/qede: fix get link details

2020-10-02 Thread Rasesh Mody
This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler") Cc: sta...@dpdk.org Reported-by: Ferruh Yigit Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh

Re: [dpdk-dev] [PATCH] net/qede: fix get link details

2020-10-02 Thread Rasesh Mody
Hi Jerin - please use v2, which addresses the build issues. On 10/1/20, 3:41 PM, "Rasesh Mody" wrote: This patch fixes get current link details, without this change the link details can be inaccurate if proper lock is not acquired. Fixes: 739a5b2f2b49 ("net/qede/base: use passed pt

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-02 Thread Ranjit Menon
Hi Tal, On 10/2/2020 12:18 PM, Tal Shnaiderman wrote: export for clang build all the functions currently built on Windows and listed in rte_eal_version.map by adding them to rte_eal_exports.def. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 156 +

[dpdk-dev] [PATCH 2/2] net/ring: prevent nodeaction arg create multiple ethdev

2020-10-02 Thread Ferruh Yigit
PMD accepts multiple 'nodeaction' arguments per vdev, for each instance of the devarg an ethdev is created. Like: "--vdev net_ring0,nodeaction=r1:0:CREATE,nodeaction=r2:0:CREATE" allocates two ethdevs. Here ethdev names will be 'r1' and 'r2' respectively (each ethdev with hardcoded number of queues

[dpdk-dev] [PATCH 1/2] net/ring: refactor to reduce indentation in probe

2020-10-02 Thread Ferruh Yigit
No functional change. Signed-off-by: Ferruh Yigit --- drivers/net/ring/rte_eth_ring.c | 137 +++- 1 file changed, 66 insertions(+), 71 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index 83c5502123..6d3deaa81a 100644 ---

Re: [dpdk-dev] [PATCH] eal/windows: export all built functions for clang

2020-10-02 Thread Tal Shnaiderman
> From: Ranjit Menon > Subject: Re: [PATCH] eal/windows: export all built functions for clang > > Hi Tal, > > On 10/2/2020 12:18 PM, Tal Shnaiderman wrote: > > export for clang build all the functions currently built on Windows > > and listed in rte_eal_version.map by adding them to > > rte_eal

[dpdk-dev] [PATCH] net/failsafe: check correct error code while handling sub-device add

2020-10-02 Thread Long Li
From: Long Li When adding a sub-device, it's possible that the sub-device is configured successfully but later fails to start. This error should not be masked. The driver needs to check the error status to prevent endless loop of trying to start the sub-device. fixes (ae80146c5a1b net/failsafe: