Re: [dpdk-dev] [PATCH] usertools: fix pmdinfo parsing

2020-11-04 Thread Olivier Matz
On Tue, Nov 03, 2020 at 03:54:39PM -0800, Stephen Hemminger wrote: > On Tue, 3 Nov 2020 21:20:43 +0100 > David Marchand wrote: > > > On Tue, Nov 3, 2020 at 8:27 PM Robin Jarry wrote: > > > 2020-11-03, David Marchand: > > > > This script was using the librte_pmd prefix has a filter to follow

Re: [dpdk-dev] [PATCH] usertools: fix pmdinfo parsing

2020-11-04 Thread Robin Jarry
2020-11-03, David Marchand: > Less ugly with a regular expression? > > if re.match(r"^librte_(baseband|compress|crypto|event|net|raw|regex|vdpa)_", > force_unicode(tag.needed)): No, that's worse :D As Stephen said, maybe it would be more readable if the list of supported classes were

[dpdk-dev] [PATCH] doc: update release notes for iavf

2020-11-04 Thread Zhang,Alvin
From: Alvin Zhang Update release notes with feature of outer IP hash for GTPC and GTPU. Signed-off-by: Alvin Zhang --- doc/guides/rel_notes/release_20_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst ind

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-04 Thread David Marchand
If I count well, this is the v3 of the patch. Please version your patches. On Wed, Nov 4, 2020 at 8:52 AM Leyi Rong wrote: > > Currently, l3fwd doesn't support multiple Tx queues, while > multiple Rx queues is supported. > To improve the throughput performance when polling multiple > queues, this

Re: [dpdk-dev] [PATCH v4] mbuf: allow dynamic flags to be used by secondary process

2020-11-04 Thread Olivier Matz
Hi Stephen, On Tue, Nov 03, 2020 at 09:53:10PM -0800, Stephen Hemminger wrote: > The dynamic flag management is broken if rte_mbuf_dynflag_lookup() > is done in a secondary process because the local pointer to > the memzone is not ever initialized. > > Fix it by using the same checks as dynfield_

[dpdk-dev] [PATCH v1 1/2] net/hinic/base: support two or more aeqs for chip

2020-11-04 Thread Guoyang Zhou
For device initialize, driver only supports four aeqs before, and now driver can supports two or more aeqs from chip config file. Fixes: 611faa5f46cc ("fix various typos found by Lintian") Cc: sta...@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_eqs.c | 8 ++--- dri

[dpdk-dev] [PATCH v1 0/2] support two or more aeqs for chip

2020-11-04 Thread Guoyang Zhou
This patch fixes can support two or more aeqs from chip config file and also support four aeqs before, and fix log info for pf command channel when something is error. -- v1: - support two or more aeqs for chip - fix log info for pf command channel when something is error Guoyang Zhou (2):

[dpdk-dev] [PATCH v1 2/2] net/hinic/base: fix log info for PF command channel

2020-11-04 Thread Guoyang Zhou
When PF command channel is error, the variables in the log has been cleared, which is not printed yet. Fixes: 214164a6bf7f ("net/hinic/base: remove unused function parameters") Cc: sta...@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_mgmt.c | 4 +++- 1 file changed, 3

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-11-04 Thread Wisam Monther
Hi, You can add my ack: Acked-by: Wisam Jaddo mailto:wis...@nvidia.com>> Thomas, Do you have comments left here? BRs, Wisam Jaddo From: Georgios Katsikas Sent: Tuesday, November 3, 2020 1:26 PM To: wis...@mellanox.com Cc: dev@dpdk.org Subject: Re: [PATCH] app/flow-perf: configurable rule batc

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-04 Thread Rong, Leyi
> -Original Message- > From: David Marchand > Sent: Wednesday, November 4, 2020 4:14 PM > To: Rong, Leyi > Cc: Zhang, Qi Z ; dev > Subject: Re: [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore > > If I count well, this is the v3 of the patch. > Please version your patches.

Re: [dpdk-dev] [PATCH 0/8] misc fixes for hns3

2020-11-04 Thread oulijun
在 2020/11/3 20:15, Ferruh Yigit 写道: On 11/2/2020 2:38 PM, Lijun Ou wrote: This patch series includes three Tx checksum bugs and two static check warnings fixes. The remaining includes two features fixes. Chengchang Tang (4): net/hns3: add limit promisc mode to VF net/hns3: fix Tx cksum

Re: [dpdk-dev] [PATCH v3] build: add pkg-config validation

2020-11-04 Thread Gregory Etelson
Hello Bruce, Thank you for the review. I'll update the script and post a new patch to the mailing list. Regards, Gregory > -Original Message- > From: Bruce Richardson > Sent: Tuesday, November 3, 2020 12:09 > To: Gregory Etelson > Cc: dev@dpdk.org; bl...@debian.org; christian.ehrha...@

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-04 Thread David Marchand
On Wed, Nov 4, 2020 at 9:34 AM Rong, Leyi wrote: > > -Original Message- > > From: David Marchand > > Sent: Wednesday, November 4, 2020 4:14 PM > > To: Rong, Leyi > > Cc: Zhang, Qi Z ; dev > > Subject: Re: [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore > > > > If I count we

[dpdk-dev] [PATCH 0/2] net/i40e: fix incorrect FDIR flex configuration

2020-11-04 Thread Chenxu Di
The configuration of FDIR flex mask and flex pit should not be set during flow validate. It should be set when flow create. Chenxu Di (2): net/i40e: fix incorrect FDIR flex mask net/i40e: fix incorrect FDIR flex pit drivers/net/i40e/i40e_ethdev.h | 22 ++-- drivers/net/i40e/i40e_fdir.c |

[dpdk-dev] [PATCH 2/2] net/i40e: fix incorrect FDIR flex pit

2020-11-04 Thread Chenxu Di
The register of FDIR flex pit should not be set during flow validate. It should be set when flow create. Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR") Cc: sta...@dpdk.org Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.h | 21 --- drivers/net/i40e/i4

[dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask

2020-11-04 Thread Chenxu Di
The register of FDIR flex mask should not be set during flow validate. It should be set when flow create. Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR") Cc: sta...@dpdk.org Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdi

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2020-11-04 Thread Rong, Leyi
> -Original Message- > From: David Marchand > Sent: Wednesday, November 4, 2020 4:43 PM > To: Rong, Leyi > Cc: Zhang, Qi Z ; dev > Subject: Re: [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore > > On Wed, Nov 4, 2020 at 9:34 AM Rong, Leyi wrote: > > > -Original Message

Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix incorrect FDIR flex pit

2020-11-04 Thread Guo, Jia
Hi, chenxu > -Original Message- > From: Chenxu Di > Sent: Wednesday, November 4, 2020 4:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; Di, ChenxuX ; > sta...@dpdk.org > Subject: [PATCH 2/2] net/i40e: fix incorrect FDIR flex pit > > The register of FDIR flex pit

Re: [dpdk-dev] [PATCH v2] cpu_layout: refactor to meet python standards

2020-11-04 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 10:53:04PM -0800, Stephen Hemminger wrote: > Rearrange code to make it pass python lint totally clean! This includes > add a main function, docstring, and some variable name changes. > > Signed-off-by: Stephen Hemminger --- v2 - > rebase to current main > > usertools/cp

[dpdk-dev] [PATCH v5] net/ice: fix outher chksum on cvl unknown

2020-11-04 Thread Murphy Yang
Currently, driver does not supports parse UDP outer checksum flag of tunneled packets. When execute 'csum set outer-udp hw 0' and 'csum parse-tunnel on 0' commands to enable hardware UDP outer checksum. This patch supports parse UDP outer checksum flag of tunneled packets. Fixes: dbf3c0e77a22 ("n

[dpdk-dev] [PATCH v5] lib/power: remove set env deprecation notice

2020-11-04 Thread David Hunt
Remove notice announcing an already-implemented change. In 19.05, rte_power_set_env was changed to return -1 in cases where the envorinment was already set up, and for the same release, a deprecation notice was added for the following commit: 'commit 5a5f3178d4a8 ("power: return error when environ

Re: [dpdk-dev] [PATCH v2 0/6] dpdk-devbind: python lint cleanups

2020-11-04 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 11:03:44PM -0800, Stephen Hemminger wrote: > This addresses several warnings from python3 lint. > Split out from earlier patchset > > Stephen Hemminger (6): > dpdk-devbind: use argparse instead of getopt > dpdk-devbind: fix indentation > dpdk-devbind: fix python lint

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask

2020-11-04 Thread Guo, Jia
Hi, chenxu > -Original Message- > From: Chenxu Di > Sent: Wednesday, November 4, 2020 4:30 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; Wang, > Haiyue ; Di, ChenxuX ; > sta...@dpdk.org > Subject: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > The register of FDIR flex ma

[dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing

2020-11-04 Thread David Marchand
This script inspects an ELF file (binary or shared library) and its linked dependencies by following DT_NEEDED tags. So far a simple librte_pmd prefix was used as a filter. Now that we changed the driver library names, update this heuristic with an explicit list of all driver classes. Fixes: a20b2

Re: [dpdk-dev] [PATCH] raw/ioat: fix queue index calculation

2020-11-04 Thread Bruce Richardson
On Tue, Nov 03, 2020 at 10:51:17PM +0100, Thomas Monjalon wrote: > 03/11/2020 21:21, Thomas Monjalon: > > 03/11/2020 15:48, Bruce Richardson: > > > Coverity flags a possible problem where the 8-bit wq_idx value may have > > > errors when shifted and sign-extended to 64-bits. Since this can only >

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask

2020-11-04 Thread Di, ChenxuX
Hi, Jia > -Original Message- > From: Guo, Jia > Sent: Wednesday, November 4, 2020 5:41 PM > To: Di, ChenxuX ; dev@dpdk.org > Cc: Xing, Beilei ; Wang, Haiyue > ; Di, ChenxuX ; > sta...@dpdk.org > Subject: RE: [PATCH 1/2] net/i40e: fix incorrect FDIR flex mask > > Hi, chenxu > > > -Or

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-04 Thread Ibtisam Tariq
Hello David, In reference to this comment > + case MBUF_DATAROOM_KEYWORD_NUM: > + { > + uint32_t data_room_size; Here, I don't think we need a temp storage. If the value is invalid, the parsing and then init will fail. You can directly pass &env.m

Re: [dpdk-dev] [PATCH v3] net/iavf: fix PROT filed for rss hash

2020-11-04 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, November 3, 2020 5:42 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v3] net/iavf: fix PROT filed for rss hash > > Add PROT field into IPv4 and IPv6 protocol headers for rss ha

Re: [dpdk-dev] [PATCH] doc: update release notes for iavf

2020-11-04 Thread Zhang, Qi Z
> -Original Message- > From: Zhang,Alvin > Sent: Wednesday, November 4, 2020 4:07 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH] doc: update release notes for iavf > > From: Alvin Zhang > > Update release notes with feature of outer IP hash for GTPC and G

Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing

2020-11-04 Thread Bruce Richardson
On Wed, Nov 04, 2020 at 10:40:33AM +0100, David Marchand wrote: > This script inspects an ELF file (binary or shared library) and its > linked dependencies by following DT_NEEDED tags. > So far a simple librte_pmd prefix was used as a filter. > Now that we changed the driver library names, update t

Re: [dpdk-dev] [PATCH v2] usertools: fix pmdinfo parsing

2020-11-04 Thread David Marchand
On Wed, Nov 4, 2020 at 11:33 AM Bruce Richardson wrote: > > On Wed, Nov 04, 2020 at 10:40:33AM +0100, David Marchand wrote: > > This script inspects an ELF file (binary or shared library) and its > > linked dependencies by following DT_NEEDED tags. > > So far a simple librte_pmd prefix was used as

Re: [dpdk-dev] [PATCH v1 1/2] net/hinic: fix outer_l3_len parse error

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 2:19 AM, Wangxiaoyun (Cloud) wrote: 在 2020/11/3 1:08, Ferruh Yigit 写道: On 10/31/2020 3:38 AM, Xiaoyun wang wrote: This patch fixes outer_l3_len parse error when PKT_TX_OUTER_IP_CKSUM is not set, which does not affect checksum function, just be consistent with mbuf meta informati

Re: [dpdk-dev] [PATCH v2] ethdev: fix check of rx configure

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 1:24 AM, wangyunjian wrote: From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Signed-off-by: Yunjian Wang Reviewed-by: Fer

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-11-04 Thread Georgios Katsikas
Hi, Is what you are asking possible with a simple git commit --amend? Thanks, Georgios On Wed, Nov 4, 2020 at 10:04 AM Wisam Monther wrote: > Hi, > > > > You can add my ack: > > Acked-by: Wisam Jaddo > > > > Thomas, > > Do you have comments left here? > > > > BRs, > > Wisam Jaddo > > > > *Fro

Re: [dpdk-dev] [PATCH v2] ethdev: fix check of rx configure

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 11:11 AM, Ferruh Yigit wrote: On 11/4/2020 1:24 AM, wangyunjian wrote: From: Yunjian Wang Coverity flags that 'rx_conf' variable is used before it's checked for NULL. This patch fixes this issue. Coverity issue: 363570 Fixes: 4ff702b5dfa9 ("ethdev: introduce Rx buffer split") Si

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

2020-11-04 Thread Wisam Monther
I think Thomas can add it if he want to merge it in this version. Moreover I think you need to keep the ack between versions and the person who acked before should comment if newer version not ok with him, otherwise he is ok with it. “Using git commit —amend”. Thomas, correct me if I’m wrong, A

Re: [dpdk-dev] [PATCH v4] ethdev: fix data type for port id

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 3:26 AM, Ajit Khaparde wrote: On Tue, Nov 3, 2020 at 6:58 PM wangyunjian wrote: From: Yunjian Wang The ethdev port id is 16 bits now. This patch fixes the data type of the variable for 'pid', which changing from uint32_t to uint16_t. RTE_MAX_ETHPORTS is the maximum number of po

Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context

2020-11-04 Thread Ferruh Yigit
On 11/3/2020 7:33 AM, Matan Azrad wrote: Hi Ferruh Thank you for the fast review. Please see inline From: Ferruh Yigit On 11/1/2020 5:48 PM, Matan Azrad wrote: When an age action becomes aged-out the rte_flow_get_aged_flows should return the action context supplied by the configuration struct

[dpdk-dev] [PATCH v2 0/2] introduce stateful flow table

2020-11-04 Thread Ori Kam
The RFC introduces Stateful Flow Table (SFT) API and changes needed in both ethdev an RTE flow to support SFT functionality. SFT library provides a framework for applications that need to maintain context across different packets of the connection. The goals of the SFT library: - Accelerate flow

[dpdk-dev] [PATCH v2 1/2] ethdev: add item/action for SFT

2020-11-04 Thread Ori Kam
From: Andrey Vesnovaty Attach SFT flow context to packet with SFT action. Match on SFT flow context (attached to packet), with SFT item. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_flow.h | 75 1 file changed, 75 insertions(+) diff --git a/li

[dpdk-dev] [PATCH v2 2/2] ethdev: introduce sft lib

2020-11-04 Thread Ori Kam
Defines RTE SFT (Stateful Flow Table) APIs for Stateful Flow Table library. Currently, DPDK enables only stateless offloading, using the rte_flow. stateless means that each packet is handled without any knowledge of privious or future packets. As we look at the industry, there is much demand to s

[dpdk-dev] [RFC v3 2/2] ethdev: introduce sft lib

2020-11-04 Thread Ori Kam
Defines RTE SFT (Stateful Flow Table) APIs for Stateful Flow Table library. Currently, DPDK enables only stateless offloading, using the rte_flow. stateless means that each packet is handled without any knowledge of previous or future packets. As we look at the industry, there is much demand to s

[dpdk-dev] [RFC v3 0/2] introduce stateful flow table

2020-11-04 Thread Ori Kam
The RFC introduces Stateful Flow Table (SFT) API and changes needed in both ethdev an RTE flow to support SFT functionality. SFT library provides a framework for applications that need to maintain context across different packets of the connection. The goals of the SFT library: - Accelerate flow

[dpdk-dev] [RFC v3 1/2] ethdev: add item/action for SFT

2020-11-04 Thread Ori Kam
From: Andrey Vesnovaty Attach SFT flow context to packet with SFT action. Match on SFT flow context (attached to packet), with SFT item. Signed-off-by: Andrey Vesnovaty --- lib/librte_ethdev/rte_flow.h | 75 1 file changed, 75 insertions(+) diff --git a/li

Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context

2020-11-04 Thread Matan Azrad
From: Ferruh Yigit > On 11/3/2020 7:33 AM, Matan Azrad wrote: > > Hi Ferruh > > > > Thank you for the fast review. > > Please see inline > > > > From: Ferruh Yigit > >> On 11/1/2020 5:48 PM, Matan Azrad wrote: > >>> When an age action becomes aged-out the rte_flow_get_aged_flows > >>> should ret

[dpdk-dev] [PATCH v4] net/mlx5: fix incorrect group value of sample suffix flow

2020-11-04 Thread Jiawei Wang
mlx5 PMD splited the sampling flow into prefix flow and suffix flow. On the sample action translation function, the scaled group value of suffix flow be attached into sample object and saved into sample resource. mlx5 PMD fetched the group value from the sample resource to create the suffix flow.

Re: [dpdk-dev] [PATCH] app/testpmd: support age shared action context

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 1:28 PM, Matan Azrad wrote: From: Ferruh Yigit On 11/3/2020 7:33 AM, Matan Azrad wrote: Hi Ferruh Thank you for the fast review. Please see inline From: Ferruh Yigit On 11/1/2020 5:48 PM, Matan Azrad wrote: When an age action becomes aged-out the rte_flow_get_aged_flows sho

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] ethdev: fix data type for port id

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 11:46 AM, Ferruh Yigit wrote: On 11/4/2020 3:26 AM, Ajit Khaparde wrote: On Tue, Nov 3, 2020 at 6:58 PM wangyunjian wrote: From: Yunjian Wang The ethdev port id is 16 bits now. This patch fixes the data type of the variable for 'pid', which changing from uint32_t to uint16_t.

Re: [dpdk-dev] [PATCH v1 0/2] support two or more aeqs for chip

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 2:03 AM, Guoyang Zhou wrote: This patch fixes can support two or more aeqs from chip config file and also support four aeqs before, and fix log info for pf command channel when something is error. -- v1: - support two or more aeqs for chip - fix log info for pf command channel

[dpdk-dev] [PATCH] net/mlx5: fix use of local array for global error

2020-11-04 Thread Dekel Peled
Recent patch uses a local string array as input for function rte_flow_error_set(). This stack memory may be later used by other code sections, overwriting the desired error string. This patch impelemnets an error string for the specific case requested, of ICMP item not supported in Verbs flow engi

Re: [dpdk-dev] [PATCH 15/15] mbuf: move pool pointer in hotterfirst half

2020-11-04 Thread Olivier Matz
Hi, On Tue, Nov 03, 2020 at 04:03:46PM +0100, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slava Ovsiienko > > Sent: Tuesday, November 3, 2020 3:03 PM > > > > Hi, Morten > > > > > From: Morten Brørup > > > Sent: Tuesday, November 3, 2020 14:10 > > > > > > > From

Re: [dpdk-dev] [PATCH v4 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-04 Thread Medvedkin, Vladimir
Hi Thakkar, On 03/11/2020 22:23, Dharmik Thakkar wrote: Avoid code duplication by combining single and multi threaded tests Also, enable support for more than 2 writers Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_lpm_perf.c | 359 +

[dpdk-dev] Licensing patch

2020-11-04 Thread Hemant Agrawal
Hi Thomas, Can you apply the following trivial patch to 20.11? https://patches.dpdk.org/patch/74896/ Regards, Hemant

[dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing

2020-11-04 Thread David Marchand
This script inspects an ELF file (binary or shared library) and its linked dependencies by following DT_NEEDED tags. So far a simple librte_pmd prefix was used as a filter to only parse DPDK drivers dependencies. While the reason is not clear from the commitlog of the patch that introduced this fil

Re: [dpdk-dev] Licensing patch

2020-11-04 Thread Thomas Monjalon
04/11/2020 16:52, Hemant Agrawal: > Hi Thomas, >Can you apply the following trivial patch to 20.11? > > https://patches.dpdk.org/patch/74896/ Yes, added in my list for -rc2.

[dpdk-dev] [PATCH v5] mbuf: allow dynamic flags to be used by secondary process

2020-11-04 Thread Stephen Hemminger
The dynamic flag management is broken if rte_mbuf_dynflag_lookup() is done in a secondary process because the local pointer to the memzone is not ever initialized. Fix it by using the same checks as dynfield_register(). I.e if shared memory zone has not been looked up already, then discover it. F

Re: [dpdk-dev] [PATCH v2] cpu_layout: refactor to meet python standards

2020-11-04 Thread Stephen Hemminger
On Wed, 4 Nov 2020 09:21:05 + Bruce Richardson wrote: > On Tue, Nov 03, 2020 at 10:53:04PM -0800, Stephen Hemminger wrote: > > Rearrange code to make it pass python lint totally clean! This includes > > add a main function, docstring, and some variable name changes. > > > > Signed-off-by: S

Re: [dpdk-dev] [PATCH v5] mbuf: allow dynamic flags to be used by secondary process

2020-11-04 Thread Olivier Matz
On Wed, Nov 04, 2020 at 08:20:00AM -0800, Stephen Hemminger wrote: > The dynamic flag management is broken if rte_mbuf_dynflag_lookup() > is done in a secondary process because the local pointer to > the memzone is not ever initialized. > > Fix it by using the same checks as dynfield_register(). >

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx: introduce 128-bit unsigned integer compat

2020-11-04 Thread Thomas Monjalon
22/10/2020 14:24, Andrew Rybchenko: > Intel SSE has __m128i, but ARMv8 has __uint128_t. So, add compat > efsys_uint128_t to be used in driver source and have either __u128i > or __uint128_t behind. Could we do something in EAL for this common need?

Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing

2020-11-04 Thread Bruce Richardson
On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote: > This script inspects an ELF file (binary or shared library) and its > linked dependencies by following DT_NEEDED tags. > So far a simple librte_pmd prefix was used as a filter to only parse > DPDK drivers dependencies. > While the re

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx: introduce 128-bit unsigned integer compat

2020-11-04 Thread Honnappa Nagarahalli
> > 22/10/2020 14:24, Andrew Rybchenko: > > Intel SSE has __m128i, but ARMv8 has __uint128_t. So, add compat > > efsys_uint128_t to be used in driver source and have either __u128i or > > __uint128_t behind. > > Could we do something in EAL for this common need? rte_int128_t is defined in EAL.

Re: [dpdk-dev] [PATCH v3] usertools: fix pmdinfo parsing

2020-11-04 Thread David Marchand
On Wed, Nov 4, 2020 at 5:36 PM Bruce Richardson wrote: > > On Wed, Nov 04, 2020 at 04:57:21PM +0100, David Marchand wrote: > > This script inspects an ELF file (binary or shared library) and its > > linked dependencies by following DT_NEEDED tags. > > So far a simple librte_pmd prefix was used as

Re: [dpdk-dev] [PATCH v4 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-04 Thread Dharmik Thakkar
> On Nov 4, 2020, at 9:46 AM, Medvedkin, Vladimir > wrote: > > Hi Thakkar, > > On 03/11/2020 22:23, Dharmik Thakkar wrote: >> Avoid code duplication by combining single and multi threaded tests >> Also, enable support for more than 2 writers >> Signed-off-by: Dharmik Thakkar >> Reviewed-by:

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Thomas Monjalon
03/11/2020 14:29, Ferruh Yigit: > On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > > On 11/2/2020 8:52 AM, SteveX Yang wrote: > >> When the max rx packet length is smaller than the sum of mtu size and > >> ether overhead size, it should be enlarged, otherwise the VLAN packets > >> will be dropped. > >>

Re: [dpdk-dev] [PATCH v2 0/6] dpdk-devbind: python lint cleanups

2020-11-04 Thread Stephen Hemminger
On Tue, 3 Nov 2020 23:03:44 -0800 Stephen Hemminger wrote: > This addresses several warnings from python3 lint. > Split out from earlier patchset > > Stephen Hemminger (6): > dpdk-devbind: use argparse instead of getopt > dpdk-devbind: fix indentation > dpdk-devbind: fix python lint warni

[dpdk-dev] [PATCH] mbuf: fix reset on mbuf free

2020-11-04 Thread Olivier Matz
m->nb_seg must be reset on mbuf free whatever the value of m->next, because it can happen that m->nb_seg is != 1. For instance in this case: m1 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m1, 500); m2 = rte_pktmbuf_alloc(mp); rte_pktmbuf_append(m2, 500); rte_pktmbuf_chain(m1, m2); m0 =

[dpdk-dev] [PATCH] net/ring: fix typo in log message

2020-11-04 Thread Olivier Matz
Add a missing space. Fixes: 869bf6d222bb ("net/ring: fix coding style") Signed-off-by: Olivier Matz --- drivers/net/ring/rte_eth_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index d6115abdd5..41402a5

[dpdk-dev] [PATCH v1] vhost: slot_idx needs to be initialised to fix gcc compile error

2020-11-04 Thread Conor Walsh
When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc sees slot_idx as possibly being uninitialised. To correct this error slot_idx has been initialised to 0. Signed-off-by: Conor Walsh --- lib/librte_vhost/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[dpdk-dev] [PATCH] net/bnxt: remove useless prefetches

2020-11-04 Thread Stephen Hemminger
Prefetching only helps performance if it is done several 100 instructions before the actual use. The purpose of the prefetch is to read ahead, it doesn't help if the next instruction will block. The code in the bnxt driver was doing these unnecessary prefetches. Signed-off-by: Stephen Hemminger

[dpdk-dev] [PATCH 1/2] eal: fix missing installation of mcslock headers

2020-11-04 Thread Olivier Matz
Add missing arch-specific headers in meson.build. Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_eal/arm/include/meson.build | 1 + lib/librte_eal/ppc/include/meson.build | 1 + lib/librte_eal/x86/include/meson.

[dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

2020-11-04 Thread Olivier Matz
Add missing arch-specific headers in meson.build. Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_eal/arm/include/meson.build | 1 + lib/librte_eal/ppc/include/meson.build | 1 + lib/librte_eal/x86/include/

[dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-04 Thread Conor Walsh
When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc sees zcd in test_ring.h as possibly being uninitialised. To correct this error zcd has been initialised to {0} in test_ring_mt_peek_stress_zc.c. Signed-off-by: Conor Walsh --- app/test/test_ring_mt_peek_stress_zc.c | 4 +

[dpdk-dev] [PATCH] test/mcslock: remove unneeded per-lcore copy

2020-11-04 Thread Olivier Matz
Each core already comes with its local storage for mcslock (in its stack), therefore there is no need to define an additional per-lcore mcslock. Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") Signed-off-by: Olivier Matz --- app/test/test_mcslock.c | 16 ++-- 1 f

Re: [dpdk-dev] [PATCH v1] vhost: slot_idx needs to be initialised to fix gcc compile error

2020-11-04 Thread Maxime Coquelin
Hi Conor, On 11/4/20 6:02 PM, Conor Walsh wrote: > When DPDK is compiled with gcc < 9 with the optimization level set to 1 > gcc sees slot_idx as possibly being uninitialised. To correct this error > slot_idx has been initialised to 0. > > Signed-off-by: Conor Walsh > --- > lib/librte_vhost/vir

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 4:51 PM, Thomas Monjalon wrote: 03/11/2020 14:29, Ferruh Yigit: On 11/2/2020 11:48 AM, Ferruh Yigit wrote: On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN

[dpdk-dev] [PATCH] test/telemetry: fix typo at beginning of line

2020-11-04 Thread Ciara Power
A "+" symbol was incorrectly placed at the beginning of a line, this is now removed. Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON") Cc: bruce.richard...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ciara Power --- app/test/test_telemetry_json.c | 2 +- 1 file changed

Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD

2020-11-04 Thread Ferruh Yigit
On 11/3/2020 11:08 PM, Thomas Monjalon wrote: 27/10/2020 12:37, Ferruh Yigit: On 10/27/2020 2:39 AM, Jiawen Wu wrote: On Monday, October 26, 2020 10:56 PM, Ferruh Yigit wrote: Series applied to dpdk-next-net/main, thanks. 57/58 & 58/58 has been distributed to the relevant commits while mergin

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

2020-11-04 Thread David Marchand
On Wed, Nov 4, 2020 at 6:04 PM Olivier Matz wrote: > > Add missing arch-specific headers in meson.build. > > Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") > Cc: sta...@dpdk.org > > Signed-off-by: Olivier Matz Issue can be seen with: diff --git a/examples/helloworld/m

Re: [dpdk-dev] [PATCH v5] mbuf: allow dynamic flags to be used by secondary process

2020-11-04 Thread David Marchand
On Wed, Nov 4, 2020 at 5:27 PM Olivier Matz wrote: > On Wed, Nov 04, 2020 at 08:20:00AM -0800, Stephen Hemminger wrote: > > The dynamic flag management is broken if rte_mbuf_dynflag_lookup() > > is done in a secondary process because the local pointer to > > the memzone is not ever initialized. >

Re: [dpdk-dev] [PATCH 2/2] eal: fix missing installation of ticketlock headers

2020-11-04 Thread David Christensen
On 11/4/20 9:03 AM, Olivier Matz wrote: Add missing arch-specific headers in meson.build. Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- lib/librte_eal/arm/include/meson.build | 1 + lib/librte_eal/ppc/include

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Thomas Monjalon
04/11/2020 18:07, Ferruh Yigit: > On 11/4/2020 4:51 PM, Thomas Monjalon wrote: > > 03/11/2020 14:29, Ferruh Yigit: > >> On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > >>> On 11/2/2020 8:52 AM, SteveX Yang wrote: > When the max rx packet length is smaller than the sum of mtu size and > ether

Re: [dpdk-dev] [PATCH] test/mcslock: remove unneeded per-lcore copy

2020-11-04 Thread Honnappa Nagarahalli
> > Each core already comes with its local storage for mcslock (in its stack), > therefore there is no need to define an additional per-lcore mcslock. > > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") > > Signed-off-by: Olivier Matz > --- > app/test/test_mcslock.c | 16

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] common/mlx5: split relaxed ordering set for read and write

2020-11-04 Thread Thomas Monjalon
03/11/2020 10:15, Matan Azrad: > From: Tal Shnaiderman > > The current DevX implementation of the relaxed ordering feature is enabling > > relaxed ordering usage only if both relaxed ordering read AND write are > > supported. In that case both relaxed ordering read and write are activated. > > >

Re: [dpdk-dev] [PATCH 1/2] drivers/net/mlx5: fix representor interrupts handler

2020-11-04 Thread Thomas Monjalon
28/10/2020 10:59, Gregory Etelson: > Representor is a port in DPDK that is connected to a VF in such a way > that assuming there are no offload flows, each packet that is sent > from the VF will be received by the corresponding representor. While > each packet that is sent to a representor will be

Re: [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about

2020-11-04 Thread Thomas Monjalon
29/10/2020 14:36, luca.bocca...@gmail.com: > From: Luca Boccassi > > Signed-off-by: Luca Boccassi > --- > Would be really great to hook up some spell checkers to the CI, so > that I'm not the only one who gets nagged by automated tools :-) There is a spell checker with checkpatch and we are cat

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-04 Thread Honnappa Nagarahalli
Hi Conor, Thanks for the patch. > > When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc > sees zcd in test_ring.h as possibly being uninitialised. To correct this > error zcd > has been initialised to {0} in test_ring_mt_peek_stress_zc.c. > > Signed-off-by: Con

[dpdk-dev] [PATCH v5 0/4] test/lpm: fix rcu qsbr perf test

2020-11-04 Thread Dharmik Thakkar
Fix LPM adds, LPM deletes, and cycle calculation. Return error if LPM add/delete fails in multi-writer test. Return error if single or multi writer test fails Remove redundant error checking for readers. Combine single and multi threaded test cases to avoid code duplication. --- v5: - Update logic

[dpdk-dev] [PATCH v5 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-04 Thread Dharmik Thakkar
Avoid code duplication by combining single and multi threaded tests Also, enable support for more than 2 writers Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_lpm_perf.c | 356 +-- 1 file change

[dpdk-dev] [PATCH v5 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-04 Thread Dharmik Thakkar
Remove redundant error checking for reader threads since they never return error. Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app

[dpdk-dev] [PATCH v5 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-04 Thread Dharmik Thakkar
Return error if Add/Delete fail in multiwriter perf test Return error if single or multi writer test fails Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honn

[dpdk-dev] [PATCH v5 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-04 Thread Dharmik Thakkar
Fix incorrect calculations for LPM adds, LPM deletes, and average cycles in RCU QSBR perf tests Since, rcu qsbr tests run for 'RCU_ITERATIONS' and not 'ITERATIONS', replace 'ITERATIONS' with 'RCU_ITERATIONS' for calculating adds, deletes, and cycles. Also, for multi-writer perf test, each writer

Re: [dpdk-dev] [PATCH] Fix spelling errors that Lintian complains about

2020-11-04 Thread Thomas Monjalon
04/11/2020 19:34, Thomas Monjalon: > 29/10/2020 14:36, luca.bocca...@gmail.com: > > From: Luca Boccassi > > > > Signed-off-by: Luca Boccassi > > --- > > Would be really great to hook up some spell checkers to the CI, so > > that I'm not the only one who gets nagged by automated tools :-) > > Th

Re: [dpdk-dev] [20.08 PATCH] license: removing the dual prefix to avoid confusion

2020-11-04 Thread Thomas Monjalon
28/07/2020 07:58, Hemant Agrawal: > This patch removes the dual keyword from dual license > definitions to avoid confusion. As the *dual* word is > not required to be added SPDX license. > > Signed-off-by: Hemant Agrawal > --- > Note that following licenses are not exceptions:- > - BSD-3-C

Re: [dpdk-dev] [PATCH v5 1/4] test/lpm: fix cycle calculation in rcu qsbr perf

2020-11-04 Thread Medvedkin, Vladimir
On 04/11/2020 18:58, Dharmik Thakkar wrote: Fix incorrect calculations for LPM adds, LPM deletes, and average cycles in RCU QSBR perf tests Since, rcu qsbr tests run for 'RCU_ITERATIONS' and not 'ITERATIONS', replace 'ITERATIONS' with 'RCU_ITERATIONS' for calculating adds, deletes, and cycles

Re: [dpdk-dev] [PATCH v5 2/4] test/lpm: return error on failure in rcu qsbr perf

2020-11-04 Thread Medvedkin, Vladimir
On 04/11/2020 18:58, Dharmik Thakkar wrote: Return error if Add/Delete fail in multiwriter perf test Return error if single or multi writer test fails Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thak

Re: [dpdk-dev] [PATCH v5 3/4] test/lpm: remove error checking in rcu qsbr perf

2020-11-04 Thread Medvedkin, Vladimir
On 04/11/2020 18:58, Dharmik Thakkar wrote: Remove redundant error checking for reader threads since they never return error. Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagaraha...@arm.com Cc: sta...@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng

Re: [dpdk-dev] [PATCH v5 4/4] test/lpm: avoid code duplication in rcu qsbr perf

2020-11-04 Thread Medvedkin, Vladimir
On 04/11/2020 18:58, Dharmik Thakkar wrote: Avoid code duplication by combining single and multi threaded tests Also, enable support for more than 2 writers Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test/test_lpm_perf.c | 356

Re: [dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing

2020-11-04 Thread Thomas Monjalon
03/11/2020 23:05, David Christensen: > The SPAPR IOMMU requires that a DMA window size be defined before memory > can be mapped for DMA. Current code dynamically modifies the DMA window > size in response to every new memory allocation which is potentially > dangerous because all existing mappings

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix typo in kni programmers guide

2020-11-04 Thread Thomas Monjalon
> > The typo "withe" should have been "with the". This is now fixed. > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v5] lib/power: remove set env deprecation notice

2020-11-04 Thread Thomas Monjalon
04/11/2020 10:28, David Hunt: > Remove notice announcing an already-implemented change. > > In 19.05, rte_power_set_env was changed to return -1 in cases where > the envorinment was already set up, and for the same release, a > deprecation notice was added for the following commit: > 'commit 5a5f3

  1   2   >