[dpdk-dev] [PATCH] doc: update vector mode information

2020-11-26 Thread Ajit Khaparde
PMD can support vector mode when jumbo is enabled as long as MTU is not arge enough to require scattered RX (which also depends on the mbuf size). Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/nics/bnxt.rst b/doc/guide

Re: [dpdk-dev] [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy

2020-11-26 Thread Xing, Beilei
> -Original Message- > From: Xiaoyu Min > Sent: Monday, November 16, 2020 3:55 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Xiaoyu Min > Subject: [PATCH 4/5] net/iavf: fix protocol size for virtchnl copy > > From: Xiaoyu Min > > The rte_flow_item_vlan items are refined.

Re: [dpdk-dev] DTS Test Nic Single Core Perf Scapy Naming Conflict

2020-11-26 Thread Tu, Lijuan
Sorry, I am not quite understand your problem. Do you mean that trex require same driver, but you use your build-in vfio-pci for one nic , and own-built on the other nic? If yes, I think you can make your own-built driver built-in, install it in kernel package. From: David Liu Sent: 2020年11月

Re: [dpdk-dev] [PATCH] doc/rel_notes: remove old deprecation for meson version

2020-11-26 Thread Thomas Monjalon
14/11/2020 11:35, David Marchand: > On Fri, Nov 13, 2020 at 5:17 PM Bruce Richardson > wrote: > > > > DPDK has been using meson 0.47 for some time now, so we can safely > > remove the note calling out this fact. > > > > Signed-off-by: Bruce Richardson > > --- > > -* meson: The minimum supported v

Re: [dpdk-dev] [PATCH v3 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Thomas Monjalon
26/11/2020 17:46, Bruce Richardson: > On Thu, Nov 26, 2020 at 05:43:28PM +0100, Thomas Monjalon wrote: > > From: Gregory Etelson > > > > DPDK relies on pkg-config(1) to provide correct parameters for > > compiler and linker used in application build. Inaccurate build > > parameters, produced by

Re: [dpdk-dev] [PATCH 1/1] doc: remove Linux headers from requirements

2020-11-26 Thread Thomas Monjalon
26/11/2020 17:21, Bruce Richardson: > On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote: > > The compilation of the kernel module KNI is optional. > > The kernel headers should be required for DPDK compilation. not, should not :) > > Fixes: 91a861e54164 ("config: disable Linux kerne

Re: [dpdk-dev] [PATCH] doc: add missing network layers in API reference

2020-11-26 Thread Thomas Monjalon
26/11/2020 15:26, Olivier Matz: > Add missing files in doxy-api-index.md and add a short description > for files that hadn't one. > > Signed-off-by: Olivier Matz > --- > + [VXLAN] (@ref rte_vxlan.h), > + [eCPRI] (@ref rte_ecpri.h), > + [Geneve] (@ref rte_g

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix compilation on RHEL 8.3

2020-11-26 Thread Thomas Monjalon
26/11/2020 19:08, Ferruh Yigit: > On 11/26/2020 6:04 PM, David Marchand wrote: > > On Thu, Nov 26, 2020 at 3:24 PM Olivier Matz wrote: > >> > >> Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix > >> build with Linux 5.6"), a new parameter 'txqueue' has to be added to > >> '

Re: [dpdk-dev] [PATCH v2] doc: update documentation for Bluefield platform

2020-11-26 Thread Thomas Monjalon
24/11/2020 08:32, Asaf Penso: > The documentation file contains some broken links to Mellanox's site. > Also now BlueField-2 platform is supported. > > This patch provides new links and adds documentation for > BlueField-2 platform. > > Signed-off-by: Asaf Penso > --- > v2: styling updates and t

Re: [dpdk-dev] [PATCH] doc: add ConnecX6 Lx and BlueField-2 to mlx5 documentation

2020-11-26 Thread Thomas Monjalon
24/11/2020 11:30, Raslan Darawsheh: > This adds ConnectX6 Lx and BlueFiled-2 to the list of supported > NICs by mlx5 PMD. > > Signed-off-by: Raslan Darawsheh Applied (with fixed typos in title and message), thanks.

Re: [dpdk-dev] [PATCH v5] doc: add Rx functions limitations in mlx5 guide

2020-11-26 Thread Thomas Monjalon
27/11/2020 00:55, Thomas Monjalon: > From: Asaf Penso > > The mlx5 PMD supports various Rx burst functions. > Each function is enabled differently and supports different features. > > Signed-off-by: Asaf Penso > Signed-off-by: Thomas Monjalon > --- > v5: fix formatting by using a table Applie

Re: [dpdk-dev] [PATCH v2] doc: update supported hardware offloads in mlx5

2020-11-26 Thread Thomas Monjalon
22/11/2020 13:05, Asaf Penso: > In DPDK 20.11 the following offload features are added: > * Buffer Split > * Sampling > * Tunnel offload > * 2-port hairpin > * RSS shared action > * Age shared action > > Update the relevant tables with OFED/rdma-core/NIC versions. > > Signed-off-by: Asaf Penso

[dpdk-dev] [PATCH v5] doc: add Rx functions limitations in mlx5 guide

2020-11-26 Thread Thomas Monjalon
From: Asaf Penso The mlx5 PMD supports various Rx burst functions. Each function is enabled differently and supports different features. Signed-off-by: Asaf Penso Signed-off-by: Thomas Monjalon --- v5: fix formatting by using a table --- doc/guides/nics/mlx5.rst | 23 +++

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit wrote: > > script is checking the existing of the kernel module file, but in some > distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. Since this script expects modprobe to be installed (coming with kmod tools), it means modinfo is

Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation

2020-11-26 Thread Matan Azrad
Hi Looks very good direction - it will do some order here. Will be also good to define what is MTU exactly: Maximum Rx packet size \ Maximum Tx packet size \ both? Is it include L2\L3 headers? Vlan? How is it going together with ``uint32_t max_lro_pkt_size``? Also when should the user configu

Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread

2020-11-26 Thread Thomas Monjalon
16/06/2020 18:12, Thomas Monjalon: > 05/06/2020 20:35, Stephen Hemminger: > > On Thu, 4 Jun 2020 10:17:31 -0700 > > Stephen Hemminger wrote: > > > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > > operations are called from a non-EAL thread. > > > > > > rte_lcore_id(

[dpdk-dev] [PATCH] kni: fix rtnl deadlocks and race conditions

2020-11-26 Thread Elad Nachman
This patch leverages on Stephen Hemminger's 64106 patch from Dec 2019, and fixes the issues reported by Ferruh and Igor: A. KNI sync lock is being locked while rtnl is held. If two threads are calling kni_net_process_request() , then the first one wil take the sync lock, release rtnl lock then sl

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix compilation on RHEL 8.3

2020-11-26 Thread Ferruh Yigit
On 11/26/2020 6:04 PM, David Marchand wrote: On Thu, Nov 26, 2020 at 3:24 PM Olivier Matz wrote: Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix build with Linux 5.6"), a new parameter 'txqueue' has to be added to 'ndo_tx_timeout' ndo on RHEL 8.3 kernel. Cc: sta...@dp

Re: [dpdk-dev] [dpdk-stable] [PATCH] kni: fix compilation on RHEL 8.3

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 3:24 PM Olivier Matz wrote: > > Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix > build with Linux 5.6"), a new parameter 'txqueue' has to be added to > 'ndo_tx_timeout' ndo on RHEL 8.3 kernel. > > Cc: sta...@dpdk.org > > Tested-by: Christophe Gross

Re: [dpdk-dev] [dpdk-stable] [PATCH] Nonnumeric input check for Setting hugepages

2020-11-26 Thread Thomas Monjalon
06/04/2020 10:50, Muhammad Bilal: > Bugzilla ID: 432 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: john.mcnam...@intel.com > Signed-off-by: Muhammad Bilal > --- > usertools/dpdk-setup.sh | 23 ++- This script is now replaced with usertools/dpdk-hugepages.py

Re: [dpdk-dev] [PATCH v4] usertools/dpdk-setup.sh: fix dpdk-setup's behaviour on non-alphanumeric inputs

2020-11-26 Thread Thomas Monjalon
24/07/2020 16:05, Jerin Jacob: > On Fri, Jul 24, 2020 at 7:00 PM Thomas Monjalon wrote: > > > > 23/07/2020 19:00, Stephen Hemminger: > > > On Thu, 23 Jul 2020 17:13:17 +0500 > > > Sarosh Arif wrote: > > > > > > > Since this script has no maintainer who is responsible for providing > > > > ACK or

Re: [dpdk-dev] [dpdk-stable] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Olivier Matz
On Thu, Nov 26, 2020 at 06:07:32PM +0100, Thomas Monjalon wrote: > 26/11/2020 17:37, Bruce Richardson: > > On Thu, Nov 26, 2020 at 05:32:26PM +0100, Olivier Matz wrote: > > > Hi Bruce, > > > > > > Thanks for the feedback. > > > > > > On Thu, Nov 26, 2020 at 03:28:46PM +, Bruce Richardson wrot

Re: [dpdk-dev] [PATCH v2] doc: update ice user guide

2020-11-26 Thread Thomas Monjalon
23/11/2020 17:51, Ferruh Yigit: > On 11/18/2020 11:56 PM, Qi Zhang wrote: > > Add link for firmware/OOT kernel driver/DDP download > > Add matching List. > > > > Signed-off-by: Qi Zhang > > Acked-by: Ferruh Yigit Applied, thanks Few minor comments about the formatting: |reg| can be used for

Re: [dpdk-dev] [dpdk-stable] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 06:07:32PM +0100, Thomas Monjalon wrote: > 26/11/2020 17:37, Bruce Richardson: > > On Thu, Nov 26, 2020 at 05:32:26PM +0100, Olivier Matz wrote: > > > Hi Bruce, > > > > > > Thanks for the feedback. > > > > > > On Thu, Nov 26, 2020 at 03:28:46PM +, Bruce Richardson wrot

Re: [dpdk-dev] [dpdk-stable] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Thomas Monjalon
26/11/2020 17:37, Bruce Richardson: > On Thu, Nov 26, 2020 at 05:32:26PM +0100, Olivier Matz wrote: > > Hi Bruce, > > > > Thanks for the feedback. > > > > On Thu, Nov 26, 2020 at 03:28:46PM +, Bruce Richardson wrote: > > > On Thu, Nov 26, 2020 at 03:20:42PM +0100, Olivier Matz wrote: > > > >

Re: [dpdk-dev] [PATCH] ci: hook to Github Actions

2020-11-26 Thread Honnappa Nagarahalli
> > On Thu, Nov 26, 2020 at 5:47 AM Honnappa Nagarahalli > wrote: > > > On Wed, Nov 25, 2020 at 2:45 PM Aaron Conole > wrote: > > > > Thanks for working on this. Sadly, I think we will have to > > > > abandon Travis soon - given the new changes it is looking very > > > > awful. Robot already

Re: [dpdk-dev] [PATCH v2] doc: update features for hns3

2020-11-26 Thread Thomas Monjalon
24/11/2020 17:31, Ferruh Yigit: > On 11/24/2020 1:56 PM, Lijun Ou wrote: > > Since the hns3 NIC hardware features are not counted > > and it is supported in fact. Besides, the flow director > > is not supported and need to delete it. > > > > Fixes: fa29fe45a7b4 ("net/hns3: support queue start and

Re: [dpdk-dev] [PATCH] doc: update TRUFLOW support information

2020-11-26 Thread Thomas Monjalon
25/11/2020 05:46, Ajit Khaparde: > Currently TRUFLOW is supported only on Whitney+ and Stingray devices. > Update the PMD doc with this info. > > Signed-off-by: Ajit Khaparde Applied, thanks

Re: [dpdk-dev] [PATCH] doc: announce end of support for some Broadcom devices

2020-11-26 Thread Thomas Monjalon
> > > > +* Broadcom bnxt PMD: NetXtreme devices belonging to the ``BCM573xx and > > > > + BCM5740x`` families will no longer be supported as of DPDK 21.02. > > > > + Specifically the support for the following Broadcom PCI ids will be > > > > removed > > > > + from the release: ``0x16c8, 0x16c9,

Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute

2020-11-26 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 26, 2020 2:23 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action > attribute > > One small point, I know it was mention in some thread, can we also > deprecate the id? > > Maybe the enti

Re: [dpdk-dev] [PATCH v3 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 05:43:28PM +0100, Thomas Monjalon wrote: > From: Gregory Etelson > > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. Inaccurate build > parameters, produced by pkg-config from DPDK .pc files could fail > appl

Re: [dpdk-dev] [PATCH] doc: remove list of supported OS

2020-11-26 Thread Thomas Monjalon
24/11/2020 17:01, Ferruh Yigit: > On 11/24/2020 2:25 PM, Ajit Khaparde wrote: > > Remove list of supported OS in PMD specific doc. > > Documenting an unsupported version of OS makes more sense in > > PMD specific docs. > > Platforms tested with this device is documented in release notes anyway. > >

[dpdk-dev] [PATCH v2] app/testpmd: fix testpmd flows left before port stop.

2020-11-26 Thread Gregory Etelson
According to RTE flow user guide, PMD will not keep flow rules after port stop. Application resources that refer to flow rules become obsolete after port stop and must not be used. Testpmd maintains linked list of active flows for each port. Entries in that list are allocated dynamically and must b

[dpdk-dev] [PATCH v3 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Thomas Monjalon
From: Gregory Etelson DPDK relies on pkg-config(1) to provide correct parameters for compiler and linker used in application build. Inaccurate build parameters, produced by pkg-config from DPDK .pc files could fail application build or cause unpredicted results during application runtime. Updat

Re: [dpdk-dev] [PATCH] eal: fix errno on service cores init failure

2020-11-26 Thread Van Haaren, Harry
> -Original Message- > From: Olivier Matz > Sent: Thursday, November 26, 2020 4:37 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Richardson, Bruce ; Jerin Jacob > ; sta...@dpdk.org > Subject: Re: [PATCH] eal: fix errno on service cores init failure > > Hi Harry, > > On Thu, Nov 26, 202

Re: [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Thomas Monjalon
26/11/2020 17:24, Bruce Richardson: > On Thu, Nov 26, 2020 at 04:42:18PM +0100, Thomas Monjalon wrote: > > From: Gregory Etelson > > > > DPDK relies on pkg-config(1) to provide correct parameters for > > compiler and linker used in application build. Inaccurate build > > parameters, produced by

Re: [dpdk-dev] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 05:32:26PM +0100, Olivier Matz wrote: > Hi Bruce, > > Thanks for the feedback. > > On Thu, Nov 26, 2020 at 03:28:46PM +, Bruce Richardson wrote: > > On Thu, Nov 26, 2020 at 03:20:42PM +0100, Olivier Matz wrote: > > > When dpdk is compiled as static libraries, it is not

Re: [dpdk-dev] [PATCH] eal: fix errno on service cores init failure

2020-11-26 Thread Olivier Matz
Hi Harry, On Thu, Nov 26, 2020 at 02:46:30PM +, Van Haaren, Harry wrote: > > -Original Message- > > From: Olivier Matz > > Sent: Thursday, November 26, 2020 2:25 PM > > To: dev@dpdk.org > > Cc: Richardson, Bruce ; Jerin Jacob > > ; Van Haaren, Harry > > ; sta...@dpdk.org > > Subject:

Re: [dpdk-dev] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Olivier Matz
Hi Bruce, Thanks for the feedback. On Thu, Nov 26, 2020 at 03:28:46PM +, Bruce Richardson wrote: > On Thu, Nov 26, 2020 at 03:20:42PM +0100, Olivier Matz wrote: > > When dpdk is compiled as static libraries, it is not possible > > to load a plugin from an application. We get the following err

Re: [dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 3:19 PM Ferruh Yigit wrote: > > This is an effort to update the dpdk-setup.sh script and keep it one > more year until whole functionality of it is replaced. > > Other option is to remove it completely, please comment. I would simply remove this script. Binding devices ca

Re: [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 04:42:18PM +0100, Thomas Monjalon wrote: > From: Gregory Etelson > > DPDK relies on pkg-config(1) to provide correct parameters for > compiler and linker used in application build. Inaccurate build > parameters, produced by pkg-config from DPDK .pc files could fail > appl

Re: [dpdk-dev] [PATCH 1/1] doc: remove Linux headers from requirements

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 05:08:37PM +0100, Thomas Monjalon wrote: > The compilation of the kernel module KNI is optional. > The kernel headers should be required for DPDK compilation. > > Fixes: 91a861e54164 ("config: disable Linux kernel modules by default") > Cc: sta...@dpdk.org > > Signed-off-b

Re: [dpdk-dev] DPDK Release Status Meeting 26/11/2020

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 4:09 PM Ferruh Yigit wrote: >* Looking to the documentation patches > * There are lots of them to review > * David will create a list of patches waiting for review >* Please support doc reviews >* Waiting for v2 of dpdk-setup patchset with doc upda

[dpdk-dev] [PATCH 1/1] doc: remove Linux headers from requirements

2020-11-26 Thread Thomas Monjalon
The compilation of the kernel module KNI is optional. The kernel headers should be required for DPDK compilation. Fixes: 91a861e54164 ("config: disable Linux kernel modules by default") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- doc/guides/linux_gsg/sys_reqs.rst | 2 -- 1 file chang

Re: [dpdk-dev] [RFC PATCH v1] build: add platform meson option

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 04:47:29PM +0100, Juraj Linkeš wrote: > The current meson option 'machine' should only specify the ISA, which is > not sufficient for Arm, where setting ISA implies other setting as well. > Add a new meson option, 'platform', which differentiates the type of the > build (nat

Re: [dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 12:49 PM Bruce Richardson wrote: > > On Wed, Oct 14, 2020 at 05:43:29PM +0100, Ferruh Yigit wrote: > > On 9/24/2020 6:53 PM, Stephen Hemminger wrote: > > > We should be encouraging the use of vfio_pci for developers, not telling > > > them to use igb_uio. > > > > > > Signed

[dpdk-dev] [RFC PATCH v1] build: add platform meson option

2020-11-26 Thread Juraj Linkeš
The current meson option 'machine' should only specify the ISA, which is not sufficient for Arm, where setting ISA implies other setting as well. Add a new meson option, 'platform', which differentiates the type of the build (native/generic) and sets machine accordingly, unless the user chooses to

[dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications

2020-11-26 Thread Thomas Monjalon
From: Gregory Etelson DPDK relies on pkg-config(1) to provide correct parameters for compiler and linker used in application build. Inaccurate build parameters, produced by pkg-config from DPDK .pc files could fail application build or cause unpredicted results during application runtime. Updat

Re: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop

2020-11-26 Thread Thomas Monjalon
24/11/2020 15:42, Ajit Khaparde: > On Mon, Aug 10, 2020 at 11:15 PM Gregory Etelson wrote: > > > > According to current RTE API, port flow rules must not be kept > > after port stop. > > > > Testpmd did not flush port flow rules after `port stop' command was > > called. As the result, after the po

Re: [dpdk-dev] [PATCH v2] doc: update pdump documentation

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 2:58 PM Reshma Pattan wrote: > > Update the pdump library programmers guide and Howto doc > with the use of multi process channel replacing socket > based communication. > > Signed-off-by: Reshma Pattan > Acked-by: Bruce Richardson [snip] > The library APIs ``rte_pdump

Re: [dpdk-dev] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Bruce Richardson
On Thu, Nov 26, 2020 at 03:20:42PM +0100, Olivier Matz wrote: > When dpdk is compiled as static libraries, it is not possible > to load a plugin from an application. We get the following error: > > EAL: librte_pmd_.so: undefined symbol: per_lcore__rte_errno > > This happens because the dpdk

Re: [dpdk-dev] [PATCH v2 6/6] usertools/setup: move removal target to 21.11

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:19 > To: Thomas Monjalon ; Ray Kinsella > ; Neil Horman > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ;

Re: [dpdk-dev] [PATCH] doc: add missing SPDX header

2020-11-26 Thread David Marchand
On Mon, Nov 16, 2020 at 3:22 AM Stephen Hemminger wrote: > > This document never had any license or copyright on this file, add one. > > Fixes: b932ebcb2664 ("doc: add NIC performance guide on Linux IA") Cc: sta...@dpdk.org > Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal Acked-by: J

[dpdk-dev] DPDK Release Status Meeting 26/11/2020

2020-11-26 Thread Ferruh Yigit
Meeting minutes of 26 November 2020 --- Agenda: * Release Dates * -rc5 status * Subtrees * LTS * OvS Participants: * Arm * Broadcom * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - * v20.11 dates * -rc5 is released on S

Re: [dpdk-dev] [PATCH v2] doc: fix grammatical error

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 2:17 PM David Marchand wrote: > On Wed, Sep 16, 2020 at 1:16 PM Sarosh Arif wrote: > > > > This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', > > so that the sentences can become grammatically accurate. Fixes: 2e486e26328c ("doc: remove Intel refer

Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-26 Thread Walsh, Conor
Hi Ferruh, I tested this patch on Ubuntu 20.04 (5.4.0-53-generic) and Centos 8.2 (4.18.0-193.28.1.el8_2.x86_64), load VFIO worked on both systems. I'm not sure if this is a problem that effects either of these distros though. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 202

Re: [dpdk-dev] [PATCH v2 4/6] usertools/setup: remove hugepage functions

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH

Re: [dpdk-dev] [PATCH v2 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH

Re: [dpdk-dev] [PATCH v2 2/6] usertools/setup: remove inserting custom kernel modules

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH

Re: [dpdk-dev] [PATCH] eal: fix errno on service cores init failure

2020-11-26 Thread Van Haaren, Harry
> -Original Message- > From: Olivier Matz > Sent: Thursday, November 26, 2020 2:25 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Jerin Jacob > ; Van Haaren, Harry > ; sta...@dpdk.org > Subject: [PATCH] eal: fix errno on service cores init failure > > Currently, when rte_service_init() f

Re: [dpdk-dev] [PATCH v2 1/6] usertools/setup: remove make based build

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Tested V2 patch, the docs also build successfully. Thanks, Conor. > From: Yigit, Ferruh > Sent: Thursday 26 November 2020 14:18 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > ; Walsh, Conor > Subject: [PATCH

[dpdk-dev] [PATCH] doc: add missing network layers in API reference

2020-11-26 Thread Olivier Matz
Add missing files in doxy-api-index.md and add a short description for files that hadn't one. Signed-off-by: Olivier Matz --- doc/api/doxy-api-index.md | 7 ++- lib/librte_net/rte_ecpri.h | 9 + lib/librte_net/rte_gre.h | 11 +++ lib/librte_net/rte_higig.h | 8

[dpdk-dev] [PATCH] eal: fix errno on service cores init failure

2020-11-26 Thread Olivier Matz
Currently, when rte_service_init() fails at initialization, we see the following message: Cannot init EAL: Exec format error This error code does describe the real issue. Instead, use the error code returned by the function. Fixes: e39824500825 ("service: initialize with EAL") Cc: sta...@dpdk.

[dpdk-dev] [PATCH] kni: fix compilation on RHEL 8.3

2020-11-26 Thread Olivier Matz
Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix build with Linux 5.6"), a new parameter 'txqueue' has to be added to 'ndo_tx_timeout' ndo on RHEL 8.3 kernel. Cc: sta...@dpdk.org Tested-by: Christophe Grosse Signed-off-by: Olivier Matz --- kernel/linux/kni/compat.h | 4

[dpdk-dev] [PATCH] app: fix plugin load on static builds

2020-11-26 Thread Olivier Matz
When dpdk is compiled as static libraries, it is not possible to load a plugin from an application. We get the following error: EAL: librte_pmd_.so: undefined symbol: per_lcore__rte_errno This happens because the dpdk symbols are not exported. Add them to the dynamic symbol table by using '

[dpdk-dev] [PATCH v2 6/6] usertools/setup: move removal target to 21.11

2020-11-26 Thread Ferruh Yigit
There are still some functions in the script that not replaced completely, give more time to complete removal of the tool. A warning added to script documentation about the removal plan. Current functionality supported by the script is: --

[dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

2020-11-26 Thread Ferruh Yigit
script is checking the existing of the kernel module file, but in some distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'. Add wildcard to cover both compressed and not compressed cases. Signed-off-by: Ferruh Yigit --- usertools/dpdk-setup.sh | 2 +- 1 file changed, 1 insert

[dpdk-dev] [PATCH v2 4/6] usertools/setup: remove hugepage functions

2020-11-26 Thread Ferruh Yigit
There is a specific tool to setup hugepages, with better support, no need to have duplication. The hugepage script is: './usertools/dpdk-hugepages.py' Please try "./usertools/dpdk-hugepages.py -h" for more information about the tool. Signed-off-by: Ferruh Yigit --- doc/guides/faq/faq.rst

[dpdk-dev] [PATCH v2 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Ferruh Yigit
Running application relies on make based build variable 'RTE_TARGET' to find the location of the applications, which is not valid anymore. Signed-off-by: Ferruh Yigit --- doc/guides/linux_gsg/quick_start.rst | 42 +++--- usertools/dpdk-setup.sh | 52 ++---

[dpdk-dev] [PATCH v2 2/6] usertools/setup: remove inserting custom kernel modules

2020-11-26 Thread Ferruh Yigit
Custom DPDK kernel module insert support relies on make based build variable 'RTE_TARGET' to find the location of the kernel modules, which is not valid anymore. Also 'igb_uio' kernel module moved to another git repository: https://git.dpdk.org/dpdk-kmods/ Signed-off-by: Ferruh Yigit --- doc/gu

[dpdk-dev] [PATCH v2 1/6] usertools/setup: remove make based build

2020-11-26 Thread Ferruh Yigit
DPDK build system is switched to 'meson' based build, please check the documentation for details: "doc/guides/linux_gsg/build_dpdk.rst" Signed-off-by: Ferruh Yigit --- doc/guides/linux_gsg/quick_start.rst | 180 +-- usertools/dpdk-setup.sh | 74 +--

[dpdk-dev] [PATCH v2 0/6] update dpdk-setup.sh

2020-11-26 Thread Ferruh Yigit
This is an effort to update the dpdk-setup.sh script and keep it one more year until whole functionality of it is replaced. Other option is to remove it completely, please comment. v2: * Documentation updated Ferruh Yigit (6): usertools/setup: remove make based build usertools/setup: remove

Re: [dpdk-dev] [PATCH 4/6] usertools/setup: remove hugepage functions

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 4/6] usertools/setup: r

Re: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Thomas Monjalon
26/11/2020 15:02, Walsh, Conor: > Hi Ferruh, > > Patch tested. > > Thanks, > Conor. > > > -Original Message- > > From: dev On Behalf Of Ferruh Yigit > > Sent: Wednesday 25 November 2020 19:19 > > To: Thomas Monjalon > > Cc: Yigit, Ferruh ; dev@dpdk.org; > > techbo...@dpdk.org; Stephen

Re: [dpdk-dev] [PATCH 3/6] usertools/setup: remove running built applications

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [

Re: [dpdk-dev] [PATCH 2/6] usertools/setup: remove inserting custom kernel modules

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [

[dpdk-dev] [PATCH v2] doc: update pdump documentation

2020-11-26 Thread Reshma Pattan
Update the pdump library programmers guide and Howto doc with the use of multi process channel replacing socket based communication. Signed-off-by: Reshma Pattan Acked-by: Bruce Richardson --- v2: fixes for the review comments --- doc/guides/howto/packet_capture_framework.rst | 12 +++ doc/

Re: [dpdk-dev] [PATCH 1/6] usertools/setup: remove make based build

2020-11-26 Thread Walsh, Conor
Hi Ferruh, Patch tested. Thanks, Conor. > From: dev On Behalf Of Ferruh Yigit > Sent: Wednesday 25 November 2020 19:19 > To: Thomas Monjalon > Cc: Yigit, Ferruh ; dev@dpdk.org; > techbo...@dpdk.org; Stephen Hemminger > ; Richardson, Bruce > > Subject: [dpdk-dev] [PATCH 1/6] usertools/setup: r

Re: [dpdk-dev] [PATCH v2] doc: fix grammatical error

2020-11-26 Thread David Marchand
On Wed, Sep 16, 2020 at 1:16 PM Sarosh Arif wrote: > > This patch corrects a grammatical error by changing 'an DPDK' to 'a DPDK', > so that the sentences can become grammatically accurate. > > Signed-off-by: Sarosh Arif > --- > doc/guides/linux_gsg/build_sample_apps.rst| 4 ++-- > doc/gu

Re: [dpdk-dev] [PATCH v4 3/6] app/testpmd: remove restriction on txpkts set

2020-11-26 Thread Ferruh Yigit
On 11/26/2020 7:24 AM, Slava Ovsiienko wrote: The bug: https://bugs.dpdk.org/show_bug.cgi?id=584 Can we pass the nb_segs = 1 always? One descriptor is minimal basic capability to send, it should be always supported. Hi Slava, I didn't get your comment, can you please elaborate? With best

Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation

2020-11-26 Thread Ferruh Yigit
On 11/26/2020 11:28 AM, Andrew Rybchenko wrote: On 11/24/20 8:36 PM, Ferruh Yigit wrote: Signed-off-by: Ferruh Yigit Acked-by: Konstantin Ananyev A couple of questions below, but anyway: Acked-by: Andrew Rybchenko --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc:

Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute

2020-11-26 Thread Ferruh Yigit
On 11/26/2020 9:08 AM, Ori Kam wrote: Hi All -Original Message- From: Ajit Khaparde Sent: Tuesday, November 24, 2020 8:10 PM Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute On Mon, Nov 2, 2020 at 8:01 AM Ferruh Yigit wrote: On 11/1/2020 10:4

Re: [dpdk-dev] [PATCH] doc: announce end of support for some Broadcom devices

2020-11-26 Thread Bruce Richardson
On Wed, Nov 25, 2020 at 02:18:43PM +0530, Jerin Jacob wrote: > On Tue, Nov 24, 2020 at 9:04 PM Ferruh Yigit wrote: > > > > On 10/26/2020 9:46 PM, Ajit Khaparde wrote: > > > Devices belonging to BCM573xx and BCM5740x family will not be supported > > > from the 21.02 release. > > > > > > Signed-off-

Re: [dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio

2020-11-26 Thread Bruce Richardson
On Wed, Oct 14, 2020 at 05:43:29PM +0100, Ferruh Yigit wrote: > On 9/24/2020 6:53 PM, Stephen Hemminger wrote: > > We should be encouraging the use of vfio_pci for developers, not telling > > them to use igb_uio. > > > > Signed-off-by: Stephen Hemminger > > --- > > v2 -- drop change about filenam

Re: [dpdk-dev] [PATCH] doc: add missing SPDX header

2020-11-26 Thread Mcnamara, John
Thanks Stephen. Acked-by: John McNamara

Re: [dpdk-dev] [PATCH] doc: update pdump documentation

2020-11-26 Thread Bruce Richardson
On Mon, Jul 13, 2020 at 03:25:25PM +0100, Reshma Pattan wrote: > Update the pdump library programmers guide and Howto doc > with the use of multi process channel replacing socket > based communication. > > Signed-off-by: Reshma Pattan > --- Some minor adjustments I'd suggest below. Otherwise: A

Re: [dpdk-dev] [RFC v2] doc: announce max Rx packet len field deprecation

2020-11-26 Thread Andrew Rybchenko
On 11/24/20 8:36 PM, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > Acked-by: Konstantin Ananyev A couple of questions below, but anyway: Acked-by: Andrew Rybchenko > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Konstantin Ananyev > Cc: Matan Azrad > Cc: Olivier Matz > Cc:

Re: [dpdk-dev] [PATCH] doc: add missing SPDX header

2020-11-26 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

[dpdk-dev] Need reviews before 20.11 release

2020-11-26 Thread David Marchand
Here is the bundle with patches being looked at before the release. https://patchwork.dpdk.org/bundle/dmarchand/20.11/?archive=both&state=* Thomas please correct me if I missed something since I lost the draft I had written... Highlights where more eyes will help: - waiting for more acks from Tech

[dpdk-dev] [PATCH 4/4] app/flow-perf: remove redundant items memset and vars

2020-11-26 Thread Wisam Jaddo
Since items are static then the default values will be zero, thus the memset to zero value is just a redundant code. Also remove the all not needed variables, that can be replaced with direct set to the structure itself. Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wi

[dpdk-dev] [PATCH 3/4] app/flow-perf: change clock measurement functions

2020-11-26 Thread Wisam Jaddo
The clock() function is not good practice to use for multiple cores/threads, since it measures the CPU time used by the process and not the wall clock time, while when running through multiple cores/threads simultaneously, we can burn through CPU time much faster. As a result this commit will chan

[dpdk-dev] [PATCH 2/4] app/flow-perf: add multiple cores insertion and deletion

2020-11-26 Thread Wisam Jaddo
One of the ways to increase the insertion/deletion rate is to use multi-threaded insertion/deletion. Thus it's needed to have support for testing and measure those rates using flow-perf application. Now we generate cores and distribute all flows to those cores, and start inserting/deleting in para

[dpdk-dev] [PATCH 1/4] app/flow-perf: refactor flows handler

2020-11-26 Thread Wisam Jaddo
Provide the flows_handler() function the ability to control flow performance processes. It is made possible after the introduction of the insert_flows() function. Also provide to the flows_handler() function the ability to print the DPDK layer memory consumption of rte_flow rule, regardless if del

[dpdk-dev] [PATCH 0/4] app/flow-perf: add multi threaded support

2020-11-26 Thread Wisam Jaddo
After this series the application will start supporting testing multiple threaded insertion and deletion rates. Also it will provide the latency & throughput rates of all threads. Wisam Jaddo (4): app/flow-perf: refactor flows handler app/flow-perf: add multiple cores insertion and deletion

Re: [dpdk-dev] [dpdk-announce] release candidate 20.11-rc5

2020-11-26 Thread Govindharajan, Hariprasad
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Sunday, November 22, 2020 10:07 PM > To: annou...@dpdk.org > Subject: [dpdk-dev] [dpdk-announce] release candidate 20.11-rc5 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/ta

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: removed typing mistake

2020-11-26 Thread David Marchand
On Wed, Sep 9, 2020 at 11:39 PM Muhammad Bilal wrote: > > Here I have removed 'that' from the sentence to make it grammatically > correct, as it seems to be a typing mistake > > Fixes: d0dff9ba445e ("doc: sample application user guide") > Cc: bernard.iremon...@intel.com > > Signed-off-by: Muhammad

Re: [dpdk-dev] [PATCH] test: fix buffer overflow

2020-11-26 Thread Ling, WeiX
Tested-by: Wei Ling Regards, Ling Wei > -Original Message- > From: dev On Behalf Of Zhang,Alvin > Sent: Wednesday, November 25, 2020 05:46 PM > To: Liang, Cunming > Cc: dev@dpdk.org; Zhang, AlvinX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] test: fix buffer overflow >

Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute

2020-11-26 Thread Ori Kam
Hi All > -Original Message- > From: Ajit Khaparde > Sent: Tuesday, November 24, 2020 8:10 PM > Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action > attribute > > On Mon, Nov 2, 2020 at 8:01 AM Ferruh Yigit wrote: > > > > On 11/1/2020 10:45 AM, Andrew Rybchenk

[dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_callback_register

2020-11-26 Thread Tal Shnaiderman
interrupt callback register is not implemented in Windows. Add stub with -ENOTSUP return value and export the function. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_eal/windows/eal_interrupts.c | 9 + 2 files changed, 10 insertions(+) diff

Re: [dpdk-dev] [PATCH] ci: hook to Github Actions

2020-11-26 Thread David Marchand
On Thu, Nov 26, 2020 at 5:47 AM Honnappa Nagarahalli wrote: > > On Wed, Nov 25, 2020 at 2:45 PM Aaron Conole wrote: > > > Thanks for working on this. Sadly, I think we will have to abandon > > > Travis soon - given the new changes it is looking very awful. Robot > > > already is starved for job

  1   2   >