Re: [dpdk-dev] [PATCH v2] app/testpmd: support multi-process

2021-03-21 Thread Min Hu (Connor)
在 2021/3/22 10:27, Ajit Khaparde 写道: :::snip +* ``--proc-type`` + Specify a given process instance as the primary or secondary DPDK instance. ``auto`` set here is ok. + +* ``-l CORELIST`` + List of cores to run on. the corelist should be different in primary process and

[dpdk-dev] [PATCH v2] vhost: add support for packed ring in async vhost

2021-03-21 Thread Cheng Jiang
For now async vhost data path only supports split ring structure. In order to make async vhost compatible with virtio 1.1 spec this patch enables packed ring in async vhost data path. Signed-off-by: Cheng Jiang --- v2: * fix wrong buffer index in rte_vhost_poll_enqueue_completed() * add async

Re: [dpdk-dev] [PATCH v2] app/testpmd: support multi-process

2021-03-21 Thread Ajit Khaparde
:::snip > +* ``--proc-type`` > + Specify a given process instance as the primary or secondary DPDK > instance. ``auto`` set here is ok. > + > +* ``-l CORELIST`` > + List of cores to run on. the corelist should be different in primary > process and secondary process. > + > +*

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-21 Thread Devendra Singh Rawat
> -Original Message- > From: Igor Russkikh > Sent: Friday, March 19, 2021 3:17 PM > To: dev@dpdk.org > Cc: Rasesh Mody ; Devendra Singh Rawat > ; Igor Russkikh > Subject: [PATCH v2 0/2] qede: 2020-02 minor fixes > > Two small fixes after customer feedback. > > v2: improved abit log m

Re: [dpdk-dev] [PATCH 2/2] qede: make driver accept bigger rss tables

2021-03-21 Thread Devendra Singh Rawat
Sure Igor, I will do that. Thanks, Devendra > -Original Message- > From: Igor Russkikh > Sent: Friday, March 19, 2021 3:18 PM > To: Devendra Singh Rawat ; dev@dpdk.org > Cc: Rasesh Mody ; sta...@dpdk.org > Subject: RE: [PATCH 2/2] qede: make driver accept bigger rss tables > > > > IMO,

Re: [dpdk-dev] [PATCH v2 4/6] net/ngbe: add device init and uninit

2021-03-21 Thread Jiawen Wu
On Saturday, March 20, 2021 1:47 AM, Stephen Hemminger wrote: > On Fri, 19 Mar 2021 15:26:26 +0800 > Jiawen Wu wrote: > > > +++ b/drivers/net/ngbe/base/ngbe_osdep.h > > @@ -0,0 +1,172 @@ > > > +#define false 0 > > +#define true1 > > These will conflict with normal

Re: [dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text

2021-03-21 Thread Li, Xiaoyun
> -Original Message- > From: Thomas Monjalon > Sent: Monday, March 22, 2021 06:31 > To: dev@dpdk.org > Cc: david.march...@redhat.com; sta...@dpdk.org; Ajit Khaparde > ; Richardson, Bruce > ; Andrew Rybchenko > ; Li, Xiaoyun ; Ori > Kam ; Bing Zhao ; Iremonger, Bernard > ; Jens Freimann

Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build

2021-03-21 Thread Min Hu (Connor)
Hi, all, any comments for this patch? Hope for your reply. Thanks. 在 2021/3/5 9:36, oulijun 写道: 在 2021/3/1 18:46, Juraj Linkeš 写道: -Original Message- From: Thomas Monjalon Sent: Wednesday, February 24, 2021 1:10 PM To: Juraj Linkeš Cc: oulijun ; ferruh.yi

[dpdk-dev] [PATCH v4 11/11] app/testpmd: fix usage text

2021-03-21 Thread Thomas Monjalon
The options help text was including an incomplete and redundant summary of the options before explaining each. The summary is dropped. The details of the option --hairpin-mode had an extra space, breaking the alignment with the next line. There were some mismatches between options in the usage te

[dpdk-dev] [PATCH v4 10/11] app/regex: fix usage text

2021-03-21 Thread Thomas Monjalon
The usage syntax help includes the program name which was fake. It is replaced with the real name from argv. Fixes: de06137cb295 ("app/regex: add RegEx test application") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Ori Kam Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH v4 09/11] app: hook in EAL usage help

2021-03-21 Thread Thomas Monjalon
Use rte_set_application_usage_hook() in the test applications, so the full help including EAL options can be printed in one go with the EAL option -h or --help. Signed-off-by: Thomas Monjalon Acked-by: Wisam Jaddo Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- app/pdump/main.c

[dpdk-dev] [PATCH v4 08/11] app: fix exit messages

2021-03-21 Thread Thomas Monjalon
Some applications were printing useless messages with rte_exit() after showing the help. Using exit() is enough in this case. Some applications were using a redundant printf or fprintf() before calling rte_exit(). The messages are unified in a single rte_exit(). Some rte_exit() calls were missing

[dpdk-dev] [PATCH v4 07/11] eal: add log level help

2021-03-21 Thread Thomas Monjalon
The option --log-level was not completely described in the usage text, and it was difficult to guess the names of the log types and levels. A new value "help" is accepted after --log-level to give more details about the syntax and listing the log types and levels. The array "levels" used for leve

[dpdk-dev] [PATCH v4 06/11] eal: catch invalid log level number

2021-03-21 Thread Thomas Monjalon
The parsing check for invalid log level was not trying to catch irrelevant numeric values. A log level 0 is now a failure in options parsing so it can be caught early. A log level higher than the max (8) is accepted with a warning message. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson

[dpdk-dev] [PATCH v4 05/11] eal: introduce maximum log level macro

2021-03-21 Thread Thomas Monjalon
RTE_DIM(...) and RTE_LOG_DEBUG were used to get the highest log level. For better clarity a new constant RTE_LOG_MAX is introduced and mapped to RTE_LOG_DEBUG. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_log.c |

[dpdk-dev] [PATCH v4 04/11] eal: move private log functions

2021-03-21 Thread Thomas Monjalon
Some private log functions had a wrong "rte_" prefix. All private log functions are moved from eal_private.h to the new file eal_log.h: rte_eal_log_init -> eal_log_init rte_log_save_regexp -> eal_log_save_regexp rte_log_save_pattern -> eal_log_save_pattern eal_log_s

[dpdk-dev] [PATCH v4 03/11] eal: use macros for help option

2021-03-21 Thread Thomas Monjalon
The macros OPT_HELP and OPT_HELP_NUM were not used where appropriate. Signed-off-by: Thomas Monjalon Acked-by: Bruce Richardson Acked-by: Andrew Rybchenko --- lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/freebsd/eal.c | 2 +- lib/librte_eal/linux/eal.c

[dpdk-dev] [PATCH v4 02/11] eal: improve options usage text

2021-03-21 Thread Thomas Monjalon
The description of the EAL options was printed before the application description provided via the hook. It is better to let the application print the global syntax and describes the detail of the EAL options below. Also, some useless lines are removed, and the alignment of few options is fixed.

[dpdk-dev] [PATCH v4 01/11] eal: explain argv behaviour during init

2021-03-21 Thread Thomas Monjalon
After argument parsing done by rte_eal_init(), the remaining arguments are to be parsed by the application by progressing in the argv array. In this context, the first string represented by argv[0] is still the same program name as the original argv[0], while the next strings are the application ar

[dpdk-dev] [PATCH v4 00/11] improve options help

2021-03-21 Thread Thomas Monjalon
The main intent of this series is to provide a nice help for the --log-level option. More patches are added to improve options help in general. v4: - fix more misses in testpmd help - add some "Fixes:" lines v3: - fix use of RTE_LOG_MAX - accept (with warning) log level higher tha

Re: [dpdk-dev] [PATCH] devtools: check logtype format

2021-03-21 Thread Andrew Rybchenko
On 3/20/21 10:26 AM, Thomas Monjalon wrote: 19/03/2021 21:37, David Marchand: Enforce that added logtypes follow the convention: - for lib/librte_XXX: lib.XXX and lib.XXX.* - for drivers/class/XXX: pmd.class.XXX and pmd.class.XXX.* What about common drivers which skip the "common" part: pmd.XX

Re: [dpdk-dev] [PATCH v3 3/3] event/octeontx2: add timer periodic mode support

2021-03-21 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Shijith Thotton >Sent: Wednesday, March 17, 2021 1:34 PM >To: Erik Gabriel Carrillo >Cc: Shijith Thotton ; Pavan Nikhilesh >Bhagavatula ; Jerin Jacob Kollanukkaran >; dev@dpdk.org >Subject: [PATCH v3 3/3] event/octeontx2: add timer periodic mode >support > >A

Re: [dpdk-dev] [PATCH] app/eventdev: fix timeout accuracy

2021-03-21 Thread Jerin Jacob
On Wed, Mar 17, 2021 at 11:30 PM Carrillo, Erik G wrote: > > Hi Pavan, > > > -Original Message- > > From: dev On Behalf Of > > pbhagavat...@marvell.com > > Sent: Thursday, February 25, 2021 6:02 AM > > To: jer...@marvell.com > > Cc: dev@dpdk.org; Pavan Nikhilesh ; > > sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH] event/dlb2: Optimize Dequeue Operations

2021-03-21 Thread Jerin Jacob
On Wed, Mar 17, 2021 at 10:33 PM Timothy McDaniel wrote: > > Convert code to use x86 vector instructions, thereby significantly > improving dequeue performance. > > Signed-off-by: Timothy McDaniel > --- > config/rte_config.h|1 + > drivers/event/dlb2/dlb2.c | 607 > +++

Re: [dpdk-dev] [PATCH 00/25] Add Support for DLB v2.5

2021-03-21 Thread Jerin Jacob
On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel wrote: > > This patch series adds support for DLB v2.5 to > the current DLB V2.0 PMD. The resulting PMD supports > both hardware versions. > > The main differences between the DLB v2.5 and v2.0 hardware > are: > - Number of queues/ports > - DLB v2.5

Re: [dpdk-dev] [PATCH v2 0/2] qede: 2020-02 minor fixes

2021-03-21 Thread Rasesh Mody
> From: Igor Russkikh > Sent: Friday, March 19, 2021 3:17 PM > > Two small fixes after customer feedback. > > v2: improved abit log message > > Igor Russkikh (2): > qede: reduce trace verbosity level > qede: make driver accept bigger rss tables > > drivers/net/qede/base/ecore_int.c | 2 +-

Re: [dpdk-dev] [EXT] [PATCH 02/25] event/dlb2: add DLB v2.5 probe-time hardware init

2021-03-21 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Timothy McDaniel > Sent: Wednesday, March 17, 2021 3:49 AM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; > harry.van.haa...@intel.com; m...@ashroe.eu; nhor...@tuxdriver.com; > nikhil@intel.com; erik.g.carri...@intel.com; abhinandan.guj...@intel.com;

Re: [dpdk-dev] [PATCH] event/octeontx2: fix xaq pool reconfigure

2021-03-21 Thread Jerin Jacob
On Sat, Mar 20, 2021 at 2:38 AM wrote: > > From: Pavan Nikhilesh > > When XAQ pool is being re-configured, and if the same memzone > is used for fc_mem when freeing the old mempool the fc_mem > will be incorrectly updated with the free count. > > Fixes: ffa4ec0b6063 ("event/octeontx2: allow adapt

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-21 Thread Jerin Jacob
On Wed, Mar 17, 2021 at 3:49 AM Timothy McDaniel wrote: > > This commit adds dlb v2.5 probe support, and updates > parameter parsing. > > The dlb v2.5 device differs from dlb v2, in that the > number of resources (ports, queues, ...) is different, > so macros have been added to take the device ver

[dpdk-dev] [PATCH v2] usertools: check 0-division with hugepage size

2021-03-21 Thread Thomas Monjalon
The default page size can be None, and the page size from user request can be 0 kB if lower than 1024. In these cases, a division will fail. In order to avoid a Python exception, the page size is checked and an error message "Invalid page size" is printed. A similar error message is printed in set

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

2021-03-21 Thread Andrew Rybchenko
On 3/21/21 12:00 PM, Thomas Monjalon wrote: > Since rte_flow is the only API for filtering operations, > the legacy driver interface filter_ctrl was too much complicated > for the simple task of getting the struct rte_flow_ops. > > The filter type RTE_ETH_FILTER_GENERIC and > the filter operarion

[dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-21 Thread Thomas Monjalon
The header file rte_eth_ctrl.h should not be needed because this legacy filtering API is completely replaced with the rte_flow API. However some definitions from this file are still used by some drivers, but such usage is already covered by an implicit include via rte_ethdev.h. Signed-off-by: Thom

[dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

2021-03-21 Thread Thomas Monjalon
Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_FILTER_GET are removed. The new driver callback

[dpdk-dev] [PATCH v3 0/2] ethdev: remove some use of legacy filtering

2021-03-21 Thread Thomas Monjalon
The ultimate goal is to remove all traces of the legacy filtering API from ethdev_driver.h and rte_eth_ctrl.h (whole file). This is just one more step of cleanup in progress. The next steps will require the involvement of some driver maintainers. v3: - keep ENOSYS error code - add commen

[dpdk-dev] [PATCH v2 4/4] event/octeontx2: timer always use virtual counter

2021-03-21 Thread pbhagavatula
From: Pavan Nikhilesh Use virtual counter for estimating current bucket as PMU cannot be reliably used to estimate time. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 19 +++-- drivers/event/octeontx2/otx2_tim_evdev.h | 26 +++

[dpdk-dev] [PATCH v2 3/4] event/octeontx2: reduce chunk pool memory usage

2021-03-21 Thread pbhagavatula
From: Pavan Nikhilesh Reduce amount of memory used by chunk pool when the mempool used is OCTEONTX2 NPA. Previously, the number of chunks configured when NPA is used is equal to the number of timers requested plus the number of buckets and if the max timeout is long enough w.r.t. resolution reque

[dpdk-dev] [PATCH v2 2/4] event/octeontx2: optimize timer arm routine

2021-03-21 Thread pbhagavatula
From: Pavan Nikhilesh Use relaxed load exclusive when polling for other threads or hardware to complete. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_worker.c | 1 + drivers/event/octeontx2/otx2_tim_worker.h | 162 -- 2 files changed, 89 insertions(

[dpdk-dev] [PATCH v2 1/4] event/octeontx2: simplify timer bucket estimation

2021-03-21 Thread pbhagavatula
From: Pavan Nikhilesh Simplify timer bucket estimation we need not align buckets to power of 2 instead use reciprocal division to compute mod. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 78 - drivers/event/octeontx2/otx2_tim_evdev.h | 84

Re: [dpdk-dev] [EXT] Re: [PATCH 4/4] event/octeontx2: timer always use virtual counter

2021-03-21 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Jerin Jacob >Sent: Saturday, March 20, 2021 7:04 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; dpdk-dev > >Subject: [EXT] Re: [dpdk-dev] [PATCH 4/4] event/octeontx2: timer >always use virtual counter > >External Email > >