Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-03-24 Thread Matan Azrad
Hi Cristian Thank you for your important review! I agree with all your comments except one, please see inline. From: Dumitrescu, Cristian > Hi Li and Matan, > > Thank you for your proposal, some comments below. > > I am also adding Jerin and Hemant to this thread, as they also participated in >

[dpdk-dev] [Bug 666] [dpdk-21.05] unit_test_eal/test_kvargs: dpdk-20.11.0 use dpdk-21.05 lib to run kvargs_autotest failed.

2021-03-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=666 Bug ID: 666 Summary: [dpdk-21.05] unit_test_eal/test_kvargs: dpdk-20.11.0 use dpdk-21.05 lib to run kvargs_autotest failed. Product: DPDK Version: unspecified Hardware: All

Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-24 Thread Andrew Rybchenko
On 3/24/21 11:00 PM, Thomas Monjalon wrote: > 24/03/2021 19:08, Ferruh Yigit: >> On 3/21/2021 9:00 AM, Thomas Monjalon wrote: >>> The header file rte_eth_ctrl.h should not be needed because >>> this legacy filtering API is completely replaced with the rte_flow API. >>> However some definitions from

[dpdk-dev] [PATCH v3 7/7] doc: add txgbe backplane update in release notes

2021-03-24 Thread Jiawen Wu
Declare updates related to device args for backplane NICs. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_21_05.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 8e686cc62..732d9743c 100644 --

[dpdk-dev] [PATCH v3 6/7] net/txgbe: add FFE parameters for user debugging

2021-03-24 Thread Jiawen Wu
Support to set PHY link mode by user defined. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst | 21 +++ drivers/net/txgbe/base/txgbe_hw.c | 11 drivers/net/txgbe/base/txgbe_phy.c | 98 - drivers/net/txgbe/base/txgbe_phy.h | 10 +++ driver

[dpdk-dev] [PATCH v3 4/7] net/txgbe/base: support to handle backplane AN73 flow

2021-03-24 Thread Jiawen Wu
Suppot to handle the interrupt of auto-negotiation, improve the link training process of connecting with other switches. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 3 + drivers/net/txgbe/base/txgbe_phy.c | 461 +++- drivers/net/txgbe/base/txgbe_

[dpdk-dev] [PATCH v3 5/7] net/txgbe: handle AN interrupt and link update

2021-03-24 Thread Jiawen Wu
Read AN interrupt from misc, and do the AN configuration action. When link status is down, PHY power should be restarted to config KR mode again. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_hw.c | 4 +- drivers/net/txgbe/base/txgbe_phy.c | 14 +++ drivers/net/txgbe/base/txg

[dpdk-dev] [PATCH v3 2/7] net/txgbe: move firmware version get function to base code

2021-03-24 Thread Jiawen Wu
Move firmware version get function to base code, and store firmware version in PHY info. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_dummy.h | 6 ++ drivers/net/txgbe/base/txgbe_hw.c| 4 drivers/net/txgbe/base/txgbe_phy.c | 12 drivers/net/txgbe/base/t

[dpdk-dev] [PATCH v3 3/7] net/txgbe: update link setup process of backplane NICs

2021-03-24 Thread Jiawen Wu
Add device arguments to support runtime options. And use these configuration to control the link setup flow, to adapt to different NIC's construction. Use firmware version to control the impact of firmware update. And fix some left bugs. Signed-off-by: Jiawen Wu --- doc/guides/nics/txgbe.rst

[dpdk-dev] [PATCH v3 1/7] net/txgbe: update device ID

2021-03-24 Thread Jiawen Wu
For more different devices, update device ID and subsystem id. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_devids.h | 44 ++--- drivers/net/txgbe/base/txgbe_hw.c | 55 --- drivers/net/txgbe/base/txgbe_phy.c| 40 +++ dr

[dpdk-dev] [PATCH v3 0/7] txgbe backplane AN training

2021-03-24 Thread Jiawen Wu
This series update link process for backplane NICs. And support to control AN training. v3: - Add devargs gradually in the patches they are used. - Update 21.05 relaese notes. v2: - Convert compile time flags to runtime options - Move firmware version get operation to base code - Fix minor bugs J

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2021-03-24 Thread Rong, Leyi
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 25, 2021 1:23 AM > To: Jerin Jacob ; David Marchand > ; Rong, Leyi > Cc: dev@dpdk.org; Zhang, Qi Z ; Richardson, Bruce > ; Ananyev, Konstantin > > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx que

[dpdk-dev] [PATCH v2 4/4] regex/mlx5: prevent wrong calculation of free sqs in umr mode

2021-03-24 Thread Suanming Mou
From: John Hurley A recent change adds support for scattered mbuf and UMR support for regex. Part of this commit makes the pi and ci counters of the regex_sq a quarter of the length in non umr mode, effectively moving them from 16 bits to 14. The new get_free method casts the difference in pi and

[dpdk-dev] [PATCH v2 2/4] regex/mlx5: add data path scattered mbuf process

2021-03-24 Thread Suanming Mou
UMR WQE can convert multiple mkey's memory sapce to contiguous space. Take advantage of the UMR WQE, scattered mbuf in one operation can be converted to an indirect mkey. The RegEx which only accepts one mkey can now process the whole scattered mbuf. The maximum scattered mbuf can be supported in

[dpdk-dev] [PATCH v2 3/4] app/test-regex: support scattered mbuf input

2021-03-24 Thread Suanming Mou
This commits adds the scattered mbuf input support. Signed-off-by: Suanming Mou --- app/test-regex/main.c | 134 ++ 1 file changed, 109 insertions(+), 25 deletions(-) diff --git a/app/test-regex/main.c b/app/test-regex/main.c index aea4fa6b88..82cffaacfa

[dpdk-dev] [PATCH v2 1/4] common/mlx5: add user memory registration bits

2021-03-24 Thread Suanming Mou
This commit adds the UMR capability bits. Signed-off-by: Suanming Mou --- drivers/common/mlx5/linux/meson.build | 2 ++ drivers/common/mlx5/mlx5_devx_cmds.c | 5 + drivers/common/mlx5/mlx5_devx_cmds.h | 3 +++ 3 files changed, 10 insertions(+) diff --git a/drivers/common/mlx5/linux/meson.

[dpdk-dev] [PATCH v2 0/4] regex/mlx5: support scattered mbuf

2021-03-24 Thread Suanming Mou
The scattered mbuf was not supported in mlx5 RegEx driver. This patch set adds the support of scattered mbuf by UMR WQE. UMR WQE can convert multiple mkey's memory sapce to contiguous space. Take advantage of the UMR WQE, scattered mbuf in one operation can be converted to an indirect mkey. The Re

[dpdk-dev] [PATCH v3 09/10] eal: add EAL argument for setting thread priority

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH v3 06/10] eal: add thread lifetime management

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for thread creation, join, canceling. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 110 lib/librte_eal/include/rte_thread.h | 53 lib/librte_eal/windows/rte_thread.c | 125 ++

[dpdk-dev] [PATCH v3 05/10] eal: implement thread priority management functions

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 25 ++ lib/librte_eal/include/rte_thread.h | 17 +++ lib/librte_eal/windows/rte_thread.c | 76 + 3 files chan

[dpdk-dev] [PATCH v3 07/10] eal: implement functions for mutex management

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 24 lib/librte_eal/include/rte_thread.h | 55 +++ lib/librte_eal/include/rte_thread_types.h | 3 +

[dpdk-dev] [PATCH v3 08/10] eal: implement functions for thread barrier management

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 16 +++ lib/librte_eal/include/rte_thread.h | 46 +++ lib/librte_eal/include/rte_thread_types.h | 2 + .../in

[dpdk-dev] [PATCH v3 02/10] eal: add thread attributes

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 53 lib/librte_eal/include/rte_thread.h | 82 +

[dpdk-dev] [PATCH v3 04/10] eal: implement functions for thread affinity management

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/rte_thread.c | 13 ++ lib/librte_eal/include/rte_thread.h | 41 +++ lib/librte_eal/windows/eal_lcore.c | 170 ++

[dpdk-dev] [PATCH v3 00/10] eal: Add new API for threading

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[dpdk-dev] [PATCH v3 01/10] eal: add thread id and simple thread functions

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add the thread identifier type. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 101 ++ lib/librte_eal/include/rte_thread.h

[dpdk-dev] [PATCH v3 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-24 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/windows/rte_thread.c | 59 - 1 file changed, 50 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal/windows/rte_thr

Re: [dpdk-dev] [PATCH] vhost: fix potential buffer overflow

2021-03-24 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, March 24, 2021 4:56 PM > To: Liu, Yong ; Xia, Chenbo > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] vhost: fix potential buffer overflow > > Hi Marvin, > > On 2/26/21 8:33 AM, Marvin Liu wrote: > > In vhost da

[dpdk-dev] [PATCH v2] net/ice: support VXLAN VNI field in FDIR

2021-03-24 Thread Zhirun Yan
Add support for VNI field in FDIR. Treat VXLAN flow type as ICE_FLTR_PTYPE_NONF_IPV4_UDP_VXLAN to align with shared code. It allows to match outer L2/L3, VNI and inner L2/L3 fields with VXLAN pattern. VNI takes 24 bits in VXLAN header, but uses 32 bits for matching in shared code. The 8 bits reserv

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx

2021-03-24 Thread oulijun
在 2021/3/24 9:44, Li, Xiaoyun 写道: -Original Message- From: oulijun Sent: Wednesday, March 24, 2021 09:01 To: Li, Xiaoyun ; Yigit, Ferruh Cc: dev@dpdk.org; linux...@openeuler.org Subject: Re: [PATCH 2/3] app/testpmd: remove forwarding config from parsing Rx and Tx 在 2021/3/23 15

[dpdk-dev] [PATCH 3/3] vhost: fix potential buffer overflow when batch dequeue

2021-03-24 Thread Marvin Liu
Similar as single dequeue, the multiple accesses of descriptor length will lead to potential risk. One-time access of descriptor length can eliminate this risk. Fixes: 75ed51697820 ("vhost: add packed ring batch dequeue") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH 1/3] vhost: fix split ring potential buffer overflow

2021-03-24 Thread Marvin Liu
In vhost datapath, descriptor's length are mostly used in two coherent operations. First step is used for address translation, second step is used for memory transaction from guest to host. But the iterval between two steps will give a window for malicious guest, in which can change descriptor leng

[dpdk-dev] [PATCH 2/3] vhost: fix packed ring potential buffer overflow

2021-03-24 Thread Marvin Liu
Similar as split ring, the multiple accesses of descriptor length will lead to potential risk. One-time access of descriptor length can eliminate this risk. Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.org Signed-off-by: Marvin Liu Reviewed-by: Maxime

Re: [dpdk-dev] [PATCH] net/igc: fix Rx RSS hash offload capabilities

2021-03-24 Thread Wang, Haiyue
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, March 25, 2021 09:52 > To: Guo, Jia ; Wang, Haiyue > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH] net/igc: fix Rx RSS hash offload capabilities > > Add DEV_RX_OFFLOAD_RSS_HASH flag to the PMD's Rx offloa

Re: [dpdk-dev] [PATCH] vdpa/ifc: check return value for PCI config read

2021-03-24 Thread Xia, Chenbo
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, March 9, 2021 4:43 PM > To: Xia, Chenbo > Cc: dev@dpdk.org; Wang, Xiao W ; sta...@dpdk.org > Subject: [PATCH] vdpa/ifc: check return value for PCI config read > > The return value of rte_pci_read_config should be checked. > > Co

Re: [dpdk-dev] [PATCH v4 3/3] vhost: optimize vhost virtqueue struct

2021-03-24 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, March 23, 2021 5:02 PM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; > david.march...@redhat.com; olivier.m...@6wind.com; bnem...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v4 3/3] vhost: optimize vhost virtque

Re: [dpdk-dev] [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding configuration when DCB test

2021-03-24 Thread Li, Xiaoyun
> -Original Message- > From: oulijun > Sent: Wednesday, March 24, 2021 21:40 > To: linux...@openeuler.org; Li, Xiaoyun ; dev > > Subject: Re: [Linuxarm] Re: [PATCH 1/3] app/testpmd: fix forwarding > configuration when DCB test > > > > 在 2021/3/24 10:03, Li, Xiaoyun 写道: > > > > > >> -

Re: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector

2021-03-24 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Kathleen Capella > Sent: Thursday, March 11, 2021 3:51 AM > To: Feifei Wang ; jer...@marvell.com; Ruifeng > Wang ; Xing, Beilei ; Guo, > Jia ; Richardson, Bruce ; > Jianbo Liu > Cc: dev@dpdk.org; nd ; Feifei Wang > ; sta...@dpdk.org > Subje

[dpdk-dev] [PATCH] net/igc: fix Rx RSS hash offload capabilities

2021-03-24 Thread Alvin Zhang
Add DEV_RX_OFFLOAD_RSS_HASH flag to the PMD's Rx offload capabilities for it supports RSS hash delivery. Fixes: 4f09bc55ac3d ("net/igc: implement device base operations") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/igc/igc_ethdev.c | 3 +++ drivers/net/igc/igc_ethdev.h | 3 ++

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Tyler Retzlaff
On Thu, Mar 25, 2021 at 01:41:47AM +0300, Dmitry Kozlyuk wrote: > 2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > > Can't speak for Seastar and Click, but we never hit this particular issue. > What is the minimal complete example to reproduce? interesting, i did a bit more digging and it is clear

Re: [dpdk-dev] [dpdk-stable] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

2021-03-24 Thread Wang, Yipeng1
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 24, 2021 2:33 PM > To: Wang, Yipeng1 ; Honnappa Nagarahalli > ; Lilijun (Jerry) > Cc: 'dev@dpdk.org' ; sta...@dpdk.org; wangyunjian > ; xudingke > Subject: Re: [dpdk-stable] 答复: [dpdk-dev] [PATCH] lib/librte_hash: add

[dpdk-dev] [Bug 665] i40e MBUF_FAST_FREE wrong check

2021-03-24 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=665 Bug ID: 665 Summary: i40e MBUF_FAST_FREE wrong check Product: DPDK Version: 20.05 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: No

Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-03-24 Thread Wang, Yipeng1
> -Original Message- > From: dev On Behalf Of kumar amber > Sent: Monday, January 11, 2021 11:25 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture > > add _SSE42_ flag to enable compilation of > sse42 specific inst

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Dmitry Kozlyuk
2021-03-24 14:55 (UTC-0700), Tyler Retzlaff: > On Wed, Mar 24, 2021 at 06:52:40PM +0100, Thomas Monjalon wrote: > > 24/03/2021 18:28, Tyler Retzlaff: [...] > > > would you prefer that i change the preprocessor protection to include only > > > windows? since i'm certain that this will break for an

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-24 Thread Ilya Maximets
On 3/24/21 10:51 PM, Maxime Coquelin wrote: > > > On 3/24/21 10:39 PM, Ilya Maximets wrote: >> On 3/24/21 9:56 PM, Maxime Coquelin wrote: >>> Hi Ilya, >>> >>> On 3/19/21 5:45 PM, Ilya Maximets wrote: On 3/19/21 5:11 PM, Ilya Maximets wrote: > On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: >>

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Tyler Retzlaff
On Wed, Mar 24, 2021 at 12:52:28PM -0700, Stephen Hemminger wrote: > On Wed, 24 Mar 2021 18:52:40 +0100 > Thomas Monjalon wrote: > > There should be some test for C++ application use of API. > There doesn't appear to be one in the current CI suite. agreed, would probably catch a few things. prob

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Tyler Retzlaff
On Wed, Mar 24, 2021 at 06:52:40PM +0100, Thomas Monjalon wrote: > 24/03/2021 18:28, Tyler Retzlaff: > > > > so to qualify. you mean maybe it is breaking compilation of c++ in a > > compiler that explicitly violates c++ standard when compiling c++? that > > would mean it is not a c++ compiler. >

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-24 Thread Maxime Coquelin
On 3/24/21 10:39 PM, Ilya Maximets wrote: > On 3/24/21 9:56 PM, Maxime Coquelin wrote: >> Hi Ilya, >> >> On 3/19/21 5:45 PM, Ilya Maximets wrote: >>> On 3/19/21 5:11 PM, Ilya Maximets wrote: On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: > Hi Ilya, > By the way, it's not clear to me why

Re: [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.

2021-03-24 Thread Thomas Monjalon
Closing this proposal. For reference, an implementation with test has been merged 2 years ago: https://inbox.dpdk.org/dev/1542130061-3702-1-git-send-email-konstantin.anan...@intel.com/ 12/07/2018 15:55, Thomas Monjalon: > Hi, > > Unfortunately, after 2 months, nobody reviewed this patch. > > Y

Re: [dpdk-dev] [dpdk-stable] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2021-03-24 Thread Thomas Monjalon
No reply after more than 2 years. Unfortunately it is probably outdated now. Classified as "Changes Requested". 17/07/2018 05:34, Jerin Jacob: > From: Takeshi Yoshimura > > Cc: olivier.m...@6wind.com > Cc: chao...@linux.vnet.ibm.com > Cc: konstantin.anan...@intel.com > > > > > > Adding rte_sm

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2021-03-24 Thread Thomas Monjalon
Hi, Same question as last year. I guess we can consider this work abandoned? 21/02/2020 14:33, Vivian Kong: > Sorry for the delayed reply. > > We are working on updating the port to a newer version. We'd like to ask > for feedback when it's ready. > > Regards, > > Vivian Kong > Linux on IBM

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-24 Thread Ilya Maximets
On 3/24/21 9:56 PM, Maxime Coquelin wrote: > Hi Ilya, > > On 3/19/21 5:45 PM, Ilya Maximets wrote: >> On 3/19/21 5:11 PM, Ilya Maximets wrote: >>> On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: Hi Ilya, By the way, it's not clear to me why dpdkvhostuser is deprecated. If OVS is restarte

Re: [dpdk-dev] [dpdk-stable] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

2021-03-24 Thread Thomas Monjalon
Sorry for not following the full thread. What is the conclusion please? 13/05/2020 03:28, Lilijun (Jerry): > > > -邮件原件- > > 发件人: Wang, Yipeng1 [mailto:yipeng1.w...@intel.com] > > 发送时间: 2020年5月13日 7:41 > > 收件人: Lilijun (Jerry) ; Honnappa Nagarahalli > > ; 'dev@dpdk.org' > > 抄送: wangyunjia

Re: [dpdk-dev] [PATCH v3 0/8] eal: cleanup resources on shutdown

2021-03-24 Thread Thomas Monjalon
Ping 20/10/2020 00:24, Thomas Monjalon: > That's a pity this patchset is not concluded. > Please Stephen, could you respin with a fix? > > > 03/05/2020 19:21, David Marchand: > > On Wed, Apr 29, 2020 at 1:58 AM Stephen Hemminger > > wrote: > > > > > > Started using valgrind with DPDK, and there

Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option

2021-03-24 Thread Thomas Monjalon
24/05/2020 17:27, Thomas Monjalon: > 01/05/2020 22:43, Ananyev, Konstantin: > > > > > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > > > Fixes: 4c38e5532a07 ("ip_frag: refact

Re: [dpdk-dev] [PATCH v4 0/4] add new kv hash table

2021-03-24 Thread Thomas Monjalon
08/05/2020 21:58, Vladimir Medvedkin: > Currently DPDK has a special implementation of a hash table for > 4 byte keys which is called FBK hash. Unfortunately its main drawback > is that it only supports 2 byte values. > The new implementation called KV hash > supports 4 byte keys and 8 byte associa

Re: [dpdk-dev] [PATCH RFC] raw: add dpaa qdma driver

2021-03-24 Thread Thomas Monjalon
25/09/2020 08:10, Hemant Agrawal: > Hi Gagan, > > On 9/7/2020 3:20 PM, Gagandeep Singh wrote: > > This patch adds support for dpaa qdma based driver. > > > Can you provide more details and break it into logical parts? Is it abandoned?

Re: [dpdk-dev] [PATCH v1 0/8] gro: support TCP/IPv6 and UDP/IPv6 for VLAN and VXLAN

2021-03-24 Thread Thomas Monjalon
21/12/2020 04:50, yang_y...@163.com: > Yi Yang (8): > gro: support TCP/IPv6 > gro: support IPv4 VXLAN TCP/IPv6 > gro: support IPv6 VXLAN TCP/IPv4 > gro: support IPv6 VXLAN TCP/IPv6 > gro: support UDP/IPv6 > gro: support IPv4 VXLAN UDP/IPv6 > gro: support IPv6 VXLAN UDP/IPv4 > gro: s

Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

2021-03-24 Thread Thomas Monjalon
There was no review of this patch in last 2 months. +Cc Yipeng and Sameh 12/01/2021 08:24, kumar amber: > add _SSE42_ flag to enable compilation of > sse42 specific instructions only on supported > architecture > > Signed-off-by: kumar amber > --- > lib/librte_hash/rte_hash_crc.h | 16

Re: [dpdk-dev] [PATCH 0/3] regex/mlx5: support scattered mbuf

2021-03-24 Thread Thomas Monjalon
> Suanming Mou (3): > common/mlx5: add user memory registration bits > regex/mlx5: add data path scattered mbuf process > app/test-regex: support scattered mbuf input Ori, could you review please?

Re: [dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup

2021-03-24 Thread Thomas Monjalon
10/03/2021 18:24, Bruce Richardson: > This set adds support for using the regular rte_log functions from the > telemetry > library; avoiding circular dependencies by having EAL register the telemetry > library itself and then passing the required handles to that library as part > of > the telemet

Re: [dpdk-dev] [PATCH v1] lib/power: add check for sysfs base frequency

2021-03-24 Thread Thomas Monjalon
16/03/2021 10:38, David Hunt: > Some kernels may show in incorrect value for base frequency in > sysfs (e.g. 15 GHz). This throws off the SST-BF algorithm for > high and low priority cores. So if base_frequency is greater > than max turbo frequency, ignore, and handle it as a normal > core. > > Kn

Re: [dpdk-dev] [RFC 0/4] SocketPair Broker support for vhost and virtio-user.

2021-03-24 Thread Maxime Coquelin
Hi Ilya, On 3/19/21 5:45 PM, Ilya Maximets wrote: > On 3/19/21 5:11 PM, Ilya Maximets wrote: >> On 3/19/21 3:39 PM, Stefan Hajnoczi wrote: >>> Hi Ilya, >>> By the way, it's not clear to me why dpdkvhostuser is deprecated. If OVS >>> is restarted then existing vhost-user connections drop with an er

Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option

2021-03-24 Thread David Marchand
On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit wrote: > > On 3/23/2021 11:07 AM, Qi Zhang wrote: > > 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. > > 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. > > 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX > > > > Sig

Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-24 Thread Thomas Monjalon
24/03/2021 19:08, Ferruh Yigit: > On 3/21/2021 9:00 AM, Thomas Monjalon wrote: > > The header file rte_eth_ctrl.h should not be needed because > > this legacy filtering API is completely replaced with the rte_flow API. > > However some definitions from this file are still used by some drivers, > >

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Stephen Hemminger
On Wed, 24 Mar 2021 18:52:40 +0100 Thomas Monjalon wrote: > 24/03/2021 18:28, Tyler Retzlaff: > > On Wed, Mar 24, 2021 at 06:04:08PM +0100, Thomas Monjalon wrote: > > > 24/03/2021 17:45, Tyler Retzlaff: > > > > > > I understood this part. > > > > > > My question is more about the reason for h

[dpdk-dev] [PATCH v2] mem: fix cleanup when multi-process is disabled

2021-03-24 Thread Dmitry Kozlyuk
rte_eal_memory_detach() did not account for cases where multi-process mode is disabled: --in-memory and --no-shconf. This resulted in unmapping memory that had not been mapped, which caused errors: EAL: Could not unmap memory: No error (Windows) EAL: Cannot munmap(0x1d47f40, 0x7000): Inv

Re: [dpdk-dev] [PATCH 01/25] event/dlb2: add dlb v2.5 probe

2021-03-24 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, March 21, 2021 4:48 AM > To: McDaniel, Timothy > Cc: dpdk-dev ; Jerin Jacob ; Van Haaren, > Harry ; Ray Kinsella ; Neil > Horman ; Rao, Nikhil ; > Carrillo, Erik G ; Gujjar, Abhinandan S > ; Pavan Nikhilesh > ; Hemant Agrawal ; >

[dpdk-dev] [PATCH v6 6/8] app/eventdev: add event vector mode in pipeline test

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support in pipeline tests. By default this mode is disabled, it can be enabled by using the option --enable_vector. example: dpdk-test-eventdev -l 7-23 -s 0xff00 -- --prod_type_ethdev --nb_pkts=0 --verbose 2 --test=pipeline_atq --stlist=a

[dpdk-dev] [dpdk-dev v21.11] [PATCH v6 8/8] eventdev: simplify Rx adapter event vector config

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Include vector configuration into the structure ``rte_event_eth_rx_adapter_queue_conf`` used when configuring rest of the Rx adapter ethernet device Rx queue parameters. This simplifies event vector configuration as it avoids splitting configuration per Rx queue. Signed-off

[dpdk-dev] [PATCH v6 7/8] doc: announce event Rx adapter config changes

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh The Rx adapter event vector configuration will be merged into Rx adapter queue configuration to simplify enabling event vectorization. Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella --- doc/guides/rel_notes/deprecation.rst | 9 + 1 file changed, 9 insertio

[dpdk-dev] [PATCH v6 5/8] eventdev: add Tx adapter event vector support

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Tx adapter, the implementation receives events from the single linked queue and based on rte_event_vector::union_valid transmits the vector of mbufs to a given port, queue pair. Signed-off-by: Pavan Nikhilesh --- .../rte_event_eth_tx

[dpdk-dev] [PATCH v6 4/8] eventdev: add Rx adapter event vector support

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Add event vector support for event eth Rx adapter, the implementation creates vector flows based on port and queue identifier of the received mbufs. Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/eventdev_pmd.h| 7 +- .../rte_event_eth_rx_adapter.c

[dpdk-dev] [PATCH v6 3/8] eventdev: introduce event vector Tx capability

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event vector transmit capability for event eth tx adapter. The capability indicates that the Tx adapter is capable of transmitting event vectors. When rte_event_vector::union_valid is set, the Tx adapter should transmit all the packets to the rte_event_vector::por

[dpdk-dev] [PATCH v6 2/8] eventdev: introduce event vector Rx capability

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Introduce event ethernet Rx adapter event vector capability. If an event eth Rx adapter has the capability of RTE_EVENT_ETH_RX_ADAPTER_CAP_EVENT_VECTOR then a given Rx queue can be configured to enable event vectorization by passing the flag RTE_EVENT_ETH_RX_ADAPTER_QUEUE_E

[dpdk-dev] [PATCH v6 1/8] eventdev: introduce event vector capability

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh Introduce rte_event_vector datastructure which is capable of holding multiple uintptr_t of the same flow thereby allowing applications to vectorize their pipeline and reducing the complexity of pipelining the events across multiple stages. This approach also reduces the sche

[dpdk-dev] [PATCH v6 0/8] Introduce event vectorization

2021-03-24 Thread pbhagavatula
From: Pavan Nikhilesh In traditional event programming model, events are identified by a flow-id and a uintptr_t. The flow-id uniquely identifies a given event and determines the order of scheduling based on schedule type, the uintptr_t holds a single object. Event devices also support burst mod

Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option

2021-03-24 Thread Ferruh Yigit
On 3/23/2021 11:07 AM, Qi Zhang wrote: 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX Signed-off-by: Qi Zhang CI is reporting a build error [1], I don't reprodu

Re: [dpdk-dev] [PATCH] mem: fix cleanup on Windows

2021-03-24 Thread David Marchand
On Wed, Mar 24, 2021 at 7:01 PM Dmitry Kozlyuk wrote: > > rte_mem_unmap() called from rte_eal_memory_detach() fails on Windows > with message "EAL: Could not unmap memory: No error". This is because > on Windows memory is not allocated using mapping. Confusing "No error" > is caused by using errno

Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows

2021-03-24 Thread Yong Wang
-Original Message- From: Dmitry Kozlyuk Date: Wednesday, March 24, 2021 at 10:50 AM To: Yong Wang Cc: Ferruh Yigit , "dev@dpdk.org" , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows 2021-03-23 17:13 (UTC+)

Re: [dpdk-dev] [PATCH v5 1/8] eventdev: introduce event vector capability

2021-03-24 Thread Pavan Nikhilesh Bhagavatula
>> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Wednesday, March 24, 2021 10:35 AM >> To: jer...@marvell.com; Jayatheerthan, Jay >; Carrillo, Erik G >; Gujjar, >> Abhinandan S ; McDaniel, Timothy >; hemant.agra...@nxp.com; Van >> Haaren, Harry ; mattias.ronnblom >; Ma, Lia

Re: [dpdk-dev] [PATCH v5 2/2] pipeline: add meter support to the SWX pipeline

2021-03-24 Thread Thomas Monjalon
16/03/2021 12:40, Cristian Dumitrescu: > Meter arrays are stateful objects that are updated by the data plane > and configured & monitored by the control plane. The meters implement > the RFC 2698 Two Rate Three Color Marker (trTCM) algorithm. > > Signed-off-by: Cristian Dumitrescu Series applie

Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering

2021-03-24 Thread Ferruh Yigit
On 3/21/2021 9:00 AM, Thomas Monjalon wrote: The header file rte_eth_ctrl.h should not be needed because this legacy filtering API is completely replaced with the rte_flow API. However some definitions from this file are still used by some drivers, but such usage is already covered by an implicit

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: replace callback getting filter operations

2021-03-24 Thread Ferruh Yigit
On 3/21/2021 9:00 AM, Thomas Monjalon wrote: Since rte_flow is the only API for filtering operations, the legacy driver interface filter_ctrl was too much complicated for the simple task of getting the struct rte_flow_ops. The filter type RTE_ETH_FILTER_GENERIC and the filter operarion RTE_ETH_F

[dpdk-dev] [PATCH] mem: fix cleanup on Windows

2021-03-24 Thread Dmitry Kozlyuk
rte_mem_unmap() called from rte_eal_memory_detach() fails on Windows with message "EAL: Could not unmap memory: No error". This is because on Windows memory is not allocated using mapping. Confusing "No error" is caused by using errno instead of rte_errno set by rte_mem_unmap(). Multi-process is n

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Thomas Monjalon
24/03/2021 18:28, Tyler Retzlaff: > On Wed, Mar 24, 2021 at 06:04:08PM +0100, Thomas Monjalon wrote: > > 24/03/2021 17:45, Tyler Retzlaff: > > > > I understood this part. > > > > My question is more about the reason for having this define. > > I think it is there because some compilers don't have

Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows

2021-03-24 Thread Dmitry Kozlyuk
2021-03-23 17:13 (UTC+), Yong Wang: > -Original Message- > From: Ferruh Yigit > Date: Tuesday, March 23, 2021 at 9:11 AM > To: Dmitry Kozlyuk , "dev@dpdk.org" , > Yong Wang > Cc: Narcisa Ana Maria Vasile , Dmitry Malloy > , Pallavi Kadam > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet

Re: [dpdk-dev] [PATCH v2] pipeline: fix instruction translation for table and mailbox fields

2021-03-24 Thread Thomas Monjalon
24/03/2021 12:36, Cristian Dumitrescu: > The SWX pipeline instructions work with operands of different types: > header fields (h.header.field), packet meta-data (m.field), extern > object mailbox field (e.obj.field), extern function (f.field), action > data read from table entries (t.field), or imm

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Tyler Retzlaff
On Wed, Mar 24, 2021 at 06:04:08PM +0100, Thomas Monjalon wrote: > 24/03/2021 17:45, Tyler Retzlaff: > > I understood this part. > > My question is more about the reason for having this define. > I think it is there because some compilers don't have asm keyword, > but have __asm__. And maybe that

Re: [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args

2021-03-24 Thread Thomas Monjalon
24/03/2021 13:22, Churchill Khangar: > This patch allows specification of integer arguments for the > CLI commands in hexadecimal and octal as well as decimal. > > Signed-off-by: Churchill Khangar > Acked-by: Cristian Dumitrescu Applied, thanks.

Re: [dpdk-dev] [PATCH] examples/l3fwd: enable multiple Tx queues on a lcore

2021-03-24 Thread Thomas Monjalon
05/11/2020 10:24, Rong, Leyi: > From: Jerin Jacob > > On Wed, Nov 4, 2020 at 2:34 PM Rong, Leyi wrote: > > > From: David Marchand > > > > On Wed, Nov 4, 2020 at 9:34 AM Rong, Leyi wrote: > > > > > As there always has thoughput limit for per queue, on some > > > > > performance test case by usin

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix TX burst queue drain edge case

2021-03-24 Thread Thomas Monjalon
23/02/2021 19:23, Kathleen Capella: > Initialize prev_tsc to cur_tsc. This avoids running the TX queue drain > in the first iteration of the packet processing loop. Is it really a fix? What was broken? Isn't it an optimization? > Fixes: af75078fece3 ("first public release") If it's really a fix,

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Thomas Monjalon
24/03/2021 17:45, Tyler Retzlaff: > On Wed, Mar 24, 2021 at 09:30:58AM +0100, Thomas Monjalon wrote: > > 24/03/2021 05:26, Tyler Retzlaff: > > > +#ifndef __cplusplus > > > #ifndef asm > > > #define asm __asm__ > > > #endif > > > +#endif > > > > It requires more explanations. > > Which compilers

Re: [dpdk-dev] [PATCH v4 00/11] improve options help

2021-03-24 Thread Thomas Monjalon
24/03/2021 16:03, David Marchand: > The changes on usage() and the --log-level help are not related and > could have been separated in two series. Yes, I will split. It will help merging the non-controversial patches. > - The "Usage: " lists [EAL options] first, so I would expect them to > be li

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-03-24 Thread Tyler Retzlaff
On Wed, Mar 24, 2021 at 09:30:58AM +0100, Thomas Monjalon wrote: > 24/03/2021 05:26, Tyler Retzlaff: > > +#ifndef __cplusplus > > #ifndef asm > > #define asm __asm__ > > #endif > > +#endif > > It requires more explanations. > Which compilers do not define asm? > What happens with C++ if asm is

Re: [dpdk-dev] [PATCH v2] ethdev: introduce enable_driver_sdk to install driver headers

2021-03-24 Thread Tyler Retzlaff
On Wed, Mar 24, 2021 at 12:30:36PM +0100, Thomas Monjalon wrote: > 24/03/2021 12:27, Ferruh Yigit: > > > > But not sure how to manage the same problem for whole project, if install > > all > > headers in one patch, or add them gradually via separate patches by time ... > > We did a cleanup in e

Re: [dpdk-dev] [PATCH] net/mlx5: add Rx checksum offload flag return bad

2021-03-24 Thread Jiawei Zhu
Hi,Slava Thanks for your explain,the multiplications and divisions are in the TRANSPOSE,not in the rte_be_to_cpu_16. So I think use if-else directly could improves the performance. And the second point about the bad sum,I agree with you. With best regards, Jiawei On 2021/3/24 12:33 上午, Slav

Re: [dpdk-dev] [PATCH 1/2] eal: make max interrupt vector id configurable

2021-03-24 Thread Jerin Jacob
On Wed, Mar 24, 2021 at 8:56 PM David Marchand wrote: > > On Wed, Mar 24, 2021 at 1:55 PM Jerin Jacob wrote: > > > > IMO, We dont need to make it configurable and each platform sets its > > > > value. That scheme won't work as generic distribution build will fail > > > > to run. > > > > Since PCI

[dpdk-dev] [PATCH v2 2/2] test/crypto: support block cipher DIGEST_ENCRYPTED mode

2021-03-24 Thread Tejasree Kondoj
Adding support for block cipher DIGEST_ENCRYPTED mode. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev_aes_test_vectors.h | 573 + app/test/test_cryptodev_blockcipher.c | 99 +++- app/test/test_cryptodev_blockcipher.h | 10 + 3 files changed, 670 insert

[dpdk-dev] [PATCH v2 1/2] common/cpt: support DIGEST_ENCRYPTED mode

2021-03-24 Thread Tejasree Kondoj
Adding support for DIGEST_ENCRYPTED mode. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/features/octeontx.ini | 1 + doc/guides/cryptodevs/features/octeontx2.ini | 1 + doc/guides/rel_notes/release_21_05.rst| 8 drivers/common/cpt/cpt_mcode_defines.h| 7 +++

  1   2   >