[dpdk-dev] [PATCH v6 05/10] eal: implement thread priority management functions

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for setting the priority for a thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 25 ++ lib/librte_eal/include/rte_thread.h | 17 +++ lib/librte_eal/windows/rte_thread.c | 76 + 3 files chan

[dpdk-dev] [PATCH v6 09/10] eal: add EAL argument for setting thread priority

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Allow the user to choose the thread priority through an EAL command line argument. The user can select the thread priority to be either 'normal' or 'critical': --thread-prio normal --thread-prio realtime Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/eal_common_o

[dpdk-dev] [PATCH v6 06/10] eal: add thread lifetime management

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function for thread creation, join, canceling. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c | 110 lib/librte_eal/include/rte_thread.h | 53 lib/librte_eal/windows/rte_thread.c | 125 ++

[dpdk-dev] [PATCH v6 08/10] eal: implement functions for thread barrier management

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 16 +++ lib/librte_eal/include/rte_thread.h | 46 +++ lib/librte_eal/include/rte_thread_types.h | 2 + .../in

[dpdk-dev] [PATCH v6 07/10] eal: implement functions for mutex management

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 24 + lib/librte_eal/include/rte_thread.h | 53 +++ lib/librte_eal/include/rte_thread_types.h | 3 +

[dpdk-dev] [PATCH v6 02/10] eal: add thread attributes

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 53 lib/librte_eal/include/rte_thread.h | 82 +

[dpdk-dev] [PATCH v6 04/10] eal: implement functions for thread affinity management

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/rte_thread.c | 13 ++ lib/librte_eal/include/rte_thread.h | 41 +++ lib/librte_eal/windows/eal_lcore.c | 170 ++

[dpdk-dev] [PATCH v6 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/include/rte_thread.h | 5 +- lib/librte_eal/windows/rte_thread.c | 75 ++--- 2 files changed, 60 insertions(+), 20 deletions(

[dpdk-dev] [PATCH v6 00/10] eal: Add new API for threading

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

[dpdk-dev] [PATCH v6 01/10] eal: add thread id and simple thread functions

2021-04-02 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add the thread identifier type. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/librte_eal/common/rte_thread.c| 101 ++ lib/librte_eal/include/rte_thread.h

[dpdk-dev] [PATCH] pipeline: fix endianness conversions

2021-04-02 Thread Cristian Dumitrescu
The SWX pipeline instructions work with operands of different types: header fields (h.header.field), packet meta-data (m.field), extern object mailbox field (e.obj.field), extern function (f.field), action data read from table entries (t.field), or immediate values; hence the HMEFTI acronym. The H

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-02 Thread Jie Zhou
On Thu, Apr 01, 2021 at 08:44:31AM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows > > > > From: Jie Zhou > > > > This patch is to enable testpmd on windows. It mainly includes: > > - Enable building libraries on Windows that TestPMD depen

Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows

2021-04-02 Thread Jie Zhou
On Wed, Mar 31, 2021 at 12:10:03PM -0700, Kadam, Pallavi wrote: > > On 3/19/2021 9:51 AM, Jie Zhou wrote: > >From: Jie Zhou > > > >This patch is to enable testpmd on windows. It mainly includes: > >- Enable building libraries on Windows that TestPMD depends on > >- Enable building testpmd on Wind

Re: [dpdk-dev] [PATCH v2 2/2] qos: rearrange enqueue procedure

2021-04-02 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, April 2, 2021 3:15 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: RE: [PATCH v2 2/2] qos: rearrange enqueue procedure > > > > > -Original Message- > > From: Ananyev, Konstantin

Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling

2021-04-02 Thread Stephen Hemminger
On Thu, 1 Apr 2021 15:05:17 + Anatoly Burakov wrote: > + /* fgets puts null terminator in, but do this just in case */ > + buf[BUFSIZ - 1] = '\0'; > + > + /* strip off any terminating newlines */ > + if (strlen(buf)) > + strtok(buf, "\n"); Why not the simpler/sho

Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling

2021-04-02 Thread Stephen Hemminger
On Thu, 1 Apr 2021 15:05:17 + Anatoly Burakov wrote: > > +#define FOPEN_OR_ERR_GOTO(f, label) do { \ > + if ((f) == NULL) { \ > + RTE_LOG(ERR, POWER, "File not opened\n"); \ > + goto label; \ > + } \ > +} while (0) > + I am n

[dpdk-dev] [PATCH v4 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-02 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c | 29 +++- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/app/tes

[dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-02 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

[dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-02 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v4 0/3] Enhancements to crypto adapter forward mode

2021-04-02 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application changes are added in third patch. v4: - Fix debug build. v3: - Added crypto adapter test application changes

Re: [dpdk-dev] [PATCH v6 3/5] examples/l3fwd: add FIB infrastructure

2021-04-02 Thread Burakov, Anatoly
On 02-Apr-21 11:52 AM, Conor Walsh wrote: The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. Instead of adding an individual flag for FIB, a new flag '--

Re: [dpdk-dev] [RFC] devtools: improve DPDK review process

2021-04-02 Thread Burakov, Anatoly
On 02-Apr-21 2:43 PM, Jerin Jacob wrote: On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov wrote: A common problem on the DPDK mailing list is lack of reviewers for patches. This script is intended to help with that problem, by picking a random commit author from our git history, and adding a Rev

[dpdk-dev] [PATCH v2 1/4] net/mlx5: support meter policy operations

2021-04-02 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

[dpdk-dev] [PATCH v2 4/4] net/mlx5: connect meter policy to created flows

2021-04-02 Thread Li Zhang
From: Shun Hao Currently ASO meter must be followed by policy table, so this adds the support that connecting meter and policy table. There are several cases to be considered: 1. For non-termination policy, connect meter to the default policy table. 2. For non-RSS termination policy case, simply

[dpdk-dev] [PATCH v2 0/4] net/mlx5: support meter policy operations

2021-04-02 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

[dpdk-dev] [PATCH v2 2/4] net/mlx5: support meter creation with policy

2021-04-02 Thread Li Zhang
Make meter creation with policy to support actions per color. The following cases to be considered: 1.Add entry match with meter_id in global drop table. 2.For non-termination policy (policy id 0), add jump rule to suffix table for green and jump rule to drop table for red. 3.Allocate counter

[dpdk-dev] [PATCH v2 3/4] net/mlx5: prepare sub-policy for a flow with meter

2021-04-02 Thread Li Zhang
When a flow with RSS action, the MLX5 PMD split the flow into several sub flow according to the flow RSS hashfield value, each sub flow requested the different RSS TIR. The new meter introduces the policy, for the meter flow with RSS in the policy action, each RSS TIR in meter policy maintains own

[dpdk-dev] [PATCH v2 11/13] net/mlx5: add support of ASO meter action

2021-04-02 Thread Li Zhang
When ASO action is available, use it as the meter action Signed-off-by: Shun Hao Signed-off-by: Li Zhang --- drivers/net/mlx5/linux/mlx5_os.c | 7 ++- drivers/net/mlx5/mlx5.c| 10 +++ drivers/net/mlx5/mlx5.h| 7 ++- drivers/net/mlx5/mlx5_flow.c | 69 +++

[dpdk-dev] [PATCH v2 13/13] net/mlx5: allow multiple flow tables on the same level

2021-04-02 Thread Li Zhang
The driver devices support creation of multiple flow tables. Jump action can be used in order to move the packet steering to different flow table. Table 0 is always the root table for packet steering. Jumping between tables may cause endless loops in steering mechanism, that's why each table has l

[dpdk-dev] [PATCH v2 12/13] net/mlx5: make ASO meter queue thread-safe

2021-04-02 Thread Li Zhang
Synchronize ASO meter queue accesses from different threads using a spinlock. Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_aso.c | 16 +--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/dri

[dpdk-dev] [PATCH v2 10/13] net/mlx5: aso flow meter send WQE and CQE handle

2021-04-02 Thread Li Zhang
ASO flow meter send WQE and CQE handle functions Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.h| 4 + drivers/net/mlx5/mlx5_flow_aso.c | 185 - drivers/net/mlx5/mlx5_flow_meter.c | 143 +- 3 files changed, 276 insertions(+), 56

[dpdk-dev] [PATCH v2 07/13] common/mlx5: add DevX API to create ASO flow meter object

2021-04-02 Thread Li Zhang
Add DevX API to create ASO flow meter object. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 18 +- drivers/common/mlx5/version.map | 1 + 3 files changed, 72 insertions(+), 1 deletion(-) d

[dpdk-dev] [PATCH v2 02/13] net/mlx5: fix meter statistics

2021-04-02 Thread Li Zhang
From: Shun Hao This fixes the meter statistics issue that when using multiple meters, only one meter has stats value. To match the correct meter in policer table, now the meter_id is also used in its match criteria, so only one color and one drop matcher are needed. And both meter_id and flow_id

[dpdk-dev] [PATCH v2 08/13] net/mlx5: flow meter pool to manage meter object

2021-04-02 Thread Li Zhang
Add ASO flow meter pool to manage meter object Signed-off-by: Li Zhang --- drivers/net/mlx5/mlx5.c| 2 +- drivers/net/mlx5/mlx5.h| 207 - drivers/net/mlx5/mlx5_flow.c | 70 - drivers/net/mlx5/mlx5_flow.h | 196 +++-- drivers/net/mlx5

[dpdk-dev] [PATCH v2 01/13] net/mlx5: support three level table walk

2021-04-02 Thread Li Zhang
From: Suanming Mou This commit adds table entry walk for the three level table. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_utils.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.h b/drivers/net/mlx5/mlx5_utils.h i

[dpdk-dev] [PATCH v2 09/13] net/mlx5: init/uninit flow meter queue for WQE

2021-04-02 Thread Li Zhang
Init/uninit flow meter SQ for WQE Signed-off-by: Li Zhang --- drivers/net/mlx5/linux/mlx5_os.c | 17 drivers/net/mlx5/meson.build | 2 +- drivers/net/mlx5/mlx5.c | 78 ++- drivers/net/mlx5/mlx5.h | 22 +++

[dpdk-dev] [PATCH v2 05/13] common/mlx5: add definitions for ASO flow meter

2021-04-02 Thread Li Zhang
This patch adds different PRM definitions, related to ASO flow meter feature, in MLX5 PMD code. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_prm.h | 75 -- 1 file changed, 71 insertions(+), 4 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/driv

[dpdk-dev] [PATCH v2 00/13] Add ASO meter support in MLX5 PMD

2021-04-02 Thread Li Zhang
To support more meters and better performance, MLX HW provide ASO flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX5 PMD driver will be responsible for ASO

[dpdk-dev] [PATCH v2 04/13] net/mlx5: use mask for meter register setting

2021-04-02 Thread Li Zhang
From: Shun Hao ASO meter feature may require to locate the flow context tag action after the ASO action. When color register is shared by meter_id/flow_id, it's like: Bits[0-7] A meter color value set by the HW. Bits[8-31] A flow id and meter id set by SW. Currently the tag action for meter writ

[dpdk-dev] [PATCH v2 06/13] common/mlx5: add read ASO flow meter HCA capability

2021-04-02 Thread Li Zhang
Read and store the device capability of FLOW_METER_ASO general object, using the DevX API. Signed-off-by: Li Zhang --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 8 2 files changed, 22 insertions(+) diff --git a/drivers/common/mlx5

[dpdk-dev] [PATCH v3 3/3] test/event_crypto: use crypto adapter enqueue API

2021-04-02 Thread Shijith Thotton
Use rte_event_crypto_adapter_enqueue() API to enqueue events to crypto adapter if forward mode is supported in driver. Signed-off-by: Shijith Thotton --- app/test/test_event_crypto_adapter.c | 29 +++- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/app/tes

[dpdk-dev] [PATCH v3 2/3] event/octeontx2: support crypto adapter forward mode

2021-04-02 Thread Shijith Thotton
Advertise crypto adapter forward mode capability and set crypto adapter enqueue function in driver. Signed-off-by: Shijith Thotton --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 42 ++ drivers/event/octeontx2/otx2_evdev.c | 5 +- .../event/octeontx2/otx2_evdev_crypto_adptr

[dpdk-dev] [PATCH v3 1/3] eventdev: introduce crypto adapter enqueue API

2021-04-02 Thread Shijith Thotton
From: Akhil Goyal In case an event from a previous stage is required to be forwarded to a crypto adapter and PMD supports internal event port in crypto adapter, exposed via capability RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD, we do not have a way to check in the API rte_event_enqueue_bur

[dpdk-dev] [PATCH v3 0/3] Enhancements to crypto adapter forward mode

2021-04-02 Thread Shijith Thotton
This series proposes a new event device enqueue operation if crypto adapter forward mode is supported. Second patch in the series is the implementation of the same in PMD. Test application are added in third patch. v3: - Added crypto adapter test application changes. v2: - Updated release notes.

Re: [dpdk-dev] [PATCH 5/6] test/crypto: dynamically build blockcipher suite

2021-04-02 Thread Power, Ciara
Hi Akhil, >-Original Message- >From: Akhil Goyal >Sent: Wednesday 31 March 2021 15:46 >To: Power, Ciara ; dev@dpdk.org >Cc: Doherty, Declan ; hemant.agra...@nxp.com; >Anoob Joseph ; ruifeng.w...@arm.com; >asoma...@amd.com; ajit.khapa...@broadcom.com; g.si...@nxp.com; >acon...@redhat.com

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-04-02 Thread Power, Ciara
Hi Aaron, >-Original Message- >From: Aaron Conole >Sent: Wednesday 31 March 2021 15:43 >To: Doherty, Declan >Cc: Power, Ciara ; dev@dpdk.org >Subject: Re: [PATCH 0/6] test: refactor crypto unit test framework > >"Doherty, Declan" writes: > >> Hey Aaron, >> >> based on the work you've b

Re: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework

2021-04-02 Thread Power, Ciara
>-Original Message- >From: Ruifeng Wang >Sent: Thursday 1 April 2021 04:14 >To: Power, Ciara ; dev@dpdk.org >Cc: Doherty, Declan ; nd >Subject: RE: [dpdk-dev] [PATCH 0/6] test: refactor crypto unit test framework > >> -Original Message- >> From: dev On Behalf Of Ciara Power >>

[dpdk-dev] [PATCH v2 6/6] test/crypto: dynamically build blockcipher suite

2021-04-02 Thread Ciara Power
In the existing implementation, the blockcipher test cases are being run and reported as one test case per type, even though multiple test cases are hidden in each. For example, "test_AES_chain_all" runs 46 test cases. Each blockcipher type should have a testsuite instead. The blockcipher testsuit

[dpdk-dev] [PATCH v2 5/6] test/crypto: fix return value on test skipped

2021-04-02 Thread Ciara Power
The blockcipher testcase return value TEST_SUCCESS was incorrect for one conditional check, it should have been TEST_SKIPPED similar to the other condition checks in this function when the testcase is skipped. Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API") Cc: roy.fan.zh...@in

[dpdk-dev] [PATCH v2 4/6] test/crypto: move testsuite params to header file

2021-04-02 Thread Ciara Power
The testsuite params struct and ut functions are now in the cryptodev test header file. This will allow them be used outside of the cryptodev_test.c file. They will be used in a subsequent patch by the blockcipher test. As a result of this change, slight renaming changes were necessary for ipsec a

[dpdk-dev] [PATCH v2 3/6] test/crypto: refactor to use sub-testsuites

2021-04-02 Thread Ciara Power
The existing implementation runs a giant cryptodev testsuite for most autotests, which in turns runs one setup function regardless of device. This is now broken down into multiple testsuites, that are used as sub-testsuites. Each autotest has a parent test suite for that device, to which the sub-t

[dpdk-dev] [PATCH v2 1/6] app/test: refactor of unit test suite runner

2021-04-02 Thread Ciara Power
Some small changes were made to the unit test suite runner for readability and to enable reuse of some of the function in a later patch. On test suite setup skip/fail, the loop to count testcases as skipped/failed has been moved to another function. This will allow for recursion in a later patch w

[dpdk-dev] [PATCH v2 2/6] test: introduce parent testsuite format

2021-04-02 Thread Ciara Power
The current structure for unit testing only allows for running a test suite with nested test cases. This means all test cases for an autotest must be in one suite, which is not ideal. For example, in some cases we may want to run multiple lists of test cases that each require different setup, so sh

[dpdk-dev] [PATCH v2 0/6] test: refactor crypto unit test framework

2021-04-02 Thread Ciara Power
v2: - Added macro in place of testcase/testsuite loops. - Added more detail in the summary output. - Moved testcase counts to the testsuite structure. - Flattened testsuite structure to remove union. - Added patch for fix of blockcipher test return value. - Squashed release note into la

Re: [dpdk-dev] [PATCH v2 2/2] qos: rearrange enqueue procedure

2021-04-02 Thread Singh, Jasvinder
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 18, 2021 11:56 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; Ananyev, Konstantin > > Subject: [PATCH v2 2/2] qos: rearrange enqueue procedure > > In many usage scenarios input mbufs for

Re: [dpdk-dev] [RFC] devtools: improve DPDK review process

2021-04-02 Thread Jerin Jacob
On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov wrote: > > A common problem on the DPDK mailing list is lack of reviewers for > patches. This script is intended to help with that problem, by picking > a random commit author from our git history, and adding a Reviewed-by: > tag. This can be added to

Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling

2021-04-02 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Burakov, Anatoly > Sent: Friday, April 2, 2021 10:36 AM > To: dev@dpdk.org > Cc: Hunt, David > Subject: Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency > handling > > On 02-Apr-21 10:26 AM, Anatoly Burakov wrote: > > Previous

Re: [dpdk-dev] [PATCH v4 2/2] power: do not skip saving original pstate governor

2021-04-02 Thread Pattan, Reshma
> -Original Message- > From: dev On Behalf Of Burakov, Anatoly > Sent: Friday, April 2, 2021 10:34 AM > To: dev@dpdk.org > Cc: Hunt, David > Subject: Re: [dpdk-dev] [PATCH v4 2/2] power: do not skip saving original > pstate > governor > > On 02-Apr-21 10:26 AM, Anatoly Burakov wrote:

[dpdk-dev] [PATCH v6 5/5] doc/guides/l3_forward: update documentation for FIB

2021-04-02 Thread Conor Walsh
The purpose of this patch is to update the l3fwd user guide to include the changes proposed in this patchset. Signed-off-by: Conor Walsh Acked-by: John McNamara --- doc/guides/sample_app_ug/l3_forward.rst | 113 +--- 1 file changed, 100 insertions(+), 13 deletions(-) diff -

[dpdk-dev] [PATCH v6 4/5] examples/l3fwd: implement FIB lookup method

2021-04-02 Thread Conor Walsh
This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_fib.c | 480 +

[dpdk-dev] [PATCH v6 3/5] examples/l3fwd: add FIB infrastructure

2021-04-02 Thread Conor Walsh
The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user

[dpdk-dev] [PATCH v6 2/5] examples/l3fwd: move l3fwd routes to common header

2021-04-02 Thread Conor Walsh
To prevent code duplication from the addition of lookup methods the routes specified in lpm should be moved to a common header. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_common_route.h | 48 +++ examples/l3fwd/

[dpdk-dev] [PATCH v6 0/5] examples/l3fwd: add FIB lookup method to l3fwd

2021-04-02 Thread Conor Walsh
Currently the l3fwd sample app supports LPM and EM lookup methods this patchset implements the FIB library as another lookup method for l3fwd. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user to select their desired lookup method. The flags '-E

[dpdk-dev] [PATCH v6 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-02 Thread Conor Walsh
The IPv6 subnets used were not within the 2001:200::/48 subnet Changed to 2001:200:0:{0-7}::/64 where 0-7 is the port ID Fixes: 37afe381bde4 ("examples/l3fwd: use reserved IP addresses") Signed-off-by: Conor Walsh Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_lpm.c | 26 +++

[dpdk-dev] [PATCH v3] net/iavf: deprecate i40evf pmd

2021-04-02 Thread Robin Zhang
The i40evf PMD will be deprecated, iavf will be the only VF driver for Intel 700 serial (i40e) NIC family. To reach this, there will be 2 steps: Step 1: iavf will be the default VF driver, while i40evf still can be selected by devarg: "driver=i40evf". This is covered by this patch, which include:

[dpdk-dev] [PATCH v2 1/2] ethdev: add pre-defined meter policy API

2021-04-02 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

[dpdk-dev] [PATCH v2 2/2] app/testpmd: support policy actions per color

2021-04-02 Thread Li Zhang
From: Haifei Luo add the new create meter with policy API to support it. Signed-off-by: Haifei Luo --- app/test-pmd/cmdline.c | 6 +- app/test-pmd/cmdline_flow.c | 118 +++- app/test-pmd/cmdline_mtr.c | 85 -- app/test-pmd/cmdlin

[dpdk-dev] [PATCH v2 0/2] Support meter policy API

2021-04-02 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

Re: [dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling

2021-04-02 Thread Burakov, Anatoly
On 02-Apr-21 10:26 AM, Anatoly Burakov wrote: Previous fix for base frequency handling in pstate mode introduced a couple of issues: - When base_frequency file does not exist, it simply bails out because of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is incorrect, as a

Re: [dpdk-dev] [PATCH v4 2/2] power: do not skip saving original pstate governor

2021-04-02 Thread Burakov, Anatoly
On 02-Apr-21 10:26 AM, Anatoly Burakov wrote: Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set

[dpdk-dev] [21.08 v2] power: refactor pstate sysfs handling

2021-04-02 Thread Anatoly Burakov
Currently, pstate sysfs handling code is a bit of an unmaintainable mess, which has contributed to various errors leading to bugs. Refactor the code in a way that makes it more maintainable and less error prone. Signed-off-by: Anatoly Burakov --- lib/librte_power/meson.build| 7 +

[dpdk-dev] [PATCH v4 2/2] power: do not skip saving original pstate governor

2021-04-02 Thread Anatoly Burakov
Currently, when we set the pstate governor to "performance", we check if it is already set to this value, and if it is, we skip setting it. However, we never save this value anywhere, so that next time we come back and request the governor to be set to its original value, the original value is emp

[dpdk-dev] [PATCH v4 1/2] power: fix pstate base frequency handling

2021-04-02 Thread Anatoly Burakov
Previous fix for base frequency handling in pstate mode introduced a couple of issues: - When base_frequency file does not exist, it simply bails out because of what appears to be accidental addition of FOPEN_OR_ERR_RET. This is incorrect, as absence of this file is not fatal and is in fact

Re: [dpdk-dev] [PATCH v3 0/6] net: ngbe PMD

2021-04-02 Thread Ferruh Yigit
On 3/23/2021 2:19 AM, Jiawen Wu wrote: This patch set provides a skeleton of ngbe PMD, which adapted to Wangxun WX1860 series NICs. v3: - Use rte_ether functions to define marcos. v2: - Correct some clerical errors. - Use ethdev debug flags instead of driver own Jiawen Wu (6): net/ngbe: add

Re: [dpdk-dev] [PATCH v3] vhost: add header check in dequeue offload

2021-04-02 Thread Wang, Xiao W
> -Original Message- > From: David Marchand > Sent: Thursday, April 1, 2021 8:04 PM > To: Wang, Xiao W > Cc: Xia, Chenbo ; Maxime Coquelin > ; Liu, Yong ; dev > ; Ananyev, Konstantin ; > dpdk stable > Subject: Re: [PATCH v3] vhost: add header check in dequeue offload > > On Wed, Mar 17

Re: [dpdk-dev] [PATCH] net/hns3: use the correct HiSilicon copyright

2021-04-02 Thread Ferruh Yigit
On 4/2/2021 2:45 AM, Min Hu (Connor) wrote: 在 2021/4/1 22:45, Ferruh Yigit 写道: On 4/1/2021 9:53 AM, Min Hu (Connor) wrote: According to the suggestion of our legal department, to standardize the copyright license of our code to avoid potential copyright risks, we make a unified modification t

Re: [dpdk-dev] [PATCH v2 0/4] Refactor async vhost control path

2021-04-02 Thread Wang, Yinan
Tested-by: Wang, Yinan > -Original Message- > From: Hu, Jiayu > Sent: 2021?4?2? 21:04 > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; > Wang, Yinan ; Pai G, Sunil ; > Jiang, Cheng1 ; Hu, Jiayu > Subject: [PATCH v2 0/4] Refactor async vhost control path > > This patch

[dpdk-dev] [Bug 238] [tree-wide] enhance getopt_long usage

2021-04-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=238 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added CC||tho...@monjalon.net