Restrict the "remove l3_l4_xsum_errors from rx_errors" to 82599 only for
hardware errata.
Fixes: 256ff05a9cae ("ixgbe: fix Rx errors statistics for UDP checksum")
Cc: sta...@dpdk.org
Signed-off-by: Haiyue Wang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++
1 file changed, 7 insertions(+)
di
In GCC compiler, __builtin_constant_p(exp) is a function.
The function returns the integer 1 if the argument is known to be
a compile-time constant.
Therefore, __builtin_constant_p(0xff << 8) returned 1.
As the result, rte_flow_item_vxlan_mask was initiated to
{{
{flags = 0x0, rsvd0 = {0x0, 0
On Wed, Apr 07, 2021 at 03:06:16PM +, Gujjar, Abhinandan S wrote:
>
>
> > -Original Message-
> > From: Anoob Joseph
> > Sent: Tuesday, April 6, 2021 8:31 PM
> > To: Gujjar, Abhinandan S
> > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> > hemant.agra...@nxp.com; nipun.gu...@
> -Original Message-
> From: Stephen Hemminger
> Sent: Wednesday, April 7, 2021 7:01 PM
> To: Long Li
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] net/netvsc: fix log double spaced messages
>
> The PMD_DRV_LOG macro in netvsc (like other drivers) adds a newline to
> the log
Hi Liang,
Sorry that last email contains "confidential notice", so I resend it.
> -Original Message-
> From: Liang Ma
> Sent: Wednesday, April 7, 2021 6:15 PM
> To: Richael Zhuang
> Cc: dev@dpdk.org; alan.ca...@intel.com; sta...@dpdk.org; David Hunt
> ; Pablo de Lara
> Subject: Re: [dpdk
Hi Liang,
> -Original Message-
> From: Liang Ma
> Sent: Wednesday, April 7, 2021 6:15 PM
> To: Richael Zhuang
> Cc: dev@dpdk.org; alan.ca...@intel.com; sta...@dpdk.org; David Hunt
> ; Pablo de Lara
> Subject: Re: [dpdk-dev] [PATCH v3 3/3] test/power: add delay before
> checking cpuinfo
Hi Cristian,
Please help review it, which is a unified V2 that contains all patches.
https://patchwork.dpdk.org/project/dpdk/list/?series=16183
Thanks!
Regards,
Li Zhang
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, April 8, 2021 4:20 AM
> To: Li Zhang ; dek...@nvid
Currently meter algorithms only supports bytes per second(BPS).
Check packet_mode set to TRUE are rejected.
Signed-off-by: Li Zhang
---
drivers/net/softnic/rte_eth_softnic_meter.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c
b/drivers/n
Currently meter algorithms only supports rate is bytes per second(BPS).
Add packet_mode flag in meter profile parameters data structure.
So that it can meter traffic by packet per second.
When packet_mode is 0, the profile rates and bucket sizes are
specified in bytes per second and bytes
when pac
Currently meter algorithms only supports bytes per second(BPS).
Check packet_mode set to TRUE are rejected.
Signed-off-by: Li Zhang
---
drivers/net/mvpp2/mrvl_mtr.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/mrvl_mtr.c
index 2fa5cb4
Currently meter algorithms only supports rate is bytes per second(BPS).
Add packet_mode flag in meter profile parameters data structure.
So that it can meter traffic by packet per second.
When packet_mode is 0, the profile rates and bucket sizes are
specified in bytes per second and bytes
when pac
add meter profile packet_mode to the ethernet device.
One example:
add port meter profile rfc2697 (port_id) (profile_id)
(cir) (cbs) (ebs) (packet_mode)
Signed-off-by: Li Zhang
---
app/test-pmd/cmdline_mtr.c | 40 +++--
doc/guides/testpmd_app_ug/testpmd_funcs.rst
在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is
it necessary to send the V2?
v2 for what? The
Support the PMD power management API in MLX5 driver.
The monitor policy of this API puts a CPU core to sleep until
a data in some monitored memory address is changed by the NIC.
Implement the get_monitor_addr function to return an address
of a CQE owner bit to monitor the arrival of a new packet.
Makes sense, Ferruh, I've send v2 without code snippet. Would you mind to take
a look?
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, March 31, 2021 11:53
> To: Alexander Kozyrev ; dev@dpdk.org
> Cc: Raslan Darawsheh ; Slava Ovsiienko
> ; Matan Azrad ; Ori Kam
>
> Subject:
Hi Cristian
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, April 8, 2021 4:18 AM
> To: Li Zhang ; dek...@nvidia.com; Ori Kam
> ; Slava Ovsiienko ; Matan
> Azrad ; Shahaf Shuler ; Li,
> Xiaoyun
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ;
> Raslan Darawsheh ; Ron
Hi Cristian
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, April 8, 2021 4:14 AM
> To: Li Zhang ; dek...@nvidia.com; Ori Kam
> ; Slava Ovsiienko ; Matan
> Azrad ; Shahaf Shuler ;
> lir...@marvell.com
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ;
> Raslan Darawsheh
Hi Cristian,
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Thursday, April 8, 2021 4:13 AM
> To: Li Zhang ; dek...@nvidia.com; Ori Kam
> ; Slava Ovsiienko ; Matan
> Azrad ; Shahaf Shuler ;
> lir...@marvell.com; Singh, Jasvinder
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
Hi,
Thanks for your comments.
My change is to make the check_power_turbo() to continue only when
rte_power_turbo_status(TEST_POWER_LCORE_ID) returns 1 which means turbo is
available.
-Original Message-
From: Burakov, Anatoly
Sent: Wednesday, April 7, 2021 5:59 PM
To: Richael Zhuang ;
The PMD_DRV_LOG macro in netvsc (like other drivers) adds a newline to
the log message as part of the macro expansion; therefore the
message should not have its own newline.
In a couple places, log messages were split across source lines
which can make looking them up in the source tree harder.
S
> -Original Message-
> From: David Marchand
> Sent: Wednesday, April 7, 2021 19:54
> To: Wang, Haiyue ; Zhang, Qi Z
> Cc: dev ; Paolo Valerio ; Aaron Conole
> ; Rong,
> Leyi ; Tu, Lijuan ; Ruifeng Wang
> (Arm Technology China)
> ; Feifei Wang ; dpdk stable
> ; Guo, Jia
> ; Richardson,
Thanks all,
Well, Most people who replied support input verification for APIs.
As the APIs are in control path APIs, so checking all input is OK.
This is a large project because there are so many APIs and libs in DPDK.
I will send a set of patches to fix that.
Thomas, Ferruh, and others, any opi
On 4/7/2021 12:48 PM, Salem Sol wrote:
From: Jiawei Wang
With the current code the VXLAN/NVGRE parsing routine
stored the configuration of the header on stack, this
might lead to overwriting the data on the stack.
Currently having VXLAN/NVGRE encap as sample actions
is done using RAW_ENCAP, fo
The script check-doc-vs-code.sh may be used to add
some automatic checks of the doc.
If run without any argument, a complete check is done.
The optional argument is a git history reference point
to check faster only what has changed since this commit.
In this commit, the only check is for rte_flo
The NICs overview table lists all supported features per driver.
There was a single row for "Flow API",
although rte_flow is composed of many items and actions.
The row "Flow API" is replaced with two new tables for items and actions.
Also, since rte_flow is not implemented in all drivers,
it wou
The driver directory is drivers/net/sfc
but the features file was doc/guides/nics/features/sfc_efx.ini.
sfc_efx.ini is renamed sfc.ini to match the driver directory name.
It will help automatic checks of this file.
Signed-off-by: Thomas Monjalon
---
doc/guides/nics/features/{sfc_efx.ini => sfc.
This is an improvement of the rte_flow documentation:
it makes possible to quickly read which items and actions
may be accepted by the drivers in a DPDK release.
A script is provided for CI to make sure the matrix is updated,
while allowing some manual tuning.
Thomas Monjalon (3):
doc: rename s
On 4/6/2021 8:53 AM, Ferruh Yigit wrote:
On 4/2/2021 3:58 AM, Min Hu (Connor) wrote:
The validity verification of input parameters should be performed at
API layer, not in the PMD.
This set of patches fix miss input validation.
---
v2:
* Fixed mixes in ethdev header file and ethdev .c file.
Ch
Users of relied on it to provide IP-related defines,
like IPPROTO_* constants, but still had to include POSIX headers
for inet_pton() and other standard IP-related facilities.
Extend so that it is a single header to gain access
to IP-related facilities on any OS. Use it to replace POSIX includes
Windows Sockets headers contain `#define s_addr S_un.S_addr`, which
conflicts with definition of `s_addr` field of `struct rte_ether_hdr`.
Prieviously `s_addr` was undefined in , which had been
breaking access to `s_addr` field of `struct in_addr`, so some DPDK
and Windows headers could not be incl
DPDK code often relies on functions and macros that are not standard C,
but are found on all platforms, even if by slightly different names.
Windows provided macros or inline definitions for such symbols.
However, when placed in public header, these symbols were unnecessarily
exposed, breaking con
Make asprintf(3) implementation for Windows private to EAL, so that it's
hidden from external consumers. It is not exposed to internal consumers
either, because they don't need asprintf() and also because callers from
other modules would have no reliable way to free allocated memory.
Signed-off-by
On Windows, EAL contains two sets of functions and macros for POSIX
compatibility: and a networking shim (socket headers).
The latter conflicts with system headers and should not exist.
Exposing the former from EAL can break consumer own POSIX compatibility
layer and is against standards in genera
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
>
> On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote:
> >
> > Hi Jerin,
>
> Hi Ori,
>
>
> >
> > > -Original Message-
> > > From: Jerin Jacob
> > > Sent: Tuesd
The affinity of a control thread is set after it has been launched. If
setting the affinity fails, pthread_cancel is called followed by a call
to pthread_join, which can hang forever if the thread's start routine
doesn't call a pthread cancellation point.
This patch modifies the logic so that the
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
> -Original Message-
> From: Li Zhang
> Sent: Wednesday, March 31, 2021 9:54 AM
> To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com;
> ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian
> ; Li, Xiaoyun
> Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com;
>
> -Original Message-
> From: Li Zhang
> Sent: Thursday, April 1, 2021 7:19 AM
> To: Dumitrescu, Cristian ;
> dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler ; NBU-Contact-Thomas Monjalon
> ; Yigit, Ferruh ; Andrew
> Rybchenko ; Liron Himi
>
> Cc: dev@dpdk
Hi Matan, and thanks a lot,
regarding the mode *1*, I still have a doubt:
1. Register the AGE event -> in event time to query the aged-out
flows by the rte_flow_get_aged_flows API, this call will trigger a
new event when new aged-out flow will be detected for the port.(if
you don’t
> -Original Message-
> From: Li Zhang
> Sent: Wednesday, March 31, 2021 9:54 AM
> To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com;
> ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian
> ; Li, Xiaoyun
> Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.com;
>
On Thu, Apr 01, 2021 at 11:52:40AM +0200, David Marchand wrote:
> Tx offload flags are of the application responsibility.
> Leave the mbuf alone and check for TSO where needed.
>
> Signed-off-by: David Marchand
> ---
The patch looks good, but maybe a better approach would be
to change the docume
On Thu, Apr 01, 2021 at 11:52:39AM +0200, David Marchand wrote:
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated quite some time ago,
> but there was no warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
>
> Signed-off-by: Dav
> -Original Message-
> From: Li Zhang
> Sent: Thursday, April 1, 2021 7:16 AM
> To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com;
> ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian
> ; lir...@marvell.com
> Cc: dev@dpdk.org; tho...@monjalon.net; rasl...@nvidia.co
> -Original Message-
> From: Li Zhang
> Sent: Thursday, April 1, 2021 7:16 AM
> To: dek...@nvidia.com; or...@nvidia.com; viachesl...@nvidia.com;
> ma...@nvidia.com; shah...@nvidia.com; Dumitrescu, Cristian
> ; lir...@marvell.com; Singh, Jasvinder
>
> Cc: dev@dpdk.org; tho...@monjalon.n
On 06/04/2021 17:50, Bruce Richardson wrote:
> On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote:
>> Rather than have two files that keeps getting out of sync, let's
>> annotate the version.map to generate the Windows export file.
>>
>> Note: EAL version.map annotation achieved with
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob wrote:
>
> On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
> wrote:
> >
> >
> >
> > > 07/04/2021 13:28, Min Hu (Connor):
> > > > Hi, all,
> > > > Many APIs in DPDK does not check if the pointer parameter is
> > > > NULL or not. For example, in 'rt
Yes you can call it from the event callback.
Yes, MLX5_AGE_TRIGGER probably means that event was sent and no need to send it
again in the next aged-out flow.
Erasing it cause new event to be sent in the next aged-out flow...
I don't understand what is the issue for you in option 1...
השג את
> Subject: [PATCH v7] eal: fix race in ctrl thread creation
>
> The creation of control threads uses a pthread barrier for synchronization.
> This patch fixes a race condition where the pthread barrier could get
> destroyed while one of the threads has not yet returned from the
> pthread_barrier
On Wed, Apr 07, 2021 at 05:53:48PM +0100, Burakov, Anatoly wrote:
> On 07-Apr-21 5:31 PM, Burakov, Anatoly wrote:
> > On 07-Apr-21 4:56 PM, Anatoly Burakov wrote:
> > > Previous fix has addressed the incorrect handling of `base_frequency`
> > > file, but has added a use-after-free error due to the
On 07-Apr-21 5:31 PM, Burakov, Anatoly wrote:
On 07-Apr-21 4:56 PM, Anatoly Burakov wrote:
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so t
On 3/31/2021 9:53 AM, Leyi Rong wrote:
Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and simple
data path selection, as the sanity check is needed ideally.
Signed-off-by: Leyi Rong
---
drivers/net/i40e/i40e_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
On 07-Apr-21 4:56 PM, Anatoly Burakov wrote:
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right after proce
On 07-Apr-21 5:10 PM, Ferruh Yigit wrote:
On 4/7/2021 4:25 PM, Hemant Agrawal wrote:
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob
wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Ma
Reviewed-by: Liang Ma
On Wed, Apr 07, 2021 at 03:56:42PM +, Anatoly Burakov wrote:
> Previous fix has addressed the incorrect handling of `base_frequency`
> file, but has added a use-after-free error due to the fact that all
> further code paths will lead to an `fclose()` call at the end, so
Hi Anatoly,
On 7/4/2021 4:56 PM, Anatoly Burakov wrote:
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right
On 4/7/2021 4:25 PM, Hemant Agrawal wrote:
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Many APIs in DPDK does not check if the point
Previous fix has addressed the incorrect handling of `base_frequency`
file, but has added a use-after-free error due to the fact that all
further code paths will lead to an `fclose()` call at the end, so the
additional `fclose()` call right after processing the file was
unnecessary.
Coverity issue
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:
flow validate 0 ingress group 0
pattern eth / ipv4 / end
actions
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, April 5, 2021 11:11 PM
> To: Gujjar, Abhinandan S ; Shijith Thotton
> ; dev@dpdk.org
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; nipun.gu...@nxp.com;
> sachin.sax...@oss.nxp.com; Anoob Joseph ;
On 4/7/2021 8:10 PM, Ajit Khaparde wrote:
On Wed, Apr 7, 2021 at 6:20 AM Jerin Jacob wrote:
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
07/04/2021 13:28, Min Hu (Connor):
Hi, all,
Many APIs in DPDK does not check if the pointer parameter is
NULL or not. For example, i
looks ok to me.
Acked-by: Hemant Agrawal
On 4/7/2021 8:39 PM, Liulingyu wrote:
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
Signed-off-by: Liulingyu
---
app/test-pmd/util.c | 25 -
lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++
lib/librte_mbu
Extend the range of immediate value used in the MODIFY_FIELD action
from 32 to 64 bits to conform to the rte_flow_action_modify_data spec.
Apply appropriate big endian conversion to the immediate value
according to a destination field bit width.
Fixes: 641dbe4fb053 ("net/mlx5: support modify field
Extend the range of immediate value used in the MODIFY_FIELD action
from 32 to 64 bits to conform to the rte_flow_action_modify_data spec.
Apply appropriate big endian conversion to the immediate value
according to a destination field bit width.
Fixes: 641dbe4fb053 ("net/mlx5: support modify field
>
> Hi Luc,
>
> On Wed, Apr 07, 2021 at 08:53:23AM -0400, Luc Pelletier wrote:
> > The creation of control threads uses a pthread barrier for
> > synchronization. This patch fixes a race condition where the pthread
> > barrier could get destroyed while one of the threads has not yet
> > returne
Hi Alex,
This patch is causing a compilation failure as following:
[1857/3005] Compiling C object
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_flow_dv.c.o
FAILED: drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_flow_dv.c.o
gcc -Idrivers/libtmp_rte_net_mlx5.a.p -Idrivers -I../../root/dpdk/drivers
> -Original Message-
> From: dev On Behalf Of Stephen Hemminger
> Sent: Friday, April 2, 2021 2:43 AM
> To: dev@dpdk.org; Honnappa Nagarahalli
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v5] pflock: implementation of phase-fair reader
> writer locks
>
> This is a new type o
> -Original Message-
> From: Anoob Joseph
> Sent: Tuesday, April 6, 2021 8:31 PM
> To: Gujjar, Abhinandan S
> Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ;
> hemant.agra...@nxp.com; nipun.gu...@nxp.com;
> sachin.sax...@oss.nxp.com; ma...@nvidia.com; Zhang, Roy Fan
> ; g.si...@nx
> -Original Message-
> From: Alexander Kozyrev
> Sent: Friday, April 2, 2021 5:08
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: fix modify field action endianness
>
> Converting modify_field action masks to the big endian form
On 3/17/2021 8:23 AM, Wei Huang wrote:
In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted
variable "max10" should be used.
Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Fol
Hi Luc,
On Wed, Apr 07, 2021 at 10:42:37AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
Hi Joyce,
On Thu, Mar 18, 2021 at 07:20:22PM +0800, Joyce Kong wrote:
> If cache is enabled, objects will be retrieved/put from/to cache,
> subsequently from/to the common pool. Now the debug stats calculate
> the objects retrieved/put from/to cache and pool together, it is
> better to distinguish
On 3/17/2021 8:21 AM, Wei Huang wrote:
In write_flash_image(), calling function "read" may taints variable
"buf" which turn to an untrusted value as argument of "rte_free".
Coverity issue: 367477
Fixes: 7a4f3993f269 ("raw/ifpga: add FPGA RSU APIs")
Hi Huang, Rosen,
I checked the coverity iss
Hi Luc,
On Wed, Apr 07, 2021 at 08:53:23AM -0400, Luc Pelletier wrote:
> The creation of control threads uses a pthread barrier for
> synchronization. This patch fixes a race condition where the pthread
> barrier could get destroyed while one of the threads has not yet
> returned from the pthread_
Not directly related to this patch, but can someone please explain why
Patchwork is creating a new series everytime I post a new version of
the patch to this thread? I must be doing something wrong but I don't
know what it is. I have been using --in-reply-to with git send-email
but that's apparentl
On Wed, Apr 7, 2021 at 5:23 PM Ananyev, Konstantin
wrote:
>
>
>
> > 07/04/2021 13:28, Min Hu (Connor):
> > > Hi, all,
> > > Many APIs in DPDK does not check if the pointer parameter is
> > > NULL or not. For example, in 'rte_ethdev.c':
> > > int
> > > rte_eth_rx_queue_setup(uint16_t port_id, u
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
Hi Vladimir,
Few comments below, mostly minor.
One generic one - doc seems missing.
With that in place:
Acked-by: Konstantin Ananyev
>
> This patch implements predictable RSS functionality.
>
> Signed-off-by: Vladimir Medvedkin
> ---
> lib/librte_hash/rte_thash.c | 577
> +++
The creation of control threads uses a pthread barrier for
synchronization. This patch fixes a race condition where the pthread
barrier could get destroyed while one of the threads has not yet
returned from the pthread_barrier_wait function, which could result in
undefined behaviour.
Fixes: 3a0d46
On Thu, Feb 25, 2021 at 11:54 AM David Marchand
wrote:
>
> Hello Haiyue,
>
> On Thu, Feb 4, 2021 at 3:56 PM Haiyue Wang wrote:
> >
> > There is an 82599 errata that UDP frames with a zero checksum are
> > incorrectly marked as checksum invalid by the hardware. This was
> > leading to misleading
> 07/04/2021 13:28, Min Hu (Connor):
> > Hi, all,
> > Many APIs in DPDK does not check if the pointer parameter is
> > NULL or not. For example, in 'rte_ethdev.c':
> > int
> > rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
> >uint16_t nb_rx_desc, unsigned
Update documentation for sample action usage in testpmd utilizing
rte_flow_action_vxlan_encap and rte_flow_action_nvgre_encap and
show the command line example.
Signed-off-by: Salem Sol
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 24 +
1 file changed, 24 insertions(+)
Add support for rte_flow_action_nvge_encap as a sample action.
The example of test-pmd command:
1. set nvgre ip-version ... tni ... ip-src ... ip-dst ...
set raw_encap 1 eth src... / ipv4... /...
set sample_actions 2 nvgre / port_id id 0 / end
flow create 0 ... pattern eth / end acti
Add support for rte_flow_action_vxlan_encap as a sample action.
The example of test-pmd command:
1. set vxlan ip-version ... vni ... udp-src ...
set raw_encap 1 eth src.../ ipv4.../...
set sample_actions 2 vxlan_encap / port_id id 0 / end
flow create 0 ... pattern eth / end actions
Add support for NVGRE encap as a sample action
and validate it.
Signed-off-by: Salem Sol
---
doc/guides/nics/mlx5.rst | 2 +-
doc/guides/rel_notes/release_21_05.rst | 2 +-
drivers/net/mlx5/mlx5_flow_dv.c| 2 ++
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a
Add support for VXLAN encap as a sample action
and validate it.
Signed-off-by: Salem Sol
---
doc/guides/nics/mlx5.rst | 4 ++--
doc/guides/rel_notes/release_21_05.rst | 6 ++
drivers/net/mlx5/mlx5_flow_dv.c| 11 +++
3 files changed, 19 insertions(+), 2 deletio
On Wed, Apr 07, 2021 at 01:40:32PM +0200, Thomas Monjalon wrote:
> 07/04/2021 13:28, Min Hu (Connor):
> > Hi, all,
> > Many APIs in DPDK does not check if the pointer parameter is
> > NULL or not. For example, in 'rte_ethdev.c':
> > int
> > rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_q
From: Jiawei Wang
With the current code the VXLAN/NVGRE parsing routine
stored the configuration of the header on stack, this
might lead to overwriting the data on the stack.
Currently having VXLAN/NVGRE encap as sample actions
is done using RAW_ENCAP, for example:
1. set raw_encap 1 eth src.../
07/04/2021 13:28, Min Hu (Connor):
> Hi, all,
> Many APIs in DPDK does not check if the pointer parameter is
> NULL or not. For example, in 'rte_ethdev.c':
> int
> rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
> uint16_t nb_rx_desc, unsigned int socket_id
> Subject: Re: [PATCH v2] build: list symbols exports in a single file
>
> External email: Use caution opening links or attachments
>
>
> 07/04/2021 10:53, Dmitry Kozlyuk:
> > 2021-04-07 10:16 (UTC+0200), David Marchand:
> > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > > wrote:
> > > >
Hi Michael,
This patch would cause this compilation failure on aarch64 compilation with gcc
:
aarch64-linux-gnu-gcc (Linaro GCC 7.1-2017.08) 7.1.1 20170707
[615/2518] Compiling C object
drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_txq.c.o
FAILED: drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_mlx5_t
On 4/7/2021 9:35 AM, Salem Sol wrote:
-Original Message-
From: Ferruh Yigit
Sent: Wednesday, April 7, 2021 11:24 AM
To: Salem Sol ; Jiawei(Jonny) Wang ;
dev@dpdk.org
Cc: Ori Kam ; Xiaoyun Li
Subject: Re: [dpdk-dev] [PATCH v3 1/8] app/testpmd: store VXLAN/NVGRE encap
data globally
Ex
Hi, all,
Many APIs in DPDK does not check if the pointer parameter is
NULL or not. For example, in 'rte_ethdev.c':
int
rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
uint16_t nb_rx_desc, unsigned int socket_id,
const struct rte_
On Wed, Apr 7, 2021 at 4:02 PM Ori Kam wrote:
>
> Hi Jerin,
Hi Ori,
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Tuesday, April 6, 2021 10:40 AM
> > To: Ori Kam
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
> >
> > On Mon, Apr 5, 2021 at 11:35 PM
Fix out of bounds write. The allocated string size was incorrect.
Coverity issue: 369670
Fixes: 66440b7b22f2 ("table: add wildcard match table type")
Signed-off-by: Cristian Dumitrescu
---
lib/librte_table/rte_swx_table_wm.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff -
Fix logically dead code in ring port.
Coverity issue: 369664
Fixes: 77a413017c2d ("port: add ring SWX port")
Signed-off-by: Cristian Dumitrescu
---
lib/librte_port/rte_swx_port_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_port/rte_swx_port_ring.c
b/lib/
Hi Jerin,
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, April 6, 2021 10:40 AM
> To: Ori Kam
> Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
>
> On Mon, Apr 5, 2021 at 11:35 PM Ori Kam wrote:
> >
> > Currently, DPDK application can offload the checksum
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Wednesday, April 7, 2021 11:59 AM
>
> On Wed, Apr 07, 2021 at 09:11:23AM +0200, Morten Brørup wrote:
> > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Honnappa
> > > Nagarahalli
> > > Sent: Wednesday, April 7,
There is no need to pass a pointer to an mbuf pointer.
Signed-off-by: Balazs Nemeth
---
lib/librte_vhost/virtio_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 2f0c97b91..1d3ad18fe 100644
---
1 - 100 of 151 matches
Mail list logo
