Support RSS hash and FDIR for IP fragment packets in ICE PMD.
v3:
rebase code and fix some parsing issues.
v2:
add some input check
Jeff Guo (3):
net/ice/base: support IP fragment RSS and FDIR
net/ice: support RSS hash for IP fragment
net/ice: support FDIR for IP fragment packet
drivers/n
Add support for IP fragment RSS hash and FDIR according to packet ID.
Separate IP fragment and IP other packet types.
Signed-off-by: Ting Xu
Signed-off-by: Jeff Guo
---
drivers/net/ice/base/ice_fdir.c | 50 +++--
drivers/net/ice/base/ice_fdir.h | 22 ---
New pattern and RSS hash flow parsing are added to handle fragmented
IPv4/IPv6 packet.
Signed-off-by: Jeff Guo
---
drivers/net/ice/ice_generic_flow.c | 21 +
drivers/net/ice/ice_generic_flow.h | 6
drivers/net/ice/ice_hash.c | 48 +-
3 files
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet.
Signed-off-by: Jeff Guo
Signed-off-by: Ting Xu
---
drivers/net/ice/ice_fdir_filter.c | 116 ++---
drivers/net/ice/ice_generic_flow.c | 1 +
2 files changed, 106 insertions(+), 11 deletions(-)
diff
support flow for IP fragment in IAVF
v3:
rebase code and fix some parsing issues
v2:
refine some input check
Jeff Guo (4):
app/testpmd: add packet id for IP fragment
common/iavf: add proto header for IP fragment
net/iavf: support RSS hash for IP fragment
net/iavf: support FDIR for IP frag
Add the new items to support the flow configuration for IP fragment
packets.
Signed-off-by: Ting Xu
Signed-off-by: Jeff Guo
---
app/test-pmd/cmdline_flow.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdlin
Add new virtchnl protocol header type and fields for IP fragment packets
to support RSS hash and FDIR.
Signed-off-by: Ting Xu
Signed-off-by: Jeff Guo
---
drivers/common/iavf/virtchnl.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iav
New pattern and RSS hash flow parsing are added to handle fragmented
IPv4/IPv6 packet.
Signed-off-by: Ting Xu
Signed-off-by: Jeff Guo
---
drivers/net/iavf/iavf_generic_flow.c | 24
drivers/net/iavf/iavf_generic_flow.h | 3 +
drivers/net/iavf/iavf_hash.c | 83 +
New FDIR parsing are added to handle the fragmented IPv4/IPv6 packet.
Signed-off-by: Ting Xu
Signed-off-by: Jeff Guo
---
drivers/net/iavf/iavf_fdir.c | 376 ++-
drivers/net/iavf/iavf_generic_flow.h | 5 +
2 files changed, 257 insertions(+), 124 deletions(-)
di
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Friday, April 2, 2021 5:08 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH] net/mlx5: fix modify field action endianness
>
> Converting modify_field action masks to the big end
Hi,
> -Original Message-
> From: Alexander Kozyrev
> Sent: Wednesday, April 7, 2021 6:18 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava
> Ovsiienko
> Subject: [PATCH v2] net/mlx5: support 64-bit value for modify field action
>
> Extend the range of immediate value
On Thu, Apr 8, 2021 at 12:44 AM Jerin Jacob wrote:
>
> On Thu, Apr 8, 2021 at 3:45 AM Ori Kam wrote:
> >
> > Hi Jerin,
> >
> > > -Original Message-
> > > From: Jerin Jacob
> > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add packet integrity checks
> > >
> > > On Wed, Apr 7, 2021 at 4:02 PM
Hi,
> -Original Message-
> From: dev On Behalf Of Xiaoyu Min
> Sent: Tuesday, March 30, 2021 4:41 PM
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ; Jack Min
> ; Ori Kam
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS
> exp
07/04/2021 08:49, Xia, Chenbo:
> > Signed-off-by: Matan Azrad
> > Acked-by: Xueming Li
>
> Patch applied to next-virtio/main with conflict resolved.
>
> Thanks!
Sorry it cannot be pulled in the main tree because it breaks
compilation with musl libc.
It can be fixed in the same way as in
41b5a
Several functions introduced in the addition of the Windows support to
mlx5 were missing the __rte_internal tag although being exported.
Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows")
Fixes: ba420719
Hi,
> -Original Message-
> From: Dong Zhou
> Sent: Thursday, April 1, 2021 4:23 PM
> To: Jiawei(Jonny) Wang ; Raslan Darawsheh
>
> Cc: dev@dpdk.org
> Subject: [PATCH] doc: update push/pop VLAN support in mlx5 guide
>
> Updates the documentation for push/pop VLAN support. In E-Switch
> mo
Hi,
> -Original Message-
> From: Viacheslav Ovsiienko
> Sent: Wednesday, April 7, 2021 6:30 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] net/mlx4: fix RSS action hash key null pointer
>
> If RSS action contains non zero hash
From: Tal Shnaiderman
> Several functions introduced in the addition of the Windows support to
> mlx5 were missing the __rte_internal tag although being exported.
>
> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows")
> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg fun
Hi,
> -Original Message-
> From: Tal Shnaiderman
> Sent: Sunday, April 11, 2021 3:22 PM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon ; Matan Azrad
> ; Raslan Darawsheh ; Asaf Penso
> ; Wisam Monther ;
> sta...@dpdk.org
> Subject: [PATCH] common/mlx5: fix missing __rte_internal tag
The Key Wrap approach is used by applications in order to protect keys
located in untrusted storage or transmitted over untrusted
communications networks. The constructions are typically built from
standard primitives such as block ciphers and cryptographic hash
functions.
The Key Wrap method and
Hi,
Small answer update to make the example more clear.
(adding the mask to the item, in previous mail I assumed it is clear that the
mask is on only
for the selected bits, but since it may not be clear I'm adding the mask in use)
In any case since RC1 is around the corner, I'm going to send V
V2 adds tespmd patch to clarify proposed API usage.
The patches target upcoming rc1 deadline later this week.
However the API discussion is still open.
Ori Kam (2):
ethdev: add packet integrity checks
app/testpmd: add support for integrity item
app/test-pmd/cmdline_flow.c| 39 +++
From: Ori Kam
Currently, DPDK application can offload the checksum check,
and report it in the mbuf.
However, as more and more applications are offloading some or all
logic and action to the HW, there is a need to check the packet
integrity so the right decision can be taken.
The application lo
From: Ori Kam
The integrity item allows the application to match
on the integrity of a packet.
use example:
match that packet integrity checks are ok. The checks depend on
packet layers. For example ICMP packet will not check L4 level.
flow create 0 ingress pattern integrity value mask 0x01 valu
Hi Konstantin,
Thanks for the review,
On 07/04/2021 15:53, Ananyev, Konstantin wrote:
Hi Vladimir,
Few comments below, mostly minor.
One generic one - doc seems missing.
With that in place:
Acked-by: Konstantin Ananyev
This patch implements predictable RSS functionality.
Signed-off-by: Vl
Hi Stephen,
Thanks for the feedback,
On 08/04/2021 18:56, Stephen Hemminger wrote:
On Tue, 6 Apr 2021 20:50:40 +0100
Vladimir Medvedkin wrote:
This patch series introduces predictable RSS feature.
It is based on the idea of searching for partial hash collisions
within Toeplitz hash.
The To
Hi Yipeng,
Thanks for the review,
On 10/04/2021 03:32, Wang, Yipeng1 wrote:
-Original Message-
From: Medvedkin, Vladimir
Sent: Tuesday, April 6, 2021 12:51 PM
To: dev@dpdk.org
Cc: Ananyev, Konstantin ; Chilikin, Andrey
; Kinsella, Ray ; Wang,
Yipeng1 ; Gobriel, Sameh
; Richardson, Bruc
On 10/04/2021 03:05, Wang, Yipeng1 wrote:
-Original Message-
From: Medvedkin, Vladimir
Sent: Tuesday, April 6, 2021 12:51 PM
To: dev@dpdk.org
Cc: Ananyev, Konstantin ; Chilikin, Andrey
; Kinsella, Ray ; Wang,
Yipeng1 ; Gobriel, Sameh
; Richardson, Bruce
Subject: [PATCH v2 1/3] hash:
On 10/04/2021 03:10, Wang, Yipeng1 wrote:
-Original Message-
From: Medvedkin, Vladimir
Sent: Tuesday, April 6, 2021 12:51 PM
To: dev@dpdk.org
Cc: Ananyev, Konstantin ; Chilikin, Andrey
; Kinsella, Ray ; Wang,
Yipeng1 ; Gobriel, Sameh
; Richardson, Bruce
Subject: [PATCH v2 2/3] hash:
This patch series introduces predictable RSS feature.
It is based on the idea of searching for partial hash collisions
within Toeplitz hash.
The Toeplitz hash function is a homomorphism between (G, ^) and (H, ^),
where (G, ^) - is a group of tuples and (H, ^) is a group of hashes
with respect to X
This patch adds predictable RSS API.
It is based on the idea of searching partial Toeplitz hash collisions.
Signed-off-by: Vladimir Medvedkin
---
lib/librte_hash/meson.build | 3 +-
lib/librte_hash/rte_thash.c | 109 +
lib/librte_hash/rte_thash.h | 193 +
This patch implements predictable RSS functionality.
Signed-off-by: Vladimir Medvedkin
---
lib/librte_hash/rte_thash.c | 610 ++--
1 file changed, 587 insertions(+), 23 deletions(-)
diff --git a/lib/librte_hash/rte_thash.c b/lib/librte_hash/rte_thash.c
in
This patch adds tests for predictable RSS feature.
Signed-off-by: Vladimir Medvedkin
---
app/test/test_thash.c | 469 +-
1 file changed, 463 insertions(+), 6 deletions(-)
diff --git a/app/test/test_thash.c b/app/test/test_thash.c
index a6aadd1..d8
Hi Matan,
> The Key Wrap approach is used by applications in order to protect keys
> located in untrusted storage or transmitted over untrusted
> communications networks. The constructions are typically built from
> standard primitives such as block ciphers and cryptographic hash
> functions.
>
>
Hi Tal,
Getting warnings from x86_64-w64-mingw32-gcc (GCC) 9.3.0:
../../../lib/librte_eal/common/eal_common_thread.c: In function
‘ctrl_params_free’:
../../../lib/librte_eal/windows/include/pthread.h:42:2: warning: value computed
is not used [-Wunused-value]
42 | !DeleteSynchronizationBarri
Hi Jie,
General comment: try to avoid #ifdef RTE_EXEC_ENV_WINDOWS except for
inherently non-portable Unix code. It clutters the source and complicates
testing: unless you build on Linux you won't know something broke in code
under #ifdef.
Take device hot-plug for example. Since you disable paramet
2021-04-02 15:14 (UTC-0700), Jie Zhou:
> On Wed, Mar 31, 2021 at 12:10:03PM -0700, Kadam, Pallavi wrote:
> >
> > On 3/19/2021 9:51 AM, Jie Zhou wrote:
> > >From: Jie Zhou
[...]
> > >--- a/app/test-pmd/testpmd.c
> > >+++ b/app/test-pmd/testpmd.c
> > >@@ -9,7 +9,9 @@
> > > #include
> > > #incl
Decouple between the different instruction optimizer. Allow each
optimization to run as a separate iteration on the entire instruction
stream.
Signed-off-by: Cristian Dumitrescu
---
lib/librte_pipeline/rte_swx_pipeline.c | 196 ++---
1 file changed, 142 insertions(+), 54 dele
Each table entry is made up of match fields and action data, with the
latter made up of the action ID and the action arguments. The approach
of having the user specify explicitly the endianness of the action
arguments is difficult to be picked up by P4 compilers, as the P4
compiler is generally una
From: Chengwen Feng
There was a call for thread create function without result check.
Add result check and message print out after failure.
Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu (Connor)
---
From: Chengwen Feng
Add result check and message print out for thread creation after
failure.
Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu (Connor)
---
lib/librte_telemetry/telemetry.c| 28 +
There exist some thread creation function without result check.
This set of patches add result check and message print out after
failure.
Chengwen Feng (2):
telemetry: fix missing check for thread creation
test: fix missing check for thread creation
---
v2:
* fix compiling bugs of missig valu
> -Original Message-
> From: Burakov, Anatoly
> Sent: Thursday, April 8, 2021 10:56 PM
> To: Richael Zhuang ; dev@dpdk.org
> Cc: lukaszx.krakow...@intel.com; sta...@dpdk.org; David Hunt
>
> Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq
> autotest
>
> On 08-Apr
> -Original Message-
> From: Yu, DapengX
> Sent: Friday, April 9, 2021 18:29
> To: Li, Xiaoyun ; Yigit, Ferruh
> ;
> Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload
> reconfig cmd
>
>
>
> > -Original M
On 2021/4/9 16:41, Juraj Linkeš wrote:
> The current way of specifying Arm configuration options is insufficient
> since we can't identify the SoC we're building for from the MIDR
> information. For example, we can't distinguish between N1SDP, Graviton2
> or Ampere Altra.
>
> We also want to be ab
Add alternative Rx/Tx offload path for AVX512, which can support Rx/Tx
offload features, like checksum/vlan/RSS/QinQ offload.
---
v3:
- complete ice_dev_supported_ptypes_get() for new adding offload
functions.
- complete tx/rx burst infos for new adding offload functions.
v2:
- add "do_offload"
Add alternative Tx data path for AVX512 which can support partial
Tx offload features, including Tx checksum offload, vlan/QinQ
insertion offload.
Signed-off-by: Leyi Rong
Signed-off-by: Wenzhuo Lu
---
drivers/net/ice/ice_rxtx.c| 28 +--
drivers/net/ice/ice_rxtx.h|
Split AVX512 Rx data path into two, one is for basic,
the other one can support additional Rx offload features,
including Rx checksum offload, Rx vlan offload, RSS offload.
Signed-off-by: Leyi Rong
Signed-off-by: Wenzhuo Lu
---
drivers/net/ice/ice_rxtx.c| 50 +++-
drivers/net/ice/i
Hi Shijith,
CI is failing for this patch -> ci/Intel-compilationfailapply issues
Whereas CI is not running for other patches. Could you please check?
Regards
Abhinandan
> -Original Message-
> From: Shijith Thotton
> Sent: Friday, April 9, 2021 7:30 PM
> To: dev@dpdk.org
> Cc: Sh
On Mon, Apr 5, 2021 at 9:54 PM Harman Kalra wrote:
>
> When device is re-configured, memory allocated for work slot is freed
> and new memory is allocated. Due to this we may loose some important
> configurations/mappings done with initial work slot memory.
>
> For example, whenever rte_event_eth_
The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those is
performance-optimized for the specific set of requested offloads.
These ones are generated on the basis of the template function and it takes
significant time to compile, just due to a large number of giant functions
gen
This patch separates Tx function declarations to different header file
in preparation for removing their implementation from the source file
and as an optional preparation for Tx cleanup.
Signed-off-by: Michael Baum
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/linux/mlx5_mp_os.c | 1 +
This patch separates Rx function implementations to different source
file as an optional preparation step for further consolidation of Rx
burst functions.
Signed-off-by: Michael Baum
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/meson.build |1 +
drivers/net/mlx5/mlx5_rx.c | 1203 ++
The mlx5_rxtx.c file contains a lot of Tx burst functions, each of those
is performance-optimized for the specific set of requested offloads.
These ones are generated on the basis of the template function and it
takes significant time to compile, just due to a large number of giant
functions genera
This patch separates Tx function implementations to different source
file as an optional preparation step for Tx cleanup.
Signed-off-by: Michael Baum
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/meson.build | 1 +
drivers/net/mlx5/mlx5_rxtx.c | 757 -
This patch separates Tx burst function implementations to different
source files, thus allowing them to compile in parallel.
Signed-off-by: Michael Baum
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/meson.build | 4 +
drivers/net/mlx5/mlx5_rxtx.c | 201 --
On April 9, 2021 10:37 PM, Ferruh Yigit wrote:
> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
> > Adding bare minimum PMD library and doc build infrastructure and claim
> > the maintainership for ngbe PMD.
> >
> > Signed-off-by: Jiawen Wu
>
> <...>
>
> > diff --git a/doc/guides/nics/ngbe.rst b/doc/gui
> -Original Message-
> From: Jiawei Wang
> Sent: Friday, April 9, 2021 15:33
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ;
> Jiawei(Jonny) Wang
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix resource release issue for mirror flow
>
> The mlx5 PMD allocated
> -Original Message-
> From: Jiawei Wang
> Sent: Friday, April 9, 2021 15:37
> To: Matan Azrad ; Shahaf Shuler
> ; Slava Ovsiienko ;
> Jiawei(Jonny) Wang
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix VLAN/DECAP actions not work in mirror flow
>
> Due to hardware li
Hi Xueming,
On Sat, Apr 10, 2021 at 02:23:55PM +, Xueming Li wrote:
> Adds a new function to get value of a specific key from kvargs list.
>
> Signed-off-by: Xueming Li
> Reviewed-by: Gaetan Rivet
> ---
> lib/librte_kvargs/rte_kvargs.c | 20
> lib/librte_kvargs/rte_kva
60 matches
Mail list logo
