Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-16 Thread Min Hu (Connor)
在 2021/4/17 2:40, Thomas Monjalon 写道: 13/04/2021 03:12, Min Hu (Connor): 在 2021/4/12 15:19, David Marchand 写道: On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: This set of patches support set thread name for debugging. Chengwen Feng (7): net/ark: support set thread name ne

Re: [dpdk-dev] [PATCH v9] app/testpmd: support multi-process

2021-04-16 Thread Min Hu (Connor)
Hi, Ferrruh, All is fixed in v10, please check it out, thanks. 在 2021/4/17 0:30, Ferruh Yigit 写道: On 4/16/2021 2:52 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0

[dpdk-dev] [PATCH v10] app/testpmd: support multi-process

2021-04-16 Thread Min Hu (Connor)
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --num-procs=

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Bing Zhao
Hi Ajit, > -Original Message- > From: Ajit Khaparde > Sent: Saturday, April 17, 2021 5:47 AM > To: Bing Zhao > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: introduce conntrack flo

[dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-16 Thread Lijun Ou
Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id], this is not the recommended way to access it. So this patch add get queue state when call rte_eth_rx_queue_info_get and rte_eth_tx_queue_info_get API. Note: After add queue_s

[dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-16 Thread Lingyu Liu
Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. Signed-off-by: Lingyu Liu Acked-by: Hemant Agrawal --- V2 change: - refine commit log app/test-pmd/util.c | 25 - lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 22 +

[dpdk-dev] [PATCH v1] mbuf: support eCPRI hardware packet type Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.

2021-04-16 Thread Lingyu Liu
Signed-off-by: Lingyu Liu Acked-by: Hemant Agrawal --- app/test-pmd/util.c | 25 - lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ lib/librte_mbuf/rte_mbuf_ptype.h | 22 ++ 3 files changed, 40 insertions(+), 9 deletions(-) diff --git a/app/test

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Ajit Khaparde
> > > + > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this structure may change without prior > > notice > > > + * > > > + * Configuration parameters for each direction of a TCP > > connection. > > > + */ > > > +struct rte_flow_tcp_dir_param { > > > + uint32_t scale:4; /**< TCP window

Re: [dpdk-dev] [PATCH] eal: standard c++ forbids defining the keyword asm as a macro

2021-04-16 Thread Tyler Retzlaff
On Tue, Apr 13, 2021 at 03:35:53PM +0200, Thomas Monjalon wrote: > 24/03/2021 05:26, Tyler Retzlaff: > > --- a/lib/librte_eal/include/rte_common.h > > +++ b/lib/librte_eal/include/rte_common.h > > @@ -31,9 +31,11 @@ extern "C" { > > #define typeof __typeof__ > > #endif > > > > +#ifndef __cplusp

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
在 2021/4/17 0:28, Stephen Hemminger 写道: On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: + if (dev_conf == NULL) { + RTE_ETHDEV_LOG(ERR, + "Cannot configure ethdev port %u to NULL dev_conf\n", The others use a natural sounding names instead

[dpdk-dev] [PATCH] pipeline: add table statistics

2021-04-16 Thread Cristian Dumitrescu
Add support for table statistics for the SWX pipeline. For each table, we maintain a counter for lookup hit packets, one for lookup miss packets and one packet counter for each table action. Signed-off-by: Cristian Dumitrescu Signed-off-by: Yogesh Jangra --- examples/pipeline/cli.c

Re: [dpdk-dev] [PATCH v3 3/3] doc: update for conntrack

2021-04-16 Thread Ajit Khaparde
On Fri, Apr 16, 2021 at 10:54 AM Bing Zhao wrote: > > The updated documentations include: > 1. Release notes > 2. rte_flow.rst > 3. testpmd user guide > > Signed-off-by: Bing Zhao > --- > doc/guides/prog_guide/rte_flow.rst | 113 > doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Ajit Khaparde
On Fri, Apr 16, 2021 at 10:54 AM Bing Zhao wrote: > > This commit introduces the conntrack action and item. > > Usually the HW offloading is stateless. For some stateful offloading > like a TCP connection, HW module will help provide the ability of a > full offloading w/o SW participation after th

[dpdk-dev] Bug with commit 64051bb1 (devargs: unify scratch buffer storage)

2021-04-16 Thread Harris, James R
Hi, SPDK has identified a regression with commit 64051bb1 (devargs: unify scratch buffer storage). The issue seems to be with this part of the patch: @@ -276,15 +287,8 @@ rte_devargs_insert(struct rte_devargs **da) if (strcmp(listed_da->bus->name, (*da)->bus->name) == 0 &&

Re: [dpdk-dev] [PATCH v1] net/virtio: fix vectorized Rx queue stuck

2021-04-16 Thread David Christensen
When Rx queue worked in vectorized mode and rxd <= 512, under traffic of high PPS rate, testpmd often start and receive packets of rxd without further growth. Testpmd started with rxq flush which tried to rx MAX_PKT_BURST(512) packets and drop. When Rx burst size >= Rx queue size, all descriptors

[dpdk-dev] [PATCH v2] buildtools: fix all drivers disabled on Windows

2021-04-16 Thread Dmitry Kozlyuk
buildtools/list-dir-globs.py printed paths with OS directory separator, which is "/" on Unices and "\" on Windows, while Meson code always expected "/". This resulted in all drivers being disabled on Windows. Replace "\" with "/" in script output. Forward slash is a valid, although non-default, se

Re: [dpdk-dev] [PATCH v6 00/10] eal: Add new API for threading

2021-04-16 Thread Narcisa Ana Maria Vasile
On Mon, Apr 12, 2021 at 09:56:14AM +0200, David Marchand wrote: > On Sat, Apr 3, 2021 at 3:39 AM Narcisa Ana Maria Vasile > wrote: > > > > From: Narcisa Vasile > > > > EAL thread API > > > Thanks for taking on this huge work. > > There is no review on this series and I don't have time for it. >

Re: [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs

2021-04-16 Thread Ajit Khaparde
On Fri, Apr 16, 2021 at 12:03 AM Thomas Monjalon wrote: > > 15/04/2021 19:59, Ajit Khaparde: > > On Thu, Apr 15, 2021 at 8:52 AM Bing Zhao wrote: > > > There are two types of flow actions: > > > 1. the direct (normal) actions that could be created and stored > > >within a flow rule. Such acti

Re: [dpdk-dev] [PATCH 0/7] support set thread name

2021-04-16 Thread Thomas Monjalon
13/04/2021 03:12, Min Hu (Connor): > 在 2021/4/12 15:19, David Marchand 写道: > > On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: > >> > >> This set of patches support set thread name for debugging. > >> > >> Chengwen Feng (7): > >>net/ark: support set thread name > >>net/ice: support

Re: [dpdk-dev] [PATCH v3 3/3] doc: update for conntrack

2021-04-16 Thread Thomas Monjalon
Doc should be added with the code. 16/04/2021 19:54, Bing Zhao: > The updated documentations include: > 1. Release notes > 2. rte_flow.rst 1 & 2 can go in ethdev patch > 3. testpmd user guide 3 can go in testpmd patch.

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add CLI for conntrack

2021-04-16 Thread Bing Zhao
Hi Ori, > -Original Message- > From: Ori Kam > Sent: Friday, April 16, 2021 4:47 PM > To: Bing Zhao ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; ajit.khapa...@broadcom.com > Subject: RE: [PATCH v2 2/2] app/testpmd: add CLI f

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Bing Zhao
Hi Thomas, Thanks for your comments. Almost all the comments are addressed. PSB. > -Original Message- > From: Thomas Monjalon > Sent: Friday, April 16, 2021 6:50 PM > To: Bing Zhao > Cc: Ori Kam ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org; > ajit.khapa...@broa

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Bing Zhao
Hi Ori, My comments are inline, PSB. > -Original Message- > From: Ori Kam > Sent: Friday, April 16, 2021 8:42 PM > To: Bing Zhao ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; ajit.khapa...@broadcom.com > Subject: RE: [PATCH v

[dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows

2021-04-16 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test-

[dpdk-dev] [PATCH v5 7/9] app/testpmd: replace POSIX specific code

2021-04-16 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v5 6/9] app/testpmd: fix parse_fec_mode return type

2021-04-16 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-16 Thread Jie Zhou
Add clock_gettime_monotonic for testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ef0b9784d..a5f8f

[dpdk-dev] [PATCH v5 8/9] app/testpmd: fix headers inclusion

2021-04-16 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6 d

[dpdk-dev] [PATCH v5 0/9] app/testpmd: enable testpmd on Windows

2021-04-16 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v5 4/9] app/testpmd: resolve name collisions

2021-04-16 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 494 ++-- 1 file changed, 247 insertions(+), 247 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c inde

[dpdk-dev] [PATCH v5 1/9] lib: build libraries that testpmd depends on

2021-04-16 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 4eed83e57..3483570ac 100644 --- a/lib/meson.build +++ b/lib/mes

[dpdk-dev] [PATCH v5 3/9] eal/windows: add device event stubs

2021-04-16 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/eal_dev.c | 33 ++ lib/librte_eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/librte_eal/windows/eal

[dpdk-dev] [PATCH v5 2/9] eal/windows: add necessary macros

2021-04-16 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/windows/include/rte_os_shim.h b/lib/librte_eal/windows/include

[dpdk-dev] [PATCH v3 3/3] doc: update for conntrack

2021-04-16 Thread Bing Zhao
The updated documentations include: 1. Release notes 2. rte_flow.rst 3. testpmd user guide Signed-off-by: Bing Zhao --- doc/guides/prog_guide/rte_flow.rst | 113 doc/guides/rel_notes/release_21_05.rst | 4 + doc/guides/testpmd_app_ug/testpmd_funcs.rst |

[dpdk-dev] [PATCH v3 2/3] app/testpmd: add CLI for conntrack

2021-04-16 Thread Bing Zhao
The command line for testing connection tracking is added. To create a conntrack object, 3 parts are needed. set conntrack com peer ... set conntrack orig scale ... set conntrack rply scale ... This will create a full conntrack action structure for the indirect action. After the indirect acti

[dpdk-dev] [PATCH v3 1/3] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Bing Zhao
This commit introduces the conntrack action and item. Usually the HW offloading is stateless. For some stateful offloading like a TCP connection, HW module will help provide the ability of a full offloading w/o SW participation after the connection was established. The basic usage is that in the

[dpdk-dev] [PATCH v3 0/3] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Bing Zhao
Depends-on: series-16451 ("Change shared action API to action handle API") This patch set includes the conntrack action and item definitions as well as the testpmd CLI proposal. Documents of release notes and guides are also updated. --- v2: add testpmd CLI proposal v3: add doc update --- Bing Z

Re: [dpdk-dev] [EXTERNAL] [PATCH] WindowsGSGDoc: Update the meson version to use for Windows DPDK

2021-04-16 Thread Thomas Monjalon
17/03/2021 01:00, Dmitry Kozlyuk: > 2021-03-16 12:09 (UTC+0100), Thomas Monjalon: > > 08/03/2021 19:32, Jie Zhou: > [...] > > > -Recommended version is either Meson 0.47.1 (baseline) or the latest > > > release. > > > +Recommended version is either Meson 0.57.0 (baseline) or the latest > > > rele

[dpdk-dev] [PATCH v4 7/9] app/testpmd: replace POSIX specific code

2021-04-16 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v4 9/9] app/testpmd: enable building testpmd on Windows

2021-04-16 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test-

[dpdk-dev] [PATCH v4 8/9] app/testpmd: fix headers inclusion

2021-04-16 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6 d

[dpdk-dev] [PATCH v4 5/9] app/testpmd: add clock_gettime_monotonic

2021-04-16 Thread Jie Zhou
Add clock_gettime_monotonic for testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ef0b9784d..018b7

[dpdk-dev] [PATCH v4 6/9] app/testpmd: fix parse_fec_mode return type

2021-04-16 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [PATCH v4 4/9] app/testpmd: resolve name collisions

2021-04-16 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 494 ++-- 1 file changed, 247 insertions(+), 247 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c inde

[dpdk-dev] [PATCH v4 3/9] eal/windows: add device event stubs

2021-04-16 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/eal_dev.c | 33 ++ lib/librte_eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/librte_eal/windows/eal

[dpdk-dev] [PATCH v4 0/9] app/testpmd: Enable testpmd on Windows

2021-04-16 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v4 2/9] eal/windows: add necessary macros

2021-04-16 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/librte_eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/windows/include/rte_os_shim.h b/lib/librte_eal/windows/include

[dpdk-dev] [PATCH v4 1/9] lib: build libraries that testpmd depends on

2021-04-16 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/meson.build b/lib/meson.build index 4eed83e57..3483570ac 100644 --- a/lib/meson.build +++ b/lib/mes

[dpdk-dev] [PATCH v4 1/1] ethdev: introduce indirect action APIs

2021-04-16 Thread Bing Zhao
Right now, rte_flow_shared_action_* APIs are used for some shared actions, like RSS, count. The shared action should be created before using it inside a flow. These shared actions sometimes are not really shared but just some indirect actions decoupled from a flow. The new functions rte_flow_actio

[dpdk-dev] [PATCH v4 0/1] Change shared action API to action handle API

2021-04-16 Thread Bing Zhao
The patch set includes: 1. API changes 2. testpmd adaption and guide update 3. driver update (only net/mlx5 is impacted) 4. rte_flow documentation update --- v2: add adaptions of testpmd and driver part v3: squash all patches into one and update rte_flow doc v4: fix the doc format er

Re: [dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-04-16 Thread Thomas Monjalon
16/04/2021 17:01, Thomas Monjalon: > 23/03/2021 11:13, Andrew Rybchenko: > > On 3/23/21 1:11 PM, Bruce Richardson wrote: > > > On Tue, Mar 23, 2021 at 10:52:19AM +0100, Gabriel Ganne wrote: > > >> Bump meson required version to 0.49 which is chosen so as to be provided > > >> by both redhat-8 and d

Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

2021-04-16 Thread Ferruh Yigit
On 4/15/2021 11:10 PM, Dmitry Kozlyuk wrote: Most modern and actively maintained distribution of libpcap for Windows is Npcap [1]. It currently doesn't provide a pkg-config file [2]. By default it is installed to C:\Program Files\Npcap and can be located using standard environment variables [3]:

[dpdk-dev] [PATCH v8 5/5] doc/guides/l3_forward: update documentation for FIB

2021-04-16 Thread Conor Walsh
The purpose of this patch is to update the l3fwd user guide to include the changes proposed in this patchset. Signed-off-by: Conor Walsh Acked-by: John McNamara --- doc/guides/rel_notes/release_21_05.rst | 5 +++ doc/guides/sample_app_ug/l3_forward.rst | 50 ++--- 2 files

[dpdk-dev] [PATCH v8 4/5] examples/l3fwd: implement FIB lookup method

2021-04-16 Thread Conor Walsh
This patch implements the Forwarding Information Base (FIB) library in l3fwd using the function calls and infrastructure introduced in the previous patch. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_fib.c | 480 +

[dpdk-dev] [PATCH v8 3/5] examples/l3fwd: add FIB infrastructure

2021-04-16 Thread Conor Walsh
The purpose of this commit is to add the necessary function calls and supporting infrastructure to allow the Forwarding Information Base (FIB) library to be integrated into the l3fwd sample app. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user

[dpdk-dev] [PATCH v8 2/5] examples/l3fwd: move l3fwd routes to common header

2021-04-16 Thread Conor Walsh
To prevent code duplication from the addition of lookup methods the routes specified in lpm should be moved to a common header. Signed-off-by: Conor Walsh Acked-by: Konstantin Ananyev Acked-by: Vladimir Medvedkin --- examples/l3fwd/l3fwd_lpm.c | 74 +--- examp

[dpdk-dev] [PATCH v8 1/5] examples/l3fwd: fix LPM IPv6 subnets

2021-04-16 Thread Conor Walsh
Any IP within the 2001:200::/48 subnet will match all the routes given instead of 1 individual route and the application cannot differentiate between them. The change in this patch allows the ports to be individually matched using smaller /64 ranges for each port. These smaller subnet ranges are st

[dpdk-dev] [PATCH v8 0/5] examples/l3fwd: add FIB lookup method to l3fwd

2021-04-16 Thread Conor Walsh
Currently the l3fwd sample app supports LPM and EM lookup methods this patchset implements the FIB library as another lookup method for l3fwd. Instead of adding an individual flag for FIB, a new flag '--lookup' has been added that allows the user to select their desired lookup method. The flags '-E

[dpdk-dev] [PATCH 14/14] lib: allow disabling optional libraries

2021-04-16 Thread Bruce Richardson
Add support for the disable_libs option, to allow disabling the build of particular libraries. As part of this, maintain a list of what libraries can safely be disabled, without breaking the build - for now this list is solely those libraries which are not built on FreeBSD, kni, power and vhost. Th

[dpdk-dev] [PATCH 10/14] examples: change meson file tabs to spaces

2021-04-16 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Signed-off-by: Bruce Richardson --- examples/bbdev_app/meson.build| 2 +- examples/bond/meson.build | 2 +- examples/cmdline/meson.build | 2 +- examples/distributor/meson.buil

[dpdk-dev] [PATCH 11/14] app: change meson file tabs to spaces

2021-04-16 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Signed-off-by: Bruce Richardson --- app/test-bbdev/meson.build | 12 +- app/test-compress-perf/meson.build | 10 +- app/test-crypto-perf/meson.build | 20 +- app/test-eventdev/meson.build | 24 +- app/test-flow-pe

[dpdk-dev] [PATCH 12/14] editorconfig: add entry for meson files

2021-04-16 Thread Bruce Richardson
Meson style guide recommends four-space indents, like for python, so add to editorconfig file. Signed-off-by: Bruce Richardson --- .editorconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/.editorconfig b/.editorconfig index d70582557..5101630c8 100644 --- a/.editorconfig +++ b/.edi

[dpdk-dev] [PATCH 08/14] lib: cleanup whitespace in meson build files

2021-04-16 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Perform other formating cleanups such as ensure that long lists of files are one per line, and terminating with a final comma before the closing brace to make addition/removals easier. In some cases, reorder lists of items where they w

[dpdk-dev] [PATCH 07/14] build: change infrastructure file tabs to spaces

2021-04-16 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation, for the basic infrastructure and tooling files, as well as doc and kernel directories. Signed-off-by: Bruce Richardson --- buildtools/chkincs/meson.build| 24 +- buildtools/meson.build| 34 +- buildtools/pkg-config

[dpdk-dev] [PATCH 06/14] build: reduce indentation in examples build spec

2021-04-16 Thread Bruce Richardson
As with the lib and drivers directories, we can use "continue" keyword to reduce the indentation level of the majority of the foreach block. At the same time, we can also replace tab indentation with spaces. Signed-off-by: Bruce Richardson --- examples/meson.build | 177 -

[dpdk-dev] [PATCH 05/14] build: reduce indentation in app build spec

2021-04-16 Thread Bruce Richardson
As with the lib and drivers directories, we can use "continue" keyword to reduce the indentation level of the majority of the foreach block. At the same time, we can also replace tab indentation with spaces. Signed-off-by: Bruce Richardson --- app/meson.build | 101 --

[dpdk-dev] [PATCH 04/14] build: clean up driver lists

2021-04-16 Thread Bruce Richardson
Ensure all lists of drivers are standardized: * one driver per line * lists double-indented with spaces (as they are line continuations) * elements in alphabetical order * opening and closing list brackets "[" & "]" on own lines * last element has trailing comma Any code snippets in the list files

[dpdk-dev] [PATCH 03/14] build: simplify the driver build configuration file

2021-04-16 Thread Bruce Richardson
As with the library meson.build file, we can use the "continue" keyword to reduce the level of indentation used for the majority of the build file. Since we are changing the whitespace indentation level, we also update the body of the foreach loop to use the meson standard, 4-space indentation. Si

[dpdk-dev] [PATCH 02/14] build: tidy up list of libraries to build

2021-04-16 Thread Bruce Richardson
With the lib/meson.build file changed from C-style indentation to python-style indentation, we need to correct the indentation of the lists of libraries, since these libs were not modified in the previous patches. For ease of management of the list and working with patches for adding to the list, p

[dpdk-dev] [PATCH 01/14] build: simplify library build file

2021-04-16 Thread Bruce Richardson
Two simplifications can be made to the build file which reduce indentation levels and make it easier to read: 1. When meson build support was first added, the compat library existed in DPDK as a single header file. Since that header has been merged into EAL, we no longer need to support header-onl

[dpdk-dev] [PATCH 00/14] Build file updates

2021-04-16 Thread Bruce Richardson
This RFC contains 5 changes/updates to the DPDK build and build files. The changes in this set are: 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels in the foreach loops when building library or driver components. 2. For libraries, drop support for header-only lib

Re: [dpdk-dev] [pull-request] next-crypto 21.05 rc1

2021-04-16 Thread Thomas Monjalon
16/04/2021 12:46, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Thu, 15 Apr 2021 16:38:16 +0100 Ferruh Yigit wrote: > When the line is long, can you break the message part to next line, to reduce > the length at least a few columns, like: > > RTE_ETHDEV_LOG(ERR, > "Failed to setup ethdev port %u Rx hairpin queue to NULL\n", > port_id); > > S

Re: [dpdk-dev] [PATCH v9] app/testpmd: support multi-process

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 2:52 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=a

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: > > + if (dev_conf == NULL) { > > + RTE_ETHDEV_LOG(ERR, > > + "Cannot configure ethdev port %u to NULL dev_conf\n", > > The others use a natural sounding names instead of argument name. If you > wanted to mat

Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs

2021-04-16 Thread Stephen Hemminger
On Thu, 15 Apr 2021 19:09:19 +0800 "Min Hu (Connor)" wrote: > + RTE_ETHDEV_LOG(ERR, "Failed to get owner id by NULL\n"); This message is awkward wording. It would be good time to fix something that has causes problems. Redefine RTE_ETHDEV_LOG to include the function name. There are

Re: [dpdk-dev] [PATCH 0/2] bugfix for doc

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 11:34 AM, Min Hu (Connor) wrote: This patchset contains 2 patches, to fix testpmd doc and hns3 doc. Huisong Li (1): doc/testpmd: delete queue stats mapping description Min Hu (Connor) (1): doc: fix HiSilicon copyright syntax Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH 1/2] doc/testpmd: delete queue stats mapping description

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 11:34 AM, Min Hu (Connor) wrote: From: Huisong Li The "--tx-queue-stats-mapping" and "--rx-queue-stats-mapping" , and display and clear of "stats_map" have been removed from testpmd. This patch deletes some descriptions about queue stats mapping in testpmd doc. Fixes: 08dcd187068

Re: [dpdk-dev] [PATCH v4] meson: update minimum required meson version

2021-04-16 Thread Thomas Monjalon
23/03/2021 11:13, Andrew Rybchenko: > On 3/23/21 1:11 PM, Bruce Richardson wrote: > > On Tue, Mar 23, 2021 at 10:52:19AM +0100, Gabriel Ganne wrote: > >> Bump meson required version to 0.49 which is chosen so as to be provided > >> by both redhat-8 and debian-10. > >> > >> Update documentation and

Re: [dpdk-dev] [PATCH v6] net/iavf: deprecate i40evf pmd

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 11:15 AM, Zhang, Qi Z wrote: -Original Message- From: dev On Behalf Of Robin Zhang Sent: Friday, April 16, 2021 9:58 AM To: dev@dpdk.org Cc: Xing, Beilei ; Guo, Jia ; Wang, Haiyue ; m...@ashroe.eu; nhor...@tuxdriver.com; Wu, Jingjing ; Yang, Qiming ; Yang, SteveX ; Zhang,

Re: [dpdk-dev] [dpdklab] Re: [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Lincoln Lavoie
We can look into that, but that now will need to be tested to work across all the different OS distros in the containers. For now, we can install the update on the ubuntu 18.04 worker that is running the production and remake the reference cache. Cheers, Lincoln On Fri, Apr 16, 2021 at 8:58 AM T

Re: [dpdk-dev] [PATCH v2 2/6] net/mlx5: separate Rx function implementations to new file

2021-04-16 Thread Ferruh Yigit
On 4/12/2021 7:32 AM, Michael Baum wrote: This patch separates Rx function implementations to different source file as an optional preparation step for further consolidation of Rx burst functions. Signed-off-by: Michael Baum Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/meson.build |

Re: [dpdk-dev] [dpdklab] Re: [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Thomas Monjalon
16/04/2021 14:43, Lincoln Lavoie: > All of the UNH ABI testing is moving info containers, so it can be run on > top of each OS, alongside the other compile and unit testing. This is > actually ready now, but hasn't been pushed live this week, because of the > backlog in the system because of the DT

Re: [dpdk-dev] [dpdklab] Re: [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Lincoln Lavoie
All of the UNH ABI testing is moving info containers, so it can be run on top of each OS, alongside the other compile and unit testing. This is actually ready now, but hasn't been pushed live this week, because of the backlog in the system because of the DTS failure. The additional compile jobs ar

Re: [dpdk-dev] [PATCH v2] build: optional NUMA and cpu counts detection

2021-04-16 Thread Juraj Linkeš
I didn't notice this e-mail, since it was sent just to dev@dpdk.org and not to me explicitly, which left it unnoticed by my filters, unfortunately. > -Original Message- > From: dev On Behalf Of David Christensen > Sent: Wednesday, March 31, 2021 9:07 PM > To: dev@dpdk.org > Subject: Re:

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Ori Kam
Hi Bing, One more thought, PSB Best, Ori > -Original Message- > From: Bing Zhao > Sent: Thursday, April 15, 2021 7:41 PM > To: Ori Kam ; NBU-Contact-Thomas Monjalon > ; ferruh.yi...@intel.com; > andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; ajit.khapa...@broadcom.com > Subject: [PATC

Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage

2021-04-16 Thread Aaron Conole
David Marchand writes: > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: >> diff --git a/lib/librte_eal/include/rte_devargs.h >> b/lib/librte_eal/include/rte_devargs.h >> index 296f19324f..134b44a887 100644 >> --- a/lib/librte_eal/include/rte_devargs.h >> +++ b/lib/librte_eal/include/rte_deva

Re: [dpdk-dev] [PATCH v2 2/2] ci: bump ABI reference version

2021-04-16 Thread David Marchand
On Thu, Apr 15, 2021 at 9:43 PM David Marchand wrote: > > When bumping DPDK version, we should have bumped the ABI reference too. > > Fixes: 442155f70c6b ("version: 21.05-rc0") > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon Series applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Thomas Monjalon
16/04/2021 13:00, Min Hu (Connor): > + if (iter == NULL) { > + RTE_ETHDEV_LOG(ERR, "Cannot init iterator for NULL iterator\n"); Don't you think it would be better as "Cannot init NULL iterator"? > rte_eth_iterator_cleanup(struct rte_dev_iterator *iter) > { > + if (iter == NU

Re: [dpdk-dev] Potential bug in QAT PMD code

2021-04-16 Thread Linfeng Li
Hi Declan, I'm wondering if there is any update on this issue and if so when the fix can be merged into the master branch. Thanks so much. Regards, Linfeng -Original Message- From: Doherty, Declan Sent: Wednesday, March 3, 2021 2:01 AM To: Linfeng Li ; dev@dpdk.org Cc: john.grif...@in

Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 12:00 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for inval

Re: [dpdk-dev] [PATCH v5] vhost: allocate and free packets in bulk in Tx packed

2021-04-16 Thread David Marchand
On Fri, Apr 16, 2021 at 12:26 PM Balazs Nemeth wrote: > > Move allocation out further and perform all allocation in bulk. The same > goes for freeing packets. In the process, also introduce > virtio_dev_pktmbuf_prep and make virtio_dev_pktmbuf_alloc use that. > > Signed-off-by: Balazs Nemeth Rev

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-16 Thread Min Hu (Connor)
Looks good to me. 在 2021/4/16 19:04, Chengchang Tang 写道: This patch add Tx prepare for bonding device. Currently, the bonding driver has not implemented the callback of rte_eth_tx_prepare function. Therefore, the TX prepare function of the slave devices will never be invoked. When hardware offl

[dpdk-dev] [RFC 1/2] net/bonding: add Tx prepare for bonding

2021-04-16 Thread Chengchang Tang
To use the HW offloads capability (e.g. checksum and TSO) in the Tx direction, the upper-layer users need to call rte_eth_dev_prepare to do some adjustment to the packets before sending them (e.g. processing pseudo headers when Tx checksum offoad enabled). But, the tx_prepare callback of the bond d

[dpdk-dev] [RFC 2/2] app/testpmd: add cmd for bonding Tx prepare

2021-04-16 Thread Chengchang Tang
Add new command to support enable/disable Tx prepare on each slave of a bonded device. This helps to test some Tx HW offloads (e.g. checksum and TSO) for boned devices in testpmd. The related commands are as follows: set bonding tx_prepare [enable|disable] When this option is enabled, bonding dr

[dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-16 Thread Chengchang Tang
This patch add Tx prepare for bonding device. Currently, the bonding driver has not implemented the callback of rte_eth_tx_prepare function. Therefore, the TX prepare function of the slave devices will never be invoked. When hardware offloading such as CKSUM and TSO are enabled for some drivers, t

Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
Hi, Kevin and all fixed in v7, thanks. 在 2021/4/16 18:22, Kevin Traynor 写道: On 16/04/2021 07:52, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefi

[dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: introduce conntrack flow action and item

2021-04-16 Thread Thomas Monjalon
15/04/2021 18:41, Bing Zhao: > This commit introduced the conntrack action and item. > > Usually the HW offloading is stateless. For some stateful offloading > like a TCP connection, HW module will help provide the ability of a > full offloading w/o SW participation after the connection was > esta

[dpdk-dev] [pull-request] next-crypto 21.05 rc1

2021-04-16 Thread Akhil Goyal
The following changes since commit 2414ce9b7b1770be2a5f406a1862589ebdef0315: power: fix closing frequency file (2021-04-15 23:53:39 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to df295be9d4d59261a7de76c4ee16b4ce0408d2

  1   2   >