Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success

2021-04-20 Thread Wang, Haiyue
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 14:22 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ; > Wang, Haiyue > > Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success > > From: Chengwen Feng > > This patch fixes e1000_write_nv

[dpdk-dev] [Bug 682] [dpdk-21.05]metering_and_policing: Invalid group ID: Invalid argument

2021-04-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=682 longfengx.li...@intel.com (longfengx.li...@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: [dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD

2021-04-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, April 20, 2021 1:55 PM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; ferruh.yi...@intel.com; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso > > Subject: [PATCH v6 00/15] Add ASO meter sup

Re: [dpdk-dev] [PATCH v6 15/15] doc: update release notes for ASO meter

2021-04-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei Wang > Sent: Tuesday, April 20, 2021 1:55 PM > To: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; ferruh.yi...@intel.com; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso > > Subject: [PATCH v6 15/15] doc: update relea

[dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter

2021-04-20 Thread Savinay Dharmappa
This patch fixes the traffic class oversubscription watermark value by initialising it with computed value of maximum watermark. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: sta...@dpdk.org Signed-off-by: Savinay Dharmappa Acked-by: Jasvinder Singh --- v3: update the title

[dpdk-dev] [PATCH] net/txgbe: fix param misusage when set rte flow error

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes parameter misusage when set rte flow action error. Fixes: b7eeecb17556 ("net/txgbe: parse n-tuple filter") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/txgbe/txgbe_flow.c | 2 +- 1 file changed, 1 inserti

[dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes e1000_write_nvm_srwr() alwayes return success. Fixes: 5a32a257f957 ("e1000: more NICs in base driver") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/e1000/base/e1000_i210.c | 2 ++ 1 file changed, 2 insert

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-20 Thread Huisong Li
Hi Kevin, Thank you for your review. This patchset has been applied to dpdk-next-net/main. I will send a new patch to fix it. Your suggestion is better.  I intend to use the following format: * Flow control info for port 0 * FC mode:     Rx pause: off

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread Min Hu (Connor)
在 2021/4/21 12:54, Li, Xiaoyun 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 12:37 To: Li, Xiaoyun ; dev@dpdk.org Cc: Yigit, Ferruh ; Wu, Jingjing Subject: Re: [PATCH 1/2] raw/ntb: check spad user index Hi, xiaoyun, 在 2021/4/21 11:31, Li, Xiaoyun 写

[dpdk-dev] [Bug 682] [dpdk-21.05]metering_and_policing: Invalid group ID: Invalid argument

2021-04-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=682 Bug ID: 682 Summary: [dpdk-21.05]metering_and_policing: Invalid group ID: Invalid argument Product: DPDK Version: unspecified Hardware: All OS: All Statu

[dpdk-dev] [PATCH v11] app/testpmd: support multi-process

2021-04-20 Thread Singh, Aman Deep
Tested-by: Aman Deep Singh mailto:aman.deep.si...@intel.com>>

Re: [dpdk-dev] [PATCH 4/4] examples/l3fwd: make data struct to be memory efficient

2021-04-20 Thread Hemant Agrawal
On 4/14/2021 12:36 AM, Jerin Jacob wrote: On Thu, Mar 18, 2021 at 3:56 PM Ruifeng Wang wrote: There are some holes in data struct lcore_conf. The holes are due to alignment requirement. For struct lcore_rx_queue, there is no need to make every element of this type to be cache line aligned, b

[dpdk-dev] [PATCH v1 3/3] net/i40e: enable PCI bus master after reset

2021-04-20 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. And align the VF reset event handling in device close mod

[dpdk-dev] [PATCH v1 2/3] net/iavf: enable PCI bus master after reset

2021-04-20 Thread Haiyue Wang
The VF reset can be triggerred by the PF reset event, in this case, the PCI bus master will be cleared, then the VF is not allowed to issue any Memory or I/O Requests. So after the reset event is detected, always enable the PCI bus master. Signed-off-by: Haiyue Wang --- drivers/net/iavf/iavf_et

[dpdk-dev] [PATCH v1 1/3] bus/pci: enable PCI master in command register

2021-04-20 Thread Haiyue Wang
This adds the support to set 'Bus Master Enable' bit in the PCI command register. Signed-off-by: Haiyue Wang --- drivers/bus/pci/pci_common.c | 20 drivers/bus/pci/rte_bus_pci.h | 12 drivers/bus/pci/version.map | 1 + lib/librte_pci/rte_pci.h | 4

[dpdk-dev] [PATCH v1 0/3] Fix PF reset causes VF memory request failure

2021-04-20 Thread Haiyue Wang
By triggerring the VF reset from PF reset, echo 1 > /sys/bus/pci/devices/PF-BDF/reset the PCI bus master bit will cleared on VF, so the VF needs to enable this bit before restart. This patch set adds the API to enable PCI bus master. Haiyue Wang (3): bus/pci: enable PCI master in comma

Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Xing, Beilei
> -Original Message- > From: Yang, MurphyX > Sent: Wednesday, April 21, 2021 11:44 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs > > Currently, F

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread Li, Xiaoyun
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 12:37 > To: Li, Xiaoyun ; dev@dpdk.org > Cc: Yigit, Ferruh ; Wu, Jingjing > > Subject: Re: [PATCH 1/2] raw/ntb: check spad user index > > Hi, xiaoyun, > > 在 2021/4/21 11:31, Li, Xiaoyun 写道: > > Hi > > > >

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread Min Hu (Connor)
Hi, xiaoyun, 在 2021/4/21 11:31, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 10:08 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun ; Wu, Jingjing Subject: [PATCH 1/2] raw/ntb: check spad user index From: Chengwen Feng This patch adds

[dpdk-dev] [PATCH v4 0/2] Support meter PPS(packet per second) in MLX5 PMD

2021-04-20 Thread Li Zhang
Currently meter algorithms only supports rate is bytes per second(BPS). Add packet_mode flag in meter profile parameters data structure. So that it can meter traffic by packet per second. Depends-on: series=16312 ("Support PPS(packet per second) on meter") https://patchwork.dpdk.org/project/dpdk/

[dpdk-dev] [PATCH v4 1/2] common/mlx5: add meter mode definition in PRM file

2021-04-20 Thread Li Zhang
Add meter mode definitions in PRM file Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index c6d8060bb9..efa5ae67bf 100644 --- a/drivers/c

[dpdk-dev] [PATCH v4 2/2] net/mlx5: support meter PPS profile

2021-04-20 Thread Li Zhang
Currently meter algorithms only supports bytes per second(BPS). Such as Single Rate Three Color Marker (srTCM rfc2697) Add packet_mode flag to support rate is packet per second. So that it can meter traffic by packet per second (PPS). Signed-off-by: Li Zhang Acked-by: Matan Azrad --- doc/guides

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread fengchengwen
On 2021/4/21 11:31, Li, Xiaoyun wrote: > Hi > >> -Original Message- >> From: Min Hu (Connor) >> Sent: Wednesday, April 21, 2021 10:08 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh ; Li, Xiaoyun >> ; >> Wu, Jingjing >> Subject: [PATCH 1/2] raw/ntb: check spad user index >> >> From: Chengwe

[dpdk-dev] [PATCH] examples/l3fwd-power: fix assignment errors

2021-04-20 Thread Min Hu (Connor)
From: HongBo Zheng Fix assignment errors of ep_hgh_edpi in function parse_ep_config. Fixes: a137d012a0dd ("examples/l3fwd-power: support traffic pattern aware control") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- examples/l3fwd-power/main.c | 4 ++-- 1

[dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Murphy Yang
Currently, FDIR doesn't work for all common PCTYPEs, the root cause is that input set is not configured. Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate") Signed-off-by: Murphy Yang --- drivers/net/i40e/i40e_fdir.c | 25 + 1 file changed, 13 i

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: add link speed check before port start

2021-04-20 Thread Min Hu (Connor)
在 2021/4/20 20:11, Ferruh Yigit 写道: On 4/19/2021 7:21 AM, Min Hu (Connor) wrote: From: Huisong Li Currently, to check whether the configured link_speeds is valid, we have to run "port start". In addition, if the configuration fails, "port->dev_conf.link_speeds" maintained in testpmd cannot

[dpdk-dev] [PATCH] net/txgbe: fix memset type error

2021-04-20 Thread Min Hu (Connor)
From: HongBo Zheng Fix memset type error in function txgbe_parse_rss_filter while clear rss_conf buffer. Fixes: 7a6d87fb8398 ("net/txgbe: parse RSS filter") Cc: sta...@dpdk.org Signed-off-by: HongBo Zheng Signed-off-by: Min Hu (Connor) --- drivers/net/txgbe/txgbe_flow.c | 2 +- 1 file change

Re: [dpdk-dev] [PATCH 2/2] raw/ntb: check malloc result

2021-04-20 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 10:08 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > ; > Wu, Jingjing > Subject: [PATCH 2/2] raw/ntb: check malloc result > > From: Chengwen Feng > > This patch adds checking for rte_zmalloc() r

Re: [dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread Li, Xiaoyun
Hi > -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 10:08 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Li, Xiaoyun > ; > Wu, Jingjing > Subject: [PATCH 1/2] raw/ntb: check spad user index > > From: Chengwen Feng > > This patch adds checking spad user index v

Re: [dpdk-dev] [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Xing, Beilei
> -Original Message- > From: Yang, MurphyX > Sent: Wednesday, April 21, 2021 10:09 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs > > Currently, F

[dpdk-dev] [PATCH] app/testpmd: support display queue state

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch supports display queue state in "show rxq/txq" commands. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- app/test-pmd/config.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c inde

[dpdk-dev] [PATCH v7 4/4] net/mlx5: connect meter policy to created flows

2021-04-20 Thread Li Zhang
From: Shun Hao Currently ASO meter must be followed by policy table, so this adds the support that connecting meter and policy table. There are several cases to be considered: 1. For non-termination policy, connect meter to the default policy table. 2. For non-RSS termination policy case, simply

[dpdk-dev] [PATCH v7 2/4] net/mlx5: support meter creation with policy

2021-04-20 Thread Li Zhang
Create a meter with the new pre-defined policy. The following cases to be considered: 1.Add entry match with meter_id in global drop table. 2.For non-termination policy (policy id 0), add jump rule to suffix table for green and jump rule to drop table for red. 3.Allocate counter per meter in d

[dpdk-dev] [PATCH v7 1/4] net/mlx5: support meter policy operations

2021-04-20 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

[dpdk-dev] [PATCH v7 3/4] net/mlx5: prepare sub-policy for a flow with meter

2021-04-20 Thread Li Zhang
When a flow has a RSS action, the driver splits each sub flow finally is configured with a different HW TIR action. Any RSS action configured in meter policy may cause a split in the flow configuration. To save performance, any TIR action will be configured in different flow table, so policy can b

[dpdk-dev] [PATCH v7 0/4] net/mlx5: support meter policy operations

2021-04-20 Thread Li Zhang
MLX5 PMD checks the validation of actions in policy while add a new meter policy, if pass the validation, allocates the new policy object from the meter policy indexed memory pool. It is common to use the same policy for multiple meters. MLX5 PMD supports two types of policy: termination policy an

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-20 Thread Li Zhang
Hi Stephen Thanks your comments. We already change it in the following series and please take a look: https://patchwork.dpdk.org/project/dpdk/list/?series=16524 + /** +* Color the packet to reflect the meter color result. +* Set the meter color in the mbuf to the selected col

[dpdk-dev] [PATCH] common/dpaax: fix possible null pointer access

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes possible null pointer access when dump iova table. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/common/dpaax/dpaax_iova_table.c |

Re: [dpdk-dev] [PATCH v5 1/2] test/power: add delay before checking cpuinfo cur freq

2021-04-20 Thread Richael Zhuang
> -Original Message- > From: David Hunt > Sent: Tuesday, April 20, 2021 8:39 PM > To: Richael Zhuang ; dev@dpdk.org > Cc: nd ; alan.ca...@intel.com; sta...@dpdk.org; Pablo de > Lara > Subject: Re: [PATCH v5 1/2] test/power: add delay before checking cpuinfo > cur freq > > > On 15/4/202

[dpdk-dev] [PATCH] examples/ethtool: remove redundant assignment

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng The new_mtu was assigned twice, the first assignment could be removed. Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- examples/ethtool/ethtool-app/eth

[dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-20 Thread Ferruh Yigit
From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes

Re: [dpdk-dev] [PATCH 2/2] eal: fix service core index validity

2021-04-20 Thread Stephen Hemminger
On Wed, 21 Apr 2021 09:17:17 +0800 "Min Hu (Connor)" wrote: > idx = strtoul(corelist, &end, 10); > if (errno || end == NULL) > return -1; > + if (idx < 0 || idx >= RTE_MAX_LCORE) Wondered at first how strtoul() could ever return an ne

[dpdk-dev] [PATCH 0/2] fixes for i40e PMD

2021-04-20 Thread Min Hu (Connor)
This patchset contains two fixes for i40e PMD. Chengwen Feng (2): net/i40e: fix veb index negative was not checked net/i40e: remove redundant judgment drivers/net/i40e/i40e_ethdev.c | 2 ++ drivers/net/i40e/i40e_rxtx.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.7.4

[dpdk-dev] [PATCH 2/2] net/i40e: remove redundant judgment

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng The vsi pointer is always valid, so it no need to judge it's validity. Fixes: b6583ee40265 ("i40e: full VMDQ pools support") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/i40e/i40e_rxtx.c | 2 -- 1 file changed, 2 deletion

[dpdk-dev] [PATCH 1/2] net/i40e: fix veb index negative was not checked

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking for veb index negative when parsing veb list. Fixes: 79f2248219c0 (net/i40e: add floating VEB option) Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 inse

[dpdk-dev] [PATCH v2] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-20 Thread Murphy Yang
Currently, FDIR doesn't work for all common PCTYPEs, the root cause is that input set is not configured. Fixes: 4a072ad43442 ("net/i40e: fix flow director config after flow validate") Signed-off-by: Murphy Yang --- v2: - tune the code and modify commit message drivers/net/i40e/i40e_fdir.c | 13 +

[dpdk-dev] [PATCH] net/kni: check rte kni init result

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking for rte_kni_init() result. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/kni/rte_eth_kni.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-

Re: [dpdk-dev] [PATCH] net/virtio: fix getline memory leakage

2021-04-20 Thread Xia, Chenbo
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 9:38 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; maxime.coque...@redhat.com; Xia, > Chenbo > Subject: [PATCH] net/virtio: fix getline memory leakage > > From: Chengwen Feng > > This patch fixes getline memor

[dpdk-dev] [PATCH 2/2] raw/ntb: check malloc result

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking for rte_zmalloc() result when init intel ntb device, also fix the same bug when start ntb device. Fixes: 034c328eb025 ("raw/ntb: support Intel NTB") Fixes: c39d1e082a4b ("raw/ntb: setup queues") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signe

[dpdk-dev] [PATCH 1/2] raw/ntb: check spad user index

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking spad user index validity when set or get attr. Fixes: 277310027965 ("raw/ntb: introduce NTB raw device driver") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/raw/ntb/ntb.c | 8 1 file changed,

[dpdk-dev] [PATCH 0/2] bugfix for raw ntb

2021-04-20 Thread Min Hu (Connor)
This patchset contains two bugfix for raw ntb. Chengwen Feng (2): raw/ntb: check spad user index raw/ntb: check malloc result drivers/raw/ntb/ntb.c | 13 + drivers/raw/ntb/ntb_hw_intel.c | 5 + 2 files changed, 18 insertions(+) -- 2.7.4

Re: [dpdk-dev] [PATCH v2 09/16] drivers: change meson file tabs to spaces

2021-04-20 Thread Xu, Rosen
Hi, > -Original Message- > From: Richardson, Bruce > Sent: Tuesday, April 20, 2021 18:22 > To: dev@dpdk.org > Cc: Richardson, Bruce ; Chautru, Nicolas > ; Hemant Agrawal ; > Sachin Saxena ; Xu, Rosen > ; Stephen Hemminger ; > drivers/bus/ifpga/meson.build | 6 +- > drivers/ne

Re: [dpdk-dev] [PATCH] net/i40e: fix flow does not effect on uncustomed pctype

2021-04-20 Thread Xing, Beilei
> -Original Message- > From: Yang, MurphyX > Sent: Friday, April 16, 2021 10:20 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Xing, Beilei ; Yang, SteveX ; > Zhang, RobinX ; Yang, MurphyX > > Subject: [PATCH] net/i40e: fix flow does not effect on uncustomed pctype > > Uncust

Re: [dpdk-dev] [PATCH V4] app/testpmd: support Tx mbuf free on demand cmd

2021-04-20 Thread oulijun
在 2021/4/19 23:28, Ferruh Yigit 写道: On 4/19/2021 1:36 PM, Lijun Ou wrote: From: Chengwen Feng This patch support tx_done_cleanup command: tx_done_cleanup port (port_id) (queue_id) (free_cnt) Instead of creating a new root level, 'tx_done_cleanup' command, what do you think to use existi

[dpdk-dev] [PATCH] net/virtio: fix getline memory leakage

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes getline memory leakage when parsing dynamic major num. Fixes: 7d62bf6f54ba ("net/virtio: introduce vhost-vDPA backend type") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- drivers/net/virtio/virtio_user_ethdev.c | 3 ++

Re: [dpdk-dev] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call

2021-04-20 Thread Xia, Chenbo
Hi Maxime & Jiayu, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, April 20, 2021 5:40 PM > To: Hu, Jiayu ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Yinan ; Pai G, Sunil ; > Jiang, Cheng1 ; sta...@dpdk.org > Subject: Re: [PATCH v3 3/4] vhost: fix unnecessary vring_state_chan

[dpdk-dev] [PATCH 2/2] eal: fix service core index validity

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking for service core index validity when parsing service corelist. Fixes: 7dbd7a6413ef ("service: add -S corelist option") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_eal/common/eal_common_options.c |

[dpdk-dev] [PATCH 0/2] fix bugs for librte eal

2021-04-20 Thread Min Hu (Connor)
This patchset fixed some bugs for librte_eal. Chengwen Feng (2): eal: check mp reply result eal: fix service core index validity lib/librte_eal/common/eal_common_options.c | 2 ++ lib/librte_eal/common/malloc_mp.c | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.7.4

[dpdk-dev] [PATCH 1/2] eal: check mp reply result

2021-04-20 Thread Min Hu (Connor)
From: Chengwen Feng This patch adds checking for mp reply result in handle_sync(). Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- lib/librte_eal/common/malloc_mp.c | 4 +--- 1 file change

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 3/3] kni: fix kernel deadlock when using mlx devices

2021-04-20 Thread Thomas Monjalon
12/04/2021 16:35, Elad Nachman: > Hi, > > The new patch is fine by me. > > Tested several dozens restarts of our proprietary application without > apparent problem. Series applied, thanks.

Re: [dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning

2021-04-20 Thread Thomas Monjalon
20/04/2021 15:21, Kevin Traynor: > clang 12 gives a warning about string concatenation in arrays. > In this case, as it is a long string test the strings are concatenated. > Add parentheses to indicate this. > > $ clang --version > clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) > > [2556/2719]

Re: [dpdk-dev] [PATCH v2] config/arm: add support for Marvell CN10K

2021-04-20 Thread Thomas Monjalon
19/04/2021 22:39, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Add config support to cross compile for Marvell CN10K SoC. > Marvell CN10K SoC is based on ARM Neoverse N2 cores. > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Pavan Nikhilesh > Acked-by: Jerin Jacob > --- > v2 C

Re: [dpdk-dev] [PATCH v4 0/3] net/pcap: build on Windows

2021-04-20 Thread Thomas Monjalon
> Dmitry Kozlyuk (3): > eal/windows: add timespec_get shim for MinGW > net/pcap: move OS-dependent code to separate files > net/pcap: build on Windows Compilation is failing on FreeBSD 11: http://mails.dpdk.org/archives/test-report/2021-April/188997.html implicit declaration of funct

Re: [dpdk-dev] [PATCH] mem: fix cleanup after incomplete initialization

2021-04-20 Thread Thomas Monjalon
20/04/2021 18:49, Burakov, Anatoly: > On 09-Apr-21 6:16 PM, Dmitry Kozlyuk wrote: > > In case of EAL initialization failure rte_eal_memory_detach() may be > > called before mapping memory configuration, which in this case points > > to the static structure. Attempt to unmap it yields error: > > >

Re: [dpdk-dev] [PATCH v5 0/5] Predictable RSS feature

2021-04-20 Thread Thomas Monjalon
19/04/2021 17:59, Vladimir Medvedkin: > Vladimir Medvedkin (5): > hash: add predictable RSS API > hash: add predictable RSS implementation > test/hash: add additional thash tests > doc: add thash documentation > maintainers: claim maintainership of the hash library I kept the doc of the

Re: [dpdk-dev] [PATCH v10 2/2] app/testpmd: support policy actions per color

2021-04-20 Thread Ajit Khaparde
On Tue, Apr 20, 2021 at 7:05 AM Jiawei Wang wrote: > > From: Haifei Luo > > Add the create/del policy CLIs to support actions per color. > The CLIs are: > Create: add port meter policy (port_id) (policy_id) g_actions (actions) > y_actions (actions) r_actions (actions) > Delete: del port meter p

Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API

2021-04-20 Thread Ajit Khaparde
On Tue, Apr 20, 2021 at 7:05 AM Jiawei Wang wrote: > > From: Li Zhang > > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actio

[dpdk-dev] [PATCH 3/3] net/sfc: add more debug log statements to transfer flows

2021-04-20 Thread Ivan Malov
These are really helpful when it comes to tracking resource sharing and debugging various leaks. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_log.h | 8 + drivers/net/sfc/sfc_mae.c | 68 --- 2

[dpdk-dev] [PATCH 1/3] net/sfc: fix outer rule and encap. header rollback on errors

2021-04-20 Thread Ivan Malov
Add missing statements to invalidate MAE resource IDs. Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules") Fixes: 1bbd1ec2348a ("net/sfc: support action VXLAN encap in MAE backend") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by:

[dpdk-dev] [PATCH 2/3] net/sfc: revise FW RSRC free error logs in transfer rules

2021-04-20 Thread Ivan Malov
The current code simply forwards FW resource free failure to the application leaving the operation incomplete. This stalls the application and makes debugging very difficult. Make the driver proceed with handling FW resource free in the case of errors. Add explicit error logging statements. Signe

Re: [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined meter policy API

2021-04-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Asaf Penso > Sent: Tuesday, April 20, 2021 1:55 PM > To: Dumitrescu, Cristian ; Jiawei(Jonny) > Wang ; Matan Azrad ; Ori Kam > ; Slava Ovsiienko ; Shahaf > Shuler ; Wisam Monther ; Li, > Xiaoyun ; Singh, Jasvinder > ; NBU-Contact-Thomas Monjalon > ; Yigit, Fe

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Thomas Monjalon
12/04/2021 01:23, Cristian Dumitrescu: > Each table entry is made up of match fields and action data, with the > latter made up of the action ID and the action arguments. The approach > of having the user specify explicitly the endianness of the action > arguments is difficult to be picked up by P4

Re: [dpdk-dev] [PATCH v8 0/5] examples/l3fwd: add FIB lookup method to l3fwd

2021-04-20 Thread Thomas Monjalon
16/04/2021 19:19, Conor Walsh: > Conor Walsh (5): > examples/l3fwd: fix LPM IPv6 subnets > examples/l3fwd: move l3fwd routes to common header > examples/l3fwd: add FIB infrastructure > examples/l3fwd: implement FIB lookup method > doc/guides/l3_forward: update documentation for FIB Appli

[dpdk-dev] [Bug 681] DPDK 20.11.1 failed to build for x86 machine types

2021-04-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=681 Bug ID: 681 Summary: DPDK 20.11.1 failed to build for x86 machine types Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API

2021-04-20 Thread Stephen Hemminger
On Thu, 18 Mar 2021 10:58:14 +0200 Li Zhang wrote: > + > + /** > + * Color the packet to reflect the meter color result. > + * > + * See struct rte_flow_action_color. > + */ > + RTE_FLOW_ACTION_TYPE_COlOR, Why the odd use of lower case here? Shouldn't it be RTE_FLOW_A

Re: [dpdk-dev] [dpdk-ci] UNH-IOL ABI Failures

2021-04-20 Thread Brandon Lo
Okay, I am updating the ABI version on the machines and rerunning the affected patches. I had mistakenly installed libabigail 1.6 since that was the default in the linux-build.sh script. Thanks, Brandon On Tue, Apr 20, 2021 at 11:37 AM Thomas Monjalon wrote: > > 20/04/2021 17:30, Brandon Lo: > >

Re: [dpdk-dev] [PATCH] mem: fix cleanup after incomplete initialization

2021-04-20 Thread Burakov, Anatoly
On 09-Apr-21 6:16 PM, Dmitry Kozlyuk wrote: In case of EAL initialization failure rte_eal_memory_detach() may be called before mapping memory configuration, which in this case points to the static structure. Attempt to unmap it yields error: EAL: Could not unmap shared memory config: Invali

Re: [dpdk-dev] [dpdk-ci] UNH-IOL ABI Failures

2021-04-20 Thread Thomas Monjalon
20/04/2021 17:30, Brandon Lo: > Hi all, > > We have noticed some failures occurring repeatedly in our CI system > regarding the ABI test. > > I looked into the failures and saw that there were some failures > caused by a clock skew issue on the ARM ABI test. > Those failures have been rerun and t

[dpdk-dev] UNH-IOL ABI Failures

2021-04-20 Thread Brandon Lo
Hi all, We have noticed some failures occurring repeatedly in our CI system regarding the ABI test. I looked into the failures and saw that there were some failures caused by a clock skew issue on the ARM ABI test. Those failures have been rerun and the report will be resent to patchworks for the

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Aaron Conole
"Dumitrescu, Cristian" writes: >> -Original Message- >> From: Thomas Monjalon >> Sent: Tuesday, April 20, 2021 11:07 AM >> To: Dumitrescu, Cristian >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 20/04/2021 12:04, Dumit

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value

2021-04-20 Thread Luca Boccassi
On Tue, 2021-04-20 at 09:54 +, Zhang, Qi Z wrote: > > -Original Message- > > From: Yigit, Ferruh > > Sent: Tuesday, April 20, 2021 4:09 PM > > To: Zhang, Qi Z ; Xiaozhen Ban > > ; Guo, Jia ; Wang, Haiyue > > > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [dpdk-stable] [dpdk-de

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Thomas Monjalon
20/04/2021 16:20, Kevin Traynor: > On 20/04/2021 11:04, Thomas Monjalon wrote: > > 17/04/2021 09:39, Min Hu (Connor): > >> + if (eth_link == NULL) { > >> + RTE_ETHDEV_LOG(ERR, > >> + "Cannot get nowait ethdev port %u for NULL link\n", > >> + port_id); > >

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Kevin Traynor
On 20/04/2021 11:04, Thomas Monjalon wrote: > Thanks for the work. > Few last comments below. > > 17/04/2021 09:39, Min Hu (Connor): >> @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, >> const char *devargs_str) >> uint16_t >> rte_eth_iterator_next(struct rte_dev_itera

Re: [dpdk-dev] [PATCH v9 0/2] Support meter policy API

2021-04-20 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, April 20, 2021 7:37 PM > To: Jiawei(Jonny) Wang ; Matan Azrad > ; Ori Kam ; Slava Ovsiienko > ; Shahaf Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Raslan Darawsheh ; Roni > Bar Yanai > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] net/ice: fix disabling of promisc mode (keep allmulti state)

2021-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Siwar Zitouni > Sent: Monday, April 19, 2021 8:54 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Lu, Wenzhuo ; Siwar Zitouni > ; sta...@dpdk.org; Thibaut Collet > > Subject: [PATCH] net/ice: fix disabling of promisc mode (keep allmulti state) >

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-20 Thread Chengchang Tang
On 2021/4/20 21:18, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Chengchang Tang >> Sent: Tuesday, April 20, 2021 1:44 PM >> To: Ananyev, Konstantin ; Yigit, Ferruh >> ; dev@dpdk.org >> Cc: linux...@huawei.com; ch...@att.com; humi...@huawei.com >> Subject: Re: [dpdk-

[dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API

2021-04-20 Thread Jiawei Wang
From: Li Zhang Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use vari

[dpdk-dev] [PATCH v10 2/2] app/testpmd: support policy actions per color

2021-04-20 Thread Jiawei Wang
From: Haifei Luo Add the create/del policy CLIs to support actions per color. The CLIs are: Create: add port meter policy (port_id) (policy_id) g_actions (actions) y_actions (actions) r_actions (actions) Delete: del port meter policy (port_id) (policy_id) Examples: testpmd> add port meter poli

[dpdk-dev] [PATCH v10 0/2] Support meter policy API

2021-04-20 Thread Jiawei Wang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe

Re: [dpdk-dev] [PATCH v5 2/2] test/power: round cpuinfo cur freq value in cpufreq autotest

2021-04-20 Thread David Hunt
On 15/4/2021 6:59 AM, Richael Zhuang wrote: The value in "/sys/.../cpuinfo_cur_freq" may not be exactly the same as what was set. For example, if "240" is written to "/sys/.../cpufreq/scaling_setspeed" to set the frequency, then the value in "/sys/.../cpuinfo_cur_freq" may be "2401222". So

Re: [dpdk-dev] [PATCH v3] net/i40e: add Tx preparation for simple Tx data path

2021-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, April 20, 2021 4:03 PM > To: Rong, Leyi ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH v3] net/i40e: add Tx preparation for simple Tx data path > > > > Introduce i40e_simple_prep_pkts() as the preparation funct

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Ferruh Yigit
On 4/20/2021 11:04 AM, Thomas Monjalon wrote: Thanks for the work. Few last comments below. 17/04/2021 09:39, Min Hu (Connor): @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str) uint16_t rte_eth_iterator_next(struct rte_dev_iterator *iter)

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-04-20 Thread Thomas Monjalon
20/04/2021 12:36, Singh, Jasvinder: > From: Thomas Monjalon > > > > Ping > > > > 23/03/2021 17:02, Thomas Monjalon: > > > 09/03/2021 17:10, Savinay Dharmappa: > > > > tc ov watermark is initialized with computed value of max tc ov > > > > watermark. > > > > > > Sorry I don't understand what the

[dpdk-dev] [PATCH v2 2/2] app/test: silence clang 12 warning

2021-04-20 Thread Kevin Traynor
clang 12 gives a warning about string concatenation in arrays. In this case, as it is a long string test the strings are concatenated. Add parentheses to indicate this. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2556/2719] Compiling C object app/test/dpdk-test.p/test_cmd

[dpdk-dev] [PATCH v2 1/2] app/test: fix clang 12 warning

2021-04-20 Thread Kevin Traynor
clang 12 gives a warning about string concatenation in arrays. In this case it looks like it was unintentional to concatenate the strings. Separate with a comma. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2557/2719] Compiling C object app/test/dpdk-test.p/test_cmdline_ip

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-20 Thread Ananyev, Konstantin
> -Original Message- > From: Chengchang Tang > Sent: Tuesday, April 20, 2021 1:44 PM > To: Ananyev, Konstantin ; Yigit, Ferruh > ; dev@dpdk.org > Cc: linux...@huawei.com; ch...@att.com; humi...@huawei.com > Subject: Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device > >

Re: [dpdk-dev] [PATCH v5 1/2] test/power: add delay before checking cpuinfo cur freq

2021-04-20 Thread David Hunt
On 20/4/2021 1:38 PM, David Hunt wrote: On 15/4/2021 6:59 AM, Richael Zhuang wrote: For some platforms the newly-set frequency may not be effective immediately. If we didn't get the right value from cpuinfo_cur_freq immediately, add 10ms delay each time before rechecking until timeout.  From

[dpdk-dev] [PATCH 2/2] app/test: silence clang 12 warning

2021-04-20 Thread Kevin Traynor
clang 12 gives a warning about string size. In this case it is a long string test. Add parentheses to indicate this. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2556/2719] Compiling C object app/test/dpdk-test.p/test_cmdline_num.c.o ../app/test/test_cmdline_num.c:204:5: w

[dpdk-dev] [PATCH 1/2] app/test: fix clang 12 warning

2021-04-20 Thread Kevin Traynor
clang 12 gives a warning about string size. In this case it looks like it was unintentional to concatenate the strings. Separate with a comma. $ clang --version clang version 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34) [2557/2719] Compiling C object app/test/dpdk-test.p/test_cmdline_ipaddr.c.o ../app/tes

Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-20 Thread Bing Zhao
Hi Lingyu, > -Original Message- > From: dev On Behalf Of Liu, Lingyu > Sent: Tuesday, April 20, 2021 10:17 AM > To: Olivier Matz > Cc: dev@dpdk.org; Zhang, Qi Z ; NBU-Contact- > Thomas Monjalon ; david.march...@redhat.com; > Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: supp

  1   2   3   >