[dpdk-dev] [PATCH v2 1/3] examples/flow_classify: fix check of port and core

2021-04-21 Thread Min Hu (Connor)
According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -w :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v2 2/3] examples/l2fwd-cat: fix check of port and core

2021-04-21 Thread Min Hu (Connor)
According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -w :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v2 0/3] fix check of port and core

2021-04-21 Thread Min Hu (Connor)
Currently, some examples check that the port is on the same NUMA node as the polling thread for best performance. The method is to compare the socket id of port and that of current core. If the result is different, warning info will be given. But it ignores the port which is from numa node 0, that

[dpdk-dev] [PATCH v2 3/3] examples/skeleton: fix check of port and core

2021-04-21 Thread Min Hu (Connor)
According to the comments and logging, the author just hope user to use the core and device which are in the same numa node for optimal performance. If not, A warning gives out. For example in flow_classify: ./build/flow_classify -w :7d:00.1 -l 93 Here: :7d:00.1 is on numa node 0. core 93

[dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes e1000_write_nvm_srwr() alwayes return success. Fixes: 5a32a257f957 ("e1000: more NICs in base driver") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- v2: * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'. --- drivers/net/e1

[dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng This patch fixes e1000_write_nvm_srwr() alwayes return success. Fixes: 5a32a257f957 ("e1000: more NICs in base driver") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- v2: * change 'E1000_ERR_NVM' to '-E1000_ERR_NVM'. --- drivers/net/e1

Re: [dpdk-dev] [PATCH] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Min Hu (Connor)
在 2021/4/21 14:56, Wang, Haiyue 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 14:22 To: dev@dpdk.org Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue Subject: [PATCH] net/e1000: fix write NVM srwr alwayes return success From: Chengwen Feng This patch fix

[dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-21 Thread Joyce Kong
Convert rte_atomic usages to C11 atomic builtins for lcores sync in ticketlock testcases. Signed-off-by: Joyce Kong Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test/test_ticketlock.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/test/t

Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Wang, Haiyue
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 15:12 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ; > Wang, Haiyue > > Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success > > From: Chengwen Feng > > This patch fixes e1000_write

Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Min Hu (Connor)
在 2021/4/21 15:18, Wang, Haiyue 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 15:12 To: dev@dpdk.org Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success From: Chengwen Feng This patch

Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Wang, Haiyue
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 15:12 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ; > Wang, Haiyue > > Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success > > From: Chengwen Feng > > This patch fixes e1000_write

[dpdk-dev] [Bug 683] librte_pipeline build failures on CentOS 7

2021-04-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=683 Bug ID: 683 Summary: librte_pipeline build failures on CentOS 7 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v5] vhost: allocate and free packets in bulk in Tx packed

2021-04-21 Thread Maxime Coquelin
On 4/16/21 12:25 PM, Balazs Nemeth wrote: > Move allocation out further and perform all allocation in bulk. The same > goes for freeing packets. In the process, also introduce > virtio_dev_pktmbuf_prep and make virtio_dev_pktmbuf_alloc use that. > > Signed-off-by: Balazs Nemeth > --- > lib/li

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Ali Alnubani
Hi, > -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Tuesday, April 20, 2021 10:58 PM > To: Cristian Dumitrescu > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > 12/04/2021 01:23, Cristian Dumitrescu: > > E

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 7:18 AM, Huisong Li wrote: Hi Kevin, Thank you for your review. This patchset has been applied to dpdk-next-net/main. I will send a new patch to fix it. Your suggestion is better.  I intend to use the following format: * Flow control info for port 0

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 8:56 AM, Ferruh Yigit wrote: On 4/21/2021 7:18 AM, Huisong Li wrote: Hi Kevin, Thank you for your review. This patchset has been applied to dpdk-next-net/main. I will send a new patch to fix it. Your suggestion is better.  I intend to use the following format:

[dpdk-dev] [PATCH V5] app/test-pmd: support cleanup txq mbufs command

2021-04-21 Thread Lijun Ou
From: Chengwen Feng This patch supports cleanup txq mbufs command: port cleanup (port_id) txq (queue_id) (free_cnt) Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- V4->V5: - rewrite patch title - define the new cmd. - Fix the comments given by Ferruh.yigit V3->V4: - revert the V3 sch

[dpdk-dev] [PATCH] net/mlx5: fix probing the device in legacy bonding mode

2021-04-21 Thread Viacheslav Ovsiienko
If the device was configured as legacy bond one (without involving E-Switch), the mlx5 PMD erroneously tried to deduce the vport index raising the fatal error and preventing device from being used. The patch checks whether there is E-Switch present and we should use vport index indeed. Fixes: 2eb

Re: [dpdk-dev] [PATCH V5] app/test-pmd: support cleanup txq mbufs command

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 9:09 AM, Lijun Ou wrote: From: Chengwen Feng This patch supports cleanup txq mbufs command: port cleanup (port_id) txq (queue_id) (free_cnt) Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- V4->V5: - rewrite patch title - define the new cmd. - Fix the comments given by F

Re: [dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD

2021-04-21 Thread Ferruh Yigit
On 4/20/2021 11:55 AM, Jiawei Wang wrote: To support more meters and better performance, MLX HW provides ASO (Advanced Steering Operation) flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the

Re: [dpdk-dev] [PATCH V5] app/test-pmd: support cleanup txq mbufs command

2021-04-21 Thread oulijun
在 2021/4/21 16:15, Ferruh Yigit 写道: On 4/21/2021 9:09 AM, Lijun Ou wrote: From: Chengwen Feng This patch supports cleanup txq mbufs command: port cleanup (port_id) txq (queue_id) (free_cnt) Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- V4->V5: - rewrite patch title - define th

Re: [dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD

2021-04-21 Thread Asaf Penso
>-Original Message- >From: Ferruh Yigit >Sent: Wednesday, April 21, 2021 11:32 AM >To: Jiawei(Jonny) Wang ; Matan Azrad >; Ori Kam ; Slava Ovsiienko >; NBU-Contact-Thomas Monjalon > >Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso > >Subject: Re: [PATCH v6 00/15] Add ASO meter support in M

[dpdk-dev] [PATCH v12] app/testpmd: support multi-process

2021-04-21 Thread Min Hu (Connor)
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --num-procs=

Re: [dpdk-dev] [PATCH v5] build: use platform option for generic and native

2021-04-21 Thread Juraj Linkeš
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 10:36 AM > To: Juraj Linkeš > Cc: david.march...@redhat.com; bruce.richard...@intel.com; > honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; dev@dpdk.org > Subject: Re: [PATCH v5] build: use platform option f

[dpdk-dev] [PATCH V6] app/test-pmd: support cleanup txq mbufs command

2021-04-21 Thread Lijun Ou
From: Chengwen Feng This patch supports cleanup txq mbufs command: port cleanup (port_id) txq (queue_id) (free_cnt) Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou --- V5->V6: - use Tx/Rx instead of RX/TX - update 'cmd_help_long_parsed' V4->V5: - rewrite patch title - define the new cmd.

[dpdk-dev] [PATCH v16 0/8] aarch64 -> aarch32 cross compilation support

2021-04-21 Thread Juraj Linkeš
Add support for aarch32 cross build in meson and add aarch64 -> aarch32 cross build to Travis. Aarch32 is an execution state that allows execution of 32-bit code on armv8 machines. This execution state contains a superset of previous armv7 32-bit instructions and features. Thus the aarch32 build i

[dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Juraj Linkeš
From: Ruifeng Wang The sfc PMD was enabled for aarch32 which is 32-bit mode but has cpu_family set to aarch64. As sfc support only 64-bit system, it should be disabled for aarch32. Updated meson file to disable sfc for aarch32 build. Fixes: 141d2870675a ("net/sfc: support aarch64 architecture")

[dpdk-dev] [PATCH v16 2/8] net/bnxt: fix aarch32 build

2021-04-21 Thread Juraj Linkeš
From: Ruifeng Wang NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector im

[dpdk-dev] [PATCH v16 3/8] net/virtio: fix aarch32 build

2021-04-21 Thread Juraj Linkeš
NEON vector path of the PMD needs aarch64 support. But it was enabled for aarch32 build as well because aarch32 build had cpu_family set to aarch64. So build for aarch32 will fail due to unsupported intrinsics. Fix aarch32 build by updating meson file to exclude NEON vector implementation for aarc

[dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags

2021-04-21 Thread Juraj Linkeš
There are two execution states on armv8 architecture, aarch64 and aarch32. Add PLATFORM_STR for the latter and update RTE_ARCH_* flags according to e9b97392640. Signed-off-by: Juraj Linkeš --- lib/librte_eal/arm/include/rte_cpuflags_32.h | 1 + lib/librte_eal/arm/rte_cpuflags.c| 9 ++

[dpdk-dev] [PATCH v16 6/8] build: add aarch32 to meson cross-compilation

2021-04-21 Thread Juraj Linkeš
Create meson cross file arm32_armv8a_linux_gcc. Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/arm32_armv8a_linux_gcc | 17 + 1 file changed, 1

[dpdk-dev] [PATCH v16 5/8] build: add aarch32 meson build flags

2021-04-21 Thread Juraj Linkeš
Add aarch32 extra build flags and aarch32 machine flags to generic machine args. Also modify how arm flags are updated in meson build - for 32-bit build, update only if cross-compiling. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- config/arm/meson.build | 32 ++

[dpdk-dev] [PATCH v16 7/8] ci: add aarch64 -> aarch32 cross compiling jobs

2021-04-21 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32-bit arm binaries executable on armv8-a, but not armv7. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Acked-by: Aaron Conole --- .ci/linux-build.sh | 7 ++- .travis.yml

[dpdk-dev] [PATCH v16 8/8] doc: add aarch32 build guidance

2021-04-21 Thread Juraj Linkeš
From: Phil Yang Add cross-compiling guidance for 32-bit aarch32 DPDK on aarch64 host. Signed-off-by: Phil Yang Acked-by: Ruifeng Wang Acked-by: Aaron Conole --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 38 +++ 1 file changed, 31 insertions(+), 7 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 9:33 AM, Asaf Penso wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, April 21, 2021 11:32 AM To: Jiawei(Jonny) Wang ; Matan Azrad ; Ori Kam ; Slava Ovsiienko ; NBU-Contact-Thomas Monjalon Cc: dev@dpdk.org; Raslan Darawsheh ; Asaf Penso Subject: Re: [PATCH v6 0

Re: [dpdk-dev] [PATCH v6 15/15] doc: update release notes for ASO meter

2021-04-21 Thread Ferruh Yigit
On 4/20/2021 11:55 AM, Jiawei Wang wrote: This patches updates the release notes for ASO meter supports. MLX5 PMD can scale the meter usage from 4K to millions with this feature. Signed-off-by: Jiawei Wang doc update squashed to 12/15 in next-net, preferred to have doc update with patch.

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 11:50 AM, Juraj Linkeš wrote: > From: Ruifeng Wang > > The sfc PMD was enabled for aarch32 which is 32-bit mode but has > cpu_family set to aarch64. > As sfc support only 64-bit system, it should be disabled for aarch32. > > Updated meson file to disable sfc for aarch32 build. > > Fi

Re: [dpdk-dev] [PATCH v11] app/testpmd: support multi-process

2021-04-21 Thread Min Hu (Connor)
Hi, Ferruh, 在 2021/4/19 21:42, Ferruh Yigit 写道: On 4/19/2021 2:03 AM, Min Hu (Connor) wrote: This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the

[dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Conor Walsh
Currently the documentation describes how to add code snippets to the docs using code blocks. This can be problematic as the code snippets in the docs may fall out of sync with the actual code it is referencing within DPDK. This patch adds instructions to the contribution guide about how to include

[dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write

2021-04-21 Thread Min Hu (Connor)
From: Chengwen Feng This fixes the timed out for shadow RAM write EEWR can't be detected. Fixes: 5a32a257f957 ("e1000: more NICs in base driver") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) --- v3: * update commit info. v2: * change 'E1000_ERR_NVM' to '-E1

Re: [dpdk-dev] [PATCH v2] net/e1000: fix write NVM srwr alwayes return success

2021-04-21 Thread Min Hu (Connor)
Hi, 在 2021/4/21 15:34, Wang, Haiyue 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 21, 2021 15:12 To: dev@dpdk.org Cc: Yigit, Ferruh ; Guo, Jia ; Wang, Haiyue Subject: [PATCH v2] net/e1000: fix write NVM srwr alwayes return success From: Chengwen Feng This patc

Re: [dpdk-dev] [PATCH v16 3/8] net/virtio: fix aarch32 build

2021-04-21 Thread Maxime Coquelin
On 4/21/21 10:50 AM, Juraj Linkeš wrote: > NEON vector path of the PMD needs aarch64 support. But it was > enabled for aarch32 build as well because aarch32 build had > cpu_family set to aarch64. So build for aarch32 will fail due > to unsupported intrinsics. > > Fix aarch32 build by updating m

[dpdk-dev] [PATCH v3] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Min Hu (Connor)
From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- v3: * fixed the print format of link flow ctrl, and removes redundant port number ve

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Min Hu (Connor)
在 2021/4/21 16:05, Ferruh Yigit 写道: On 4/21/2021 8:56 AM, Ferruh Yigit wrote: On 4/21/2021 7:18 AM, Huisong Li wrote: Hi Kevin, Thank you for your review. This patchset has been applied to dpdk-next-net/main. I will send a new patch to fix it. Your suggestion is better.  I intend to use

[dpdk-dev] [PATCH v12] app/testpmd: support multi-process

2021-04-21 Thread Singh, Aman Deep
This patch adds multi-process support for testpmd. The test cmd example as follows: the primary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ --rxq=4 --txq=4 --num-procs=2 --proc-id=0 the secondary cmd: ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ --rxq=4 --txq=4 --nu

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Ruifeng Wang
> -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, April 21, 2021 5:05 PM > To: Juraj Linkeš ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; Ruifeng Wang ; > arybche...@solarfl

[dpdk-dev] [PATCH] pipeline: fix build with gcc 4.8.5

2021-04-21 Thread Ali Alnubani
Compilation on CentOS 7 with gcc version 4.8.5 fails with the following errors: ``` ... error: 'src_struct_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] ... error: 'dst_struct_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] ... ``` This p

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Mcnamara, John
> -Original Message- > From: Walsh, Conor > Sent: Wednesday, April 21, 2021 10:12 AM > To: Mcnamara, John ; tho...@monjalon.net; > david.march...@redhat.com; Yigit, Ferruh ; > Richardson, Bruce ; Burakov, Anatoly > > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH] doc/contributing/docu

Re: [dpdk-dev] [PATCH v10 0/2] Support meter policy API

2021-04-21 Thread Ferruh Yigit
On 4/20/2021 3:04 PM, Jiawei Wang wrote: Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potentia

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Thomas Monjalon
21/04/2021 12:21, Mcnamara, John: > From: Walsh, Conor > > Currently the documentation describes how to add code snippets to the docs > > using code blocks. This can be problematic as the code snippets in the > > docs may fall out of sync with the actual code it is referencing within > > DPDK. Thi

Re: [dpdk-dev] [PATCH v2 6/7] telemetry: support set init threads name

2021-04-21 Thread Bruce Richardson
On Sat, Apr 17, 2021 at 05:09:47PM +0800, Min Hu (Connor) wrote: > From: Chengwen Feng > > This patch supports set init threads name which is helpful for > debugging. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 1/3] net/sfc: fix outer rule and encap. header rollback on errors

2021-04-21 Thread Ferruh Yigit
On 4/20/2021 10:10 PM, Ivan Malov wrote: Add missing statements to invalidate MAE resource IDs. Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules") Fixes: 1bbd1ec2348a ("net/sfc: support action VXLAN encap in MAE backend") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov R

Re: [dpdk-dev] [PATCH] pipeline: fix build with gcc 4.8.5

2021-04-21 Thread Thomas Monjalon
21/04/2021 12:06, Ali Alnubani: > Compilation on CentOS 7 with gcc version 4.8.5 fails with > the following errors: > ``` > ... > error: 'src_struct_id' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > ... > error: 'dst_struct_id' may be used uninitialized in this > func

[dpdk-dev] [PATCH] examples/vm_power_manager: remove vm channel number check

2021-04-21 Thread Reshma Pattan
VM channel number should not be validated against the host vm_power_manager coremask core indexes, as VM cores need not to be same as host cores. So remove this check, to allow all the vm channels to be added successfully. Fixes: b49c677a0d24 ("examples/vm_power: respect core mask") Cc: david.h...

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Thomas Monjalon
21/04/2021 04:36, Ferruh Yigit: > From: "Min Hu (Connor)" > > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 0366137722a

[dpdk-dev] Minutes of Technical Board Meeting, 2021-03-24

2021-04-21 Thread Jerin Jacob Kollanukkaran
Minutes of Technical Board Meeting, 2021-03-24 Members Attending - -Bruce -Ferruh -Hemant -Honnappa -Jerin (Chair) -Kevin -Konstantin -Maxime -Olivier -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are

Re: [dpdk-dev] [PATCH v3] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Kevin Traynor
On 21/04/2021 10:41, Min Hu (Connor) wrote: > From: Huisong Li > > This patch supports the query of the link flow control parameter > on a port. > > The command format is as follows: > show port flow_ctrl > Thanks Connor, Acked-by: Kevin Traynor > Signed-off-by: Huisong Li > Signed-off-by:

Re: [dpdk-dev] [PATCH v3] net/e1000: fix timed out for shadow RAM write

2021-04-21 Thread Wang, Haiyue
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 17:16 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ; > Wang, Haiyue > > Subject: [PATCH v3] net/e1000: fix timed out for shadow RAM write > > From: Chengwen Feng > > This fixes the timed out for shadow

Re: [dpdk-dev] [PATCH V6] app/test-pmd: support cleanup txq mbufs command

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 9:45 AM, Lijun Ou wrote: From: Chengwen Feng This patch supports cleanup txq mbufs command: port cleanup (port_id) txq (queue_id) (free_cnt) Signed-off-by: Chengwen Feng Signed-off-by: Lijun Ou Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 5:36 AM, Ferruh Yigit wrote: > From: "Min Hu (Connor)" > > This patch adds more sanity checks in control path APIs. > > Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") > Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and > variables") > Fixes: 036

[dpdk-dev] [PATCH] bpf: delete meaningless code

2021-04-21 Thread Min Hu (Connor)
'rd->u.max = rd->u.max' is meaningless which should be deleted. This patch fixed it. Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- lib/librte_bpf/bpf_validate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[dpdk-dev] [PATCH] test/bpf: fix wrong error variable

2021-04-21 Thread Min Hu (Connor)
This patch fixed wrong error variable in logging message. Fixes: 83633ba23076 ("test/bpf: fix few small issues") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_bpf.c b/app/test/test_bpf

Re: [dpdk-dev] [PATCH v3] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:12 PM, Kevin Traynor wrote: On 21/04/2021 10:41, Min Hu (Connor) wrote: From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor

[dpdk-dev] [PATCH] app/testpmd: fix division by zero bug

2021-04-21 Thread Min Hu (Connor)
Variable total, which may be zero and result in segmentation fault. This patch fixed it. Fixes: 9b1249d9ff69 ("app/testpmd: support dumping socket memory") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test-pmd/cmdline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/t

Re: [dpdk-dev] [PATCH v3] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:36 PM, Ferruh Yigit wrote: On 4/21/2021 12:12 PM, Kevin Traynor wrote: On 21/04/2021 10:41, Min Hu (Connor) wrote: From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-b

Re: [dpdk-dev] [PATCH] test/bpf: fix wrong error variable

2021-04-21 Thread Ananyev, Konstantin
> -Original Message- > From: Min Hu (Connor) > Sent: Wednesday, April 21, 2021 12:37 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Ananyev, Konstantin > > Subject: [PATCH] test/bpf: fix wrong error variable > > This patch fixed wrong error variable in logging message. > > Fixes: 83633

Re: [dpdk-dev] [PATCH v3] app/testpmd: support the query of link flow ctrl info

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 10:41 AM, Min Hu (Connor) wrote: From: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) <...> @@ -258,6 +258,9 @@ static voi

Re: [dpdk-dev] [PATCH] bpf: delete meaningless code

2021-04-21 Thread Ananyev, Konstantin
> > 'rd->u.max = rd->u.max' is meaningless which should be deleted. > > This patch fixed it. > > Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") > Cc: sta...@dpdk.org As I remember, I did it on purpose. Some old (but still supported) version of clang complained about uni

Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error

2021-04-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Tuesday, April 20, 2021 10:31 AM > To: Zhang, AlvinX ; Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error > > > -Original Message- > > From: Zhan

Re: [dpdk-dev] [PATCH v1 0/3] Fix PF reset causes VF memory request failure

2021-04-21 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Wednesday, April 21, 2021 1:03 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Liang-min > ; Wang, Haiyue > Subject: [PATCH v1 0/3] Fix PF reset causes VF memory request failure > > By triggerring the VF reset from PF reset, > ec

Re: [dpdk-dev] [PATCH] bpf: delete meaningless code

2021-04-21 Thread Min Hu (Connor)
在 2021/4/21 19:43, Ananyev, Konstantin 写道: 'rd->u.max = rd->u.max' is meaningless which should be deleted. This patch fixed it. Fixes: 8021917293d0 ("bpf: add extra validation for input BPF program") Cc: sta...@dpdk.org As I remember, I did it on purpose. Some old (but still supported) ve

Re: [dpdk-dev] [PATCH] app/testpmd: support display queue state

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 4:24 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch supports display queue state in "show rxq/txq" commands. Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v2 00/16] Build file updates

2021-04-21 Thread Thomas Monjalon
20/04/2021 12:22, Bruce Richardson: > This set contains 5 changes/updates to the DPDK build and build files. > > The changes in this set are: > 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation > levels >in the foreach loops when building library or driver components. >

Re: [dpdk-dev] [PATCH] common/dpaax: fix possible null pointer access

2021-04-21 Thread Hemant Agrawal
On 4/21/2021 8:16 AM, Min Hu (Connor) wrote: From: Chengwen Feng This patch fixes possible null pointer access when dump iova table. Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Min Hu (Connor)

[dpdk-dev] [PATCH v10] ethdev: add sanity checks in control APIs

2021-04-21 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Min Hu (Connor)
Hi, fixed in v10, thanks. 在 2021/4/21 19:28, Andrew Rybchenko 写道: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify p

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Kevin Traynor
On 21/04/2021 12:28, Andrew Rybchenko wrote: > On 4/21/21 5:36 AM, Ferruh Yigit wrote: >> From: "Min Hu (Connor)" >> >> This patch adds more sanity checks in control path APIs. >> >> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") >> Fixes: 3d98f921fbe9 ("ethdev: unify prefix f

[dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Conor Walsh
The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first iteration") implemented a change to the em and lpm lookup methods to prevent the TX queue drain running in the first iteration of their packet processing loops. This patch introduces this change into the fib lookup method, this

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: > Hi, > >> -Original Message- >> From: dev On Behalf Of Thomas Monjalon >> Sent: Tuesday, April 20, 2021 10:58 PM >> To: Cristian Dumitrescu >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action args >> >> 12/04/202

Re: [dpdk-dev] [PATCH 00/14] Build file updates

2021-04-21 Thread Xueming(Steven) Li
> -Original Message- > From: Bruce Richardson > Sent: Monday, April 19, 2021 9:06 PM > To: Xueming(Steven) Li > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/14] Build file updates > > On Sun, Apr 18, 2021 at 08:45:25AM +, Xueming(Steven) Li wrote: > > Hi Bruce, > > > > > --

Re: [dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration

2021-04-21 Thread Ananyev, Konstantin
> The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first > iteration") implemented a change to the em and lpm lookup methods to > prevent the TX queue drain running in the first iteration of their > packet processing loops. This patch introduces this change into the > fib lookup met

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Ali Alnubani
> -Original Message- > From: Aaron Conole > Sent: Wednesday, April 21, 2021 3:57 PM > To: Ali Alnubani > Cc: NBU-Contact-Thomas Monjalon ; Cristian > Dumitrescu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > Ali Alnubani writes:

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static fun

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Aaron Conole
Ali Alnubani writes: >> -Original Message- >> From: Aaron Conole >> Sent: Wednesday, April 21, 2021 3:57 PM >> To: Ali Alnubani >> Cc: NBU-Contact-Thomas Monjalon ; Cristian >> Dumitrescu ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of >> action

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 2:19 PM, Ferruh Yigit wrote: On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f92

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 4:19 PM, Ferruh Yigit wrote: > On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: >> On 4/21/21 5:36 AM, Ferruh Yigit wrote: >>> From: "Min Hu (Connor)" >>> >>> This patch adds more sanity checks in control path APIs. >>> >>> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 4:40 PM, Ferruh Yigit wrote: > On 4/21/2021 2:19 PM, Ferruh Yigit wrote: >> On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: >>> On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1a

[dpdk-dev] [PATCH] pipeline: prevent some compiler warnings

2021-04-21 Thread Cristian Dumitrescu
Some older versions of the GCC compiler may trigger the -Werror=maybe-uninitialized warning if some local variables are not initialized. Signed-off-by: Cristian Dumitrescu --- lib/librte_pipeline/rte_swx_pipeline.c | 30 +- 1 file changed, 15 insertions(+), 15 deletions(-

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Ali Alnubani > Sent: Wednesday, April 21, 2021 8:50 AM > To: NBU-Contact-Thomas Monjalon ; Dumitrescu, > Cristian ; Aaron Conole > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > Hi, > > >

Re: [dpdk-dev] [PATCH v2 0/7] support set thread name

2021-04-21 Thread Thomas Monjalon
17/04/2021 11:09, Min Hu (Connor): > This set of patches support set thread name for debugging. > > Chengwen Feng (7): > net/ark: support set thread name > net/ice: support set VSI reset thread name > vdpa/ifc: support set notify and vring relay thread name > raw/ifpga: support set monitor

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Juraj Linkeš
> -Original Message- > From: Ruifeng Wang > Sent: Wednesday, April 21, 2021 12:06 PM > To: Andrew Rybchenko ; Juraj Linkeš > ; tho...@monjalon.net; > david.march...@redhat.com; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; arybche...@sola

Re: [dpdk-dev] [PATCH v9] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 12:28 PM, Andrew Rybchenko wrote: On 4/21/21 5:36 AM, Ferruh Yigit wrote: From: "Min Hu (Connor)" This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static fun

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 21, 2021 11:31 AM > To: Walsh, Conor ; david.march...@redhat.com; > Yigit, Ferruh ; Richardson, Bruce > ; Burakov, Anatoly > ; Mcnamara, John > Cc: dev@dpdk.org > Subject: Re: [PATCH] doc/contributing/documentation: a

Re: [dpdk-dev] [PATCH v10] ethdev: add sanity checks in control APIs

2021-04-21 Thread Ferruh Yigit
On 4/21/2021 1:36 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invali

Re: [dpdk-dev] [PATCH v16 1/8] net/sfc: fix aarch32 build

2021-04-21 Thread Andrew Rybchenko
On 4/21/21 5:08 PM, Juraj Linkeš wrote: > > >> -Original Message- >> From: Ruifeng Wang >> Sent: Wednesday, April 21, 2021 12:06 PM >> To: Andrew Rybchenko ; Juraj Linkeš >> ; tho...@monjalon.net; >> david.march...@redhat.com; bruce.richard...@intel.com; >> acon...@redhat.com; maicolgabr

Re: [dpdk-dev] [PATCH] doc/contributing/documentation: add info about including code

2021-04-21 Thread Thomas Monjalon
21/04/2021 16:17, Mcnamara, John: > From: Thomas Monjalon > > > > > > This is a very good suggestion and I think we should encourage doc > > > writers to use this when including code in the documentation. > > > > Yes, and we should try to clean-up existing code snippets. > > If there is no gener

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-21 Thread Ali Alnubani
Hi Cristian, > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, April 21, 2021 4:58 PM > To: Ali Alnubani ; NBU-Contact-Thomas Monjalon > ; Aaron Conole > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > > >

Re: [dpdk-dev] [PATCH v16 4/8] eal/arm: update CPU flags

2021-04-21 Thread Juraj Linkeš
Addining Jerin, Jan and Ruifeng > -Original Message- > From: Juraj Linkeš > Sent: Wednesday, April 21, 2021 10:50 AM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; acon...@redhat.com; > maicolgabr...@hotmail.com > Cc: Juraj Linkeš ; dev@dpdk.org > Subj

Re: [dpdk-dev] [PATCH v4 0/2] fix missing check for thread creation

2021-04-21 Thread Thomas Monjalon
> Chengwen Feng (2): > telemetry: fix missing check for thread creation > test: fix missing check for thread creation Applied, thanks

Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common PCTYPEs

2021-04-21 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Xing, Beilei > Sent: Wednesday, April 21, 2021 1:11 PM > To: Yang, MurphyX ; dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; > Yang, SteveX ; Zhang, RobinX > > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix FDIR issue for common > PCTYPEs >

  1   2   >