[dpdk-dev] [PATCH 3/4] net/bnxt: fix mismatched comparison

2021-04-30 Thread Ajit Khaparde
Fix comparison between uint16_t and uint32_t types. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr

[dpdk-dev] [PATCH 4/4] net/bnxt: fix ring count calculation

2021-04-30 Thread Ajit Khaparde
Fix ring count calculation for Thor. VNIC count does not have a direct bearing on the number of rings that can be used. Fixes: fe8dd26f86c78 ("net/bnxt: cap max Rx rings for Thor") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 18 ++ 1 file changed, 6 insertions(+),

[dpdk-dev] [PATCH 2/4] net/bnxt: fix unchecked return value

2021-04-30 Thread Ajit Khaparde
Return value where return value of rte_pci_read_config was not checked. Fix it. Coverity issue: 349919 Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnx

[dpdk-dev] [PATCH 0/4] bnxt PMD fixes

2021-04-30 Thread Ajit Khaparde
This patchset contains fixes to the bnxt PMD. Ajit Khaparde (4): net/bnxt: fix mismatched type comparison net/bnxt: fix unchecked return value net/bnxt: fix mismatched comparison net/bnxt: fix ring count calculation drivers/net/bnxt/bnxt.h| 18 ++ drivers/net/bnxt

[dpdk-dev] [PATCH 1/4] net/bnxt: fix mismatched type comparison

2021-04-30 Thread Ajit Khaparde
dev_info.max_mac_addrs is of type uint32_t. But the counter i is of type uint16_t. This mismatch may cause the loop condition may always be true. Change the loop counter variable to uint32_t. Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Cc: sta...@dpdk.org Signed-of

Re: [dpdk-dev] [PATCH v6 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-30 Thread Dmitry Kozlyuk
2021-04-29 19:39 (UTC-0700), Narcisa Ana Maria Vasile: > On Thu, Apr 29, 2021 at 03:50:38AM +0300, Dmitry Kozlyuk wrote: > > 2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > > > From: Narcisa Vasile [...] > > > (*key)->thread_index = TlsAlloc(); > > > if ((*key)->thread_index == TLS_

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 02/10] eal: add thread attributes

2021-04-30 Thread Dmitry Kozlyuk
2021-04-29 15:52 (UTC+), Tyler Retzlaff: > -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 29, 2021 12:48 AM > > > 29/04/2021 02:50, Dmitry Kozlyuk: > > > 2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > > > > +int > > > > +rte_thread_attr_init(rte_threa

[dpdk-dev] [RFC 1/1] app/testpmd: add l3fwd mode to testpmd

2021-04-30 Thread Kathleen Capella
Add l3fwd mode to testpmd to speed up debugging and performance analysis. Implement LPM lookup for single NUMA socket only. Signed-off-by: Kathleen Capella --- app/test-pmd/config.c | 66 +++ app/test-pmd/l3fwd.c | 356 ++ app/test-pmd/l3fwd.

[dpdk-dev] [RFC 0/1] app/testpmd: add l3fwd mode to testpmd

2021-04-30 Thread Kathleen Capella
Performance of the LPM mode in L3fwd example application is used as an industry standard to compare between various platforms. Unfortunately, L3fwd example application lacks debugging capabilities to understand the performance bottlenecks and fix them. While debugging performance issues we need a

Re: [dpdk-dev] [PATCH v3 0/7] test: refactor crypto unit test framework

2021-04-30 Thread Doherty, Declan
On 23/04/2021 5:18 PM, Ciara Power wrote: The current crypto unit test framework is not granular enough to accurately track unit test results. This is caused by one testcase in a suite actually running multiple testcases, but only returning one result. The approach taken in this patchset al

Re: [dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites

2021-04-30 Thread Doherty, Declan
On 23/04/2021 5:18 PM, Ciara Power wrote: The existing implementation runs a giant cryptodev testsuite for most autotests, which in turns runs one setup function regardless of device. This is now broken down into multiple testsuites, that are used as sub-testsuites. Each autotest runs a gener

Re: [dpdk-dev] How to disable SVE auto vectorization while using GCC

2021-04-30 Thread Honnappa Nagarahalli
> > On Fri, Apr 30, 2021 at 5:27 PM fengchengwen > wrote: > > > > Hi, ALL > > We have a question for your help: > > 1. We have two platforms, both of which are ARM64, one of which > supports > > both NEON and SVE, the other only support NEON. > > 2. We want to run on both platforms wit

Re: [dpdk-dev] [PATCH v6 08/10] eal: implement functions for thread barrier management

2021-04-30 Thread Dmitry Kozlyuk
2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > [...] > diff --git a/lib/librte_eal/include/rte_thread_types.h > b/lib/librte_eal/include/rte_thread_types.h > index 37bc7af2b..b055bbf67 100644 > --- a/lib/librte_eal/include/rte_thread_types.h > +++ b/lib/librte_eal/include/rte_thread_type

[dpdk-dev] [PATCH v9 09/10] app/testpmd: fix unused function warnings

2021-04-30 Thread Jie Zhou
Function print_fdir_mask and print_fdir_flex_payload is only called when either i40e or ixgbe presents. Add #if defined to remove "unused function" compilation warning. Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 82 +-- 1

[dpdk-dev] [PATCH v9 08/10] app/testpmd: fix headers inclusion

2021-04-30 Thread Jie Zhou
- Include rte_os_shim.h in testpmd.h - Remove redundant headers Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 3 --- app/test-pmd/cmdline_flow.c | 2 -- app/test-pmd/parameters.c | 1 - app/test-pmd/testpmd.h | 1 + 4 files changed, 1 insertion(+), 6 d

[dpdk-dev] [PATCH v9 05/10] app/testpmd: resolve name collisions

2021-04-30 Thread Jie Zhou
Resolve name collisions with Windows types Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline_flow.c | 512 ++-- 1 file changed, 256 insertions(+), 256 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c inde

[dpdk-dev] [PATCH v9 07/10] app/testpmd: replace POSIX specific code

2021-04-30 Thread Jie Zhou
- Make printf format OS independent - Replace htons with RTE_BE16 - Replace POSIX specific inet_aton with OS independent inet_pton - Replace sleep with rte_delay_us_sleep - Repalce random with rte_rand - #ifndef mman related code for now Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou ---

[dpdk-dev] [PATCH v9 10/10] app/testpmd: enable building testpmd on Windows

2021-04-30 Thread Jie Zhou
From: Jie Zhou - Disable unsupported Apps on Windows - Enable building of testpmd on Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/meson.build| 4 app/pdump/meson.build | 6 ++ app/proc-info/meson.build | 6 ++ app/test-

[dpdk-dev] [PATCH v9 06/10] app/testpmd: fix parse_fec_mode return type

2021-04-30 Thread Jie Zhou
Fix parse_fec_mode to return fec_capa instead of mode Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/cmdline.c | 6 +++--- app/test-pmd/config.c | 4 ++-- app/test-pmd/testpmd.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/ap

[dpdk-dev] [PATCH v9 04/10] eal/Windows: add clock_gettime on Windows

2021-04-30 Thread Jie Zhou
Add clock_gettime on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- app/test-pmd/config.c | 1 + lib/eal/windows/include/rte_os_shim.h | 38 +++ 2 files changed, 39 insertions(+) diff --git a/app/test-pmd/config.c b/app/tes

[dpdk-dev] [PATCH v9 03/10] eal/windows: add device event stubs

2021-04-30 Thread Jie Zhou
Add device event stubs in eal_dev.c for Windows Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/eal_dev.c | 33 + lib/eal/windows/meson.build | 1 + 2 files changed, 34 insertions(+) create mode 100644 lib/eal/windows/eal_dev.c diff --git

[dpdk-dev] [PATCH v9 00/10] app/testpmd: enable testpmd on Windows

2021-04-30 Thread Jie Zhou
This patchset is to enable testpmd on windows. It mainly includes: - Enable building libraries on Windows that testpmd depends on - Add necessary macros required by testpmd on Windows in rte_os_shim.h - Add device event stubs for Windows - Resolve name collisions with Windows types - Add clock_gett

[dpdk-dev] [PATCH v9 02/10] eal/windows: add necessary macros

2021-04-30 Thread Jie Zhou
Add required macros by testpmd on Windows in rte_os_shim.h Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/eal/windows/include/rte_os_shim.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h index

[dpdk-dev] [PATCH v9 01/10] lib: build libraries that testpmd depends on

2021-04-30 Thread Jie Zhou
Enable building libraries that testpmd depends on Signed-off-by: Jie Zhou Signed-off-by: Jie Zhou --- lib/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/meson.build b/lib/meson.build index c9a20f65b..2d499b238 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -76

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 06/10] eal: add thread lifetime management

2021-04-30 Thread Dmitry Kozlyuk
2021-04-30 20:22 (UTC+0300), Dmitry Kozlyuk: > 2021-04-29 21:31 (UTC+), Dmitry Malloy: > > [...] > > How about we defer fixing this to another follow-up change? > > I'm strictly against accepting code with known severe bugs. > > Alternative: > > 1. Don't add rte_thread_cancel() in public A

Re: [dpdk-dev] [PATCH v6 07/10] eal: implement functions for mutex management

2021-04-30 Thread Dmitry Kozlyuk
2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: [...] > diff --git a/lib/librte_eal/include/rte_thread_types.h > b/lib/librte_eal/include/rte_thread_types.h > index a884daf17..37bc7af2b 100644 > --- a/lib/librte_eal/include/rte_thread_types.h > +++ b/lib/librte_eal/include/rte_thread_types.

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v6 06/10] eal: add thread lifetime management

2021-04-30 Thread Dmitry Kozlyuk
2021-04-29 21:31 (UTC+), Dmitry Malloy: > Thread cancellation is a pain point. Emulating it properly is nearly > impossible (without hooking into various OS calls which are supposed to be > "cancellation points"). I do like the cancellation token idea, but I'm not > sure how existing clients, w

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers

2021-04-30 Thread Ivan Malov
Hi Ferruh, These changes are imported. Furthermore, originally, these files are auto-generated, so in order to fix spelling I can't just apply my edits to the imported changes. The fixes are to be made in the original source, and I believe this should be somehow discussed internally. So, the

Re: [dpdk-dev] How to disable SVE auto vectorization while using GCC

2021-04-30 Thread Stephen Hemminger
On Fri, 30 Apr 2021 20:41:13 +0530 Jerin Jacob wrote: > On Fri, Apr 30, 2021 at 5:27 PM fengchengwen wrote: > > > > Hi, ALL > > We have a question for your help: > > 1. We have two platforms, both of which are ARM64, one of which supports > > both NEON and SVE, the other only support NEON

Re: [dpdk-dev] [PATCH] net/sfc: fix mark support in EF100 native Rx datapath

2021-04-30 Thread Ferruh Yigit
On 4/28/2021 3:17 PM, Andrew Rybchenko wrote: > Decouple user mark from user flag. Usage of mark does not require to > use flag as well. Flag is not actually supported yet. > > Fixes: 1aacc3d388d3 ("net/sfc: support user mark and flag Rx for EF100") > Cc: stabledpdk.org Cc: sta...@dpdk.org >

Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers

2021-04-30 Thread Ferruh Yigit
On 4/28/2021 10:49 AM, Ivan Malov wrote: > From: Andrew Rybchenko > > Signed-off-by: Andrew Rybchenko > Signed-off-by: Ivan Malov > --- > drivers/common/sfc_efx/base/efx_regs_mcdi.h | 3509 +++-- > .../common/sfc_efx/base/efx_regs_mcdi_aoe.h | 142 +- > .../common/sfc_efx/base

Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync

2021-04-30 Thread Tyler Retzlaff
On Thu, Apr 29, 2021 at 09:10:04PM +, Honnappa Nagarahalli wrote: > > > > > > your subject line indicates the use of C11 which is a standard [1]. > > > > the patch itself uses gcc atomics builtins which are not part of C11 > > standard so > > the subject line is incorrect and misleading. >

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-30 Thread Ferruh Yigit
On 4/27/2021 2:57 PM, Olivier Matz wrote: > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() and > rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to > verify a packet containing a valid checksum. > > Since

Re: [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev

2021-04-30 Thread Pavan Nikhilesh Bhagavatula
+Cc: jay.jayatheert...@intel.com> >This patch set contains two bugfixes for lib eventdev. > >Chengwen Feng (2): > eventdev: remove redundant setting thread name > eventdev: fix memory leakage when create thread fail > > lib/eventdev/rte_event_eth_rx_adapter.c | 5 ++--- > 1 file changed, 2 inser

Re: [dpdk-dev] How to disable SVE auto vectorization while using GCC

2021-04-30 Thread Jerin Jacob
On Fri, Apr 30, 2021 at 5:27 PM fengchengwen wrote: > > Hi, ALL > We have a question for your help: > 1. We have two platforms, both of which are ARM64, one of which supports > both NEON and SVE, the other only support NEON. > 2. We want to run on both platforms with a single binary file,

[dpdk-dev] [PATCH v4 12/12] raw/ioat: report status of completed jobs

2021-04-30 Thread Bruce Richardson
Add improved error handling to rte_ioat_completed_ops(). This patch adds new parameters to the function to enable the user to track the completion status of each individual operation in a batch. With this addition, the function can help the user to determine firstly, how many operations may have fa

[dpdk-dev] [PATCH v4 11/12] raw/ioat: add API to query remaining ring space

2021-04-30 Thread Bruce Richardson
From: Kevin Laatz Add a new API to query remaining descriptor ring capacity. This API is useful, for example, when an application needs to enqueue a fragmented packet and wants to ensure that all segments of the packet will be enqueued together. Signed-off-by: Kevin Laatz Signed-off-by: Bruce R

[dpdk-dev] [PATCH v4 10/12] raw/ioat: rework SW ring layout

2021-04-30 Thread Bruce Richardson
The ring management in the idxd part of the driver is more complex than it needs to be, tracking individual batches in a ring and having null descriptors as padding to avoid having single-operation batches. This can be simplified by using a regular ring-based layout, with additional overflow at the

[dpdk-dev] [PATCH v4 09/12] raw/ioat: move idxd functions to separate file

2021-04-30 Thread Bruce Richardson
Split the rte_ioat_rawdev_fns.h file into two separate headers, so that the data structures for the original ioat devices and the newer idxd ones can be kept separate from each other. This makes code management and rework easier. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/meson.build

[dpdk-dev] [PATCH v4 08/12] raw/ioat: add bus driver for device scanning automatically

2021-04-30 Thread Bruce Richardson
Rather than using a vdev with args, DPDK can scan and initialize the devices automatically using a bus-type driver. This bus does not need to worry about registering device drivers, rather it can initialize the devices directly on probe. The device instances (queues) to use are detected from /dev

[dpdk-dev] [PATCH v4 07/12] raw/ioat: allow perform operations function to return error

2021-04-30 Thread Bruce Richardson
From: Kevin Laatz Change the return type for the rte_ioat_perform_ops() function from void to int to allow the possibility of returning an error code in future, should it be necessary. Signed-off-by: Kevin Laatz --- drivers/raw/ioat/rte_ioat_rawdev.h | 4 +++- drivers/raw/ioat/rte_ioat_ra

[dpdk-dev] [PATCH v4 06/12] raw/ioat: make workqueue name configurable in script

2021-04-30 Thread Bruce Richardson
Add a "--name-prefix" parameter to the quick configuration script for DSA. This allows the queues configured on a DSA instance to be made available to only one DPDK process in a setup with multiple DPDK process instances. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/dpdk_idxd_cfg.py | 9

[dpdk-dev] [PATCH v4 05/12] raw/ioat: fix script for configuring small number of queues

2021-04-30 Thread Bruce Richardson
The dpdk_idxd_cfg.py script included with the driver for convenience did not work properly where the number of queues to be configured was less than the number of groups or engines. This was because there would be configured groups/engines not assigned to queues. Fix this by limiting the engine and

[dpdk-dev] [PATCH v4 02/12] raw/ioat: support limiting queues for idxd PCI device

2021-04-30 Thread Bruce Richardson
When using a full device instance via vfio, allow the user to specify a maximum number of queues to configure rather than always using the max number of supported queues. Signed-off-by: Bruce Richardson --- doc/guides/rawdevs/ioat.rst | 8 drivers/raw/ioat/idxd_pci.c | 28 +

[dpdk-dev] [PATCH v4 04/12] raw/ioat: add explicit padding to descriptor struct

2021-04-30 Thread Bruce Richardson
Add an explicit padding field to the end of the descriptor structure so that when the batch descriptor is defined on the stack for perform-ops, the unused space is all zeroed appropriately. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/rte_ioat_rawdev_fns.h | 5 - 1 file changed, 4 in

[dpdk-dev] [PATCH v4 03/12] raw/ioat: add component prefix to log messages

2021-04-30 Thread Bruce Richardson
Add the driver prefix "IOAT" to log messages for the driver. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_private.h b/drivers/raw/ioat/ioat_private.h index 6c423811ec..f032d5fe3d 1006

[dpdk-dev] [PATCH v4 01/12] raw/ioat: add unit tests for completion batching

2021-04-30 Thread Bruce Richardson
Add in additional unit tests to verify that we can get completion reports of multiple batches in a single completed_ops() call. Also verify we can get smaller number of completions if that is requested too. Signed-off-by: Bruce Richardson --- drivers/raw/ioat/ioat_rawdev_test.c | 199 +++

[dpdk-dev] [PATCH v4 00/12] ioat driver updates

2021-04-30 Thread Bruce Richardson
This set contains a series of updates to the ioat driver, described in each of the individual patchsets. V4: fix issue with capacity unit test [due to missed line when rebasing to create v3 patchset] V3: fixed checkpatch issue flagged reworked capacity unit tests fixed ring wrap-a

Re: [dpdk-dev] [PATCH 2/3] common/sfc_efx/base: add MAE VLAN presence match bits

2021-04-30 Thread Kinsella, Ray
On 28/04/2021 10:49, Ivan Malov wrote: > Introduce necessary infrastructure for these fields to > be set, validated and compared during class comparison. > Enumeration and mappings envisaged are MCDI-compatible. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/4] net/tap: fix Rx cksum flags on IP options packets

2021-04-30 Thread Ferruh Yigit
On 4/27/2021 2:57 PM, Olivier Matz wrote: > When packet type is IPV4_EXT, the checksum is always marked as good in > the mbuf offload flags. > > Since we know the header lengths, we can easily call > rte_ipv4_udptcp_cksum() in this case too. > > Fixes: 8ae3023387e9 ("net/tap: add Rx/Tx checksum o

Re: [dpdk-dev] Use WFE for spinlock and ring

2021-04-30 Thread Bruce Richardson
On Fri, Apr 30, 2021 at 01:41:22PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality > > > > > > > > of 'polling for a memory location to become equal to a given > > value'[1]. > > > > > > > > > > > > > > > > Use th

[dpdk-dev] [PATCH v1] raw/ptdma: introduce ptdma driver

2021-04-30 Thread ssebasti
From: Selwin Sebastian Add support for PTDMA driver Signed-off-by: Selwin Sebastian --- MAINTAINERS | 5 + doc/guides/rawdevs/ptdma.rst | 220 + drivers/raw/meson.build | 1 + drivers/raw/ptdma/meson.build|

Re: [dpdk-dev] [PATCH] net/iavf: fix VLAN tag extraction handling in AVX512 path

2021-04-30 Thread Zhang, Qi Z
> -Original Message- > From: Sun, QinX > Sent: Thursday, April 29, 2021 2:45 PM > To: Rong, Leyi ; Zhang, Qi Z ; Lu, > Wenzhuo > Cc: dev@dpdk.org; Rong, Leyi > Subject: RE: [dpdk-dev] [PATCH] net/iavf: fix VLAN tag extraction handling in > AVX512 path > > > -Original Message-

Re: [dpdk-dev] [PATCH v2 0/6] net/ice: base update update batch 3

2021-04-30 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, April 30, 2021 9:59 PM > To: Yigit, Ferruh > Cc: Yang, Qiming ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH v2 0/6] net/ice: base update update batch 3 > > Add IP fragment support in base code and couple QinQ improvement. > u

Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3.

2021-04-30 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, April 30, 2021 7:57 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/6] net/ice: base update update batch 3. > > On 4/29/2021 1:41 AM, Qi Zhang wrote: > > Add IP fragment support in ba

[dpdk-dev] [PATCH v2 6/6] net/ice/base: support IP fragment RSS and FDIR

2021-04-30 Thread Qi Zhang
Add support for IP fragment RSS hash and FDIR function. Separate IP fragment and IP other packet types. The patch also update the release date in README. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo Signed-off-by: Qi Zhang Acked-by: Qi Zhang --- drivers/net/ice/base/README | 2 +- dri

[dpdk-dev] [PATCH v2 5/6] net/ice/base: sign external device package programming

2021-04-30 Thread Qi Zhang
External topology devices (e.g. PHYs) connected to 100G or to SoC that includes 100G IP might have a firmware engine within the device and the firmware is usually loaded from NVM connected to the topology device. The topology device NVM images can be updated using SW tools but such solution poses a

[dpdk-dev] [PATCH v2 4/6] net/ice/base: support L3 DSCP QoS

2021-04-30 Thread Qi Zhang
The base code support to build configuration TLVs in DSCP mode has not been implemented before, so the functions to do so and the flow control to determine if we are in VLAN or DSCP mode need to be added. The current value for maximum number of DCB APPs (ICE_DCBX_MAX_APPS) is not sufficient when s

[dpdk-dev] [PATCH v2 3/6] net/ice/base: add print if DDP/FW don't support QinQ as expected

2021-04-30 Thread Qi Zhang
Currently if the driver supports QinQ there is no message/information if the DDP and/or FW don't support QinQ. Add functionality that prints if the DDP and/or FW don't support QinQ if the driver attempts to configured DVM. This will make it more obvious to users in the field that they need to updat

[dpdk-dev] [PATCH v2 2/6] net/ice/base: add function for post DDP download VLAN mode configuration

2021-04-30 Thread Qi Zhang
Currently it's not clear that only the first PF downloads the package and configures the VLAN mode. When this is happening all other PFs are blocked on the global configuration lock. Once the package is successfully downloaded and the global configuration lock has been released then all PFs resume

[dpdk-dev] [PATCH v2 1/6] net/ice/base: add IP fragment flags

2021-04-30 Thread Qi Zhang
Add the IPv6 fragment flags and the IPv4 fragment field shift. Signed-off-by: Ting Xu Signed-off-by: Jeff Guo Signed-off-by: Qi Zhang Acked-by: Qiming Yang --- drivers/net/ice/base/ice_fdir.c | 2 +- drivers/net/ice/base/ice_fdir.h | 16 2 files changed, 13 insertions(+), 5

[dpdk-dev] [PATCH v2 0/6] net/ice: base update update batch 3

2021-04-30 Thread Qi Zhang
Add IP fragment support in base code and couple QinQ improvement. update the release date as the last base patch for DPDK 21.05. v2: - fix compile error in patch 2/6 - wrap long strin gin patch 3/6 - fix typo in patch 4/6 - fix title convetion in patch 4/6 and 5/6 Qi Zhang (6): net/ice/base: ad

[dpdk-dev] [PATCH v3 30/33] event/cnxk: add timer cancel function

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add function to cancel event timer that has been armed. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 1 + drivers/event/cnxk/cnxk_tim_evdev.h | 5 drivers/event/cnxk/cnxk_tim_worker.c | 30 ++

[dpdk-dev] [PATCH v3 29/33] event/cnxk: add timer arm timeout burst

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm timeout burst function. All the timers requested to be armed have the same timeout. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 7 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 12 +++ driver

[dpdk-dev] [PATCH v3 33/33] event/cnxk: add devargs to control timer adapters

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add devargs to control each event timer adapter i.e. TIM rings internal parameters uniquely. The following dict format is expected [ring-chnk_slots-disable_npa-stats_ena]. 0 represents default values. Example: --dev "0002:1e:00.0,tim_ring_ctl=[2-1023-1-0]" Signed-o

[dpdk-dev] [PATCH v3 32/33] event/cnxk: add timer adapter start and stop

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter start and stop functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 71 - 1 file changed, 70 insertions(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cn

[dpdk-dev] [PATCH v3 28/33] event/cnxk: add timer arm routine

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer arm routine. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.c | 18 ++ drivers/event/cnxk/cnxk_tim_evdev.h | 23 ++ drivers/event/cnxk/cnxk_tim_worker.c | 95 + drivers/event/cnxk/cnxk_tim_

[dpdk-dev] [PATCH v3 31/33] event/cnxk: add timer stats get and reset

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter statistics get and reset functions. Stats are disabled by default and can be enabled through devargs. Example: --dev "0002:1e:00.0,tim_stats_ena=1" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnx

[dpdk-dev] [PATCH v3 27/33] event/cnxk: add TIM bucket operations

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add TIM bucket operations used for event timer arm and cancel. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_tim_evdev.h | 30 +++ drivers/event/cnxk/cnxk_tim_worker.c | 6 ++ drivers/event/cnxk/cnxk_tim_worker.h | 123

[dpdk-dev] [PATCH v3 26/33] event/cnxk: add devargs for chunk size and rings

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add devargs to control default chunk size and max numbers of timer rings to attach to a given RVU PF. Example: --dev "0002:1e:00.0,tim_chnk_slots=1024" --dev "0002:1e:00.0,tim_rings_lmt=4" Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton ---

[dpdk-dev] [PATCH v3 25/33] event/cnxk: add timer adapter info function

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add TIM event timer adapter info get function. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_evdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c b/drivers/event/cn

[dpdk-dev] [PATCH v3 24/33] event/cnxk: allow adapters to resize inflights

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add internal SSO functions to allow event adapters to resize SSO buffers that are used to hold in-flight events in DRAM. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 33 drivers/event/cnxk/cnxk_

[dpdk-dev] [PATCH v3 23/33] event/cnxk: add devargs to disable NPA

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh If the chunks are allocated from NPA then TIM can automatically free them when traversing the list of chunks. Add devargs to disable NPA and use software mempool to manage chunks. Example: --dev "0002:0e:00.0,tim_disable_npa=1" Signed-off-by: Shijith Thotton Signe

[dpdk-dev] [PATCH v3 22/33] event/cnxk: create and free timer adapter

2021-04-30 Thread pbhagavatula
From: Shijith Thotton When the application calls timer adapter create the following is used: - Allocate a TIM LF based on number of LF's provisioned. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate

[dpdk-dev] [PATCH v3 21/33] event/cnxk: add timer adapter capabilities

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add function to retrieve event timer adapter capabilities. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_tim_evdev.c | 22 +++

[dpdk-dev] [PATCH v3 20/33] event/cnxk: support event timer

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add event timer adapter a.k.a TIM initialization on SSO probe. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- doc/guides/eventdevs/cnxk.rst | 6 drivers/event/cnxk/cnxk_eventdev.c | 3 ++ drivers/event/cnxk/cnxk_eventdev.h | 2 ++ drive

[dpdk-dev] [PATCH v3 19/33] event/cnxk: add event port and queue xstats

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving statistics from SSO HWS and HWGRP. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_sso.c| 63 + drivers/common/cnxk/roc_sso.h| 19 ++ drivers/event/cnxk/cnxk_eventdev.h | 15 ++ drivers/event/cnxk/

[dpdk-dev] [PATCH v3 18/33] event/cnxk: add SSO selftest and dump

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add selftest to verify sanity of SSO and also add function to dump internal state of SSO. Signed-off-by: Pavan Nikhilesh --- app/test/test_eventdev.c| 14 + drivers/event/cnxk/cn10k_eventdev.c |8 + drivers/event/cnxk/cn9k_eventdev.c

[dpdk-dev] [PATCH v3 17/33] event/cnxk: add device stop and close functions

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add event device stop and close callback functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 15 + drivers/event/cnxk/cn9k_eventdev.c | 14 + drivers/event/cnxk/cnxk_eventdev.c | 48

[dpdk-dev] [PATCH v3 16/33] event/cnxk: add device start function

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add eventdev start function along with few cleanup API's to maintain sanity. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 127 drivers/event/cnxk/cn9k_eventdev.c | 113 ++

[dpdk-dev] [PATCH v3 15/33] event/cnxk: add SSO GWS dequeue fastpath functions

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS event dequeue fastpath functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 10 ++- drivers/event/cnxk/cn10k_worker.c | 54 + drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventdev.c | 1

[dpdk-dev] [PATCH v3 14/33] event/cnxk: add SSO GWS fastpath enqueue functions

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO GWS fastpath event device enqueue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 16 +++- drivers/event/cnxk/cn10k_worker.c | 54 ++ drivers/event/cnxk/cn10k_worker.h | 12 +++ drivers/event/cnxk/cn9k_eventde

[dpdk-dev] [PATCH v3 13/33] event/cnxk: add SSO HW device operations

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HW device operations used for enqueue/dequeue. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_worker.c | 7 + drivers/event/cnxk/cn10k_worker.h | 151 + drivers/event/cnxk/cn9k_worker.c | 7 + drivers/event/cnxk/cn9k_worker.h

[dpdk-dev] [PATCH v3 12/33] event/cnxk: add devargs to configure getwork mode

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add devargs to configure the platform specific getwork mode. CN9K getwork mode by default is set to use dual workslot mode. Add option to force single workslot mode. Example: --dev "0002:0e:00.0,single_ws=1" CN10K supports multiple getwork prefetch modes, by defaul

[dpdk-dev] [PATCH v3 11/33] event/cnxk: add event port link and unlink

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add platform specific event port, queue link and unlink APIs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 64 +- drivers/event/cnxk/cn9k_eventdev.c | 101 drivers/e

Re: [dpdk-dev] Build KNI module failed

2021-04-30 Thread Juraj Linkeš
Maybe we actually need to step back a bit and talk about versions. Which DPDK version are you using? Why are you using the old make build system instead of Meson? Support for KNI cross-compilation was only added recently to Meson and I don't know enough about the old Make system to comment on th

[dpdk-dev] [PATCH v3 10/33] event/cnxk: add port config functions

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add SSO HWS a.k.a event port setup and release functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 121 +++ drivers/event/cnxk/cn9k_eventdev.c | 147 drivers/

[dpdk-dev] [PATCH v3 09/33] event/cnxk: add devargs to control SSO HWGRP QoS

2021-04-30 Thread pbhagavatula
From: Shijith Thotton SSO HWGRPs i.e. queue uses DRAM & SRAM buffers to hold in-flight events. By default the buffers are assigned to the SSO HWGRPs to satisfy minimum HW requirements. SSO is free to assign the remaining buffers to HWGRPs based on a preconfigured threshold. We can control the QoS

[dpdk-dev] [PATCH v3 06/33] event/cnxk: add event queue config functions

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add setup and release functions for event queues i.e. SSO HWGRPs. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 2 ++ drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/event/cnxk/cnxk_eventdev.c | 19

[dpdk-dev] [PATCH v3 08/33] event/cnxk: add devargs for inflight buffer count

2021-04-30 Thread pbhagavatula
From: Shijith Thotton The number of events for a *open system* event device is specified as -1 as per the eventdev specification. Since, SSO inflight events are only limited by DRAM size, the xae_cnt devargs parameter is introduced to provide upper limit for in-flight events. Example: --

[dpdk-dev] [PATCH v3 04/33] event/cnxk: add common configuration validation

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add configuration validation, port and queue configuration functions. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cnxk_eventdev.c | 70 ++ drivers/event/cnxk/cnxk_eventdev.h | 6 +++ 2 files changed, 7

[dpdk-dev] [PATCH v3 07/33] event/cnxk: allocate event inflight buffers

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Allocate buffers in DRAM that hold inflight events. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 7 ++ drivers/event/cnxk/cn9k_eventdev.c | 7 ++ drivers/event/cnxk/cnxk_eventdev.c | 105 +++

[dpdk-dev] [PATCH v3 05/33] event/cnxk: add platform specific device config

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add platform specific event device configuration that attaches the requested number of SSO HWS(event ports) and HWGRP(event queues) LFs to the RVU PF/VF. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 35 ++

[dpdk-dev] [PATCH v3 03/33] event/cnxk: add platform specific device probe

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add platform specific event device probe and remove, also add event device info get function. Signed-off-by: Pavan Nikhilesh Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn10k_eventdev.c | 101 +++ drivers/event/cnxk/cn9k_eventdev.c | 10

[dpdk-dev] [PATCH v3 02/33] event/cnxk: add device capabilities function

2021-04-30 Thread pbhagavatula
From: Shijith Thotton Add the info_get function to return details on the queues, flow, prioritization capabilities, etc. which this device has. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.c | 24 drivers/event/cnx

[dpdk-dev] [PATCH v3 01/33] event/cnxk: add build infra and device setup

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh Add meson build infra structure along with the event device SSO initialization and teardown functions. Signed-off-by: Shijith Thotton Signed-off-by: Pavan Nikhilesh Acked-by: Ray Kinsella --- MAINTAINERS| 6 +++ doc/guides/eventdevs/cnxk.rst

[dpdk-dev] [PATCH v3 00/33] Marvell CNXK Event device Driver

2021-04-30 Thread pbhagavatula
From: Pavan Nikhilesh This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' driver. In future, CN9K a.k.a octeontx2 will also be supported by same driver when code is ready and 'event/octeontx2' will be deprecated. v3 Changes: - Fix documentation, copyright. - Update release

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: fix tunnel offload private items location

2021-04-30 Thread Ferruh Yigit
On 4/25/2021 4:57 PM, Gregory Etelson wrote: > Tunnel offload API requires application to query PMD for specific flow > items and actions. Application uses these PMD specific elements to > build flow rules according to the tunnel offload model. Can you please give some samples what are "PMD specif

Re: [dpdk-dev] Use WFE for spinlock and ring

2021-04-30 Thread Honnappa Nagarahalli
> > > > > > > > > > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality > > > > > > > of 'polling for a memory location to become equal to a given > value'[1]. > > > > > > > > > > > > > > Use the API for the rte spinlock and ring implementations. > > > > > > > With the wait until

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location

2021-04-30 Thread Ferruh Yigit
On 4/29/2021 8:44 AM, Gregory Etelson wrote: > Hello Ferruh, > >> [snip] >> >>> I am OK to get both to next-net, as long as driver patch is Ack'ed. >>> >> >> [PATCH v2 1/2] net/mlx5: fix tunnel offload private items location was sent >> with Ack from Viacheslav Ovsiienko >> >>> It seems there is a

  1   2   >