Support to enable and disable QINQ hardware strip, when configure vlan
offload with QINQ strip mask. If there are packets have QINQ tag to RSS,
users should enable QINQ strip before configuring the RSS.
Fixes: 220b0e49bc47 ("net/txgbe: support VLAN")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
Hi David,
May I know how to configures Tx offloading by testpmd, could you help to
provide an example case?
I add a case which need vhost tx offload (TSO/cksum) function, this case can't
work with the patch, could you use this case as the example if possible?
For example: VM2VM split ring vhost
Hi Maxime and David,
I see patch " vhost: fix offload flags in Rx path "
http://patches.dpdk.org/project/dpdk/patch/20210503164344.27916-4-david.march...@redhat.com/
has been merged, and the legacy implementation is kept. Do you think we still
need to fix the header check for the legacy impleme
> -Original Message-
> From: Zhang, AlvinX
> Sent: Saturday, May 8, 2021 11:11 AM
> To: Zhang, Qi Z ; Yigit, Ferruh
> Cc: dev@dpdk.org; Zhang, AlvinX
> Subject: [PATCH v3] net/ice: fix txq vector path selection
>
> If vector mode is not allowed for Tx, no need to perform vector relat
Thanks for your suggestions, we found that the -fno-tree-vectorize option works.
PS: This option is not successfully added in the earliest test.
Solution:
1. use the -fno-tree-vectorize option to prevent compiler generate auto
vetorization
code, so tha slow-path will work fine.
2. add '-march=
Hi, Slava
Thanks for your explanation.
Thus we can ignore the order between update global cache and
update dev_gen due to R/W lock.
Furthermore, it is unnecessary to keep wmb, and the last wmb (1d)
I think can be removed.
Two reasons for this:
1. wmb has only one function, this is for the loca
If vector mode is not allowed for Tx, no need to perform vector
related setup for Tx queue.
The patch deferred vector setup for Tx queue to the place that
vector mode is confirmed to be allowed.
Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
Signed-off-by: Alvin Zhang
---
v2,v3: U
Thanks Qi,
> -Original Message-
> From: Zhang, Qi Z
> Sent: Saturday, May 8, 2021 10:37 AM
> To: Zhang, AlvinX ; Yigit, Ferruh
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: RE: [PATCH v2] net/ice: fix txq vector path selection
>
>
> > -Original Message-
> > From: Zhang, Alvi
> -Original Message-
> From: Zhang, AlvinX
> Sent: Saturday, May 8, 2021 9:21 AM
> To: Zhang, Qi Z ; Yigit, Ferruh
> Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org
> Subject: [PATCH v2] net/ice: fix txq vector path selection
>
> If Tx vector mode is disabled, the txq vector mode sh
> -Original Message-
> From: dev On Behalf Of Lingyu Liu
> Sent: Friday, April 30, 2021 2:24 AM
> To: dev@dpdk.org
> Cc: Liu, Lingyu
> Subject: [dpdk-dev] [PATCH v1] net/ixgbe: configure EXVET_T register
>
> According to X550 datasheet (section 8.2.1.2), when setting vlan tpid, the
>
> -Original Message-
> From: David Marchand
> Sent: Thursday, May 6, 2021 6:07 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Yang, Qiming ; Zhang, Qi Z
> ; Yigit, Ferruh ; Lu, Wenzhuo
>
> Subject: [PATCH] net/ice/base: fix mem allocations wrapper
>
> This is reported by our internal co
> -Original Message-
> From: Wu, Wenjun1
> Sent: Thursday, May 6, 2021 10:20 AM
> To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z
>
> Cc: Wu, Wenjun1
> Subject: [PATCH v1] net/ice: remove redundant RSS configuration for GTPU
>
> Originally, the default RSS for GTPU is inner fields. Now,
On Fri, May 7, 2021 at 4:51 PM Dmitry Kozlyuk wrote:
>
> 2021-05-07 15:06 (UTC-0400), Lance Richardson:
> [...]
> > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> > index ec7156df96..41a94a7511 100644
> > --- a/lib/eal/unix/eal_unix_memory.c
> > +++ b/lib/eal/unix/e
If Tx vector mode is disabled, the txq vector mode should be
disabled too.
This patch adds checking of Tx vector mode before enabling txq
vector mode.
Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path")
Cc: sta...@dpdk.org
Signed-off-by: Alvin Zhang
---
v2: Update commit log.
---
driv
在 2021/5/7 20:25, David Marchand 写道:
On Fri, May 7, 2021 at 2:20 PM Thomas Monjalon wrote:
The variable "dev" is not used in hns3_get_tx_prep_needed()
in the case of RTE_LIBRTE_ETHDEV_DEBUG:
drivers/net/hns3/hns3_rxtx.c:4213:45: error: unused parameter ‘dev’
Fixes: d7ec2c076579 ("net/hns3
For 32-bit targets, size_t is normally a 32-bit type and
does not have sufficient range to represent 64-bit offsets
that can are needed when mapping PCI addresses. Use uint64_t
instead.
Found when attempting to run 32-bit Linux dpdk-testpmd
using VFIO driver:
EAL: pci_map_resource(): cannot m
> Windows compilation is failing in CI, apparently Windows doesn't
> understand "off_t".
>
> Should we add an "rte_off_t" definition for non-POSIX portability?
On second thought, it's probably better to simply use uint64_t.
On Fri, May 7, 2021 at 2:10 PM Lance Richardson
wrote:
>
> For 32-bit targets, size_t is normally a 32-bit type and
> does not have sufficient range to represent 64-bit offsets
> that can are needed when mapping PCI addresses. Use off_t
> instead, which is usually a 64-bit type when compiled with
For 32-bit targets, size_t is normally a 32-bit type and
does not have sufficient range to represent 64-bit offsets
that can are needed when mapping PCI addresses. Use off_t
instead, which is usually a 64-bit type when compiled with
_D_FILE_OFFSET_BITS=64 as is the case for DPDK.
Found when attemp
2021-05-07 15:06 (UTC-0400), Lance Richardson:
[...]
> diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> index ec7156df96..41a94a7511 100644
> --- a/lib/eal/unix/eal_unix_memory.c
> +++ b/lib/eal/unix/eal_unix_memory.c
> @@ -24,14 +24,14 @@
>
> static void *
> mem_m
On 5/5/21 3:39 PM, Piotr Kubaj wrote:
lib/librte_eal/ppc/include/rte_altivec.h | 3 +++
lib/librte_eal/ppc/include/rte_cycles.h | 12
lib/librte_eal/ppc/rte_cycles.c | 16
Directory path "librte_eal" has been changed to "eal" so a v3 patch is
like
On 5/5/21 3:39 PM, Piotr Kubaj wrote:
diff --git a/lib/librte_eal/ppc/include/rte_altivec.h
b/lib/librte_eal/ppc/include/rte_altivec.h
index 1551a9454..3fcc819c1 100644
--- a/lib/librte_eal/ppc/include/rte_altivec.h
+++ b/lib/librte_eal/ppc/include/rte_altivec.h
@@ -7,6 +7,9 @@
#define_RTE_
In the function __idxd_completed_ops() we have a parameter shadow warning
due to a local variable having the same name as one of the function
parameters. This is fixed by simply renaming the local variable.
Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")
Reported-by: Sunil Pai G
On Fri, May 07, 2021 at 05:48:50PM +0100, Ferruh Yigit wrote:
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > From: Stanislaw Kardach
> >
> > Introduce a memory area for ENA driver shared between all the processes
> > of a same prefix (memzone backed).
> > Move the memzone allocation counter fo
2021-05-07 10:13 (UTC+0200), David Marchand:
> On Thu, May 6, 2021 at 11:45 AM David Marchand
> wrote:
> >
> > A terminated pthread should be joined or detached so that its associated
> > resources are released.
> >
> > The "ice-reset-" threads are used to service some reset task in the
> > backgr
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> From: Stanislaw Kardach
>
> pthread_cond_timedwait() may spuriously wakeup according to POSIX.
> Therefore it is required to check whether predicate is actually true
> before finishing the waiting loop.
>
> Signed-off-by: Stanislaw Kardach
> Reviewe
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> This version update contains:
> * memcpy mapping to the dpdk-optimized version.
> * ena_com (HAL) update to the latest version.
> * Bug fixes for the large LLQ headers and devargs parsing.
> * Mbuf RSS hash presence indication.
> * Bug fix for
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> From: Stanislaw Kardach
>
> rte_pci_device and rte_eth_dev are process-local structures. Therefore
> ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally.
> Switch this to extracting those structures via rte_eth_devices indexing
> and
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> From: Stanislaw Kardach
>
> Introduce a memory area for ENA driver shared between all the processes
> of a same prefix (memzone backed).
> Move the memzone allocation counter for ENA_MEM_ALLOC_COHERENT there so
> that all processes may utilize it.
De
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> To make it possible to the app to determine if the hash was calculated
> for the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's
> ol_flags.
>
> As the PMD wasn't setting that, the application couldn't check if there
> is a hash in a pro
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> As the documentation of rte_kvargs_parse() states, the valid_keys
> argument must be NULL terminated. Lack of this feature may cause
> segmentation fault if the passed devarg will be different then the
> supported value.
>
> Fixes: 8a7a73f26cc9 ("net/e
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> Although the ENA DPDK PMD doesn't have to perform any actions for
> destroying the wait event, some other platforms have to.
>
> The macro "ENA_WAIT_EVENT_DESTROY" was renamed to
> "ENA_WAIT_EVENTS_DESTROY" and also whole implementation responsible for
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> Hi,
>
> this version updates the driver to version 2.3.0, which fixes multiple
> bugs, contains part of the work on making the ENA PMD fully MP aware, and
> also updates HAL to the latest version.
>
> More detailed list of changes:
> * memcpy mappin
On 5/7/2021 3:59 PM, Ferruh Yigit wrote:
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
>> Hi,
>>
>> this version updates the driver to version 2.3.0, which fixes multiple
>> bugs, contains part of the work on making the ENA PMD fully MP aware, and
>> also updates HAL to the latest version.
>>
>> Mo
On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> Hi,
>
> this version updates the driver to version 2.3.0, which fixes multiple
> bugs, contains part of the work on making the ENA PMD fully MP aware, and
> also updates HAL to the latest version.
>
> More detailed list of changes:
> * memcpy mappin
07/05/2021 13:54, David Marchand:
> If no enable_drivers option is passed, the default is to build the
> drivers list by calling list-dir-globs.py.
>
> But if no python interpreter is installed, no error is reported and all
> drivers end up being disabled.
>
> Example on a minimal FreeBSD vm:
>
https://bugs.dpdk.org/show_bug.cgi?id=698
Bug ID: 698
Summary: i40e unload on FreeBSD prints "unqualified module" and
breaks link
Product: DPDK
Version: 20.11
Hardware: x86
OS: FreeBSD
Status: UN
David Marchand writes:
> On Thu, May 6, 2021 at 5:15 PM David Marchand
> wrote:
>>
>> Testing OVS build against 21.05-rc2 revealed some issues.
>> Bits were also missing on OVS side, so for people interested, a
>> rebased dpdk-latest OVS branch is available at:
>> https://github.com/david-march
07/05/2021 11:54, Burakov, Anatoly:
> On 06-May-21 5:40 PM, Conor Walsh wrote:
> > +* ``start-after`` and ``end-before`` can use any text within a given file,
> > + however it may be difficult to find unique text within your code to mark
> > the
> > + start and end of your snippets. In these cas
07/05/2021 14:25, David Marchand:
> On Fri, May 7, 2021 at 2:20 PM Thomas Monjalon wrote:
> >
> > The variable "dev" is not used in hns3_get_tx_prep_needed()
> > in the case of RTE_LIBRTE_ETHDEV_DEBUG:
> > drivers/net/hns3/hns3_rxtx.c:4213:45: error: unused parameter ‘dev’
>
> Fixes: d7ec2c076579
> > > Reported-by: Harry van Haaren
> > > Signed-off-by: Bruce Richardson
> > > ---
> >
> > Tested-by: Anatoly Burakov
>
> Tested-by: Harry van Haaren
I was having an issue while running l3fwd after rc2 where I had to force
IOVA mode to PA, this patch fixes that issue.
Tested-by: Conor Wals
On Fri, May 7, 2021 at 2:20 PM Thomas Monjalon wrote:
>
> The variable "dev" is not used in hns3_get_tx_prep_needed()
> in the case of RTE_LIBRTE_ETHDEV_DEBUG:
> drivers/net/hns3/hns3_rxtx.c:4213:45: error: unused parameter ‘dev’
Fixes: d7ec2c076579 ("net/hns3: select Tx prepare based on Tx offlo
On Thu, May 6, 2021 at 5:15 PM David Marchand wrote:
>
> Testing OVS build against 21.05-rc2 revealed some issues.
> Bits were also missing on OVS side, so for people interested, a
> rebased dpdk-latest OVS branch is available at:
> https://github.com/david-marchand/ovs/commits/dpdk-latest
I got
The variable "dev" is not used in hns3_get_tx_prep_needed()
in the case of RTE_LIBRTE_ETHDEV_DEBUG:
drivers/net/hns3/hns3_rxtx.c:4213:45: error: unused parameter ‘dev’
Reported-by: David Marchand
Signed-off-by: Thomas Monjalon
---
drivers/net/hns3/hns3_rxtx.c | 1 +
1 file changed, 1 insertion(
If no enable_drivers option is passed, the default is to build the
drivers list by calling list-dir-globs.py.
But if no python interpreter is installed, no error is reported and all
drivers end up being disabled.
Example on a minimal FreeBSD vm:
dpdk@freebsd:~/dpdk $ meson setup build
...
On Fri, May 07, 2021 at 10:18:52AM +, Ruifeng Wang wrote:
> > -Original Message-
> > From: Bruce Richardson
> > Sent: Friday, April 30, 2021 10:19 PM
> > To: Honnappa Nagarahalli
> > Cc: tho...@monjalon.net; Ruifeng Wang ; David
> > Marchand ; dev ;
> > jer...@marvell.com; nd
> > Sub
On 5/7/2021 10:26 AM, David Marchand wrote:
> On Wed, Apr 28, 2021 at 9:21 AM Min Hu (Connor) wrote:
>>
>> From: Chengchang Tang
>>
>> Tx prepare should be called only when necessary to reduce the impact on
>> performance.
>>
>> For partial TX offload, users need to call rte_eth_tx_prepare() to i
> -Original Message-
> From: Bruce Richardson
> Sent: Friday, April 30, 2021 10:19 PM
> To: Honnappa Nagarahalli
> Cc: tho...@monjalon.net; Ruifeng Wang ; David
> Marchand ; dev ;
> jer...@marvell.com; nd
> Subject: Re: Use WFE for spinlock and ring
>
> On Fri, Apr 30, 2021 at 01:41:22P
Hi, Feifei
We should consider the locks in your scenario - it is crucial for the complete
model description:
How agent_1 (in your terms) rebuilds global cache:
1a) lock()
1b) rebuild(global cache)
1c) update(dev_gen)
1d) wmb()
1e) unlock()
How agent_2 checks:
2a) check(dev_gen) (assume positi
Test case setup should return -ENOTSUP, if it is not supported.
Fixes: 7d761b07fcf6 ("test/event: add unit tests for periodic timer")
Signed-off-by: Shijith Thotton
---
app/test/test_event_timer_adapter.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/app/test/test_ev
On Fri, May 7, 2021 at 11:22 AM David Marchand
wrote:
> diff --git a/lib/meson.build b/lib/meson.build
> index 77f363a516..56f2465ee2 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -88,7 +88,8 @@ optional_libs = [
> ]
>
> disabled_libs = []
> -opt_disabled_libs = run_command(list_di
On 06-May-21 5:40 PM, Conor Walsh wrote:
Currently the documentation describes how to add code snippets to the
docs using code blocks. This can be problematic as the code snippets
in the docs may fall out of sync with the actual code it is referencing
within DPDK. This patch adds instructions to
On Fri, May 07, 2021 at 11:21:57AM +0200, David Marchand wrote:
> If no enable_drivers option is passed, the default is to build the
> drivers list by calling list-dir-globs.py.
>
> But if no python interpreter is installed, no error is reported and all
> drivers end up being disabled.
>
> Exampl
On 07-May-21 3:13 AM, Richael Zhuang wrote:
@@ -262,18 +189,16 @@ static int
power_init_for_setting_freq(struct acpi_power_info *pi) {
FILE *f;
- char fullpath[PATH_MAX];
char buf[BUFSIZ];
uint32_t i, freq;
- char *s;
+ int ret;
- snprintf(fullp
To enable IP fragment RSS hash, ICE_FLOW_SEG_HDR_IPV_FRAG is added to the
IP RSS configuration template, together with ICE_FLOW_SEG_HDR_IPV_OTHER.
It will cause error when associating flow profile. To fix this issue,
this patch only selects one of the above two segment header types based
on rss typ
The support of RSS expansion for the flows with IPv6 GRE item was added
to mlx5 PMD. And the GRE KEY item support in expansion was missed
and the flows with GRE and GRE KEY items were expanded in the wrong
way causing the flow creation failure.
This patch adds the RSS expansion support for GRE KEY
On Wed, Apr 28, 2021 at 9:21 AM Min Hu (Connor) wrote:
>
> From: Chengchang Tang
>
> Tx prepare should be called only when necessary to reduce the impact on
> performance.
>
> For partial TX offload, users need to call rte_eth_tx_prepare() to invoke
> the tx_prepare callback of PMDs. In this call
If no enable_drivers option is passed, the default is to build the
drivers list by calling list-dir-globs.py.
But if no python interpreter is installed, no error is reported and all
drivers end up being disabled.
Example on a minimal FreeBSD vm:
dpdk@freebsd:~/dpdk $ meson setup build
...
On Tue, May 4, 2021 at 3:06 PM Kinsella, Ray wrote:
>
>
>
> On 03/05/2021 12:18, Akhil Goyal wrote:
> > Hi Ray,
> >>> @@ -127,6 +127,10 @@ Deprecation Notices
> >>>values to the function ``rte_event_eth_rx_adapter_queue_add`` using
> >>>the structure ``rte_event_eth_rx_adapter_queue_add``.
From: HongBo Zheng
Currently in the VF reset scenario, the VF performs the set
alive operation before restoring the configuration completed,
which may cause the hardware to work in an abnormal state.
This patch fix this problem by set VF alive after restoring
the configuration completed.
Fixes:
From: Chengwen Feng
This patch adds link status event pre-conditions.
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu (Connor)
---
doc/guides/nics/hns3.rst | 10 ++
1 file changed, 10 insertions(+)
diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 4439df5..c3a
This patch set contains 6 bugfixes for hns3 PMD.
Chengwen Feng (5):
net/hns3: return code when PCI config space write fail
net/hns3: fix logging info when clear all FDIR rules
net/hns3: clear hash map when clear all FDIR rules
net/hns3: fix out param not set when query FDIR counter
doc:
From: Chengwen Feng
This patch returns error code when calling rte_pci_write_config() API.
Fixes: 6dd32ded17d8 ("net/hns3: check PCI config space write")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu (Connor)
---
drivers/net/hns3/hns3_ethdev_vf.c | 3 +++
1 file chan
From: Chengwen Feng
If clear FDIR rules fail, the error code was logged, but the error code
was useless because it was the sum of all fail code.
This patch fixes it by log the success cnt and fail cnt.
Fixes: fcba820d9b9e ("net/hns3: support flow director")
Fixes: 8eed8acc812e ("net/hns3: add e
From: Chengwen Feng
The fdir hash map hold the pointers of fdir rule elements, it needs to
be set to NULL when clear all fdir rules.
Fixes: fcba820d9b9e ("net/hns3: support flow director")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
Signed-off-by: Min Hu (Connor)
---
drivers/net/hns3/hn
From: Chengwen Feng
The hardware doesn't support counting the number of bytes that through
the fdir rule. Therefore, the corresponding out parameters (e.g.
bytes_set/bytes) is set to zero.
Fixes: fcba820d9b9e ("net/hns3: support flow director")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
On Fri, May 7, 2021 at 12:24 AM Dmitry Kozlyuk wrote:
>
> 2021-05-06 17:14 (UTC+0200), David Marchand:
> > Spotted by sparse in OVS build:
> > ../../lib/netdev-dpdk.c: note: in included file (through
> > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h,
> > /home/runner/work/ovs/ovs/dpdk-
>From the documentation:
"The SoC configuration is a combination of implementer and CPU part number
configuration and SoC-specific configuration."
Align Qualcomm SoC configuration with the configuration of other
server SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
implementer
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, April 29, 2021 11:06 PM
> To: Ruifeng Wang
> Cc: Honnappa Nagarahalli ; Konstantin
> Ananyev ; dev@dpdk.org;
> david.march...@redhat.com; tho...@monjalon.net; jer...@marvell.com;
> nd ; Gavin Hu ; Steve Capper
> ; Ola Liljed
On Thu, May 6, 2021 at 11:45 AM David Marchand
wrote:
>
> A terminated pthread should be joined or detached so that its associated
> resources are released.
>
> The "ice-reset-" threads are used to service some reset task in the
> background, but they are never joined by the thread that created th
> -Original Message-
> From: Ruifeng Wang
> Sent: Friday, May 7, 2021 9:23 AM
> To: Thierry Herbelot ; dev@dpdk.org
> Cc: tho...@monjalon.net; Juraj Linkeš ;
> Honnappa Nagarahalli ; nd
> Subject: RE: [PATCH-V6] config/arm: restore support for Qualcomm servers
>
In addition to Ruifeng's
> -Original Message-
> From: Thierry Herbelot
> Sent: Thursday, May 6, 2021 5:26 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot ; tho...@monjalon.net;
> Juraj Linkeš ; Honnappa Nagarahalli
> ; Ruifeng Wang
>
> Subject: [PATCH-V6] config/arm: restore support for Qualcomm servers
>
> From th
The crypto driver added new fields to the mkey attributes struct:
crypto_en and set_remote_rw.
The entire mkey struct was not initialized, only specific fields in it,
which caused the new added fields not to be initialized resulting in a
mkey creation error.
This is fixed by initializing the enti
73 matches
Mail list logo
