For "order_launch_lcores" function, wmb after that the main lcore
updates the variable "t->err", which represents the end of the test
signal, is unnecessary. Because after the main lcore updates this
siginal variable, it will jump out of the launch function loop, and wait
other lcores stop or retur
> -Original Message-
> From: Yang, Qiming
> Sent: Monday, May 10, 2021 1:02 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] net/ice/base: remove unnecessary code
>
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Monday, May 10, 2021 11:23
> > To: Yang
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 10, 2021 11:23
> To: Yang, Qiming
> Cc: dev@dpdk.org; Zhang, Qi Z
> Subject: [PATCH] net/ice/base: remove unnecessary code
>
> Coverty issue: 370613
> Execution cannot reach this statement: "break;".
> Remove the unnecessary
Hi Asaf，
Are there any progress for this case?
BR
wenxu
发件人：Asaf Penso
发送日期：2021-04-29 17:06:52
收件人：wenxu
抄送人："dev@dpdk.org"
主题：RE: Re:RE: Re:Re: [dpdk-dev] nvgre inner rss problem in mlx5
Sure, let’s take it offline and come back here with updated results.
Regards,
Asaf Penso
From: w
> -Original Message-
> From: dev On Behalf Of Alvin Zhang
> Sent: Tuesday, April 27, 2021 4:59 PM
> To: Wu, Jingjing ; Xing, Beilei
> Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix offload flag checking in simple Tx
> datapath
>
> For Tx p
Coverty issue: 370613
Execution cannot reach this statement: "break;".
Remove the unnecessary if branch.
Fixes: 2913bc4155d2 ("net/ice/base: sign external device package programming")
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --g
Convery issue: 370613
Execution cannot reach this statement: "break;".
Remove the unnecessary if branch.
Fixes: 2913bc4155d2 ("net/ice/base: sign external device package programming")
Signed-off-by: Qi Zhang
---
drivers/net/ice/base/ice_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --g
> -Original Message-
> From: dev On Behalf Of Wenjun Wu
> Sent: Saturday, May 8, 2021 4:41 PM
> To: dev@dpdk.org; qiming.y...@intel.com--annotate
> Cc: Wu, Wenjun1
> Subject: [dpdk-dev] [PATCH v2] net/ice: remove redundant RSS configuration for
> GTPU
>
> Originally, the default RSS f
> -Original Message-
> From: dev On Behalf Of Wenzhuo Lu
> Sent: Monday, May 10, 2021 9:33 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH] net/iavf: fix coverity issue
>
> The coverity issue,
> "CID 370606: Control flow issues (DEADCODE) Execution cannot reach
> -Original Message-
> From: Xu, Ting
> Sent: Saturday, May 8, 2021 3:12 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Zhang, Qi Z
> ; Xu, Ting ; sta...@dpdk.org
> Subject: [PATCH v1] net/ice: fix wrong IP RSS configuration template
>
> To enable IP fragment RSS hash, ICE_FLOW_SEG_HDR_IPV
The coverity issue,
"CID 370606: Control flow issues (DEADCODE)
Execution cannot reach the expression "use_avx2"
inside this statement: "if (!use_sse && !use_avx2 &..."."
After commit bb3ef9aaa478, the check is useless.
Fixes: bb3ef9aaa478 ("net/iavf: fix Rx function selection")
Signed-off-by:
On Sun, 9 May 2021 22:48:02 +0530
wrote:
> From: Pavan Nikhilesh
>
> Avoid expanding parameters inside RTE_*_ALIGN macros.
> Update common_autotest to detect macro side effects.
> Workaround static arrays relying on RTE_ALIGN macros.
>
> Fixes: af75078fece3 ("first public release")
> Cc: sta..
From: Pavan Nikhilesh
Avoid expanding parameters inside RTE_*_ALIGN macros.
Update common_autotest to detect macro side effects.
Workaround static arrays relying on RTE_ALIGN macros.
Fixes: af75078fece3 ("first public release")
Cc: sta...@dpdk.org
Signed-off-by: Pavan Nikhilesh
Signed-off-by:
From: Pavan Nikhilesh
Avoid expanding parameters inside the macro multiple times.
For example:
RTE_ALIGN_MUL_NEAR(rte_rdtsc() - start, CYC_PER_10MHZ);
Here rte_rdtsc() call is expanded multiple times in the macro
causing it to return different values that leads to unintended
side effects.
The following changes since commit 627c5b41bb14a1afbd1489b0fc4b8224532a823d:
build: fix default drivers list without Python (2021-05-07 15:41:45 +0200)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to 1bb213071ae1fd89105273e9
On Fri, May 7, 2021 at 3:42 PM Shijith Thotton wrote:
>
> Test case setup should return -ENOTSUP, if it is not supported.
>
> Fixes: 7d761b07fcf6 ("test/event: add unit tests for periodic timer")
Cc: sta...@dpdk.org
>
> Signed-off-by: Shijith Thotton
Acked-by: Jerin Jacob
Applied to dpdk-next
From: Shiri Kuzin
Add the supported capabilities to the crypto driver.
Add supported feature flags.
Add crypto driver documentation.
Signed-off-by: Shiri Kuzin
Signed-off-by: Matan Azrad
---
doc/guides/cryptodevs/features/mlx5.ini | 37 ++
doc/guides/cryptodevs/index.rst | 1
From: Suanming Mou
Currently, HW handles the WQEs much faster than the software,
Using the constant WQE set layout can initialize most of the WQE
segments in advanced, and software only needs to configure very
limited segments in datapath. This accelerates the software WQE
organize in datapath.
From: Suanming Mou
The mlx5 HW crypto operations are done by attaching crypto property
to a memory region. Once done, every access to the memory via the
crypto-enabled memory region will result with in-line encryption or
decryption of the data.
As a result, the design choice is to provide two ty
From: Suanming Mou
This commit adds mlx5 crypto statistic get and reset operations.
Signed-off-by: Suanming Mou
Signed-off-by: Matan Azrad
---
drivers/crypto/mlx5/mlx5_crypto.c | 39 ---
1 file changed, 36 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/
From: Suanming Mou
The crypto operations are done with the WQE set which contains
one UMR WQE and one rdma write WQE. Most segments of the WQE
set are initialized properly during queue setup, only limited
segments are initialized according to the crypto detail in the
datapath process.
This commi
From: Suanming Mou
A keytag is a piece of data encrypted together with a DEK.
When a DEK is referenced by an MKEY.bsf through its index, the keytag is
also supplied in the BSF as plaintext. The HW will decrypt the DEK (and
the attached keytag) and will fail the operation if the keytags don't
mat
From: Shiri Kuzin
Mellanox user space drivers don't deal with physical addresses as part
of a memory protection mechanism.
The device translates the given virtual address to a physical address
using the given memory key as an address space identifier.
That's why any mbuf virtual address is moved
From: Shiri Kuzin
To work with crypto engines that are marked with wrapped_import_method,
a login session is required.
A crypto login object needs to be created using DevX.
The crypto login object contains:
- The credential pointer.
- The import_KEK pointer to be used for all sec
From: Shiri Kuzin
Add the dev_start function that is used to start a configured device.
Add the dev_stop function that is used to stop a configured device.
Both functions set the dev parameter as used and return 0.
Signed-off-by: Shiri Kuzin
Acked-by: Matan Azrad
---
drivers/crypto/mlx5/mlx5
From: Shiri Kuzin
The HW queue pairs are a pair of send queue and receive queue of
independent work queues packed together in one object for the purpose
of transferring data between nodes of a network.
Completion Queue is a FIFO queue of completed work requests.
In crypto driver we use one QP i
From: Shiri Kuzin
The basic dev control operations are configure, close and get info.
Extended the existing support of configure and close:
-mlx5_crypto_dev_configure- function used to configure device.
-mlx5_crypto_dev_close- function used to close a configured
device.
From: Shiri Kuzin
Sessions are used in symmetric transformations in order to prepare
objects and data for packet processing stage.
A mlx5 session includes iv_offset, pointer to mlx5_crypto_dek struct,
bsf_size, bsf_p_type, block size index, encryption_order and encryption
standard.
Implement th
From: Shiri Kuzin
A DEK(Data encryption Key) is an mlx5 HW object which represents the
cipher algorithm key.
The DEKs are used during data encryption/decryption operations.
In symmetric algorithms like AES-STS, we use the same DEK for both
encryption and decryption.
Use the mlx5 hash-list tool
From: Shiri Kuzin
Add a new PMD for Mellanox devices- crypto PMD.
The crypto PMD will be supported starting Nvidia ConnectX6 and
BlueField2.
The crypto PMD will add the support of encryption and decryption using
the AES-XTS symmetric algorithm.
The crypto PMD requires rdma-core and uses mlx5 D
Add a new PMD for Nvidia devices- crypto PMD.
The crypto PMD will be supported on Nvidia ConnectX6 The crypto PMD will add
the support of encryption and decryption using the AES-XTS symmetric algorithm.
The crypto PMD requires rdma-core and uses mlx5 DevX.
v2:
Add data-path part.
v3:
Rebase.
v4
On Fri, May 7, 2021 at 2:33 AM wrote:
>
> From: Pavan Nikhilesh
>
> The last lcore declared in the list is also a valid lcore in the list.
>
> Fixes: 32d7dbf269be ("app/eventdev: fix overflow in lcore list parsing")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh
Acked-by: Jerin Jacob
On Thu, May 6, 2021 at 6:41 PM Hemant Agrawal
wrote:
>
> Acked-by: Hemant Agrawal
Applied to dpdk-next-eventdev/for-main. Thanks.
>
>
From: Thomas Monjalon
> 09/05/2021 10:31, Matan Azrad:
> >
> > From: Akhil Goyal
> > > > From: Suanming Mou
> > > >
> > > > A keytag is a piece of data encrypted together with a DEK.
> > > >
> > > > When a DEK is referenced by an MKEY.bsf through its index, the
> > > > keytag is also supplied i
pt., 7 maj 2021 o 18:49 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > From: Stanislaw Kardach
> >
> > rte_pci_device and rte_eth_dev are process-local structures. Therefore
> > ena_adapter::pdev and ena_adapter::rte_dev cannot be used universally.
> > Switch this to
pt., 7 maj 2021 o 18:50 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > This version update contains:
> > * memcpy mapping to the dpdk-optimized version.
> > * ena_com (HAL) update to the latest version.
> > * Bug fixes for the large LLQ headers and devargs parsi
> -Original Message-
> From: Akhil Goyal
> Sent: Sunday, May 9, 2021 12:33 PM
> To: Matan Azrad ; dev@dpdk.org
> Cc: Suanming Mou ; NBU-Contact-Thomas
> Monjalon ; Shiri Kuzin
> Subject: RE: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD
>
> External email: Use caution open
> -Original Message-
> From: Akhil Goyal
> Sent: Sunday, May 9, 2021 12:21 PM
> To: Matan Azrad ; dev@dpdk.org
> Cc: Suanming Mou ; NBU-Contact-Thomas
> Monjalon ; Shiri Kuzin
> Subject: RE: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations
>
> External email: Use caution
> -Original Message-
> From: Akhil Goyal
> Sent: Sunday, May 9, 2021 12:19 PM
> To: Matan Azrad ; dev@dpdk.org
> Cc: Suanming Mou ; NBU-Contact-Thomas
> Monjalon ; Shiri Kuzin
> Subject: RE: [EXT] [PATCH v3 09/15] crypto/mlx5: adjust to the multiple data
> unit API
>
> External email:
From: Akhil Goyal
> > From: Akhil Goyal
> > > > From: Suanming Mou
> > > >
> > > > A keytag is a piece of data encrypted together with a DEK.
> > > >
> > > > When a DEK is referenced by an MKEY.bsf through its index, the
> > > > keytag is also supplied in the BSF as plaintext. The HW will
> > >
pt., 7 maj 2021 o 18:47 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > To make it possible to the app to determine if the hash was calculated
> > for the packet or not, the PKT_RX_RSS_HASH should be set in the mbuf's
> > ol_flags.
> >
> > As the PMD wasn't setting tha
From: Akhil Goyal
> > > > +Supported NICs
> > > > +--
> > > > +
> > > > +* Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT
> (2x200G)
> > > > +
> > > > +Prerequisites
> > > > +-
> > > > +
> > > > +- Mellanox OFED version: **5.3**
> > > > + see :doc:`../../nics/mlx
pt., 7 maj 2021 o 18:47 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > Although the ENA DPDK PMD doesn't have to perform any actions for
> > destroying the wait event, some other platforms have to.
> >
> > The macro "ENA_WAIT_EVENT_DESTROY" was renamed to
> > "ENA_WAI
pt., 7 maj 2021 o 17:52 Ferruh Yigit napisał(a):
>
> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
> > Hi,
> >
> > this version updates the driver to version 2.3.0, which fixes multiple
> > bugs, contains part of the work on making the ENA PMD fully MP aware, and
> > also updates HAL to the latest v
On 5/7/2021 6:18 PM, Stanislaw Kardach wrote:
> On Fri, May 07, 2021 at 05:48:50PM +0100, Ferruh Yigit wrote:
>> On 5/6/2021 3:25 PM, Michal Krawczyk wrote:
>>> From: Stanislaw Kardach
>>>
>>> Introduce a memory area for ENA driver shared between all the processes
>>> of a same prefix (memzone bac
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, April 28, 2021 12:32 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
>
> Subject: [PATCH] net/mlx5: fix query missed Rx packet stats
>
> There was a typo - the device context was wrongly provided
> instead of
Hi,
> -Original Message-
> From: Slava Ovsiienko
> Sent: Wednesday, April 28, 2021 12:18 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix Tx queue doorbell record field offset
>
> If the Send Queue (backing one for PMD Tx que
Hi,
> -Original Message-
> From: Haifei Luo
> Sent: Tuesday, April 6, 2021 9:51 AM
> To: dek...@nvidia.com; Ori Kam ; Slava Ovsiienko
> ; Matan Azrad ; Shahaf
> Shuler ; Wisam Monther
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> ; Raslan Darawsheh ; Roni
> Bar Yanai
> Subject: [PAT
Hi,
> -Original Message-
> From: Jiawei(Jonny) Wang
> Sent: Friday, May 7, 2021 12:42 PM
> To: Slava Ovsiienko ; Matan Azrad
> ; Ori Kam ; Jack Min
>
> Cc: dev@dpdk.org; Raslan Darawsheh ;
> sta...@dpdk.org
> Subject: [PATCH] net/mlx5: fix RSS expansion for GRE KEY
>
> The support of RS
> > > +
> > > +fmt_name = 'mlx5_crypto'
> > > +deps += ['common_mlx5', 'eal', 'cryptodev']
> >
> > I don't see a reason for eal dependency. Do you really need it?
>
> See RTE_LOG_REGISTER.
Compilation works fine even after removing this dependency.
I believe it is internally managed in cryptodev.
> > > +static void
> > > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev,
> > > + struct rte_cryptodev_sym_session *sess) {
> > > + struct mlx5_crypto_priv *priv = dev->data->dev_private;
> > > + struct mlx5_crypto_session *sess_private_data =
> > > +
>
> > Also set feature flag in the code and the documentation in this patch.
> > I see that you are setting all of them in a single patch in the end.
> > This is not correct. It should be added where the feature is supported.
> > Please fix this for all the feature flags.
>
> No, in this stage no
> From: Akhil Goyal
> > > From: Suanming Mou
> > >
> > > A keytag is a piece of data encrypted together with a DEK.
> > >
> > > When a DEK is referenced by an MKEY.bsf through its index, the keytag
> > > is also supplied in the BSF as plaintext. The HW will decrypt the DEK
> > > (and the attached
> > > +Supported NICs
> > > +--
> > > +
> > > +* Mellanox\ |reg| ConnectX\ |reg|-6 200G MCX654106A-HCAT (2x200G)
> > > +
> > > +Prerequisites
> > > +-
> > > +
> > > +- Mellanox OFED version: **5.3**
> > > + see :doc:`../../nics/mlx5` guide for more Mellanox OFED details.
>
09/05/2021 10:31, Matan Azrad:
>
> From: Akhil Goyal
> > > From: Suanming Mou
> > >
> > > A keytag is a piece of data encrypted together with a DEK.
> > >
> > > When a DEK is referenced by an MKEY.bsf through its index, the keytag
> > > is also supplied in the BSF as plaintext. The HW will decryp
From: Akhil Goyal
> > +
> > +Overview
> > +
> > +
> > +The device can provide disk encryption services, allowing data
> > +encryption and decryption towards a disk. Having all
> > +encryption/decryption operations done in a single device can reduce
> > +cost and overheads of the
> > rela
From: Akhil Goyal
> > @@ -685,9 +919,8 @@ mlx5_crypto_pci_probe(struct rte_pci_driver
> > *pci_drv,
> > DRV_LOG(INFO,
> > "Crypto device %s was created successfully.", ibv->name);
> > crypto_dev->dev_ops = &mlx5_crypto_ops;
> > - crypto_dev->dequeue_burst = NULL;
>
From: Akhil Goyal
> > From: Suanming Mou
> >
> > A keytag is a piece of data encrypted together with a DEK.
> >
> > When a DEK is referenced by an MKEY.bsf through its index, the keytag
> > is also supplied in the BSF as plaintext. The HW will decrypt the DEK
> > (and the attached keytag) and w
Hi,
> -Original Message-
> From: Shiri Kuzin
> Sent: Friday, May 7, 2021 10:01 AM
> To: dev@dpdk.org
> Cc: Matan Azrad ; Raslan Darawsheh
> ; Slava Ovsiienko
> Subject: [PATCH] common/mlx5: fix mkey attributes initialization
>
> The crypto driver added new fields to the mkey attributes
From: Akhil Goyal
> > From: Shiri Kuzin
> >
> > In AES-XTS the data to be encrypted\decrypted does not have to be in
> > multiples of 16B size, the unit of data is called data-unit.
> >
> > As a result of patch [1] a new field is added to the cipher
> > capability, called dataunit_set, where th
From: Akhil Goyal
> > +static void
> > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev,
> > + struct rte_cryptodev_sym_session *sess) {
> > + struct mlx5_crypto_priv *priv = dev->data->dev_private;
> > + struct mlx5_crypto_session *sess_private_data =
>
Hi Akhil
Thanks for the review, I know it was too tied for you to review, so, I really
appreciate..
From: Akhil Goyal
> > diff --git a/drivers/crypto/mlx5/meson.build
> > b/drivers/crypto/mlx5/meson.build new file mode 100644 index
> > 00..fd00283665
> > --- /dev/null
> > +++ b/drivers/c
62 matches
Mail list logo
