[dpdk-dev] [PATCH v3 2/2] net/i40e: replace SMP barrier with thread fence

2021-07-05 Thread Joyce Kong
Simply replace the SMP barrier with atomic thread fence for i40e hw ring sacn, if there is no synchronization point. Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang --- drivers/net/i40e/i40e_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_r

[dpdk-dev] [PATCH v3 1/2] net/i40e: add logic of processing continuous DD bits for Arm

2021-07-05 Thread Joyce Kong
For Arm platforms, reading descs can get re-ordered, then the status of DD bits will be discontinuous, so add the logic to only process continuous descs by checking DD bits. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang

[dpdk-dev] [PATCH v3 0/2] fixes for i40e hw scan ring

2021-07-05 Thread Joyce Kong
This patchset contains two parts for i40e PMD, one is to add the logic of processing continuous DD bits for Arm platform, the other is to replace SMP barrier with thread fence. v3: Seperate the commit changes into two parts. v2: Only add the compile option for Arm and keep X86 intact. v1:

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Matan Azrad
Hi From: fengchengwen > On 2021/7/4 23:21, Matan Azrad wrote: > > > > > > From: Chengwen Feng > >> This patch introduces 'dmadevice' which is a generic type of DMA > >> device. > >> > >> The APIs of dmadev library exposes some generic operations which can > >> enable configuration and I/O with the

Re: [dpdk-dev] [dpdk-stable] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> > From: Kalesh Anakkur Purayil > Sent: Tuesday, July 6, 2021 11:27 AM > To: Xueming(Steven) Li > Cc: dpdk stable ; dpdk-dev ; Abhishek Marathe > ; Akhil Goyal ; Ali > Alnubani Subject: Re: [dpdk-stable] 20.11.2 patches review and test > > Hi Xueming, > > Testing with dpdk v20.11.2 from B

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread fengchengwen
On 2021/7/4 23:21, Matan Azrad wrote: > > > From: Chengwen Feng >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. >> >> The APIs of dmadev library exposes some generic operations which can >> enable configuration and I/O with the DMA devices. >> > Did you consider RTE

[dpdk-dev] [PATCH v2 2/2] net/mlx5: control rules with identical pattern behavior

2021-07-05 Thread Jiawei Wang
In order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' is introduced. If allow, these rules be inserted successfully and only the first rule take affect. If disallow, the first rule will be inserted and other rules be rejected. The d

[dpdk-dev] [PATCH v2 1/2] common/mlx5: add glue function for duplicate rule ability

2021-07-05 Thread Jiawei Wang
Add glue function to update the duplicate rule allow/disallow through rdma-core DV API. Signed-off-by: Jiawei Wang Acked-by: Matan Azrad --- drivers/common/mlx5/linux/meson.build | 2 ++ drivers/common/mlx5/linux/mlx5_glue.c | 12 drivers/common/mlx5/linux/mlx5_glue.h | 1 + 3 fi

[dpdk-dev] [PATCH v2 0/2] control rules with identical pattern behavior

2021-07-05 Thread Jiawei Wang
In order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' is introduced. If allow, these rules be inserted successfully and only the first rule take affect. If disallow, the first rule will be inserted and other rules be rejected. The d

Re: [dpdk-dev] [PATCH v3] ethdev: add IPv4 and L4 checksum RSS offload types

2021-07-05 Thread Zhang, AlvinX
> > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index > > faf3bd9..1268729 100644 > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -537,6 +537,8 @@ struct rte_eth_rss_conf { > > #define ETH_RSS_PPPOE (1ULL << 31) > > #define ETH_RSS_ECP

[dpdk-dev] [Bug 733] [dpdk-19.11.9-rc2] make and meson build failed on Fedora33 with CLang11.0.0 and Fedora34 with Clang12.0.0

2021-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=733 Christian Ehrhardt (christian.ehrha...@canonical.com) changed: What|Removed |Added Status|IN_PROGRESS |RESOLVED

[dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
Currently, if dev_configure is not called or fails to be called, users can still call dev_start successfully. So it is necessary to have a flag which indicates whether the device is configured, to control whether dev_start can be called and eliminate dependency on user invocation order. The flag s

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread fengchengwen
Many thanks, mostly OK, a few comment inline On 2021/7/4 22:57, Andrew Rybchenko wrote: > On 7/2/21 4:18 PM, Chengwen Feng wrote: >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. [snip] >> +#ifndef _RTE_DMADEV_CORE_H_ >> +#define _RTE_DMADEV_CORE_H_ >> + >> +/** >>

[dpdk-dev] [PATCH V1] ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
Currently, if dev_configure is not called or fails to be called, users can still call dev_start successfully. So it is necessary to have a flag which indicates whether the device is configured, to control whether dev_start can be called and eliminate dependency on user invocation order. The falg s

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread fengchengwen
Many thanks, mostly OK, and a few comment inline On 2021/7/4 17:30, Jerin Jacob wrote: > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng wrote: >> >> This patch introduces 'dmadevice' which is a generic type of DMA >> device. ... >> +#include > > Sort in alphabetical order. > >> + >> +/** >> + *

Re: [dpdk-dev] [PATCH v3 0/2] add Rx/Tx offload paths for ICE AVX2

2021-07-05 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Friday, July 2, 2021 4:04 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhang, Qi Z > Subject: RE: [dpdk-dev] [PATCH v3 0/2] add Rx/Tx offload paths for ICE AVX2 > > > > -Original Message- > > From: dev On Behalf Of W

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-05 Thread Yu, PingX
Christian, As 21.08 RC1 are planned to be released on 7/7, this LTS 19.11.9-rc4 test report may be delayed to 7/13. Regards, Yu, Ping > -Original Message- > From: Christian Ehrhardt > Sent: Monday, July 5, 2021 9:23 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil

Re: [dpdk-dev] [PATCH v2 0/3] Support outer layer FDIR for GTPoGRE packet

2021-07-05 Thread Zhang, Qi Z
> -Original Message- > From: Liu, Lingyu > Sent: Tuesday, July 6, 2021 3:43 PM > To: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > ; Wu, Jingjing > Cc: Guo, Junfeng ; Liu, Lingyu > Subject: [PATCH v2 0/3] Support outer layer FDIR for GTPoGRE packet > > Add support for outer most L3 laye

Re: [dpdk-dev] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Jiang, YuX > Sent: Wednesday, June 30, 2021 6:33 PM > To: Xueming(Steven) Li ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Akhil > Goyal ; Ali Alnubani > ; Walker, Benjamin ; David > Christensen ; > Govindharajan, Hariprasad ; Hemant > Agrawal ;

Re: [dpdk-dev] 20.11.2 patches review and test

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Ali Alnubani > Sent: Thursday, July 1, 2021 11:54 PM > To: Xueming(Steven) Li ; sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; Akhil > Goyal ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@intel.com; Hemant Agrawal > ;

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 17:50, Andrew Rybchenko 写道: Hi Huisong, On 7/5/21 9:07 AM, Thomas Monjalon wrote: 05/07/2021 05:18, Huisong Li: 在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 19:22, Ananyev, Konstantin 写道: On 7/5/21 6:03 AM, Huisong Li wrote: 在 2021/7/3 19:04, Ananyev, Konstantin 写道: 在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your

Re: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop

2021-07-05 Thread Ruifeng Wang
> -Original Message- > From: Conor Walsh > Sent: Tuesday, July 6, 2021 1:06 AM > To: konstantin.anan...@intel.com; vladimir.medved...@intel.com; Ruifeng > Wang ; jer...@marvell.com > Cc: dev@dpdk.org; paulis.grib...@intel.com; Conor Walsh > > Subject: [PATCH] examples/l3fwd: remove useles

[dpdk-dev] [PATCH v2 3/3] doc: release note for GTPoGRE FDIR

2021-07-05 Thread Lingyu Liu
Refine 21.08 release note for GTPoGRE FDIR and RSS. Signed-off-by: Lingyu Liu --- doc/guides/rel_notes/release_21_08.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst index da4b066b38..d79ec0

[dpdk-dev] [PATCH v2 2/3] net/iavf: add AVF FDIR for GTPoGRE tunnel packet

2021-07-05 Thread Lingyu Liu
Add AVF FDIR for outer L3 header of GTPoGRE tunnel packet. Only pattern without inner most L3,L4 fields support outer dst/src ip FDIR. Support TEID and QFI field FDIR for GTPoGRE. +---+-+ |Pattern| Input Set

[dpdk-dev] [PATCH v2 1/3] net/iavf: add flow pattern for GTPoGRE

2021-07-05 Thread Lingyu Liu
Add GTPoGRE flow pattern with no inner fileds for AVF FDIR and RSS. Signed-off-by: Lingyu Liu --- drivers/net/iavf/iavf_generic_flow.c | 84 drivers/net/iavf/iavf_generic_flow.h | 8 +++ 2 files changed, 92 insertions(+) diff --git a/drivers/net/iavf/iavf_generic_f

[dpdk-dev] [PATCH v2 0/3] Support outer layer FDIR for GTPoGRE packet

2021-07-05 Thread Lingyu Liu
Add support for outer most L3 layer FDIR for GTPoGRE packet. GTPU TEID FDIR is supported for GTPoGRE flow pattern without inner L3,L4 fields. GTPU enhance header is supported. Lingyu Liu (3): net/iavf: add flow pattern for GTPoGRE net/iavf: add AVF FDIR for GTPoGRE tunnel packet doc: release

[dpdk-dev] [PATCH V2] pipeline: fix table entry read

2021-07-05 Thread Cristian Dumitrescu
The rte_swx_pipeline_table_entry_read() function is used to read from a character string a table entry that is to be added to the table, deleted from the table or set as the default entry of the table. Addition needs both the match and the part of the entry, deletion ignores the action part, while

[dpdk-dev] [PATCH] pipeline: fix table entry read

2021-07-05 Thread Cristian Dumitrescu
The rte_swx_pipeline_table_entry_read() function is used to read from a character string a table entry that is to be added to the table, deleted from the table or set as the default entry of teh table. Addition needs both the match and the part of the entry, deletion ignores the action part, while

Re: [dpdk-dev] [PATCH v4 49/62] net/cnxk: support initial version of rte flow

2021-07-05 Thread Thomas Monjalon
23/06/2021 06:46, Nithin Dabilpuram: > From: Kiran Kumar K > > Adding initial version of rte_flow support for cnxk family device. > Supported rte_flow ops are flow_validate, flow_create, flow_crstroy, flow_destroy? > flow_flush, flow_query, flow_isolate. > > Signed-off-by: Kiran Kumar K [...]

Re: [dpdk-dev] [PATCH v4 09/62] net/cnxk: add build infra and common probe

2021-07-05 Thread Thomas Monjalon
23/06/2021 06:46, Nithin Dabilpuram: > --- a/drivers/net/meson.build > +++ b/drivers/net/meson.build > @@ -12,6 +12,7 @@ drivers = [ > 'bnx2x', > 'bnxt', > 'bonding', > + 'cnxk', > 'cxgbe', > 'dpaa', > 'dpaa2', Wrong indent spotted with d

Re: [dpdk-dev] [PATCH v2 18/58] net/bnxt: shared TCAM region support

2021-07-05 Thread Thomas Monjalon
Please make the title start with an imperative verb. One more nit below. 13/06/2021 02:06, Ajit Khaparde: > From: Farah Smith > > - switch to single slice management on Wh+ > - Support of shared session WC_TCAM_HIGH and WC_TCAM_LOW regions > - Enable/disable using TF_TCAM_SHARED flag in tf_core.

Re: [dpdk-dev] [PATCH v2 08/58] net/bnxt: add action SRAM translation

2021-07-05 Thread Thomas Monjalon
13/06/2021 02:06, Ajit Khaparde: > From: Farah Smith > > - Translate Truflow action types for Thor to HCAPI RM > resource defined SRAM banks. > - move module type enum definitions to tf_core API > - Switch to subtype concept for RM. > - alloc/free working for Thor SRAM table type for full AR. >

Re: [dpdk-dev] [PATCH v3 00/32] add support for baseband phy

2021-07-05 Thread Thomas Monjalon
21/06/2021 17:04, Tomasz Duszynski: > Tomasz Duszynski (32): > common/cnxk: add bphy cgx/rpm initialization and cleanup > common/cnxk: support for communication with atf > common/cnxk: support for getting link information > common/cnxk: support for changing internal loopback > common/cnxk

[dpdk-dev] Canceled: DTS improvement WG - Debate/triag inputs - Extending for next 5 weeks

2021-07-05 Thread Honnappa Nagarahalli
Hello, We will continuing debating/triaging the inputs from [1]. As discussed, I am blocking the calendar for next 4 weeks. Thank you, Honnappa [1] https://docs.google.com/document/d/1c5S0_mZzFvzZfYkqyORLT2-qNvUb-fBdjA6DGusy4yM/edit#

Re: [dpdk-dev] DTS improvement WG - Debate/triag inputs - Extending for next 5 weeks

2021-07-05 Thread Honnappa Nagarahalli
Hi Lijuan, Sorry to hear that. Please take care, I will cancel the meeting for this week. Thanks, Honnappa From: Tu, Lijuan Sent: Sunday, July 4, 2021 11:59 PM To: Honnappa Nagarahalli ; Chen, Zhaoyan ; Buckley, Daniel M ; juraj.lin...@pantheon.tech; jer...@marvell.com; Linco

Re: [dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop

2021-07-05 Thread Ananyev, Konstantin
> > This patch aligns the l3fwd FIB code with the changes made to LPM in > commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM > main loop"). > This change ensures the compiler knows that the lcore config variables > are constant values and the compiler will then optimize the cod

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Bruce Richardson
On Mon, Jul 05, 2021 at 09:25:34PM +0530, Jerin Jacob wrote: > > On Mon, Jul 5, 2021 at 4:22 PM Bruce Richardson > wrote: > > > > On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: > > > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng > > > wrote: > > > > > > > > This patch introduces 'd

[dpdk-dev] [PATCH] examples/l3fwd: remove useless reloads in FIB main loop

2021-07-05 Thread Conor Walsh
This patch aligns the l3fwd FIB code with the changes made to LPM in commit 74fb854a3de6 ("examples/l3fwd: remove useless reloads in LPM main loop"). This change ensures the compiler knows that the lcore config variables are constant values and the compiler will then optimize the code accordingly.

Re: [dpdk-dev] [PATCH v8 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-05 Thread Thomas Monjalon
05/07/2021 08:45, Xueming Li: > Auxiliary bus [1] provides a way to split function into child-devices > representing sub-domains of functionality. Each auxiliary device > represents a part of its parent functionality. > > Auxiliary device is identified by unique device name, sysfs path: > /sys/b

Re: [dpdk-dev] atomic operations

2021-07-05 Thread Stephen Hemminger
On Mon, 5 Jul 2021 08:33:21 + Ruifeng Wang wrote: > > > > > > One simple example: increment a counter atomically. > > > > __atomic_fetch_add(&counter, 1, __ATOMIC_RELAXED); or > > > > __atomic_add_fetch(&counter, 1, __ATOMIC_RELAXED); > > > > I really hate how atomics are "documented" i

[dpdk-dev] rte_fbarray with Legacy mem

2021-07-05 Thread kumaraparameshwaran rathinavel
Hi All, I am facing an issue with 20.05 when legacy mem is being used. These are the logs added to the remap_segment function during eal_legacy_hugepage_init and found below EAL: remap_segment memseg_len:2097152 ms_idx:1095 msl->base_va:0x6020 post-addr:0x60008900 physaddr:21600

[dpdk-dev] [PATCH 6/6] doc: update mlx5 metering policy part

2021-07-05 Thread Bing Zhao
Added support for yellow color. Signed-off-by: Bing Zhao --- doc/guides/rel_notes/release_21_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst index a6ecfdf3ce..93566a8500 100644 --- a/doc/guides/rel_n

[dpdk-dev] [PATCH 5/6] net/mlx5: split policies handling of colors

2021-07-05 Thread Bing Zhao
If the fate action is either RSS or Queue of a meter policy, the action will only be created in the flow splitting stage. With queue as the fate action, only one sub-policy is needed. And RSS will have more than one sub-policies if there is an expansion. Since the RSS parameters are the same for b

[dpdk-dev] [PATCH 3/6] net/mlx5: enable meter bucket overflow for yellow color

2021-07-05 Thread Bing Zhao
To support the meter policy for yellow action, the prerequisite is that the hardware needs to support the EBS and then the yellow color of packets can be marked for the further steering. In the current implementation EBS and overflow were ignored when creating a meter profile. With this commit, if

[dpdk-dev] [PATCH 4/6] net/mlx5: added support for yellow policy rules

2021-07-05 Thread Bing Zhao
When creating a meter policy, both / either of the action rules for green and yellow colors may be provided. After validation, usually the actions are created before the meter is using by a flow rule. If there is action specified for the yellow color, the action rules should be created together wi

[dpdk-dev] [PATCH 2/6] net/mlx5: support yellow in meter policy validation

2021-07-05 Thread Bing Zhao
In the previous implementation, the policy for yellow color was not supported. The action validation for yellow was skipped. Since the yellow color policy needs to be supported, the validation should also be done for yellow color. In the meanwhile, due to the fact that color policies of one meter

[dpdk-dev] [PATCH 1/6] net/mlx5: add yellow color default policy

2021-07-05 Thread Bing Zhao
To support the yellow color for the default meter policy, the default policy action for yellow should be created together with the green policy. The default policy action for yellow action is the same as that for green. In the same table, the same matcher will be reused for yellow and the destinat

[dpdk-dev] [PATCH 0/6] support yellow color policy in mlx5

2021-07-05 Thread Bing Zhao
When creating a meter policy, the actions for yellow color can be specified together with green color. The mlx5 PMD now supports to set the policy for yellow. The actions list that is supported for yellow is the same as that for green. Bing Zhao (6): net/mlx5: add yellow color default policy

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Jerin Jacob
need On Mon, Jul 5, 2021 at 4:22 PM Bruce Richardson wrote: > > On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: > > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng > > wrote: > > > > > > This patch introduces 'dmadevice' which is a generic type of DMA > > > device. > > > > > > The AP

[dpdk-dev] [PATCH v6 7/7] l3fwd-power: support multiqueue in PMD pmgmt modes

2021-07-05 Thread Anatoly Burakov
Currently, l3fwd-power enforces the limitation of having one queue per lcore. This is no longer necessary, so remove the limitation. Signed-off-by: Anatoly Burakov --- examples/l3fwd-power/main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fw

[dpdk-dev] [PATCH v6 6/7] power: support monitoring multiple Rx queues

2021-07-05 Thread Anatoly Burakov
Use the new multi-monitor intrinsic to allow monitoring multiple ethdev Rx queues while entering the energy efficient power state. The multi version will be used unconditionally if supported, and the UMWAIT one will only be used when multi-monitor is not supported by the hardware. Signed-off-by: A

[dpdk-dev] [PATCH v6 5/7] power: support callbacks for multiple Rx queues

2021-07-05 Thread Anatoly Burakov
Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism relies on ethdev Rx callbacks, so it is very difficult

[dpdk-dev] [PATCH v6 4/7] power: remove thread safety from PMD power API's

2021-07-05 Thread Anatoly Burakov
Currently, we expect that only one callback can be active at any given moment, for a particular queue configuration, which is relatively easy to implement in a thread-safe way. However, we're about to add support for multiple queues per lcore, which will greatly increase the possibility of various

[dpdk-dev] [PATCH v6 3/7] eal: add power monitor for multiple events

2021-07-05 Thread Anatoly Burakov
Use RTM and WAITPKG instructions to perform a wait-for-writes similar to what UMWAIT does, but without the limitation of having to listen for just one event. This works because the optimized power state used by the TPAUSE instruction will cause a wake up on RTM transaction abort, so if we add the a

[dpdk-dev] [PATCH v6 2/7] net/af_xdp: add power monitor support

2021-07-05 Thread Anatoly Burakov
Implement support for .get_monitor_addr in AF_XDP driver. Signed-off-by: Anatoly Burakov --- Notes: v2: - Rewrite using the callback mechanism drivers/net/af_xdp/rte_eth_af_xdp.c | 34 + 1 file changed, 34 insertions(+) diff --git a/drivers/net/af_xdp/rte_e

[dpdk-dev] [PATCH v6 1/7] power_intrinsics: use callbacks for comparison

2021-07-05 Thread Anatoly Burakov
Previously, the semantics of power monitor were such that we were checking current value against the expected value, and if they matched, then the sleep was aborted. This is somewhat inflexible, because it only allowed us to check for a specific value in a specific way. This commit replaces the co

[dpdk-dev] [PATCH v6 0/7] Enhancements for PMD power management

2021-07-05 Thread Anatoly Burakov
This patchset introduces several changes related to PMD power management: - Changed monitoring intrinsics to use callbacks as a comparison function, based on previous patchset [1] but incorporating feedback [2] - this hopefully will make it possible to add support for .get_monitor_addr in virt

[dpdk-dev] [Bug 751] DPDK build error with gcc-12

2021-07-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=751 Bug ID: 751 Summary: DPDK build error with gcc-12 Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Norma

Re: [dpdk-dev] [PATCH v8 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-05 Thread Andrew Rybchenko
On 7/5/21 5:57 PM, Thomas Monjalon wrote: > 05/07/2021 11:35, Andrew Rybchenko: >> On 7/5/21 12:30 PM, Xueming(Steven) Li wrote: >>> From: Andrew Rybchenko I still don't understand if we really need to make the API a part of stable API/ABI in the future. Can it be internal? >>> >>> Ther

Re: [dpdk-dev] [PATCH v2 1/3] vhost: add unsafe API to drain pkts in async vhost

2021-07-05 Thread Pai G, Sunil
Hi Cheng, Comments inline. > +uint16_t rte_vhost_drain_queue_thread_unsafe(int vid, uint16_t > queue_id, > + struct rte_mbuf **pkts, uint16_t count) { > + struct virtio_net *dev = get_device(vid); > + struct vhost_virtqueue *vq; > + uint16_t n_pkts = count; > + > +

Re: [dpdk-dev] [PATCH v8 2/2] bus/auxiliary: introduce auxiliary bus

2021-07-05 Thread Thomas Monjalon
05/07/2021 11:35, Andrew Rybchenko: > On 7/5/21 12:30 PM, Xueming(Steven) Li wrote: > > From: Andrew Rybchenko > >> I still don't understand if we really need to make the API a part of > >> stable API/ABI in the future. Can it be internal? > > > > There was some discussion on this with Thomas in

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-05 Thread Bruce Richardson
On Mon, Jul 05, 2021 at 04:11:54PM +0200, David Marchand wrote: > On Fri, Jul 2, 2021 at 2:56 PM Bruce Richardson > wrote: > > > > When multi-process is not wanted and DPDK is run with the "no-shconf" > > flag, the telemetry library still needs a runtime directory to place the > > unix socket for

Re: [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used

2021-07-05 Thread David Marchand
On Fri, Jul 2, 2021 at 2:56 PM Bruce Richardson wrote: > > When multi-process is not wanted and DPDK is run with the "no-shconf" > flag, the telemetry library still needs a runtime directory to place the > unix socket for telemetry connections. Therefore, rather than not > creating the directory w

Re: [dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on socket bind failure

2021-07-05 Thread David Marchand
On Fri, Jul 2, 2021 at 2:56 PM Bruce Richardson wrote: > > If the library fails to create the needed socket, add an additional > check to report if the error is due to a missing DPDK runtime dir. > > Signed-off-by: Bruce Richardson Reviewed-by: David Marchand -- David Marchand

Re: [dpdk-dev] [PATCH v1] net/ice: support default RSS for IP fragment packet

2021-07-05 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Monday, July 5, 2021 2:43 PM > To: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Cc: Wu, Wenjun1 > Subject: [PATCH v1] net/ice: support default RSS for IP fragment packet > > This patch adds default RSS support for IPv4 and IPv6 fragmen

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Bruce Richardson
On Mon, Jul 05, 2021 at 01:12:54PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Monday, 5 July 2021 12.53 > > > > On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: > > > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng > >

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread David Marchand
On Mon, Jul 5, 2021 at 3:18 PM Wang, Haiyue wrote: > > > -Original Message- > > From: dev On Behalf Of David Marchand > > Sent: Tuesday, June 29, 2021 16:07 > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

[dpdk-dev] 19.11.9 patches review and test

2021-07-05 Thread Christian Ehrhardt
Hi all, Here is a list of patches targeted for stable release 19.11.9. The planned date for the final release is 19th July. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validation

Re: [dpdk-dev] [PATCH v3 2/2] eal: handle compressed firmwares

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Igor Russkikh ; Aaron Conole ; > Michael Santana > ; Richardson, Bruce ; > Rasesh Mody > ; Shahed Shaikh ; Yang, Qiming > ; Zhang, > Qi Z ; Heinrich Kuhn ; > Deven

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > Both "normal" and "dcf" inits have their copy of some firmwar

[dpdk-dev] [PATCH 21.11 3/3] app/test: add allocator performance autotest

2021-07-05 Thread Dmitry Kozlyuk
Memory allocator performance is crucial to applications that deal with large amount of memory or allocate frequently. DPDK allocator performance is affected by EAL options, API used and, at least, allocation size. New autotest is intended to be run with different EAL options. It measures performanc

[dpdk-dev] [PATCH 21.11 2/3] eal: add memory pre-allocation from existing files

2021-07-05 Thread Dmitry Kozlyuk
From: Viacheslav Ovsiienko The primary DPDK process launch might take a long time if initially allocated memory is large. From practice allocation of 1 TB of memory over 1 GB hugepages on Linux takes tens of seconds. Fast restart is highly desired for some applications and launch delay presents a

[dpdk-dev] [PATCH 21.11 1/3] eal/linux: make hugetlbfs analysis reusable

2021-07-05 Thread Dmitry Kozlyuk
get_hugepage_dir() searched for a hugetlbfs mount with a given page size using handcraft parsing of /proc/mounts and mixing traversal logic with selecting the needed entry. Separate code to enumerate hugetlbfs mounts to eal_hugepage_mount_walk() taking a callback that can inspect already parsed ent

[dpdk-dev] [PATCH 21.11 0/3] eal: add memory pre-allocation from existing files

2021-07-05 Thread Dmitry Kozlyuk
Hugepage allocation from the system takes time, resulting in slow startup or sporadic delays later. Most of the time spent in kernel is zero-filling memory for security reasons, which may be irrelevant in a controlled environment. The bottleneck is memory access speed, so for speeduup the amount of

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-05 Thread Maxime Coquelin
On 7/5/21 2:16 PM, Burakov, Anatoly wrote: > On 05-Jul-21 9:40 AM, Xuan Ding wrote: >> The use of IOMMU has many advantages, such as isolation and address >> translation. This patch extends the capbility of DMA engine to use >> IOMMU if the DMA device is bound to vfio. >> >> When set memory tabl

[dpdk-dev] [PATCH] doc: announce IPsec SA config option struct changes

2021-07-05 Thread Tejasree Kondoj
Proposing following new field for IPsec tunnel header verification in the structure ``rte_security_ipsec_sa_options``. enum rte_security_ipsec_tunnel_verify_mode tunnel_hdr_verify; It is used to indicate whether outer header verification need to be done as part of inbound IPsec processing. https:

Re: [dpdk-dev] [PATCH v5 1/2] vhost: enable IOMMU for async vhost

2021-07-05 Thread Burakov, Anatoly
On 05-Jul-21 9:40 AM, Xuan Ding wrote: The use of IOMMU has many advantages, such as isolation and address translation. This patch extends the capbility of DMA engine to use IOMMU if the DMA device is bound to vfio. When set memory table, the guest memory will be mapped into the default containe

Re: [dpdk-dev] [PATCH v4 1/2] kni: rework rte_kni_update_link using ioctl

2021-07-05 Thread Ferruh Yigit
On 7/4/2021 6:06 PM, Igor Ryzhov wrote: > Current implementation doesn't allow us to update KNI carrier if the > interface is not yet UP in kernel. It means that we can't use it in the > same thread which is processing rte_kni_ops.config_network_if, which is > very convenient, because it allows us

[dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field

2021-07-05 Thread Gregory Etelson
The new item allows PMD to offload IPv4 IHL field for matching, if hardware supports that operation. Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 12 +++- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1 + 2 files changed, 12 insertions(+), 1 deletion

[dpdk-dev] [PATCH] test/crypto: use formal array size macro

2021-07-05 Thread Rebecca Troy
Replaces the use of local ARRAY_SIZE macro, which is not used anywhere else, with the formal RTE_DIM macro for better consistency in crypto unit test. Signed-off-by: Rebecca Troy --- app/test/test_cryptodev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/app/test/te

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, July 5, 2021 18:00 > To: David Marchand ; Wang, Haiyue > > Cc: dev@dpdk.org; Yang, Qiming > Subject: RE: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > > > > -Original Message- > > From: David Marchan

Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading

2021-07-05 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Monday, July 5, 2021 16:34 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > On Mon, Jul 5, 2021 at 10:02 AM Wang, Haiyue wrote: > > >

[dpdk-dev] [PATCH v2 2/2] net/mlx5: add flow rule match for IPv4 IHL field

2021-07-05 Thread Gregory Etelson
Provide flow rules capability to match on IPv4 IHL field. Minimal HCA firmware version requiredto offload IPv4 IHL is xx_30_2000. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_21_08.rst | 3 +++ dri

[dpdk-dev] [PATCH v2 1/2] common/mlx5: query for hardware capability to offload IPv4 IHL field

2021-07-05 Thread Gregory Etelson
The patch queries MLX5 port hardware if it is capable to offload IPv4 IHL field. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers

[dpdk-dev] [PATCH v2 0/2] net/mlx5: add flow rule match for IPv4 IHL field

2021-07-05 Thread Gregory Etelson
Expand MLX5 PMD flows functionality with a match on IPV4 IHL field. Allow testpmd to cofigure IPv4 IHL values in flow rule. v2: - update release notes. - update MLX5 guide. - remove tespmd from the series. Gregory Etelson (2): common/mlx5: query for hardware capability to offload IPv4 IHL fiel

[dpdk-dev] [RFC] security: add option to configure tunnel header verification

2021-07-05 Thread Tejasree Kondoj
Add option to indicate whether outer header verification need to be done as part of inbound IPsec processing. With inline IPsec processing, SA lookup would be happening in the Rx path of rte_ethdev. When rte_flow is configured to support more than one SA, SPI would be used to lookup SA. In such ca

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Ananyev, Konstantin
> On 7/5/21 6:03 AM, Huisong Li wrote: > > > > 在 2021/7/3 19:04, Ananyev, Konstantin 写道: > >>> 在 2021/7/2 21:23, Ananyev, Konstantin 写道: > > On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: > >> @Thomas, @Ferruh, I tend to accept it (with minor style fixes), > >> but I need your opinion

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-05 Thread Christian Ehrhardt
On Mon, Jul 5, 2021 at 12:44 PM Ali Alnubani wrote: > > > -Original Message- > > From: Ali Alnubani > > Sent: Monday, July 5, 2021 9:35 AM > > To: Christian Ehrhardt > > Cc: sta...@dpdk.org; dev@dpdk.org; Abhishek Marathe > > ; Akhil Goyal ; > > benjamin.wal...@intel.com; David Christense

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Monday, 5 July 2021 12.53 > > On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: > > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng > wrote: > > > > > > + > > > +/** > > > + * The data structure associated wit

Re: [dpdk-dev] [PATCH v2] ethdev: keep count of allocated and used representor ranges

2021-07-05 Thread Xueming(Steven) Li
> -Original Message- > From: Andrew Rybchenko > Sent: Monday, July 5, 2021 6:03 PM > To: Matan Azrad ; Shahaf Shuler ; Slava > Ovsiienko ; NBU- > Contact-Thomas Monjalon ; Ferruh Yigit > ; Xueming(Steven) Li > > Cc: dev@dpdk.org; Viacheslav Galaktionov > ; sta...@dpdk.org > Subject:

Re: [dpdk-dev] [PATCH 21.11] telemetry: remove experimental tags from APIs

2021-07-05 Thread Bruce Richardson
On Mon, Jul 05, 2021 at 11:09:38AM +0100, Power, Ciara wrote: > > > >-Original Message- > >From: Richardson, Bruce > >Sent: Friday 2 July 2021 16:23 > >To: dev@dpdk.org > >Cc: Ray Kinsella ; Power, Ciara ; > >Richardson, Bruce > >Subject: [PATCH 21.11] telemetry: remove experimental tag

[dpdk-dev] rte_get_tsc_cycles function slowly increase ?

2021-07-05 Thread ??????
hi all, rte_get_tsc_cycles function slowly increase, gettimeofday function is normally increase. The following pseudo-code is my test example: ``` uint64_t hz = rte_get_tsc_hz(); uint64_t start_cycles = rte_get_tsc_cycles(); // running on first cpuuint64_t start_time = gettimeofday(

Re: [dpdk-dev] [PATCH] dmadev: introduce DMA device library

2021-07-05 Thread Bruce Richardson
On Sun, Jul 04, 2021 at 03:00:30PM +0530, Jerin Jacob wrote: > On Fri, Jul 2, 2021 at 6:51 PM Chengwen Feng wrote: > > > > This patch introduces 'dmadevice' which is a generic type of DMA > > device. > > > > The APIs of dmadev library exposes some generic operations which can > > enable configurat

Re: [dpdk-dev] 19.11.9 patches review and test

2021-07-05 Thread Ali Alnubani
> -Original Message- > From: Ali Alnubani > Sent: Monday, July 5, 2021 9:35 AM > To: Christian Ehrhardt > Cc: sta...@dpdk.org; dev@dpdk.org; Abhishek Marathe > ; Akhil Goyal ; > benjamin.wal...@intel.com; David Christensen ; > hariprasad.govindhara...@intel.com; Hemant Agrawal > ; Ian Stok

Re: [dpdk-dev] dmadev discussion summary

2021-07-05 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > Sent: Sunday, 4 July 2021 09.43 > > On Sat, Jul 3, 2021 at 5:54 PM Morten Brørup > wrote: > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > > Sent: Saturday, 3 July 2021 11.09 > > > > > > On Sat, Jul

Re: [dpdk-dev] [PATCH v5 5/7] power: support callbacks for multiple Rx queues

2021-07-05 Thread Burakov, Anatoly
On 01-Jul-21 10:01 AM, David Hunt wrote: On 30/6/2021 10:52 AM, David Hunt wrote: Hi Anatoly, On 29/6/2021 4:48 PM, Anatoly Burakov wrote: Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as mo

Re: [dpdk-dev] [PATCH v5 5/7] power: support callbacks for multiple Rx queues

2021-07-05 Thread Burakov, Anatoly
On 30-Jun-21 12:04 PM, Ananyev, Konstantin wrote: Currently, there is a hard limitation on the PMD power management support that only allows it to support a single queue per lcore. This is not ideal as most DPDK use cases will poll multiple queues per core. The PMD power management mechanism

Re: [dpdk-dev] Use WFE for spinlock and ring

2021-07-05 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Monday, July 5, 2021 4:52 PM > To: Ruifeng Wang > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; tho...@monjalon.net; dev > ; jer...@marvell.com; nd > Subject: Re: Use WFE for spinlock and ring > > On Fri, May 7, 2021 at 12:24 PM Bruc

Re: [dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on socket bind failure

2021-07-05 Thread Power, Ciara
>-Original Message- >From: Morten Brørup >Sent: Friday 2 July 2021 15:23 >To: Richardson, Bruce ; dev@dpdk.org >Cc: Power, Ciara >Subject: RE: [dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on >socket bind failure > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce

  1   2   >