Re: [dpdk-dev] [PATCH 2/5] lib/vhost: implement rte_power_monitor API

2021-09-16 Thread Li, Miao
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, September 15, 2021 4:52 PM > To: Li, Miao ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH 2/5] lib/vhost: implement rte_power_monitor API > > Hi Miao, > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH 1/5] net/virtio: implement rte_power_monitor API

2021-09-16 Thread Li, Miao
Hi chenbo > -Original Message- > From: Xia, Chenbo > Sent: Wednesday, September 15, 2021 4:45 PM > To: Li, Miao ; dev@dpdk.org > Cc: maxime.coque...@redhat.com > Subject: RE: [PATCH 1/5] net/virtio: implement rte_power_monitor API > > Hi Miao, > > > -Original Message- > > From:

[dpdk-dev] [PATCH v2 2/2] vhost: enable IOMMU for async vhost

2021-09-16 Thread Xuan Ding
The use of IOMMU has many advantages, such as isolation and address translation. This patch extends the capbility of DMA engine to use IOMMU if the DMA engine is bound to vfio. When set memory table, the guest memory will be mapped into the default container of DPDK. Signed-off-by: Xuan Ding ---

[dpdk-dev] [PATCH v2 1/2] vfio: allow partially unmapping adjacent memory

2021-09-16 Thread Xuan Ding
Currently, if we map a memory area A, then map a separate memory area B that by coincidence happens to be adjacent to A, current implementation will merge these two segments into one, and if partial unmapping is not supported, these segments will then be only allowed to be unmapped in one go. In ot

[dpdk-dev] [PATCH v2 0/2] support IOMMU for DMA device

2021-09-16 Thread Xuan Ding
This series supports DMA device to use vfio in async vhost. The first patch extends the capability of current vfio dma mapping API to allow partial unmapping for adjacent memory if the platform does not support partial unmapping. The second patch involves the IOMMU programming for guest memory in

Re: [dpdk-dev] [PATCH v2 1/6] security: add SA lifetime configuration

2021-09-16 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, September 16, 2021 4:36 PM > To: Anoob Joseph ; Akhil Goyal > ; Doherty, Declan ; > Zhang, Roy Fan > Cc: Jerin Jacob Kollanukkaran ; Archana Muniganti > ; Tejasree Kondoj

[dpdk-dev] [PATCH] common/cnxk: fix incorrect free of MCAM counter

2021-09-16 Thread psatheesh
From: Satheesh Paul Upon MCAM allocation failure, free counters only if counters were allocated earlier for the flow rule. Fixes: f9af9080746 ("common/cnxk: add mcam utility API") Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc_mcam.c | 3 ++- 1 file changed, 2 insertions(+), 1 d

Re: [dpdk-dev] [PATCH] app/testpmd: fix statistics in multiple process

2021-09-16 Thread Min Hu (Connor)
Hi, Xiaoyun, 在 2021/9/16 13:17, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Tuesday, September 14, 2021 11:13 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH] app/testpmd: fix statistics in multiple process Currently, 'clear port stats all' in

Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address

2021-09-16 Thread Xia, Chenbo
Hi David, > -Original Message- > From: David Marchand > Sent: Friday, September 10, 2021 3:18 PM > To: Xia, Chenbo > Cc: dev ; Dumitrescu, Cristian ; > Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of > PCI ID and address > > On Fri, Sep 10, 2

[dpdk-dev] [PATCH v2 2/2] app/test: Delete cmdline free function

2021-09-16 Thread zhihongx . peng
From: Zhihong Peng Cmdline will be released in cmdline_stdin_exit function, so it does not need to be released here. Fixes: acdabc450ea0 (test: fix terminal settings on exit) Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- app/test/test.c | 1 - app/test/test_cmdline_lib.c | 1

[dpdk-dev] [PATCH v2 1/2] lib/cmdline: release cl when cmdline exit

2021-09-16 Thread zhihongx . peng
From: Zhihong Peng Malloc cl in the cmdline_stdin_new function, so release in the cmdline_stdin_exit function is logical, so that cl will not be released alone. Fixes: af75078fece3 (first public release) Cc: sta...@dpdk.org Signed-off-by: Zhihong Peng --- lib/cmdline/cmdline_socket.c | 1 + 1

Re: [dpdk-dev] [PATCH 00/12] ice base code batch 2 for DPDK 21.11

2021-09-16 Thread Guo, Junfeng
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, September 16, 2021 17:53 > To: Yang, Qiming > Cc: Guo, Junfeng ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 00/12] ice base code batch 2 for DPDK 21.11 > > Qi Zhang (12): > net/ice/base: calculate logical PF ID > net/i

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-16 Thread Huisong Li
在 2021/9/16 18:36, Thomas Monjalon 写道: 16/09/2021 10:01, Huisong Li: 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling rte_eth_dev_close() will release resources of eth device and close it. But rt

Re: [dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf

2021-09-16 Thread Zhang, RobinX
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 17, 2021 12:28 AM > To: Zhang, RobinX ; dev@dpdk.org > Cc: Wang, Haiyue ; Xing, Beilei > ; m...@ashroe.eu; Wu, Jingjing > ; Burakov, Anatoly ; > Zhang, Qi Z ; Guo, Junfeng ; > Yang, SteveX > Subject: Re: [dpd

[dpdk-dev] [PATCH v2 2/2] app/testpmd: fix txonly forwording

2021-09-16 Thread Alvin Zhang
When random number of Tx segments is enabled, because the actual number of segments may be only one, the first segment of the Tx packets must accommodate a complete being sending Eth/IP/UDP packet. Besides, if multiple flow is enabled, the forwarding will update the IP and UDP header, these header

[dpdk-dev] [PATCH v2 1/2] app/testpmd: update forward engine beginning

2021-09-16 Thread Alvin Zhang
For each forward engine, there may be some special conditions must be meet before the forwarding run. Adding checks for these conditions in configuring is not suitable, because one condition may rely on multiple configurations, and the conditions required by each forward engine is not general. Th

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-09-16 Thread Min Hu (Connor)
Hi, Ferruh, What is the status of this set of your patches ? Could they be merged? 在 2021/7/22 22:43, Stephen Hemminger 写道: On Thu, 22 Jul 2021 13:15:04 +0300 Andrew Rybchenko wrote: I don't think we care about type of transmission in this level, I assume we define min MTU ma

Re: [dpdk-dev] [RFC] ethdev: improve link speed to string

2021-09-16 Thread Min Hu (Connor)
Agree with you. Thanks Andrew 在 2021/9/16 16:21, Andrew Rybchenko 写道: On 9/16/21 11:16 AM, Min Hu (Connor) wrote: Hi, Andrew, 在 2021/9/16 14:22, Andrew Rybchenko 写道: On 9/16/21 5:56 AM, Min Hu (Connor) wrote: Currently, link speed to string only supports specific speeds, like 10M, 100M, 1G e

Re: [dpdk-dev] [EXT] [PATCH 1/2] security: use the net library for IP structs

2021-09-16 Thread Tal Shnaiderman
> Subject: RE: [EXT] [PATCH 1/2] security: use the net library for IP structs > > External email: Use caution opening links or attachments > > > > Remove the netinet includes and replaces them with rte_ip.h to support > > the in_addr/in6_addr structs on all operating systems. > > > > Signed-off-

[dpdk-dev] [PATCH v10 12/12] MAINTAINERS: add entry for new packet capture features

2021-09-16 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 77a549a5e8c2..df160477a217 100644 --- a

[dpdk-dev] [PATCH v10 11/12] doc: changes for new pcapng and dumpcap

2021-09-16 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v10 10/12] test: enable bpf autotest

2021-09-16 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.

[dpdk-dev] [PATCH v10 09/12] test: add a test for pcapng library

2021-09-16 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v10 08/12] test: add test for bpf_convert

2021-09-16 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 200 1 file changed, 200 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..543a5fd6

[dpdk-dev] [PATCH v10 07/12] app/dumpcap: add new packet capture application

2021-09-16 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-16 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v10 05/12] bpf: add function to dump eBPF instructions

2021-09-16 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 + lib

[dpdk-dev] [PATCH v10 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-09-16 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v10 03/12] bpf: allow self-xor operation

2021-09-16 Thread Stephen Hemminger
Some BPF programs may use XOR of a register with itself as a way to zero register in one instruction. The BPF filter converter generates this in the prolog to the generated code. The BPF validator would not allow this because the value of register was undefined. But after this operation it always

[dpdk-dev] [PATCH v10 02/12] lib: pdump is not supported on Windows

2021-09-16 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v10 01/12] librte_pcapng: add new library for writing pcapng files

2021-09-16 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v10 00/12] Packet capture framework enhancements

2021-09-16 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments

2021-09-16 Thread David Marchand
On Wed, Sep 1, 2021 at 11:59 AM Bruce Richardson wrote: > > On Wed, Sep 01, 2021 at 09:38:47AM +, Conor Walsh wrote: > > This patch fixes a memleak which was reported in Bugzilla within the > > eal_save_args function. This was caused by the function mistakenly > > adding -- to the eal args ins

Re: [dpdk-dev] [PATCH v3 00/13] enhancements to host based flow table management

2021-09-16 Thread Ajit Khaparde
On Thu, Sep 16, 2021 at 6:26 AM Ferruh Yigit wrote: > > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > This patch set adds support for new offload features/enhancments for > > Thor adapters like VF representor support, new flow matches/actions > > & dynamic SRAM manager support. > > > > v2 ==> v3

[dpdk-dev] [PATCH] net: fix checksum API documentation

2021-09-16 Thread Lance Richardson
Minor corrections and improvements to documentation for checksum APIs. Fixes: 6006818cfb26 ("net: new checksum functions") Fixes: 45a08ef55e44 ("net: introduce functions to verify L4 checksums") Cc: sta...@dpdk.org Signed-off-by: Lance Richardson --- lib/net/rte_ip.h | 8 1 file changed

Re: [dpdk-dev] [PATCH v3 01/13] net/bnxt: tf core index table updates

2021-09-16 Thread Ajit Khaparde
On Thu, Sep 16, 2021 at 6:47 AM Ferruh Yigit wrote: > > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > From: Farah Smith > > > > Remove unused shadow table functionality. > > > > Can you please update 'tf' (or 'TF') in the patch titles with 'TruFlow', to > make > it more clear and consistent wi

[dpdk-dev] [PATCH v2] net/virtio: handle Tx checksums correctly for tunnel packets

2021-09-16 Thread Ivan Malov
Tx prepare method calls rte_net_intel_cksum_prepare(), which handles tunnel packets correctly, but Tx burst path does not take tunnel presence into account when computing the offsets. Fixes: 58169a9c8153 ("net/virtio: support Tx checksum offload") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Re

Re: [dpdk-dev] [PATCH 28/32] net/ngbe: add IPsec context creation

2021-09-16 Thread Ferruh Yigit
On 9/16/2021 10:00 AM, Hemant Agrawal wrote: > > On 9/15/2021 10:28 PM, Ferruh Yigit wrote: >> On 9/8/2021 9:37 AM, Jiawen Wu wrote: >>> Initialize securiry context, and support to get security >>> capabilities. >>> >>> Signed-off-by: Jiawen Wu >> <...> >> >>> --- a/drivers/net/ngbe/ngbe_ethdev.c

Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size

2021-09-16 Thread Jerin Jacob
On Thu, Sep 16, 2021 at 8:46 PM Ferruh Yigit wrote: > > On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote: > > NPA stack should be aligned to ROC cache line size. > > > > Can you please document the long versions of 'NPA' & 'ROC' abbreviations? > > Also for the patch title, since abbreviations needs t

Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model

2021-09-16 Thread Ferruh Yigit
On 9/16/2021 5:29 PM, Venkat Duvvuru wrote: > On Thu, Sep 16, 2021 at 7:20 PM Ferruh Yigit wrote: >> >> On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: >>> diff --git a/meson_options.txt b/meson_options.txt >>> index 0e92734c49..f686e6d92a 100644 >>> --- a/meson_options.txt >>> +++ b/meson_options.txt

Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model

2021-09-16 Thread Venkat Duvvuru
On Thu, Sep 16, 2021 at 7:20 PM Ferruh Yigit wrote: > > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > diff --git a/meson_options.txt b/meson_options.txt > > index 0e92734c49..f686e6d92a 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -46,3 +46,5 @@ option('tests', type: 'bo

Re: [dpdk-dev] [PATCH v5 0/3] net/i40e: remove i40evf

2021-09-16 Thread Ferruh Yigit
On 9/15/2021 4:09 AM, Robin Zhang wrote: > In DPDK 21.05, iavf already became the default VF for i40e devices. > So remove i40evf due to it's no need to maintain now. > > v5: > - rebase code. > > v4: > - resolve compile warning issue. > > v3: > - remove VF related code in i40e_rxtx.c. > > v2: >

Re: [dpdk-dev] [PATCH v4 1/2] config/arm: split march cfg into arch and features

2021-09-16 Thread Thomas Monjalon
17/08/2021 12:56, Juraj Linkeš: > Older compilers may not support all arch versions and all features that > the target SoC supports, in which case it's better to figure out the > highest arch version and features that the compiler supports. Implement > a way to achieve this: > 1. Find the highest a

Re: [dpdk-dev] [PATCH] net/i40e: fix mbuf leak

2021-09-16 Thread Ferruh Yigit
On 9/13/2021 3:29 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: dev On Behalf Of >> chenqiming_hua...@163.com >> Sent: Monday, August 23, 2021 9:51 AM >> To: dev@dpdk.org >> Cc: Xing, Beilei ; Qiming Chen >> ; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] net/i40e: fix mbuf

Re: [dpdk-dev] [PATCH v3] net/ice: refine flow priority support in PF

2021-09-16 Thread Ferruh Yigit
On 9/8/2021 5:58 AM, Yuying Zhang wrote: > The usage of priority is converse in pipeline mode and > non-pipeline mode. Refine attribute priority support of flow > filter in PF driver. When priority is 0, rules are created in > switch filter first and FDIR is used as backup. When priority > is 1, ru

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Thomas Monjalon
16/09/2021 17:43, Xueming(Steven) Li: > On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > > 15/09/2021 15:02, Xueming Li: > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > - RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_release, > > > -ENOTSUP); > >

Re: [dpdk-dev] [PATCH v2] ethdev: change queue release callback

2021-09-16 Thread Xueming(Steven) Li
On Thu, 2021-09-16 at 10:09 +0200, Thomas Monjalon wrote: > 15/09/2021 15:02, Xueming Li: > > To align with other eth device queue configuration callbacks, cleanup > > queue release callback API by changing RX and TX queue release callback > > API parameter from queue object to device and queue ind

Re: [dpdk-dev] [PATCH] examples/service_cores: fix lcore count check

2021-09-16 Thread Thomas Monjalon
31/08/2021 18:09, Van Haaren, Harry: > From: Ruifeng Wang > > Fixes: 7f6ee6aee717 ("examples/service_cores: check cores before run") > > Cc: sta...@dpdk.org > > Cc: vipin.vargh...@intel.com > > > > Signed-off-by: Ruifeng Wang > > Change makes sense to me, this was introduced in Oct 2020 > so a

Re: [dpdk-dev] [PATCH] examples/service_cores: fix lcore count check

2021-09-16 Thread David Marchand
On Tue, Aug 31, 2021 at 6:12 PM Van Haaren, Harry wrote: > > The example has various profiles to run services on specified > > number of lcores. Due to incorrect boundary condition, service > > can be dispatched to a core that does not exist. This puts main > > core into endless wait. > > > > Max

Re: [dpdk-dev] [PATCH v2] eal: remove the deprecated whitelist/blacklist and master/slave API's

2021-09-16 Thread David Marchand
On Mon, Aug 23, 2021 at 5:07 PM Stephen Hemminger wrote: > > New API's for these were added in 20.11 and the old API was retained > but marked deprecated. Since 21.11 is the next LTS, it is time > to remove the deprecated ones. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ruifeng Wang Fixe

Re: [dpdk-dev] [PATCH v9 03/12] bpf: allow self-xor operation

2021-09-16 Thread Ananyev, Konstantin
> Some BPF programs may use XOR of a register with itself > as a way to zero register in one instruction. > The BPF filter converter generates this in the prolog > to the generated code. > > The BPF validator would not allow this because the value of > register was undefined. But after this oper

Re: [dpdk-dev] [PATCH 2/8] cryptodev: move inline APIs into separate structure

2021-09-16 Thread Ananyev, Konstantin
Hi Akhil, Overall, looks good to me. Few comments below. Konstantin > Move fastpath inline function pointers from rte_cryptodev into a > separate structure accessed via a flat array. > The intension is to make rte_cryptodev and related structures private > to avoid future API/ABI breakages. > >

Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size

2021-09-16 Thread Ferruh Yigit
On 8/30/2021 2:52 PM, Ashwin Sekhar T K wrote: > NPA stack should be aligned to ROC cache line size. > Can you please document the long versions of 'NPA' & 'ROC' abbreviations? Also for the patch title, since abbreviations needs to be uppercase, to automate the check for these abbreviations, can

Re: [dpdk-dev] [PATCH v4] test/func_reentrancy: free memzones after creating test

2021-09-16 Thread David Marchand
On Thu, Sep 16, 2021 at 5:04 PM Olivier Matz wrote: > > On Sun, Aug 22, 2021 at 09:57:40PM -0500, Joyce Kong wrote: > > Function reentrancy test limits maximum number of iterations > > simultaneously, however it doesn't free the 'fr_test_once' > > memzones after the fact, so introduce freeing 'fr_

Re: [dpdk-dev] [PATCH v4] test/func_reentrancy: free memzones after creating test

2021-09-16 Thread Olivier Matz
On Sun, Aug 22, 2021 at 09:57:40PM -0500, Joyce Kong wrote: > Function reentrancy test limits maximum number of iterations > simultaneously, however it doesn't free the 'fr_test_once' > memzones after the fact, so introduce freeing 'fr_test_once' > in ring/mempool/hash/fbk/lpm_clean. > > Meanwhile

Re: [dpdk-dev] [PATCH 1/2] common/cnxk: update roc models

2021-09-16 Thread Jerin Jacob
On Mon, Aug 30, 2021 at 10:00 PM Ashwin Sekhar T K wrote: > > Update roc models. Please update git comment for more details on what is updated. > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/common/cnxk/roc_model.c | 51 +++ > drivers/common/cnxk/roc_model.h

Re: [dpdk-dev] [PATCH 2/2] common/cnxk: avoid using stashing option of stype

2021-09-16 Thread Jerin Jacob
On Mon, Aug 30, 2021 at 10:00 PM Ashwin Sekhar T K wrote: > > Avoid using stashing option of stype in NPA in cn10k-a0 stepping. > > This is a workaround for a HW Errata due to which NPA stashing operations > will never result in writing the data into L2 cache. But instead, it will > be written int

Re: [dpdk-dev] [PATCH] doc: remove references to the old build system

2021-09-16 Thread David Marchand
On Wed, Sep 15, 2021 at 6:28 PM Thomas Monjalon wrote: > > Some docs and comments in Meson files are still mentioning > the old build system based on "make", removed in 20.11. > After one year, such references are better to be removed. > > Signed-off-by: Thomas Monjalon Acked-by: David Marchand

Re: [dpdk-dev] [PATCH 1/2] common/cnxk: send link event to VF

2021-09-16 Thread Jerin Jacob
On Fri, Jul 30, 2021 at 9:38 PM Harman Kalra wrote: > > Currently link event is only sent to the PF by AF as soon as it comes > up, or in case of any physical change in link. PF will broadcast > these link events to all its VFs as soon as it receives it. > But no event is sent when a new VF comes

Re: [dpdk-dev] [PATCH] common/cnxk: support for dual VLAN insert and strip actions

2021-09-16 Thread Jerin Jacob
On Tue, Sep 7, 2021 at 7:28 AM Jerin Jacob wrote: > > On Mon, Jul 19, 2021 at 11:12 AM wrote: > > > > From: Satheesh Paul > > > > Add roc API to configure dual VLAN tag addition and removal. > > > > Signed-off-by: Satheesh Paul Acked-by: Jerin Jacob > > Added following in release notes > +

Re: [dpdk-dev] [PATCH] common/cnxk: align npa stack to roc cache line size

2021-09-16 Thread Jerin Jacob
On Mon, Aug 30, 2021 at 7:23 PM Ashwin Sekhar T K wrote: > > NPA stack should be aligned to ROC cache line size. > > Fixes: f765f5611240 ("common/cnxk: add NPA pool HW operations") > > Signed-off-by: Ashwin Sekhar T K Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks >

Re: [dpdk-dev] [PATCH] doc: remove template comments in old release notes

2021-09-16 Thread David Marchand
On Wed, Sep 15, 2021 at 6:25 PM Thomas Monjalon wrote: > > The release notes comments mention how to generate the documentation > with the old & removed build system. > > Rather than fixing these comments, all old release notes comments > are removed, because they are useful only for the current r

Re: [dpdk-dev] [PATCH v2] net/virtio: remove blank lines in log

2021-09-16 Thread David Marchand
On Thu, Sep 16, 2021 at 11:53 AM Thomas Monjalon wrote: > > The macros PMD_*_LOG already include the line feed character. > Redundant \n are removed. > > Signed-off-by: Thomas Monjalon > Reviewed-by: David Marchand > Reviewed-by: Chenbo Xia > --- > v2: fix more macros than PMD_INIT_LOG Just co

Re: [dpdk-dev] [PATCH v3 00/13] enhancements to host based flow table management

2021-09-16 Thread Brandon Lo
On Thu, Sep 16, 2021 at 9:26 AM Ferruh Yigit wrote: > > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > This patch set adds support for new offload features/enhancments for > > Thor adapters like VF representor support, new flow matches/actions > > & dynamic SRAM manager support. > > > > v2 ==> v3

Re: [dpdk-dev] [RFC PATCH] build/pkg-config: remove machine arch flag

2021-09-16 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Ruifeng Wang > Sent: Thursday, September 16, 2021 6:17 PM > To: Jerin Jacob ; David Christensen > > Cc: Bruce Richardson ; dpdk-dev > ; Luca Boccassi ; David Marchand > ; ian.sto...@intel.com; Ilya Maximets > ; jer...@marvell.com; Honnappa Nag

Re: [dpdk-dev] [PATCH v3 13/13] net/bnxt: add enhancements to TF ULP

2021-09-16 Thread Ferruh Yigit
On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > From: Kishore Padmanabha > > 1. Added support to specify l4 port masks in the template. Also enabled >source mac in the wild card key for ingress flows. > > 2. Added support to enable offload for ipv6 traffic within the vxlan >tunnel connecti

[dpdk-dev] [PATCH v2] net/iavf: fix mbuf leak

2021-09-16 Thread Qiming Chen
In the iavf_dev_rx_queue_start function, if the iavf_switch_queue or iavf_switch_queue_lv function fails, the previously applied mbuf is not released, resulting in leakage. The patch fixes the problem. Fixes: 9cf9c02bf6ee ("net/iavf: add enable/disable queues for large VF") Cc: sta...@dpdk.org Si

Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model

2021-09-16 Thread Thomas Monjalon
16/09/2021 16:01, Bruce Richardson: > On Thu, Sep 16, 2021 at 02:49:57PM +0100, Ferruh Yigit wrote: > > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > > diff --git a/meson_options.txt b/meson_options.txt > > > index 0e92734c49..f686e6d92a 100644 > > > --- a/meson_options.txt > > > +++ b/meson_opti

Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model

2021-09-16 Thread Bruce Richardson
On Thu, Sep 16, 2021 at 02:49:57PM +0100, Ferruh Yigit wrote: > On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > > diff --git a/meson_options.txt b/meson_options.txt > > index 0e92734c49..f686e6d92a 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -46,3 +46,5 @@ option('tests', ty

Re: [dpdk-dev] [PATCH v3 11/13] net/bnxt: dynamically allocate space for EM defrag function

2021-09-16 Thread Ferruh Yigit
On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > From: Randy Schacher > > Alter defrag function to dynamically allocate and delete > free_list and adj_list buffers. > Can you explain a little more the reasoning/motivation/impact of the change, why buffers are dynamically allocated, is there any im

Re: [dpdk-dev] [PATCH v3 04/13] net/bnxt: add Thor SRAM mgr model

2021-09-16 Thread Ferruh Yigit
On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > diff --git a/meson_options.txt b/meson_options.txt > index 0e92734c49..f686e6d92a 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -46,3 +46,5 @@ option('tests', type: 'boolean', value: true, description: > 'build unit tests') >

Re: [dpdk-dev] [PATCH v3 01/13] net/bnxt: tf core index table updates

2021-09-16 Thread Ferruh Yigit
On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > From: Farah Smith > > Remove unused shadow table functionality. > Can you please update 'tf' (or 'TF') in the patch titles with 'TruFlow', to make it more clear and consistent with the previous commits? Ajit, Also can you add 'TruFlow' to the 'de

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Gaoxiang Liu
Hi Chenbo, liugaoxi...@huawei.com and gaoxiangl...@163.com both are my email addresses. You can align to liugaoxi...@huawei.com or gaoxiangl...@163.com when applying the patch. And the email address of liugaoxi...@huawei.com now has only the permission to receive emails, but not the per

Re: [dpdk-dev] [PATCH v3 00/13] enhancements to host based flow table management

2021-09-16 Thread Ferruh Yigit
On 9/11/2021 4:30 PM, Venkat Duvvuru wrote: > This patch set adds support for new offload features/enhancments for > Thor adapters like VF representor support, new flow matches/actions > & dynamic SRAM manager support. > > v2 ==> v3 > = > * Fixed compilation issue. > > Farah Smith (4): >

[dpdk-dev] [PATCH] net/virtio: do not use PMD log type

2021-09-16 Thread David Marchand
Fixes: 1982462eadea ("net/virtio: add Rx free threshold setting") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/virtio_rxtx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Xia, Chenbo
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 16, 2021 8:57 PM > To: Xia, Chenbo ; Maxime Coquelin > ; Gaoxiang Liu > Cc: dev@dpdk.org; liugaoxi...@huawei.com; sta...@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of sock

[dpdk-dev] app/test: fix pdcp short mac test

2021-09-16 Thread Fan Zhang
Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I") Cc: g.si...@nxp.com This patch fixes the pdcp short mac-i test by removing them from snow3g and kasumi test suite and move to pdcp test suite. This is to prevent incorrect failure for crypto device not support pdcp. Signed-off-by: Fan

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Ferruh Yigit
On 9/16/2021 1:37 PM, Xia, Chenbo wrote: >> -Original Message- >> From: Maxime Coquelin >> Sent: Thursday, September 16, 2021 8:33 PM >> To: Yigit, Ferruh ; Gaoxiang Liu >> ; Xia, Chenbo >> Cc: dev@dpdk.org; liugaoxi...@huawei.com; sta...@dpdk.org; Thomas Monjalon >> >> Subject: Re: [dpd

[dpdk-dev] [PATCH v5 2/2] test/event: Add rx queue conf get test in rx adapter autotest

2021-09-16 Thread Ganapati Kundapura
Add unit tests for rte_event_eth_rx_adapter_queue_conf_get() in rx adapter autotest Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_rx_adapter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_e

[dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-16 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_queue_conf_get() API to get rx queue information - event queue identifier, flags for handling received packets, scheduler type, event priority, polling frequency of the receive queue and flow identifier in rte_event_eth_rx_adapter_queue_conf structure Signed-off-by:

[dpdk-dev] [PATCH v5 2/2] test/event: Add rx queue conf get test in rx adapter autotest

2021-09-16 Thread Ganapati Kundapura
Add unit tests for rte_event_eth_rx_adapter_queue_conf_get() in rx adapter autotest Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_rx_adapter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_e

[dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-16 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_queue_conf_get() API to get rx queue information - event queue identifier, flags for handling received packets, scheduler type, event priority, polling frequency of the receive queue and flow identifier in rte_event_eth_rx_adapter_queue_conf structure Signed-off-by:

Re: [dpdk-dev] [PATCH v5 04/10] mbuf: add IPsec ESP tunnel type

2021-09-16 Thread Olivier Matz
On Fri, Sep 10, 2021 at 12:32:34PM +0100, Radu Nicolau wrote: > Add tunnel type for IPsec ESP tunnels > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > Acked-by: Akhil Goyal Acked-by:

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, September 16, 2021 8:33 PM > To: Yigit, Ferruh ; Gaoxiang Liu > ; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; sta...@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-stable] [PATCH v2] vhost: add log print of sock

Re: [dpdk-dev] [PATCH v3 4/4] mbuf: make rte_mbuf_check part of stable API

2021-09-16 Thread Olivier Matz
On Wed, Sep 01, 2021 at 09:49:06AM +0300, Andrew Rybchenko wrote: > On 9/1/21 9:46 AM, Andrew Rybchenko wrote: > > On 8/31/21 10:35 PM, Stephen Hemminger wrote: > >> This one has been in for required time period. > >> > >> Signed-off-by: Stephen Hemminger > > > > Experimental warning should be re

Re: [dpdk-dev] [PATCH v2] eal: add additional info if lcore exceeds max cores

2021-09-16 Thread David Marchand
On Wed, Sep 15, 2021 at 2:11 PM David Hunt wrote: > > If the user requests to use an lcore above 128 using -l or -c, > the eal will exit with "EAL: invalid core list syntax" and > very little other useful information. > > This patch adds some extra information suggesting to use --lcores > so that

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Maxime Coquelin
On 9/16/21 14:28, Ferruh Yigit wrote: On 9/14/2021 12:30 PM, Maxime Coquelin wrote: On 9/7/21 2:51 AM, Gaoxiang Liu wrote: Add log print of socket path in vhost_user_add_connection. It's useful when adding a mass of socket connections, because the information of every connection is clearer

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: add log print of socket path on adding connection

2021-09-16 Thread Ferruh Yigit
On 9/14/2021 12:30 PM, Maxime Coquelin wrote: > > > On 9/7/21 2:51 AM, Gaoxiang Liu wrote: >> Add log print of socket path in vhost_user_add_connection. >> It's useful when adding a mass of socket connections, >> because the information of every connection is clearer. >> >> Fixes: 8f972312b8f4 ("

Re: [dpdk-dev] [PATCH v3 3/4] mbuf: make rte_mbuf_tx_offload as stable

2021-09-16 Thread Olivier Matz
On Wed, Sep 01, 2021 at 09:45:22AM +0300, Andrew Rybchenko wrote: > On 8/31/21 10:35 PM, Stephen Hemminger wrote: > > This function should be made stable now. > > > > Also, fix the docbook comment format. > > > > Fixes: 8d9c2c3a1f01 ("mbuf: add function to generate raw Tx offload value") > > Cc:

Re: [dpdk-dev] [PATCH v3 1/3] eal/linux: make hugetlbfs analysis reusable

2021-09-16 Thread John Levon
On Tue, Sep 14, 2021 at 01:34:54PM +0300, Dmitry Kozlyuk wrote: > + do { > + m = getmntent(f); Should you be using getmntent_r() etc? Nice cleanup! regards john

Re: [dpdk-dev] [PATCH v3 2/4] mbuf: make rte_mbuf_dynfield API's stable

2021-09-16 Thread Olivier Matz
On Wed, Sep 01, 2021 at 09:43:00AM +0300, Andrew Rybchenko wrote: > On 8/31/21 10:35 PM, Stephen Hemminger wrote: > > These functions to register dynamic fields were added in 20.11 > > and should be promoted to stable. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko Ack

[dpdk-dev] [PATCH v5 2/2] test/event: Add rx queue conf get test in rx adapter autotest

2021-09-16 Thread Ganapati Kundapura
Add unit tests for rte_event_eth_rx_adapter_queue_conf_get() in rx adapter autotest Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_rx_adapter.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_e

[dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-16 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_queue_conf_get() API to get rx queue information - event queue identifier, flags for handling received packets, scheduler type, event priority, polling frequency of the receive queue and flow identifier in rte_event_eth_rx_adapter_queue_conf structure Signed-off-by:

Re: [dpdk-dev] [PATCH v3 1/4] mbuf: make rte_pktmbuf_free_bulk and rte_pktmbuf_copy stable API's

2021-09-16 Thread Olivier Matz
On Wed, Sep 01, 2021 at 09:42:27AM +0300, Andrew Rybchenko wrote: > On 8/31/21 10:35 PM, Stephen Hemminger wrote: > > These two functions were added in 20.11 as experimental. > > Time to promote the to stable status. > > > > Signed-off-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko Acked

Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost

2021-09-16 Thread Xia, Chenbo
Hi, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, September 16, 2021 7:34 PM > To: Yigit, Ferruh ; Hu, Jiayu ; > dev@dpdk.org > Cc: Xia, Chenbo ; david.march...@redhat.com; Jiang, > Cheng1 > Subject: Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost >

Re: [dpdk-dev] [PATCH] mbuf: fix typo in comment

2021-09-16 Thread Olivier Matz
On Wed, Sep 01, 2021 at 04:49:44PM -0700, Stephen Hemminger wrote: > Misspelling of 'copied' > > Fixes: c3a90c381daa ("mbuf: add a copy routine") > Signed-off-by: Stephen Hemminger Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH 1/2] lib/eventdev: add usage hints to port configure API

2021-09-16 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob > Sent: Thursday, September 16, 2021 5:59 AM > To: Van Haaren, Harry > Cc: dpdk-dev ; Pathak, Pravin ; > McDaniel, Timothy > Subject: Re: [dpdk-dev] [PATCH 1/2] lib/eventdev: add usage hints to port > configure API > > On Thu, Sep 9, 2021 at 6:24

Re: [dpdk-dev] [PATCH v2 03/15] crypto: add dest_sgl in raw vector APIs

2021-09-16 Thread Ananyev, Konstantin
> > The structure rte_crypto_sym_vec is updated to > add dest_sgl to support out of place processing. > > Signed-off-by: Hemant Agrawal > Acked-by: Akhil Goyal > --- > lib/cryptodev/rte_crypto_sym.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/cryptodev/rte_crypto_sym.h b/

Re: [dpdk-dev] [PATCH v2 02/15] crypto: add total raw buffer length

2021-09-16 Thread Ananyev, Konstantin
> From: Gagandeep Singh > > The current crypto raw data vectors is extended to support > rte_security usecases, where we need total data length to know > how much additional memory space is available in buffer other > than data length so that driver/HW can write expanded size > data after encry

Re: [dpdk-dev] [PATCH v2 01/15] crypto: change sgl to src_sgl in vector

2021-09-16 Thread Ananyev, Konstantin
> This patch renames the sgl to src_sgl to help differentiating > between source and destination sgl. > > Signed-off-by: Hemant Agrawal > Acked-by: Akhil Goyal > --- > app/test/test_cryptodev.c | 6 ++--- > drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 12 +- > driver

  1   2   >