Re: [dpdk-dev] [PATCH 3/3] net/bonding: start ethdev prior to setting 8023ad flow

2021-09-24 Thread Havlík Martin
Hello, as Jan stated before, I have started the discussion afresh: [PATCH 0/4] doc: update RTE flow rule and bonding related info https://www.mail-archive.com/dev@dpdk.org/msg214517.html Now, [Patch 1] didn't really move anywhere, but it connects to [Patch 2], where a device capability was agr

[dpdk-dev] [PATCH] net/bnxt: fix mem zone free for Tx and Rx rings

2021-09-24 Thread Ajit Khaparde
The device cleanup logic was freeing most of the ring related memory, but was not freeing up the mem zone associated with the rings. This patch fixes the issue. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH] net/bnxt: fix Tx queue startup state

2021-09-24 Thread Ajit Khaparde
Default queue state of Tx queues on startup is not correct. Fix this by setting the state when the port is started. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson --- drivers/net/bnxt/bnxt_ethdev.c | 10 +

Re: [dpdk-dev] [PATCH v1] windows/netuio: add Intel 82599 10GbE VF device ID

2021-09-24 Thread Kadam, Pallavi
Hi William, On 9/22/2021 2:19 PM, William Tu wrote: Add Intel 82599 10GbE Ethernet adapter VF device IDs to netuio inf file in order to enable them on Windows. Signed-off-by: William Tu --- windows/netuio/netuio.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/windows/netuio/netuio

Re: [dpdk-dev] Not able to start IAVF PMD with dpdk 20.11.3

2021-09-24 Thread Dey, Souvik
Hi Wu, Thanks for the update. I got rid of the vfio-pci probe issue by enabling "modprobe vfio enable_unsafe_noiommu_mode=1". This was required as I am trying inside a VM where VT-d is not enabled. Now once I bind the interfaces( VF) to the vfio-pci instead of uio_pci_generic , the links are co

[dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-09-24 Thread William Tu
Windows does not support linker option '/-no-whole-archive' or '/whole-archive'. The patch removes them under Windows build. Signed-off-by: William Tu --- buildtools/pkg-config/meson.build | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/buildtools/pkg-config/meson.

Re: [dpdk-dev] [RFC PATCH v2 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

2021-09-24 Thread Ananyev, Konstantin
> > First, fix the bug that keyword const of func arg should be after "*". I believe there is no bug here. > This is because const before "*" means the value of "cbi" should not be > changed. Exactly, it says that the function itself will not change the value of "cbi". It just waits for the

Re: [dpdk-dev] [PATCH v2 02/15] crypto: add total raw buffer length

2021-09-24 Thread Akhil Goyal
> > Hi Konstantin > > > > On 9/21/2021 12:58 AM, Akhil Goyal wrote: > > >>> From: Gagandeep Singh > > >>> > > >>> The current crypto raw data vectors is extended to support > > >>> rte_security usecases, where we need total data length to know > > >>> how much additional memory space is available

Re: [dpdk-dev] [PATCH] test/compress: fix buffer overflow bug

2021-09-24 Thread Akhil Goyal
> > Fixes stack buffer overflow bug in compressdev autotest, which > > was caused by the use of buf_idx in the debug logs. Originally, buf_idx > > was treated as an array instead of the reference of an integar. > > This was fixed by replacing the use of buf_idx[priv_data->orig_idx] with > > the var

Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix indirect mkey cleaning

2021-09-24 Thread Akhil Goyal
> The driver creates an indirect mkey per entry in the queue to manage the > crypto operation using the BSF fields. > > The indirect mkeys were never released neither while error occurs in the > creation phase nor when the queue is released. > > Clean the indirect mkeys in the above cases. > > F

Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: fix crypto QP indexing

2021-09-24 Thread Akhil Goyal
> The crypto QP consumer (ci) and producer (pi) indexes are increased > with each successful enqueue/dequeue operations. > > However the QP pi index is calculated with a wraparound the number > of elements while the QP ci does not. > > This is causing incorrect engine calculation for encqueued WQ

Re: [dpdk-dev] [PATCH] common/cpt: rework pending queue

2021-09-24 Thread Akhil Goyal
> From: David George > > Replace pending queue with one that allows concurrent single producer and > single consumer. This relaxes the restriction of only allowing a single > lcore to operate on a given queue pair. > > Signed-off-by: David George > Signed-off-by: Anoob Joseph > --- > doc/guid

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix parsing of flow queue

2021-09-24 Thread Akhil Goyal
> > > Documentation specifies that flow port & queue is provided as, > > > > > > <...> port 0 queue 0 > > > > > > But code is expecting the same as, > > > > > > <...> port 0 0 > > > > > > Fix the above to match documentation. > > > > > > Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix parsing of flow queue

2021-09-24 Thread Akhil Goyal
> > Documentation specifies that flow port & queue is provided as, > > > > <...> port 0 queue 0 > > > > But code is expecting the same as, > > > > <...> port 0 0 > > > > Fix the above to match documentation. > > > > Fixes: 8e693616fcb2 ("examples/ipsec-secgw: enable flow based > > distribution") >

Re: [dpdk-dev] [EXT] [PATCH v5] app/crypto-perf: add throughput test for asymmetric crypto

2021-09-24 Thread Akhil Goyal
> From: Kiran Kumar K > > Adding support for asymmetric crypto perf test. > Only modex is supported for now. > > One new optype has been added. > --optype modex > > ./dpdk-test-crypto-perf -c 0x3 -- --devtype crypto_cn9k --optype modex > --ptest throughput > > Signed-off-by: Kira

Re: [dpdk-dev] [EXT] app/test: fix pdcp short mac test

2021-09-24 Thread Akhil Goyal
> > Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I") > > Cc: g.si...@nxp.com > > > > This patch fixes the pdcp short mac-i test by removing them from snow3g > and > > kasumi test suite and move to pdcp test suite. > > This is to prevent incorrect failure for crypto device not suppor

Re: [dpdk-dev] [PATCH 2/4] bus/fslmc: remove experimental tag from API

2021-09-24 Thread Thomas Monjalon
09/09/2021 10:01, David Marchand: > On Thu, Sep 9, 2021 at 9:54 AM Nipun Gupta wrote: > > > > This API was introduced in 19.08, therefore removing > > > > experimental tag to promote them to stable state. > > > > > > The only user is an in-tree driver. > > > Do we need to export this symbol to app

Re: [dpdk-dev] [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-24 Thread Bruce Richardson
On Fri, Sep 24, 2021 at 02:33:35PM +, Conor Walsh wrote: > Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have > moved to dmadev. > > Signed-off-by: Conor Walsh > --- This probably needs a release note entry for it too. With such a RN addition, feel free to add my acked-by.

Re: [dpdk-dev] [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-24 Thread Kevin Laatz
On 24/09/2021 15:33, Conor Walsh wrote: Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 2 files changed, 5 insertions(+), 1 deletion(-) Acked-by: K

[dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-24 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process removing another process' telemetry socket as it started up, giving unexpected behaviour. This patch changes that behaviour to first check if the existing socket

[dpdk-dev] [PATCH] net/octeontx2: use fast udata and mdata flags

2021-09-24 Thread Tejasree Kondoj
Using fast metadata and userdata flags instead of driver callbacks for set_pkt_metadata and get_userdata in inline IPsec. Signed-off-by: Tejasree Kondoj --- drivers/net/octeontx2/otx2_ethdev_sec.c| 25 ++ drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 2 +- 2 files changed

Re: [dpdk-dev] [PATCH v6 05/13] dmadev: add device iterator

2021-09-24 Thread Kevin Laatz
On 24/09/2021 11:29, Bruce Richardson wrote: Add a function and wrapper macro to iterate over all dma devices. Signed-off-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 13 + lib/dmadev/rte_dmadev.h | 18 ++ lib/dmadev/version.map | 1 + 3 files changed, 3

Re: [dpdk-dev] [PATCH v6 10/13] dmadev: add flag for error handling support

2021-09-24 Thread Kevin Laatz
On 24/09/2021 11:31, Bruce Richardson wrote: Due to HW or driver limiations, not all dmadevs may support full error handling e.g. safely managing and reporting an invalid address to a copy operation. The skeleton dmadev, for example, being pure software will always seg-fault if passed an invalid

Re: [dpdk-dev] [PATCH v6 08/13] app/test: run test suite on skeleton driver

2021-09-24 Thread Kevin Laatz
On 24/09/2021 11:29, Bruce Richardson wrote: When running the dmadev_autotest, run the suite of copy tests on the skeleton driver created for API testing too, rather than just destroying the driver instances once the API tests are complete. This helps to sanity check the tests themselves are reas

[dpdk-dev] [PATCH 5/5] kvargs: fix comments style

2021-09-24 Thread Olivier Matz
A '*' is missing at 2 places, add them. Fixes: e1a00536c8ed ("kvargs: add a new library to parse key/value arguments") Fixes: 3ab385063cb9 ("kvargs: add get by key") Signed-off-by: Olivier Matz --- lib/kvargs/rte_kvargs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/l

[dpdk-dev] [PATCH 4/5] kvargs: remove experimental function to compare string

2021-09-24 Thread Olivier Matz
The function was designed to be used as a handler for rte_kvargs_process() to compare the value string in a kvlist. For readability, its usages in DPDK have been replaced by rte_kvargs_get_with_value() in previous commit. Remove this function, as it is not used anymore. Signed-off-by: Olivier Mat

[dpdk-dev] [PATCH 3/5] kvargs: new function to get from key and value

2021-09-24 Thread Olivier Matz
A quite common scenario with kvargs is to lookup for a = in a kvlist. For instance, check if name=foo is present in name=toto,name=foo,name=bar. This is currently done in drivers/bus with rte_kvargs_process() + the rte_kvargs_strcmp() handler. This approach is not straightforward, and can be repla

[dpdk-dev] [PATCH 2/5] kvargs: promote get from key as stable

2021-09-24 Thread Olivier Matz
The function rte_kvargs_get() is used by eal and pci bus driver since its introduction in commit 3ab385063cb9 ("kvargs: add get by key") and commit d2a66ad79480 ("bus: add device arguments name parsing"), in dpdk 21.05. Let's promote it as stable. Signed-off-by: Olivier Matz --- lib/kvargs/rte_

[dpdk-dev] [PATCH 1/5] kvargs: promote delimited parsing as stable

2021-09-24 Thread Olivier Matz
This function is used by EAL to parse key/value strings separated with specified delimiters. It was introduced in 2018 by commit 5d6af85ab00c ("kvargs: introduce a more flexible parsing function"), and can be promoted as stable. Signed-off-by: Olivier Matz --- lib/kvargs/rte_kvargs.h | 1 - lib

[dpdk-dev] [PATCH 0/5] kvargs: promote or remove experimental api

2021-09-24 Thread Olivier Matz
This patchset promotes 2 functions rte_kvargs_parse_delim() and rte_kvargs_get() as stable. It also replaces rte_kvargs_strcmp() by a new one rte_kvargs_get_with_value(), which is easier to use. Olivier Matz (5): kvargs: promote delimited parsing as stable kvargs: promote get from key as stab

Re: [dpdk-dev] [PATCH v10 06/12] pdump: support pcapng and filtering

2021-09-24 Thread Pattan, Reshma
> -Original Message- > > > > > > + * Similar behavior to rte_bpf_eth callback. > > > + * if BPF program returns zero value for a given packet, > > > + * then it will be ignored. > > > + */ > > Looks like wrong callback name referred in the comment, sho

[dpdk-dev] [PATCH v11 12/12] MAINTAINERS: add entry for new packet capture features

2021-09-24 Thread Stephen Hemminger
Since the packet capture is just extension of existing pdump; add myself as maintainer of that. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30bf77b79a75..eae60d2d7a74 100644 --- a

[dpdk-dev] [PATCH v11 11/12] doc: changes for new pcapng and dumpcap

2021-09-24 Thread Stephen Hemminger
Describe the new packet capture library and utilities Signed-off-by: Stephen Hemminger --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + .../howto/img/packet_capture_framework.svg| 96 +-- doc/guides/howto/packet_c

[dpdk-dev] [PATCH v11 10/12] test: enable bpf autotest

2021-09-24 Thread Stephen Hemminger
The BPF autotest is defined but not run automatically. Since it is short, it should be added to the autotest suite. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- app/test/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test/meson.build b/app/test/meson.

[dpdk-dev] [PATCH v11 09/12] test: add a test for pcapng library

2021-09-24 Thread Stephen Hemminger
Simple unit test that created pcapng file using API. To run this test you need to have at least one device. For example: DPDK_TEST=pcapng_autotest ./build/app/test/dpdk-test -l 0-15 \ --no-huge -m 2048 --vdev=net_tap,iface=dummy Signed-off-by: Stephen Hemminger --- app/test/meson.build |

[dpdk-dev] [PATCH v11 08/12] test: add test for bpf_convert

2021-09-24 Thread Stephen Hemminger
Add some functional tests for the Classic BPF to DPDK BPF converter. Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 200 1 file changed, 200 insertions(+) diff --git a/app/test/test_bpf.c b/app/test/test_bpf.c index 527c06b80708..543a5fd6

[dpdk-dev] [PATCH v11 07/12] app/dumpcap: add new packet capture application

2021-09-24 Thread Stephen Hemminger
This is a new packet capture application to replace existing pdump. The new application works like Wireshark dumpcap program and supports the pdump API features. It is not complete yet some features such as filtering are not implemented. Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c

[dpdk-dev] [PATCH v11 06/12] pdump: support pcapng and filtering

2021-09-24 Thread Stephen Hemminger
This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version number (not part of exposed API or ABI) is intentionally

[dpdk-dev] [PATCH v11 05/12] bpf: add function to dump eBPF instructions

2021-09-24 Thread Stephen Hemminger
When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meson.build | 1 + lib/bpf/rte_bpf.h | 14 + lib

[dpdk-dev] [PATCH v11 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-09-24 Thread Stephen Hemminger
The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the resulting program in hugepage shared memory so it

[dpdk-dev] [PATCH v11 03/12] bpf: allow self-xor operation

2021-09-24 Thread Stephen Hemminger
Some BPF programs may use XOR of a register with itself as a way to zero register in one instruction. The BPF filter converter generates this in the prolog to the generated code. The BPF validator would not allow this because the value of register was undefined. But after this operation it always

[dpdk-dev] [PATCH v11 02/12] lib: pdump is not supported on Windows

2021-09-24 Thread Stephen Hemminger
The current version of the pdump library was building on Windows, but it was useless since the pdump utility was not being built and Windows does not have multi-process support. The new version of pdump with filtering now has dependency on bpf. But bpf library is not available on Windows. Signed-

[dpdk-dev] [PATCH v11 01/12] librte_pcapng: add new library for writing pcapng files

2021-09-24 Thread Stephen Hemminger
This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See draft RFC https://www.ietf.org/id/draft-tuexen-opsawg-pcapng-03.html and https://github.com/pcapng/pcapng/ Signed-off-by: Stephe

[dpdk-dev] [PATCH v11 00/12] Packet capture framework enhancements

2021-09-24 Thread Stephen Hemminger
This patch set is a more complete version of the the enhanced packet capture support described last year. The new capture library and utility are: - faster avoids lots of extra I/O, does bursting, etc. - gives more information (multiple ports, queues, etc) - has a better user interface (same

Re: [dpdk-dev] [PATCH v4 1/2] Enable ASan for memory detector on DPDK

2021-09-24 Thread Stephen Hemminger
On Fri, 24 Sep 2021 11:52:33 +0200 Olivier Matz wrote: > Hi Zhihong, > > On Fri, Sep 24, 2021 at 02:16:29AM +, zhihongx.p...@intel.com wrote: > > From: Zhihong Peng > > > > AddressSanitizer (ASan) is a google memory error detect > > standard tool. It could help to detect use-after-free and

Re: [dpdk-dev] [PATCH v3] net/af_packet: reinsert the stripped vlan tag

2021-09-24 Thread Stephen Hemminger
On Fri, 24 Sep 2021 14:44:45 +0300 Tudor Cornea wrote: > +Features and Limitations of the af_packet PMD > +- > + > +Since the following commit, the Linux kernel strips the vlan tag > + > +.. code-block:: console > + > +commit bcc6d47903612c3861201cc

Re: [dpdk-dev] [PATCH v6 10/13] dmadev: add flag for error handling support

2021-09-24 Thread Conor Walsh
On 24/09/2021 11:31, Bruce Richardson wrote: Due to HW or driver limiations, not all dmadevs may support full error handling e.g. safely managing and reporting an invalid address to a copy operation. The skeleton dmadev, for example, being pure software will always seg-fault if passed an invalid

Re: [dpdk-dev] [PATCH v6 04/13] dma/skeleton: add burst capacity function

2021-09-24 Thread Conor Walsh
On 24/09/2021 11:29, Bruce Richardson wrote: Implement function to return the remaining space for operations. Signed-off-by: Bruce Richardson --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v6 05/13] dmadev: add device iterator

2021-09-24 Thread Conor Walsh
On 24/09/2021 11:29, Bruce Richardson wrote: Add a function and wrapper macro to iterate over all dma devices. Signed-off-by: Bruce Richardson --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] RTE_REGISTER_BUS does not work on Windows

2021-09-24 Thread William Tu
Hi, I continued my experiment and observed below 1. for dpdk-testpmd.exe which works fine, the functions in driver/bus/pci/* are there in the binary, ex: PS C:\dpdk\build\app> dumpbin.exe /ALL .\dpdk-testpmd.exe | grep rte_pci_set_b 0001D1F0 0068DB40 0068DC32 0073BDEC rte_pci_set_bus_master So

[dpdk-dev] [PATCH v5 12/12] raw/ioat: deprecate ioat rawdev driver

2021-09-24 Thread Conor Walsh
Deprecate the rawdev IOAT driver as both IOAT and IDXD drivers have moved to dmadev. Signed-off-by: Conor Walsh --- MAINTAINERS | 2 +- doc/guides/rawdevs/ioat.rst | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ccabba9169..

[dpdk-dev] [PATCH v5 11/12] devbind: move ioat device IDs to dmadev category

2021-09-24 Thread Conor Walsh
Move Intel IOAT devices from Misc to DMA devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Bruce Richardson --- usertools/dpdk-devbind.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py inde

[dpdk-dev] [PATCH v5 10/12] dma/ioat: add burst capacity function

2021-09-24 Thread Conor Walsh
Adds the ability to find the remaining space in the IOAT ring. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/io

[dpdk-dev] [PATCH v5 09/12] dma/ioat: add support for vchan status function

2021-09-24 Thread Conor Walsh
Add support for the rte_dmadev_vchan_status API call. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/i

[dpdk-dev] [PATCH v5 08/12] dma/ioat: add statistics

2021-09-24 Thread Conor Walsh
Add statistic tracking for operations in IOAT. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/ioat/ioat_dmadev.c | 43 ++ 1 file changed, 43 insertions(+) diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/

[dpdk-dev] [PATCH v5 07/12] dma/ioat: add data path completion functions

2021-09-24 Thread Conor Walsh
Add the data path functions for gathering completed operations from IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- doc/guides/dmadevs/ioat.rst| 33 +++- drivers/dma/ioat/ioat_dmadev.c | 141 + 2 files

[dpdk-dev] [PATCH v5 06/12] dma/ioat: add data path job submission functions

2021-09-24 Thread Conor Walsh
Add data path functions for enqueuing and submitting operations to IOAT devices. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- doc/guides/dmadevs/ioat.rst| 9 drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed,

[dpdk-dev] [PATCH v5 05/12] dma/ioat: add start and stop functions

2021-09-24 Thread Conor Walsh
Add start, stop and recover functions for IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- doc/guides/dmadevs/ioat.rst| 3 ++ drivers/dma/ioat/ioat_dmadev.c | 92 ++ 2 files changed, 95 insertions(+) dif

[dpdk-dev] [PATCH v5 04/12] dma/ioat: add configuration functions

2021-09-24 Thread Conor Walsh
Add functions for device configuration. The info_get and close functions are included here also. info_get can be useful for checking successful configuration and close is used by the dmadev api when releasing a configured device. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- doc/guide

[dpdk-dev] [PATCH v5 03/12] dma/ioat: add datapath structures

2021-09-24 Thread Conor Walsh
Add data structures required for the data path of IOAT devices. Signed-off-by: Conor Walsh Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 63 +- drivers/dma/ioat/ioat_hw_defs.h | 215 2 files changed, 277

[dpdk-dev] [PATCH v5 02/12] dma/ioat: create dmadev instances on PCI probe

2021-09-24 Thread Conor Walsh
When a suitable device is found during the PCI probe, create a dmadev instance for each channel. Internal structures and HW definitions required for device creation are also included. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz --- drivers/dma/ioat/ioat_dmadev.c | 102

[dpdk-dev] [PATCH v5 01/12] dma/ioat: add device probe and removal functions

2021-09-24 Thread Conor Walsh
Add the basic device probe/remove skeleton code and initial documentation for new IOAT DMA driver. Maintainers update is also included in this patch. Signed-off-by: Conor Walsh Reviewed-by: Kevin Laatz Reviewed-by: Chengwen Feng --- MAINTAINERS| 6 +++ doc/guides/d

[dpdk-dev] [PATCH v5 00/12] dma: add dmadev driver for ioat devices

2021-09-24 Thread Conor Walsh
This patchset adds a dmadev driver and associated documentation to support Intel QuickData Technology devices, part of the Intel I/O Acceleration Technology (Intel I/OAT). This driver is intended to ultimately replace the current IOAT part of the IOAT rawdev driver. This patchset passes all the dri

[dpdk-dev] [PATCH v6 16/16] devbind: move idxd device ID to dmadev class

2021-09-24 Thread Kevin Laatz
The dmadev library is the preferred abstraction for using IDXD devices and will replace the rawdev implementation in future. This patch moves the IDXD device ID to the dmadev class. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Acked-by: Bruce Richardson --- usertools/dpdk-devbind.py | 4

[dpdk-dev] [PATCH v6 15/16] devbind: add dma device class

2021-09-24 Thread Kevin Laatz
Add a new class for DMA devices. Devices listed under the DMA class are to be used with the dmadev library. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson Reviewed-by: Chengwen Feng --- v6: remove purely cosmetic change from patch --- usertools/dpdk-devbind

[dpdk-dev] [PATCH v6 14/16] dma/idxd: move dpdk_idxd_cfg.py from raw to dma

2021-09-24 Thread Kevin Laatz
From: Conor Walsh Move the example script for configuring IDXD devices bound to the IDXD kernel driver from raw to dma, and create a symlink to still allow use from raw. Signed-off-by: Conor Walsh Signed-off-by: Kevin Laatz Acked-by: Bruce Richardson --- drivers/dma/idxd/dpdk_idxd_cfg.py | 1

[dpdk-dev] [PATCH v6 13/16] dma/idxd: add burst capacity API

2021-09-24 Thread Kevin Laatz
Add support for the burst capacity API. This API will provide the calling application with the remaining capacity of the current burst (limited by max HW batch size). Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Bruce Richardson --- v6: updates for burst capacity api moving

[dpdk-dev] [PATCH v6 12/16] dma/idxd: add vchan status function

2021-09-24 Thread Kevin Laatz
When testing dmadev drivers, it is useful to have the HW device in a known state. This patch adds the implementation of the function which will wait for the device to be idle (all jobs completed) before proceeding. Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v3: update API name to v

[dpdk-dev] [PATCH v6 11/16] dma/idxd: add operation statistic tracking

2021-09-24 Thread Kevin Laatz
Add statistic tracking for DSA devices. The dmadev library documentation is also updated to add a generic section for using the library's statistics APIs. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh Reviewed-by: Chengwen Feng --- v6: move doc update to

[dpdk-dev] [PATCH v6 10/16] dma/idxd: add data-path job completion functions

2021-09-24 Thread Kevin Laatz
Add the data path functions for gathering completed operations. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v2: - fixed typo in docs - add completion status for invalid opcode v6: - update documentation to reduce duplication --- doc/guides/dma

[dpdk-dev] [PATCH v6 09/16] dma/idxd: add data-path job submission functions

2021-09-24 Thread Kevin Laatz
Add data path functions for enqueuing and submitting operations to DSA devices. Documentation updates are included for dmadev library and IDXD driver docs as appropriate. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v6: - add references to dmadev l

[dpdk-dev] [PATCH v6 08/16] dma/idxd: add start and stop functions for pci devices

2021-09-24 Thread Kevin Laatz
Add device start/stop functions for DSA devices bound to vfio. For devices bound to the IDXD kernel driver, these are not required since the IDXD kernel driver takes care of this. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v6: fix return values of s

[dpdk-dev] [PATCH v6 07/16] dma/idxd: add configure and info_get functions

2021-09-24 Thread Kevin Laatz
Add functions for device configuration. The info_get function is included here since it can be useful for checking successful configuration. Documentation is also updated to add device configuration usage info. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh

[dpdk-dev] [PATCH v6 06/16] dma/idxd: add datapath structures

2021-09-24 Thread Kevin Laatz
Add data structures required for the data path for IDXD devices. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v2: add completion status for invalid opcode --- drivers/dma/idxd/idxd_bus.c | 1 + drivers/dma/idxd/idxd_common.c | 33

[dpdk-dev] [PATCH v6 05/16] dma/idxd: create dmadev instances on pci probe

2021-09-24 Thread Kevin Laatz
When a suitable device is found during the PCI probe, create a dmadev instance for each HW queue. HW definitions required are also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v4: rebase changes v6: add close function for device destroy and

[dpdk-dev] [PATCH v6 04/16] dma/idxd: create dmadev instances on bus probe

2021-09-24 Thread Kevin Laatz
When a suitable device is found during the bus scan/probe, create a dmadev instance for each HW queue. Internal structures required for device creation are also added. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v4: - fix 'vdev' naming, changed to

[dpdk-dev] [PATCH v6 03/16] dma/idxd: add bus device probing

2021-09-24 Thread Kevin Laatz
Add the basic device probing for DSA devices bound to the IDXD kernel driver. These devices can be configured via sysfs and made available to DPDK if they are found during bus scan. Relevant documentation is included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor

[dpdk-dev] [PATCH v6 02/16] dma/idxd: add skeleton for VFIO based DSA device

2021-09-24 Thread Kevin Laatz
Add the basic device probe/remove skeleton code for DSA device bound to the vfio pci driver. Relevant documentation and MAINTAINERS update also included. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Reviewed-by: Conor Walsh --- v5: add missing toctree entry for idxd driver v6: ad

[dpdk-dev] [PATCH v6 01/16] raw/ioat: only build if dmadev not present

2021-09-24 Thread Kevin Laatz
From: Bruce Richardson Only build the rawdev IDXD/IOAT drivers if the dmadev drivers are not present. This change requires the dependencies to be reordered in drivers/meson.build so that rawdev can use the "RTE_DMA_* build macros to check for the presence of the equivalent dmadev driver. A note

[dpdk-dev] [PATCH v6 00/16] add dmadev driver for idxd devices

2021-09-24 Thread Kevin Laatz
This patchset adds a dmadev driver and associated documentation to support Intel Data Streaming Accelerator devices. This driver is intended to ultimately replace the current IDXD part of the IOAT rawdev driver. NOTE: This patchset has several dependencies: - v23 of the dmadev lib set [1] - v6 o

Re: [dpdk-dev] [dpdk-web] DMARC mitigation in dpdk.org's mailing list

2021-09-24 Thread Ali Alnubani
Hi Jim, Yes I got the techboard's approval during the last meeting. Another alternative we can look into is upgrading to Mailman 3, since it's now the actively developed version. It has a more modern UI, and along with other features, it has support for ARC (Authenticated Received Chain) signin

[dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable

2021-09-24 Thread Olivier Matz
This function is public since commit 8f0e4d6a78a5 ("net: export IPv6 header extensions skip function") (2018), and is used by vmxnet3 driver. Promote it as stable. Signed-off-by: Olivier Matz --- lib/net/rte_net.h | 4 lib/net/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletio

Re: [dpdk-dev] [PATCH v6 00/10] new features for ipsec and security libraries

2021-09-24 Thread Ananyev, Konstantin
> > Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value I provided my comments for individual patches. There are few more generic ones, I have: 1. Documentation updates are missing. Specially th

[dpdk-dev] [PATCH v3] net/af_packet: reinsert the stripped vlan tag

2021-09-24 Thread Tudor Cornea
The af_packet pmd driver binds to a raw socket and allows sending and receiving of packets through the kernel. Since commit [1], the kernel strips the vlan tags early in __netif_receive_skb_core(), so we receive untagged packets while running with the af_packet pmd. Luckily for us, the skb vlan-r

Re: [dpdk-dev] [PATCH v6 10/10] ipsec: add ol_flags support

2021-09-24 Thread Ananyev, Konstantin
> Update the IPsec library to set mbuff->ol_flags and use the configured > L3 header length when setting the mbuff->tx_offload fields You stated what pactch does, but didn't explain why it is needed. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha

[dpdk-dev] [PATCH] common/cpt: rework pending queue

2021-09-24 Thread Anoob Joseph
From: David George Replace pending queue with one that allows concurrent single producer and single consumer. This relaxes the restriction of only allowing a single lcore to operate on a given queue pair. Signed-off-by: David George Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/octeon

Re: [dpdk-dev] [PATCH v2 0/2] i40e Rx descriptor loads ordering

2021-09-24 Thread Zhang, Qi Z
> -Original Message- > From: Ruifeng Wang > Sent: Wednesday, September 15, 2021 4:34 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Richardson, Bruce ; jer...@marvell.com; > hemant.agra...@nxp.com; d...@linux.vnet.ibm.com; > honnappa.nagaraha...@arm.com; sta...@dpdk.org; n..

Re: [dpdk-dev] [PATCH v3] net/ice: support IPv4/L4 checksum RSS offload

2021-09-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 24, 2021 5:54 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v3] net/ice: support IPv4/L4 checksum RSS offload > > Add supports for RSS_IPV4_CHKSUM & RSS_L4_CHKSUM RSS offload types in > RS

Re: [dpdk-dev] [PATCH v3 1/2] common/iavf: enable hash calculation based on IPv4 checksum

2021-09-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 24, 2021 5:57 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v3 1/2] common/iavf: enable hash calculation based on IPv4 > checksum > > Add IPv4 header checksum field selector, it can be use

[dpdk-dev] [PATCH v23 1/6] dmadev: introduce DMA device library

2021-09-24 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' device allocation APIs. The infrastructure is prepared to welcome drivers in drivers/dma/ Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob Reviewed-by: K

[dpdk-dev] [PATCH v23 6/6] app/test: add dmadev API test

2021-09-24 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- MAINTAINERS

[dpdk-dev] [PATCH v23 2/6] dmadev: add control plane function support

2021-09-24 Thread Chengwen Feng
This patch add control plane functions for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 41 +++ doc/guides/rel_notes/release_21_11.rst | 1 + lib/dmade

[dpdk-dev] [PATCH v23 0/6] support dmadev

2021-09-24 Thread Chengwen Feng
This patch set contains six patch for new add dmadev. Chengwen Feng (6): dmadev: introduce DMA device library dmadev: add control plane function support dmadev: add data plane function support dmadev: add multi-process support dma/skeleton: introduce skeleton dmadev driver app/test: ad

[dpdk-dev] [PATCH v23 5/6] dma/skeleton: introduce skeleton dmadev driver

2021-09-24 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng Reviewed-by: Kevi

[dpdk-dev] [PATCH v23 4/6] dmadev: add multi-process support

2021-09-24 Thread Chengwen Feng
This patch add multi-process support for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/rel_notes/release_21_11.rst | 1 + lib/dmadev/rte_dmadev.c| 168

[dpdk-dev] [PATCH v23 3/6] dmadev: add data plane function support

2021-09-24 Thread Chengwen Feng
This patch add data plane functions for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 22 ++ doc/guides/rel_notes/release_21_11.rst | 1 + lib/dmadev/rt

Re: [dpdk-dev] [PATCH v3 2/2] net/iavf: support IPv4/L4 checksum RSS offload

2021-09-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 24, 2021 5:57 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v3 2/2] net/iavf: support IPv4/L4 checksum RSS offload > > Add supports for RSS_IPV4_CHKSUM & RSS_L4_CHKSUM RSS offload types in

[dpdk-dev] [PATCH v2] kni: Fix request overwritten

2021-09-24 Thread Elad Nachman
Fix lack of multiple KNI requests handling support by introducing a request in progress flag which will fail additional requests with EAGAIN return code if the original request has not been processed by user-space. Bugzilla ID: 809 Signed-off-by: Elad Nachman --- kernel/linux/kni/kni_net.c | 9

Re: [dpdk-dev] [PATCH v5] net/ice: add support for low Rx latency

2021-09-24 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Friday, September 24, 2021 5:34 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: [PATCH v5] net/ice: add support for low Rx latency > > This patch adds a devarg parameter to enable/disable low Rx latency. > > Signed

Re: [dpdk-dev] [EXT] app/test: fix pdcp short mac test

2021-09-24 Thread Anoob Joseph
> Subject: [EXT] [dpdk-dev] app/test: fix pdcp short mac test > > External Email > > -- > Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I") > Cc: g.si...@nxp.com > > This patch fixes the pdcp short mac-i test by remo

  1   2   >