Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 10:07 PM, Ivan Malov wrote: > Hi Ori, > > On 30/09/2021 17:59, Ori Kam wrote: >> Hi Ivan, >> Sorry for jumping in late. > > No worries. That's OK. > >> I have a concern that this patch breaks other PMDs. > > It does no such thing. > >>> From the rst file " One should negotiate flag

Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 9:14 PM Long Li wrote: > > rte_device name only points at some location where the name is stored. > > In general this storage is in the bus object or (in some buses) the devarg > > that > > resulted in the rte_device object creation. > > > > If we won't store the name in t

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-09-30 Thread Andrew Rybchenko
On 9/30/21 10:30 PM, Ivan Malov wrote: > Hi Thomas, > > On 30/09/2021 19:18, Thomas Monjalon wrote: >> 23/09/2021 13:20, Ivan Malov: >>> In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace >>> intending to add new flags, RSS_HASH and FLOW_MARK. Since then, >>> only the former has bee

Re: [dpdk-dev] [PATCH] lib: remove sched.h from public headers

2021-09-30 Thread Thomas Monjalon
24/09/2021 00:34, William Tu: > On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk > wrote: > > > > Public headers including POSIX-specific were unusable > > on Windows. These includes were superfluous, remove them. > > > > Signed-off-by: Dmitry Kozlyuk > > --- > > Write a program, include rte_eal

Re: [dpdk-dev] [PATCH v2 00/28] net/cnxk: support for inline ipsec

2021-09-30 Thread Jerin Jacob
On Thu, Sep 30, 2021 at 10:32 PM Nithin Dabilpuram wrote: > > Support for inline ipsec in CN9K event mode and in Cn10K event mode and > poll mode. > > Kommula Shiva Shankar (1): > common/cnxk: add CQ enable support in NIX Tx path > > Nithin Dabilpuram (18): > common/cnxk: support CPT parse hea

[dpdk-dev] [PATCH v4] eventdev/rx-adapter: fix segfault in queue conf get

2021-09-30 Thread Ganapati Kundapura
rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without queue added to the Rx adapter. Added check to no queues in Rx adapter and error out on being called with no queue in Rx adapter. Added test case to call queue conf get without queues in Rx adapter. Fixes: b36879759b7f3ce ("eve

Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get

2021-09-30 Thread Kundapura, Ganapati
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: 01 October 2021 10:12 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: RE: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue > conf get > > Hi Ganapati, >

[dpdk-dev] [PATCH v3] eventdev/rx-adapter: fix segfault in que conf get

2021-09-30 Thread Ganapati Kundapura
rte_event_eth_rx_adapter_queue_conf_get() segfaults if called without queue added to the Rx adapter. Added check to no queues in Rx adapter and error out on being called with no queue in Rx adapter. Added test case to call queue conf get without queues in Rx adapter. Fixes: b36879759b7f3ce ("eve

Re: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf get

2021-09-30 Thread Naga Harish K, S V
Hi Ganapati, > -Original Message- > From: dev On Behalf Of Ganapati Kundapura > Sent: Thursday, September 30, 2021 6:30 PM > To: jerinjac...@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: [dpdk-dev] [PATCH v2] eventdev/rx-adapter: segfault in queue conf > get The commit mes

Re: [dpdk-dev] [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs

2021-09-30 Thread Long Li
> Subject: [PATCH 00/11] add FreeBSD support to VMBUS & NetVSC PMDs > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > This patch series adds support to VMBUS & NetVSC PMDs run on FreeBSD > > Srik

Re: [dpdk-dev] [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels

2021-09-30 Thread Long Li
> Subject: [PATCH 06/11] net/netvsc: request HV_UIO to open sub-channels > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > On Linux, the request does nothing, while on FreeBSD the HV_UIO kernel >

Re: [dpdk-dev] [PATCH 05/11] bus/vmbus: open subchannels

2021-09-30 Thread Long Li
> Subject: [PATCH 05/11] bus/vmbus: open subchannels > > [You don't often get email from srikant...@oneconvergence.com. Learn > why this is important at http://aka.ms/LearnAboutSenderIdentification.] > > In FreeBSD, unlike Linux there is no sub-channel open callback that could be > called by HV_U

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: > > Hi Ajit, > > On 01/10/2021 00:48, Ajit Khaparde wrote: > > > >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > >> index 97ae52e17e..7a8da3d7ab 100644 > >> --- a/app/test-pmd/testpmd.c > >> +++ b/app/test-pmd/testpmd.c > >>

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ajit Khaparde
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 97ae52e17e..7a8da3d7ab 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1485,10 +1485,36 @@ static void > init_config_port_offloads(portid_t pid, uint32_t socket_id) > { > struct rte_port

[dpdk-dev] [PATCH v2] mempool/stack: build on Windows

2021-09-30 Thread Jie Zhou
enable build mempool/stack on Windows V2 change: - enable build lib stack on Windows which mempool/stack depends on Signed-off-by: Jie Zhou --- drivers/mempool/stack/meson.build | 5 - lib/meson.build | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) diff --git

Re: [dpdk-dev] [PATCH v3 13/13] app/test: enable subset of unit tests on Windows

2021-09-30 Thread Jie Zhou
On Thu, Sep 23, 2021 at 10:35:37AM +0300, Dmitry Kozlyuk wrote: > 2021-09-08 15:14 (UTC-0700), Jie Zhou: > > On Tue, Sep 07, 2021 at 09:43:56AM -0400, Aaron Conole wrote: > > > Jie Zhou writes: > > > > > > > Enable a subset of unit tests on Windows. Currently not all the > > > > dependencies (e

[dpdk-dev] [PATCH] mempool/stack: build on Windows

2021-09-30 Thread Jie Zhou
Enable the build of mempool/stack on Windows Signed-off-by: Jie Zhou --- drivers/mempool/stack/meson.build | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build index 371cf131b1..580dde79eb 100644 --- a/drivers/mempool/stac

Re: [dpdk-dev] [PATCH 1/3] bus/vmbus: fix leak on device scan

2021-09-30 Thread Long Li
> Subject: Re: [PATCH 1/3] bus/vmbus: fix leak on device scan > > On Wed, Sep 29, 2021 at 10:57 PM Long Li wrote: > > > > > Subject: [PATCH 1/3] bus/vmbus: fix leak on device scan > > > > > > Caught running ASAN. > > > > > > The device name is leaked on scan. > > > rte_device name field being a c

Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random

2021-09-30 Thread Kadam, Pallavi
On 9/30/2021 9:46 AM, Thomas Monjalon wrote: 10/09/2021 01:23, Pallavi Kadam: IAVF PMD needs to generate a random MAC address if it is not configured by host. 'random' is now supported on Windows. This patch can be the first of this series to respect the dependency order. Fixes: 16f0d03098c

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
On 01/10/2021 01:12, Ajit Khaparde wrote: On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov wrote: Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-30 Thread William Tu
On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile wrote: > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1,

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Typo below: On 9/30/2021 3:07 PM, Menon, Ranjit wrote: Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys

Re: [dpdk-dev] [kmods PATCH v2 4/4] windows/virt2phys: add tracing

2021-09-30 Thread Menon, Ranjit
Hi Dmitry, On 5/26/2021 2:01 PM, Dmitry Kozlyuk wrote: WPP tracing [1] allows kernel drivers to print logs that can be viewed without attaching a debugger to the running system. Traces are colelcted only when enabled. Instrument virt2phys with traces: * ERROR: failures that prevent the driver

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ajit, On 01/10/2021 00:48, Ajit Khaparde wrote: diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17e..7a8da3d7ab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1485,10 +1485,36 @@ static void init_config_port_offloads(portid_t pid, uint32

[dpdk-dev] [PATCH 17/18] common/mlx5: support device DMA map and unmap

2021-09-30 Thread michaelba
From: Michael Baum Since MR management has moved to the common area, there is no longer a need for the DMA map and unmap function for each driver. This patch share those functions. For most drivers it supports these operations for the first time. Signed-off-by: Michael Baum Acked-by: Matan Azra

[dpdk-dev] [PATCH 18/18] common/mlx5: share MR mempool registration

2021-09-30 Thread michaelba
From: Michael Baum Expand the use of mempool registration to MR management for other drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 148 ++ drivers/common/mlx5/mlx5_common.h | 9 ++ drivers/common/mlx5/mlx5_

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-09-30 Thread Srikanth K
Sure, I will follow the Windows support approach. Regarding the patches organization, they were arranged logically to the best of my knowledge. The approach followed is to take Linux PMD code and replace the Linux dependent part with the FreeBSD compatible code. All the removals are of this Linux

[dpdk-dev] [PATCH 16/18] common/mlx5: share MR management

2021-09-30 Thread michaelba
From: Michael Baum Add global shared MR cache as a field of common device structure. Move MR management to use this global cache for all drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c| 54 - drivers/common/mlx5/mlx5_com

[dpdk-dev] [PATCH 08/18] common/mlx5: share device context object

2021-09-30 Thread michaelba
From: Michael Baum Create shared context device in common area and add it as a field of common device. Use this context device in all drivers and remove the ctx field from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c

[dpdk-dev] [PATCH 11/18] common/mlx5: share the HCA capabilities handle

2021-09-30 Thread michaelba
From: Michael Baum Add HCA attributes structure as a field of device config structure. It query in common probing, and updates the timestamp format fields. Each driver use HCA attributes from common device config structure, instead of query it for itself. Signed-off-by: Michael Baum Acked-by:

[dpdk-dev] [PATCH 14/18] common/mlx5: add global MR cache create function

2021-09-30 Thread michaelba
From: Michael Baum Add function for global shared MR cache structure initialization. This function include: - btree initialization. - set callbacks for reg and dereg MR. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_verbs.c | 15 +++ drivers

[dpdk-dev] [PATCH 09/18] common/mlx5: add ROCE disable in context device creation

2021-09-30 Thread michaelba
From: Michael Baum Add option to get IB device after disabling RoCE. It is relevant if there is vDPA class in device arguments list. Use common device context in vDPA driver and remove the ctx field from its private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/com

[dpdk-dev] [PATCH 12/18] net/mlx5: remove redundancy in MR file

2021-09-30 Thread michaelba
From: Michael Baum This patch remove two redundant things from MR file: 1. mr_find_contig_memsegs_data structure which is moved to common file before. 2. External memory mechanism - mlx5_tx_update_ext_mp function. Since commit [1] which added support for DMA map and unmap, external mem

[dpdk-dev] [PATCH 13/18] common/mlx5: add MR ctrl init function

2021-09-30 Thread michaelba
From: Michael Baum Add function for MR control structure initialization. This function include: - btree initialization. - dev_gen_ptr initialization. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common_mr.c| 28 + drivers/common/

[dpdk-dev] [PATCH 10/18] common/mlx5: share the protection domain object

2021-09-30 Thread michaelba
From: Michael Baum Create shared Protection Domain in common area and add it and its PDN as fields of common device structure. Use this Protection Domain in all drivers and remove the PD and PDN fields from their private structure. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- driver

[dpdk-dev] [PATCH 07/18] net/mlx5: remove redundant flag in device config

2021-09-30 Thread michaelba
From: Michael Baum Device configure structure has flag named devx as same as SH structure with the same meaning. Remove the flag from the configuration structure and move all the usages to the SH flag. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c |

[dpdk-dev] [PATCH 15/18] common/mlx5: share MR top-half search function

2021-09-30 Thread michaelba
From: Michael Baum Add function to search in local liniar cache and use it in the drivers instead of their functions. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h| 9 drivers/common/mlx5/mlx5_common_mr.c | 52 +++

[dpdk-dev] [PATCH 01/18] net/mlx5/windows: fix miss callback register for mem event

2021-09-30 Thread michaelba
From: Michael Baum In device initialization, the driver registers to free hugepages events. When husepage is released, this callback frees all its related MRs. In Windows initialization, this callback is not registered what may cause to use invalid memory. This patch adds memory event callback

[dpdk-dev] [PATCH 03/18] common/mlx5: share common definitions

2021-09-30 Thread michaelba
From: Michael Baum Create MACRO definitions file in the common driver as preparation for MR and basic probe sharing. Move relevant definitions from the net driver to the above file. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 1 + drivers/co

[dpdk-dev] [PATCH 04/18] common/mlx5: share memory related devargs

2021-09-30 Thread michaelba
From: Michael Baum Add device configure structure and function to parse user device arguments into it. Move parsing and management of relevant device arguments to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 184 ++

[dpdk-dev] [PATCH 00/18] mlx5: sharing global MR cache between drivers

2021-09-30 Thread michaelba
From: Michael Baum The MLNX PMD supports 5 classes (net, RegEx, vDPA, Compress and Crypto). The various drivers are registered under the common driver, and managed by it. In the common driver probing, it calls in a loop the probe function of each driver registered to it. Each driver creates for i

[dpdk-dev] [PATCH 05/18] net/mlx5/windows: rearrange probing code

2021-09-30 Thread michaelba
From: Michael Baum Rearrange device detection code. Rearrange configuration structures filling. Remove unneeded variables. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/windows/mlx5_os.c | 224 - 1 file changed, 94 insertions(+), 130 deleti

[dpdk-dev] [PATCH 02/18] common/mlx5: share basic probing with the internal drivers

2021-09-30 Thread michaelba
From: Michael Baum Create common probing structure that includes, for now, basic probing information detected by the common driver and share it with all the internal drivers. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c | 4 +- drivers/commo

[dpdk-dev] [PATCH 06/18] common/mlx5: move basic probing functions to common

2021-09-30 Thread michaelba
From: Michael Baum Move open IBV/DevX device function to common. Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_common_os.c| 86 ++ drivers/common/mlx5/linux/mlx5_common_os.h| 3 + drivers/common/mlx5/linux/mlx5_common_verbs.c | 70 +

Re: [dpdk-dev] [PATCH 0/2] eal/windows: restore mistakenly hidden API

2021-09-30 Thread Thomas Monjalon
01/09/2021 21:35, Menon, Ranjit: > On 8/28/2021 7:16 PM, Dmitry Kozlyuk wrote: > > Some functions were not exported, and UUID API not even built on Windows > > for no compelling reason. This hasn't been an issue so far, because only > > static build is currently available on Windows, however: > > 1

Re: [dpdk-dev] [kmods PATCH v2 0/4] windows/virt2phys: fix paging issue

2021-09-30 Thread Dmitry Kozlyuk
2021-09-30 22:24 (UTC+0200), Thomas Monjalon: > 23/06/2021 09:13, Thomas Monjalon: > > 26/05/2021 23:01, Dmitry Kozlyuk: > > > v2: > > > * Following ofline review by DmitryM: > > > - Add comment explaining tracking approach for validation team. > > > - Replace deprecated allocatio

Re: [dpdk-dev] [PATCH] eal/windows: expose symbol rte_version

2021-09-30 Thread Thomas Monjalon
11/08/2021 23:55, Dmitry Kozlyuk: > 2021-08-05 17:48 (UTC+), William Tu: > > When OVS inits, it calls rte_version to get the DPDK's version. > > The patch fixes the error below by exposing rte_version symbol. > > libopenvswitch.a(dpdk.c.obj) : error LNK2019: unresolved external symbol > > rte_v

Re: [dpdk-dev] [kmods PATCH v2 0/4] windows/virt2phys: fix paging issue

2021-09-30 Thread Thomas Monjalon
23/06/2021 09:13, Thomas Monjalon: > 26/05/2021 23:01, Dmitry Kozlyuk: > > v2: > > * Following ofline review by DmitryM: > > - Add comment explaining tracking approach for validation team. > > - Replace deprecated allocation API calls. > > - Check properties of locked memory (

Re: [dpdk-dev] [PATCH] windows/netuio: add Intel Virtual Function device IDs

2021-09-30 Thread Thomas Monjalon
15/09/2021 21:07, Dmitry Kozlyuk: > 2021-09-14 17:51 (UTC-0700), Pallavi Kadam: > > Add Intel Ethernet Virtual Function device IDs to netuio inf file > > to support Intel 40GbE and 100GbE deives on Windows VM. > > Nit: why only VM? Can't VF be used from the host? > > > > > Signed-off-by: Pallavi

Re: [dpdk-dev] [PATCH v3 0/3] Support iavf PMD on Windows

2021-09-30 Thread Thomas Monjalon
> Pallavi Kadam (3): > net/iavf: build on Windows > lib/net: fix support of random > doc: update iavf PMD and 21.11 release notes Applied with improvements and intel.com links fixed.

[dpdk-dev] DPDK Release Status Meeting 2021-09-30

2021-09-30 Thread Mcnamara, John
Release status meeting minutes 2021-09-30 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Broadcom * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates * Proposal/V1:Friday

[dpdk-dev] DPDK Release Status Meeting 2021-09-23

2021-09-30 Thread Mcnamara, John
Release status meeting minutes 2021-09-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - * v21.11 dates * Proposal/V1:Friday, 10

Re: [dpdk-dev] [PATCH v3 0/5] A means to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Thomas, On 30/09/2021 19:18, Thomas Monjalon wrote: 23/09/2021 13:20, Ivan Malov: In 2019, commit [1] announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. The problem hasn't been solved. Applications sti

[dpdk-dev] [PATCH v6 2/2] ethdev: change queue release callback

2021-09-30 Thread Xueming Li
Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callbacks are changed to use queue ID - all drive

[dpdk-dev] [PATCH v6 1/2] ethdev: make queue release callback optional

2021-09-30 Thread Xueming Li
Some drivers don't need Rx and Tx queue release callback, make them optional. Clean up empty queue release callbacks for some drivers. Signed-off-by: Xueming Li Reviewed-by: Andrew Rybchenko Acked-by: Ferruh Yigit --- app/test/virtual_pmd.c| 12 drivers/net/af_packet/r

[dpdk-dev] [PATCH v6 0/2] ethdev: change queue release callback

2021-09-30 Thread Xueming Li
This patch is a preparation of shared Rx queue feature[1]. Rxq object could be shared among ports of a share group, a shared rxq object can't tell which port it belongs to. This is the motativation to clean up queue release callback API to use queue ID. v2: included new NFP PMD driver v3: - commit

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ivan Malov
Hi Ori, On 30/09/2021 17:59, Ori Kam wrote: Hi Ivan, Sorry for jumping in late. No worries. That's OK. I have a concern that this patch breaks other PMDs. It does no such thing. From the rst file " One should negotiate flag delivery beforehand" since you only added this function for you

Re: [dpdk-dev] [PATCH v3 3/3] doc: update iavf PMD and 21.11 release notes

2021-09-30 Thread Thomas Monjalon
10/09/2021 01:23, Pallavi Kadam: > Add documentation to support iavf PMD on Windows. > Update the release notes for the same. > > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > --- > --- a/doc/guides/nics/intel_vf.rst > +++ b/doc/guides/nics/intel_vf.rst > +Windows Support > +---

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery of Rx meta data

2021-09-30 Thread Ori Kam
Hi Ivan, Sorry for jumping in late. I have a concern that this patch breaks other PMDs. >From the rst file " One should negotiate flag delivery beforehand" since you only added this function for your PMD all other PMD will fail. I see that you added exception in the examples, but it doesn't make

[dpdk-dev] [PATCH v4 2/6] ethdev: new API to aggregate shared Rx queue group

2021-09-30 Thread Xueming Li
This patch introduces new api to aggreate ports among same shared Rx queue group. Only queues with specified share group are aggregated. Rx burst and device close are expected to be supported by new device. Signed-off-by: Xueming Li --- lib/ethdev/ethdev_driver.h | 23 ++- li

[dpdk-dev] [PATCH v4 1/6] ethdev: introduce shared Rx queue

2021-09-30 Thread Xueming Li
In current DPDK framework, each RX queue is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Most important, polling all ports leads to high cache miss, high latency and low throughput. This patch intro

[dpdk-dev] [PATCH v4 4/6] app/testpmd: dump port info for shared Rx queue

2021-09-30 Thread Xueming Li
In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 14a9a251fb9..4c

[dpdk-dev] [PATCH v4 6/6] app/testpmd: add forwarding engine for shared Rx queue

2021-09-30 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

[dpdk-dev] [PATCH v4 3/6] app/testpmd: new parameter to enable shared Rx queue

2021-09-30 Thread Xueming Li
Adds "--rxq-share" parameter to enable shared rxq for each rxq. Default shared rxq group 0 is used, RX queues in same switch domain shares same rxq according to queue index. Shared Rx queue is enabled only if device support offloading flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ. Signed-off-by: Xueming Li

[dpdk-dev] [PATCH v4 5/6] app/testpmd: force shared Rx queue polled on same core

2021-09-30 Thread Xueming Li
Shared rxqs shares one set rx queue of groups zero. Shared Rx queue must must be polled from one core. Checks and stops forwarding if shared rxq being scheduled on multiple cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 96 ++ app/test-pmd/

[dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-09-30 Thread Xueming Li
In current DPDK framework, all RX queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

Re: [dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-09-30 Thread Ananyev, Konstantin
> > These methods were introduced in 20.05. > There has been no changes in their public API since then. > They seem mature enough to remove the experimental tag. > > Signed-off-by: Sean Morrissey > --- Acked-by: Konstantin Ananyev > -- > 2.25.1

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-09-30 Thread David Marchand
On Thu, Sep 30, 2021 at 3:09 PM wrote: > > From: Zhihong Peng > > AddressSanitizer (ASan) is a google memory error detect > standard tool. It could help to detect use-after-free and > {heap,stack,global}-buffer overflow bugs in C/C++ programs, > print detailed error information when error happens

Re: [dpdk-dev] [dpdk-stable] [DPDK] net/virtio: fix check scatter on all Rx queues

2021-09-30 Thread David Marchand
On Wed, Sep 22, 2021 at 10:13 AM Peng, ZhihongX wrote: > > On 15/09/2021 19:37, David Marchand wrote: > > > On Wed, Aug 4, 2021 at 10:36 AM wrote: > > >> > > >> From: Zhihong Peng > > >> > > >> This patch fixes the wrong way to obtain virtqueue. > > >> The end of virtqueue cannot be judged based

Re: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS Hash

2021-09-30 Thread Ori Kam
Hi Jie, You are missing updating the rte_flow.rst and release notes: Please see more comments below. Thanks, Ori > -Original Message- > From: dev On Behalf Of Jie Wang > Sent: Friday, September 24, 2021 6:17 PM > Subject: [dpdk-dev] [PATCH 3/4] ethdev: support PPPoL2TPv2oUDP RSS > Hash

Re: [dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-09-30 Thread David Christensen
On 9/30/21 2:07 AM, Min Hu (Connor) wrote: Hi, all, I got the answer: testpmd fwd mode should be set "io", then ping OK. IO fwd mode, it will not change packet MAC address info, and ping OK MAC fwd mode, it will change packet MAC address info, like: "rte_ether_addr_copy(&p

[dpdk-dev] [PATCH v1] lib/ring: remove experimental tag from functions

2021-09-30 Thread Sean Morrissey
These methods were introduced in 20.05. There has been no changes in their public API since then. They seem mature enough to remove the experimental tag. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring_hts.h | 9 - lib/ring/rte_ring_peek.h| 13 - lib/ring/rte_rin

[dpdk-dev] [RFC] mempool: implement index-based per core cache

2021-09-30 Thread Dharmik Thakkar
Current mempool per core cache implementation is based on pointer For most architectures, each pointer consumes 64b Replace it with index-based implementation, where in each buffer is addressed by (pool address + index) It will reduce memory requirements L3Fwd performance testing reveals minor imp

Re: [dpdk-dev] [PATCH] [v3] vdpa/ifc: increase readability in function

2021-09-30 Thread Ferruh Yigit
On 9/28/2021 3:22 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: jilei chen >> Sent: Monday, September 27, 2021 6:18 PM >> To: Wang, Xiao W >> Cc: dev@dpdk.org >> Subject: [PATCH] [v3] vdpa/ifc: increase readability in function >> >> Use bool type for function's switch pa

[dpdk-dev] [PATCH v2 2/2] net/cxgbe: add support to get firmware version

2021-09-30 Thread Rahul Lakkireddy
From: Nikhil Vasoya Implement eth_dev_ops callback to get firmware version. Signed-off-by: Nikhil Vasoya Signed-off-by: Rahul Lakkireddy --- v2: - Update FW version feature in cxgbe.ini and cxgbevf.ini doc/guides/nics/features/cxgbe.ini | 1 + doc/guides/nics/features/cxgbevf.ini | 1 +

[dpdk-dev] [PATCH v2 1/2] net/cxgbe: add support for xstats API for the VF

2021-09-30 Thread Rahul Lakkireddy
From: Nikhil Vasoya Add support to fetch port and queue stats via xstats API. Also remove queue stats from basic stats because they're now available via xstats API for the VF. Signed-off-by: Nikhil Vasoya Signed-off-by: Rahul Lakkireddy --- v2: - Update Extended Stats feature in cxgbe.ini and

[dpdk-dev] [PATCH v2 0/2] net/cxgbe: add VF xstats and firmware version

2021-09-30 Thread Rahul Lakkireddy
This series of patches add following features. Patch 1 adds support to fetch port and queue stats via xstats API for VF. Patch 2 adds support to get firmware version. Thanks, Rahul --- v2: - Update Extended Stats and FW version features in cxgbe.ini and cxgbevf.ini Nikhil Vasoya (2): net/c

[dpdk-dev] [PATCH v2 28/28] net/cnxk: reflect globally enabled offloads in queue conf

2021-09-30 Thread Nithin Dabilpuram
Reflect globally enabled Rx and Tx offloads in queue conf. Also fix issue with lmt data prepare for multi seg. Fixes: a24af6361e37 ("net/cnxk: add Tx queue setup and release") Fixes: a86144cd9ded ("net/cnxk: add Rx queue setup and release") Fixes: 305ca2c4c382 ("net/cnxk: support multi-segment vec

[dpdk-dev] [PATCH v2 24/28] net/cnxk: update ethertype for mixed IPsec tunnel versions

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds support to update ethertype for mixed IPsec tunnel versions. And also sets et_overwr for inbound IPsec. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security.c | 1 + drivers/net/cnxk/cn10k_ethdev.h | 3 ++- drivers/net/cnxk/cn10k_ethdev_sec.c | 2

[dpdk-dev] [PATCH v2 23/28] net/cnxk: support IPsec transport mode in cn10k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds IPsec transport mode capability to rte security capabilities. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/cn

[dpdk-dev] [PATCH v2 22/28] net/cnxk: support IPsec anti replay in cn9k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds anti replay support for cn9k platform using SW anti replay check. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn9k_ethdev.h | 3 +++ drivers/net/cnxk/cn9k_ethdev_sec.c | 29 drivers/net/cnxk/cn9k_rx.h | 54 +

[dpdk-dev] [PATCH v2 21/28] net/cnxk: support Tx security offload on cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support to create and submit CPT instructions on Tx on CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 15 +- drivers/event/cnxk/cn10k_worker.h| 74 +- drivers/event/cnxk/cn10k_worker_tx_enq.c | 2 +- drivers/event/cnxk/cn10k_wor

[dpdk-dev] [PATCH v2 27/28] net/cnxk: support configuring channel mask via devargs

2021-09-30 Thread Nithin Dabilpuram
From: Satheesh Paul This patch adds support to configure channel mask which will be used by rte flow when adding flow rules with inline IPsec action. Signed-off-by: Satheesh Paul --- doc/guides/nics/cnxk.rst | 20 +++ drivers/net/cnxk/cnxk_ethdev_sec.c | 39 ++

[dpdk-dev] [PATCH v2 26/28] net/cnxk: add crypto capabilities for AES CBC and HMAC SHA1

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds capabitlities for AES_CBC and HMAC_SHA1 for 9k security offload. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev_sec.c | 40 + drivers/net/cnxk/cn9k_ethdev_sec.c | 40 + 2 files c

[dpdk-dev] [PATCH v2 25/28] net/cnxk: allow zero udp6 checksum for non inline device

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Sets IP6_UDP_OPT in NIX RX config to allow optional UDP checksum for IPv6 in case of security offload. Also disable drop_re when inline inbound is enabled. Signed-off-by: Srujana Challa --- drivers/net/cnxk/cn10k_ethdev.c | 5 + drivers/net/cnxk/cnxk_ethdev.c | 9

[dpdk-dev] [PATCH v2 20/28] net/cnxk: support Rx security offload on cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support to receive CPT processed packets on Rx via second pass on CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 80 ++-- drivers/event/cnxk/cn10k_worker.h | 73 +++- drivers/event/cnxk/cn10k_worker_deq.c | 2 +- drivers/event/cn

[dpdk-dev] [PATCH v2 19/28] net/cnxk: support Tx security offload on cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support to create and submit CPT instructions on Tx on CN9K SoC. Signed-off-by: Nithin Dabilpuram Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_eventdev.c | 29 +- drivers/event/cnxk/cn9k_worker.h | 163 +- drivers/event/cnxk/cn9k_worker_d

[dpdk-dev] [PATCH v2 18/28] net/cnxk: support Rx security offload on cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support to receive CPT processed packets on Rx for CN9K. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn9k_eventdev.c | 153 drivers/event/cnxk/cn9k_worker.h| 7 +- drivers/event/cnxk/cn9k_worker_deq.c| 2 +- drivers/event/cnxk

[dpdk-dev] [PATCH v2 17/28] net/cnxk: support inline security setup for cn10k

2021-09-30 Thread Nithin Dabilpuram
Add support for inline inbound and outbound IPSec for SA create, destroy and other NIX / CPT LF configurations. This patch also changes dpdk-devbind.py to list new inline device as misc device. Signed-off-by: Nithin Dabilpuram --- doc/guides/nics/cnxk.rst | 102 doc/gui

[dpdk-dev] [PATCH v2 16/28] net/cnxk: support inline security setup for cn9k

2021-09-30 Thread Nithin Dabilpuram
Add support for inline inbound and outbound IPSec for SA create, destroy and other NIX / CPT LF configurations. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn9k_ethdev.c | 23 +++ drivers/net/cnxk/cn9k_ethdev.h | 61 +++ drivers/net/cnxk/cn9k_ethdev_sec.c | 31

[dpdk-dev] [PATCH v2 15/28] common/cnxk: support inline IPsec rte flow action

2021-09-30 Thread Nithin Dabilpuram
From: Satheesh Paul Add support to configure flow rules with inline IPsec action. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_nix_inl.h | 3 +++ drivers/common/cnxk/roc_nix_inl_dev.c | 3 +++ drivers/common/cnxk/roc_nix_inl_priv.h | 3 +++ drivers/common/cnxk/roc_npc_mcam

[dpdk-dev] [PATCH v2 12/28] common/cnxk: add CQ enable support in NIX Tx path

2021-09-30 Thread Nithin Dabilpuram
From: Kommula Shiva Shankar This patch provides applications to add CQ support in Tx path. This enables packet completion events on CQ for requested packets. Signed-off-by: Kommula Shiva Shankar --- drivers/common/cnxk/roc_nix.h | 2 ++ drivers/common/cnxk/roc_nix_queue.c | 4 2 fil

[dpdk-dev] [PATCH v2 11/28] common/cnxk: restore NIX sqb pool limit before destroy

2021-09-30 Thread Nithin Dabilpuram
Restore SQB AURA/POOL limit before destroying SQB to be able to drain all the buffers from the aura. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_queue.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_ni

[dpdk-dev] [PATCH v2 06/28] common/cnxk: support NIX inline device init and fini

2021-09-30 Thread Nithin Dabilpuram
Add support to init and fini inline device with NIX LF, SSO LF and SSOW LF for inline inbound IPSec in CN10K. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 2 + drivers/common/cnxk/roc_cpt.c | 7 +- driv

[dpdk-dev] [PATCH v2 10/28] common/cnxk: align CPT LF enable/disable sequence

2021-09-30 Thread Nithin Dabilpuram
For CPT LF IQ enable, set CPT_LF_CTL[ENA] before setting CPT_LF_INPROG[EENA] to true. For CPT LF IQ disable, align sequence to that of HRM. Also this patch aligns space for instructions in CPT LF to ROC_ALIGN to make complete memory cache aligned and has other minor fixes/additions. Signed-off-b

[dpdk-dev] [PATCH v2 09/28] common/cnxk: dump CPT LF registers on error intr

2021-09-30 Thread Nithin Dabilpuram
Dump CPT LF registers on error interrupt for debugging purpose. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_cpt.c | 5 - drivers/common/cnxk/roc_cpt_debug.c | 32 ++-- drivers/common/cnxk/roc_cpt_priv.h | 1 + 3 files changed, 35 insertio

[dpdk-dev] [PATCH v2 14/28] common/cnxk: support anti-replay check in SW for cn9k

2021-09-30 Thread Nithin Dabilpuram
From: Srujana Challa Adds anti replay SW implementation for cn9k platform. Signed-off-by: Srujana Challa --- drivers/common/cnxk/cnxk_security_ar.h | 184 + 1 file changed, 184 insertions(+) create mode 100644 drivers/common/cnxk/cnxk_security_ar.h diff --git

[dpdk-dev] [PATCH v2 05/28] common/cnxk: support NIX inline device IRQ

2021-09-30 Thread Nithin Dabilpuram
Add API to setup NIX inline device IRQ's. This registers IRQ's for errors in case of NIX, CPT LF, SSOW and get wor interrupt in case of SSO. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/meson.build | 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/c

[dpdk-dev] [PATCH v2 13/28] common/cnxk: setup aura BP conf based on nix

2021-09-30 Thread Nithin Dabilpuram
Currently only NIX0 conf is setup in AURA for backpressure. This patch adds support for NIX1 as well. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_fc.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_fc.

[dpdk-dev] [PATCH v2 07/28] common/cnxk: support NIX inline inbound and outbound setup

2021-09-30 Thread Nithin Dabilpuram
Add API to support setting up NIX inline inbound and NIX inline outbound. In case of inbound, SA base is setup on NIX PFFUNC and in case of outbound, required number of CPT LF's are attached to NIX PFFUNC. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/hw/cpt.h | 8 + drivers

  1   2   3   >