Re: [dpdk-dev] [PATCH v6 00/17] i40e base code update

2021-10-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Saturday, October 9, 2021 9:40 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Zhang, Helin ; Wu, Jingjing ; > remy.hor...@intel.com; jijiang@intel.com; jing.d.c...@intel.com; Liang, > Cunming ; Lu, Wenzhuo ; > Guo, Junfen

Re: [dpdk-dev] [PATCH v6 14/17] net/i40e/base: separate kernel allocated Rx bi rings

2021-10-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Saturday, October 9, 2021 9:40 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Zhang, Helin ; Wu, Jingjing ; > remy.hor...@intel.com; jijiang@intel.com; jing.d.c...@intel.com; Liang, > Cunming ; Lu, Wenzhuo ; > Guo, Junfen

Re: [dpdk-dev] [PATCH v6 10/17] net/i40e/base: fix headers to match functions

2021-10-08 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, RobinX > Sent: Saturday, October 9, 2021 9:40 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Zhang, Helin ; Wu, Jingjing ; > remy.hor...@intel.com; jijiang@intel.com; jing.d.c...@intel.com; Liang, > Cunming ; Lu, Wenzhuo ; > Guo, Junfe

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix RxQ/TxQ release

2021-10-08 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wang, Haiyue > Sent: Tuesday, September 28, 2021 8:19 PM > To: Meunier, Julien ; dev@dpdk.org > Cc: sta...@dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix RxQ/TxQ release > > > -Original Message- > >

[dpdk-dev] [PATCH v2] net/iavf: fix multi-process shared data

2021-10-08 Thread dapengx . yu
From: Dapeng Yu When the iavf_adapter instance is not initialized completedly in the primary process, the secondary process accesses its "rte_eth_dev" member, it causes secondary process crash. This patch replaces eth_dev with eth_dev_data in iavf_adapter. Fixes: f978c1c9b3b5 ("net/iavf: add RS

Re: [dpdk-dev] [PATCH 02/10] vdpa/sfc: add support for device initialization

2021-10-08 Thread Xia, Chenbo
Hi Vijay, > -Original Message- > From: Vijay Kumar Srivastava > Sent: Saturday, October 2, 2021 1:32 AM > To: Xia, Chenbo ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; andrew.rybche...@oktetlabs.ru; Harpreet > Singh Anand ; Praveen Kumar Jain > Subject: RE: [PATCH 02/10] vdpa/sfc: add

Re: [dpdk-dev] [PATCH] kni: restrict bifurcated device support

2021-10-08 Thread Stephen Hemminger
On Sat, 9 Oct 2021 00:58:30 +0100 Ferruh Yigit wrote: > To enable bifurcated device support, rtnl_lock is released before calling > userspace callbacks and asynchronous requests are enabled. > > But these changes caused more issues, like bug #809, #816. To reduce the > scope of the problems, th

[dpdk-dev] [PATCH v6 17/17] net/i40e/base: update version in readme

2021-10-08 Thread Robin Zhang
Update base code version in README. Signed-off-by: Robin Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6af2993116..2e4fa5a921 100644 --- a/drivers/net/i40e/base/README +

[dpdk-dev] [PATCH v6 16/17] net/i40e/base: add defines related to DDP

2021-10-08 Thread Robin Zhang
This patch adds some defines related to DDP Track ID. Signed-off-by: Artur Tyminski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index 813c1ec00f..f4a

[dpdk-dev] [PATCH v6 15/17] net/i40e/base: update FVL FW API version to 1.15

2021-10-08 Thread Robin Zhang
Update FVL FW API version to 1.15 Signed-off-by: Maciej Paczkowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index

[dpdk-dev] [PATCH v6 14/17] net/i40e/base: separate kernel allocated Rx bi rings

2021-10-08 Thread Robin Zhang
Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP zero-copy/sk_buff rx_bi rings are now separate. Functions to properly allocate the different rings are added as well. The purpose of this commit is sync with latest share code. Signed-off-by: Björn Töpel Signed-off-by: Robin Zhang

[dpdk-dev] [PATCH v6 13/17] net/i40e/base: add calculation of MAC frequency if no link

2021-10-08 Thread Robin Zhang
Add macros and structures for MAC frequency calculation in case the link is not present. Remove duplicate definition in i40e_ethdev.c Signed-off-by: Piotr Kwapulinski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 9 + drivers/net/i40e/base/i40e_register.h

[dpdk-dev] [PATCH v6 12/17] net/i40e/base: fix checksum is used incorrectly

2021-10-08 Thread Robin Zhang
The variable checksum from i40e_calc_nvm_checksum is used before return value is checked. Fix this logic. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 3ed6c3246f43 ("i40e/base: handle AQ timeout when releasing NVM") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Robin Zhan

[dpdk-dev] [PATCH v6 11/17] net/i40e/base: fix potentially uninitialized variables

2021-10-08 Thread Robin Zhang
The status of i40e_read_nvm_word is not checked, so variables set from this function could be used uninitialized. In this case, preserve the existing flow that does not block initialization by initializing these values from the start. Fixes: 8d6c51fcd24b ("i40e/base: get OEM version") Fixes: 2db70

[dpdk-dev] [PATCH v6 10/17] net/i40e/base: fix headers to match functions

2021-10-08 Thread Robin Zhang
Fix several kernel-doc warnings when building with W=1. These changes are only to comments. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 842ea1996335 ("i40e/base: save link module type") Fixes: fd72a2284a89 ("i40e/base: support LED blinking with new PHY") Fixes: 788fc17b2dec ("i40e/base: suppo

[dpdk-dev] [PATCH v6 09/17] net/i40e/base: add flags and fields for double VLAN

2021-10-08 Thread Robin Zhang
Add flags for outer VLAN and include set port parameters. Add flags, which describe port and switch state for both double VLAN functionality and outer VLAN processing. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 22 ++

[dpdk-dev] [PATCH v6 08/17] net/i40e/base: fix AOC media type

2021-10-08 Thread Robin Zhang
For Active Optical Cable (AOC) the correct media type is "Fibre", not "Direct Attach Copper". Fixes: d749d4d89969 ("i40e/base: add AOC PHY types") Fixes: aa153cc89ff0 ("net/i40e/base: add new PHY types for 25G AOC and ACC") Cc: sta...@dpdk.org Signed-off-by: Dawid Lukwinski Signed-off-by: Robin

[dpdk-dev] [PATCH v6 07/17] net/i40e/base: fix update link data for X722

2021-10-08 Thread Robin Zhang
The X722 card has 'Link Type' information elsewhere than the X710. Previously, for all cards, the 'Link Type' information was retrieved by opcode 0x0607 and this value was wrong for all X722 cards. Now this information for X722 only is taken by opcode 0x0600 (function: i40e_aq_get_phy_capabilities)

[dpdk-dev] [PATCH v6 06/17] net/i40e/base: fix PF reset

2021-10-08 Thread Robin Zhang
PF has to delete all the filters during reset. If it is fully loaded with filters then it is possible that it will take more than 200 ms to finish the reset resulting in timeout during pf_reset and PF reset failed, -15 error indication. Increasing the timeout value for PF reset from 200 to 1000 to

[dpdk-dev] [PATCH v6 05/17] net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters

2021-10-08 Thread Robin Zhang
Unlike other supported adapters, 2.5G and 5G use different PHY type identifiers for reading/writing PHY settings and for reading link status. This commit introduces separate PHY identifiers for these two operation types. Fixes: 988ed63c7441 ("net/i40e/base: add support for Carlsville device") Cc:

[dpdk-dev] [PATCH v6 04/17] net/i40e/base: define new shadow RAM pointers

2021-10-08 Thread Robin Zhang
Add definitions for Shadow RAM pointers: 6th FPA(Free Provisioning Area) module, 5th FPA module in X722 and Preservation Rules module. These definitions are not using by DPDK now, the purpose of this commit is sync with latest share code. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin

[dpdk-dev] [PATCH v6 03/17] net/i40e/base: set TSA table values when parsing CEE config

2021-10-08 Thread Robin Zhang
Driver did not Set TSA(Transmit Selection Algorithm) table values when parsing CEE(Converged Enhanced Ethernet) configuration obtained from FW. Signed-off-by: Pawel Malinowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_dcb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deleti

[dpdk-dev] [PATCH v6 02/17] net/i40e/base: add Min SRev for 4 more X722 modules

2021-10-08 Thread Robin Zhang
Some customers want to downgrade to an earlier FW security revision, this already implemented by FW so that customers can have more control over the security revisions they can use. FW also implemented a mechanism via NVMupdate to allow the users to accept or not a baseline Min SRev version that wi

[dpdk-dev] [PATCH v6 01/17] net/i40e/base: add v2 version of send ASQ command functions

2021-10-08 Thread Robin Zhang
ASQ(Admin Send Queue) send command functions are returning only i40e status codes yet some calling functions also need Admin Queue status that is stored in hw->aq.asq_last_status. Since hw object is stored on a heap it introduces a possibility for a race condition in access to hw if calling functio

[dpdk-dev] [PATCH v6 00/17] i40e base code update

2021-10-08 Thread Robin Zhang
update i40e base code. source code of i40e driver: cid-i40e.2021.08.16.tar.gz changelog in i40e share repo: >From 59a080f4fafe ("i40e-shared: Add opcode 0x0406 and 0x0416 to Linux support") To 2c7aab559654 ("i40e-shared: Add defines related to DDP") The following commits are ignored: cb9139e3bce

[dpdk-dev] [PATCH v5 17/17] net/i40e/base: update version in readme

2021-10-08 Thread Robin Zhang
Update base code version in README. Signed-off-by: Robin Zhang --- drivers/net/i40e/base/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 6af2993116..2e4fa5a921 100644 --- a/drivers/net/i40e/base/README +

[dpdk-dev] [PATCH v5 16/17] net/i40e/base: add defines related to DDP

2021-10-08 Thread Robin Zhang
This patch adds some defines related to DDP Track ID. Signed-off-by: Artur Tyminski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_type.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/i40e/base/i40e_type.h b/drivers/net/i40e/base/i40e_type.h index 813c1ec00f..f4a

[dpdk-dev] [PATCH v5 15/17] net/i40e/base: update FVL FW API version to 1.15

2021-10-08 Thread Robin Zhang
Update FVL FW API version to 1.15 Signed-off-by: Maciej Paczkowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h index

[dpdk-dev] [PATCH v5 14/17] net/i40e/base: separate kernel allocated Rx bi rings

2021-10-08 Thread Robin Zhang
Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP zero-copy/sk_buff rx_bi rings are now separate. Functions to properly allocate the different rings are added as well. The purpose of this commit is sync with latest share code. Signed-off-by: Björn Töpel Signed-off-by: Robin Zhang

[dpdk-dev] [PATCH v5 13/17] net/i40e/base: add calculation of MAC frequency if no link

2021-10-08 Thread Robin Zhang
Add macros and structures for MAC frequency calculation in case the link is not present. Remove duplicate definition in i40e_ethdev.c Signed-off-by: Piotr Kwapulinski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 9 + drivers/net/i40e/base/i40e_register.h

[dpdk-dev] [PATCH v5 12/17] net/i40e/base: fix checksum is used incorrectly

2021-10-08 Thread Robin Zhang
The variable checksum from i40e_calc_nvm_checksum is used before return value is checked. Fix this logic. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 3ed6c3246f43 ("i40e/base: handle AQ timeout when releasing NVM") Cc: sta...@dpdk.org Signed-off-by: Christopher Pau Signed-off-by: Robin Zhan

[dpdk-dev] [PATCH v5 11/17] net/i40e/base: fix potentially uninitialized variables

2021-10-08 Thread Robin Zhang
The status of i40e_read_nvm_word is not checked, so variables set from this function could be used uninitialized. In this case, preserve the existing flow that does not block initialization by initializing these values from the start. Fixes: 8d6c51fcd24b ("i40e/base: get OEM version") Fixes: 2db70

[dpdk-dev] [PATCH v5 10/17] net/i40e/base: fix headers to match functions

2021-10-08 Thread Robin Zhang
Fix several kernel-doc warnings when building with W=1. These changes are only to comments. Fixes: 8db9e2a1b232 ("i40e: base driver") Fixes: 842ea1996335 ("i40e/base: save link module type") Fixes: fd72a2284a89 ("i40e/base: support LED blinking with new PHY") Fixes: 788fc17b2dec ("i40e/base: suppo

[dpdk-dev] [PATCH v5 09/17] net/i40e/base: add flags and fields for double VLAN

2021-10-08 Thread Robin Zhang
Add flags for outer VLAN and include set port parameters. Add flags, which describe port and switch state for both double VLAN functionality and outer VLAN processing. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_adminq_cmd.h | 22 ++

[dpdk-dev] [PATCH v5 08/17] net/i40e/base: fix AOC media type

2021-10-08 Thread Robin Zhang
For Active Optical Cable (AOC) the correct media type is "Fibre", not "Direct Attach Copper". Fixes: d749d4d89969 ("i40e/base: add AOC PHY types") Fixes: aa153cc89ff0 ("net/i40e/base: add new PHY types for 25G AOC and ACC") Cc: sta...@dpdk.org Signed-off-by: Dawid Lukwinski Signed-off-by: Robin

[dpdk-dev] [PATCH v5 07/17] net/i40e/base: fix update link data for X722

2021-10-08 Thread Robin Zhang
The X722 card has 'Link Type' information elsewhere than the X710. Previously, for all cards, the 'Link Type' information was retrieved by opcode 0x0607 and this value was wrong for all X722 cards. Now this information for X722 only is taken by opcode 0x0600 (function: i40e_aq_get_phy_capabilities)

[dpdk-dev] [PATCH v5 06/17] net/i40e/base: fix PF reset

2021-10-08 Thread Robin Zhang
PF has to delete all the filters during reset. If it is fully loaded with filters then it is possible that it will take more than 200 ms to finish the reset resulting in timeout during pf_reset and PF reset failed, -15 error indication. Increasing the timeout value for PF reset from 200 to 1000 to

[dpdk-dev] [PATCH v5 05/17] net/i40e/base: fix PHY identifiers for 2.5G and 5G adapters

2021-10-08 Thread Robin Zhang
Unlike other supported adapters, 2.5G and 5G use different PHY type identifiers for reading/writing PHY settings and for reading link status. This commit introduces separate PHY identifiers for these two operation types. Fixes: 988ed63c7441 ("net/i40e/base: add support for Carlsville device") Cc:

[dpdk-dev] [PATCH v5 04/17] net/i40e/base: define new shadow RAM pointers

2021-10-08 Thread Robin Zhang
Add definitions for Shadow RAM pointers: 6th FPA(Free Provisioning Area) module, 5th FPA module in X722 and Preservation Rules module. These definations are not using by DPDK now, the purpose of this commit is sync with latest share code. Signed-off-by: Stanislaw Grzeszczak Signed-off-by: Robin

[dpdk-dev] [PATCH v5 03/17] net/i40e/base: set TSA table values when parsing CEE config

2021-10-08 Thread Robin Zhang
Driver did not Set TSA(Transmit Selection Algorithm) table values when parsing CEE(Converged Enhanced Ethernet) configuration obtained from FW. Signed-off-by: Pawel Malinowski Signed-off-by: Robin Zhang --- drivers/net/i40e/base/i40e_dcb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deleti

[dpdk-dev] [PATCH v5 01/17] net/i40e/base: add v2 version of send ASQ command functions

2021-10-08 Thread Robin Zhang
ASQ(Admin Send Queue) send command functions are returning only i40e status codes yet some calling functions also need Admin Queue status that is stored in hw->aq.asq_last_status. Since hw object is stored on a heap it introduces a possibility for a race condition in access to hw if calling functio

[dpdk-dev] [PATCH v5 02/17] net/i40e/base: add Min SRev for 4 more X722 modules

2021-10-08 Thread Robin Zhang
Some customers want to downgrade to an earlier FW security revision, this already implemented by FW so that customers can have more control over the security revisions they can use. FW also implemented a mechanism via NVMupdate to allow the users to accept or not a baseline Min SRev version that wi

[dpdk-dev] [PATCH v5 00/17] i40e base code update

2021-10-08 Thread Robin Zhang
update i40e base code. source code of i40e driver: cid-i40e.2021.08.16.tar.gz changelog in i40e share repo: >From 59a080f4fafe ("i40e-shared: Add opcode 0x0406 and 0x0416 to Linux support") To 2c7aab559654 ("i40e-shared: Add defines related to DDP") The following commits are ignored: cb9139e3bce

Re: [dpdk-dev] [PATCH] ethdev: fix eth device released repeatedly

2021-10-08 Thread lihuisong (C)
在 2021/10/8 18:23, Thomas Monjalon 写道: 08/10/2021 10:21, Huisong Li: In secondary process, because it doesn't clear eth_dev->data, the "eth_dev" above will not be NULL when rte_eth_dev_close() has been called before this interface is called. In this case, Ethernet device will be released repea

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Fri, Oct 8, 2021 at 5:02 PM Kadam, Pallavi wrote: > > > On 10/8/2021 6:53 AM, William Tu wrote: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID 0x10D3, > > verifying rx/tx work

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Kadam, Pallavi
On 10/8/2021 6:53 AM, William Tu wrote: This patch enables building the e1000 driver for Windows. I tested using two Windows VM on top of VMware Fusion, creating two e1000 devices with device ID 0x10D3, verifying rx/tx works correctly using dpdk-testpmd.exe rxonly and txonly mode. Signed-off-b

[dpdk-dev] [PATCH] kni: restrict bifurcated device support

2021-10-08 Thread Ferruh Yigit
To enable bifurcated device support, rtnl_lock is released before calling userspace callbacks and asynchronous requests are enabled. But these changes caused more issues, like bug #809, #816. To reduce the scope of the problems, the bifurcated device support related changes are only enabled when i

Re: [dpdk-dev] [PATCH v3] eal/windows: ensure all enabled CPUs are counted

2021-10-08 Thread Narcisa Ana Maria Vasile
On Wed, Aug 18, 2021 at 06:46:00AM -0700, Narcisa Ana Maria Vasile wrote: > From: Narcisa Vasile > > On Windows, -l/--lcores EAL option was unable to process CPU sets > containing CPUs other than 0 and 1, because CPU_COUNT() macro > only checked these CPUs in the set. Fix CPU_COUNT() by enumerati

Re: [dpdk-dev] [PATCH v5 2/2] cmdline: make struct rdline opaque

2021-10-08 Thread Narcisa Ana Maria Vasile
On Fri, Oct 08, 2021 at 01:10:28AM +0300, Dmitry Kozlyuk wrote: > Hide struct rdline definition and some RDLINE_* constants in order > to be able to change internal buffer sizes transparently to the user. > Add new functions: > > * rdline_new(): allocate and initialize struct rdline. > This func

Re: [dpdk-dev] [PATCH v5 1/2] cmdline: make struct cmdline opaque

2021-10-08 Thread Narcisa Ana Maria Vasile
On Fri, Oct 08, 2021 at 01:10:27AM +0300, Dmitry Kozlyuk wrote: > Remove the definition of `struct cmdline` from public header. > Deprecation notice: > https://mails.dpdk.org/archives/dev/2020-September/183310.html > > Signed-off-by: Dmitry Kozlyuk > Acked-by: David Marchand > Acked-by: Olivier

[dpdk-dev] [PATCH v15 7/9] eal: implement functions for mutex management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock, trylock. Add RTE_STATIC_MUTEX macro to replace static initialization of mutexes. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). The RTE_STATIC_MUTEX calls into

[dpdk-dev] [PATCH v15 8/9] eal: implement functions for thread barrier management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v15 6/9] eal: add thread lifetime management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v15 9/9] Add unit tests for thread API

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. The tests verify that: * mutexes and barriers behave as expected * thread properties are applied correctly * the thread id is retrieved correctly * thread creation/des

[dpdk-dev] [PATCH v15 5/9] eal: implement thread priority management functions

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for setting and getting the priority of a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. On Linux, the following mapping is created: RTE_THREAD_PRIORITY_NORMAL corresponds to * policy SCHED_OTH

[dpdk-dev] [PATCH v15 2/9] eal: add thread attributes

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v15 4/9] eal: implement functions for thread affinity management

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v15 3/9] eal/windows: translate Windows errors to errno-style errors

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 6 +-- lib/eal/

[dpdk-dev] [PATCH v15 1/9] eal: add basic threading functions

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v15 0/9] eal: Add EAL API for threading

2021-10-08 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-08 Thread Slava Ovsiienko
Hi, I've reviewed the series, and it looks good to me. I see we did not introduce new indirect referencing on the datapath (just replaced rte_eth_devices[] being hidden with the new rte_eth_fp_ops[].) My only concern - we'll get two places where pointers to the PMDs routines are stored, and it me

[dpdk-dev] [PATCH v3 8/9] gpudev: add communication list

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [PATCH v3 7/9] gpudev: add communication flag

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. When mixing network activity with task processing there may be the need to put in communication the CPU with the device in order to synchronize op

[dpdk-dev] [PATCH v3 6/9] gpudev: add memory barrier

2021-10-08 Thread eagostini
From: Elena Agostini Add a function for the application to ensure the coherency of the writes executed by another device into the GPU memory. Signed-off-by: Elena Agostini --- doc/guides/prog_guide/gpudev.rst | 8 lib/gpudev/gpudev.c | 19 +++ lib/gpudev/

[dpdk-dev] [PATCH v3 9/9] doc: add CUDA example in GPU guide

2021-10-08 Thread eagostini
From: Elena Agostini Signed-off-by: Elena Agostini --- doc/guides/prog_guide/gpudev.rst | 122 +++ 1 file changed, 122 insertions(+) diff --git a/doc/guides/prog_guide/gpudev.rst b/doc/guides/prog_guide/gpudev.rst index cbaec5a1e4..1baf0c6772 100644 --- a/doc/guides

[dpdk-dev] [PATCH v3 0/9] GPU library

2021-10-08 Thread eagostini
From: eagostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The goal of this new library is to enhance the collaboration between DPDK, that's primarily a CPU framework, and GPU devices. When mixing network act

[dpdk-dev] [PATCH v3 5/9] gpudev: add memory API

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. Such workload distribution can be achieved by sharing some memory. As a first step, the features are focused on memory management. A function all

[dpdk-dev] [PATCH v3 1/9] gpudev: introduce GPU device class library

2021-10-08 Thread eagostini
From: Elena Agostini In heterogeneous computing system, processing is not only in the CPU. Some tasks can be delegated to devices working in parallel. The new library gpudev is for dealing with GPGPU computing devices from a DPDK application running on the CPU. The infrastructure is prepared to

[dpdk-dev] [PATCH v3 4/9] gpudev: support multi-process

2021-10-08 Thread eagostini
From: Thomas Monjalon The device data shared between processes are moved in a struct allocated in a shared memory (a new memzone for all GPUs). The main struct rte_gpu references the shared memory via the pointer mpshared. The API function rte_gpu_attach() is added to attach a device from the se

[dpdk-dev] [PATCH v3 3/9] gpudev: add child device representing a device context

2021-10-08 Thread eagostini
From: Thomas Monjalon The computing device may operate in some isolated contexts. Memory and processing are isolated in a silo represented by a child device. The context is provided as an opaque by the caller of rte_gpu_add_child(). Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/gpud

[dpdk-dev] [PATCH v3 2/9] gpudev: add event notification

2021-10-08 Thread eagostini
From: Thomas Monjalon Callback functions may be registered for a device event. Callback management is per-process and not thread-safe. The events RTE_GPU_EVENT_NEW and RTE_GPU_EVENT_DEL are notified respectively after creation and before removal of a device, as part of the library functions. Som

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread William Tu
On Fri, Oct 8, 2021 at 1:35 PM Dmitry Kozlyuk wrote: > > 2021-10-08 06:53 (UTC-0700), William Tu: > > This patch enables building the e1000 driver for Windows. > > I tested using two Windows VM on top of VMware Fusion, > > creating two e1000 devices with device ID 0x10D3, > > verifying rx/tx works

[dpdk-dev] [PATCH] lpm: fix buffer overflow

2021-10-08 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=819 The rte_lpm6 keeps routing information for control plane purpose inside the rte_hash table which uses rte_jhash() as a hash function. >From the rte_jhash() documentation: If input key is n

[dpdk-dev] [PATCH] test/hash: fix buffer overflow

2021-10-08 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=818 Some tests for the rte_hash table use the rte_jhash_32b() as the hash function. This hash function interprets the length argument in units of 4 bytes. This patch divides configured key le

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Kadam, Pallavi
On 10/8/2021 9:08 AM, Wang, Haiyue wrote: -Original Message- From: William Tu Sent: Friday, October 8, 2021 21:54 To: dev@dpdk.org Cc: Kadam, Pallavi ; david.march...@redhat.com; Wang, Haiyue Subject: [PATCH v2] net/e1000: build on Windows This patch enables building the e1000 drive

[dpdk-dev] [PATCH] doc/windows_gsg: update section on driver installation

2021-10-08 Thread Dmitry Kozlyuk
Windows GSG included a section only on virt2phys driver installation, but not on NetUIO. The content of the section duplicated documentation in dpdk-kmods, but contained no links to it, only a reference. Add subsections for virt2phys and NetUIO, explaining their roles. Refer to documenttion in dpd

Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten

2021-10-08 Thread Ferruh Yigit
On 10/4/2021 5:18 PM, Elad Nachman wrote: On Mon, Oct 4, 2021 at 7:05 PM Ferruh Yigit wrote: On 10/4/2021 3:58 PM, Elad Nachman wrote: בתאריך יום ב׳, 4 באוק׳ 2021, 17:51, מאת Ferruh Yigit ‏< ferruh.yi...@intel.com>: On 10/4/2021 3:25 PM, Elad Nachman wrote: Can you please try to not top po

[dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields

2021-10-08 Thread Akhil Goyal
In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits available in the structure. Now for every new sa option, these reserved_opts can be reduced and new option can be added. Signed-off-b

[dpdk-dev] [PATCH v2 2/3] security: hide internal API

2021-10-08 Thread Akhil Goyal
rte_security_dynfield_register() is an internal API to be used by the driver, hence moving it to internal. Signed-off-by: Akhil Goyal Acked-by: Konstantin Ananyev --- v2: no change lib/security/rte_security_driver.h | 2 +- lib/security/version.map | 7 ++- 2 files changed, 7 ins

[dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-08 Thread Akhil Goyal
Remove *_LIST_END enumerators from asymmetric crypto lib to avoid ABI breakage for every new addition in enums. Signed-off-by: Akhil Goyal --- v2: no change app/test/test_cryptodev_asym.c | 4 ++-- drivers/crypto/qat/qat_asym.c | 2 +- lib/cryptodev/rte_crypto_asym.h | 4 3 files change

Re: [dpdk-dev] [PATCH v2] net/e1000: build on Windows

2021-10-08 Thread Dmitry Kozlyuk
2021-10-08 06:53 (UTC-0700), William Tu: > This patch enables building the e1000 driver for Windows. > I tested using two Windows VM on top of VMware Fusion, > creating two e1000 devices with device ID 0x10D3, > verifying rx/tx works correctly using dpdk-testpmd.exe > rxonly and txonly mode. > > S

Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries

2021-10-08 Thread Akhil Goyal
> Subject: RE: [EXT] [PATCH v7 0/8] new features for ipsec and security > libraries > > > Add support for: > > TSO, NAT-T/UDP encapsulation, ESN > > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > > SA telemetry > > mbuf offload flags > > Initial SQN value > > > > Radu Nicolau (8): > > security: add

Re: [dpdk-dev] [PATCH v2] kni: Fix request overwritten

2021-10-08 Thread Ferruh Yigit
On 10/4/2021 7:27 PM, Elad Nachman wrote: בתאריך יום ב׳, 4 באוק׳ 2021, 20:00, מאת Eric Christian ‏ : I am not sure that only we can recreate the KNI request overwrite. We may be the only ones with a current use case that exposes the vulnerability. It is possible for any KNI operation to enc

Re: [dpdk-dev] [PATCH v3 5/9] gpudev: add memory API

2021-10-08 Thread Thomas Monjalon
09/10/2021 03:53, eagost...@nvidia.com: > --- a/lib/gpudev/version.map > +++ b/lib/gpudev/version.map > + rte_gpu_free; > rte_gpu_info_get; > rte_gpu_init; > rte_gpu_is_valid; > + rte_gpu_malloc; > + rte_gpu_register; > + rte_gpu_unregister; > }; Should we insert

Re: [dpdk-dev] [PATCH v3 6/9] gpudev: add memory barrier

2021-10-08 Thread Thomas Monjalon
09/10/2021 03:53, eagost...@nvidia.com: > From: Elena Agostini > > Add a function for the application to ensure the coherency > of the writes executed by another device into the GPU memory. > > Signed-off-by: Elena Agostini > --- > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change

[dpdk-dev] [PATCH v2] test/crypto-perf: support lookaside IPsec

2021-10-08 Thread Akhil Goyal
Added support for lookaside IPsec protocol offload. Supported cases: -AEAD -Cipher+auth Command used for testing: ./dpdk-test-crypto-perf -c 0xf -- --devtype crypto_octeontx2 --ptest throughput --optype ipsec --cipher-algo aes-cbc --pool-sz 16384 --cipher-op encrypt --cipher-key-sz 16 --cipher-iv-

Re: [dpdk-dev] [EXT] [PATCH v1] bbdev: remove experimental tag from API

2021-10-08 Thread Akhil Goyal
> This promotes the bbdev interface to stable. > Overdue for some time as bbdev interface has been stable. > > Signed-off-by: Nicolas Chautru > --- Acked-by: Akhil Goyal If anybody has any objections please raise or else this patch Will be merged in RC1.

Re: [dpdk-dev] [EXT] [PATCH] crypto/ipsec_mb: support ZUC-256

2021-10-08 Thread Akhil Goyal
> Add support for ZUC-EEA3-256 and ZUC-EIA3-256 > (only 4-byte tags supported for now). > > Signed-off-by: Pablo de Lara > --- > > This patch depends on patchset > https://patches.dpdk.org/project/dpdk/list/?series=18470 > Hi Fan/Ciara/Pablo, Please add this patch also to the dependent series.

Re: [dpdk-dev] [EXT] [PATCH v3 8/8] examples/ipsec-secgw: add support for additional algorithms

2021-10-08 Thread Akhil Goyal
> Add support for AES-GMAC, AES_CTR, AES_XCBC_MAC, > AES_CCM, CHACHA20_POLY1305 > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.h | 3 +- > examples/ipsec-secgw/sa.c| 133 --- > 2 files changed, 126 inserti

Re: [dpdk-dev] [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for defining initial sequence number value

2021-10-08 Thread Akhil Goyal
> Subject: [EXT] [PATCH v3 6/8] examples/ipsec-secgw: add support for > defining initial sequence number value > Subject too long. examples/ipsec-secgw: define initial ESN value > Add esn field to SA definition block to allow initial ESN value The commit description should describe the new opt

Re: [dpdk-dev] [EXT] [PATCH v3 5/8] examples/ipsec-secgw: add support for telemetry

2021-10-08 Thread Akhil Goyal
Subject can be Examples/ipsec-secgw: support telemetry > Add telemetry support to the IPsec GW sample app > Elaborate patch description to show how it can be used. Probably it is worth mentioning how the output will look like. > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > ---

Re: [dpdk-dev] [EXT] [PATCH v3 4/8] examples/ipsec-secgw: add support for TSO

2021-10-08 Thread Akhil Goyal
> Add support to allow user to specific MSS for TSO offload on a per SA > basis. MSS configuration in the context of IPsec is only supported for > outbound SA's in the context of an inline IPsec Crypto offload. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > --- > doc/guides/s

Re: [dpdk-dev] [EXT] [PATCH v3 3/8] examples/ipsec-secgw: add support for inline crypto UDP encapsulation

2021-10-08 Thread Akhil Goyal
> Enable UDP encapsulation for both transport and tunnel modes for the > inline crypto offload path. > > Signed-off-by: Radu Nicolau > --- > examples/ipsec-secgw/ipsec.c | 33 + > examples/ipsec-secgw/ipsec.h | 7 ++- > examples/ipsec-secgw/sa.c| 9 +++

Re: [dpdk-dev] [EXT] [PATCH v3 2/8] examples/ipsec-secgw: update create inline session

2021-10-08 Thread Akhil Goyal
> Rework create inline session function as to update the session > configuration parameters before create session is called. > Also updated the rss key array size to prevent buffers overflows > with PMDs that copy more than 40 bytes. > > Signed-off-by: Radu Nicolau > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [EXT] [PATCH v3 1/8] examples/ipsec-secgw: add stats interval argument

2021-10-08 Thread Akhil Goyal
> diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst > b/doc/guides/sample_app_ug/ipsec_secgw.rst > index 78171b25f9..846cf2b81a 100644 > --- a/doc/guides/sample_app_ug/ipsec_secgw.rst > +++ b/doc/guides/sample_app_ug/ipsec_secgw.rst > @@ -127,6 +127,7 @@ The application has a number of command

Re: [dpdk-dev] [EXT] [PATCH v7 2/8] ipsec: add support for AEAD algorithms

2021-10-08 Thread Akhil Goyal
> Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > Acked-by: Konstantin Ananyev > --- > lib/ipsec/crypto.h | 137 >

Re: [dpdk-dev] [EXT] [PATCH v7 0/8] new features for ipsec and security libraries

2021-10-08 Thread Akhil Goyal
> Add support for: > TSO, NAT-T/UDP encapsulation, ESN > AES_CCM, CHACHA20_POLY1305 and AES_GMAC > SA telemetry > mbuf offload flags > Initial SQN value > > Radu Nicolau (8): > security: add ESN field to ipsec_xform > ipsec: add support for AEAD algorithms > security: add UDP params for IPse

Re: [dpdk-dev] [EXT] [PATCH 1/3] crypto/aesni_mb: add NULL/NULL support

2021-10-08 Thread Akhil Goyal
> > Hi Radu and Akhil > > We can add this change as a patch into > http://patchwork.dpdk.org/project/dpdk/cover/20210929163035.608387-1-ciara.po...@intel.com/ > v4 it is ok. > The doc can be updated accordingly. > No issues from my side.

Re: [dpdk-dev] [PATCH 0/2] Bugfixes for bonding

2021-10-08 Thread Ferruh Yigit
On 9/22/2021 8:09 AM, Min Hu (Connor) wrote: This patchset contains two bugfixes for bonding. Chengchang Tang (2): net/bonding: fix dedicated queue mode in vector burst net/bonding: fix RSS key length Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v5 2/6] ethdev: move jumbo frame offload check to library

2021-10-08 Thread Ananyev, Konstantin
> > Setting MTU bigger than RTE_ETHER_MTU requires the jumbo frame support, > and application should enable the jumbo frame offload support for it. > > When jumbo frame offload is not enabled by application, but MTU bigger > than RTE_ETHER_MTU is requested there are two options, either fail or >

  1   2   3   >