Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Thomas Monjalon
13/10/2021 07:36, Anoob Joseph: > From: Thomas Monjalon > > 12/10/2021 16:47, Kinsella, Ray: > > > On 12/10/2021 15:18, Anoob Joseph wrote: > > > > From: Thomas Monjalon > > > >> 12/10/2021 15:38, Anoob Joseph: > > > >>> From: Thomas Monjalon > > > 12/10/2021 13:34, Anoob Joseph: > > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Anoob Joseph
Hi Akhil, Ray, Thomas, Please see inline. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, October 13, 2021 12:32 PM > To: Akhil Goyal ; dev@dpdk.org; Kinsella, Ray > ; Anoob Joseph > Cc: david.march...@redhat.com; hemant.agra...@nxp.com; > pablo.de.lara.gu

Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-13 Thread Andrew Rybchenko
On 10/12/21 11:14 PM, Stephen Hemminger wrote: > On Tue, 12 Oct 2021 21:39:57 +0200 > David Marchand wrote: > >> As stated in the API, dynamic field and flags should be created with no >> additional flag (simply in the API for future changes). >> >> Fix the dynamic flag register helper which was

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: fix max Rx packet length

2021-10-13 Thread Xu, Rosen
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, October 12, 2021 7:54 > To: Jerin Jacob ; Li, Xiaoyun ; > Chas Williams ; Min Hu (Connor) ; > Hemant Agrawal ; Sachin Saxena > ; Zhang, Qi Z ; Wang, > Xiao W ; Matan Azrad ; > Viacheslav Ovsiienko ; Harman Kalra > ; Maciej Cz

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: remove jumbo offload flag

2021-10-13 Thread Michał Krawczyk
wt., 12 paź 2021 o 01:54 Ferruh Yigit napisał(a): > > Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. > > Instead of drivers announce this capability, application can deduct the > capability by checking reported 'dev_info.max_mtu' or > 'dev_info.max_rx_pktlen'. > > And instead of application s

[dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option

2021-10-13 Thread Sarosh Arif
The default behaviour of l2fwd is to exit if we are unable to turn promiscuous mode on. On some aws instances turning promiscuous mode on is not permitted. In such cases there should be a way to run the application without promiscuous mode. This patch allows user to turn promiscuous mode on via c

Re: [dpdk-dev] [PATCH v25 1/6] dmadev: introduce DMA device library

2021-10-13 Thread Thomas Monjalon
13/10/2021 02:21, fengchengwen: > On 2021/10/13 3:09, Thomas Monjalon wrote: > > 11/10/2021 09:33, Chengwen Feng: > >> +static void > >> +dma_release(struct rte_dma_dev *dev) > >> +{ > >> + rte_free(dev->dev_private); > >> + memset(dev, 0, sizeof(struct rte_dma_dev)); > >> +} [...] > >> +int > >>

[dpdk-dev] [dpdk-users] DPDK VF rte_flow invalid - Cannot create flow on VF

2021-10-13 Thread my Zhu
Hi, I am trying to create some flow rules on VF using DPDK 19.08 rte_flow API. But it returns -38, *Function not implemented* when I called rte_flow_validate(). I bind I40E on PF0 and vfio-pci on VF0 and iavf on VF1 and VF2 I just wanna know can X710's VF create flow rules using rte_flow. Should

[dpdk-dev] [PATCH v5] ethdev: replace bit shifts with macros

2021-10-13 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, unsigne

[dpdk-dev] [PATCH v4] eventdev/rx_adapter: add telemetry callbacks

2021-10-13 Thread Ganapati Kundapura
Added telemetry callbacks to get Rx adapter stats, reset stats and to get Rx queue config information. Acked-by: Jay Jayatheerthan Signed-off-by: Ganapati Kundapura --- v4: * Addressed segfault when per Rx queue event buffer is used. v3: * Updated release notes. * Addressed review comments. v

Re: [dpdk-dev] [PATCH] doc: remove web references to internal guides

2021-10-13 Thread Thomas Monjalon
08/10/2021 09:34, David Marchand: > On Thu, Oct 7, 2021 at 2:22 PM Thomas Monjalon wrote: > > > > The guides should be referenced locally with RST syntax > > :doc: (beginning of page) or :ref: (specific chapter). > > The links to doc.dpdk.org/guides/ are removed. > > > > The links to the doc.dpdk.

Re: [dpdk-dev] [PATCH v6 1/2] Enable ASan for memory detector on DPDK

2021-10-13 Thread Bruce Richardson
On Thu, Sep 30, 2021 at 10:20:00AM +0200, David Marchand wrote: > Hello, > > I see v6 is superseded in pw, I have been cleaning my queue... maybe my fault. > > > On Thu, Sep 30, 2021 at 7:37 AM wrote: > > > > From: Zhihong Peng > > > > AddressSanitizer (ASan) is a google memory error detect >

[dpdk-dev] [PATCH v1 0/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Serena He
This is to enable DPDK GitHub Actions on arm64 and CI jobs are triggered only for repos installed with given GHApp and runners. Serena He (1): ci: enable DPDK GHA for arm64 with self-hosted runners .github/workflows/build-arm64.yml | 118 ++ 1 file changed, 118 in

[dpdk-dev] [PATCH v1 1/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Serena He
CI jobs are triggered only for repos installed with given GHApp and runners Cc: sta...@dpdk.org Signed-off-by: Serena He --- .github/workflows/build-arm64.yml | 118 ++ 1 file changed, 118 insertions(+) create mode 100644 .github/workflows/build-arm64.yml diff --g

[dpdk-dev] [PATCH] net/hns3: fix incorrect free function

2021-10-13 Thread Min Hu (Connor)
From: Chengwen Feng The intr_handle->intr_vec is allocated by rte_zmalloc(), but freed by free(), this patch fixes it. Fixes: 02a7b55657b2 ("net/hns3: support Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_ethdev_vf.c | 2 +- 1 file changed, 1 insert

Re: [dpdk-dev] [PATCH 1/3] ethdev: introduce flow pre-configuration hints

2021-10-13 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 9:48 PM Alexander Kozyrev wrote: > > The flow rules creation/destruction at a large scale incurs a performance > penalty and may negatively impact the packet processing when used > as part of the datapath logic. This is mainly because software/hardware > resources are alloca

Re: [dpdk-dev] [PATCH v3] eventdev/rx_adapter: add telemetry callbacks

2021-10-13 Thread Kundapura, Ganapati
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: 13 October 2021 12:18 > To: Kundapura, Ganapati ; Jayatheerthan, Jay > ; jerinjac...@gmail.com; dev@dpdk.org > Cc: Kinsella, Ray ; Thomas Monjalon > ; David Marchand > Subject: RE: [PATCH v3] eventdev/rx_adapter: add tele

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash

2021-10-13 Thread Wang, Jie1X
> -Original Message- > From: Ori Kam > Sent: Tuesday, October 12, 2021 11:32 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yigit, Ferruh ; NBU-Contact-Thomas Monjalon > ; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Wu, Wenjun1 > > Subject:

Re: [dpdk-dev] [PATCH v6 1/3] eal/linux: make hugetlbfs analysis reusable

2021-10-13 Thread David Marchand
Hello, On Mon, Oct 11, 2021 at 10:57 AM Dmitry Kozlyuk wrote: > > get_hugepage_dir() searched for a hugetlbfs mount with a given page size > using handcraft parsing of /proc/mounts and mixing traversal logic with > selecting the needed entry. Separate code to enumerate hugetlbfs mounts > to eal_h

Re: [dpdk-dev] [PATCH] examples/l2fwd: add promiscuous mode selection through command line option

2021-10-13 Thread Bruce Richardson
On Wed, Oct 13, 2021 at 12:23:03PM +0500, Sarosh Arif wrote: > The default behaviour of l2fwd is to exit if we are unable to turn > promiscuous mode on. On some aws instances turning promiscuous mode > on is not permitted. In such cases there should be a way to run the > application without promisc

Re: [dpdk-dev] [PATCH 2/5] ethdev: add capability to keep shared objects on restart

2021-10-13 Thread Dmitry Kozlyuk
This thread continues discussions on previous versions to keep everything in the thread with final patches: [1]: http://inbox.dpdk.org/dev/d5673b58-5aa6-ca35-5b60-d938e56cf...@oktetlabs.ru/ [2]: http://inbox.dpdk.org/dev/dm8pr12mb5400997ccec9169ac5ae0c89d6...@dm8pr12mb5400.namprd12.prod.outlook.

Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart

2021-10-13 Thread Dmitry Kozlyuk
Please let's continue in the thread for the latest version of the patches: http://inbox.dpdk.org/dev/ch0pr12mb5091792a77cbd1528db7a005b9...@ch0pr12mb5091.namprd12.prod.outlook.com/ Please see my comments there. > -Original Message- > From: Andrew Rybchenko > Sent: 12 октября 2021 г. 13:

Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > As stated in the API, dynamic field and flags should be created with no > additional flag (simply in the API for future changes). > > Fix the dynamic flag register helper which was not enforcing it and add > unit tests. > > Fixes: 4958ca3a443a ("mbu

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 08:04, Anoob Joseph wrote: > Hi Akhil, Ray, Thomas, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, October 13, 2021 12:32 PM >> To: Akhil Goyal ; dev@dpdk.org; Kinsella, Ray >> ; Anoob Joseph >> Cc: david

Re: [dpdk-dev] [PATCH v3 04/10] common/sfc_efx/base: add RECIRC ID match in action rules API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 01:24, Ivan Malov wrote: > Currently, there is an API for setting recirculation ID in > outer rules. Add an API to let action rules match on it. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > drivers/common/sfc_efx/base/efx.h | 13 ++ > driver

Re: [dpdk-dev] [PATCH v12 00/12] Packet capture framework update

2021-10-13 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon > > Thought they were, look like Reshma got missed. > > > > No worries about doing in 22.02 since there is no API/ABI breakage in > > the patchset. No pre-release note needed either. > > We can still merge it for 21.11 if Reshma is OK with t

Re: [dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-13 Thread Andrew Rybchenko
On 10/12/21 11:14 PM, Stephen Hemminger wrote: > On Tue, 12 Oct 2021 21:39:26 +0200 > David Marchand wrote: > >> If we do not enforce valid flags are passed by an application, this >> application might face issues in the future when we add more flags. >> >> Signed-off-by: David Marchand > > Ack

Re: [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 3:42 AM, Wang, Jie1X wrote: -Original Message- From: Yigit, Ferruh Sent: Tuesday, October 12, 2021 10:38 PM To: Wang, Jie1X ; dev@dpdk.org Cc: tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun ; Yang, SteveX Subject: Re: [PATCH v12 2/2] app/testpmd: fix te

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 22:52, Thomas Monjalon wrote: > 12/10/2021 22:34, Dumitrescu, Cristian: >> From: Thomas Monjalon >>> 01/09/2021 14:20, Jasvinder Singh: These APIs were introduced in 18.05, therefore removing experimental tag to promote them to stable state. Signed-off-by: Jasv

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 21:34, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Singh, Jasvinder >> Sent: Wednesday, September 1, 2021 1:20 PM >> To: dev@dpdk.org >> Cc: Dumitrescu, Cristian ; m...@ashroe.eu; >> Zhang, Roy Fan >> Subject: [PATCH] pipeline: remove experimental tag

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > This API was introduced in 18.08, therefore removing > experimental tag to promote it to stable state. > > Signed-off-by: Jasvinder Singh > --- > drivers/net/softnic/rte_eth_softnic.h | 1 - > drivers/net/softnic/version.map | 7 +-- > 2

Re: [dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:19, Jasvinder Singh wrote: > This API was introduced in 18.05, therefore removing > experimental tag to promote it to stable state > > Signed-off-by: Jasvinder Singh > --- > lib/sched/rte_sched.h | 4 > lib/sched/version.map | 2 +- > 2 files changed, 1 insertion(+), 5 d

[dpdk-dev] [PATCH] mempool: fix name size in mempool structure

2021-10-13 Thread Andrew Rybchenko
Use correct define as a name array size. The change breaks ABI and therefore cannot be backported to stable branches. Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") Signed-off-by: Andrew Rybchenko --- lib/mempool/rte_mempool.h | 7 +-- 1 file changed, 1 insertion(+

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 13:29, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > creat

Re: [dpdk-dev] [PATCH 3/3] ethdev: add async queue-based flow rules operations

2021-10-13 Thread Ajit Khaparde
On Tue, Oct 5, 2021 at 9:49 PM Alexander Kozyrev wrote: > > A new, faster, queue-based flow rules management mechanism is needed for > applications offloading rules inside the datapath. This asynchronous > and lockless mechanism frees the CPU for further packet processing and > reduces the perform

Re: [dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- > app/test/test_memzone.c | 24 >

Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-13 Thread Ananyev, Konstantin
Hi Kevin, AFAIK, no other action from your side is needed at the moment. Now it is up to other reviewers (if any) to have a look, and then DPDK maintainers to bring your patch in. If they will have more comments/questions about the patch - they will email you. Meanwhile, as I said before, it would

Re: [dpdk-dev] [PATCH v6 1/3] eal/linux: make hugetlbfs analysis reusable

2021-10-13 Thread Dmitry Kozlyuk
Hello, > [...] > As you probably noticed, I merged John patch. > Could you rebase this series on the main branch please? Of course. Only would you accept that for now I'll just keep the tests John has added? With the new helper, directory selection logic can be tested isolated from parsing and

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Thomas Monjalon
13/10/2021 10:51, Kinsella, Ray: > > On 12/10/2021 22:52, Thomas Monjalon wrote: > > 12/10/2021 22:34, Dumitrescu, Cristian: > >> From: Thomas Monjalon > >>> 01/09/2021 14:20, Jasvinder Singh: > These APIs were introduced in 18.05, therefore removing > experimental tag to promote them t

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:40, Thomas Monjalon wrote: > 13/10/2021 10:51, Kinsella, Ray: >> >> On 12/10/2021 22:52, Thomas Monjalon wrote: >>> 12/10/2021 22:34, Dumitrescu, Cristian: From: Thomas Monjalon > 01/09/2021 14:20, Jasvinder Singh: >> These APIs were introduced in 18.05, therefore

Re: [dpdk-dev] [PATCH v1 1/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Thomas Monjalon
13/10/2021 10:03, Serena He: > CI jobs are triggered only for repos installed with given GHApp and runners [...] > +# Here, runners for arm64 are accessed by installed GitHub APP, thus > will not be available by fork. > +# you can change the following 'if' and 'runs-on' if you have your ow

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Thomas Monjalon
13/10/2021 11:43, Kinsella, Ray: > On 13/10/2021 10:40, Thomas Monjalon wrote: > > 13/10/2021 10:51, Kinsella, Ray: > >> On 12/10/2021 22:52, Thomas Monjalon wrote: > >>> 12/10/2021 22:34, Dumitrescu, Cristian: > From: Thomas Monjalon > > 01/09/2021 14:20, Jasvinder Singh: > >> These

Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting IPv4 fragment

2021-10-13 Thread 蔡慧超
Hi,Konstantin Meanwhile, as I said before, it would be really good to add a new test-case to cover that case. It could be a new separate patch on top of current one. --Ok,I will. Kevin

Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: support PPPoL2TPv2oUDP RSS Hash

2021-10-13 Thread Wang, Jie1X
> -Original Message- > From: Ori Kam > Sent: Wednesday, October 13, 2021 5:15 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yigit, Ferruh ; NBU-Contact-Thomas Monjalon > ; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; Yang, SteveX ; Wu, Jingjing > ; Xing, Beilei ; Wu, Wenjun1 > > Subject:

Re: [dpdk-dev] [PATCH 1/2] vdpa/mlx5: workaround FW first completion in start

2021-10-13 Thread Maxime Coquelin
Hi Xueming, On 9/23/21 10:17, Xueming Li wrote: After a vDPA application restart, qemu restores VQ with used and available index, new incoming packet triggers virtio driver to handle buffers. Under heavy traffic, no available buffer for firmware to receive new packets, no Rx interrupts generated

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:49, Thomas Monjalon wrote: > 13/10/2021 11:43, Kinsella, Ray: >> On 13/10/2021 10:40, Thomas Monjalon wrote: >>> 13/10/2021 10:51, Kinsella, Ray: On 12/10/2021 22:52, Thomas Monjalon wrote: > 12/10/2021 22:34, Dumitrescu, Cristian: >> From: Thomas Monjalon >>>

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: retry VAR allocation during vDPA restart

2021-10-13 Thread Maxime Coquelin
On 9/23/21 10:17, Xueming Li wrote: VAR is the device memory space for the virtio queues doorbells, qemu could mmap it to directly to speed up doorbell push. On a busy system, Qemu takes time to release VAR resources during driver shutdown. If vdpa restarted quickly, the VAR allocation failed

Re: [dpdk-dev] [PATCH 2/2] vdpa/mlx5: retry VAR allocation during vDPA restart

2021-10-13 Thread Xueming(Steven) Li
On Wed, 2021-10-13 at 12:06 +0200, Maxime Coquelin wrote: > > On 9/23/21 10:17, Xueming Li wrote: > > VAR is the device memory space for the virtio queues doorbells, qemu > > could mmap it to directly to speed up doorbell push. > > > > On a busy system, Qemu takes time to release VAR resources du

Re: [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 9:50 AM, Ferruh Yigit wrote: On 10/13/2021 3:42 AM, Wang, Jie1X wrote: -Original Message- From: Yigit, Ferruh Sent: Tuesday, October 12, 2021 10:38 PM To: Wang, Jie1X ; dev@dpdk.org Cc: tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun ; Yang, SteveX Subj

Re: [dpdk-dev] [PATCH v6 2/3] eal: add memory pre-allocation from existing files

2021-10-13 Thread David Marchand
On Tue, Oct 12, 2021 at 11:09 PM Dmitry Kozlyuk wrote: > > From this, I see two parts in this patch: > > - faster restart, reusing hugepage files as is (combination of not calling > > unlink() and doing "clear on alloc"), > > This part is interesting, and I think a single knob for this would be

[dpdk-dev] [PATCH v4] cryptodev: add telemetry callbacks

2021-10-13 Thread Rebecca Troy
The cryptodev library now registers commands with telemetry, and implements the corresponding callback functions. These commands allow a list of cryptodevs to be queried, as well as info and stats for the corresponding cryptodev. An example usage can be seen below: Connecting to /var/run/dpdk/rte

Re: [dpdk-dev] [PATCH] net/ice/base: fix null pointer dereferences for parser

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, October 13, 2021 6:35 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org; Yigit, Ferruh ; > Guo, Junfeng > Subject: [PATCH] net/ice/base: fix null pointer dereferences for parser > > Nu

Re: [dpdk-dev] [PATCH] net/ice: fix compile failure when Rx desc size is 16

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Monday, October 11, 2021 4:36 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH] net/ice: fix compile failure when Rx desc size is 16 > > The Timestamp Overlay feature is available only in 32B Flex Desc

Re: [dpdk-dev] [PATCH v1] doc: fix typo of Intel device name

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of William Tu > Sent: Tuesday, October 12, 2021 2:56 AM > To: dev@dpdk.org > Cc: Wang, Haiyue > Subject: [dpdk-dev] [PATCH v1] doc: fix typo of Intel device name > > The device name should be 82574L Gigabit Ethernet Controller. > > Signed-off

Re: [dpdk-dev] [PATCH v3 00/10] net/sfc: add support for tunnel offload

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 1:24 AM, Ivan Malov wrote: The first 6 patches comprise the fundamental part of the series. They are trying to be future-proof with respect to the planned HW/FW changes. 4 more patches form the adaptation part of some sort to make the offload work on the currently available HW/FW.

Re: [dpdk-dev] [PATCH v3 00/10] net/sfc: add support for tunnel offload

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 1:24 AM, Ivan Malov wrote: The first 6 patches comprise the fundamental part of the series. They are trying to be future-proof with respect to the planned HW/FW changes. 4 more patches form the adaptation part of some sort to make the offload work on the currently available HW/FW.

Re: [dpdk-dev] [PATCH] net/ice: fix deadlock on flow redirect

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Monday, October 11, 2021 3:39 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix deadlock on flow redirect > > From: Dapeng Yu > > If flow redirect failed, the spinl

Re: [dpdk-dev] [PATCH v3 00/10] net/sfc: add support for tunnel offload

2021-10-13 Thread Thomas Monjalon
13/10/2021 12:45, Ferruh Yigit: > On 10/13/2021 1:24 AM, Ivan Malov wrote: > > The first 6 patches comprise the fundamental part of the series. > > They are trying to be future-proof with respect to the planned > > HW/FW changes. 4 more patches form the adaptation part of some > > sort to make the

Re: [dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable

2021-10-13 Thread Thomas Monjalon
07/10/2021 18:25, Kinsella, Ray: > > On 02/10/2021 10:40, David Marchand wrote: > > On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz wrote: > >> > >> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6 > >> header extensions skip function") (2018), and is used by vmxnet3 driver. > >>

Re: [dpdk-dev] [PATCH v4] cryptodev: add telemetry callbacks

2021-10-13 Thread Power, Ciara
>-Original Message- >From: Troy, Rebecca >Sent: Wednesday 13 October 2021 11:22 >To: dev@dpdk.org >Cc: Power, Ciara ; Zhang, Roy Fan >; Troy, Rebecca ; Akhil >Goyal ; Doherty, Declan >Subject: [PATCH v4] cryptodev: add telemetry callbacks > >The cryptodev library now registers commands wi

Re: [dpdk-dev] [PATCH] net/ice: fix freeing queues on DCF device reset

2021-10-13 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Monday, October 11, 2021 3:26 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH] net/ice: fix freeing queues on DCF device reset > > From: Dapeng Yu > > In function ice_dcf_stop_

[dpdk-dev] [PATCH v4 0/4] net/mlx5: implicit mempool registration

2021-10-13 Thread Dmitry Kozlyuk
MLX5 hardware has its internal IOMMU where PMD registers the memory. On the data path, PMD translates VA into a key consumed by the device IOMMU. It is impractical for the PMD to register all allocated memory because of increased lookup cost both in HW and SW. Most often mbuf memory comes from me

[dpdk-dev] [PATCH v4 1/4] mempool: add event callbacks

2021-10-13 Thread Dmitry Kozlyuk
Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes from mempools that can come and go. PMD can enumer

[dpdk-dev] [PATCH v4 2/4] mempool: add non-IO flag

2021-10-13 Thread Dmitry Kozlyuk
Mempool is a generic allocator that is not necessarily used for device IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark such mempools automatically if their objects are not contiguous or IOVA are not available. Components can inspect this flag in order to optimize their memor

[dpdk-dev] [PATCH v4 3/4] common/mlx5: add mempool registration facilities

2021-10-13 Thread Dmitry Kozlyuk
Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own database. Memory regions can be shared within a data

[dpdk-dev] [PATCH v4 4/4] net/mlx5: support mempool registration

2021-10-13 Thread Dmitry Kozlyuk
When the first port in a given protection domain (PD) starts, install a mempool event callback for this PD and register all existing memory regions (MR) for it. When the last port in a PD closes, remove the callback and unregister all mempools for this PD. This behavior can be switched off with a n

Re: [dpdk-dev] [v6] telemetry: remove limitation on JSON output buffer length

2021-10-13 Thread Power, Ciara
>-Original Message- >From: Gowrishankar Muthukrishnan >Sent: Monday 11 October 2021 11:55 >To: dev@dpdk.org >Cc: Richardson, Bruce ; Power, Ciara >; jer...@marvell.com; Gowrishankar Muthukrishnan > >Subject: [v6] telemetry: remove limitation on JSON output buffer length > >Earlier, JSON me

Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure

2021-10-13 Thread David Marchand
On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko wrote: > > Use correct define as a name array size. > > The change breaks ABI and therefore cannot be backported to > stable branches. > > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types") > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Bruce Richardson
On Wed, Oct 13, 2021 at 11:02:02AM +0100, Kinsella, Ray wrote: > > > On 13/10/2021 10:49, Thomas Monjalon wrote: > > 13/10/2021 11:43, Kinsella, Ray: > >> On 13/10/2021 10:40, Thomas Monjalon wrote: > >>> 13/10/2021 10:51, Kinsella, Ray: > On 12/10/2021 22:52, Thomas Monjalon wrote: > >

Re: [dpdk-dev] [PATCH] mempool: fix name size in mempool structure

2021-10-13 Thread Andrew Rybchenko
On 10/13/21 2:07 PM, David Marchand wrote: > On Wed, Oct 13, 2021 at 10:57 AM Andrew Rybchenko > wrote: >> >> Use correct define as a name array size. >> >> The change breaks ABI and therefore cannot be backported to >> stable branches. >> >> Fixes: 38c9817ee1d8 ("mempool: adjust name size in rela

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow item/action templates

2021-10-13 Thread Ivan Malov
Hi, On 13/10/2021 04:25, Alexander Kozyrev wrote: From: Ivan Malov On Wednesday, October 6, 2021 13:25 On 06/10/2021 07:48, Alexander Kozyrev wrote: Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in a

Re: [dpdk-dev] [PATCH v5] ethdev: replace bit shifts with macros

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 8:52 AM, Thomas Monjalon wrote: The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums

Re: [dpdk-dev] [PATCH v1 1/1] ci: enable DPDK GHA for arm64 with self-hosted runners

2021-10-13 Thread Michael Santana
On 10/13/21 4:03 AM, Serena He wrote: CI jobs are triggered only for repos installed with given GHApp and runners Cc: sta...@dpdk.org Signed-off-by: Serena He --- .github/workflows/build-arm64.yml | 118 ++ 1 file changed, 118 insertions(+) create mode 1006

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 12:11, Bruce Richardson wrote: > On Wed, Oct 13, 2021 at 11:02:02AM +0100, Kinsella, Ray wrote: >> >> >> On 13/10/2021 10:49, Thomas Monjalon wrote: >>> 13/10/2021 11:43, Kinsella, Ray: On 13/10/2021 10:40, Thomas Monjalon wrote: > 13/10/2021 10:51, Kinsella, Ray: >> O

[dpdk-dev] [V2] app/flow-perf: add destination ports parameter

2021-10-13 Thread Sean Zhang
Add optional destination ports parameter for port-id action. The parameter is not must, and the value is 1 by default as before if the parameter not provided. For example: $ dpdk-test-flow-perf -w 08:00.0,representor=[0,1] -- --transfer \ > --ingress --transfer --ether --portmask=0x2 --vxlan-enca

Re: [dpdk-dev] [PATCH v3 00/12] ethdev: rework transfer flow API

2021-10-13 Thread Ferruh Yigit
On 10/10/2021 3:39 PM, Ivan Malov wrote: As per RFC [1], action PORT_ID appears to be ambiguous. Its name suggests that matching traffic be sent to the ethdev with the specified ID, that is, to the application. However, in Open vSwitch, the action is used to send traffic to a remote entity repres

Re: [dpdk-dev] [PATCH v3 01/12] ethdev: add port representor item to flow API

2021-10-13 Thread Ferruh Yigit
On 10/10/2021 3:39 PM, Ivan Malov wrote: diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index 89d4b33ef1..1261cb2bf3 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -188,6 +188,8 @@ API Changes

Re: [dpdk-dev] [PATCH v4 0/6] ethdev: introduce shared Rx queue

2021-10-13 Thread Xueming(Steven) Li
On Tue, 2021-10-12 at 14:28 +0300, Andrew Rybchenko wrote: > On 10/12/21 1:55 PM, Xueming(Steven) Li wrote: > > On Tue, 2021-10-12 at 11:48 +0300, Andrew Rybchenko wrote: > > > On 10/12/21 9:37 AM, Xueming(Steven) Li wrote: > > > > On Mon, 2021-10-11 at 23:11 +0800, Xueming Li wrote: > > > > > On M

Re: [dpdk-dev] [PATCH v3 05/12] ethdev: deprecate hard-to-use or ambiguous items and actions

2021-10-13 Thread Ferruh Yigit
On 10/10/2021 3:39 PM, Ivan Malov wrote: --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -122,12 +122,6 @@ Deprecation Notices is deprecated and will be removed in DPDK 21.11. Shared counters should be managed using shared actions API (``rte_flow_s

Re: [dpdk-dev] [dpdk-stable] [Patch v2] bus/vmbus: map to the correct ring buffer addresses for the secondary process

2021-10-13 Thread Thomas Monjalon
29/09/2021 22:46, lon...@linuxonhyperv.com: > From: Long Li > > The driver code had wrong assumption that all the addresses to ring buffers > in the secondary process are the same as those in the primary process. This > is not always correct as the channels could be mapped to different > addresse

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Thomas Monjalon
13/10/2021 13:42, Kinsella, Ray: > On 13/10/2021 12:11, Bruce Richardson wrote: > > On Wed, Oct 13, 2021 at 11:02:02AM +0100, Kinsella, Ray wrote: > >> On 13/10/2021 10:49, Thomas Monjalon wrote: > >>> 13/10/2021 11:43, Kinsella, Ray: > On 13/10/2021 10:40, Thomas Monjalon wrote: > > 13/10

Re: [dpdk-dev] [PATCH] net/hns3: fix incorrect free function

2021-10-13 Thread Ferruh Yigit
On 10/13/2021 9:09 AM, Min Hu (Connor) wrote: From: Chengwen Feng The intr_handle->intr_vec is allocated by rte_zmalloc(), but freed by free(), this patch fixes it. Fixes: 02a7b55657b2 ("net/hns3: support Rx interrupt") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Reviewed-by: Ferruh Y

Re: [dpdk-dev] [PATCH v4] eventdev/rx_adapter: add telemetry callbacks

2021-10-13 Thread Naga Harish K, S V
Acked-by: Naga Harish K S V > -Original Message- > From: dev On Behalf Of Ganapati Kundapura > Sent: Wednesday, October 13, 2021 1:27 PM > To: jerinjac...@gmail.com; dev@dpdk.org > Cc: Jayatheerthan, Jay > Subject: [dpdk-dev] [PATCH v4] eventdev/rx_adapter: add telemetry > callbacks >

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-10-13 Thread Thomas Monjalon
+Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: > On 10/09/2021 08:36, David Marchand wrote: > > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: > >> On 09/09/2021 17:40, Rahul Shah wrote: > >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > >>> rte_port_

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Ferruh Yigit
On 10/12/2021 1:29 PM, Gregory Etelson wrote: RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplif

Re: [dpdk-dev] [PATCH v8 06/10] ipsec: add transmit segmentation offload support

2021-10-13 Thread Nicolau, Radu
On 10/12/2021 5:25 PM, Ananyev, Konstantin wrote: +/* check if packet will exceed MSS and segmentation is required */ +static inline int +esn_outb_nb_segments(struct rte_mbuf *m) { DPDK codying style pls. + uint16_t segments = 1; + uint16_t pkt_l3len = m->pkt_len - m->l2_len; + +

[dpdk-dev] [PATCH v9 00/10] new features for ipsec and security libraries

2021-10-13 Thread Radu Nicolau
Add support for: TSO, NAT-T/UDP encapsulation, ESN AES_CCM, CHACHA20_POLY1305 and AES_GMAC SA telemetry mbuf offload flags Initial SQN value Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Radu Nicolau (10): securit

[dpdk-dev] [PATCH v9 01/10] security: add ESN field to ipsec_xform

2021-10-13 Thread Radu Nicolau
Update ipsec_xform definition to include ESN field. This allows the application to control the ESN starting value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Anoob Joseph Acked-by:

[dpdk-dev] [PATCH v9 02/10] ipsec: add support for AEAD algorithms

2021-10-13 Thread Radu Nicolau
Add support for AES_CCM, CHACHA20_POLY1305 and AES_GMAC. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Konstantin Ananyev --- doc/guides/prog_guide/ipsec_lib.rst| 3 +- doc/guid

[dpdk-dev] [PATCH v9 03/10] security: add UDP params for IPsec NAT-T

2021-10-13 Thread Radu Nicolau
Add support for specifying UDP port params for UDP encapsulation option. RFC3948 section-2.1 does not enforce using specific the UDP ports for UDP-Encapsulated ESP Header Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley

[dpdk-dev] [PATCH v9 04/10] ipsec: add support for NAT-T

2021-10-13 Thread Radu Nicolau
Add support for the IPsec NAT-Traversal use case for Tunnel mode packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- doc/guides/prog_guide/ipsec_lib.rst| 2 ++ doc/guides/rel_notes/r

[dpdk-dev] [PATCH v9 05/10] mbuf: add IPsec ESP tunnel type

2021-10-13 Thread Radu Nicolau
Add ESP tunnel type to the tunnel types list that can be specified for TSO or checksum on the inner part of tunnel packets. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Akhil Goyal Ac

[dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-13 Thread Radu Nicolau
Add support for transmit segmentation offload to inline crypto processing mode. This offload is not supported by other offload modes, as at a minimum it requires inline crypto for IPsec to be supported on the network interface. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off

[dpdk-dev] [PATCH v9 07/10] ipsec: add support for SA telemetry

2021-10-13 Thread Radu Nicolau
Add telemetry support for ipsec SAs Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang Acked-by: Konstantin Ananyev --- doc/guides/prog_guide/ipsec_lib.rst| 7 + doc/guides/rel_notes/release_2

[dpdk-dev] [PATCH v9 08/10] ipsec: add support for initial SQN value

2021-10-13 Thread Radu Nicolau
Update IPsec library to support initial SQN value. Signed-off-by: Declan Doherty Signed-off-by: Radu Nicolau Signed-off-by: Abhijit Sinha Signed-off-by: Daniel Martin Buckley Acked-by: Fan Zhang --- doc/guides/rel_notes/release_21_11.rst | 1 + lib/ipsec/sa.c | 18 ++

[dpdk-dev] [PATCH v9 09/10] doc: remove unneeded ipsec new field deprecation

2021-10-13 Thread Radu Nicolau
The deprecation notice regarding extendig rte_ipsec_sa_prm with a new field hdr_l3_len is no longer applicable. Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/deprecation.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/

[dpdk-dev] [PATCH v9 10/10] doc: remove unneeded security deprecation

2021-10-13 Thread Radu Nicolau
The new fields regarding TSO support were not implemented following feedback, it was decided to implement TSO support by using existing mbuf fields. Signed-off-by: Radu Nicolau --- doc/guides/rel_notes/deprecation.rst | 7 --- 1 file changed, 7 deletions(-) diff --git a/doc/guides/rel_notes

[dpdk-dev] [PATCH v26 1/6] dmadev: introduce DMA device library

2021-10-13 Thread Chengwen Feng
The 'dmadev' is a generic type of DMA device. This patch introduce the 'dmadev' device allocation functions. The infrastructure is prepared to welcome drivers in drivers/dma/ Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob Reviewed-by: Ke

[dpdk-dev] [PATCH v26 2/6] dmadev: add control plane API support

2021-10-13 Thread Chengwen Feng
This patch add control plane API for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 10 + doc/guides/rel_notes/release_21_11.rst | 2 + lib/dmadev/rte_dm

[dpdk-dev] [PATCH v26 4/6] dmadev: add multi-process support

2021-10-13 Thread Chengwen Feng
This patch add multi-process support for dmadev. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Reviewed-by: Kevin Laatz Reviewed-by: Conor Walsh --- doc/guides/rel_notes/release_21_11.rst | 1 + lib/dmadev/rte_dmadev.c| 183

  1   2   3   4   5   >